View | Details | Raw Unified | Return to bug 26346
Collapse All | Expand All

(-)a/Koha/Virtualshelf.pm (-4 / +8 lines)
Lines 186-192 sub add_biblio { Link Here
186 
    return if $already_exists;
 186 
    return if $already_exists;
187 

          187
          

        

        

          188
          
    # Check permissions

          188
          
    # Check permissions

        

          
            

              189
              
    return unless ( $self->owner == $borrowernumber && $self->allow_change_from_owner ) || ( $self->allow_change_from_staff && Koha::Patrons->find( $borrowernumber )->can_patron_change_staff_only_lists ) || $self->allow_change_from_others;


              189
              
    my $patron = Koha::Patrons->find( $borrowernumber ) or return 0;

            

            

              
              

              190
              
    return 0 unless ( $self->owner == $borrowernumber && $self->allow_change_from_owner ) || ( $self->allow_change_from_staff && $patron->can_patron_change_staff_only_lists ) || $self->allow_change_from_others;

            

        

          190
          

          191
          

        

        

          191
          
    my $content = Koha::Virtualshelfcontent->new(

          192
          
    my $content = Koha::Virtualshelfcontent->new(

        

        

          192
          
        {

          193
          
        {

        

  

    
      
            Lines 208-215
          sub remove_biblios {
      
      
        Link Here
      
    
  

        

          208
          
    return unless @$biblionumbers;

          209
          
    return unless @$biblionumbers;

        

        

          209
          

          210
          

        

        

          210
          
    my $number_removed = 0;

          211
          
    my $number_removed = 0;

        

            

              
              
              212
              
    my $patron = Koha::Patrons->find( $borrowernumber ) or return 0;

            

        

          211
          
    if( ( $self->owner == $borrowernumber && $self->allow_change_from_owner )

          213
          
    if( ( $self->owner == $borrowernumber && $self->allow_change_from_owner )

        

          
            

              212
              
      || ( $self->allow_change_from_staff && Koha::Patrons->find( $borrowernumber )->can_patron_change_staff_only_lists )


              214
              
      || ( $self->allow_change_from_staff && $patron->can_patron_change_staff_only_lists )

            

        

          213
          
      || $self->allow_change_from_others ) {

          215
          
      || $self->allow_change_from_others ) {

        

        

          214
          
        $number_removed += $self->get_contents->search({

          216
          
        $number_removed += $self->get_contents->search({

        

        

          215
          
            biblionumber => $biblionumbers,

          217
          
            biblionumber => $biblionumbers,

        

  

    
      
            Lines 236-242
          sub can_be_deleted {
      
      
        Link Here
      
    
  

        

          236
          
    return 0 unless $borrowernumber;

          238
          
    return 0 unless $borrowernumber;

        

        

          237
          
    return 1 if $self->owner == $borrowernumber;

          239
          
    return 1 if $self->owner == $borrowernumber;

        

        

          238
          

          240
          

        

          
            

              239
              
    my $patron = Koha::Patrons->find( $borrowernumber );


              241
              
    my $patron = Koha::Patrons->find( $borrowernumber ) or return 0;

            

        

          240
          

          242
          

        

        

          241
          
    return 1 if $self->is_public and haspermission( $patron->userid, { lists => 'delete_public_lists' } );

          243
          
    return 1 if $self->is_public and haspermission( $patron->userid, { lists => 'delete_public_lists' } );

        

        

          242
          

          244
          

        

  

    
      
            Lines 257-265
          sub can_be_managed {
      
      
        Link Here
      
    
  

        

          257
          
sub can_biblios_be_added {

          259
          
sub can_biblios_be_added {

        

        

          258
          
    my ( $self, $borrowernumber ) = @_;

          260
          
    my ( $self, $borrowernumber ) = @_;

        

        

          259
          

          261
          

        

            

              
              
              262
              
    my $patron = Koha::Patrons->find( $borrowernumber ) or return 0;

            

        

          260
          
    return 1

          263
          
    return 1

        

        

          261
          
      if $borrowernumber

          264
          
      if $borrowernumber

        

          
            

              262
              
      and ( ( $self->owner == $borrowernumber && $self->allow_change_from_owner ) or ( $self->allow_change_from_staff && Koha::Patrons->find( $borrowernumber )->can_patron_change_staff_only_lists ) or $self->allow_change_from_others );


              265
              
      and ( ( $self->owner == $borrowernumber && $self->allow_change_from_owner ) or ( $self->allow_change_from_staff && $patron->can_patron_change_staff_only_lists ) or $self->allow_change_from_others );

            

        

          263
          
    return 0;

          266
          
    return 0;

        

        

          264
          
}

          267
          
}

        

        

          265
          

          268
          

        

  

    
      
            Lines 273-275
          sub _type {
      
      
        Link Here
      
    
  

        

          273
          
    return 'Virtualshelve';

          276
          
    return 'Virtualshelve';

        

        

          274
          
}

          277
          
}

        

        

          275
          

          278
          

        

            

              
              
              279
              
1;

            



(-)a/Koha/Virtualshelves.pm
      (-2 / +7 lines)




  

    
      
            Lines 22-28
          use Koha::Database;
      
      
        Link Here
      
    
  

        

          22
          

          22
          

        

        

          23
          
use Koha::Virtualshelf;

          23
          
use Koha::Virtualshelf;

        

        

          24
          

          24
          

        

            

              25
              
use C4::Auth;

              
              
            

        

          26
          

          25
          

        

        

          27
          
use base qw(Koha::Objects);

          26
          
use base qw(Koha::Objects);

        

        

          28
          

          27
          

        

  

    
      
            Lines 88-95
          sub get_some_shelves {
      
      
        Link Here
      
    
  

        

          88
          
    my $add_allowed = $params->{add_allowed};

          87
          
    my $add_allowed = $params->{add_allowed};

        

        

          89
          

          88
          

        

        

          90
          
    my @conditions;

          89
          
    my @conditions;

        

            

              
              
              90
              
    my $patron;

            

            

              91
              
    my $staffuser = 0;

            

            

              92
              
    if ( $borrowernumber != 0 ) {

            

            

              93
              
        $patron = Koha::Patrons->find( $borrowernumber );

            

            

              94
              
        $staffuser = $patron->can_patron_change_staff_only_lists;

            

            

              95
              
    }

            

        

          91
          
    if ( $add_allowed ) {

          96
          
    if ( $add_allowed ) {

        

          
            

              92
              
        if ( Koha::Patrons->find( $borrowernumber )->can_patron_change_staff_only_lists ) {


              97
              
        if ( $staffuser ) {

            

        

          93
          
            push @conditions, {

          98
          
            push @conditions, {

        

        

          94
          
                -or =>

          99
          
                -or =>

        

        

          95
          
                [

          100
          
                [

        



(-)a/opac/opac-shelves.pl
      (-1 / +2 lines)




  

    
      
            Lines 442-448
          if ( $op eq 'list' ) {
      
      
        Link Here
      
    
  

        

          442
          
        ),

          442
          
        ),

        

        

          443
          
    );

          443
          
    );

        

        

          444
          
}

          444
          
}

        

          
            

              445
              
my $staffuser = Koha::Patrons->find( $loggedinuser )->can_patron_change_staff_only_lists if $loggedinuser;


              445
              
my $staffuser;

            

            

              
              

              446
              
$staffuser = Koha::Patrons->find( $loggedinuser )->can_patron_change_staff_only_lists if $loggedinuser;

            

        

          446
          
$template->param(

          447
          
$template->param(

        

        

          447
          
    op       => $op,

          448
          
    op       => $op,

        

        

          448
          
    referer  => $referer,

          449
          
    referer  => $referer,

        



(-)a/t/db_dependent/Virtualshelves.t
      (-22 / +21 lines)




  

    
      
            Lines 289-305
          subtest 'Shelf permissions' => sub {
      
      
        Link Here
      
    
  

        

          289
          
        }

          289
          
        }

        

        

          290
          
    )->store;

          290
          
    )->store;

        

        

          291
          

          291
          

        

          
            

              292
              
    is( $public_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view his public list' );


              292
              
    is( $public_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view their public list' );

            

        

          293
          
    is( $public_shelf->can_be_viewed( $patron2->{borrowernumber} ), 1, 'Public list should be viewed by another staff member');

          293
          
    is( $public_shelf->can_be_viewed( $patron2->{borrowernumber} ), 1, 'Public list should be viewed by another staff member');

        

        

          294
          
    is( $public_shelf->can_be_viewed( $patron3->{borrowernumber} ), 1, 'Public list should be viewed by someone with no special permissions' );

          294
          
    is( $public_shelf->can_be_viewed( $patron3->{borrowernumber} ), 1, 'Public list should be viewed by someone with no special permissions' );

        

        

          295
          
    is( $public_shelf->can_be_viewed( $patron4->{borrowernumber} ), 1, 'Public list should be viewed by someone with the edit_public_lists sub-permission checked' );

          295
          
    is( $public_shelf->can_be_viewed( $patron4->{borrowernumber} ), 1, 'Public list should be viewed by someone with the edit_public_lists sub-permission checked' );

        

        

          296
          

          296
          

        

          
            

              297
              
    is( $public_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete his list' );


              297
              
    is( $public_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete their list' );

            

        

          298
          
    is( $public_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Public list should not be deleted by another staff member' );

          298
          
    is( $public_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Public list should not be deleted by another staff member' );

        

        

          299
          
    is( $public_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0, 'Public list should not be deleted by someone with no special permissions' );

          299
          
    is( $public_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0, 'Public list should not be deleted by someone with no special permissions' );

        

        

          300
          
    is( $public_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0, 'Public list should not be deleted by someone with the edit_public_lists sub-permission checked' );

          300
          
    is( $public_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0, 'Public list should not be deleted by someone with the edit_public_lists sub-permission checked' );

        

        

          301
          

          301
          

        

          
            

              302
              
    is( $public_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage his list' );


              302
              
    is( $public_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage their list' );

            

        

          303
          
    is( $public_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Public list should not be managed by another staff member' );

          303
          
    is( $public_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Public list should not be managed by another staff member' );

        

        

          304
          
    is( $public_shelf->can_be_managed( $patron3->{borrowernumber} ), 0, 'Public list should not be managed by someone with no special permissions' );

          304
          
    is( $public_shelf->can_be_managed( $patron3->{borrowernumber} ), 0, 'Public list should not be managed by someone with no special permissions' );

        

        

          305
          
    is( $public_shelf->can_be_managed( $patron4->{borrowernumber} ), 1, 'Public list should be managed by someone with the edit_public_lists sub-permission checked' );

          305
          
    is( $public_shelf->can_be_managed( $patron4->{borrowernumber} ), 1, 'Public list should be managed by someone with the edit_public_lists sub-permission checked' );

        

  

    
      
            Lines 317-343
          subtest 'Shelf permissions' => sub {
      
      
        Link Here
      
    
  

        

          317
          
    $public_shelf->allow_change_from_owner(1);

          317
          
    $public_shelf->allow_change_from_owner(1);

        

        

          318
          
    $public_shelf->store;

          318
          
    $public_shelf->store;

        

        

          319
          

          319
          

        

          
            

              320
              
    is( $public_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view his public list' );


              320
              
    is( $public_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view their public list' );

            

        

          321
          
    is( $public_shelf->can_be_viewed( $patron2->{borrowernumber} ), 1, 'Public list should be viewed by staff member' );

          321
          
    is( $public_shelf->can_be_viewed( $patron2->{borrowernumber} ), 1, 'Public list should be viewed by staff member' );

        

        

          322
          
    is( $public_shelf->can_be_viewed( $patron3->{borrowernumber} ), 1, 'Public list should be viewed by someone with no special permissions' );

          322
          
    is( $public_shelf->can_be_viewed( $patron3->{borrowernumber} ), 1, 'Public list should be viewed by someone with no special permissions' );

        

        

          323
          
    is( $public_shelf->can_be_viewed( $patron4->{borrowernumber} ), 1, 'Public list should be viewable by someone with the edit_public_lists sub-permission checked' );

          323
          
    is( $public_shelf->can_be_viewed( $patron4->{borrowernumber} ), 1, 'Public list should be viewable by someone with the edit_public_lists sub-permission checked' );

        

        

          324
          

          324
          

        

          
            

              325
              
    is( $public_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete his list' );


              325
              
    is( $public_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete their list' );

            

        

          326
          
    is( $public_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Public list should not be deleted by another staff member' );

          326
          
    is( $public_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Public list should not be deleted by another staff member' );

        

        

          327
          
    is( $public_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0, 'Public list should not be deleted by someone with no special permissions' );

          327
          
    is( $public_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0, 'Public list should not be deleted by someone with no special permissions' );

        

        

          328
          
    is( $public_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0, 'Public list should not be deleted by someone with the edit_public_lists sub-permission checked' );

          328
          
    is( $public_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0, 'Public list should not be deleted by someone with the edit_public_lists sub-permission checked' );

        

        

          329
          

          329
          

        

          
            

              330
              
    is( $public_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage his list' );


              330
              
    is( $public_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage thier list' );

            

        

          331
          
    is( $public_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Public list should not be managed by another staff member' );

          331
          
    is( $public_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Public list should not be managed by another staff member' );

        

        

          332
          
    is( $public_shelf->can_be_managed( $patron3->{borrowernumber} ), 0, 'Public list should not be managed by someone with no special permissions' );

          332
          
    is( $public_shelf->can_be_managed( $patron3->{borrowernumber} ), 0, 'Public list should not be managed by someone with no special permissions' );

        

        

          333
          
    is( $public_shelf->can_be_managed( $patron4->{borrowernumber} ), 1, 'Public list should be managed by someone with the edit_public_lists sub-permission checked' );

          333
          
    is( $public_shelf->can_be_managed( $patron4->{borrowernumber} ), 1, 'Public list should be managed by someone with the edit_public_lists sub-permission checked' );

        

        

          334
          

          334
          

        

          
            

              335
              
    is( $public_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 1, 'The owner should be able to add biblios to his list' );


              335
              
    is( $public_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 1, 'The owner should be able to add biblios to their list' );

            

        

          336
          
    is( $public_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 0, 'Public list should not be modified (add) by another staff member' );

          336
          
    is( $public_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 0, 'Public list should not be modified (add) by another staff member' );

        

        

          337
          
    is( $public_shelf->can_biblios_be_added( $patron3->{borrowernumber} ), 0, 'Public list should not be modified (add) by someone with no special permissions' );

          337
          
    is( $public_shelf->can_biblios_be_added( $patron3->{borrowernumber} ), 0, 'Public list should not be modified (add) by someone with no special permissions' );

        

        

          338
          
    is( $public_shelf->can_biblios_be_added( $patron4->{borrowernumber} ), 0, 'Public list should not be modified (add) by someone with the edit_public_lists sub-permission checked' );

          338
          
    is( $public_shelf->can_biblios_be_added( $patron4->{borrowernumber} ), 0, 'Public list should not be modified (add) by someone with the edit_public_lists sub-permission checked' );

        

        

          339
          

          339
          

        

          
            

              340
              
    is( $public_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 1, 'The owner should be able to remove biblios to his list' );


              340
              
    is( $public_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 1, 'The owner should be able to remove biblios to their list' );

            

        

          341
          
    is( $public_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 0, 'Public list should not be modified (remove) by another staff member' );

          341
          
    is( $public_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 0, 'Public list should not be modified (remove) by another staff member' );

        

        

          342
          
    is( $public_shelf->can_biblios_be_removed( $patron3->{borrowernumber} ), 0, 'Public list should not be modified (remove) by someone with no special permissions' );

          342
          
    is( $public_shelf->can_biblios_be_removed( $patron3->{borrowernumber} ), 0, 'Public list should not be modified (remove) by someone with no special permissions' );

        

        

          343
          
    is( $public_shelf->can_biblios_be_removed( $patron4->{borrowernumber} ), 0, 'Public list should not be modified (remove) by someone with the edit_public_list sub-permission checked' );

          343
          
    is( $public_shelf->can_biblios_be_removed( $patron4->{borrowernumber} ), 0, 'Public list should not be modified (remove) by someone with the edit_public_list sub-permission checked' );

        

  

    
      
            Lines 352-368
          subtest 'Shelf permissions' => sub {
      
      
        Link Here
      
    
  

        

          352
          
        }

          352
          
        }

        

        

          353
          
    )->store;

          353
          
    )->store;

        

        

          354
          

          354
          

        

          
            

              355
              
    is( $private_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view his list' );


              355
              
    is( $private_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view their list' );

            

        

          356
          
    is( $private_shelf->can_be_viewed( $patron2->{borrowernumber} ), 0, 'Private list should not be viewed by another staff member' );

          356
          
    is( $private_shelf->can_be_viewed( $patron2->{borrowernumber} ), 0, 'Private list should not be viewed by another staff member' );

        

        

          357
          
    is( $private_shelf->can_be_viewed( $patron3->{borrowernumber} ), 0, 'Private list should not be viewed by someone with no special permissions' );

          357
          
    is( $private_shelf->can_be_viewed( $patron3->{borrowernumber} ), 0, 'Private list should not be viewed by someone with no special permissions' );

        

        

          358
          
    is( $private_shelf->can_be_viewed( $patron4->{borrowernumber} ), 0, 'Private list should not be viewed by someone with the edit_public_lists sub-permission checked' );

          358
          
    is( $private_shelf->can_be_viewed( $patron4->{borrowernumber} ), 0, 'Private list should not be viewed by someone with the edit_public_lists sub-permission checked' );

        

        

          359
          

          359
          

        

          
            

              360
              
    is( $private_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete his list' );


              360
              
    is( $private_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete their list' );

            

        

          361
          
    is( $private_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Private list should not be deleted by another staff member' );

          361
          
    is( $private_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Private list should not be deleted by another staff member' );

        

        

          362
          
    is( $private_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0, 'Private list should not be deleted by someone with no special permissions' );

          362
          
    is( $private_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0, 'Private list should not be deleted by someone with no special permissions' );

        

        

          363
          
    is( $private_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0, 'Private list should not be deleted by someone with the edit_public_lists sub-permission checked' );

          363
          
    is( $private_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0, 'Private list should not be deleted by someone with the edit_public_lists sub-permission checked' );

        

        

          364
          

          364
          

        

          
            

              365
              
    is( $private_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage his list' );


              365
              
    is( $private_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage their list' );

            

        

          366
          
    is( $private_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Private list should not be managed by another staff member' );

          366
          
    is( $private_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Private list should not be managed by another staff member' );

        

        

          367
          
    is( $private_shelf->can_be_managed( $patron3->{borrowernumber} ), 0, 'Private list should not be managed by someone with no special permissions' );

          367
          
    is( $private_shelf->can_be_managed( $patron3->{borrowernumber} ), 0, 'Private list should not be managed by someone with no special permissions' );

        

        

          368
          
    is( $private_shelf->can_be_managed( $patron4->{borrowernumber} ), 0, 'Private list should not be managed by someone with the edit_public_lists sub-permission checked' );

          368
          
    is( $private_shelf->can_be_managed( $patron4->{borrowernumber} ), 0, 'Private list should not be managed by someone with the edit_public_lists sub-permission checked' );

        

  

    
      
            Lines 381-407
          subtest 'Shelf permissions' => sub {
      
      
        Link Here
      
    
  

        

          381
          
    $private_shelf->allow_change_from_staff(1);

          381
          
    $private_shelf->allow_change_from_staff(1);

        

        

          382
          
    $private_shelf->allow_change_from_others(0);

          382
          
    $private_shelf->allow_change_from_others(0);

        

        

          383
          
    $private_shelf->store;

          383
          
    $private_shelf->store;

        

          
            

              384
              
    is( $private_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view his list' );


              384
              
    is( $private_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view their list' );

            

        

          385
          
    is( $private_shelf->can_be_viewed( $patron2->{borrowernumber} ), 0, 'Private list should not be viewed by another staff member' );

          385
          
    is( $private_shelf->can_be_viewed( $patron2->{borrowernumber} ), 0, 'Private list should not be viewed by another staff member' );

        

        

          386
          
    is( $private_shelf->can_be_viewed( $patron3->{borrowernumber} ), 0, 'Private list should not be viewed by someone with no special permissions' );

          386
          
    is( $private_shelf->can_be_viewed( $patron3->{borrowernumber} ), 0, 'Private list should not be viewed by someone with no special permissions' );

        

        

          387
          
    is( $private_shelf->can_be_viewed( $patron4->{borrowernumber} ), 0, 'Private list should not be viewed by someone with the edit_public_lists sub-permission checked' );

          387
          
    is( $private_shelf->can_be_viewed( $patron4->{borrowernumber} ), 0, 'Private list should not be viewed by someone with the edit_public_lists sub-permission checked' );

        

        

          388
          

          388
          

        

          
            

              389
              
    is( $private_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete his list' );


              389
              
    is( $private_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete their list' );

            

        

          390
          
    is( $private_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Private list should not be deleted by another staff member' );

          390
          
    is( $private_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Private list should not be deleted by another staff member' );

        

        

          391
          
    is( $private_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0, 'Private list should not be deleted by someone with no special permissions' );

          391
          
    is( $private_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0, 'Private list should not be deleted by someone with no special permissions' );

        

        

          392
          
    is( $private_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0, 'Private list should not be deleted by someone with the edit_public_lists sub-permission checked' );

          392
          
    is( $private_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0, 'Private list should not be deleted by someone with the edit_public_lists sub-permission checked' );

        

        

          393
          

          393
          

        

          
            

              394
              
    is( $private_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage his list' );


              394
              
    is( $private_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage their list' );

            

        

          395
          
    is( $private_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Private list should not be managed by another staff member' );

          395
          
    is( $private_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Private list should not be managed by another staff member' );

        

        

          396
          
    is( $private_shelf->can_be_managed( $patron3->{borrowernumber} ), 0, 'Private list should not be managed by someone with no special permissions' );

          396
          
    is( $private_shelf->can_be_managed( $patron3->{borrowernumber} ), 0, 'Private list should not be managed by someone with no special permissions' );

        

        

          397
          
    is( $private_shelf->can_be_managed( $patron4->{borrowernumber} ), 0, 'Private list should not be managed by someone with the edit_public_lists sub-permission checked' );

          397
          
    is( $private_shelf->can_be_managed( $patron4->{borrowernumber} ), 0, 'Private list should not be managed by someone with the edit_public_lists sub-permission checked' );

        

        

          398
          

          398
          

        

          
            

              399
              
    is( $private_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 1, 'The owner should be able to add biblios to his list' );


              399
              
    is( $private_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 1, 'The owner should be able to add biblios to their list' );

            

        

          400
          
    is( $private_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 1, 'Private list should not modified (add) by another staff member # individual check done later' );

          400
          
    is( $private_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 1, 'Private list should not modified (add) by another staff member # individual check done later' );

        

        

          401
          
    is( $private_shelf->can_biblios_be_added( $patron3->{borrowernumber} ), 0, 'Private list should not be modified (add) by someone with no special permissions' );

          401
          
    is( $private_shelf->can_biblios_be_added( $patron3->{borrowernumber} ), 0, 'Private list should not be modified (add) by someone with no special permissions' );

        

        

          402
          
    is ( $private_shelf->can_biblios_be_added( $patron4->{borrowernumber} ), 0, 'Private list should not be modified (add) by someone with the edit_public_lists sub-permission checked' );

          402
          
    is ( $private_shelf->can_biblios_be_added( $patron4->{borrowernumber} ), 0, 'Private list should not be modified (add) by someone with the edit_public_lists sub-permission checked' );

        

        

          403
          

          403
          

        

          
            

              404
              
    is( $private_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 1, 'The owner should be able to remove biblios to his list' );


              404
              
    is( $private_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 1, 'The owner should be able to remove biblios to their list' );

            

        

          405
          
    is( $private_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 1, 'Private list should be modified (remove) by another staff member # individual check done later' );

          405
          
    is( $private_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 1, 'Private list should be modified (remove) by another staff member # individual check done later' );

        

        

          406
          
    is( $private_shelf->can_biblios_be_removed( $patron3->{borrowernumber} ), 0, 'Private list should not be modified (remove) by someone with no special permissions' );

          406
          
    is( $private_shelf->can_biblios_be_removed( $patron3->{borrowernumber} ), 0, 'Private list should not be modified (remove) by someone with no special permissions' );

        

        

          407
          
    is( $private_shelf->can_biblios_be_removed( $patron4->{borrowernumber} ), 0, 'Private list should not be modified (remove) by someone with the edit_public_lists sub-permission checked' );

          407
          
    is( $private_shelf->can_biblios_be_removed( $patron4->{borrowernumber} ), 0, 'Private list should not be modified (remove) by someone with the edit_public_lists sub-permission checked' );

        

  

    
      
            Lines 410-436
          subtest 'Shelf permissions' => sub {
      
      
        Link Here
      
    
  

        

          410
          
    $private_shelf->allow_change_from_others(1);

          410
          
    $private_shelf->allow_change_from_others(1);

        

        

          411
          
    $private_shelf->store;

          411
          
    $private_shelf->store;

        

        

          412
          

          412
          

        

          
            

              413
              
    is( $private_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view his list' );


              413
              
    is( $private_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view their list' );

            

        

          414
          
    is( $private_shelf->can_be_viewed( $patron2->{borrowernumber} ), 0, 'Private list should not be viewed by another staff member' );

          414
          
    is( $private_shelf->can_be_viewed( $patron2->{borrowernumber} ), 0, 'Private list should not be viewed by another staff member' );

        

        

          415
          
    is( $private_shelf->can_be_viewed( $patron3->{borrowernumber} ), 0, 'Private list should not be viewed by someone with no special permissions' );

          415
          
    is( $private_shelf->can_be_viewed( $patron3->{borrowernumber} ), 0, 'Private list should not be viewed by someone with no special permissions' );

        

        

          416
          
    is( $private_shelf->can_be_viewed( $patron4->{borrowernumber} ), 0, 'Private list should not be viewed by someone with the edit_public_lists sub-permission checked' );

          416
          
    is( $private_shelf->can_be_viewed( $patron4->{borrowernumber} ), 0, 'Private list should not be viewed by someone with the edit_public_lists sub-permission checked' );

        

        

          417
          

          417
          

        

          
            

              418
              
    is( $private_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete his list' );


              418
              
    is( $private_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete their list' );

            

        

          419
          
    is( $private_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Private list should not be deleted by another staff member' );

          419
          
    is( $private_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Private list should not be deleted by another staff member' );

        

        

          420
          
    is( $private_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0, 'Private list should not be deleted by someone with no special permissions' );

          420
          
    is( $private_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0, 'Private list should not be deleted by someone with no special permissions' );

        

        

          421
          
    is( $private_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0, 'Private list should not be deleted by someone with the edit_public_lists sub-permission checked' );

          421
          
    is( $private_shelf->can_be_deleted( $patron4->{borrowernumber} ), 0, 'Private list should not be deleted by someone with the edit_public_lists sub-permission checked' );

        

        

          422
          

          422
          

        

          
            

              423
              
    is( $private_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage his list' );


              423
              
    is( $private_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage their list' );

            

        

          424
          
    is( $private_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Private list should not be managed by another staff member' );

          424
          
    is( $private_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Private list should not be managed by another staff member' );

        

        

          425
          
    is( $private_shelf->can_be_managed( $patron3->{borrowernumber} ), 0, 'Private list should not be managed by someone with no special permissions' );

          425
          
    is( $private_shelf->can_be_managed( $patron3->{borrowernumber} ), 0, 'Private list should not be managed by someone with no special permissions' );

        

        

          426
          
    is( $private_shelf->can_be_managed( $patron4->{borrowernumber} ), 0, 'Private list should not be managed by someone with the edit_public_lists sub-permission checked' );

          426
          
    is( $private_shelf->can_be_managed( $patron4->{borrowernumber} ), 0, 'Private list should not be managed by someone with the edit_public_lists sub-permission checked' );

        

        

          427
          

          427
          

        

          
            

              428
              
    is( $private_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 1, 'The owner should be able to add biblios to his list' );


              428
              
    is( $private_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 1, 'The owner should be able to add biblios to their list' );

            

        

          429
          
    is( $private_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 1, 'Private list could be modified (add) by another staff member # individual check done later' );

          429
          
    is( $private_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 1, 'Private list could be modified (add) by another staff member # individual check done later' );

        

        

          430
          
    is( $private_shelf->can_biblios_be_added( $patron3->{borrowernumber} ), 1, 'Private list could be modified (add) by someone with no special permissions' );

          430
          
    is( $private_shelf->can_biblios_be_added( $patron3->{borrowernumber} ), 1, 'Private list could be modified (add) by someone with no special permissions' );

        

        

          431
          
    is( $private_shelf->can_biblios_be_added( $patron4->{borrowernumber} ), 1, 'Private list could be modified (add) by someone with the edit_public_lists sub-permission checked' );

          431
          
    is( $private_shelf->can_biblios_be_added( $patron4->{borrowernumber} ), 1, 'Private list could be modified (add) by someone with the edit_public_lists sub-permission checked' );

        

        

          432
          

          432
          

        

          
            

              433
              
    is( $private_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 1, 'The owner should be able to remove biblios to his list' );


              433
              
    is( $private_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 1, 'The owner should be able to remove biblios to their list' );

            

        

          434
          
    is( $private_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 1, 'Private list could be modified (remove) by another staff member # individual check done later' );

          434
          
    is( $private_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 1, 'Private list could be modified (remove) by another staff member # individual check done later' );

        

        

          435
          
    is( $private_shelf->can_biblios_be_removed( $patron3->{borrowernumber} ), 1, 'Private list could be modified (remove) by someone with no special permissions' );

          435
          
    is( $private_shelf->can_biblios_be_removed( $patron3->{borrowernumber} ), 1, 'Private list could be modified (remove) by someone with no special permissions' );

        

        

          436
          
    is( $private_shelf->can_biblios_be_removed( $patron4->{borrowernumber} ), 1, 'Private list could be modified (remove) by someone with the edit_public_lists sub-permission checked' );

          436
          
    is( $private_shelf->can_biblios_be_removed( $patron4->{borrowernumber} ), 1, 'Private list could be modified (remove) by someone with the edit_public_lists sub-permission checked' );

        

            

              437
              
- 

              
              
            






  

  Return to bug 26346