Attachment #129431 for bug #29878

View | Details | Raw Unified | Return to bug 29878
Collapse All | Expand All

Lines 720-726 It also accounts for the "item-level_itypes" system preference. Link Here

(-)a/catalogue/search.pl (-1 / +1 lines)
720	sub prepare_adv_search_types {	720	sub prepare_adv_search_types {
721	my ($types) = @_;	721	my ($types) = @_;
722		722
723	my @advanced_search_types = split( /\\|/, $types );	723	my @advanced_search_types = split( /\,/, $types );
724		724
725	# the index parameter is different for item-level itemtypes	725	# the index parameter is different for item-level itemtypes
726	my $itype_or_itemtype =	726	my $itype_or_itemtype =




use Modern::Perl;

return {
    bug_number => "29878",
    description => "Use multiple select for AdvancedSearchTypes system preference",
    up => sub {
        my ($args) = @_;
        my $dbh = $args->{dbh};

        $dbh->do(q{
            UPDATE systempreferences SET value = REPLACE(value, '|', ',')
            WHERE variable IN ('AdvancedSearchTypes')
        });
    },
}

Lines 96-106 Searching: Link Here

(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref (-4 / +6 lines)
96	0: "Don't add"	96	0: "Don't add"
97	- search history of the unlogged user to the next patron logging in.	97	- search history of the unlogged user to the next patron logging in.
98	-	98	-
99	- Show tabs in the OPAC and staff interface advanced search for limiting searches on the	99	- Show tabs in the OPAC and staff interface advanced search for limiting searches by
100	- pref: AdvancedSearchTypes	100	- pref: AdvancedSearchTypes
101	class: long	101	multiple:
102	- "fields (separate values with \|). Tabs appear in the order listed.<br/>"	102	itemtypes: Item type
103	- "<em>Currently supported values</em>: Item types (<strong>itemtypes</strong>), Collection Codes (<strong>ccode</strong>) and Shelving Location (<strong>loc</strong>)."	103	ccode: Collection
		104	loc: Shelving location
		105	- "Tabs appear in the order listed.<br/>"
104	-	106	-
105	- Limit the languages listed in the advanced search drop-down to the	107	- Limit the languages listed in the advanced search drop-down to the
106	- pref: AdvancedSearchLanguages	108	- pref: AdvancedSearchLanguages

Lines 240-246 my $itype_or_itemtype = (C4::Context->preference("item-level_itypes"))?'itype':' Link Here

(-)a/opac/opac-search.pl (-2 / +1 lines)
240	my @advancedsearchesloop;	240	my @advancedsearchesloop;
241	my $cnt;	241	my $cnt;
242	my $advanced_search_types = C4::Context->preference("AdvancedSearchTypes") \|\| "itemtypes";	242	my $advanced_search_types = C4::Context->preference("AdvancedSearchTypes") \|\| "itemtypes";
243	my @advanced_search_types = split(/\\|/, $advanced_search_types);	243	my @advanced_search_types = split(/\,/, $advanced_search_types);
244		244
245	my $hidingrules = C4::Context->yaml_preference('OpacHiddenItems') // {};	245	my $hidingrules = C4::Context->yaml_preference('OpacHiddenItems') // {};
246		246
247	-

Return to bug 29878

Line 0 Link Here

(-)a/installer/data/mysql/atomicupdate/bug-29878.pl (+15 lines)
	1	use Modern::Perl;
	2
	3	return {
	4	bug_number => "29878",
	5	description => "Use multiple select for AdvancedSearchTypes system preference",
	6	up => sub {
	7	my ($args) = @_;
	8	my $dbh = $args->{dbh};
	9
	10	$dbh->do(q{
	11	UPDATE systempreferences SET value = REPLACE(value, '\|', ',')
	12	WHERE variable IN ('AdvancedSearchTypes')
	13	});
	14	},
	15	}