Attachment #129548 for bug #29809

View | Details | Raw Unified | Return to bug 29809
Collapse All | Expand All




    return 'Stockrotationitem';
}

=head3 item

  my $item = Koha::StockRotationItem->item;

Returns the item associated with the current stock rotation item.

=cut

sub item {
    my ( $self ) = @_;
    my $rs = $self->_result->itemnumber;
    return Koha::Item->_new_from_dbic( $rs );


sub needs_repatriating {
    my ( $self ) = @_;
    my ( $item, $stage ) = ( $self->item, $self->stage );
    if ( $self->item->get_transfer ) {
        return 0;               # We're in transit.
    } elsif ( $item->holdingbranch ne $stage->branchcode_id
                  || $item->homebranch ne $stage->branchcode_id ) {


sub needs_advancing {
    my ( $self ) = @_;
    return 0 if $self->item->get_transfer; # intransfer: don't advance.
    return 1 if $self->fresh;                    # Just on rota: advance.
    my $completed = $self->item->_result->branchtransfers->search(
        { 'reason' => "StockrotationAdvance" },
        { order_by => { -desc => 'datearrived' } }
    );

            return 0;
        }
    } else {
        warn "We have no historical branch transfer for item " . $self->item->itemnumber . "; This should not have happened!";
    }
}



    # Create the transfer.
    my $transfer = try {
        $self->item->request_transfer(
            {
                to            => $self->stage->branchcode,
                reason        => "StockrotationRepatriation",

    };

    # Ensure the homebranch is still in sync with the rota stage
    $self->item->homebranch( $self->stage->branchcode_id )->store;

    return defined($transfer) ? 1 : 0;
}


sub advance {
    my ($self)         = @_;
    my $item           = $self->item;
    my $current_branch = $item->holdingbranch;
    my $transfer;



    # Cancel 'StockrotationAdvance' transfer if one is in progress
    if ($new_indemand) {
        my $item = $self->item;
        my $transfer = $item->get_transfer;
        if ($transfer && $transfer->reason eq 'StockrotationAdvance') {
            my $stage = $self->stage;

sub investigate {
    my ( $self ) = @_;
    my $item_report = {
        title      => $self->item->_result->biblioitem
            ->biblionumber->title,
        author     => $self->item->_result->biblioitem
            ->biblionumber->author,
        callnumber => $self->item->itemcallnumber,
        location   => $self->item->location,
        onloan     => $self->item->onloan,
        barcode    => $self->item->barcode,
        itemnumber => $self->itemnumber_id,
        branch => $self->item->_result->holdingbranch,
        object => $self,
    };
    my $reason;




    );

    # Relationship to rota
    isa_ok( $sritem->item, 'Koha::Item', "Fetched related item." );
    is( $sritem->item->itemnumber, $itm->itemnumber, "Related rota OK." );

    # Relationship to stage
    isa_ok( $sritem->stage, 'Koha::StockRotationStage', "Fetched related stage." );

        }
    );
    my $dbitem = Koha::StockRotationItems->find($sritem->{itemnumber_id});
    $dbitem->item->homebranch($dbitem->stage->branchcode_id);
    $dbitem->item->holdingbranch($dbitem->stage->branchcode_id);
    $dbitem->stage->position(1);

    my $dbrota = $dbitem->stage->rota;

    );

    my $branch = $builder->build({ source => 'Branch' });
    $dbitem->item->holdingbranch($branch->{branchcode});

    # - homebranch != holdingbranch [1]
    is(

    );

    # Set to incorrect homebranch.
    $dbitem->item->holdingbranch($dbitem->stage->branchcode_id);
    $dbitem->item->homebranch($branch->{branchcode});
    # - homebranch != stockrotationstage.branch & not in transit [1]
    is(
        $dbitem->needs_repatriating, 1,

            }
        }
    );
    my $item_id = $sritem_1->item->itemnumber;
    my $srstage_1 = $sritem_1->stage;
    $sritem_1->discard_changes;
    $sritem_1->stage->position(1);
    $sritem_1->stage->duration(50);
    my $branch = $builder->build({ source => 'Branch' });
    $sritem_1->item->holdingbranch($branch->{branchcode});

    # Test a straight up repatriate
    ok($sritem_1->repatriate, "Repatriation done.");
    my $intransfer = $sritem_1->item->get_transfer;
    is($intransfer->frombranch, $branch->{branchcode}, "Origin correct.");
    is($intransfer->tobranch, $sritem_1->stage->branchcode_id, "Target Correct.");

    # Reset
    $intransfer->datearrived(dt_from_string())->store;
    $sritem_1->item->holdingbranch($branch->{branchcode});

    # Setup a conflicting manual transfer
    my $item = Koha::Items->find($item_id);


    # Reset
    $intransfer->datearrived(dt_from_string())->store;
    $sritem_1->item->holdingbranch($branch->{branchcode});

    # Confirm that stockrotation ignores transfer limits
    t::lib::Mocks::mock_preference('UseBranchTransferLimits', 1);

        {
            fromBranch => $branch->{branchcode},
            toBranch   => $srstage_1->branchcode_id,
            itemtype   => $sritem_1->item->effective_itemtype,
        }
    )->store;

    # Stockrotation should overrule transfer limits
    ok($sritem_1->repatriate, "Repatriation done regardless of transfer limits.");
    $intransfer = $sritem_1->item->get_transfer;
    is($intransfer->frombranch, $branch->{branchcode}, "Origin correct.");
    is($intransfer->tobranch, $sritem_1->stage->branchcode_id, "Target Correct.");


        }
    );
    $dbitem = Koha::StockRotationItems->find($sritem->{itemnumber_id});
    $dbitem->item->homebranch($dbitem->stage->branchcode_id);
    $dbitem->item->holdingbranch($dbitem->stage->branchcode_id);
    $dbitem->stage->position(1);
    $dbitem->stage->duration(50);


    )->store;
    is($dbitem->needs_advancing, 1, "Ready to be advanced.");
    $dbtransfer->delete;
    warning_is {$dbitem->needs_advancing} "We have no historical branch transfer for itemnumber " . $dbitem->item->itemnumber . "; This should not have happened!", "Missing transfer is warned.";

    $schema->storage->txn_rollback;
};

        }
    );
    $sritem_1->discard_changes;
    $sritem_1->item->holdingbranch($sritem_1->stage->branchcode_id);
    my $item_id = $sritem_1->item->itemnumber;
    my $srstage_1 = $sritem_1->stage;
    $srstage_1->position(1)->duration(50)->store; # Configure stage.
    # Configure item
    $sritem_1->item->holdingbranch($srstage_1->branchcode_id)->store;
    $sritem_1->item->homebranch($srstage_1->branchcode_id)->store;
    # Sanity check
    is($sritem_1->stage->stage_id, $srstage_1->stage_id, "Stage sanity check.");


    ## Test results
    is($sritem_1->stage->stage_id, $srstage_2->stage_id, "Stage updated.");
    is(
        $sritem_1->item->homebranch,
        $srstage_2->branchcode_id,
        "Item homebranch updated"
    );
    my $transfer_request = $sritem_1->item->get_transfer;
    is($transfer_request->frombranch, $srstage_1->branchcode_id, "Origin correct.");
    is($transfer_request->tobranch, $srstage_2->branchcode_id, "Target Correct.");
    is($transfer_request->datesent, undef, "Transfer requested, but not sent.");

    # Arrive at new branch
    $transfer_request->datearrived(dt_from_string())->store;
    $sritem_1->item->holdingbranch($srstage_2->branchcode_id)->store;

    # Test a cyclical advance
    ok($sritem_1->advance, "Cyclical advancement done.");

    ## Test results
    is($sritem_1->stage->stage_id, $srstage_1->stage_id, "Stage updated.");
    is(
        $sritem_1->item->homebranch,
        $srstage_1->branchcode_id,
        "Item homebranch updated"
    );
    $transfer_request = $sritem_1->item->get_transfer;
    is($transfer_request->frombranch, $srstage_2->branchcode_id, "Origin correct.");
    is($transfer_request->tobranch, $srstage_1->branchcode_id, "Target correct.");

    # Arrive at new branch
    $transfer_request->datearrived(dt_from_string())->store;
    $sritem_1->item->holdingbranch($srstage_1->branchcode_id)->store;

    # Confirm that stockrotation ignores transfer limits
    t::lib::Mocks::mock_preference('UseBranchTransferLimits', 1);

        {
            fromBranch => $srstage_1->branchcode_id,
            toBranch   => $srstage_2->branchcode_id,
            itemtype   => $sritem_1->item->effective_itemtype,
        }
    )->store;


    ## Test results
    is($sritem_1->stage->stage_id, $srstage_2->stage_id, "Stage updated ignoring transfer limits.");
    is(
        $sritem_1->item->homebranch,
        $srstage_2->branchcode_id,
        "Item homebranch updated ignoring transfer limits"
    );
    $transfer_request = $sritem_1->item->get_transfer;
    is($transfer_request->frombranch, $srstage_1->branchcode_id, "Origin correct ignoring transfer limits.");
    is($transfer_request->tobranch, $srstage_2->branchcode_id, "Target correct ignoring transfer limits.");

    # Arrive at new branch
    $transfer_request->datearrived(dt_from_string())->store;
    $sritem_1->item->holdingbranch($srstage_2->branchcode_id)->store;

    # Setup a conflicting manual transfer
    my $item = Koha::Items->find($item_id);

    isnt($transfer_request->datecancelled, undef, "Conflicting manual transfer was cancelled");

    # StockRotationAdvance transfer added
    $transfer_request = $sritem_1->item->get_transfer;
    is($transfer_request->reason, 'StockrotationAdvance', "StockrotationAdvance transfer added");
    is($transfer_request->frombranch, $srstage_2->branchcode_id, "Origin correct.");
    is($transfer_request->tobranch, $srstage_1->branchcode_id, "Target correct.");

    # Arrive at new branch
    $transfer_request->datearrived(dt_from_string())->store;
    $sritem_1->item->holdingbranch($srstage_1->branchcode_id)->store;

    # Setup a conflicting reserve transfer
    $item->request_transfer({ to => $srstage_2->branchcode, reason => "Reserve" });

    # StockRotationAdvance transfer added
    my $transfer_requests = Koha::Item::Transfers->search(
        {
            itemnumber    => $sritem_1->item->itemnumber,
            datearrived   => undef,
            datecancelled => undef
        }


    # Arrive at new branch
    $transfer_request->datearrived(dt_from_string())->store;
    $sritem_1->item->holdingbranch($srstage_2->branchcode_id)->store;

    # StockRotationAdvance transfer added
    $transfer_request = $sritem_1->item->get_transfer;
    is($transfer_request->reason, 'StockrotationAdvance', "StockrotationAdvance transfer remains after reserve is met");
    is($transfer_request->frombranch, $srstage_1->branchcode_id, "Origin correct.");
    is($transfer_request->tobranch, $srstage_2->branchcode_id, "Target correct.");

    # Arrive at new branch
    $transfer_request->datearrived(dt_from_string())->store;
    $sritem_1->item->holdingbranch($srstage_2->branchcode_id)->store;

    # Checked out item, advanced to next stage, checkedout from next stage
    # transfer should be generated, but not initiated


    # Arrive at new branch
    $transfer_request->datearrived(dt_from_string())->store;
    $sritem_1->item->holdingbranch($srstage_3->branchcode_id)->store;

    # Advance again, Remove from rota.
    ok($sritem_1->advance, "Non-cyclical advance.");

        }
    );
    $dbitem = Koha::StockRotationItems->find($sritem->{itemnumber_id});
    $dbitem->item->homebranch($dbitem->stage->branchcode_id)->store;
    $dbitem->item->holdingbranch($dbitem->stage->branchcode_id)->store;
    is($dbitem->investigate->{reason}, 'initiation', "fresh item at stagebranch initiates.");

    # Test item not at stagebranch with branchtransfer history ['repatriation']

    $dbitem = Koha::StockRotationItems->find($sritem->{itemnumber_id});
    my $dbtransfer = Koha::Item::Transfer->new({
        'itemnumber'  => $dbitem->itemnumber_id,
        'frombranch'  => $dbitem->item->homebranch,
        'tobranch'    => $dbitem->item->homebranch,
        'datesent'    => dt_from_string(),
        'datearrived' => dt_from_string(),
        'reason'      => "StockrotationAdvance",

    $dbitem = Koha::StockRotationItems->find($sritem->{itemnumber_id});
    $dbtransfer = Koha::Item::Transfer->new({
        'itemnumber'  => $dbitem->itemnumber_id,
        'frombranch'  => $dbitem->item->homebranch,
        'tobranch'    => $dbitem->stage->branchcode_id,
        'datesent'    => dt_from_string(),
        'datearrived' => dt_from_string(),
        'reason'      => "StockrotationAdvance",
    })->store;
    $dbitem->item->homebranch($dbitem->stage->branchcode_id)->store;
    $dbitem->item->holdingbranch($dbitem->stage->branchcode_id)->store;
    is($dbitem->investigate->{reason}, 'not-ready', "older item at stagebranch not-ready.");

    # Test item due for advancement ['advancement']

    my $arrived_duration =  DateTime::Duration->new( days => 52);
    $dbtransfer = Koha::Item::Transfer->new({
        'itemnumber'  => $dbitem->itemnumber_id,
        'frombranch'  => $dbitem->item->homebranch,
        'tobranch'    => $dbitem->stage->branchcode_id,
        'datesent'    => dt_from_string() - $sent_duration,
        'datearrived' => dt_from_string() - $arrived_duration,
        'reason'      => "StockrotationAdvance",
    })->store;
    $dbitem->item->homebranch($dbitem->stage->branchcode_id)->store;
    $dbitem->item->holdingbranch($dbitem->stage->branchcode_id)->store;
    is($dbitem->investigate->{reason}, 'advancement',
       "Item ready for advancement.");


    $arrived_duration =  DateTime::Duration->new( days => 52);
    $dbtransfer = Koha::Item::Transfer->new({
        'itemnumber'  => $dbitem->itemnumber_id,
        'frombranch'  => $dbitem->item->homebranch,
        'tobranch'    => $dbitem->stage->branchcode_id,
        'datesent'    => dt_from_string() - $sent_duration,
        'datearrived' => dt_from_string() - $arrived_duration,
        'reason'      => "StockrotationAdvance",
    })->store;
    $dbitem->item->homebranch($dbitem->stage->branchcode_id)->store;
    $dbitem->item->holdingbranch($dbitem->stage->branchcode_id)->store;
    is($dbitem->investigate->{reason}, 'in-demand',
       "Item advances, but in-demand.");


    $arrived_duration =  DateTime::Duration->new( days => 52);
    $dbtransfer = Koha::Item::Transfer->new({
        'itemnumber'  => $dbitem->itemnumber_id,
        'frombranch'  => $dbitem->item->homebranch,
        'tobranch'    => $dbitem->stage->branchcode_id,
        'datesent'    => dt_from_string() - $sent_duration,
        'datearrived' => dt_from_string() - $arrived_duration,

    });
    my $dbitem = Koha::StockRotationItems->find($sritem->{itemnumber_id});
    my $firstbranch = $dbitem->stage->branchcode_id;
    $dbitem->item->holdingbranch($firstbranch)->store;
    my $dbstage = $dbitem->stage;
    $dbstage->position(1)->duration(50)->store; # Configure stage.
    # Configure item
    $dbitem->item->holdingbranch($firstbranch)->store;
    $dbitem->item->homebranch($firstbranch)->store;
    # Sanity check
    is($dbitem->stage->stage_id, $dbstage->stage_id, "Stage sanity check.");


    # Test an item in transfer, toggle cancels transfer and resets indemand.
    ok($dbitem->advance, "Advancement done.");
    $dbitem->get_from_storage;
    my $transfer = $dbitem->item->get_transfer;
    is(ref($transfer), 'Koha::Item::Transfer', 'Item set to in transfer as expected');
    is($transfer->frombranch, $firstbranch, 'Transfer from set correctly');
    is($transfer->tobranch, $secondbranch, 'Transfer to set correctly');

    isnt($updated_transfer->datearrived, undef, 'Transfer datearrived set as expected');
    is($dbitem->indemand, 0, "Item retains indemand as expected.");
    is($dbitem->stage_id, $dbstage->id, 'Item stage reset as expected.');
    is($dbitem->item->homebranch, $firstbranch, 'Item homebranch reset as expected.');

    $schema->storage->txn_rollback;
};
- 

Return to bug 29809

Lines 57-71 sub _type { Link Here

(-)a/Koha/StockRotationItem.pm (-19 / +19 lines)
57	return 'Stockrotationitem';	57	return 'Stockrotationitem';
58	}	58	}
59		59
60	=head3 itemnumber	60	=head3 item
61		61
62	my $item = Koha::StockRotationItem->itemnumber;	62	my $item = Koha::StockRotationItem->item;
63		63
64	Returns the item associated with the current stock rotation item.	64	Returns the item associated with the current stock rotation item.
65		65
66	=cut	66	=cut
67		67
68	sub itemnumber {	68	sub item {
69	my ( $self ) = @_;	69	my ( $self ) = @_;
70	my $rs = $self->_result->itemnumber;	70	my $rs = $self->_result->itemnumber;
71	return Koha::Item->_new_from_dbic( $rs );	71	return Koha::Item->_new_from_dbic( $rs );
Lines 96-103 according to our stockrotation plan. Link Here
96		96
97	sub needs_repatriating {	97	sub needs_repatriating {
98	my ( $self ) = @_;	98	my ( $self ) = @_;
99	my ( $item, $stage ) = ( $self->itemnumber, $self->stage );	99	my ( $item, $stage ) = ( $self->item, $self->stage );
100	if ( $self->itemnumber->get_transfer ) {	100	if ( $self->item->get_transfer ) {
101	return 0; # We're in transit.	101	return 0; # We're in transit.
102	} elsif ( $item->holdingbranch ne $stage->branchcode_id	102	} elsif ( $item->holdingbranch ne $stage->branchcode_id
103	\|\| $item->homebranch ne $stage->branchcode_id ) {	103	\|\| $item->homebranch ne $stage->branchcode_id ) {
Lines 117-125 Return 1 if this item is ready to be moved on to the next stage in its rota. Link Here
117		117
118	sub needs_advancing {	118	sub needs_advancing {
119	my ( $self ) = @_;	119	my ( $self ) = @_;
120	return 0 if $self->itemnumber->get_transfer; # intransfer: don't advance.	120	return 0 if $self->item->get_transfer; # intransfer: don't advance.
121	return 1 if $self->fresh; # Just on rota: advance.	121	return 1 if $self->fresh; # Just on rota: advance.
122	my $completed = $self->itemnumber->_result->branchtransfers->search(	122	my $completed = $self->item->_result->branchtransfers->search(
123	{ 'reason' => "StockrotationAdvance" },	123	{ 'reason' => "StockrotationAdvance" },
124	{ order_by => { -desc => 'datearrived' } }	124	{ order_by => { -desc => 'datearrived' } }
125	);	125	);
Lines 136-142 sub needs_advancing { Link Here
136	return 0;	136	return 0;
137	}	137	}
138	} else {	138	} else {
139	warn "We have no historical branch transfer for itemnumber " . $self->itemnumber->itemnumber . "; This should not have happened!";	139	warn "We have no historical branch transfer for item " . $self->item->itemnumber . "; This should not have happened!";
140	}	140	}
141	}	141	}
142		142
Lines 157-163 sub repatriate { Link Here
157		157
158	# Create the transfer.	158	# Create the transfer.
159	my $transfer = try {	159	my $transfer = try {
160	$self->itemnumber->request_transfer(	160	$self->item->request_transfer(
161	{	161	{
162	to => $self->stage->branchcode,	162	to => $self->stage->branchcode,
163	reason => "StockrotationRepatriation",	163	reason => "StockrotationRepatriation",
Lines 168-174 sub repatriate { Link Here
168	};	168	};
169		169
170	# Ensure the homebranch is still in sync with the rota stage	170	# Ensure the homebranch is still in sync with the rota stage
171	$self->itemnumber->homebranch( $self->stage->branchcode_id )->store;	171	$self->item->homebranch( $self->stage->branchcode_id )->store;
172		172
173	return defined($transfer) ? 1 : 0;	173	return defined($transfer) ? 1 : 0;
174	}	174	}
Lines 194-200 pass 'ignore_limits' in the call to request_transfer. Link Here
194		194
195	sub advance {	195	sub advance {
196	my ($self) = @_;	196	my ($self) = @_;
197	my $item = $self->itemnumber;	197	my $item = $self->item;
198	my $current_branch = $item->holdingbranch;	198	my $current_branch = $item->holdingbranch;
199	my $transfer;	199	my $transfer;
200		200
Lines 300-306 sub toggle_indemand { Link Here
300		300
301	# Cancel 'StockrotationAdvance' transfer if one is in progress	301	# Cancel 'StockrotationAdvance' transfer if one is in progress
302	if ($new_indemand) {	302	if ($new_indemand) {
303	my $item = $self->itemnumber;	303	my $item = $self->item;
304	my $transfer = $item->get_transfer;	304	my $transfer = $item->get_transfer;
305	if ($transfer && $transfer->reason eq 'StockrotationAdvance') {	305	if ($transfer && $transfer->reason eq 'StockrotationAdvance') {
306	my $stage = $self->stage;	306	my $stage = $self->stage;
Lines 334-349 generating stockrotation reports about this stockrotationitem. Link Here
334	sub investigate {	334	sub investigate {
335	my ( $self ) = @_;	335	my ( $self ) = @_;
336	my $item_report = {	336	my $item_report = {
337	title => $self->itemnumber->_result->biblioitem	337	title => $self->item->_result->biblioitem
338	->biblionumber->title,	338	->biblionumber->title,
339	author => $self->itemnumber->_result->biblioitem	339	author => $self->item->_result->biblioitem
340	->biblionumber->author,	340	->biblionumber->author,
341	callnumber => $self->itemnumber->itemcallnumber,	341	callnumber => $self->item->itemcallnumber,
342	location => $self->itemnumber->location,	342	location => $self->item->location,
343	onloan => $self->itemnumber->onloan,	343	onloan => $self->item->onloan,
344	barcode => $self->itemnumber->barcode,	344	barcode => $self->item->barcode,
345	itemnumber => $self->itemnumber_id,	345	itemnumber => $self->itemnumber_id,
346	branch => $self->itemnumber->_result->holdingbranch,	346	branch => $self->item->_result->holdingbranch,
347	object => $self,	347	object => $self,
348	};	348	};
349	my $reason;	349	my $reason;