Attachment #133073 for bug #9525

View | Details | Raw Unified | Return to bug 9525
Collapse All | Expand All

Lines 1925-1930 returnbranch => branch to which to return item. Possible values: Link Here

(-)a/C4/Circulation.pm (-1 / +13 lines)
1925	noreturn: do not return, let item remain where checked in (floating collections)	1925	noreturn: do not return, let item remain where checked in (floating collections)
1926	homebranch: return to item's home branch	1926	homebranch: return to item's home branch
1927	holdingbranch: return to issuer branch	1927	holdingbranch: return to issuer branch
		1928	returnbylibrarygroup: if item is returned to float group library, let it float
1928		1929
1929	This searches branchitemrules in the following order:	1930	This searches branchitemrules in the following order:
1930		1931
Lines 2084-2091 sub AddReturn { Link Here
2084		2085
2085	# full item data, but no borrowernumber or checkout info (no issue)	2086	# full item data, but no borrowernumber or checkout info (no issue)
2086	my $hbr = GetBranchItemRule($item->homebranch, $itemtype)->{'returnbranch'} \|\| "homebranch";	2087	my $hbr = GetBranchItemRule($item->homebranch, $itemtype)->{'returnbranch'} \|\| "homebranch";
		2088	# check if returnbranch and homebranch belong to the same float group
		2089	my $validate_float = Koha::Libraries->find( $item->homebranch )->validate_float_sibling({ branchcode => $branch });
2087	# get the proper branch to which to return the item	2090	# get the proper branch to which to return the item
2088	my $returnbranch = $hbr ne 'noreturn' ? $item->$hbr : $branch;	2091	my $returnbranch;
		2092	if($hbr eq 'noreturn'){
		2093	$returnbranch = $branch;
		2094	}elsif($hbr eq 'returnbylibrarygroup'){
		2095	# if library isn't in same the float group, transfer item to homebranch
		2096	$hbr = 'homebranch';
		2097	$returnbranch = $validate_float ? $branch : $item->$hbr;
		2098	}else{
		2099	$returnbranch = $item->$hbr;
		2100	}
2089	# if $hbr was "noreturn" or any other non-item table value, then it should 'float' (i.e. stay at this branch)	2101	# if $hbr was "noreturn" or any other non-item table value, then it should 'float' (i.e. stay at this branch)
2090	my $transfer_trigger = $hbr eq 'homebranch' ? 'ReturnToHome' : $hbr eq 'holdingbranch' ? 'ReturnToHolding' : undef;	2102	my $transfer_trigger = $hbr eq 'homebranch' ? 'ReturnToHome' : $hbr eq 'holdingbranch' ? 'ReturnToHolding' : undef;
2091		2103




    };
}

=head3 get_float_group_libraries

Return all libraries belonging to the same float group

=cut

sub get_float_libraries {
    my ( $self ) = @_;

    my $library_groups = $self->library_groups;
    my @float_libraries;

    while ( my $library_group = $library_groups->next ) {
        my $root = Koha::Library::Groups->get_root_ancestor({id => $library_group->id});
        if($root->ft_local_float_group) {
            push @float_libraries, $root->all_libraries;
        }
    }

    my %seen;
    @float_libraries =
      grep { !$seen{ $_->id }++ } @float_libraries;

    return Koha::Libraries->search({ branchcode => { '-in' => [ keys %seen ] } });
}

=head3 validate_float_sibling

Return if given library is a valid float group member

=cut

sub validate_float_sibling {
    my ( $self, $params ) = @_;

    return 1 if $params->{branchcode} eq $self->id;

    my $branchcode = $params->{branchcode};
    return $self->get_float_libraries->search( { branchcode => $branchcode } )
      ->count > 0;
}

=head2 Internal methods

=head3 _type




    my $ft_search_groups_opac  = $cgi->param('ft_search_groups_opac')  || 0;
    my $ft_search_groups_staff = $cgi->param('ft_search_groups_staff') || 0;
    my $ft_local_hold_group = $cgi->param('ft_local_hold_group') || 0;
    my $ft_local_float_group = $cgi->param('ft_local_float_group') || 0;

    if ( !$branchcode && Koha::Library::Groups->search( { title => $title } )->count() ) {
        $template->param( error_duplicate_title => $title );

                    ft_search_groups_opac  => $ft_search_groups_opac,
                    ft_search_groups_staff => $ft_search_groups_staff,
                    ft_local_hold_group    => $ft_local_hold_group,
                    ft_local_float_group   => $ft_local_float_group,
                    branchcode             => $branchcode,
                }
            )->store();

    my $ft_search_groups_opac  = $cgi->param('ft_search_groups_opac')  || 0;
    my $ft_search_groups_staff = $cgi->param('ft_search_groups_staff') || 0;
    my $ft_local_hold_group = $cgi->param('ft_local_hold_group') || 0;
    my $ft_local_float_group = $cgi->param('ft_local_float_group') || 0;

    if ($id) {
        my $group = Koha::Library::Groups->find($id);

                ft_search_groups_opac    => $ft_search_groups_opac,
                ft_search_groups_staff   => $ft_search_groups_staff,
                ft_local_hold_group   => $ft_local_hold_group,
                ft_local_float_group     => $ft_local_float_group,
            }
        )->store();


Lines 303-310 if ($barcode) { Link Here

(-)a/circ/returns.pl (-2 / +4 lines)
303		303
304	# make sure return branch respects home branch circulation rules, default to homebranch	304	# make sure return branch respects home branch circulation rules, default to homebranch
305	my $hbr = GetBranchItemRule($item->homebranch, $itemtype ? $itemtype->itemtype : undef )->{'returnbranch'} \|\| "homebranch";	305	my $hbr = GetBranchItemRule($item->homebranch, $itemtype ? $itemtype->itemtype : undef )->{'returnbranch'} \|\| "homebranch";
306	$returnbranch = $hbr ne 'noreturn' ? $item->$hbr : $userenv_branch; # can be noreturn, homebranch or holdingbranch	306	my $validate_float = Koha::Libraries->find( $item->homebranch )->validate_float_sibling({ branchcode => $userenv_branch });
307		307	# get the proper branch to which to return the item
		308	# if library isn't in same the float group, transfer item to homelibrary
		309	$returnbranch = $hbr eq 'noreturn' ? $userenv_branch : $hbr eq 'returnbylibrarygroup' ? $validate_float ? $userenv_branch : $item->homebranch : $item->$hbr;
308	my $materials = $item->materials;	310	my $materials = $item->materials;
309	my $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({frameworkcode => '', kohafield =>'items.materials', authorised_value => $materials });	311	my $descriptions = Koha::AuthorisedValues->get_description_by_koha_field({frameworkcode => '', kohafield =>'items.materials', authorised_value => $materials });
310	$materials = $descriptions->{lib} // $materials;	312	$materials = $descriptions->{lib} // $materials;

Lines 147-152 Link Here

(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/library_groups.tt (-4 / +23 lines)
147	Is local hold group	147	Is local hold group
148	</label>	148	</label>
149	</p>	149	</p>
		150	<p>
		151	<label>
		152	<input type="checkbox" name="ft_local_float_group" id="add-group-modal-ft_local_float_group" value="1" />
		153	Is local float group
		154	</label>
		155	</p>
150	</div>	156	</div>
151	</div>	157	</div>
152	</div>	158	</div>
Lines 211-216 Link Here
211	Is local hold group	217	Is local hold group
212	</label>	218	</label>
213	</p>	219	</p>
		220	<p>
		221	<label>
		222	<input type="checkbox" id="edit-group-modal-ft_local_float_group" name="ft_local_float_group" value="1" />
		223	Is local float group
		224	</label>
		225	</p>
214	</div>	226	</div>
215	</div>	227	</div>
216	</div>	228	</div>
Lines 291-297 Link Here
291	var ft_search_groups_opac = $(this).data('groupFt_search_groups_opac');	303	var ft_search_groups_opac = $(this).data('groupFt_search_groups_opac');
292	var ft_search_groups_staff = $(this).data('groupFt_search_groups_staff');	304	var ft_search_groups_staff = $(this).data('groupFt_search_groups_staff');
293	var ft_local_hold_group = $(this).data('groupFt_local_hold_group');	305	var ft_local_hold_group = $(this).data('groupFt_local_hold_group');
294	edit_group( id, parent_id, title, description, ft_hide_patron_info, ft_search_groups_opac, ft_search_groups_staff, ft_local_hold_group );	306	var ft_local_float_group = $(this).data('groupFt_local_float_group');
		307	edit_group( id, parent_id, title, description, ft_hide_patron_info, ft_search_groups_opac, ft_search_groups_staff, ft_local_hold_group, ft_local_float_group );
295	});	308	});
296		309
297	$('.delete-group').on('click', function(e) {	310	$('.delete-group').on('click', function(e) {
Lines 327-332 Link Here
327	$('#add-group-modal-ft_search_groups_opac').prop('checked', false);	340	$('#add-group-modal-ft_search_groups_opac').prop('checked', false);
328	$('#add-group-modal-ft_search_groups_staff').prop('checked', false);	341	$('#add-group-modal-ft_search_groups_staff').prop('checked', false);
329	$('#add-group-modal-ft_local_hold_group').prop('checked', false);	342	$('#add-group-modal-ft_local_hold_group').prop('checked', false);
		343	$('#add-group-modal-ft_local_float_group').prop('checked', false);
330	if ( parent_id ) {	344	if ( parent_id ) {
331	$('#root-group-features-add').hide();	345	$('#root-group-features-add').hide();
332	} else {	346	} else {
Lines 336-357 Link Here
336		350
337	}	351	}
338		352
339	function edit_group( id, parent_id, title, description, ft_hide_patron_info, ft_search_groups_opac, ft_search_groups_staff, ft_local_hold_group ) {	353	function edit_group( id, parent_id, title, description, ft_hide_patron_info, ft_search_groups_opac, ft_search_groups_staff, ft_local_hold_group, ft_local_float_group ) {
340	$('#edit-group-modal-id').val( id );	354	$('#edit-group-modal-id').val( id );
341	$('#edit-group-modal-title').val( title );	355	$('#edit-group-modal-title').val( title );
342	$('#edit-group-modal-description').val( description );	356	$('#edit-group-modal-description').val( description );
343		357	console.log(ft_local_float_group);
344	if ( parent_id ) {	358	if ( parent_id ) {
345	$('#edit-group-modal-ft_hide_patron_info').prop('checked', false);	359	$('#edit-group-modal-ft_hide_patron_info').prop('checked', false);
346	$('#edit-group-modal-ft_search_groups_opac').prop('checked', false);	360	$('#edit-group-modal-ft_search_groups_opac').prop('checked', false);
347	$('#edit-group-modal-ft_search_groups_staff').prop('checked', false);	361	$('#edit-group-modal-ft_search_groups_staff').prop('checked', false);
348	$('#edit-group-modal-ft_local_hold_group').prop('checked', false);	362	$('#edit-group-modal-ft_local_hold_group').prop('checked', false);
		363	$('#edit-group-modal-ft_local_float_group').prop('checked', false);
349	$('#root-group-features-edit').hide();	364	$('#root-group-features-edit').hide();
350	} else {	365	} else {
351	$('#edit-group-modal-ft_hide_patron_info').prop('checked', ft_hide_patron_info ? true : false );	366	$('#edit-group-modal-ft_hide_patron_info').prop('checked', ft_hide_patron_info ? true : false );
352	$('#edit-group-modal-ft_search_groups_opac').prop('checked', ft_search_groups_opac ? true : false );	367	$('#edit-group-modal-ft_search_groups_opac').prop('checked', ft_search_groups_opac ? true : false );
353	$('#edit-group-modal-ft_search_groups_staff').prop('checked', ft_search_groups_staff ? true : false );	368	$('#edit-group-modal-ft_search_groups_staff').prop('checked', ft_search_groups_staff ? true : false );
354	$('#edit-group-modal-ft_local_hold_group').prop('checked', ft_local_hold_group ? true : false );	369	$('#edit-group-modal-ft_local_hold_group').prop('checked', ft_local_hold_group ? true : false );
		370	$('#edit-group-modal-ft_local_float_group').prop('checked', ft_local_float_group ? true : false );
355	$('#root-group-features-edit').show();	371	$('#root-group-features-edit').show();
356	}	372	}
357		373
Lines 407-412 Link Here
407	[% IF group.ft_local_hold_group %]	423	[% IF group.ft_local_hold_group %]
408	<li>Is local hold group</li>	424	<li>Is local hold group</li>
409	[% END %]	425	[% END %]
		426	[% IF group.ft_local_float_group %]
		427	<li>Is local float group</li>
		428	[% END %]
410	</ul>	429	</ul>
411	[% END %]	430	[% END %]
412	</td>	431	</td>
Lines 424-430 Link Here
424	</li>	443	</li>
425		444
426	<li>	445	<li>
427	<a class="edit-group" id="edit-group-[% group.id \| html %]" href="#" data-group-id="[% group.id \| html %]" data-group-parent-id="[% group.parent_id \| html %]" data-group-title="[% group.title \| html %]" data-group-description="[% group.description \| html %]" data-group-ft_hide_patron_info="[% group.ft_hide_patron_info \| html %]" data-group-ft_search_groups_opac="[% group.ft_search_groups_opac \| html %]" data-group-ft_search_groups_staff="[% group.ft_search_groups_staff \| html %]" data-group-ft_local_hold_group="[% group.ft_local_hold_group \| html %]" >	446	<a class="edit-group" id="edit-group-[% group.id \| html %]" href="#" data-group-id="[% group.id \| html %]" data-group-parent-id="[% group.parent_id \| html %]" data-group-title="[% group.title \| html %]" data-group-description="[% group.description \| html %]" data-group-ft_hide_patron_info="[% group.ft_hide_patron_info \| html %]" data-group-ft_search_groups_opac="[% group.ft_search_groups_opac \| html %]" data-group-ft_search_groups_staff="[% group.ft_search_groups_staff \| html %]" data-group-ft_local_hold_group="[% group.ft_local_hold_group \| html %]" data-group-ft_local_float_group="[% group.ft_local_float_group \| html %]" >
428	<i class="fa fa-pencil"></i> Edit	447	<i class="fa fa-pencil"></i> Edit
429	</a>	448	</a>
430	</li>	449	</li>

Lines 743-748 Link Here

(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt (+10 lines)
743	[% END %]	743	[% END %]
744	Item floats	744	Item floats
745	</option>	745	</option>
		746	[% IF returnbranch.rule_value == 'returnbylibrarygroup' %]
		747	<option value="returnbylibrarygroup" selected="selected">
		748	[% ELSE %]
		749	<option value="returnbylibrarygroup">
		750	[% END %]
		751	Item floats by library group
		752	</option>
746	</select>	753	</select>
747	</td>	754	</td>
748	<td class="actions">	755	<td class="actions">
Lines 1127-1132 Link Here
1127	<span>Item returns to issuing branch</span>	1134	<span>Item returns to issuing branch</span>
1128	[% ELSIF returnbranch == 'noreturn' %]	1135	[% ELSIF returnbranch == 'noreturn' %]
1129	<span>Item floats</span>	1136	<span>Item floats</span>
		1137	[% ELSIF returnbranch == 'returnbylibrarygroup'%]
		1138	<span>Item floats by library group</span>
1130	[% END %]	1139	[% END %]
1131	</td>	1140	</td>
1132	<td class="actions">	1141	<td class="actions">
Lines 1179-1184 Link Here
1179	<option value="homebranch">Item returns home</option>	1188	<option value="homebranch">Item returns home</option>
1180	<option value="holdingbranch">Item returns to issuing library</option>	1189	<option value="holdingbranch">Item returns to issuing library</option>
1181	<option value="noreturn">Item floats</option>	1190	<option value="noreturn">Item floats</option>
		1191	<option value="returnbylibrarygroup">Item floats by library group</option>
1182	</select>	1192	</select>
1183	</td>	1193	</td>
1184	<td class="actions"><button type="submit" class="btn btn-default btn-xs"><i class="fa fa-plus"></i> Add</button></td>	1194	<td class="actions"><button type="submit" class="btn btn-default btn-xs"><i class="fa fa-plus"></i> Add</button></td>





};

subtest 'get_float_libraries and validate_float_sibling' => sub {

    plan tests => 4;

    $schema->storage->txn_begin;

    my $library1 = $builder->build_object({ class => 'Koha::Libraries' });
    my $library2 = $builder->build_object({ class => 'Koha::Libraries' });
    my $library3 = $builder->build_object({ class => 'Koha::Libraries' });
    my $library4 = $builder->build_object({ class => 'Koha::Libraries' });

    my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } );
    my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } );
    # Float group 1
    $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library1->branchcode } } );
    $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library2->branchcode } } );
    # Float group 2
    $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root2->id, branchcode => $library3->branchcode } } );
    $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root2->id, branchcode => $library4->branchcode } } );

    my @libraries1 = $library1->get_float_libraries();
    is(scalar @libraries1, '2', '1st float group contains 2 libraries');

    my @libraries2 = $library3->get_float_libraries();
    is(scalar @libraries2, '2', '2nd float group also contains 2 libraries');

    ok($library1->validate_float_sibling({ branchcode => $library2->branchcode }), "Library1 and library2 belong in to the same float group.");
    ok($library3->validate_float_sibling({ branchcode => $library4->branchcode }), "Library3 and library5 belong in to the same float group.");

    $schema->storage->txn_rollback;
};

subtest 'outgoing_transfers' => sub {
    plan tests => 3;

- 

Return to bug 9525

Lines 313-318 sub to_api_mapping { Link Here

(-)a/Koha/Library.pm (+42 lines)
313	};	313	};
314	}	314	}
315		315
		316	=head3 get_float_group_libraries
		317
		318	Return all libraries belonging to the same float group
		319
		320	=cut
		321
		322	sub get_float_libraries {
		323	my ( $self ) = @_;
		324
		325	my $library_groups = $self->library_groups;
		326	my @float_libraries;
		327
		328	while ( my $library_group = $library_groups->next ) {
		329	my $root = Koha::Library::Groups->get_root_ancestor({id => $library_group->id});
		330	if($root->ft_local_float_group) {
		331	push @float_libraries, $root->all_libraries;
		332	}
		333	}
		334
		335	my %seen;
		336	@float_libraries =
		337	grep { !$seen{ $_->id }++ } @float_libraries;
		338
		339	return Koha::Libraries->search({ branchcode => { '-in' => [ keys %seen ] } });
		340	}
		341
		342	=head3 validate_float_sibling
		343
		344	Return if given library is a valid float group member
		345
		346	=cut
		347
		348	sub validate_float_sibling {
		349	my ( $self, $params ) = @_;
		350
		351	return 1 if $params->{branchcode} eq $self->id;
		352
		353	my $branchcode = $params->{branchcode};
		354	return $self->get_float_libraries->search( { branchcode => $branchcode } )
		355	->count > 0;
		356	}
		357
316	=head2 Internal methods	358	=head2 Internal methods
317		359
318	=head3 _type	360	=head3 _type

Lines 50-55 if ( $action eq 'add' ) { Link Here

(-)a/admin/library_groups.pl (+4 lines)
50	my $ft_search_groups_opac = $cgi->param('ft_search_groups_opac') \|\| 0;	50	my $ft_search_groups_opac = $cgi->param('ft_search_groups_opac') \|\| 0;
51	my $ft_search_groups_staff = $cgi->param('ft_search_groups_staff') \|\| 0;	51	my $ft_search_groups_staff = $cgi->param('ft_search_groups_staff') \|\| 0;
52	my $ft_local_hold_group = $cgi->param('ft_local_hold_group') \|\| 0;	52	my $ft_local_hold_group = $cgi->param('ft_local_hold_group') \|\| 0;
		53	my $ft_local_float_group = $cgi->param('ft_local_float_group') \|\| 0;
53		54
54	if ( !$branchcode && Koha::Library::Groups->search( { title => $title } )->count() ) {	55	if ( !$branchcode && Koha::Library::Groups->search( { title => $title } )->count() ) {
55	$template->param( error_duplicate_title => $title );	56	$template->param( error_duplicate_title => $title );
Lines 65-70 if ( $action eq 'add' ) { Link Here
65	ft_search_groups_opac => $ft_search_groups_opac,	66	ft_search_groups_opac => $ft_search_groups_opac,
66	ft_search_groups_staff => $ft_search_groups_staff,	67	ft_search_groups_staff => $ft_search_groups_staff,
67	ft_local_hold_group => $ft_local_hold_group,	68	ft_local_hold_group => $ft_local_hold_group,
		69	ft_local_float_group => $ft_local_float_group,
68	branchcode => $branchcode,	70	branchcode => $branchcode,
69	}	71	}
70	)->store();	72	)->store();
Lines 85-90 elsif ( $action eq 'edit' ) { Link Here
85	my $ft_search_groups_opac = $cgi->param('ft_search_groups_opac') \|\| 0;	87	my $ft_search_groups_opac = $cgi->param('ft_search_groups_opac') \|\| 0;
86	my $ft_search_groups_staff = $cgi->param('ft_search_groups_staff') \|\| 0;	88	my $ft_search_groups_staff = $cgi->param('ft_search_groups_staff') \|\| 0;
87	my $ft_local_hold_group = $cgi->param('ft_local_hold_group') \|\| 0;	89	my $ft_local_hold_group = $cgi->param('ft_local_hold_group') \|\| 0;
		90	my $ft_local_float_group = $cgi->param('ft_local_float_group') \|\| 0;
88		91
89	if ($id) {	92	if ($id) {
90	my $group = Koha::Library::Groups->find($id);	93	my $group = Koha::Library::Groups->find($id);
Lines 97-102 elsif ( $action eq 'edit' ) { Link Here
97	ft_search_groups_opac => $ft_search_groups_opac,	100	ft_search_groups_opac => $ft_search_groups_opac,
98	ft_search_groups_staff => $ft_search_groups_staff,	101	ft_search_groups_staff => $ft_search_groups_staff,
99	ft_local_hold_group => $ft_local_hold_group,	102	ft_local_hold_group => $ft_local_hold_group,
		103	ft_local_float_group => $ft_local_float_group,
100	}	104	}
101	)->store();	105	)->store();
102		106

Lines 331-336 subtest 'get_hold_libraries and validate_hold_sibling' => sub { Link Here

(-)a/t/db_dependent/Koha/Libraries.t (-1 / +32 lines)
331		331
332	};	332	};
333		333
		334	subtest 'get_float_libraries and validate_float_sibling' => sub {
		335
		336	plan tests => 4;
		337
		338	$schema->storage->txn_begin;
		339
		340	my $library1 = $builder->build_object({ class => 'Koha::Libraries' });
		341	my $library2 = $builder->build_object({ class => 'Koha::Libraries' });
		342	my $library3 = $builder->build_object({ class => 'Koha::Libraries' });
		343	my $library4 = $builder->build_object({ class => 'Koha::Libraries' });
		344
		345	my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } );
		346	my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } );
		347	# Float group 1
		348	$builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library1->branchcode } } );
		349	$builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library2->branchcode } } );
		350	# Float group 2
		351	$builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root2->id, branchcode => $library3->branchcode } } );
		352	$builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root2->id, branchcode => $library4->branchcode } } );
		353
		354	my @libraries1 = $library1->get_float_libraries();
		355	is(scalar @libraries1, '2', '1st float group contains 2 libraries');
		356
		357	my @libraries2 = $library3->get_float_libraries();
		358	is(scalar @libraries2, '2', '2nd float group also contains 2 libraries');
		359
		360	ok($library1->validate_float_sibling({ branchcode => $library2->branchcode }), "Library1 and library2 belong in to the same float group.");
		361	ok($library3->validate_float_sibling({ branchcode => $library4->branchcode }), "Library3 and library5 belong in to the same float group.");
		362
		363	$schema->storage->txn_rollback;
		364	};
		365
334	subtest 'outgoing_transfers' => sub {	366	subtest 'outgoing_transfers' => sub {
335	plan tests => 3;	367	plan tests => 3;
336		368
337	-