Attachment #145655 for bug #14367

View | Details | Raw Unified | Return to bug 14367
Collapse All | Expand All




use MARC::File::XML;
use POSIX qw( strftime );
use Module::Load::Conditional qw( can_load );
use JSON qw(encode_json decode_json);

use C4::Koha;
use C4::Log qw( logaction );    # logaction

use Koha::SearchEngine::Indexer;
use Koha::Libraries;
use Koha::Util::MARC;
use Koha::MetadataRecord::History;

=head1 NAME


                BiblioAutoLink( $record, $frameworkcode );
            }

            # now add the record (history parameter is undef: no history yet)
            ModBiblioMarc( $record, $biblionumber, undef, { skip_record_index => $skip_record_index } ) unless $defer_marc_save;

            # update OAI-PMH sets
            if(C4::Context->preference("OAI-PMH:AutoUpdateSets")) {

    # update biblionumber and biblioitemnumber in MARC
    # FIXME - this is assuming a 1 to 1 relationship between
    # biblios and biblioitems
    my $sth = $dbh->prepare("select biblioitems.biblioitemnumber, biblio_metadata.history from biblioitems INNER JOIN biblio_metadata ON biblioitems.biblionumber = biblio_metadata.biblionumber WHERE biblioitems.biblionumber=?");
    $sth->execute($biblionumber);
    my ($biblioitemnumber, $history) = $sth->fetchrow;
    $sth->finish();
    _koha_marc_update_bib_ids( $record, $frameworkcode, $biblionumber, $biblioitemnumber );


    _koha_marc_update_biblioitem_cn_sort( $record, $oldbiblio, $frameworkcode );

    # update the MARC record (that now contains biblio and items) with the new record data
    ModBiblioMarc( $record, $biblionumber, $history, { skip_record_index => $skip_record_index } );

    # modify the other koha tables
    _koha_modify_biblio( $dbh, $oldbiblio, $frameworkcode );

sub ModBiblioMarc {
    # pass the MARC::Record to this function, and it will create the records in
    # the marcxml field
    my ( $record, $biblionumber, $history, $params ) = @_;
    if ( !$record ) {
        carp 'ModBiblioMarc passed an undefined record';
        return;

        $indexer->index_records( $biblionumber, "specialUpdate", "biblioserver" );
    }

    # Decode JSON history, create new record, update and re-encode to JSON.
    my $historylength = 10;
    eval {
        $history = decode_json($history);
        1;
    } or do {
        $history = undef;
    };
    my $newrecord = HistoryRecordNew($record);
    my $newhistory = HistoryUpdate($newrecord, $historylength, $history);
    $newhistory = encode_json($newhistory);

    $m_rs->update({ metadata => $record->as_xml_record($encoding), history => $newhistory });

    ModZebra( $biblionumber, "specialUpdate", "biblioserver", $record );
    return $biblionumber;
}





package Koha::MetadataRecord::History;

# Copyright 2016 Aleisha Amohia <aleisha@catalyst.net.nz>
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.

use strict;
use warnings;

use C4::Charset qw( StripNonXmlChars );
use JSON qw(decode_json);

use vars qw(@ISA @EXPORT);

BEGIN {
    require Exporter;
    @ISA = qw( Exporter );

    push @EXPORT, qw(
        &GetMarcBiblioHistory
        &HistoryUpdate
        &HistoryParse
        &HistoryMapUsers
        &HistoryBorrowerDetails
        &HistoryRecordNew
    );
 }

=head1 NAME

Koha::MetadataRecord::History - tracking changes to MARC records

=head1 DESCRIPTION

Koha::MetadataRecord::History not only tracks changes to MARC records and presents them in a log, but also allows users to
roll them back, either in batch to a previous point in the history or separately for each field (so you can roll back changes
to a field without changing fields that may have been changed after this one).

=head2 GetMarcBiblioHistory

    my ($record, $history) = GetMarcBiblio($biblionumber, [$embeditems]);

Returns MARC::Record representing bib identified by C<$biblionumber>.  If no bib exists, returns undef.
C<$biblionumber>.  If no bib exists, returns undef.
C<$embeditems>.  If set to true, items data are included.
The MARC record contains biblio data, and items data if $embeditems is set to true.

=cut

sub GetMarcBiblioHistory {
    my $biblionumber = shift;
    my $embeditems   = shift || 0;
    if (not defined $biblionumber) {
        warn "GetMarcBiblio called with undefined biblionumber";
        return;
    }
    my $dbh = C4::Context->dbh;
    my $sth = $dbh->prepare("SELECT metadata,history FROM biblio_metadata WHERE biblionumber=? ");
    $sth->execute($biblionumber);
    my $row = $sth->fetchrow_hashref;
    my $marcxml = StripNonXmlChars( $row->{'metadata'} );
    MARC::File::XML->default_record_format( C4::Context->preference('marcflavour') );
    my $record = MARC::Record->new();
    my ($history, $borrowers) = HistoryParse( $row->{'history'} );
    $borrowers = HistoryBorrowerDetails( $borrowers );
    $history = HistoryMapUsers( $history, $borrowers );
    if ($marcxml) {
        $record = eval { MARC::Record::new_from_xml( $marcxml, "utf8", C4::Context->preference('marcflavour') ) };
        if ($@) { warn " problem with :$biblionumber : $@ \n$marcxml"; }
            return unless $record;
            C4::Biblio::_koha_marc_update_bib_ids($record, '', $biblionumber, $biblionumber);
            C4::Biblio::EmbedItemsInMarcBiblio($record, $biblionumber) if ($embeditems);
            return ($record, $history);
    } else {
        return;
    }
}

=head2 HistoryParse

Input format (JSON): [ { datetime, borrowernumber, marcxml } ]
Output format: { tag } { subfield } [ { borrowernumber, data, datetime } ]

=cut

sub HistoryParse {
    my $json = shift;
    if (!defined $json) {
        warn "HistoryParse: Missing JSON parameter";
        return;
    }
    my $input = decode_json($json);
    # Reindex the dataset; order all values by datetime under each tag name.
    my $borrowers = { };
    my $output = { };
    for my $item (@{$input}) {
        my $datetime = $item->{datetime};
        $borrowers->{ $item->{borrowernumber }} = undef;
        my $record = MARC::File::XML::decode($item->{marcxml});
        for my $field ($record->fields()) {
            my $tag = $field->tag();
            $output->{$tag} = {} unless defined $output->{$tag};
            for my $subfield ($field->subfields()) {
                # Build hash ref structure.
                my $subfield_tag = @{$subfield}[0];
                $output->{$tag}->{$subfield_tag} = []
                unless defined $output->{$tag}->{$subfield_tag};
                push( @{ $output->{$tag}->{$subfield_tag} }, HistoryParsedRecordNew(
                    @{ $subfield }[1], $item->{borrowernumber}, $datetime));
                }
            }
        }
    return ( $output, $borrowers );
}

=head2 HistoryBorrowerDetails

Take a hashref with borrowernumbers as keys, returns new hash with the
borrowernumber as key to hash containing firstname, surname and title.

=cut

sub HistoryBorrowerDetails {
    my $borrowernumbers = shift;
    my $dbh = C4::Context->dbh;
    my $output = { };
    my @numbers = keys %{$borrowernumbers};
    if (@numbers > 0) {
        # We now need to look up the numeric user id's and map to name and title strings.
        my $sth = $dbh->prepare(qq{SELECT
            borrowernumber, title, firstname, surname
            FROM borrowers
            WHERE borrowernumber IN}
            . '(' . join(',', ('?') x @numbers) . ')');
        $sth->execute(@numbers)
            or die ('BorrowerDetails: Unable to execute SELECT statement');
        while (my $row = $sth->fetchrow_hashref()) {
            $output->{ $row->{borrowernumber} } = { };
            $output->{ $row->{borrowernumber} }->{title}     = $row->{title};
            $output->{ $row->{borrowernumber} }->{firstname} = $row->{firstname};
            $output->{ $row->{borrowernumber} }->{surname}   = $row->{surname};
        }
        $sth->finish();
    }
    return $output;
}

=head2 HistoryMapUsers

=cut

sub HistoryMapUsers {
    my ($history, $borrowers) = @_;
    my $mappedhistory = { };
    for my $tag (keys %{ $history }) {
        $mappedhistory->{ $tag } = { };
        for my $field (keys %{ $history->{ $tag } }) {
            $mappedhistory->{ $tag }->{ $field } = [ ];
            for my $entry (@{ $history->{ $tag }->{ $field } }) {
                # C4::Dates does not allow me to print time, only dates.
                #my $newtime = C4::Dates->new( $history->{ $tag }->{ $field }->{ $time }->{timestamp}, 'iso' )->output('syspref');
                my $newitem = { };
                my $user = $borrowers->{ $entry->{borrowernumber} };

                # Maybe change this to work on original instead of copy?
                $newitem->{title}          = $user->{title};
                $newitem->{firstname}      = $user->{firstname};
                $newitem->{surname}        = $user->{surname};
                $newitem->{borrowernumber} = $entry->{borrowernumber};
                $newitem->{data}           = $entry->{data};
                $newitem->{datetime}       = $entry->{datetime};

                push ( @{ $mappedhistory->{ $tag }->{ $field } } , $newitem);
            }
        }
    }
    return $mappedhistory;
}

=head2 HistoryParsedRecordNew

=cut

sub HistoryParsedRecordNew {
    my ($value, $borrowernumber, $datetime) = @_;
    my $newrecord = {
        data           => $value,
        borrowernumber => $borrowernumber,
        datetime       => $datetime,
    };
    return $newrecord;
}

=head2 HistoryRecordNew

=cut

sub HistoryRecordNew {
    my ( $record ) = @_;
    my $encoding = C4::Context->preference("marcflavour");
    my $hash_record = {
        borrowernumber => C4::Context->userenv()->{number},
        datetime       => POSIX::strftime('%Y-%m-%d %T', localtime(time)),
        marcxml        => $record->as_xml_record($encoding),
    };
    return $hash_record;
}

=head2 HistoryUpdate

=cut

sub HistoryUpdate {
    my ( $record, $limit, $collection ) = @_;
    if ( !$record ) {
        warn "HistoryUpdate: Called with undefined record";
        return;
    }
    if ( ref($record) ne 'HASH' ) {
        warn "HistoryUpdate: Record parameter is not a hashref";
        return;
    }
    $limit = 10 unless defined $limit;
    # We need something to append history to, even if there is none.
    $collection = [] unless defined $collection;
    # Truncate history to $histsize - 1, need space for new entry.
    splice(@{$collection}, $limit - 1);
    push(@{$collection}, $record);
    # Sort the resulting array, newest entries first.
    # Removed; used to be integer timestamps. Is now MySQL date strings.
    #@{$collection} = sort { $a->{timestamp} < $b->{timestamp} } @{$collection};
    @{$collection} = sort { $a->{datetime} lt $b->{datetime} } @{$collection};
    return $collection;
}

1;

__END__

=head1 AUTHOR

Koha Development Team <http://koha-community.org/>

Paul POULAIN paul.poulain@free.fr

Joshua Ferraro jmf@liblime.com

=cut




use Koha::DateUtils qw( dt_from_string );

use Koha::Biblios;
use C4::Koha;
use Koha::ItemTypes;
use Koha::MetadataRecord::History;
use Koha::Libraries;

use Koha::BiblioFrameworks;
use Koha::Patrons;

use MARC::File::USMARC;
use MARC::File::XML;
use URI::Escape qw( uri_escape_utf8 );

=cut

sub create_input {
    my ( $tag, $subfield, $value, $index_tag, $rec, $authorised_values_sth,$cgi, $history ) = @_;

    my $index_subfield = CreateKey(); # create a specifique key for each subfield

    my $taghistory = $history->{$tag}->{$subfield};

    $value =~ s/"/&quot;/g;

    # Apply optional framework default value when it is a new record,
    # or when editing as new (duplicating a record),
    # or when changing a record's framework,

        value          => $value,
        maxlength      => $tagslib->{$tag}->{$subfield}->{maxlength},
        random         => CreateKey(),
        history        => $taghistory,
    );

    if(exists $mandatory_z3950->{$tag.$subfield}){

            maxlength => $subfield_data{maxlength},
            readonly  => ($is_readonly) ? 1 : 0,
            authtype  => $tagslib->{$tag}->{$subfield}->{authtypecode},
            history   => $taghistory,
        };

    # it's a plugin field

                javascript     => $plugin->javascript,
                plugin         => $plugin->name,
                noclick        => $plugin->noclick,
                history        => $taghistory,
            };
        } else {
            warn $plugin->errstr;

                size      => 67,
                maxlength => $subfield_data{maxlength},
                readonly  => 0,
                history   => $taghistory,
            };
        }


            value     => $value,
            size      => 67,
            maxlength => $subfield_data{maxlength},
            history   => $taghistory,
        };

    }

                id        => $subfield_data{id},
                name      => $subfield_data{id},
                value     => $value,
                history   => $taghistory,
            };

        }

                size      => 67,
                maxlength => $subfield_data{maxlength},
                readonly  => 0,
                history   => $taghistory,
            };

        }

}

sub build_tabs {
    my ( $template, $record, $dbh, $encoding, $input, $history ) = @_;

    # fill arrays
    my @loop_data = ();
    #my $tag;

    my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : "";
    my $query = "SELECT authorised_value, lib

		}
		# loop through each field
                foreach my $field (@fields) {
                    
                    my @subfields_data;
                    if ( $tag < 10 ) {
                        my ( $value, $subfield );

                            @subfields_data,
                            &create_input(
                                $tag, $subfield, $value, $index_tag, $record,
                                $authorised_values_sth,$input, $history
                            )
                        );
                    }

                                @subfields_data,
                                &create_input(
                                    $tag, $subfield, $value, $index_tag,
                                    $record, $authorised_values_sth,$input, $history
                                )
                            );
                        }

                            @subfields_data,
                            &create_input(
                                $tag, $subfield, '', $index_tag, $record,
                                $authorised_values_sth,$input, $history
                            )
                        );
                    }

                        @subfields_data,
                        &create_input(
                            $tag, $subfield->{subfield}, '', $index_tag, $record,
                            $authorised_values_sth,$input, $history
                        )
                    );
                }

                        tagfirstsubfield => $subfields_data[0],
                        fixedfield       => $tag < 10?1:0,
                    );

                    push @loop_data, \%tag_data ;
                }
            }

# -- Global

my $record   = -1;
my $history  = undef;
my $encoding = "";
my (
	$biblionumbertagfield,

);

if ( $biblio && !$breedingid ) {
    ($record, $history) = GetMarcBiblioHistory($biblio->id);
}
if ($breedingid) {
    ( $record, $encoding ) = MARCfindbreeding( $breedingid ) ;

        else {
            ( $biblionumber, $oldbibitemnum ) = AddBiblio( $record, $frameworkcode );
        }
        if ($redirect eq "items" || (defined $mode && $mode ne "popup" && !$is_a_modif && $redirect ne "view" && $redirect ne "just_save")){
	    if ($frameworkcode eq 'FA'){
		print $input->redirect(
            '/cgi-bin/koha/cataloguing/additem.pl?'

        }
    } else {
    # it may be a duplicate, warn the user and do nothing
        build_tabs ($template, $record, $dbh,$encoding, $input, $history);
        $template->param(
            biblionumber             => $biblionumber,
            biblioitemnumber         => $biblioitemnumber,

            $record = $urecord;
        };
    }

    build_tabs( $template, $record, $dbh, $encoding, $input, $history );
    $template->param(
        biblionumber             => $biblionumber,
        biblionumbertagfield        => $biblionumbertagfield,

Line 0 Link Here

(-)a/installer/data/mysql/atomicupdate/bug_14367_-_add_history_column.perl (+9 lines)
	1	$DBversion = 'XXX';
	2	if( CheckVersion( $DBversion ) ) {
	3	unless( column_exists( 'biblio_metadata', 'history' ) ) {
	4	$dbh->do(q\|ALTER TABLE biblio_metadata ADD history longtext default NULL AFTER metadata\|);
	5	}
	6
	7	SetVersion( $DBversion );
	8	print "Upgrade to $DBversion done (Bug 14367: Add column biblio_metadata.history)\n";
	9	}

Lines 81-86 ul li.tag li.subfield_line.ui-sortable-helper::before { Link Here

(-)a/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css (+22 lines)
81	text-decoration: none;	81	text-decoration: none;
82	}	82	}
83		83
		84	.buttonHistory {
		85	font-weight : bold;
		86	text-decoration : none;
		87	}
		88
84	a.expandfield {	89	a.expandfield {
85	text-decoration: none;	90	text-decoration: none;
86	}	91	}
Lines 287-292 fieldset.order_details ol li .label:first-child { Link Here
287	margin: 0 .5em;	292	margin: 0 .5em;
288	}	293	}
289		294
		295	.readonly { border-width : 1px; border-style: inset; padding-left : 15px; background: #EEE url(../img/locked.png) center left no-repeat; width:29em; }
		296	.subfield_history { margin : 0 .5em; float: right; }
		297
290	#cataloguing_additem_itemlist {	298	#cataloguing_additem_itemlist {
291	margin-bottom: 1em;	299	margin-bottom: 1em;
292	}	300	}
Lines 514-516 tbody tr.active td { Link Here
514	font-weight: bold;	522	font-weight: bold;
515	padding: 0;	523	padding: 0;
516	}	524	}
		525
		526	.history_container {
		527	display: none;
		528	}
		529
		530	.history_table {
		531	width: 100%;
		532	display: none;
		533	float: right;
		534	clear: both;
		535	font-size: 75%;
		536	width: 75%;
		537	margin: 0.3em;
		538	}




[% USE raw %]
[% USE Asset %]
[% USE Koha %]
[% USE KohaDates %]
[% INCLUDE 'doc-head-open.inc' %]
<title>[% IF ( biblionumber ) %]Editing [% title | html %] (Record number [% biblionumber | html %])[% ELSE %]Add MARC record[% END %] &rsaquo; Cataloging &rsaquo; Koha</title>
[% INCLUDE 'doc-head-close.inc' %]

    var Sticky;
    $(document).ready(function() {

        $(".input_marceditor").click(function(){
            var tag = $(this).attr('id');
            historyToggle(tag + '_history');
            return false;
        });

        $(".tag_editor").click(function(){
            var tag = $(this).attr('id');
            openAuth(this.parentNode.parentNode.getElementsByTagName('input')[1].id, tag, 'biblio');
            return false;
        });

        $(".buttonHistory").click(function(){
            var tag = $(this).attr('id');
            HistoryToggle(tag + '_history');
            return false;
        });

        $(".hist_rollback").click(function(){
            var tag = $(this).attr('data-tag');
            var value = $(this).attr('data-history');
            HistoryRollback(tag, value);
            return false;
        });

        [% IF bib_doesnt_exist %]
            $("#addbibliotabs").hide();
            $("#toolbar").hide();

                                                    <div class="subfield_controls">
                                                        [% IF ( mv.type == 'text' ) %]
                                                            [% IF ( mv.authtype ) %]
                                                                <a id="[%- mv.authtype | html -%]" href="#" class="buttonDot tag_editor" onclick="openAuth(this.parentNode.parentNode.getElementsByTagName('input')[1].id,'[%- mv.authtype | html -%]','biblio'); return false;" tabindex="1" title="Tag editor">Tag editor</a>
                                                            [% END %]
                                                        [% ELSIF ( mv.type == 'text_complex' ) %]
                                                                [% IF mv.noclick %]
                                                                    <span class="buttonDot tag_editor disabled" tabindex="-1" title="Field autofilled by plugin"></span>
                                                                [% ELSE %]
                                                                    [% IF mv.plugin == "upload.pl" %]
                                                                        <a href="#" id="buttonDot_[% mv.id | html %]" class="buttonDot tag_editor upload framework_plugin" tabindex="2"><i class="fa fa-upload" aria-hidden="true"></i> Upload</a>
                                                                    [% ELSE %]
                                                                        <a href="#" id="buttonDot_[% mv.id | html %]" class="buttonDot tag_editor framework_plugin" tabindex="2" title="Tag editor">Tag editor</a>
                                                                    [% END %]
                                                                [% END %]
                                                            </span>

                                                            </a>
                                                        [% END %]
                                                    </div>
                                                    [% IF ( subfield_loo.history ) %]
                                                    <span class="subfield_history">
                                                        <a href="#" class="buttonHistory" id="[%- mv.id | html -%]">
                                                            <img src="[% interface | html %]/[% theme | html %]/img/icon-history.png" alt="History" title="Display history for this field" />
                                                        </a>
                                                    </span>

                                                    <table class="history_table" id="[%- mv.id | html -%]_history" name="[%- mv.name | html -%]_history">
                                                        <tr>
                                                            <th>Value</th>
                                                            <th>Date</th>
                                                            <th>User</th>
                                                        </tr>
                                                        [% FOREACH hist IN subfield_loo.history %]
                                                        <tr>
                                                            <td><a href="#" data-tag='[%- mv.id | html -%]' data-history='[% hist.data | html %]' class='hist_rollback'>[% hist.data | html %]</a></td>
                                                            <td>[% hist.datetime | $KohaDates with_hours = 1 %]</td>
                                                            <td>[% hist.title | html %] [% hist.firstname | html %] [% hist.surname | html %]</td>
                                                        </tr>
                                                        [% END %]
                                                    </table>
                                                    [% END %]
                                                </li> <!-- /.subfield_line -->
                                                <!-- End of the line -->
                                            [% END # /FOREACH subfield_loop %]




    window.open("../authorities/auth_finder.pl?source="+source+"&authtypecode="+authtype+"&index="+tagsubfieldid+"&value_mainstr="+encodeURIComponent(mainmainstring)+"&value_main="+encodeURIComponent(mainstring), "_blank",'width=700,height=550,toolbar=false,scrollbars=yes');
}

function HistoryToggle (tagid)
{
	$('#' + tagid).toggle();
}

function HistoryRollback (tagid, value)
{
	$('#' + tagid).val(value);
}

function ExpandField(index) {
    var original = document.getElementById(index); //original <li>
    var lis = original.getElementsByTagName('li');




#!/usr/bin/perl

use Modern::Perl;
use t::lib::TestBuilder;
use t::lib::Mocks;
use Test::More tests => 6;
use POSIX qw(strftime);

use MARC::Record;
use MARC::Field;
use JSON qw(encode_json);

use Koha::MetadataRecord::History;

BEGIN {
    use_ok('C4::Biblio');
}

our $dbh = C4::Context->dbh;
$dbh->{AutoCommit} = 0;
$dbh->{RaiseError} = 0;

$dbh->do(q|DELETE FROM issues|);
$dbh->do(q|DELETE FROM items|);
$dbh->do(q|DELETE FROM borrowers|);
$dbh->do(q|DELETE FROM branches|);
$dbh->do(q|DELETE FROM categories|);
$dbh->do(q|DELETE FROM biblioitems|);

my $builder = t::lib::TestBuilder->new();

my $branch = $builder->build(
    {
        source => 'Branch',
    }
);

my $category = $builder->build(
    {
        source => 'Category',
    }
);

my $patron1 = $builder->build(
    {
        source => 'Borrower',
        value  => {
            title        => 'Mr/Mrs',
            firstname    => 'First name',
            surname      => 'Surname',
            categorycode => $category->{categorycode},
            branchcode   => $branch->{branchcode},
        },
    }
);

my $patron2 = $builder->build(
    {
        source => 'Borrower',
        value  => {
            title        => 'Mr/Mrs 2',
            firstname    => 'First name 2',
            surname      => 'Surname 2',
            categorycode => $category->{categorycode},
            branchcode   => $branch->{branchcode},
        },
    }
);

my $biblio = $builder->build(
    {
        source => 'Biblio',
        value  => {
            branchcode => $branch->{branchcode},
        },
    }
);

C4::Context->_new_userenv('DUMMY_SESSION_ID');
C4::Context->set_userenv( $patron1->{borrowernumber},
    $patron1->{userid}, 'usercnum', $patron1->{firstname}, $patron1->{surname},
    $branch->{branchcode}, 'My library', 0 );

# Item with no pre-existing history backlog.
my $record1 = MARC::Record->new();
my $field1  = MARC::Field->new(
    245, '1', '0',
    'a' => 'First Title',
    'c' => 'Some dude'
);
$record1->append_fields($field1);

my $record2 = MARC::Record->new();
my $field2  = MARC::Field->new(
    245, '1', '0',
    'a' => 'Second Title',
    'c' => 'Former dude'
);
$record2->append_fields($field2);

my $biblioitem1 = $builder->build(
    {
        source => 'Biblioitem',
        value  => {
            marcxml => $record1->as_xml(),
            history => undef,
        }
    }
);

# items{tagname}{subfield}{timestamp}{borrowernumber|timestamp|marcxml}
my $items = [
    {
        borrowernumber => $patron1->{borrowernumber},
        datetime       => '2012-08-12 12:00:10',
        marcxml        => $record1->as_xml(),
    },
    {
        borrowernumber => $patron2->{borrowernumber},
        datetime       => '2012-08-12 12:00:10',
        marcxml        => $record2->as_xml(),
    }
];

# Item with previous history entries.
my $biblioitem2 = $builder->build(
    {
        source => 'Biblioitem',
        value  => {
            marcxml => $record2->as_xml(),
            history => encode_json($items),
        }
    }
);

my $expected_history = {
    245 => {
        a => [
            {
                borrowernumber => $patron1->{borrowernumber},
                data           => 'First Title',
                datetime       => '2012-08-12 12:00:10'
            },
            {
                borrowernumber => $patron2->{borrowernumber},
                data           => 'Second Title',
                datetime       => '2012-08-12 12:00:10'
            },
        ],
        c => [
            {
                borrowernumber => $patron1->{borrowernumber},
                data           => 'Some dude',
                datetime       => '2012-08-12 12:00:10'
            },
            {
                borrowernumber => $patron2->{borrowernumber},
                data           => 'Former dude',
                datetime       => '2012-08-12 12:00:10'
            },
        ],
    },
};

my $expected_users = {
    $patron1->{borrowernumber} => undef,
    $patron2->{borrowernumber} => undef,
};

# Tests the decoding and reindexing of the data, without any borrower
# information implanted into the history itself.

my ( $history, $users ) = C4::Biblio::HistoryParse( encode_json($items) );

is_deeply( $history, $expected_history, 'HistoryParse: Output' );
is_deeply( $users,   $expected_users,   'HistoryParse: Users' );

# Tests the extraction of full borrower details based on the borrowernumber.
my $expected_details = {
    $patron1->{borrowernumber} => {
        firstname => $patron1->{firstname},
        surname   => $patron1->{surname},
        title     => $patron1->{title},
    },
    $patron2->{borrowernumber} => {
        firstname => $patron2->{firstname},
        surname   => $patron2->{surname},
        title     => $patron2->{title},
    }
};

my $details = HistoryBorrowerDetails($expected_users);
is_deeply( $details, $expected_details, 'HistoryBorrowerDetails: Output' );

{
    my $expected_mapped_history = {
        245 => {
            a => [
                {
                    borrowernumber => $patron1->{borrowernumber},
                    data           => 'First Title',
                    firstname      => $patron1->{firstname},
                    surname        => $patron1->{surname},
                    title          => $patron1->{title},
                    datetime       => '2012-08-12 12:00:10'
                },
                {
                    borrowernumber => $patron2->{borrowernumber},
                    data           => 'Second Title',
                    firstname      => $patron2->{firstname},
                    surname        => $patron2->{surname},
                    title          => $patron2->{title},
                    datetime       => '2012-08-12 12:00:10'
                },
            ],
            c => [
                {
                    borrowernumber => $patron1->{borrowernumber},
                    data           => 'Some dude',
                    firstname      => $patron1->{firstname},
                    surname        => $patron1->{surname},
                    title          => $patron1->{title},
                    datetime       => '2012-08-12 12:00:10'
                },
                {
                    borrowernumber => $patron2->{borrowernumber},
                    data           => 'Former dude',
                    firstname      => $patron2->{firstname},
                    surname        => $patron2->{surname},
                    title          => $patron2->{title},
                    datetime       => '2012-08-12 12:00:10'
                },
            ]
        }
    };

    $history = C4::Biblio::HistoryMapUsers( $expected_history, $details );

    is_deeply( $history, $expected_mapped_history, 'HistoryMapUsers: Output' );

  #my $record;
  #( $record, $history ) = GetMarcBiblioHistory( $biblioitem2->{biblionumber} );

    #is_deeply( $record, $record2 );
    #is_deeply( $history, $expected_mapped_history );
}

# The C4::Context will provide the expected user borrowernumber.
my $record = HistoryRecordNew($record1);

my $expected_record = {
    borrowernumber => C4::Context->userenv()->{number},
    marcxml        => $record1->as_xml_record(),
    datetime       => POSIX::strftime( '%Y-%m-%d %T', localtime ),
};
is_deeply( $record, $expected_record );

Return to bug 14367

Lines 47-58 use Koha::BiblioFrameworks; Link Here

(-)a/cataloguing/addbiblio.pl (-15 / +27 lines)
47	use Koha::DateUtils qw( dt_from_string );	47	use Koha::DateUtils qw( dt_from_string );
48		48
49	use Koha::Biblios;	49	use Koha::Biblios;
		50	use C4::Koha;
50	use Koha::ItemTypes;	51	use Koha::ItemTypes;
		52	use Koha::MetadataRecord::History;
51	use Koha::Libraries;	53	use Koha::Libraries;
52
53	use Koha::BiblioFrameworks;	54	use Koha::BiblioFrameworks;
54	use Koha::Patrons;	55	use Koha::Patrons;
55
56	use MARC::File::USMARC;	56	use MARC::File::USMARC;
57	use MARC::File::XML;	57	use MARC::File::XML;
58	use URI::Escape qw( uri_escape_utf8 );	58	use URI::Escape qw( uri_escape_utf8 );
Lines 288-297 sub GetMandatoryFieldZ3950 { Link Here
288	=cut	288	=cut
289		289
290	sub create_input {	290	sub create_input {
291	my ( $tag, $subfield, $value, $index_tag, $rec, $authorised_values_sth,$cgi ) = @_;	291	my ( $tag, $subfield, $value, $index_tag, $rec, $authorised_values_sth,$cgi, $history ) = @_;
292		292
293	my $index_subfield = CreateKey(); # create a specifique key for each subfield	293	my $index_subfield = CreateKey(); # create a specifique key for each subfield
294		294
		295	my $taghistory = $history->{$tag}->{$subfield};
		296
		297	$value =~ s/"/"/g;
		298
295	# Apply optional framework default value when it is a new record,	299	# Apply optional framework default value when it is a new record,
296	# or when editing as new (duplicating a record),	300	# or when editing as new (duplicating a record),
297	# or when changing a record's framework,	301	# or when changing a record's framework,
Lines 343-348 sub create_input { Link Here
343	value => $value,	347	value => $value,
344	maxlength => $tagslib->{$tag}->{$subfield}->{maxlength},	348	maxlength => $tagslib->{$tag}->{$subfield}->{maxlength},
345	random => CreateKey(),	349	random => CreateKey(),
		350	history => $taghistory,
346	);	351	);
347		352
348	if(exists $mandatory_z3950->{$tag.$subfield}){	353	if(exists $mandatory_z3950->{$tag.$subfield}){
Lines 401-406 sub create_input { Link Here
401	maxlength => $subfield_data{maxlength},	406	maxlength => $subfield_data{maxlength},
402	readonly => ($is_readonly) ? 1 : 0,	407	readonly => ($is_readonly) ? 1 : 0,
403	authtype => $tagslib->{$tag}->{$subfield}->{authtypecode},	408	authtype => $tagslib->{$tag}->{$subfield}->{authtypecode},
		409	history => $taghistory,
404	};	410	};
405		411
406	# it's a plugin field	412	# it's a plugin field
Lines 423-428 sub create_input { Link Here
423	javascript => $plugin->javascript,	429	javascript => $plugin->javascript,
424	plugin => $plugin->name,	430	plugin => $plugin->name,
425	noclick => $plugin->noclick,	431	noclick => $plugin->noclick,
		432	history => $taghistory,
426	};	433	};
427	} else {	434	} else {
428	warn $plugin->errstr;	435	warn $plugin->errstr;
Lines 435-440 sub create_input { Link Here
435	size => 67,	442	size => 67,
436	maxlength => $subfield_data{maxlength},	443	maxlength => $subfield_data{maxlength},
437	readonly => 0,	444	readonly => 0,
		445	history => $taghistory,
438	};	446	};
439	}	447	}
440		448
Lines 447-452 sub create_input { Link Here
447	value => $value,	455	value => $value,
448	size => 67,	456	size => 67,
449	maxlength => $subfield_data{maxlength},	457	maxlength => $subfield_data{maxlength},
		458	history => $taghistory,
450	};	459	};
451		460
452	}	461	}
Lines 467-472 sub create_input { Link Here
467	id => $subfield_data{id},	476	id => $subfield_data{id},
468	name => $subfield_data{id},	477	name => $subfield_data{id},
469	value => $value,	478	value => $value,
		479	history => $taghistory,
470	};	480	};
471		481
472	}	482	}
Lines 479-484 sub create_input { Link Here
479	size => 67,	489	size => 67,
480	maxlength => $subfield_data{maxlength},	490	maxlength => $subfield_data{maxlength},
481	readonly => 0,	491	readonly => 0,
		492	history => $taghistory,
482	};	493	};
483		494
484	}	495	}
Lines 504-514 sub format_indicator { Link Here
504	}	515	}
505		516
506	sub build_tabs {	517	sub build_tabs {
507	my ( $template, $record, $dbh, $encoding,$input ) = @_;	518	my ( $template, $record, $dbh, $encoding, $input, $history ) = @_;
508		519
509	# fill arrays	520	# fill arrays
510	my @loop_data = ();	521	my @loop_data = ();
511	my $tag;	522	#my $tag;
512		523
513	my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : "";	524	my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : "";
514	my $query = "SELECT authorised_value, lib	525	my $query = "SELECT authorised_value, lib
Lines 564-570 sub build_tabs { Link Here
564	}	575	}
565	# loop through each field	576	# loop through each field
566	foreach my $field (@fields) {	577	foreach my $field (@fields) {
567
568	my @subfields_data;	578	my @subfields_data;
569	if ( $tag < 10 ) {	579	if ( $tag < 10 ) {
570	my ( $value, $subfield );	580	my ( $value, $subfield );
Lines 584-590 sub build_tabs { Link Here
584	@subfields_data,	594	@subfields_data,
585	&create_input(	595	&create_input(
586	$tag, $subfield, $value, $index_tag, $record,	596	$tag, $subfield, $value, $index_tag, $record,
587	$authorised_values_sth,$input	597	$authorised_values_sth,$input, $history
588	)	598	)
589	);	599	);
590	}	600	}
Lines 599-605 sub build_tabs { Link Here
599	@subfields_data,	609	@subfields_data,
600	&create_input(	610	&create_input(
601	$tag, $subfield, $value, $index_tag,	611	$tag, $subfield, $value, $index_tag,
602	$record, $authorised_values_sth,$input	612	$record, $authorised_values_sth,$input, $history
603	)	613	)
604	);	614	);
605	}	615	}
Lines 629-635 sub build_tabs { Link Here
629	@subfields_data,	639	@subfields_data,
630	&create_input(	640	&create_input(
631	$tag, $subfield, '', $index_tag, $record,	641	$tag, $subfield, '', $index_tag, $record,
632	$authorised_values_sth,$input	642	$authorised_values_sth,$input, $history
633	)	643	)
634	);	644	);
635	}	645	}
Lines 685-691 sub build_tabs { Link Here
685	@subfields_data,	695	@subfields_data,
686	&create_input(	696	&create_input(
687	$tag, $subfield->{subfield}, '', $index_tag, $record,	697	$tag, $subfield->{subfield}, '', $index_tag, $record,
688	$authorised_values_sth,$input	698	$authorised_values_sth,$input, $history
689	)	699	)
690	);	700	);
691	}	701	}
Lines 703-709 sub build_tabs { Link Here
703	tagfirstsubfield => $subfields_data[0],	713	tagfirstsubfield => $subfields_data[0],
704	fixedfield => $tag < 10?1:0,	714	fixedfield => $tag < 10?1:0,
705	);	715	);
706		716
707	push @loop_data, \%tag_data ;	717	push @loop_data, \%tag_data ;
708	}	718	}
709	}	719	}
Lines 806-811 $mandatory_z3950 = GetMandatoryFieldZ3950($frameworkcode); Link Here
806	# -- Global	816	# -- Global
807		817
808	my $record = -1;	818	my $record = -1;
		819	my $history = undef;
809	my $encoding = "";	820	my $encoding = "";
810	my (	821	my (
811	$biblionumbertagfield,	822	$biblionumbertagfield,
Lines 816-822 my ( Link Here
816	);	827	);
817		828
818	if ( $biblio && !$breedingid ) {	829	if ( $biblio && !$breedingid ) {
819	$record = $biblio->metadata->record;	830	($record, $history) = GetMarcBiblioHistory($biblio->id);
820	}	831	}
821	if ($breedingid) {	832	if ($breedingid) {
822	( $record, $encoding ) = MARCfindbreeding( $breedingid ) ;	833	( $record, $encoding ) = MARCfindbreeding( $breedingid ) ;
Lines 902-908 if ( $op eq "addbiblio" ) { Link Here
902	else {	913	else {
903	( $biblionumber, $oldbibitemnum ) = AddBiblio( $record, $frameworkcode );	914	( $biblionumber, $oldbibitemnum ) = AddBiblio( $record, $frameworkcode );
904	}	915	}
905	if ($redirect eq "items" \|\| ($mode ne "popup" && !$is_a_modif && $redirect ne "view" && $redirect ne "just_save")){	916	if ($redirect eq "items" \|\| (defined $mode && $mode ne "popup" && !$is_a_modif && $redirect ne "view" && $redirect ne "just_save")){
906	if ($frameworkcode eq 'FA'){	917	if ($frameworkcode eq 'FA'){
907	print $input->redirect(	918	print $input->redirect(
908	'/cgi-bin/koha/cataloguing/additem.pl?'	919	'/cgi-bin/koha/cataloguing/additem.pl?'
Lines 961-967 if ( $op eq "addbiblio" ) { Link Here
961	}	972	}
962	} else {	973	} else {
963	# it may be a duplicate, warn the user and do nothing	974	# it may be a duplicate, warn the user and do nothing
964	build_tabs ($template, $record, $dbh,$encoding,$input);	975	build_tabs ($template, $record, $dbh,$encoding, $input, $history);
965	$template->param(	976	$template->param(
966	biblionumber => $biblionumber,	977	biblionumber => $biblionumber,
967	biblioitemnumber => $biblioitemnumber,	978	biblioitemnumber => $biblioitemnumber,
Lines 1009-1015 elsif ( $op eq "delete" ) { Link Here
1009	$record = $urecord;	1020	$record = $urecord;
1010	};	1021	};
1011	}	1022	}
1012	build_tabs( $template, $record, $dbh, $encoding,$input );	1023
		1024	build_tabs( $template, $record, $dbh, $encoding, $input, $history );
1013	$template->param(	1025	$template->param(
1014	biblionumber => $biblionumber,	1026	biblionumber => $biblionumber,
1015	biblionumbertagfield => $biblionumbertagfield,	1027	biblionumbertagfield => $biblionumbertagfield,

Lines 58-63 function openAuth(tagsubfieldid,authtype,source) { Link Here

(-)a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js (+10 lines)
58	window.open("../authorities/auth_finder.pl?source="+source+"&authtypecode="+authtype+"&index="+tagsubfieldid+"&value_mainstr="+encodeURIComponent(mainmainstring)+"&value_main="+encodeURIComponent(mainstring), "_blank",'width=700,height=550,toolbar=false,scrollbars=yes');	58	window.open("../authorities/auth_finder.pl?source="+source+"&authtypecode="+authtype+"&index="+tagsubfieldid+"&value_mainstr="+encodeURIComponent(mainmainstring)+"&value_main="+encodeURIComponent(mainstring), "_blank",'width=700,height=550,toolbar=false,scrollbars=yes');
59	}	59	}
60		60
		61	function HistoryToggle (tagid)
		62	{
		63	$('#' + tagid).toggle();
		64	}
		65
		66	function HistoryRollback (tagid, value)
		67	{
		68	$('#' + tagid).val(value);
		69	}
		70
61	function ExpandField(index) {	71	function ExpandField(index) {
62	var original = document.getElementById(index); //original <li>	72	var original = document.getElementById(index); //original <li>
63	var lis = original.getElementsByTagName('li');	73	var lis = original.getElementsByTagName('li');

Lines 84-89 use MARC::File::USMARC; Link Here

(-)a/C4/Biblio.pm (-6 / +23 lines)
84	use MARC::File::XML;	84	use MARC::File::XML;
85	use POSIX qw( strftime );	85	use POSIX qw( strftime );
86	use Module::Load::Conditional qw( can_load );	86	use Module::Load::Conditional qw( can_load );
		87	use JSON qw(encode_json decode_json);
87		88
88	use C4::Koha;	89	use C4::Koha;
89	use C4::Log qw( logaction ); # logaction	90	use C4::Log qw( logaction ); # logaction
Lines 112-117 use Koha::SearchEngine; Link Here
112	use Koha::SearchEngine::Indexer;	113	use Koha::SearchEngine::Indexer;
113	use Koha::Libraries;	114	use Koha::Libraries;
114	use Koha::Util::MARC;	115	use Koha::Util::MARC;
		116	use Koha::MetadataRecord::History;
115		117
116	=head1 NAME	118	=head1 NAME
117		119
Lines 285-292 sub AddBiblio { Link Here
285	BiblioAutoLink( $record, $frameworkcode );	287	BiblioAutoLink( $record, $frameworkcode );
286	}	288	}
287		289
288	# now add the record	290	# now add the record (history parameter is undef: no history yet)
289	ModBiblioMarc( $record, $biblionumber, { skip_record_index => $skip_record_index } ) unless $defer_marc_save;	291	ModBiblioMarc( $record, $biblionumber, undef, { skip_record_index => $skip_record_index } ) unless $defer_marc_save;
290		292
291	# update OAI-PMH sets	293	# update OAI-PMH sets
292	if(C4::Context->preference("OAI-PMH:AutoUpdateSets")) {	294	if(C4::Context->preference("OAI-PMH:AutoUpdateSets")) {
Lines 404-412 sub ModBiblio { Link Here
404	# update biblionumber and biblioitemnumber in MARC	406	# update biblionumber and biblioitemnumber in MARC
405	# FIXME - this is assuming a 1 to 1 relationship between	407	# FIXME - this is assuming a 1 to 1 relationship between
406	# biblios and biblioitems	408	# biblios and biblioitems
407	my $sth = $dbh->prepare("select biblioitemnumber from biblioitems where biblionumber=?");	409	my $sth = $dbh->prepare("select biblioitems.biblioitemnumber, biblio_metadata.history from biblioitems INNER JOIN biblio_metadata ON biblioitems.biblionumber = biblio_metadata.biblionumber WHERE biblioitems.biblionumber=?");
408	$sth->execute($biblionumber);	410	$sth->execute($biblionumber);
409	my ($biblioitemnumber) = $sth->fetchrow;	411	my ($biblioitemnumber, $history) = $sth->fetchrow;
410	$sth->finish();	412	$sth->finish();
411	_koha_marc_update_bib_ids( $record, $frameworkcode, $biblionumber, $biblioitemnumber );	413	_koha_marc_update_bib_ids( $record, $frameworkcode, $biblionumber, $biblioitemnumber );
412		414
Lines 417-423 sub ModBiblio { Link Here
417	_koha_marc_update_biblioitem_cn_sort( $record, $oldbiblio, $frameworkcode );	419	_koha_marc_update_biblioitem_cn_sort( $record, $oldbiblio, $frameworkcode );
418		420
419	# update the MARC record (that now contains biblio and items) with the new record data	421	# update the MARC record (that now contains biblio and items) with the new record data
420	ModBiblioMarc( $record, $biblionumber, { skip_record_index => $skip_record_index } );	422	ModBiblioMarc( $record, $biblionumber, $history, { skip_record_index => $skip_record_index } );
421		423
422	# modify the other koha tables	424	# modify the other koha tables
423	_koha_modify_biblio( $dbh, $oldbiblio, $frameworkcode );	425	_koha_modify_biblio( $dbh, $oldbiblio, $frameworkcode );
Lines 2709-2715 Function exported, but should NOT be used, unless you really know what you're do Link Here
2709	sub ModBiblioMarc {	2711	sub ModBiblioMarc {
2710	# pass the MARC::Record to this function, and it will create the records in	2712	# pass the MARC::Record to this function, and it will create the records in
2711	# the marcxml field	2713	# the marcxml field
2712	my ( $record, $biblionumber, $params ) = @_;	2714	my ( $record, $biblionumber, $history, $params ) = @_;
2713	if ( !$record ) {	2715	if ( !$record ) {
2714	carp 'ModBiblioMarc passed an undefined record';	2716	carp 'ModBiblioMarc passed an undefined record';
2715	return;	2717	return;
Lines 2781-2786 sub ModBiblioMarc { Link Here
2781	$indexer->index_records( $biblionumber, "specialUpdate", "biblioserver" );	2783	$indexer->index_records( $biblionumber, "specialUpdate", "biblioserver" );
2782	}	2784	}
2783		2785
		2786	# Decode JSON history, create new record, update and re-encode to JSON.
		2787	my $historylength = 10;
		2788	eval {
		2789	$history = decode_json($history);
		2790	1;
		2791	} or do {
		2792	$history = undef;
		2793	};
		2794	my $newrecord = HistoryRecordNew($record);
		2795	my $newhistory = HistoryUpdate($newrecord, $historylength, $history);
		2796	$newhistory = encode_json($newhistory);
		2797
		2798	$m_rs->update({ metadata => $record->as_xml_record($encoding), history => $newhistory });
		2799
		2800	ModZebra( $biblionumber, "specialUpdate", "biblioserver", $record );
2784	return $biblionumber;	2801	return $biblionumber;
2785	}	2802	}
2786		2803

Line 0 Link Here

(-)a/Koha/MetadataRecord/History.pm (+261 lines)
		1	package Koha::MetadataRecord::History;
		2
		3	# Copyright 2016 Aleisha Amohia <aleisha@catalyst.net.nz>
		4	#
		5	# This file is part of Koha.
		6	#
		7	# Koha is free software; you can redistribute it and/or modify it
		8	# under the terms of the GNU General Public License as published by
		9	# the Free Software Foundation; either version 3 of the License, or
		10	# (at your option) any later version.
		11	#
		12	# Koha is distributed in the hope that it will be useful, but
		13	# WITHOUT ANY WARRANTY; without even the implied warranty of
		14	# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
		15	# GNU General Public License for more details.
		16	#
		17	# You should have received a copy of the GNU General Public License
		18	# along with Koha; if not, see <http://www.gnu.org/licenses>.
		19
		20	use strict;
		21	use warnings;
		22
		23	use C4::Charset qw( StripNonXmlChars );
		24	use JSON qw(decode_json);
		25
		26	use vars qw(@ISA @EXPORT);
		27
		28	BEGIN {
		29	require Exporter;
		30	@ISA = qw( Exporter );
		31
		32	push @EXPORT, qw(
		33	&GetMarcBiblioHistory
		34	&HistoryUpdate
		35	&HistoryParse
		36	&HistoryMapUsers
		37	&HistoryBorrowerDetails
		38	&HistoryRecordNew
		39	);
		40	}
		41
		42	=head1 NAME
		43
		44	Koha::MetadataRecord::History - tracking changes to MARC records
		45
		46	=head1 DESCRIPTION
		47
		48	Koha::MetadataRecord::History not only tracks changes to MARC records and presents them in a log, but also allows users to
		49	roll them back, either in batch to a previous point in the history or separately for each field (so you can roll back changes
		50	to a field without changing fields that may have been changed after this one).
		51
		52	=head2 GetMarcBiblioHistory
		53
		54	my ($record, $history) = GetMarcBiblio($biblionumber, [$embeditems]);
		55
		56	Returns MARC::Record representing bib identified by C<$biblionumber>. If no bib exists, returns undef.
		57	C<$biblionumber>. If no bib exists, returns undef.
		58	C<$embeditems>. If set to true, items data are included.
		59	The MARC record contains biblio data, and items data if $embeditems is set to true.
		60
		61	=cut
		62
		63	sub GetMarcBiblioHistory {
		64	my $biblionumber = shift;
65	my $embeditems = shift \|\| 0;
66	if (not defined $biblionumber) {
67	warn "GetMarcBiblio called with undefined biblionumber";
68	return;
69	}
70	my $dbh = C4::Context->dbh;
71	my $sth = $dbh->prepare("SELECT metadata,history FROM biblio_metadata WHERE biblionumber=? ");
72	$sth->execute($biblionumber);
73	my $row = $sth->fetchrow_hashref;
74	my $marcxml = StripNonXmlChars( $row->{'metadata'} );
75	MARC::File::XML->default_record_format( C4::Context->preference('marcflavour') );
76	my $record = MARC::Record->new();
77	my ($history, $borrowers) = HistoryParse( $row->{'history'} );
78	$borrowers = HistoryBorrowerDetails( $borrowers );
79	$history = HistoryMapUsers( $history, $borrowers );
80	if ($marcxml) {
81	$record = eval { MARC::Record::new_from_xml( $marcxml, "utf8", C4::Context->preference('marcflavour') ) };
82	if ($@) { warn " problem with :$biblionumber : $@ \n$marcxml"; }
83	return unless $record;
84	C4::Biblio::_koha_marc_update_bib_ids($record, '', $biblionumber, $biblionumber);
85	C4::Biblio::EmbedItemsInMarcBiblio($record, $biblionumber) if ($embeditems);
86	return ($record, $history);
87	} else {
88	return;
89	}
90	}
91
92	=head2 HistoryParse
93
94	Input format (JSON): [ { datetime, borrowernumber, marcxml } ]
95	Output format: { tag } { subfield } [ { borrowernumber, data, datetime } ]
96
97	=cut
98
99	sub HistoryParse {
100	my $json = shift;
101	if (!defined $json) {
102	warn "HistoryParse: Missing JSON parameter";
103	return;
104	}
105	my $input = decode_json($json);
106	# Reindex the dataset; order all values by datetime under each tag name.
107	my $borrowers = { };
108	my $output = { };
109	for my $item (@{$input}) {
110	my $datetime = $item->{datetime};
111	$borrowers->{ $item->{borrowernumber }} = undef;
112	my $record = MARC::File::XML::decode($item->{marcxml});
113	for my $field ($record->fields()) {
114	my $tag = $field->tag();
115	$output->{$tag} = {} unless defined $output->{$tag};
116	for my $subfield ($field->subfields()) {
117	# Build hash ref structure.
118	my $subfield_tag = @{$subfield}[0];
119	$output->{$tag}->{$subfield_tag} = []
120	unless defined $output->{$tag}->{$subfield_tag};
121	push( @{ $output->{$tag}->{$subfield_tag} }, HistoryParsedRecordNew(
122	@{ $subfield }[1], $item->{borrowernumber}, $datetime));
123	}
124	}
125	}
126	return ( $output, $borrowers );
127	}
128
129	=head2 HistoryBorrowerDetails
130
131	Take a hashref with borrowernumbers as keys, returns new hash with the
132	borrowernumber as key to hash containing firstname, surname and title.
133
134	=cut
135
136	sub HistoryBorrowerDetails {
137	my $borrowernumbers = shift;
138	my $dbh = C4::Context->dbh;
139	my $output = { };
140	my @numbers = keys %{$borrowernumbers};
141	if (@numbers > 0) {
142	# We now need to look up the numeric user id's and map to name and title strings.
143	my $sth = $dbh->prepare(qq{SELECT
144	borrowernumber, title, firstname, surname
145	FROM borrowers
146	WHERE borrowernumber IN}
147	. '(' . join(',', ('?') x @numbers) . ')');
148	$sth->execute(@numbers)
149	or die ('BorrowerDetails: Unable to execute SELECT statement');
150	while (my $row = $sth->fetchrow_hashref()) {
151	$output->{ $row->{borrowernumber} } = { };
152	$output->{ $row->{borrowernumber} }->{title} = $row->{title};
153	$output->{ $row->{borrowernumber} }->{firstname} = $row->{firstname};
154	$output->{ $row->{borrowernumber} }->{surname} = $row->{surname};
155	}
156	$sth->finish();
157	}
158	return $output;
159	}
160
161	=head2 HistoryMapUsers
162
163	=cut
164
165	sub HistoryMapUsers {
166	my ($history, $borrowers) = @_;
167	my $mappedhistory = { };
168	for my $tag (keys %{ $history }) {
169	$mappedhistory->{ $tag } = { };
170	for my $field (keys %{ $history->{ $tag } }) {
171	$mappedhistory->{ $tag }->{ $field } = [ ];
172	for my $entry (@{ $history->{ $tag }->{ $field } }) {
173	# C4::Dates does not allow me to print time, only dates.
174	#my $newtime = C4::Dates->new( $history->{ $tag }->{ $field }->{ $time }->{timestamp}, 'iso' )->output('syspref');
175	my $newitem = { };
176	my $user = $borrowers->{ $entry->{borrowernumber} };
177
178	# Maybe change this to work on original instead of copy?
179	$newitem->{title} = $user->{title};
180	$newitem->{firstname} = $user->{firstname};
181	$newitem->{surname} = $user->{surname};
182	$newitem->{borrowernumber} = $entry->{borrowernumber};
183	$newitem->{data} = $entry->{data};
184	$newitem->{datetime} = $entry->{datetime};
185
186	push ( @{ $mappedhistory->{ $tag }->{ $field } } , $newitem);
187	}
188	}
189	}
190	return $mappedhistory;
191	}
192
193	=head2 HistoryParsedRecordNew
194
195	=cut
196
197	sub HistoryParsedRecordNew {
198	my ($value, $borrowernumber, $datetime) = @_;
199	my $newrecord = {
200	data => $value,
201	borrowernumber => $borrowernumber,
202	datetime => $datetime,
203	};
204	return $newrecord;
205	}
206
207	=head2 HistoryRecordNew
208
209	=cut
210
211	sub HistoryRecordNew {
212	my ( $record ) = @_;
213	my $encoding = C4::Context->preference("marcflavour");
214	my $hash_record = {
215	borrowernumber => C4::Context->userenv()->{number},
216	datetime => POSIX::strftime('%Y-%m-%d %T', localtime(time)),
217	marcxml => $record->as_xml_record($encoding),
218	};
219	return $hash_record;
220	}
221
222	=head2 HistoryUpdate
223
224	=cut
225
226	sub HistoryUpdate {
227	my ( $record, $limit, $collection ) = @_;
228	if ( !$record ) {
229	warn "HistoryUpdate: Called with undefined record";
230	return;
231	}
232	if ( ref($record) ne 'HASH' ) {
233	warn "HistoryUpdate: Record parameter is not a hashref";
234	return;
235	}
236	$limit = 10 unless defined $limit;
237	# We need something to append history to, even if there is none.
238	$collection = [] unless defined $collection;
239	# Truncate history to $histsize - 1, need space for new entry.
240	splice(@{$collection}, $limit - 1);
241	push(@{$collection}, $record);
242	# Sort the resulting array, newest entries first.
243	# Removed; used to be integer timestamps. Is now MySQL date strings.
244	#@{$collection} = sort { $a->{timestamp} < $b->{timestamp} } @{$collection};
245	@{$collection} = sort { $a->{datetime} lt $b->{datetime} } @{$collection};
246	return $collection;
247	}
248
249	1;
250
251	__END__
252
253	=head1 AUTHOR
254
255	Koha Development Team <http://koha-community.org/>
256
257	Paul POULAIN paul.poulain@free.fr
258
259	Joshua Ferraro jmf@liblime.com
260
261	=cut

Lines 1-6 Link Here

(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt (-3 / +51 lines)
1	[% USE raw %]	1	[% USE raw %]
2	[% USE Asset %]	2	[% USE Asset %]
3	[% USE Koha %]	3	[% USE Koha %]
		4	[% USE KohaDates %]
4	[% INCLUDE 'doc-head-open.inc' %]	5	[% INCLUDE 'doc-head-open.inc' %]
5	<title>[% IF ( biblionumber ) %]Editing [% title \| html %] (Record number [% biblionumber \| html %])[% ELSE %]Add MARC record[% END %] &rsaquo; Cataloging &rsaquo; Koha</title>	6	<title>[% IF ( biblionumber ) %]Editing [% title \| html %] (Record number [% biblionumber \| html %])[% ELSE %]Add MARC record[% END %] &rsaquo; Cataloging &rsaquo; Koha</title>
6	[% INCLUDE 'doc-head-close.inc' %]	7	[% INCLUDE 'doc-head-close.inc' %]
Lines 27-32 Link Here
27	var Sticky;	28	var Sticky;
28	$(document).ready(function() {	29	$(document).ready(function() {
29		30
		31	$(".input_marceditor").click(function(){
		32	var tag = $(this).attr('id');
		33	historyToggle(tag + '_history');
		34	return false;
		35	});
		36
		37	$(".tag_editor").click(function(){
		38	var tag = $(this).attr('id');
		39	openAuth(this.parentNode.parentNode.getElementsByTagName('input')[1].id, tag, 'biblio');
		40	return false;
		41	});
		42
		43	$(".buttonHistory").click(function(){
		44	var tag = $(this).attr('id');
		45	HistoryToggle(tag + '_history');
		46	return false;
		47	});
		48
		49	$(".hist_rollback").click(function(){
		50	var tag = $(this).attr('data-tag');
		51	var value = $(this).attr('data-history');
		52	HistoryRollback(tag, value);
		53	return false;
		54	});
		55
30	[% IF bib_doesnt_exist %]	56	[% IF bib_doesnt_exist %]
31	$("#addbibliotabs").hide();	57	$("#addbibliotabs").hide();
32	$("#toolbar").hide();	58	$("#toolbar").hide();
Lines 1171-1186 function PopupMARCFieldDoc(field) { Link Here
1171	<div class="subfield_controls">	1197	<div class="subfield_controls">
1172	[% IF ( mv.type == 'text' ) %]	1198	[% IF ( mv.type == 'text' ) %]
1173	[% IF ( mv.authtype ) %]	1199	[% IF ( mv.authtype ) %]
1174	<a href="#" class="buttonDot tag_editor" onclick="openAuth(this.parentNode.parentNode.getElementsByTagName('input')[1].id,'[%- mv.authtype \| html -%]','biblio'); return false;" tabindex="1" title="Tag editor">Tag editor</a>	1200	<a id="[%- mv.authtype \| html -%]" href="#" class="buttonDot tag_editor" onclick="openAuth(this.parentNode.parentNode.getElementsByTagName('input')[1].id,'[%- mv.authtype \| html -%]','biblio'); return false;" tabindex="1" title="Tag editor">Tag editor</a>
1175	[% END %]	1201	[% END %]
1176	[% ELSIF ( mv.type == 'text_complex' ) %]	1202	[% ELSIF ( mv.type == 'text_complex' ) %]
1177	[% IF mv.noclick %]	1203	[% IF mv.noclick %]
1178	<span class="buttonDot tag_editor disabled" tabindex="-1" title="Field autofilled by plugin"></span>	1204	<span class="buttonDot tag_editor disabled" tabindex="-1" title="Field autofilled by plugin"></span>
1179	[% ELSE %]	1205	[% ELSE %]
1180	[% IF mv.plugin == "upload.pl" %]	1206	[% IF mv.plugin == "upload.pl" %]
1181	<a href="#" id="buttonDot_[% mv.id \| html %]" class="tag_editor upload framework_plugin" tabindex="1"><i class="fa fa-upload" aria-hidden="true"></i> Upload</a>	1207	<a href="#" id="buttonDot_[% mv.id \| html %]" class="buttonDot tag_editor upload framework_plugin" tabindex="2"><i class="fa fa-upload" aria-hidden="true"></i> Upload</a>
1182	[% ELSE %]	1208	[% ELSE %]
1183	<a href="#" id="buttonDot_[% mv.id \| html %]" class="buttonDot tag_editor framework_plugin" tabindex="1" title="Tag editor">Tag editor</a>	1209	<a href="#" id="buttonDot_[% mv.id \| html %]" class="buttonDot tag_editor framework_plugin" tabindex="2" title="Tag editor">Tag editor</a>
1184	[% END %]	1210	[% END %]
1185	[% END %]	1211	[% END %]
1186	</span>	1212	</span>
Lines 1194-1199 function PopupMARCFieldDoc(field) { Link Here
1194	</a>	1220	</a>
1195	[% END %]	1221	[% END %]
1196	</div>	1222	</div>
		1223	[% IF ( subfield_loo.history ) %]
		1224	<span class="subfield_history">
		1225	<a href="#" class="buttonHistory" id="[%- mv.id \| html -%]">
		1226	<img src="[% interface \| html %]/[% theme \| html %]/img/icon-history.png" alt="History" title="Display history for this field" />
		1227	</a>
		1228	</span>
		1229
		1230	<table class="history_table" id="[%- mv.id \| html -%]_history" name="[%- mv.name \| html -%]_history">
		1231	<tr>
		1232	<th>Value</th>
		1233	<th>Date</th>
		1234	<th>User</th>
		1235	</tr>
		1236	[% FOREACH hist IN subfield_loo.history %]
		1237	<tr>
		1238	<td><a href="#" data-tag='[%- mv.id \| html -%]' data-history='[% hist.data \| html %]' class='hist_rollback'>[% hist.data \| html %]</a></td>
		1239	<td>[% hist.datetime \| $KohaDates with_hours = 1 %]</td>
		1240	<td>[% hist.title \| html %] [% hist.firstname \| html %] [% hist.surname \| html %]</td>
		1241	</tr>
		1242	[% END %]
		1243	</table>
		1244	[% END %]
1197	</li> <!-- /.subfield_line -->	1245	</li> <!-- /.subfield_line -->
1198	<!-- End of the line -->	1246	<!-- End of the line -->
1199	[% END # /FOREACH subfield_loop %]	1247	[% END # /FOREACH subfield_loop %]

Line 0 Link Here

(-)a/t/db_dependent/BiblioHistory.t (-1 / +256 lines)
0	-	1	#!/usr/bin/perl
		2
		3	use Modern::Perl;
		4	use t::lib::TestBuilder;
		5	use t::lib::Mocks;
		6	use Test::More tests => 6;
		7	use POSIX qw(strftime);
		8
		9	use MARC::Record;
		10	use MARC::Field;
		11	use JSON qw(encode_json);
		12
		13	use Koha::MetadataRecord::History;
		14
		15	BEGIN {
		16	use_ok('C4::Biblio');
		17	}
		18
		19	our $dbh = C4::Context->dbh;
		20	$dbh->{AutoCommit} = 0;
		21	$dbh->{RaiseError} = 0;
		22
		23	$dbh->do(q\|DELETE FROM issues\|);
		24	$dbh->do(q\|DELETE FROM items\|);
		25	$dbh->do(q\|DELETE FROM borrowers\|);
		26	$dbh->do(q\|DELETE FROM branches\|);
		27	$dbh->do(q\|DELETE FROM categories\|);
		28	$dbh->do(q\|DELETE FROM biblioitems\|);
		29
		30	my $builder = t::lib::TestBuilder->new();
		31
		32	my $branch = $builder->build(
		33	{
		34	source => 'Branch',
		35	}
		36	);
		37
		38	my $category = $builder->build(
		39	{
		40	source => 'Category',
		41	}
		42	);
		43
		44	my $patron1 = $builder->build(
		45	{
		46	source => 'Borrower',
		47	value => {
		48	title => 'Mr/Mrs',
		49	firstname => 'First name',
		50	surname => 'Surname',
		51	categorycode => $category->{categorycode},
		52	branchcode => $branch->{branchcode},
		53	},
		54	}
		55	);
		56
		57	my $patron2 = $builder->build(
		58	{
		59	source => 'Borrower',
		60	value => {
		61	title => 'Mr/Mrs 2',
		62	firstname => 'First name 2',
		63	surname => 'Surname 2',
		64	categorycode => $category->{categorycode},
		65	branchcode => $branch->{branchcode},
66	},
67	}
68	);
69
70	my $biblio = $builder->build(
71	{
72	source => 'Biblio',
73	value => {
74	branchcode => $branch->{branchcode},
75	},
76	}
77	);
78
79	C4::Context->_new_userenv('DUMMY_SESSION_ID');
80	C4::Context->set_userenv( $patron1->{borrowernumber},
81	$patron1->{userid}, 'usercnum', $patron1->{firstname}, $patron1->{surname},
82	$branch->{branchcode}, 'My library', 0 );
83
84	# Item with no pre-existing history backlog.
85	my $record1 = MARC::Record->new();
86	my $field1 = MARC::Field->new(
87	245, '1', '0',
88	'a' => 'First Title',
89	'c' => 'Some dude'
90	);
91	$record1->append_fields($field1);
92
93	my $record2 = MARC::Record->new();
94	my $field2 = MARC::Field->new(
95	245, '1', '0',
96	'a' => 'Second Title',
97	'c' => 'Former dude'
98	);
99	$record2->append_fields($field2);
100
101	my $biblioitem1 = $builder->build(
102	{
103	source => 'Biblioitem',
104	value => {
105	marcxml => $record1->as_xml(),
106	history => undef,
107	}
108	}
109	);
110
111	# items{tagname}{subfield}{timestamp}{borrowernumber\|timestamp\|marcxml}
112	my $items = [
113	{
114	borrowernumber => $patron1->{borrowernumber},
115	datetime => '2012-08-12 12:00:10',
116	marcxml => $record1->as_xml(),
117	},
118	{
119	borrowernumber => $patron2->{borrowernumber},
120	datetime => '2012-08-12 12:00:10',
121	marcxml => $record2->as_xml(),
122	}
123	];
124
125	# Item with previous history entries.
126	my $biblioitem2 = $builder->build(
127	{
128	source => 'Biblioitem',
129	value => {
130	marcxml => $record2->as_xml(),
131	history => encode_json($items),
132	}
133	}
134	);
135
136	my $expected_history = {
137	245 => {
138	a => [
139	{
140	borrowernumber => $patron1->{borrowernumber},
141	data => 'First Title',
142	datetime => '2012-08-12 12:00:10'
143	},
144	{
145	borrowernumber => $patron2->{borrowernumber},
146	data => 'Second Title',
147	datetime => '2012-08-12 12:00:10'
148	},
149	],
150	c => [
151	{
152	borrowernumber => $patron1->{borrowernumber},
153	data => 'Some dude',
154	datetime => '2012-08-12 12:00:10'
155	},
156	{
157	borrowernumber => $patron2->{borrowernumber},
158	data => 'Former dude',
159	datetime => '2012-08-12 12:00:10'
160	},
161	],
162	},
163	};
164
165	my $expected_users = {
166	$patron1->{borrowernumber} => undef,
167	$patron2->{borrowernumber} => undef,
168	};
169
170	# Tests the decoding and reindexing of the data, without any borrower
171	# information implanted into the history itself.
172
173	my ( $history, $users ) = C4::Biblio::HistoryParse( encode_json($items) );
174
175	is_deeply( $history, $expected_history, 'HistoryParse: Output' );
176	is_deeply( $users, $expected_users, 'HistoryParse: Users' );
177
178	# Tests the extraction of full borrower details based on the borrowernumber.
179	my $expected_details = {
180	$patron1->{borrowernumber} => {
181	firstname => $patron1->{firstname},
182	surname => $patron1->{surname},
183	title => $patron1->{title},
184	},
185	$patron2->{borrowernumber} => {
186	firstname => $patron2->{firstname},
187	surname => $patron2->{surname},
188	title => $patron2->{title},
189	}
190	};
191
192	my $details = HistoryBorrowerDetails($expected_users);
193	is_deeply( $details, $expected_details, 'HistoryBorrowerDetails: Output' );
194
195	{
196	my $expected_mapped_history = {
197	245 => {
198	a => [
199	{
200	borrowernumber => $patron1->{borrowernumber},
201	data => 'First Title',
202	firstname => $patron1->{firstname},
203	surname => $patron1->{surname},
204	title => $patron1->{title},
205	datetime => '2012-08-12 12:00:10'
206	},
207	{
208	borrowernumber => $patron2->{borrowernumber},
209	data => 'Second Title',
210	firstname => $patron2->{firstname},
211	surname => $patron2->{surname},
212	title => $patron2->{title},
213	datetime => '2012-08-12 12:00:10'
214	},
215	],
216	c => [
217	{
218	borrowernumber => $patron1->{borrowernumber},
219	data => 'Some dude',
220	firstname => $patron1->{firstname},
221	surname => $patron1->{surname},
222	title => $patron1->{title},
223	datetime => '2012-08-12 12:00:10'
224	},
225	{
226	borrowernumber => $patron2->{borrowernumber},
227	data => 'Former dude',
228	firstname => $patron2->{firstname},
229	surname => $patron2->{surname},
230	title => $patron2->{title},
231	datetime => '2012-08-12 12:00:10'
232	},
233	]
234	}
235	};
236
237	$history = C4::Biblio::HistoryMapUsers( $expected_history, $details );
238
239	is_deeply( $history, $expected_mapped_history, 'HistoryMapUsers: Output' );
240
241	#my $record;
242	#( $record, $history ) = GetMarcBiblioHistory( $biblioitem2->{biblionumber} );
243
244	#is_deeply( $record, $record2 );
245	#is_deeply( $history, $expected_mapped_history );
246	}
247
248	# The C4::Context will provide the expected user borrowernumber.
249	my $record = HistoryRecordNew($record1);
250
251	my $expected_record = {
252	borrowernumber => C4::Context->userenv()->{number},
253	marcxml => $record1->as_xml_record(),
254	datetime => POSIX::strftime( '%Y-%m-%d %T', localtime ),
255	};
256	is_deeply( $record, $expected_record );