Attachment #152942 for bug #30708

View | Details | Raw Unified | Return to bug 30708
Collapse All | Expand All




import { mount } from "@cypress/vue";

function get_attributes() {
    return [
        {
            processing_attribute_id: 1,
            processing_id: 1,
            name: "Country",
            type: "authorised_value",
            option_source: "COUNTRY",
        },
        {
            processing_attribute_id: 1,
            processing_id: 1,
            name: "DB",
            type: "db_column",
            option_source: "biblio.title",
        },
        {
            processing_attribute_id: 1,
            processing_id: 1,
            name: "Height",
            type: "free_text",
            option_source: null,
        },
    ];
}
function get_processing() {
    return {
        name: "test processing",
        processing_id: 1,
        attributes: get_attributes(),
    };
}
describe("Processings", () => {
    beforeEach(() => {
        cy.login();
        cy.title().should("eq", "Koha staff interface");
        cy.intercept(
            "GET",
            "/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationModule",
            '{"value":"1"}'
        );
        cy.intercept(
            "GET",
            "/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationNotForLoanWaitingListIn",
            '{"value":"24"}'
        );
        cy.intercept(
            "GET",
            "/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationNotForLoanDefaultTrainIn",
            '{"value":"42"}'
        );
        cy.intercept(
            "GET",
            "/api/v1/authorised_value_categories/NOT_LOAN/authorised_values",
            [
                {
                    category_name: "NOT_LOAN",
                    description: "Ordered",
                    value: "-1",
                },
                {
                    category_name: "NOT_LOAN",
                    description: "Not for loan",
                    value: "1",
                },
                {
                    category_name: "NOT_LOAN",
                    description: "Staff collection",
                    value: "2",
                },
                {
                    category_name: "NOT_LOAN",
                    description: "Added to bundle",
                    value: "3",
                },
                {
                    category_name: "NOT_LOAN",
                    description: "In preservation",
                    value: "24",
                },
                {
                    category_name: "NOT_LOAN",
                    description: "In preservation external",
                    value: "42",
                },
            ]
        );
    });

    it("Settings", () => {
        cy.visit("/cgi-bin/koha/preservation/home.pl");
        cy.get("#navmenulist").contains("Settings").click();
        cy.get("#not_for_loan_waiting_list_in .vs__selected").contains(
            "In preservation"
        );
        cy.get("#not_for_loan_default_train_in .vs__selected").contains(
            "In preservation external"
        );
    });
    it("List processing", () => {
        cy.intercept("GET", "/api/v1/preservation/processings*", []);
        cy.visit("/cgi-bin/koha/preservation/settings");
        cy.get("#processing_0").should("not.exist");
        cy.intercept("GET", "/api/v1/preservation/processings*", [
            get_processing(),
        ]);
        cy.visit("/cgi-bin/koha/preservation/settings");
        cy.get("#processing_0").should("exist");
    });

    it("Add processing", () => {
        cy.intercept("GET", "/api/v1/preservation/processings*", []);
        cy.visit("/cgi-bin/koha/preservation/settings");
        let processing = get_processing();
        cy.contains("Add new processing").click();
        cy.get("#processing_name").type(processing.name);
        cy.contains("Add new attribute").click();
        let attribute = processing.attributes[0];
        cy.get("#attribute_name_0").type(attribute.name);
        cy.get("#attribute_type_0 .vs__search").type("Authorized{enter}", {
            force: true,
        });
        cy.get("#attribute_option_0 .vs__search").type(
            attribute.option_source + "{enter}",
            { force: true }
        );
        cy.contains("Add new attribute").click();
        attribute = processing.attributes[1];
        cy.get("#attribute_name_1").type(attribute.name);
        cy.get("#attribute_type_1 .vs__search").type("Database{enter}", {
            force: true,
        });
        cy.get("#attribute_option_1 .vs__search").type(
            attribute.option_source + "{enter}",
            { force: true }
        );
        cy.contains("Add new attribute").click();
        attribute = processing.attributes[2];
        cy.get("#attribute_name_2").type(attribute.name);
        cy.get("#attribute_type_2 .vs__search").type("Free{enter}", {
            force: true,
        });

        // Submit the form, get 500
        cy.intercept("POST", "/api/v1/preservation/processings", {
            statusCode: 500,
            error: "Something went wrong",
        });
        cy.get("#processings_add").contains("Submit").click();
        cy.get("main div[class='dialog alert']").contains(
            "Something went wrong: Error: Internal Server Error"
        );

        // Submit the form, success!
        cy.intercept("POST", "/api/v1/preservation/processings", {
            statusCode: 201,
            body: processing,
        });
        cy.intercept("GET", "/api/v1/preservation/processings*", {
            statusCode: 200,
            body: [processing],
        });
        cy.get("#processings_add").contains("Submit").click();
        cy.get("main div[class='dialog message']").contains(
            "Processing created"
        );
        cy.get("#processing_0").contains(processing.name);
    });

    it("Edit processing", () => {
        let processing = get_processing();
        cy.intercept("GET", "/api/v1/preservation/processings/*", {
            statusCode: 200,
            body: processing,
        });
        cy.intercept("GET", "/api/v1/preservation/processings*", {
            statusCode: 200,
            body: [processing],
        });
        cy.visit("/cgi-bin/koha/preservation/settings");
        cy.get("#processing_0").contains(processing.name);
        cy.get("#processing_0").contains("Edit this processing").click();
        cy.get("#processing_name").should("have.value", processing.name);
        let attribute = processing.attributes[0];
        cy.get("#attribute_name_0").should("have.value", attribute.name);
        cy.get("#attribute_type_0 .vs__selected").contains("Authorized value");
        cy.get("#attribute_option_0 .vs__selected").contains(
            attribute.option_source
        );
        attribute = processing.attributes[1];
        cy.get("#attribute_name_1").should("have.value", attribute.name);
        cy.get("#attribute_type_1 .vs__selected").contains("Database column");
        cy.get("#attribute_option_1 .vs__selected").contains(
            attribute.option_source
        );
        attribute = processing.attributes[2];
        cy.get("#attribute_name_2").should("have.value", attribute.name);
        cy.get("#attribute_type_2 .vs__selected").contains("Free text");
        cy.get("#attribute_option_2").should("not.exist");

        // Submit the form, get 500
        cy.intercept("PUT", "/api/v1/preservation/processings/*", {
            statusCode: 500,
            error: "Something went wrong",
        });
        cy.get("#processings_add").contains("Submit").click();
        cy.get("main div[class='dialog alert']").contains(
            "Something went wrong: Error: Internal Server Error"
        );

        // Submit the form, success!
        cy.intercept("PUT", "/api/v1/preservation/processings/*", {
            statusCode: 200,
            body: processing,
        });
        cy.get("#processings_add").contains("Submit").click();
        cy.get("main div[class='dialog message']").contains(
            "Processing updated"
        );
    });

    it("Delete processing", () => {
        let processing = get_processing();
        cy.intercept("GET", "/api/v1/preservation/processings*", {
            statusCode: 200,
            body: [processing],
        });

        // Submit the form, get 500
        cy.intercept("DELETE", "/api/v1/preservation/processings/*", {
            statusCode: 500,
            error: "Something went wrong",
        });
        cy.visit("/cgi-bin/koha/preservation/settings");
        cy.get("#processing_0").contains("Remove this processing").click();
        cy.contains("Yes, delete").click();
        cy.get("main div[class='dialog alert']").contains(
            "Something went wrong: Error: Internal Server Error"
        );

        // Submit the form, success!
        cy.intercept("DELETE", "/api/v1/preservation/processings/*", {
            statusCode: 204,
            body: null,
        });
        cy.get("#processing_0").contains("Remove this processing").click();
        cy.contains("Yes, delete").click();
        cy.get("main div[class='dialog message']").contains(
            `Processing ${processing.name} deleted`
        );
    });
});




import { mount } from "@cypress/vue";

function get_attributes() {
    return [
        {
            processing_attribute_id: 1,
            processing_id: 1,
            name: "Country",
            type: "authorised_value",
            option_source: "COUNTRY",
        },
        {
            processing_attribute_id: 2,
            processing_id: 1,
            name: "DB",
            type: "db_column",
            option_source: "biblio.title",
        },
        {
            processing_attribute_id: 3,
            processing_id: 1,
            name: "Height",
            type: "free_text",
            option_source: null,
        },
    ];
}
function get_other_attributes() {
    return [
        {
            processing_attribute_id: 4,
            processing_id: 2,
            name: "Country",
            type: "authorised_value",
            option_source: "COUNTRY",
        },
        {
            processing_attribute_id: 5,
            processing_id: 2,
            name: "Width",
            type: "free_text",
            option_source: null,
        },
    ];
}

function get_processings() {
    return [
        {
            name: "new processing",
            processing_id: 1,
            attributes: get_attributes(),
        },
        {
            name: "an other processing",
            processing_id: 2,
            attributes: get_other_attributes(),
        },
    ];
}

function get_items() {
    // This is not a full item but it contains the info we are using
    return [
        {
            biblio: {
                biblio_id: 1,
                title: "a biblio title",
            },
            external_id: "bc_1",
            item_id: 1,
        },
        {
            biblio: {
                biblio_id: 2,
                title: "an other biblio title",
            },
            external_id: "bc_2",
            item_id: 2,
        },
        {
            biblio: {
                biblio_id: 3,
                title: "yet an other biblio title",
            },
            external_id: "bc_3",
            item_id: 3,
        },
    ];
}

function get_train_items() {
    let train_item_1 = get_items()[0];
    let processing_attributes = get_attributes();
    train_item_1.attributes = [
        {
            processing_attribute: processing_attributes[0],
            processing_attribute_id:
                processing_attributes[0].processing_attribute_id,
            value: "Argentina",
        },
        {
            processing_attribute: processing_attributes[1],
            processing_attribute_id:
                processing_attributes[1].processing_attribute_id,
            value: "a biblio title modified",
        },
        {
            processing_attribute: processing_attributes[2],
            processing_attribute_id:
                processing_attributes[2].processing_attribute_id,
            value: "12cm",
        },
    ];
    train_item_1.added_on = "2023-03-31T12:23:34+00:00";
    train_item_1.processing_id = 1;
    train_item_1.item_id = 1;

    let train_item_2 = get_items()[1];
    let processing_attributes = get_attributes();
    train_item_2.attributes = [
        {
            processing_attribute: processing_attributes[0],
            processing_attribute_id:
                processing_attributes[0].processing_attribute_id,
            value: "Uruguay",
        },
        {
            processing_attribute: processing_attributes[1],
            processing_attribute_id:
                processing_attributes[1].processing_attribute_id,
            value: "an other modified title",
        },
        {
            processing_attribute: processing_attributes[2],
            processing_attribute_id:
                processing_attributes[2].processing_attribute_id,
            value: "34cm",
        },
    ];
    train_item_2.added_on = "2023-04-01T12:34:56+00:00";
    train_item_2.processing_id = 1;
    train_item_2.item_id = 2;

    let train_item_3 = get_items()[0];
    let processing_attributes = get_other_attributes();
    train_item_3.attributes = [
        {
            processing_attribute: processing_attributes[0],
            processing_attribute_id:
                processing_attributes[0].processing_attribute_id,
            value: "Bolivia",
        },
        {
            processing_attribute: processing_attributes[1],
            processing_attribute_id:
                processing_attributes[1].processing_attribute_id,
            value: "W 123cm",
        },
    ];
    train_item_3.added_on = "2023-04-02T12:34:56+00:00";
    train_item_3.processing_id = 2;
    train_item_3.item_id = 3;

    return [train_item_1, train_item_2, train_item_3];
}

function get_train() {
    let processings = get_processings();
    return {
        train_id: 1,
        name: "My train",
        description: "Just a train",
        default_processing_id: processings[0].processing_id,
        not_for_loan: "42",
        created_on: "2023-04-05T10:16:27+00:00",
        closed_on: null,
        sent_on: null,
        received_on: null,
        items: [],
        default_processing: processings[0],
    };
}

describe("Trains", () => {
    beforeEach(() => {
        cy.login();
        cy.title().should("eq", "Koha staff interface");
        cy.intercept(
            "GET",
            "/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationModule",
            '{"value":"1"}'
        );
        cy.intercept(
            "GET",
            "/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationNotForLoanWaitingListIn",
            '{"value":"24"}'
        );
        cy.intercept(
            "GET",
            "/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationNotForLoanDefaultTrainIn",
            '{"value":"42"}'
        );
        cy.intercept(
            "GET",
            "/api/v1/authorised_value_categories/NOT_LOAN/authorised_values",
            [
                {
                    category_name: "NOT_LOAN",
                    description: "Ordered",
                    value: "-1",
                },
                {
                    category_name: "NOT_LOAN",
                    description: "Not for loan",
                    value: "1",
                },
                {
                    category_name: "NOT_LOAN",
                    description: "Staff collection",
                    value: "2",
                },
                {
                    category_name: "NOT_LOAN",
                    description: "Added to bundle",
                    value: "3",
                },
                {
                    category_name: "NOT_LOAN",
                    description: "In preservation",
                    value: "24",
                },
                {
                    category_name: "NOT_LOAN",
                    description: "In preservation external",
                    value: "42",
                },
                {
                    category_name: "NOT_LOAN",
                    description: "In preservation other",
                    value: "43",
                },
            ]
        );
    });

    it("List trains", () => {
        // GET trains returns 500
        cy.intercept("GET", "/api/v1/preservation/trains*", {
            statusCode: 500,
            error: "Something went wrong",
        });
        cy.visit("/cgi-bin/koha/preservation/home.pl");
        cy.get("#navmenulist").contains("Trains").click();
        cy.get("main div[class='dialog alert']").contains(
            /Something went wrong/
        );

        // GET trains returns empty list
        cy.intercept("GET", "/api/v1/*", []);
        cy.visit("/cgi-bin/koha/preservation/trains");
        cy.get("#trains_list").contains("There are no trains defined");

        // GET trains returns something
        let train = get_train();
        let trains = [train];

        cy.intercept("GET", "/api/v1/preservation/trains*", {
            statusCode: 200,
            body: trains,
            headers: {
                "X-Base-Total-Count": "1",
                "X-Total-Count": "1",
            },
        });
        cy.intercept("GET", "/api/v1/preservation/trains/*", train);
        cy.visit("/cgi-bin/koha/preservation/trains");
        cy.get("#trains_list").contains("Showing 1 to 1 of 1 entries");
    });

    it("Add train", () => {
        cy.intercept("GET", "/api/v1/preservation/trains", []);
        cy.intercept(
            "GET",
            "/api/v1/preservation/processings",
            get_processings()
        );
        cy.visit("/cgi-bin/koha/preservation/trains");
        let train = get_train();
        cy.contains("New train").click();
        cy.get("#train_name").type(train.name);
        cy.get("#train_description").type(train.description);
        // Confirm that the default not_for_loan is selected
        cy.get("#not_for_loan .vs__selected").contains(
            "In preservation external"
        );
        // Change it
        cy.get("#not_for_loan .vs__search").type(
            "In preservation other{enter}"
        );
        cy.get("#train_default_processing .vs__search").type(
            "new processing{enter}"
        );

        // Submit the form, get 500
        cy.intercept("POST", "/api/v1/preservation/trains", {
            statusCode: 500,
            error: "Something went wrong",
        });
        cy.get("#trains_add").contains("Submit").click();
        cy.get("main div[class='dialog alert']").contains(
            "Something went wrong: Error: Internal Server Error"
        );

        // Submit the form, success!
        cy.intercept("POST", "/api/v1/preservation/trains", {
            statusCode: 201,
            body: train,
        });
        cy.get("#trains_add").contains("Submit").click();
        cy.get("main div[class='dialog message']").contains("Train created");
    });

    it("Edit train", () => {
        let train = get_train();
        let processings = get_processings();
        cy.intercept("GET", "/api/v1/preservation/trains/*", train);
        cy.intercept("GET", "/api/v1/preservation/trains", [train]);
        cy.intercept("GET", "/api/v1/preservation/processings*", processings);
        cy.visit("/cgi-bin/koha/preservation/trains");
        cy.get("#trains_list table tbody tr:first").contains("Edit").click();
        cy.get("#train_name").should("have.value", train.name);
        cy.get("#train_description").should("have.value", train.description);
        cy.get("#not_for_loan .vs__selected").contains(
            "In preservation external"
        );
        cy.get("#train_default_processing .vs__selected").contains(
            train.default_processing.name
        );

        // Submit the form, get 500
        cy.intercept("PUT", "/api/v1/preservation/trains/*", {
            statusCode: 500,
            error: "Something went wrong",
        });
        cy.get("#trains_add").contains("Submit").click();
        cy.get("main div[class='dialog alert']").contains(
            "Something went wrong: Error: Internal Server Error"
        );

        // Submit the form, success!
        cy.intercept("PUT", "/api/v1/preservation/trains/*", {
            statusCode: 200,
            body: train,
        });
        cy.intercept("GET", "/api/v1/preservation/trains", {
            statusCode: 200,
            body: [train],
        });
        cy.get("#trains_add").contains("Submit").click();
        cy.get("main div[class='dialog message']").contains("Train updated");
    });

    it("Simple show train", () => {
        let train = get_train();
        let trains = [train];

        cy.intercept("GET", "/api/v1/preservation/trains*", {
            statusCode: 200,
            body: trains,
            headers: {
                "X-Base-Total-Count": "1",
                "X-Total-Count": "1",
            },
        });
        cy.intercept("GET", "/api/v1/preservation/trains/*", train);
        cy.visit("/cgi-bin/koha/preservation/trains");
        let name_link = cy.get("#trains_list table tbody tr:first td:first a");
        name_link.should(
            "have.text",
            train.name + " (#" + train.train_id + ")"
        );
        name_link.click();
        cy.get("#trains_show h2").contains("Train #" + train.train_id);

        cy.contains("Name:" + train.name);
        cy.contains("Description:" + train.description);
        cy.contains(
            "Status for item added to this train:" + "In preservation external"
        );
        cy.contains("Default processing:" + train.default_processing.name);
    });

    it("Show train close, send, receive", () => {
        let train = get_train();
        cy.intercept("GET", "/api/v1/preservation/trains/" + train.train_id, {
            statusCode: 200,
            body: train,
        }).as("get-train");
        cy.visit("/cgi-bin/koha/preservation/trains/" + train.train_id);
        cy.wait("@get-train");
        cy.contains("Closed on:").should("not.exist");
        cy.contains("Sent on:").should("not.exist");
        cy.contains("Received on:").should("not.exist");

        let closed_train = Object.assign({}, train);
        closed_train.closed_on = "2022-10-27 12:34:56";
        cy.intercept("PUT", "/api/v1/preservation/trains/" + train.train_id, {
            statusCode: 201,
            body: closed_train,
        }).as("set-train");
        cy.intercept("GET", "/api/v1/preservation/trains/" + train.train_id, {
            statusCode: 200,
            body: closed_train,
        }).as("get-train");
        cy.get("#toolbar").contains("Close").click();
        cy.wait("@get-train");
        cy.contains("Closed on:").should("exist");
        cy.contains("Sent on:").should("not.exist");
        cy.contains("Received on:").should("not.exist");

        let sent_train = Object.assign({}, closed_train);
        sent_train.sent_on = "2022-10-28 12:34:56";
        cy.intercept("PUT", "/api/v1/preservation/trains/" + train.train_id, {
            statusCode: 201,
            body: sent_train,
        }).as("set-train");
        cy.intercept("GET", "/api/v1/preservation/trains/" + train.train_id, {
            statusCode: 200,
            body: sent_train,
        }).as("get-train");
        cy.get("#toolbar").contains("Send").click();
        cy.wait("@get-train");
        cy.contains("Closed on:").should("exist");
        cy.contains("Sent on:").should("exist");
        cy.contains("Received on:").should("not.exist");

        let received_train = Object.assign({}, sent_train);
        received_train.received_on = "2022-10-29 12:34:56";
        cy.intercept("PUT", "/api/v1/preservation/trains/" + train.train_id, {
            statusCode: 201,
            body: received_train,
        }).as("set-train");
        cy.intercept("GET", "/api/v1/preservation/trains/" + train.train_id, {
            statusCode: 200,
            body: received_train,
        }).as("get-train");
        cy.get("#toolbar").contains("Receive").click();
        cy.wait("@get-train");
        cy.contains("Closed on:").should("exist");
        cy.contains("Sent on:").should("exist");
        cy.contains("Received on:").should("exist");
    });

    it("Delete train", () => {
        let train = get_train();
        cy.intercept("GET", "/api/v1/preservation/trains*", {
            statusCode: 200,
            body: [train],
            headers: {
                "X-Base-Total-Count": "1",
                "X-Total-Count": "1",
            },
        });
        cy.visit("/cgi-bin/koha/preservation/trains");

        // Submit the form, get 500
        cy.intercept(
            "DELETE",
            "/api/v1/preservation/trains/" + train.train_id,
            {
                statusCode: 500,
                error: "Something went wrong",
            }
        );
        cy.get("#trains_list table tbody tr:first").contains("Delete").click();
        cy.contains("Yes, delete").click();
        cy.get("main div[class='dialog alert']").contains(
            "Something went wrong: Error: Internal Server Error"
        );

        // Submit the form, success!
        cy.intercept(
            "DELETE",
            "/api/v1/preservation/trains/" + train.train_id,
            {
                statusCode: 201,
                body: null,
            }
        );
        cy.get("#trains_list table tbody tr:first").contains("Delete").click();
        cy.contains("Yes, delete").click();
        cy.get("main div[class='dialog message']").contains(
            `Train ${train.name} deleted`
        );
    });

    it("Add new item to a train", () => {
        let train = get_train();
        cy.intercept(
            "GET",
            "/api/v1/preservation/trains/" + train.train_id,
            train
        );
        let processings = get_processings();
        cy.intercept("GET", "/api/v1/preservation/processings*", processings);
        cy.intercept(
            "GET",
            "/api/v1/preservation/processings/" + processings[0].processing_id,
            processings[0]
        );
        cy.visit("/cgi-bin/koha/preservation/trains/" + train.train_id);
        cy.contains("Add items").click();
        cy.get("#barcode").type("bc_1");
        cy.intercept("GET", "/api/v1/preservation/waiting-list/items*", []);
        cy.contains("Submit").click();
        cy.get("div[class='dialog alert modal']").contains(
            "Cannot find item with this barcode. It must be in the waiting list."
        );
        cy.get("#close_modal").click();

        let item = get_items()[0];
        cy.intercept("GET", "/api/v1/preservation/waiting-list/items*", [item]);
        cy.contains("Submit").click();
        cy.intercept(
            "POST",
            `/api/v1/preservation/trains/${train.train_id}/items`,
            {
                statusCode: 201,
                body: item, // Not correct but not important
            }
        );
        cy.contains("Itemnumber:" + item.item_id);
        cy.get("#processing .vs__selected").contains(
            train.default_processing.name
        );
        cy.contains("Country:");
        cy.get("#attribute_0 .vs__search").type("Argentin{enter}");
        cy.contains("DB:");
        cy.get("#attribute_1").should("have.value", item.biblio.title);
        cy.get("#attribute_1").type(" modified");
        cy.contains("Height:");
        cy.get("#attribute_2").type("42cm");

        let train_items = get_train_items();
        let train_with_one_item = Object.assign({}, train);
        train_with_one_item.items = [train_items[0]];

        cy.intercept(
            "GET",
            "/api/v1/preservation/trains/" + train.train_id,
            train_with_one_item
        );
        cy.contains("Submit").click();
        cy.get("#trains_show").contains("Showing 1 to 1 of 1 entries");

        let train_with_2_items = Object.assign({}, train);
        train_with_2_items.items = [train_items[0], train_items[1]];
        cy.intercept(
            "GET",
            "/api/v1/preservation/trains/" + train.train_id,
            train_with_2_items
        );
        cy.visit("/cgi-bin/koha/preservation/trains/" + train.train_id);
        cy.get("#trains_show table").should("exist");
        cy.get("#trains_show").contains("Showing 1 to 2 of 2 entries");
        train_with_2_items.items.forEach(train_item => {
            train_item.attributes.forEach(attribute => {
                cy.get("td").contains(attribute.value);
            });
        });

        let train_with_3_items = Object.assign({}, train);
        train_with_3_items.items = [
            train_items[0],
            train_items[1],
            train_items[2],
        ];
        cy.intercept(
            "GET",
            "/api/v1/preservation/trains/" + train.train_id,
            train_with_3_items
        );
        cy.visit("/cgi-bin/koha/preservation/trains/" + train.train_id);
        cy.get("#trains_show table").should("not.exist");
        train_with_3_items.items.forEach((train_item, i) => {
            train_item.attributes.forEach(attribute => {
                let re = new RegExp(attribute.value);
                cy.get(`#item_${i}`).contains(re);
            });
        });
    });
});




import { mount } from "@cypress/vue";

function get_items() {
    // This is not a full item but it contains the info we are using
    return [
        {
            biblio: {
                biblio_id: 1,
                title: "a biblio title",
            },
            external_id: "bc_1",
            item_id: 1,
        },
        {
            biblio: {
                biblio_id: 2,
                title: "yet another biblio title",
            },
            external_id: "bc_3",
            item_id: 3,
        },
    ];
}
describe("WaitingList", () => {
    beforeEach(() => {
        cy.login();
        cy.title().should("eq", "Koha staff interface");
        cy.intercept(
            "GET",
            "/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationModule",
            '{"value":"1"}'
        );
        cy.intercept(
            "GET",
            "/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationNotForLoanWaitingListIn",
            '{"value":"24"}'
        );
        cy.intercept(
            "GET",
            "/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationNotForLoanDefaultTrainIn",
            '{"value":"42"}'
        );
    });

    it("List", () => {
        cy.intercept(
            "GET",
            "/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationNotForLoanWaitingListIn",
            '{"value":""}'
        );
        cy.visit("/cgi-bin/koha/preservation/home.pl");
        cy.intercept("GET", "/api/v1/preservation/waiting-list/items*", []);
        cy.get("#navmenulist").contains("Waiting list").click();
        cy.get("#waiting-list").contains(
            "You need to configure this module first."
        );

        cy.intercept(
            "GET",
            "/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationNotForLoanWaitingListIn",
            '{"value":"42"}'
        );
        cy.visit("/cgi-bin/koha/preservation/home.pl");
        cy.intercept("GET", "/api/v1/preservation/waiting-list/items*", []);
        cy.get("#navmenulist").contains("Waiting list").click();
        cy.get("#waiting-list").contains(
            "There are no items in the waiting list"
        );
    });

    it("Add to waiting list", () => {
        cy.intercept("GET", "/api/v1/preservation/waiting-list/items*", []);
        cy.visit("/cgi-bin/koha/preservation/waiting-list");
        cy.intercept("POST", "/api/v1/preservation/waiting-list/items", {
            statusCode: 500,
            error: "Something went wrong",
        });
        cy.get("#waiting-list").contains("Add to waiting list").click();
        cy.get("#barcode_list").type("bc_1\nbc_2\nbc_3");
        cy.contains("Submit").click();
        cy.get("main div[class='dialog alert']").contains(
            "Something went wrong: Error: Internal Server Error"
        );

        cy.intercept("GET", "/api/v1/preservation/waiting-list/items*", {
            statusCode: 200,
            body: get_items(),
            headers: {
                "X-Base-Total-Count": "2",
                "X-Total-Count": "2",
            },
        }).as("get-items");
        cy.intercept("POST", "/api/v1/preservation/waiting-list/items", [
            { item_id: 1 },
            { item_id: 3 },
        ]);
        cy.get("#waiting-list").contains("Add to waiting list").click();
        cy.get("#barcode_list").type("bc_1\nbc_2\nbc_3");
        cy.contains("Submit").click();
        cy.wait("@get-items");
        cy.get("main div[class='dialog message']").contains(
            "2 new items added."
        );
    });

    it("Add to waiting list then add to a train", () => {
        let train = {
            description: "yet another train",
            name: "a train",
            train_id: 1,
        };
        cy.intercept("GET", "/api/v1/preservation/trains*", [train]);
        cy.visit("/cgi-bin/koha/preservation/waiting-list");

        cy.intercept("GET", "/api/v1/preservation/waiting-list/items*", {
            statusCode: 200,
            body: get_items(),
            headers: {
                "X-Base-Total-Count": "2",
                "X-Total-Count": "2",
            },
        }).as("get-items");
        cy.intercept("POST", "/api/v1/preservation/waiting-list/items", [
            { item_id: 1 },
            { item_id: 3 },
        ]);
        cy.get("#waiting-list").contains("Add to waiting list").click();
        cy.get("#barcode_list").type("bc_1\nbc_2\nbc_3");
        cy.contains("Submit").click();
        cy.wait("@get-items");
        cy.get("main div[class='dialog message']").contains(
            "2 new items added."
        );
        cy.contains("Add last 2 items to a train").click();
        cy.get("#train_id .vs__search").type(train.name + "{enter}");
        cy.intercept(
            "POST",
            "/api/v1/preservation/trains/" + train.train_id + "/items/batch",
            req => {
                req.reply({
                    statusCode: 201,
                    body: req.body,
                });
            }
        );
        cy.contains("Submit").click();
        cy.get("main div[class='dialog message']").contains(
            `2 items have been added to train ${train.train_id}.`
        );
    });

    it("Remove item from waiting list", () => {
        cy.intercept("GET", "/api/v1/preservation/waiting-list/items*", {
            statusCode: 200,
            body: get_items(),
            headers: {
                "X-Base-Total-Count": "2",
                "X-Total-Count": "2",
            },
        }); //.as("get-items")
        cy.visit("/cgi-bin/koha/preservation/waiting-list");

        // Submit the form, get 500
        cy.intercept("DELETE", "/api/v1/preservation/waiting-list/items/*", {
            statusCode: 500,
            error: "Something went wrong",
        });
        cy.get("#waiting-list table tbody tr:first").contains("Remove").click();
        cy.contains("Yes, remove").click();
        cy.get("main div[class='dialog alert']").contains(
            "Something went wrong: Error: Internal Server Error"
        );

        // Submit the form, success!
        cy.intercept("DELETE", "/api/v1/preservation/waiting-list/items/*", {
            statusCode: 204,
            body: null,
        });
        cy.get("#waiting-list table tbody tr:first").contains("Remove").click();
        cy.contains("Yes, remove").click();
        cy.get("main div[class='dialog message']").contains(
            `Item removed from the waiting list`
        );
    });
});




#!/usr/bin/perl

# This file is part of Koha
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.

use Modern::Perl;

use Test::More tests => 1;
use Test::Exception;
use Test::Warn;

use Koha::Preservation::Processings;
use Koha::Database;

use t::lib::TestBuilder;
use t::lib::Mocks;

my $schema  = Koha::Database->new->schema;
my $builder = t::lib::TestBuilder->new;

subtest 'attributes' => sub {

    plan tests => 4;

    $schema->storage->txn_begin;

    my $processing = $builder->build_object( { class => 'Koha::Preservation::Processings' } );

    my $attributes = [
        { name => 'color', type => 'authorised_value', option_source => 'COLORS' },
        { name => 'title', type => 'db_column',        option_source => '245$a' },
        {
            name => 'height',
            type => 'free_text'
        },
    ];
    $processing->attributes($attributes);
    my $fetched_attributes = $processing->attributes;
    is( ref($fetched_attributes),   'Koha::Preservation::Processing::Attributes' );
    is( $fetched_attributes->count, 3 );
    $processing->attributes( [] );
    is( ref($fetched_attributes),   'Koha::Preservation::Processing::Attributes' );
    is( $fetched_attributes->count, 0 );

    $schema->storage->txn_rollback;
};




#!/usr/bin/perl

# This file is part of Koha
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.

use Modern::Perl;

use Test::More tests => 2;
use Test::Exception;
use Test::Warn;

use Koha::Preservation::Trains;
use Koha::Database;

use t::lib::TestBuilder;
use t::lib::Mocks;

my $schema  = Koha::Database->new->schema;
my $builder = t::lib::TestBuilder->new;

subtest 'default_processing' => sub {

    plan tests => 3;

    $schema->storage->txn_begin;

    my $processing         = $builder->build_object( { class => 'Koha::Preservation::Processings' } );
    my $another_processing = $builder->build_object( { class => 'Koha::Preservation::Processings' } );

    my $train = $builder->build_object( { class => 'Koha::Preservation::Trains', value => { default_processing_id => $processing->processing_id } } );

    my $default_processing = $train->default_processing;
    is( ref($default_processing),           'Koha::Preservation::Processing', '->default_processing returns a Koha::Preservation::Processing object' );
    is( $default_processing->processing_id, $processing->processing_id,       'correct processing is returned' );
    $processing->delete;
    $default_processing = $train->get_from_storage->default_processing;
    is( $default_processing, undef, 'deleting the processing does not delete the train' );

    $schema->storage->txn_rollback;
};

subtest 'add_items & items' => sub {
    plan tests => 9;

    $schema->storage->txn_begin;

    my $not_for_loan_waiting_list_in = 24;
    my $not_for_loan_train_in        = 42;
    my $train = $builder->build_object(
        {
            class => 'Koha::Preservation::Trains',
            value => {
                not_for_loan => $not_for_loan_train_in,
                closed_on    => undef,
                sent_on      => undef,
                received_on  => undef
            }
        }
    );
    my $item_1 = $builder->build_sample_item;
    my $item_2 = $builder->build_sample_item;
    my $item_3 = $builder->build_sample_item;

    $builder->build_object( { class => 'Koha::AuthorisedValues', value => { category => 'NOT_LOAN', authorised_value => $not_for_loan_waiting_list_in } } );
    $item_1->notforloan($not_for_loan_waiting_list_in)->store;
    $item_2->notforloan(0)->store;    # item_2 is not in the waiting list
    $item_3->notforloan($not_for_loan_waiting_list_in)->store;
    t::lib::Mocks::mock_preference( 'PreservationNotForLoanWaitingListIn', $not_for_loan_waiting_list_in );
    warning_is {
        $train->add_items( [ { item_id => $item_1->itemnumber }, { item_id => $item_2->itemnumber }, { barcode => $item_3->barcode } ] );
    }
    'Item not added to train: [Cannot add item to train, it is not in the waiting list]';
    my $items_train = $train->items;
    is( $items_train->count, 2, '2 items added to the train' );
    my $item_train_1 = $items_train->find( { item_id => $item_1->itemnumber } );
    my $item_train_3 = $items_train->find( { item_id => $item_3->itemnumber } );
    my $catalogue_item_1 = $item_train_1->catalogue_item;
    is( ref($catalogue_item_1),        'Koha::Item' );
    is( $catalogue_item_1->notforloan, $not_for_loan_train_in );

    my $catalogue_item_3 = $item_train_3->catalogue_item;
    is( ref($catalogue_item_3),        'Koha::Item' );
    is( $catalogue_item_3->notforloan, $not_for_loan_train_in );

    is( $item_1->get_from_storage->notforloan, $not_for_loan_train_in );
    is( $item_2->get_from_storage->notforloan, 0 );
    is( $item_3->get_from_storage->notforloan, $not_for_loan_train_in );

    $schema->storage->txn_rollback;
};




#!/usr/bin/env perl

# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.

use Modern::Perl;

use Test::More tests => 5;
use Test::Mojo;

use t::lib::TestBuilder;
use t::lib::Mocks;

use Koha::Preservation::Processings;
use Koha::Database;

my $schema  = Koha::Database->new->schema;
my $builder = t::lib::TestBuilder->new;

my $t = Test::Mojo->new('Koha::REST::V1');
t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );

subtest 'list() tests' => sub {

    plan tests => 8;

    $schema->storage->txn_begin;

    Koha::Preservation::Processings->search->delete;

    my $librarian = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 2**30 }
        }
    );
    my $password = 'thePassword123';
    $librarian->set_password( { password => $password, skip_validation => 1 } );
    my $userid = $librarian->userid;

    my $patron = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 0 }
        }
    );

    $patron->set_password( { password => $password, skip_validation => 1 } );
    my $unauth_userid = $patron->userid;

    ## Authorized user tests
    # No processings, so empty array should be returned
    $t->get_ok("//$userid:$password@/api/v1/preservation/processings")->status_is(200)
      ->json_is( [] );

    my $processing = $builder->build_object(
        {
            class => 'Koha::Preservation::Processings',
        }
    );

    # One processing created, should get returned
    $t->get_ok("//$userid:$password@/api/v1/preservation/processings")->status_is(200)
      ->json_is( [ $processing->to_api ] );

    # Unauthorized access
    $t->get_ok("//$unauth_userid:$password@/api/v1/preservation/processings")
      ->status_is(403);

    $schema->storage->txn_rollback;
};

subtest 'get() tests' => sub {

    plan tests => 11;

    $schema->storage->txn_begin;

    my $processing =
      $builder->build_object( { class => 'Koha::Preservation::Processings' } );
    my $attributes = [
        {
            name          => 'color',
            type          => 'authorised_value',
            option_source => 'COLORS'
        },
        { name => 'title', type => 'db_column', option_source => '245$a' },
        {
            name => 'height',
            type => 'free_text'
        },
    ];
    $attributes = $processing->attributes($attributes);
    my $librarian = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 2**30 }
        }
    );
    my $password = 'thePassword123';
    $librarian->set_password( { password => $password, skip_validation => 1 } );
    my $userid = $librarian->userid;

    my $patron = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 0 }
        }
    );

    $patron->set_password( { password => $password, skip_validation => 1 } );
    my $unauth_userid = $patron->userid;

    # This processing exists, should get returned
    $t->get_ok( "//$userid:$password@/api/v1/preservation/processings/"
          . $processing->processing_id )->status_is(200)
      ->json_is( $processing->to_api );

    # Return one processing with attributes
    $t->get_ok( "//$userid:$password@/api/v1/preservation/processings/"
          . $processing->processing_id  => {'x-koha-embed' => 'attributes'} )->status_is(200)
      ->json_is( { %{ $processing->to_api }, attributes => $attributes->to_api });

    # Unauthorized access
    $t->get_ok( "//$unauth_userid:$password@/api/v1/preservation/processings/"
          . $processing->processing_id )->status_is(403);

    # Attempt to get non-existent processing
    my $processing_to_delete =
      $builder->build_object( { class => 'Koha::Preservation::Processings' } );
    my $non_existent_id = $processing_to_delete->processing_id;
    $processing_to_delete->delete;

    $t->get_ok("//$userid:$password@/api/v1/preservation/processings/$non_existent_id")
      ->status_is(404)->json_is( '/error' => 'Processing not found' );

    $schema->storage->txn_rollback;
};

subtest 'add() tests' => sub {

    plan tests => 15;

    $schema->storage->txn_begin;

    my $librarian = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 2**30 }
        }
    );
    my $password = 'thePassword123';
    $librarian->set_password( { password => $password, skip_validation => 1 } );
    my $userid = $librarian->userid;

    my $patron = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 0 }
        }
    );

    $patron->set_password( { password => $password, skip_validation => 1 } );
    my $unauth_userid = $patron->userid;

    my $default_processing = $builder->build_object({class => 'Koha::Preservation::Processings'});
    my $processing = {
        name             => "processing name",
    };

    # Unauthorized attempt to write
    $t->post_ok( "//$unauth_userid:$password@/api/v1/preservation/processings" => json =>
          $processing )->status_is(403);

    # Authorized attempt to write invalid data
    my $processing_with_invalid_field = {
        blah             => "processing Blah",
        %$processing,
    };

    $t->post_ok( "//$userid:$password@/api/v1/preservation/processings" => json =>
          $processing_with_invalid_field )->status_is(400)->json_is(
        "/errors" => [
            {
                message => "Properties not allowed: blah.",
                path    => "/body"
            }
        ]
          );

    # Authorized attempt to write
    my $processing_id =
      $t->post_ok(
        "//$userid:$password@/api/v1/preservation/processings" => json => $processing )
      ->status_is( 201, 'SWAGGER3.2.1' )->header_like(
        Location => qr|^/api/v1/preservation/processings/\d*|,
        'SWAGGER3.4.1'
    )->json_is( '/name'                   => $processing->{name} )
      ->tx->res->json->{processing_id};

    # Authorized attempt to create with null id
    $processing->{processing_id} = undef;
    $t->post_ok(
        "//$userid:$password@/api/v1/preservation/processings" => json => $processing )
      ->status_is(400)->json_has('/errors');

    # Authorized attempt to create with existing id
    $processing->{processing_id} = $processing_id;
    $t->post_ok(
        "//$userid:$password@/api/v1/preservation/processings" => json => $processing )
      ->status_is(400)->json_is(
        "/errors" => [
            {
                message => "Read-only.",
                path    => "/body/processing_id"
            }
        ]
      );

    $schema->storage->txn_rollback;
};

subtest 'update() tests' => sub {

    plan tests => 15;

    $schema->storage->txn_begin;

    my $librarian = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 2**30 }
        }
    );
    my $password = 'thePassword123';
    $librarian->set_password( { password => $password, skip_validation => 1 } );
    my $userid = $librarian->userid;

    my $patron = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 0 }
        }
    );

    $patron->set_password( { password => $password, skip_validation => 1 } );
    my $unauth_userid = $patron->userid;

    my $processing_id =
      $builder->build_object( { class => 'Koha::Preservation::Processings' } )->processing_id;

    # Unauthorized attempt to update
    $t->put_ok(
        "//$unauth_userid:$password@/api/v1/preservation/processings/$processing_id" =>
          json => { name => 'New unauthorized name change' } )->status_is(403);

    # Attempt partial update on a PUT
    my $processing_with_missing_field = {
    };

    $t->put_ok(
        "//$userid:$password@/api/v1/preservation/processings/$processing_id" => json =>
          $processing_with_missing_field )->status_is(400)
      ->json_is( "/errors" =>
          [ { message => "Missing property.", path => "/body/name" } ] );

    my $default_processing = $builder->build_object({class => 'Koha::Preservation::Processings'});
    # Full object update on PUT
    my $processing_with_updated_field = {
        name => "New name",
    };

    $t->put_ok(
        "//$userid:$password@/api/v1/preservation/processings/$processing_id" => json =>
          $processing_with_updated_field )->status_is(200)
      ->json_is( '/name' => 'New name' );

    # Authorized attempt to write invalid data
    my $processing_with_invalid_field = {
        blah             => "processing Blah",
        %$processing_with_updated_field,
    };

    $t->put_ok(
        "//$userid:$password@/api/v1/preservation/processings/$processing_id" => json =>
          $processing_with_invalid_field )->status_is(400)->json_is(
        "/errors" => [
            {
                message => "Properties not allowed: blah.",
                path    => "/body"
            }
        ]
          );

    # Attempt to update non-existent processing
    my $processing_to_delete =
      $builder->build_object( { class => 'Koha::Preservation::Processings' } );
    my $non_existent_id = $processing_to_delete->processing_id;
    $processing_to_delete->delete;

    $t->put_ok( "//$userid:$password@/api/v1/preservation/processings/$non_existent_id" =>
          json => $processing_with_updated_field )->status_is(404);

    # Wrong method (POST)
    $processing_with_updated_field->{processing_id} = 2;

    $t->post_ok(
        "//$userid:$password@/api/v1/preservation/processings/$processing_id" => json =>
          $processing_with_updated_field )->status_is(404);

    $schema->storage->txn_rollback;
};

subtest 'delete() tests' => sub {

    plan tests => 7;

    $schema->storage->txn_begin;

    my $librarian = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 2**30 }
        }
    );
    my $password = 'thePassword123';
    $librarian->set_password( { password => $password, skip_validation => 1 } );
    my $userid = $librarian->userid;

    my $patron = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 0 }
        }
    );

    $patron->set_password( { password => $password, skip_validation => 1 } );
    my $unauth_userid = $patron->userid;

    my $processing_id =
      $builder->build_object( { class => 'Koha::Preservation::Processings' } )->processing_id;

    # Unauthorized attempt to delete
    $t->delete_ok(
        "//$unauth_userid:$password@/api/v1/preservation/processings/$processing_id")
      ->status_is(403);

    # Delete existing processing
    $t->delete_ok("//$userid:$password@/api/v1/preservation/processings/$processing_id")
      ->status_is( 204, 'SWAGGER3.2.4' )->content_is( '', 'SWAGGER3.3.4' );

    # Attempt to delete non-existent processing
    $t->delete_ok("//$userid:$password@/api/v1/preservation/processings/$processing_id")
      ->status_is(404);

    $schema->storage->txn_rollback;
};




#!/usr/bin/env perl

# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.

use Modern::Perl;

use Test::More tests => 6;
use Test::Mojo;

use t::lib::TestBuilder;
use t::lib::Mocks;

use Koha::Preservation::Trains;
use Koha::Database;

my $schema  = Koha::Database->new->schema;
my $builder = t::lib::TestBuilder->new;

my $t = Test::Mojo->new('Koha::REST::V1');
t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );

subtest 'list() tests' => sub {

    plan tests => 8;

    $schema->storage->txn_begin;

    Koha::Preservation::Trains->search->delete;

    my $librarian = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 2**30 }
        }
    );
    my $password = 'thePassword123';
    $librarian->set_password( { password => $password, skip_validation => 1 } );
    my $userid = $librarian->userid;

    my $patron = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 0 }
        }
    );

    $patron->set_password( { password => $password, skip_validation => 1 } );
    my $unauth_userid = $patron->userid;

    ## Authorized user tests
    # No trains, so empty array should be returned
    $t->get_ok("//$userid:$password@/api/v1/preservation/trains")->status_is(200)
      ->json_is( [] );

    my $train = $builder->build_object(
        {
            class => 'Koha::Preservation::Trains',
        }
    );

    # One train created, should get returned
    $t->get_ok("//$userid:$password@/api/v1/preservation/trains")->status_is(200)
      ->json_is( [ $train->to_api ] );

    # Unauthorized access
    $t->get_ok("//$unauth_userid:$password@/api/v1/preservation/trains")
      ->status_is(403);

    $schema->storage->txn_rollback;
};

subtest 'get() tests' => sub {

    plan tests => 14;

    $schema->storage->txn_begin;

    my $train =
      $builder->build_object( { class => 'Koha::Preservation::Trains' } );
    my $default_processing = $train->default_processing;
    my $librarian = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 2**30 }
        }
    );
    my $password = 'thePassword123';
    $librarian->set_password( { password => $password, skip_validation => 1 } );
    my $userid = $librarian->userid;

    my $patron = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 0 }
        }
    );

    $patron->set_password( { password => $password, skip_validation => 1 } );
    my $unauth_userid = $patron->userid;

    # This train exists, should get returned
    $t->get_ok( "//$userid:$password@/api/v1/preservation/trains/"
          . $train->train_id )->status_is(200)
      ->json_is( $train->to_api );

    # Return one train with some embeds
    $t->get_ok( "//$userid:$password@/api/v1/preservation/trains/"
          . $train->train_id  => {'x-koha-embed' => 'items,default_processing'} )->status_is(200)
      ->json_is( { %{ $train->to_api }, items => [], default_processing => $default_processing->unblessed });

    # Return one train with all embeds
    $t->get_ok( "//$userid:$password@/api/v1/preservation/trains/"
          . $train->train_id => { 'x-koha-embed' => 'items,items.attributes,items.attributes.processing_attribute,default_processing,default_processing.attributes' } )
      ->status_is(200)->json_is( { %{ $train->to_api }, items => [], default_processing => { %{ $default_processing->unblessed }, attributes => [] } } );

    # Unauthorized access
    $t->get_ok( "//$unauth_userid:$password@/api/v1/preservation/trains/"
          . $train->train_id )->status_is(403);

    # Attempt to get non-existent train
    my $train_to_delete =
      $builder->build_object( { class => 'Koha::Preservation::Trains' } );
    my $non_existent_id = $train_to_delete->train_id;
    $train_to_delete->delete;

    $t->get_ok("//$userid:$password@/api/v1/preservation/trains/$non_existent_id")
      ->status_is(404)->json_is( '/error' => 'Train not found' );

    $schema->storage->txn_rollback;
};

subtest 'add() tests' => sub {

    plan tests => 18;

    $schema->storage->txn_begin;

    my $librarian = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 2**30 }
        }
    );
    my $password = 'thePassword123';
    $librarian->set_password( { password => $password, skip_validation => 1 } );
    my $userid = $librarian->userid;

    my $patron = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 0 }
        }
    );

    $patron->set_password( { password => $password, skip_validation => 1 } );
    my $unauth_userid = $patron->userid;

    my $default_processing = $builder->build_object({class => 'Koha::Preservation::Processings'});
    my $train = {
        name             => "train name",
        description      => "train description",
        default_processing_id => $default_processing->processing_id,
        not_for_loan => 42,
    };

    # Unauthorized attempt to write
    $t->post_ok( "//$unauth_userid:$password@/api/v1/preservation/trains" => json =>
          $train )->status_is(403);

    # Authorized attempt to write invalid data
    my $train_with_invalid_field = {
        blah             => "train Blah",
        %$train,
    };

    $t->post_ok( "//$userid:$password@/api/v1/preservation/trains" => json =>
          $train_with_invalid_field )->status_is(400)->json_is(
        "/errors" => [
            {
                message => "Properties not allowed: blah.",
                path    => "/body"
            }
        ]
          );

    # Authorized attempt to write
    my $train_id =
      $t->post_ok(
        "//$userid:$password@/api/v1/preservation/trains" => json => $train )
      ->status_is( 201, 'SWAGGER3.2.1' )->header_like(
        Location => qr|^/api/v1/preservation/trains/\d*|,
        'SWAGGER3.4.1'
    )->json_is( '/name'                   => $train->{name} )
      ->json_is( '/description'           => $train->{description} )
      ->json_is( '/default_processing_id' => $train->{default_processing_id} )
      ->json_is( '/not_for_loan'          => $train->{not_for_loan} )
      ->tx->res->json->{train_id};

    # Authorized attempt to create with null id
    $train->{train_id} = undef;
    $t->post_ok(
        "//$userid:$password@/api/v1/preservation/trains" => json => $train )
      ->status_is(400)->json_has('/errors');

    # Authorized attempt to create with existing id
    $train->{train_id} = $train_id;
    $t->post_ok(
        "//$userid:$password@/api/v1/preservation/trains" => json => $train )
      ->status_is(400)->json_is(
        "/errors" => [
            {
                message => "Read-only.",
                path    => "/body/train_id"
            }
        ]
      );

    $schema->storage->txn_rollback;
};

subtest 'update() tests' => sub {

    plan tests => 15;

    $schema->storage->txn_begin;

    my $librarian = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 2**30 }
        }
    );
    my $password = 'thePassword123';
    $librarian->set_password( { password => $password, skip_validation => 1 } );
    my $userid = $librarian->userid;

    my $patron = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 0 }
        }
    );

    $patron->set_password( { password => $password, skip_validation => 1 } );
    my $unauth_userid = $patron->userid;

    my $train_id =
      $builder->build_object( { class => 'Koha::Preservation::Trains' } )->train_id;

    # Unauthorized attempt to update
    $t->put_ok(
        "//$unauth_userid:$password@/api/v1/preservation/trains/$train_id" =>
          json => { name => 'New unauthorized name change' } )->status_is(403);

    # Attempt partial update on a PUT
    my $train_with_missing_field = {
    };

    $t->put_ok(
        "//$userid:$password@/api/v1/preservation/trains/$train_id" => json =>
          $train_with_missing_field )->status_is(400)
      ->json_is( "/errors" =>
          [ { message => "Missing property.", path => "/body/name" } ] );

    my $default_processing = $builder->build_object({class => 'Koha::Preservation::Processings'});
    # Full object update on PUT
    my $train_with_updated_field = {
        name             => "New name",
        description      => "train description",
        default_processing_id => $default_processing->processing_id,
        not_for_loan => 42,
    };

    $t->put_ok(
        "//$userid:$password@/api/v1/preservation/trains/$train_id" => json =>
          $train_with_updated_field )->status_is(200)
      ->json_is( '/name' => 'New name' );

    # Authorized attempt to write invalid data
    my $train_with_invalid_field = {
        blah             => "train Blah",
        %$train_with_updated_field,
    };

    $t->put_ok(
        "//$userid:$password@/api/v1/preservation/trains/$train_id" => json =>
          $train_with_invalid_field )->status_is(400)->json_is(
        "/errors" => [
            {
                message => "Properties not allowed: blah.",
                path    => "/body"
            }
        ]
          );

    # Attempt to update non-existent train
    my $train_to_delete =
      $builder->build_object( { class => 'Koha::Preservation::Trains' } );
    my $non_existent_id = $train_to_delete->train_id;
    $train_to_delete->delete;

    $t->put_ok( "//$userid:$password@/api/v1/preservation/trains/$non_existent_id" =>
          json => $train_with_updated_field )->status_is(404);

    # Wrong method (POST)
    $train_with_updated_field->{train_id} = 2;

    $t->post_ok(
        "//$userid:$password@/api/v1/preservation/trains/$train_id" => json =>
          $train_with_updated_field )->status_is(404);

    $schema->storage->txn_rollback;
};

subtest 'delete() tests' => sub {

    plan tests => 7;

    $schema->storage->txn_begin;

    my $librarian = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 2**30 }
        }
    );
    my $password = 'thePassword123';
    $librarian->set_password( { password => $password, skip_validation => 1 } );
    my $userid = $librarian->userid;

    my $patron = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 0 }
        }
    );

    $patron->set_password( { password => $password, skip_validation => 1 } );
    my $unauth_userid = $patron->userid;

    my $train_id =
      $builder->build_object( { class => 'Koha::Preservation::Trains' } )->train_id;

    # Unauthorized attempt to delete
    $t->delete_ok(
        "//$unauth_userid:$password@/api/v1/preservation/trains/$train_id")
      ->status_is(403);

    # Delete existing train
    $t->delete_ok("//$userid:$password@/api/v1/preservation/trains/$train_id")
      ->status_is( 204, 'SWAGGER3.2.4' )->content_is( '', 'SWAGGER3.3.4' );

    # Attempt to delete non-existent train
    $t->delete_ok("//$userid:$password@/api/v1/preservation/trains/$train_id")
      ->status_is(404);

    $schema->storage->txn_rollback;
};

subtest '*_item() tests' => sub {

    plan tests => 26;

    $schema->storage->txn_begin;

    my $librarian = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 2**30 }
        }
    );
    my $password = 'thePassword123';
    $librarian->set_password( { password => $password, skip_validation => 1 } );
    my $userid = $librarian->userid;

    my $not_for_loan_waiting_list_in = 24;
    my $not_for_loan_train_in        = 42;

    t::lib::Mocks::mock_preference( 'PreservationNotForLoanWaitingListIn',
        $not_for_loan_waiting_list_in );

    my $default_processing =
      $builder->build_object( { class => 'Koha::Preservation::Processings' } );
    my $another_processing =
      $builder->build_object( { class => 'Koha::Preservation::Processings' } );

    my $attributes = [
        {
            name          => 'color',
            type          => 'authorised_value',
            option_source => 'COLORS'
        },
        { name => 'title', type => 'db_column', option_source => '245$a' },
        {
            name => 'height',
            type => 'free_text'
        },
    ];
    my $processing_attributes = $default_processing->attributes($attributes);
    my $color_attribute =
      $processing_attributes->search( { name => 'color' } )->next;
    my $title_attribute =
      $processing_attributes->search( { name => 'title' } )->next;
    my $height_attribute =
      $processing_attributes->search( { name => 'height' } )->next;

    my $train = $builder->build_object(
        {
            class => 'Koha::Preservation::Trains',
            value => {
                not_for_loan          => $not_for_loan_train_in,
                default_processing_id => $default_processing->processing_id,
                closed_on             => undef,
                sent_on               => undef,
                received_on           => undef,
            }
        }
    );
    my $train_id = $train->train_id;

    my $item_1 = $builder->build_sample_item;
    my $item_2 = $builder->build_sample_item;
    my $item_3 = $builder->build_sample_item;

    # Add item not in waiting list
    $t->post_ok(
        "//$userid:$password@/api/v1/preservation/trains/$train_id/items" =>
          json => { item_id => $item_1->itemnumber } )->status_is(400)
      ->json_is( { error => 'Item not in waiting list' } );

    $item_1->notforloan($not_for_loan_waiting_list_in)->store;

    # Add item in waiting list
    my $item_attributes = [
        {
            processing_attribute_id => $color_attribute->processing_attribute_id,
            value => 'red'
        },
        {
            processing_attribute_id => $title_attribute->processing_attribute_id,
            value => 'my title'
        },
    ];
    my $train_item_id =
      $t->post_ok(
        "//$userid:$password@/api/v1/preservation/trains/$train_id/items" =>
          json =>
          { item_id => $item_1->itemnumber, attributes => $item_attributes } )
      ->status_is( 201, 'SWAGGER3.2.1' )
      ->json_is( '/item_id'       => $item_1->itemnumber )
      ->json_is( '/processing_id' => $train->default_processing_id )
      ->json_has('/added_on')->tx->res->json->{train_item_id};
    my $train_item = Koha::Preservation::Train::Items->find($train_item_id);

    $t->get_ok(
        "//$userid:$password@/api/v1/preservation/trains/$train_id/items/$train_item_id"
          => { 'x-koha-embed' => 'attributes' } )->status_is(200)->json_is(
        {
            %{ $train_item->to_api },
            attributes => $train_item->attributes->to_api
        }
          );

    is( $item_1->get_from_storage->notforloan,
        $train->not_for_loan,
        "Item not for loan has been set to train's not for loan" );

    # Add deleted item
    $item_2->delete;
    $t->post_ok(
        "//$userid:$password@/api/v1/preservation/trains/$train_id/items" =>
          json => { item_id => $item_2->itemnumber } )->status_is(404)
      ->json_is( { error => 'Item not found' } );

    # Update item
    my $new_item_attributes = [
        {
            processing_attribute_id => $title_attribute->processing_attribute_id,
            value => 'my new title'
        },
        {
            processing_attribute_id => $height_attribute->processing_attribute_id,
            value => '24cm'
        },
    ];
    $t->put_ok(
        "//$userid:$password@/api/v1/preservation/trains/$train_id/items/$train_item_id"
          => json => {
            item_id    => $item_1->itemnumber,
            attributes => $new_item_attributes,
          }
    )->status_is(200);

    $t->get_ok(
        "//$userid:$password@/api/v1/preservation/trains/$train_id/items/$train_item_id"
          => { 'x-koha-embed' => 'attributes' } )->status_is(200)->json_is(
        {
            %{ $train_item->to_api },
            attributes => $train_item->attributes->to_api
        }
          );

    # Delete existing item
    $t->delete_ok("//$userid:$password@/api/v1/preservation/trains/$train_id/items/$train_item_id")
      ->status_is( 204, 'SWAGGER3.2.4' )->content_is( '', 'SWAGGER3.3.4' );

    # Delete non existing item
    $t->delete_ok("//$userid:$password@/api/v1/preservation/trains/$train_id/items/$train_item_id")
      ->status_is(404)->json_is( '/error' => 'Train item not found' );

    $schema->storage->txn_rollback;
};




#!/usr/bin/env perl

# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.

use Modern::Perl;

use Test::More tests => 1;
use Test::Mojo;
use Test::Warn;

use t::lib::TestBuilder;
use t::lib::Mocks;

use Koha::Preservation::Trains;
use Koha::Database;
use Koha::DateUtils qw( dt_from_string );

my $schema  = Koha::Database->new->schema;
my $builder = t::lib::TestBuilder->new;

my $t = Test::Mojo->new('Koha::REST::V1');
t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );

subtest 'add_item, list, remove_item tests' => sub {

    plan tests => 34;

    $schema->storage->txn_begin;

    my $librarian = $builder->build_object(
        {
            class => 'Koha::Patrons',
            value => { flags => 2**30 }
        }
    );
    my $password = 'thePassword123';
    $librarian->set_password( { password => $password, skip_validation => 1 } );
    my $userid = $librarian->userid;

    my $item_1 = $builder->build_sample_item;
    my $item_2 = $builder->build_sample_item;
    my $item_3 = $builder->build_sample_item;

    t::lib::Mocks::mock_preference( 'PreservationNotForLoanWaitingListIn', undef );
    $t->get_ok("//$userid:$password@/api/v1/preservation/waiting-list/items")
      ->status_is(400)->json_is(
        {
            error     => 'MissingSettings',
            parameter => 'PreservationNotForLoanWaitingListIn'
        }
      );

    my $not_for_loan_waiting_list_in = 24;
    t::lib::Mocks::mock_preference( 'PreservationNotForLoanWaitingListIn',
        $not_for_loan_waiting_list_in );

    $t->get_ok("//$userid:$password@/api/v1/preservation/waiting-list/items")
      ->status_is(200)->json_is( [] );

    # Add items
    $t->post_ok(
        "//$userid:$password@/api/v1/preservation/waiting-list/items" =>
          json => [
            { item_id => $item_1->itemnumber },
            { barcode => $item_3->barcode }
          ]
    )->status_is(201)->json_is(
        [
            { item_id => $item_1->itemnumber },
            { item_id => $item_3->itemnumber }
        ]
    );

    is( $item_1->get_from_storage->notforloan, $not_for_loan_waiting_list_in );
    is( $item_2->get_from_storage->notforloan, 0 );
    is( $item_3->get_from_storage->notforloan, $not_for_loan_waiting_list_in );

    $t->post_ok(
        "//$userid:$password@/api/v1/preservation/waiting-list/items" =>
          json => [
            { item_id => $item_2->itemnumber },
            { barcode => $item_3->barcode }
          ]
    )->status_is(201)->json_is( [ { item_id => $item_2->itemnumber } ] );

    is( $item_1->get_from_storage->notforloan, $not_for_loan_waiting_list_in );
    is( $item_2->get_from_storage->notforloan, $not_for_loan_waiting_list_in );
    is( $item_3->get_from_storage->notforloan, $not_for_loan_waiting_list_in );

    $t->delete_ok(
        "//$userid:$password@/api/v1/preservation/waiting-list/items/"
          . $item_2->itemnumber )->status_is(204);

    is( $item_2->get_from_storage->notforloan, 0,
        "Item removed from the waiting list has its notforloan status back to 0"
    );

    # Add item_1 to a non-received train
    my $train = $builder->build_object(
        {
            class => 'Koha::Preservation::Trains',
            value => {
                not_for_loan => 42,
                closed_on    => undef,
                sent_on      => undef,
                received_on  => undef
            }
        }
    );
    $train->add_item( { item_id => $item_1->itemnumber } );

    # And try to add it to the waiting list
    warning_like {
        $t->post_ok(
            "//$userid:$password@/api/v1/preservation/waiting-list/items" =>
              json => [ { item_id => $item_1->itemnumber } ] )->status_is(201)
          ->json_is( [] );
    }
    qr[Cannot add item to waiting list, it is already in a non-received train];

    # Add item_3 to a train, receive the train and add the item to the waiting list
    $train = $builder->build_object(
        {
            class => 'Koha::Preservation::Trains',
            value => {
                not_for_loan => 42,
                closed_on    => undef,
                sent_on      => undef,
                received_on  => undef
            }
        }
    );
    $train->add_item( { item_id => $item_3->itemnumber } );
    $train->received_on(dt_from_string)->store;

    $t->post_ok(
        "//$userid:$password@/api/v1/preservation/waiting-list/items" =>
          json => [ { item_id => $item_3->itemnumber } ] )->status_is(201)
      ->json_is( [ { item_id => $item_3->itemnumber } ] );

    $t->delete_ok(
        "//$userid:$password@/api/v1/preservation/waiting-list/items/"
          . $item_2->itemnumber )->status_is(204);

    $item_2->delete;
    $t->delete_ok("//$userid:$password@/api/v1/preservation/waiting-list/items")
      ->status_is(404);

    $t->delete_ok(
        "//$userid:$password@/api/v1/preservation/waiting-list/items/"
          . $item_2->itemnumber )->status_is(404);

    $schema->storage->txn_rollback;
};

Return to bug 30708

Line 0 Link Here

(-)a/t/cypress/integration/Preservation/Settings.ts (+254 lines)
		1	import { mount } from "@cypress/vue";
		2
		3	function get_attributes() {
		4	return [
		5	{
		6	processing_attribute_id: 1,
		7	processing_id: 1,
		8	name: "Country",
		9	type: "authorised_value",
		10	option_source: "COUNTRY",
		11	},
		12	{
		13	processing_attribute_id: 1,
		14	processing_id: 1,
		15	name: "DB",
		16	type: "db_column",
		17	option_source: "biblio.title",
		18	},
		19	{
		20	processing_attribute_id: 1,
		21	processing_id: 1,
		22	name: "Height",
		23	type: "free_text",
		24	option_source: null,
		25	},
		26	];
		27	}
		28	function get_processing() {
		29	return {
		30	name: "test processing",
		31	processing_id: 1,
		32	attributes: get_attributes(),
		33	};
		34	}
		35	describe("Processings", () => {
		36	beforeEach(() => {
		37	cy.login();
		38	cy.title().should("eq", "Koha staff interface");
		39	cy.intercept(
		40	"GET",
		41	"/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationModule",
		42	'{"value":"1"}'
		43	);
		44	cy.intercept(
		45	"GET",
		46	"/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationNotForLoanWaitingListIn",
		47	'{"value":"24"}'
		48	);
		49	cy.intercept(
		50	"GET",
		51	"/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationNotForLoanDefaultTrainIn",
		52	'{"value":"42"}'
		53	);
		54	cy.intercept(
		55	"GET",
		56	"/api/v1/authorised_value_categories/NOT_LOAN/authorised_values",
		57	[
		58	{
		59	category_name: "NOT_LOAN",
		60	description: "Ordered",
		61	value: "-1",
		62	},
		63	{
		64	category_name: "NOT_LOAN",
65	description: "Not for loan",
66	value: "1",
67	},
68	{
69	category_name: "NOT_LOAN",
70	description: "Staff collection",
71	value: "2",
72	},
73	{
74	category_name: "NOT_LOAN",
75	description: "Added to bundle",
76	value: "3",
77	},
78	{
79	category_name: "NOT_LOAN",
80	description: "In preservation",
81	value: "24",
82	},
83	{
84	category_name: "NOT_LOAN",
85	description: "In preservation external",
86	value: "42",
87	},
88	]
89	);
90	});
91
92	it("Settings", () => {
93	cy.visit("/cgi-bin/koha/preservation/home.pl");
94	cy.get("#navmenulist").contains("Settings").click();
95	cy.get("#not_for_loan_waiting_list_in .vs__selected").contains(
96	"In preservation"
97	);
98	cy.get("#not_for_loan_default_train_in .vs__selected").contains(
99	"In preservation external"
100	);
101	});
102	it("List processing", () => {
103	cy.intercept("GET", "/api/v1/preservation/processings*", []);
104	cy.visit("/cgi-bin/koha/preservation/settings");
105	cy.get("#processing_0").should("not.exist");
106	cy.intercept("GET", "/api/v1/preservation/processings*", [
107	get_processing(),
108	]);
109	cy.visit("/cgi-bin/koha/preservation/settings");
110	cy.get("#processing_0").should("exist");
111	});
112
113	it("Add processing", () => {
114	cy.intercept("GET", "/api/v1/preservation/processings*", []);
115	cy.visit("/cgi-bin/koha/preservation/settings");
116	let processing = get_processing();
117	cy.contains("Add new processing").click();
118	cy.get("#processing_name").type(processing.name);
119	cy.contains("Add new attribute").click();
120	let attribute = processing.attributes[0];
121	cy.get("#attribute_name_0").type(attribute.name);
122	cy.get("#attribute_type_0 .vs__search").type("Authorized{enter}", {
123	force: true,
124	});
125	cy.get("#attribute_option_0 .vs__search").type(
126	attribute.option_source + "{enter}",
127	{ force: true }
128	);
129	cy.contains("Add new attribute").click();
130	attribute = processing.attributes[1];
131	cy.get("#attribute_name_1").type(attribute.name);
132	cy.get("#attribute_type_1 .vs__search").type("Database{enter}", {
133	force: true,
134	});
135	cy.get("#attribute_option_1 .vs__search").type(
136	attribute.option_source + "{enter}",
137	{ force: true }
138	);
139	cy.contains("Add new attribute").click();
140	attribute = processing.attributes[2];
141	cy.get("#attribute_name_2").type(attribute.name);
142	cy.get("#attribute_type_2 .vs__search").type("Free{enter}", {
143	force: true,
144	});
145
146	// Submit the form, get 500
147	cy.intercept("POST", "/api/v1/preservation/processings", {
148	statusCode: 500,
149	error: "Something went wrong",
150	});
151	cy.get("#processings_add").contains("Submit").click();
152	cy.get("main div[class='dialog alert']").contains(
153	"Something went wrong: Error: Internal Server Error"
154	);
155
156	// Submit the form, success!
157	cy.intercept("POST", "/api/v1/preservation/processings", {
158	statusCode: 201,
159	body: processing,
160	});
161	cy.intercept("GET", "/api/v1/preservation/processings*", {
162	statusCode: 200,
163	body: [processing],
164	});
165	cy.get("#processings_add").contains("Submit").click();
166	cy.get("main div[class='dialog message']").contains(
167	"Processing created"
168	);
169	cy.get("#processing_0").contains(processing.name);
170	});
171
172	it("Edit processing", () => {
173	let processing = get_processing();
174	cy.intercept("GET", "/api/v1/preservation/processings/*", {
175	statusCode: 200,
176	body: processing,
177	});
178	cy.intercept("GET", "/api/v1/preservation/processings*", {
179	statusCode: 200,
180	body: [processing],
181	});
182	cy.visit("/cgi-bin/koha/preservation/settings");
183	cy.get("#processing_0").contains(processing.name);
184	cy.get("#processing_0").contains("Edit this processing").click();
185	cy.get("#processing_name").should("have.value", processing.name);
186	let attribute = processing.attributes[0];
187	cy.get("#attribute_name_0").should("have.value", attribute.name);
188	cy.get("#attribute_type_0 .vs__selected").contains("Authorized value");
189	cy.get("#attribute_option_0 .vs__selected").contains(
190	attribute.option_source
191	);
192	attribute = processing.attributes[1];
193	cy.get("#attribute_name_1").should("have.value", attribute.name);
194	cy.get("#attribute_type_1 .vs__selected").contains("Database column");
195	cy.get("#attribute_option_1 .vs__selected").contains(
196	attribute.option_source
197	);
198	attribute = processing.attributes[2];
199	cy.get("#attribute_name_2").should("have.value", attribute.name);
200	cy.get("#attribute_type_2 .vs__selected").contains("Free text");
201	cy.get("#attribute_option_2").should("not.exist");
202
203	// Submit the form, get 500
204	cy.intercept("PUT", "/api/v1/preservation/processings/*", {
205	statusCode: 500,
206	error: "Something went wrong",
207	});
208	cy.get("#processings_add").contains("Submit").click();
209	cy.get("main div[class='dialog alert']").contains(
210	"Something went wrong: Error: Internal Server Error"
211	);
212
213	// Submit the form, success!
214	cy.intercept("PUT", "/api/v1/preservation/processings/*", {
215	statusCode: 200,
216	body: processing,
217	});
218	cy.get("#processings_add").contains("Submit").click();
219	cy.get("main div[class='dialog message']").contains(
220	"Processing updated"
221	);
222	});
223
224	it("Delete processing", () => {
225	let processing = get_processing();
226	cy.intercept("GET", "/api/v1/preservation/processings*", {
227	statusCode: 200,
228	body: [processing],
229	});
230
231	// Submit the form, get 500
232	cy.intercept("DELETE", "/api/v1/preservation/processings/*", {
233	statusCode: 500,
234	error: "Something went wrong",
235	});
236	cy.visit("/cgi-bin/koha/preservation/settings");
237	cy.get("#processing_0").contains("Remove this processing").click();
238	cy.contains("Yes, delete").click();
239	cy.get("main div[class='dialog alert']").contains(
240	"Something went wrong: Error: Internal Server Error"
241	);
242
243	// Submit the form, success!
244	cy.intercept("DELETE", "/api/v1/preservation/processings/*", {
245	statusCode: 204,
246	body: null,
247	});
248	cy.get("#processing_0").contains("Remove this processing").click();
249	cy.contains("Yes, delete").click();
250	cy.get("main div[class='dialog message']").contains(
251	`Processing ${processing.name} deleted`
252	);
253	});
254	});

Line 0 Link Here

(-)a/t/cypress/integration/Preservation/WaitingList.ts (+185 lines)
		1	import { mount } from "@cypress/vue";
		2
		3	function get_items() {
		4	// This is not a full item but it contains the info we are using
		5	return [
		6	{
		7	biblio: {
		8	biblio_id: 1,
		9	title: "a biblio title",
		10	},
		11	external_id: "bc_1",
		12	item_id: 1,
		13	},
		14	{
		15	biblio: {
		16	biblio_id: 2,
		17	title: "yet another biblio title",
		18	},
		19	external_id: "bc_3",
		20	item_id: 3,
		21	},
		22	];
		23	}
		24	describe("WaitingList", () => {
		25	beforeEach(() => {
		26	cy.login();
		27	cy.title().should("eq", "Koha staff interface");
		28	cy.intercept(
		29	"GET",
		30	"/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationModule",
		31	'{"value":"1"}'
		32	);
		33	cy.intercept(
		34	"GET",
		35	"/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationNotForLoanWaitingListIn",
		36	'{"value":"24"}'
		37	);
		38	cy.intercept(
		39	"GET",
		40	"/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationNotForLoanDefaultTrainIn",
		41	'{"value":"42"}'
		42	);
		43	});
		44
		45	it("List", () => {
		46	cy.intercept(
		47	"GET",
		48	"/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationNotForLoanWaitingListIn",
		49	'{"value":""}'
		50	);
		51	cy.visit("/cgi-bin/koha/preservation/home.pl");
		52	cy.intercept("GET", "/api/v1/preservation/waiting-list/items*", []);
		53	cy.get("#navmenulist").contains("Waiting list").click();
		54	cy.get("#waiting-list").contains(
		55	"You need to configure this module first."
		56	);
		57
		58	cy.intercept(
		59	"GET",
		60	"/cgi-bin/koha/svc/config/systempreferences/?pref=PreservationNotForLoanWaitingListIn",
		61	'{"value":"42"}'
		62	);
		63	cy.visit("/cgi-bin/koha/preservation/home.pl");
		64	cy.intercept("GET", "/api/v1/preservation/waiting-list/items*", []);
65	cy.get("#navmenulist").contains("Waiting list").click();
66	cy.get("#waiting-list").contains(
67	"There are no items in the waiting list"
68	);
69	});
70
71	it("Add to waiting list", () => {
72	cy.intercept("GET", "/api/v1/preservation/waiting-list/items*", []);
73	cy.visit("/cgi-bin/koha/preservation/waiting-list");
74	cy.intercept("POST", "/api/v1/preservation/waiting-list/items", {
75	statusCode: 500,
76	error: "Something went wrong",
77	});
78	cy.get("#waiting-list").contains("Add to waiting list").click();
79	cy.get("#barcode_list").type("bc_1\nbc_2\nbc_3");
80	cy.contains("Submit").click();
81	cy.get("main div[class='dialog alert']").contains(
82	"Something went wrong: Error: Internal Server Error"
83	);
84
85	cy.intercept("GET", "/api/v1/preservation/waiting-list/items*", {
86	statusCode: 200,
87	body: get_items(),
88	headers: {
89	"X-Base-Total-Count": "2",
90	"X-Total-Count": "2",
91	},
92	}).as("get-items");
93	cy.intercept("POST", "/api/v1/preservation/waiting-list/items", [
94	{ item_id: 1 },
95	{ item_id: 3 },
96	]);
97	cy.get("#waiting-list").contains("Add to waiting list").click();
98	cy.get("#barcode_list").type("bc_1\nbc_2\nbc_3");
99	cy.contains("Submit").click();
100	cy.wait("@get-items");
101	cy.get("main div[class='dialog message']").contains(
102	"2 new items added."
103	);
104	});
105
106	it("Add to waiting list then add to a train", () => {
107	let train = {
108	description: "yet another train",
109	name: "a train",
110	train_id: 1,
111	};
112	cy.intercept("GET", "/api/v1/preservation/trains*", [train]);
113	cy.visit("/cgi-bin/koha/preservation/waiting-list");
114
115	cy.intercept("GET", "/api/v1/preservation/waiting-list/items*", {
116	statusCode: 200,
117	body: get_items(),
118	headers: {
119	"X-Base-Total-Count": "2",
120	"X-Total-Count": "2",
121	},
122	}).as("get-items");
123	cy.intercept("POST", "/api/v1/preservation/waiting-list/items", [
124	{ item_id: 1 },
125	{ item_id: 3 },
126	]);
127	cy.get("#waiting-list").contains("Add to waiting list").click();
128	cy.get("#barcode_list").type("bc_1\nbc_2\nbc_3");
129	cy.contains("Submit").click();
130	cy.wait("@get-items");
131	cy.get("main div[class='dialog message']").contains(
132	"2 new items added."
133	);
134	cy.contains("Add last 2 items to a train").click();
135	cy.get("#train_id .vs__search").type(train.name + "{enter}");
136	cy.intercept(
137	"POST",
138	"/api/v1/preservation/trains/" + train.train_id + "/items/batch",
139	req => {
140	req.reply({
141	statusCode: 201,
142	body: req.body,
143	});
144	}
145	);
146	cy.contains("Submit").click();
147	cy.get("main div[class='dialog message']").contains(
148	`2 items have been added to train ${train.train_id}.`
149	);
150	});
151
152	it("Remove item from waiting list", () => {
153	cy.intercept("GET", "/api/v1/preservation/waiting-list/items*", {
154	statusCode: 200,
155	body: get_items(),
156	headers: {
157	"X-Base-Total-Count": "2",
158	"X-Total-Count": "2",
159	},
160	}); //.as("get-items")
161	cy.visit("/cgi-bin/koha/preservation/waiting-list");
162
163	// Submit the form, get 500
164	cy.intercept("DELETE", "/api/v1/preservation/waiting-list/items/*", {
165	statusCode: 500,
166	error: "Something went wrong",
167	});
168	cy.get("#waiting-list table tbody tr:first").contains("Remove").click();
169	cy.contains("Yes, remove").click();
170	cy.get("main div[class='dialog alert']").contains(
171	"Something went wrong: Error: Internal Server Error"
172	);
173
174	// Submit the form, success!
175	cy.intercept("DELETE", "/api/v1/preservation/waiting-list/items/*", {
176	statusCode: 204,
177	body: null,
178	});
179	cy.get("#waiting-list table tbody tr:first").contains("Remove").click();
180	cy.contains("Yes, remove").click();
181	cy.get("main div[class='dialog message']").contains(
182	`Item removed from the waiting list`
183	);
184	});
185	});

Line 0 Link Here

(-)a/t/db_dependent/Koha/Preservation/Processings.t (+58 lines)
	1	#!/usr/bin/perl
	2
	3	# This file is part of Koha
	4	#
	5	# Koha is free software; you can redistribute it and/or modify it
	6	# under the terms of the GNU General Public License as published by
	7	# the Free Software Foundation; either version 3 of the License, or
	8	# (at your option) any later version.
	9	#
	10	# Koha is distributed in the hope that it will be useful, but
	11	# WITHOUT ANY WARRANTY; without even the implied warranty of
	12	# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
	13	# GNU General Public License for more details.
	14	#
	15	# You should have received a copy of the GNU General Public License
	16	# along with Koha; if not, see <http://www.gnu.org/licenses>.
	17
	18	use Modern::Perl;
	19
	20	use Test::More tests => 1;
	21	use Test::Exception;
	22	use Test::Warn;
	23
	24	use Koha::Preservation::Processings;
	25	use Koha::Database;
	26
	27	use t::lib::TestBuilder;
	28	use t::lib::Mocks;
	29
	30	my $schema = Koha::Database->new->schema;
	31	my $builder = t::lib::TestBuilder->new;
	32
	33	subtest 'attributes' => sub {
	34
	35	plan tests => 4;
	36
	37	$schema->storage->txn_begin;
	38
	39	my $processing = $builder->build_object( { class => 'Koha::Preservation::Processings' } );
	40
	41	my $attributes = [
	42	{ name => 'color', type => 'authorised_value', option_source => 'COLORS' },
	43	{ name => 'title', type => 'db_column', option_source => '245$a' },
	44	{
	45	name => 'height',
	46	type => 'free_text'
	47	},
	48	];
	49	$processing->attributes($attributes);
	50	my $fetched_attributes = $processing->attributes;
	51	is( ref($fetched_attributes), 'Koha::Preservation::Processing::Attributes' );
	52	is( $fetched_attributes->count, 3 );
	53	$processing->attributes( [] );
	54	is( ref($fetched_attributes), 'Koha::Preservation::Processing::Attributes' );
	55	is( $fetched_attributes->count, 0 );
	56
	57	$schema->storage->txn_rollback;
	58	};

Line 0 Link Here

(-)a/t/db_dependent/Koha/Preservation/Trains.t (+102 lines)
		1	#!/usr/bin/perl
		2
		3	# This file is part of Koha
		4	#
		5	# Koha is free software; you can redistribute it and/or modify it
		6	# under the terms of the GNU General Public License as published by
		7	# the Free Software Foundation; either version 3 of the License, or
		8	# (at your option) any later version.
		9	#
		10	# Koha is distributed in the hope that it will be useful, but
		11	# WITHOUT ANY WARRANTY; without even the implied warranty of
		12	# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
		13	# GNU General Public License for more details.
		14	#
		15	# You should have received a copy of the GNU General Public License
		16	# along with Koha; if not, see <http://www.gnu.org/licenses>.
		17
		18	use Modern::Perl;
		19
		20	use Test::More tests => 2;
		21	use Test::Exception;
		22	use Test::Warn;
		23
		24	use Koha::Preservation::Trains;
		25	use Koha::Database;
		26
		27	use t::lib::TestBuilder;
		28	use t::lib::Mocks;
		29
		30	my $schema = Koha::Database->new->schema;
		31	my $builder = t::lib::TestBuilder->new;
		32
		33	subtest 'default_processing' => sub {
		34
		35	plan tests => 3;
		36
		37	$schema->storage->txn_begin;
		38
		39	my $processing = $builder->build_object( { class => 'Koha::Preservation::Processings' } );
		40	my $another_processing = $builder->build_object( { class => 'Koha::Preservation::Processings' } );
		41
		42	my $train = $builder->build_object( { class => 'Koha::Preservation::Trains', value => { default_processing_id => $processing->processing_id } } );
		43
		44	my $default_processing = $train->default_processing;
		45	is( ref($default_processing), 'Koha::Preservation::Processing', '->default_processing returns a Koha::Preservation::Processing object' );
		46	is( $default_processing->processing_id, $processing->processing_id, 'correct processing is returned' );
		47	$processing->delete;
		48	$default_processing = $train->get_from_storage->default_processing;
		49	is( $default_processing, undef, 'deleting the processing does not delete the train' );
		50
		51	$schema->storage->txn_rollback;
		52	};
		53
		54	subtest 'add_items & items' => sub {
		55	plan tests => 9;
		56
		57	$schema->storage->txn_begin;
		58
		59	my $not_for_loan_waiting_list_in = 24;
		60	my $not_for_loan_train_in = 42;
		61	my $train = $builder->build_object(
		62	{
		63	class => 'Koha::Preservation::Trains',
		64	value => {
65	not_for_loan => $not_for_loan_train_in,
66	closed_on => undef,
67	sent_on => undef,
68	received_on => undef
69	}
70	}
71	);
72	my $item_1 = $builder->build_sample_item;
73	my $item_2 = $builder->build_sample_item;
74	my $item_3 = $builder->build_sample_item;
75
76	$builder->build_object( { class => 'Koha::AuthorisedValues', value => { category => 'NOT_LOAN', authorised_value => $not_for_loan_waiting_list_in } } );
77	$item_1->notforloan($not_for_loan_waiting_list_in)->store;
78	$item_2->notforloan(0)->store; # item_2 is not in the waiting list
79	$item_3->notforloan($not_for_loan_waiting_list_in)->store;
80	t::lib::Mocks::mock_preference( 'PreservationNotForLoanWaitingListIn', $not_for_loan_waiting_list_in );
81	warning_is {
82	$train->add_items( [ { item_id => $item_1->itemnumber }, { item_id => $item_2->itemnumber }, { barcode => $item_3->barcode } ] );
83	}
84	'Item not added to train: [Cannot add item to train, it is not in the waiting list]';
85	my $items_train = $train->items;
86	is( $items_train->count, 2, '2 items added to the train' );
87	my $item_train_1 = $items_train->find( { item_id => $item_1->itemnumber } );
88	my $item_train_3 = $items_train->find( { item_id => $item_3->itemnumber } );
89	my $catalogue_item_1 = $item_train_1->catalogue_item;
90	is( ref($catalogue_item_1), 'Koha::Item' );
91	is( $catalogue_item_1->notforloan, $not_for_loan_train_in );
92
93	my $catalogue_item_3 = $item_train_3->catalogue_item;
94	is( ref($catalogue_item_3), 'Koha::Item' );
95	is( $catalogue_item_3->notforloan, $not_for_loan_train_in );
96
97	is( $item_1->get_from_storage->notforloan, $not_for_loan_train_in );
98	is( $item_2->get_from_storage->notforloan, 0 );
99	is( $item_3->get_from_storage->notforloan, $not_for_loan_train_in );
100
101	$schema->storage->txn_rollback;
102	};

Line 0 Link Here

(-)a/t/db_dependent/api/v1/preservation_Processings.t (+369 lines)
		1	#!/usr/bin/env perl
		2
		3	# This file is part of Koha.
		4	#
		5	# Koha is free software; you can redistribute it and/or modify it
		6	# under the terms of the GNU General Public License as published by
		7	# the Free Software Foundation; either version 3 of the License, or
		8	# (at your option) any later version.
		9	#
		10	# Koha is distributed in the hope that it will be useful, but
		11	# WITHOUT ANY WARRANTY; without even the implied warranty of
		12	# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
		13	# GNU General Public License for more details.
		14	#
		15	# You should have received a copy of the GNU General Public License
		16	# along with Koha; if not, see <http://www.gnu.org/licenses>.
		17
		18	use Modern::Perl;
		19
		20	use Test::More tests => 5;
		21	use Test::Mojo;
		22
		23	use t::lib::TestBuilder;
		24	use t::lib::Mocks;
		25
		26	use Koha::Preservation::Processings;
		27	use Koha::Database;
		28
		29	my $schema = Koha::Database->new->schema;
		30	my $builder = t::lib::TestBuilder->new;
		31
		32	my $t = Test::Mojo->new('Koha::REST::V1');
		33	t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );
		34
		35	subtest 'list() tests' => sub {
		36
		37	plan tests => 8;
		38
		39	$schema->storage->txn_begin;
		40
		41	Koha::Preservation::Processings->search->delete;
		42
		43	my $librarian = $builder->build_object(
		44	{
		45	class => 'Koha::Patrons',
		46	value => { flags => 2**30 }
		47	}
		48	);
		49	my $password = 'thePassword123';
		50	$librarian->set_password( { password => $password, skip_validation => 1 } );
		51	my $userid = $librarian->userid;
		52
		53	my $patron = $builder->build_object(
		54	{
		55	class => 'Koha::Patrons',
		56	value => { flags => 0 }
		57	}
		58	);
		59
		60	$patron->set_password( { password => $password, skip_validation => 1 } );
		61	my $unauth_userid = $patron->userid;
		62
		63	## Authorized user tests
		64	# No processings, so empty array should be returned
65	$t->get_ok("//$userid:$password@/api/v1/preservation/processings")->status_is(200)
66	->json_is( [] );
67
68	my $processing = $builder->build_object(
69	{
70	class => 'Koha::Preservation::Processings',
71	}
72	);
73
74	# One processing created, should get returned
75	$t->get_ok("//$userid:$password@/api/v1/preservation/processings")->status_is(200)
76	->json_is( [ $processing->to_api ] );
77
78	# Unauthorized access
79	$t->get_ok("//$unauth_userid:$password@/api/v1/preservation/processings")
80	->status_is(403);
81
82	$schema->storage->txn_rollback;
83	};
84
85	subtest 'get() tests' => sub {
86
87	plan tests => 11;
88
89	$schema->storage->txn_begin;
90
91	my $processing =
92	$builder->build_object( { class => 'Koha::Preservation::Processings' } );
93	my $attributes = [
94	{
95	name => 'color',
96	type => 'authorised_value',
97	option_source => 'COLORS'
98	},
99	{ name => 'title', type => 'db_column', option_source => '245$a' },
100	{
101	name => 'height',
102	type => 'free_text'
103	},
104	];
105	$attributes = $processing->attributes($attributes);
106	my $librarian = $builder->build_object(
107	{
108	class => 'Koha::Patrons',
109	value => { flags => 2**30 }
110	}
111	);
112	my $password = 'thePassword123';
113	$librarian->set_password( { password => $password, skip_validation => 1 } );
114	my $userid = $librarian->userid;
115
116	my $patron = $builder->build_object(
117	{
118	class => 'Koha::Patrons',
119	value => { flags => 0 }
120	}
121	);
122
123	$patron->set_password( { password => $password, skip_validation => 1 } );
124	my $unauth_userid = $patron->userid;
125
126	# This processing exists, should get returned
127	$t->get_ok( "//$userid:$password@/api/v1/preservation/processings/"
128	. $processing->processing_id )->status_is(200)
129	->json_is( $processing->to_api );
130
131	# Return one processing with attributes
132	$t->get_ok( "//$userid:$password@/api/v1/preservation/processings/"
133	. $processing->processing_id => {'x-koha-embed' => 'attributes'} )->status_is(200)
134	->json_is( { %{ $processing->to_api }, attributes => $attributes->to_api });
135
136	# Unauthorized access
137	$t->get_ok( "//$unauth_userid:$password@/api/v1/preservation/processings/"
138	. $processing->processing_id )->status_is(403);
139
140	# Attempt to get non-existent processing
141	my $processing_to_delete =
142	$builder->build_object( { class => 'Koha::Preservation::Processings' } );
143	my $non_existent_id = $processing_to_delete->processing_id;
144	$processing_to_delete->delete;
145
146	$t->get_ok("//$userid:$password@/api/v1/preservation/processings/$non_existent_id")
147	->status_is(404)->json_is( '/error' => 'Processing not found' );
148
149	$schema->storage->txn_rollback;
150	};
151
152	subtest 'add() tests' => sub {
153
154	plan tests => 15;
155
156	$schema->storage->txn_begin;
157
158	my $librarian = $builder->build_object(
159	{
160	class => 'Koha::Patrons',
161	value => { flags => 2**30 }
162	}
163	);
164	my $password = 'thePassword123';
165	$librarian->set_password( { password => $password, skip_validation => 1 } );
166	my $userid = $librarian->userid;
167
168	my $patron = $builder->build_object(
169	{
170	class => 'Koha::Patrons',
171	value => { flags => 0 }
172	}
173	);
174
175	$patron->set_password( { password => $password, skip_validation => 1 } );
176	my $unauth_userid = $patron->userid;
177
178	my $default_processing = $builder->build_object({class => 'Koha::Preservation::Processings'});
179	my $processing = {
180	name => "processing name",
181	};
182
183	# Unauthorized attempt to write
184	$t->post_ok( "//$unauth_userid:$password@/api/v1/preservation/processings" => json =>
185	$processing )->status_is(403);
186
187	# Authorized attempt to write invalid data
188	my $processing_with_invalid_field = {
189	blah => "processing Blah",
190	%$processing,
191	};
192
193	$t->post_ok( "//$userid:$password@/api/v1/preservation/processings" => json =>
194	$processing_with_invalid_field )->status_is(400)->json_is(
195	"/errors" => [
196	{
197	message => "Properties not allowed: blah.",
198	path => "/body"
199	}
200	]
201	);
202
203	# Authorized attempt to write
204	my $processing_id =
205	$t->post_ok(
206	"//$userid:$password@/api/v1/preservation/processings" => json => $processing )
207	->status_is( 201, 'SWAGGER3.2.1' )->header_like(
208	Location => qr\|^/api/v1/preservation/processings/\d*\|,
209	'SWAGGER3.4.1'
210	)->json_is( '/name' => $processing->{name} )
211	->tx->res->json->{processing_id};
212
213	# Authorized attempt to create with null id
214	$processing->{processing_id} = undef;
215	$t->post_ok(
216	"//$userid:$password@/api/v1/preservation/processings" => json => $processing )
217	->status_is(400)->json_has('/errors');
218
219	# Authorized attempt to create with existing id
220	$processing->{processing_id} = $processing_id;
221	$t->post_ok(
222	"//$userid:$password@/api/v1/preservation/processings" => json => $processing )
223	->status_is(400)->json_is(
224	"/errors" => [
225	{
226	message => "Read-only.",
227	path => "/body/processing_id"
228	}
229	]
230	);
231
232	$schema->storage->txn_rollback;
233	};
234
235	subtest 'update() tests' => sub {
236
237	plan tests => 15;
238
239	$schema->storage->txn_begin;
240
241	my $librarian = $builder->build_object(
242	{
243	class => 'Koha::Patrons',
244	value => { flags => 2**30 }
245	}
246	);
247	my $password = 'thePassword123';
248	$librarian->set_password( { password => $password, skip_validation => 1 } );
249	my $userid = $librarian->userid;
250
251	my $patron = $builder->build_object(
252	{
253	class => 'Koha::Patrons',
254	value => { flags => 0 }
255	}
256	);
257
258	$patron->set_password( { password => $password, skip_validation => 1 } );
259	my $unauth_userid = $patron->userid;
260
261	my $processing_id =
262	$builder->build_object( { class => 'Koha::Preservation::Processings' } )->processing_id;
263
264	# Unauthorized attempt to update
265	$t->put_ok(
266	"//$unauth_userid:$password@/api/v1/preservation/processings/$processing_id" =>
267	json => { name => 'New unauthorized name change' } )->status_is(403);
268
269	# Attempt partial update on a PUT
270	my $processing_with_missing_field = {
271	};
272
273	$t->put_ok(
274	"//$userid:$password@/api/v1/preservation/processings/$processing_id" => json =>
275	$processing_with_missing_field )->status_is(400)
276	->json_is( "/errors" =>
277	[ { message => "Missing property.", path => "/body/name" } ] );
278
279	my $default_processing = $builder->build_object({class => 'Koha::Preservation::Processings'});
280	# Full object update on PUT
281	my $processing_with_updated_field = {
282	name => "New name",
283	};
284
285	$t->put_ok(
286	"//$userid:$password@/api/v1/preservation/processings/$processing_id" => json =>
287	$processing_with_updated_field )->status_is(200)
288	->json_is( '/name' => 'New name' );
289
290	# Authorized attempt to write invalid data
291	my $processing_with_invalid_field = {
292	blah => "processing Blah",
293	%$processing_with_updated_field,
294	};
295
296	$t->put_ok(
297	"//$userid:$password@/api/v1/preservation/processings/$processing_id" => json =>
298	$processing_with_invalid_field )->status_is(400)->json_is(
299	"/errors" => [
300	{
301	message => "Properties not allowed: blah.",
302	path => "/body"
303	}
304	]
305	);
306
307	# Attempt to update non-existent processing
308	my $processing_to_delete =
309	$builder->build_object( { class => 'Koha::Preservation::Processings' } );
310	my $non_existent_id = $processing_to_delete->processing_id;
311	$processing_to_delete->delete;
312
313	$t->put_ok( "//$userid:$password@/api/v1/preservation/processings/$non_existent_id" =>
314	json => $processing_with_updated_field )->status_is(404);
315
316	# Wrong method (POST)
317	$processing_with_updated_field->{processing_id} = 2;
318
319	$t->post_ok(
320	"//$userid:$password@/api/v1/preservation/processings/$processing_id" => json =>
321	$processing_with_updated_field )->status_is(404);
322
323	$schema->storage->txn_rollback;
324	};
325
326	subtest 'delete() tests' => sub {
327
328	plan tests => 7;
329
330	$schema->storage->txn_begin;
331
332	my $librarian = $builder->build_object(
333	{
334	class => 'Koha::Patrons',
335	value => { flags => 2**30 }
336	}
337	);
338	my $password = 'thePassword123';
339	$librarian->set_password( { password => $password, skip_validation => 1 } );
340	my $userid = $librarian->userid;
341
342	my $patron = $builder->build_object(
343	{
344	class => 'Koha::Patrons',
345	value => { flags => 0 }
346	}
347	);
348
349	$patron->set_password( { password => $password, skip_validation => 1 } );
350	my $unauth_userid = $patron->userid;
351
352	my $processing_id =
353	$builder->build_object( { class => 'Koha::Preservation::Processings' } )->processing_id;
354
355	# Unauthorized attempt to delete
356	$t->delete_ok(
357	"//$unauth_userid:$password@/api/v1/preservation/processings/$processing_id")
358	->status_is(403);
359
360	# Delete existing processing
361	$t->delete_ok("//$userid:$password@/api/v1/preservation/processings/$processing_id")
362	->status_is( 204, 'SWAGGER3.2.4' )->content_is( '', 'SWAGGER3.3.4' );
363
364	# Attempt to delete non-existent processing
365	$t->delete_ok("//$userid:$password@/api/v1/preservation/processings/$processing_id")
366	->status_is(404);
367
368	$schema->storage->txn_rollback;
369	};