Attachment #155017 for bug #33766

View | Details | Raw Unified | Return to bug 33766
Collapse All | Expand All




use Modern::Perl;

return {
    bug_number  => "33766",
    description => "Add syspref to determine text content of userid input field's label.",
    up          => sub {
        my ($args) = @_;
        my ( $dbh, $out ) = @$args{qw(dbh out)};

        # Do you stuffs here
        $dbh->do(
            q{INSERT IGNORE INTO systempreferences (variable,value) VALUES ('OPACLoginLabelTextContent','Cardnumber')  }
        );

        # sysprefs
        say $out "Added new system preference 'OPACLoginLabelTextContent'";
    },
};

Lines 473-478 INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` Link Here

(-)a/installer/data/mysql/mandatory/sysprefs.sql (+1 lines)
473	('OPACLocalCoverImages','0','1','Display local cover images on OPAC search and details pages.','YesNo'),	473	('OPACLocalCoverImages','0','1','Display local cover images on OPAC search and details pages.','YesNo'),
474	('OpacLocationBranchToDisplay','holding','holding\|home\|both','In the OPAC, under location show which branch for Location in the record details.','Choice'),	474	('OpacLocationBranchToDisplay','holding','holding\|home\|both','In the OPAC, under location show which branch for Location in the record details.','Choice'),
475	('OpacLocationOnDetail','holding','holding\|home\|both\|column','In the OPAC detail, display the shelving location on its own column or under a library columns.', 'Choice'),	475	('OpacLocationOnDetail','holding','holding\|home\|both\|column','In the OPAC detail, display the shelving location on its own column or under a library columns.', 'Choice'),
		476	('OPACLoginLabelTextContent','Cardnumber',NULL,NULL,NULL),
476	('OPACMandatoryHoldDates', '', '\|start\|end\|both', 'Define which hold dates are required on OPAC reserve form', 'Choice'),	477	('OPACMandatoryHoldDates', '', '\|start\|end\|both', 'Define which hold dates are required on OPAC reserve form', 'Choice'),
477	('OpacMaintenance','0','','If ON, enables maintenance warning in OPAC','YesNo'),	478	('OpacMaintenance','0','','If ON, enables maintenance warning in OPAC','YesNo'),
478	('OpacMaintenanceNotice','','','A user-defined block of HTML to appear on screen when OpacMaintenace is enabled','Textarea'),	479	('OpacMaintenanceNotice','','','A user-defined block of HTML to appear on screen when OpacMaintenace is enabled','Textarea'),




                  column: "on a separate column"
            - "for items on the OPAC record details page."
            - "<br />Note: If 'on a separate column' is selected, you still need to enable the item_shelving_location display on the <a href='/cgi-bin/koha/admin/columns_settings.pl'>configure columns</a> administration page."
        -
            - Use
            - pref: OPACLoginLabelTextContent
              default: Cardnumber
              choices:
                  Cardnumber: Cardnumber
                  Username: Username
                  "Cardnumber or Username": Cardnumber or Username
            - "as the text content of the userid input field's label."
        -
            - pref: OPACShowMusicalInscripts
              default: 0

              type: textarea
              syntax: text/html
              class: code

        -
            - pref: OpacBrowseSearch
              default: 0

Lines 412-418 Link Here

(-)a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc (-1 / +1 lines)
412	<input type="hidden" name="koha_login_context" value="opac" />	412	<input type="hidden" name="koha_login_context" value="opac" />
413	<fieldset class="brief">	413	<fieldset class="brief">
414	<div class="local-login">	414	<div class="local-login">
415	<label for="muserid">Login:</label><input type="text" id="muserid" name="userid" autocomplete="off" />	415	<label for="muserid">[% Koha.Preference('OPACLoginLabelTextContent') \| html %]:</label><input type="text" id="muserid" name="userid" autocomplete="off" />
416	<label for="mpassword">Password:</label><input type="password" id="mpassword" name="password" autocomplete="off" />	416	<label for="mpassword">Password:</label><input type="password" id="mpassword" name="password" autocomplete="off" />
417	<fieldset class="action">	417	<fieldset class="action">
418	<input type="submit" class="btn btn-primary" value="Log in" />	418	<input type="submit" class="btn btn-primary" value="Log in" />

Lines 223-229 Link Here

(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt (-1 / +1 lines)
223	<input type="hidden" name="[% INPUT.name \| html %]" value="[% INPUT.value \| html %]" />	223	<input type="hidden" name="[% INPUT.name \| html %]" value="[% INPUT.value \| html %]" />
224	[% END %]	224	[% END %]
225	<div class="form-group">	225	<div class="form-group">
226	<label for="userid">Login:</label>	226	<label for="userid">[% Koha.Preference('OPACLoginLabelTextContent') \| html %]:</label>
227	<input class="form-control" type="text" size="25" id="userid" name="userid" autocomplete="off" />	227	<input class="form-control" type="text" size="25" id="userid" name="userid" autocomplete="off" />
228	</div>	228	</div>
229	<div class="form-group">	229	<div class="form-group">

Lines 205-211 Link Here

(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt (-1 / +1 lines)
205	<p>If you do not have an external account, but do have a local account, you can still log in: </p>	205	<p>If you do not have an external account, but do have a local account, you can still log in: </p>
206	[% END # /IF identity_providers.size %]	206	[% END # /IF identity_providers.size %]
207	<div class="local-login">	207	<div class="local-login">
208	<label for="userid">Login:</label>	208	<label for="userid">[% Koha.Preference('OPACLoginLabelTextContent') \| html %]:</label>
209	<input class="form-control" type="text" id="userid" name="userid" autocomplete="off" />	209	<input class="form-control" type="text" id="userid" name="userid" autocomplete="off" />
210	<label for="password">Password:</label>	210	<label for="password">Password:</label>
211	<input class="form-control" type="password" id="password" name="password" autocomplete="off" />	211	<input class="form-control" type="password" id="password" name="password" autocomplete="off" />

Lines 125-131 Link Here

(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt (-1 / +1 lines)
125	<p>To reset your password, enter your login or your email address.</p>	125	<p>To reset your password, enter your login or your email address.</p>
126	<fieldset class="brief">	126	<fieldset class="brief">
127	<div class="form-group">	127	<div class="form-group">
128	<label for="username">Login:</label>	128	<label for="username">[% Koha.Preference('OPACLoginLabelTextContent') \| html %]:</label>
129	<input class="form-control" type="text" id="username" size="40" name="username" value="[% username \| html %]" />	129	<input class="form-control" type="text" id="username" size="40" name="username" value="[% username \| html %]" />
130	</div>	130	</div>
131		131

Lines 86-92 Link Here

(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt (-1 / +1 lines)
86	<input type="hidden" name="koha_login_context" value="opac" />	86	<input type="hidden" name="koha_login_context" value="opac" />
87	<fieldset class="brief">	87	<fieldset class="brief">
88	<legend>Log in to your account:</legend>	88	<legend>Log in to your account:</legend>
89	<label for="userid">Login:</label>	89	<label for="userid">[% Koha.Preference('OPACLoginLabelTextContent') \| html %]:</label>
90	[% IF Koha.Preference('PatronSelfRegistrationPrefillForm') %]	90	[% IF Koha.Preference('PatronSelfRegistrationPrefillForm') %]
91	<input class="form-control" type="text" id="userid" size="10" name="userid" value="[% borrower.userid \| html %]" autocomplete="off" />	91	<input class="form-control" type="text" id="userid" size="10" name="userid" value="[% borrower.userid \| html %]" autocomplete="off" />
92	[% ELSE %]	92	[% ELSE %]

Lines 79-85 Link Here

(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt (-1 / +1 lines)
79		79
80	<fieldset class="brief">	80	<fieldset class="brief">
81	<div class="form-group">	81	<div class="form-group">
82	<label for="userid">Login:</label>	82	<label for="userid">[% Koha.Preference('OPACLoginLabelTextContent') \| html %]:</label>
83	<input class="form-control" autocomplete="off" type="text" size="25" id="userid" name="userid" />	83	<input class="form-control" autocomplete="off" type="text" size="25" id="userid" name="userid" />
84	</div>	84	</div>
85	<div class="form-group">	85	<div class="form-group">

Lines 406-412 Link Here

(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt (-2 / +1 lines)
406	<fieldset>	406	<fieldset>
407	[% IF ( Koha.Preference('SelfCheckoutByLogin') ) %]	407	[% IF ( Koha.Preference('SelfCheckoutByLogin') ) %]
408	<legend>Log in to your account</legend>	408	<legend>Log in to your account</legend>
409	<label for="patronlogin">Login:</label>	409	<label for="patronlogin">[% Koha.Preference('OPACLoginLabelTextContent') \| html %]:</label>
410	<input type="text" id="patronlogin" class="focus noEnterSubmit" size="20" name="patronlogin" autocomplete="off"/>	410	<input type="text" id="patronlogin" class="focus noEnterSubmit" size="20" name="patronlogin" autocomplete="off"/>
411	<label for="patronpw">Password:</label>	411	<label for="patronpw">Password:</label>
412	<input type="password" id="patronpw" size="20" name="patronpw" autocomplete="off"/>	412	<input type="password" id="patronpw" size="20" name="patronpw" autocomplete="off"/>
413	-

Return to bug 33766

Lines 171-176 OPAC: Link Here

(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref (+10 lines)
171	column: "on a separate column"	171	column: "on a separate column"
172	- "for items on the OPAC record details page."	172	- "for items on the OPAC record details page."
173	- "<br />Note: If 'on a separate column' is selected, you still need to enable the item_shelving_location display on the <a href='/cgi-bin/koha/admin/columns_settings.pl'>configure columns</a> administration page."	173	- "<br />Note: If 'on a separate column' is selected, you still need to enable the item_shelving_location display on the <a href='/cgi-bin/koha/admin/columns_settings.pl'>configure columns</a> administration page."
		174	-
		175	- Use
		176	- pref: OPACLoginLabelTextContent
		177	default: Cardnumber
		178	choices:
		179	Cardnumber: Cardnumber
		180	Username: Username
		181	"Cardnumber or Username": Cardnumber or Username
		182	- "as the text content of the userid input field's label."
174	-	183	-
175	- pref: OPACShowMusicalInscripts	184	- pref: OPACShowMusicalInscripts
176	default: 0	185	default: 0
Lines 528-533 OPAC: Link Here
528	type: textarea	537	type: textarea
529	syntax: text/html	538	syntax: text/html
530	class: code	539	class: code
		540
531	-	541	-
532	- pref: OpacBrowseSearch	542	- pref: OpacBrowseSearch
533	default: 0	543	default: 0

Line 0 Link Here

(-)a/installer/data/mysql/atomicupdate/bug_33766-a11y_fix_ambiguous_form-field_in_opac-auth.tt (+18 lines)
	1	use Modern::Perl;
	2
	3	return {
	4	bug_number => "33766",
	5	description => "Add syspref to determine text content of userid input field's label.",
	6	up => sub {
	7	my ($args) = @_;
	8	my ( $dbh, $out ) = @$args{qw(dbh out)};
	9
	10	# Do you stuffs here
	11	$dbh->do(
	12	q{INSERT IGNORE INTO systempreferences (variable,value) VALUES ('OPACLoginLabelTextContent','Cardnumber') }
	13	);
	14
	15	# sysprefs
	16	say $out "Added new system preference 'OPACLoginLabelTextContent'";
	17	},
	18	};