View | Details | Raw Unified | Return to bug 35491
Collapse All | Expand All

(-)a/C4/Reserves.pm (+3 lines)
Lines 2169-2174 sub RevertWaitingStatus { Link Here
2169
        }
2169
        }
2170
    )->store();
2170
    )->store();
2171
2171
2172
    logaction( 'HOLDS', 'MODIFY', $hold->id, $hold )
2173
        if C4::Context->preference('HoldsLog');
2174
2172
    _FixPriority( { biblionumber => $hold->biblionumber } );
2175
    _FixPriority( { biblionumber => $hold->biblionumber } );
2173
2176
2174
    Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue->new->enqueue(
2177
    Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue->new->enqueue(
(-)a/t/db_dependent/Reserves.t (-7 / +21 lines)
Lines 989-995 subtest 'reserves.item_level_hold' => sub { Link Here
989
    );
989
    );
990
990
991
    subtest 'item level hold' => sub {
991
    subtest 'item level hold' => sub {
992
        plan tests => 3;
992
        plan tests => 5;
993
        my $reserve_id = AddReserve(
993
        my $reserve_id = AddReserve(
994
            {
994
            {
995
                branchcode     => $item->homebranch,
995
                branchcode     => $item->homebranch,
Lines 1017-1040 subtest 'reserves.item_level_hold' => sub { Link Here
1017
        } );
1017
        } );
1018
1018
1019
        t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 1 );
1019
        t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 1 );
1020
        t::lib::Mocks::mock_preference( 'HoldsLog',           1 );
1020
1021
1021
        # Revert the waiting status
1022
        # Revert the waiting status
1022
        C4::Reserves::RevertWaitingStatus(
1023
        C4::Reserves::RevertWaitingStatus( { itemnumber => $item->itemnumber } );
1023
            { itemnumber => $item->itemnumber } );
1024
1024
1025
        $hold = Koha::Holds->find($reserve_id);
1025
        $hold = Koha::Holds->find($reserve_id);
1026
1026
1027
        is( $hold->itemnumber, $item->itemnumber, 'Itemnumber should not be removed when the waiting status is revert' );
1027
        is(
1028
            $hold->itemnumber, $item->itemnumber,
1029
            'Itemnumber should not be removed when the waiting status is revert'
1030
        );
1031
1032
        my $log =
1033
            Koha::ActionLogs->search( { module => 'HOLDS', action => 'MODIFY', object => $hold->reserve_id } )->next;
1034
        my $expected = sprintf q{'timestamp' => '%s'}, $hold->timestamp;
1035
        like( $log->info, qr{$expected}, 'Timestamp logged is the current one' );
1036
        my $log_count =
1037
            Koha::ActionLogs->search( { module => 'HOLDS', action => 'MODIFY', object => $hold->reserve_id } )->count;
1028
1038
1029
        t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 0 );
1039
        t::lib::Mocks::mock_preference( 'RealTimeHoldsQueue', 0 );
1040
        t::lib::Mocks::mock_preference( 'HoldsLog',           0 );
1030
1041
1031
        $hold->set_waiting;
1042
        $hold->set_waiting;
1032
1043
1033
        # Revert the waiting status, RealTimeHoldsQueue => shouldn't add a test
1044
        # Revert the waiting status, RealTimeHoldsQueue => shouldn't add a test
1034
        C4::Reserves::RevertWaitingStatus(
1045
        C4::Reserves::RevertWaitingStatus( { itemnumber => $item->itemnumber } );
1035
            { itemnumber => $item->itemnumber } );
1036
1046
1037
        $hold->delete;    # cleanup
1047
        $hold->delete;    # cleanup
1048
1049
        my $log_count_after =
1050
            Koha::ActionLogs->search( { module => 'HOLDS', action => 'MODIFY', object => $hold->reserve_id } )->count;
1051
        is( $log_count, $log_count_after, "No logging is added for RevertWaitingStatus when HoldsLog is disabled" );
1052
1038
    };
1053
    };
1039
1054
1040
    subtest 'biblio level hold' => sub {
1055
    subtest 'biblio level hold' => sub {
1041
- 

Return to bug 35491