View | Details | Raw Unified | Return to bug 34978
Collapse All | Expand All

(-)a/Koha/Plugins.pm (-6 / +12 lines)
Lines 276-294 sub InstallPlugins { Link Here
276
    my $verbose = $params->{verbose} // $self->_verbose;
276
    my $verbose = $params->{verbose} // $self->_verbose;
277
277
278
    my @plugin_classes = $self->plugins();
278
    my @plugin_classes = $self->plugins();
279
    my (@plugins, @classes_filters);
279
    my ( @plugins, @classes_filters );
280
280
281
    my $has_filters = defined($params->{include}) || defined($params->{exclude});
281
    my $has_filters = defined( $params->{include} ) || defined( $params->{exclude} );
282
282
283
    # Warn user if the specified classes doesn't exist and return nothing
283
    # Warn user if the specified classes doesn't exist and return nothing
284
    if ($has_filters) {
284
    if ($has_filters) {
285
        @classes_filters = defined($params->{include}) ? @{$params->{include}} : @{$params->{exclude}};
285
        @classes_filters = defined( $params->{include} ) ? @{ $params->{include} } : @{ $params->{exclude} };
286
286
287
        foreach my $classes_filter (@classes_filters) {
287
        foreach my $classes_filter (@classes_filters) {
288
            my $is_found = 0;
288
            my $is_found = 0;
289
289
290
            foreach my $plugin_class (@plugin_classes) {
290
            foreach my $plugin_class (@plugin_classes) {
291
                $is_found = 1 if $plugin_class =~ ":$classes_filter\$|^$classes_filter\$" || ($classes_filter =~ "^::" && $plugin_class =~ "$classes_filter\$");
291
                $is_found = 1
292
                    if $plugin_class =~ ":$classes_filter\$|^$classes_filter\$"
293
                    || ( $classes_filter =~ "^::" && $plugin_class =~ "$classes_filter\$" );
292
            }
294
            }
293
            unless ($is_found) {
295
            unless ($is_found) {
294
                warn "$classes_filter have not been found, try a different name";
296
                warn "$classes_filter have not been found, try a different name";
Lines 305-313 sub InstallPlugins { Link Here
305
            if ($has_filters) {
307
            if ($has_filters) {
306
                my $is_found = 0;
308
                my $is_found = 0;
307
                foreach my $classes_filter (@classes_filters) {
309
                foreach my $classes_filter (@classes_filters) {
308
                    $is_found = 1 if $plugin_class =~ ":$classes_filter\$|^$classes_filter\$" || ($classes_filter =~ "^::" && $plugin_class =~ "$classes_filter\$");
310
                    $is_found = 1
311
                        if $plugin_class =~ ":$classes_filter\$|^$classes_filter\$"
312
                        || ( $classes_filter =~ "^::" && $plugin_class =~ "$classes_filter\$" );
309
                }
313
                }
310
                next if (defined($params->{include}) && !$is_found) || (defined($params->{exclude}) && $is_found);
314
                next
315
                    if ( defined( $params->{include} ) && !$is_found )
316
                    || ( defined( $params->{exclude} ) && $is_found );
311
            }
317
            }
312
318
313
            my $plugin;
319
            my $plugin;
(-)a/misc/devel/install_plugins.pl (-2 / +2 lines)
Lines 26-35 use Koha::Script; Link Here
26
use C4::Context;
26
use C4::Context;
27
use Koha::Plugins;
27
use Koha::Plugins;
28
28
29
my ($help, @include, @exclude);
29
my ( $help, @include, @exclude );
30
30
31
GetOptions(
31
GetOptions(
32
    'help|?' => \$help,
32
    'help|?'    => \$help,
33
    'include=s' => \@include,
33
    'include=s' => \@include,
34
    'exclude=s' => \@exclude,
34
    'exclude=s' => \@exclude,
35
) or die "Installation aborted\n";
35
) or die "Installation aborted\n";
(-)a/t/db_dependent/Koha/Plugins/Plugins.t (-20 / +19 lines)
Lines 24-30 use File::Temp qw( tempdir tempfile ); Link Here
24
use FindBin qw($Bin);
24
use FindBin qw($Bin);
25
use Module::Load::Conditional qw(can_load);
25
use Module::Load::Conditional qw(can_load);
26
use Test::MockModule;
26
use Test::MockModule;
27
use Test::More tests => 30;
27
use Test::More tests => 19;
28
use Test::Warn;
28
use Test::Warn;
29
29
30
use C4::Context;
30
use C4::Context;
Lines 195-217 subtest 'InstallPlugins() tests' => sub { Link Here
195
    Koha::Plugins::Methods->delete;
195
    Koha::Plugins::Methods->delete;
196
    $schema->resultset('PluginData')->delete;
196
    $schema->resultset('PluginData')->delete;
197
197
198
    # Tests for the exclude paramater
198
    # Tests for the exclude parameter
199
    # Test the returned plugins of the InstallPlugins subroutine
199
    # Test the returned plugins of the InstallPlugins subroutine
200
    my $plugins = Koha::Plugins->new({ enable_plugins => 1 });
200
    my $plugins           = Koha::Plugins->new( { enable_plugins => 1 } );
201
    my @installed_plugins = $plugins->InstallPlugins({ exclude => ["Test", "Koha::Plugin::MarcFieldValues"] });
201
    my @installed_plugins = $plugins->InstallPlugins( { exclude => [ "Test", "Koha::Plugin::MarcFieldValues" ] } );
202
    my $plugin_classes = join(" ", map{$_->{class}} @installed_plugins);
202
    my $plugin_classes    = join( " ", map { $_->{class} } @installed_plugins );
203
203
204
    my $result = grep { $plugin_classes !~ $_ } [":Test |:Test\$", ":MarcFieldValues |:MarcFieldValues\$"]
204
    my $result = grep { $plugin_classes !~ $_ } [ ":Test |:Test\$", ":MarcFieldValues |:MarcFieldValues\$" ]
205
        && $plugin_classes =~ ":TestItemBarcodeTransform |:TestItemBarcodeTransform\$";
205
        && $plugin_classes =~ ":TestItemBarcodeTransform |:TestItemBarcodeTransform\$";
206
    ok($result, "Excluded plugins are not returned");
206
    ok( $result, "Excluded plugins are not returned" );
207
207
208
    # Test the plugins in the database
208
    # Test the plugins in the database
209
    my @plugins = $plugins->GetPlugins({ all => 1, error => 1 });
209
    my @plugins = $plugins->GetPlugins( { all => 1, error => 1 } );
210
    $plugin_classes = join(" ", map{$_->{class}} @plugins);
210
    $plugin_classes = join( " ", map { $_->{class} } @plugins );
211
211
212
    $result = grep { $plugin_classes !~ $_ } [":Test |:Test\$", ":MarcFieldValues |:MarcFieldValues\$"]
212
    $result = grep { $plugin_classes !~ $_ } [ ":Test |:Test\$", ":MarcFieldValues |:MarcFieldValues\$" ]
213
        && $plugin_classes =~ ":TestItemBarcodeTransform |:TestItemBarcodeTransform\$";
213
        && $plugin_classes =~ ":TestItemBarcodeTransform |:TestItemBarcodeTransform\$";
214
    ok($result, "Excluded plugins are not installed");
214
    ok( $result, "Excluded plugins are not installed" );
215
215
216
    # Remove installed plugins data
216
    # Remove installed plugins data
217
    Koha::Plugins::Methods->delete;
217
    Koha::Plugins::Methods->delete;
Lines 219-240 subtest 'InstallPlugins() tests' => sub { Link Here
219
219
220
    # Tests for the include parameter
220
    # Tests for the include parameter
221
    # Test the returned plugins of the InstallPlugins subroutine
221
    # Test the returned plugins of the InstallPlugins subroutine
222
    @installed_plugins = $plugins->InstallPlugins({ include => ["Test", "Koha::Plugin::MarcFieldValues"]});
222
    @installed_plugins = $plugins->InstallPlugins( { include => [ "Test", "Koha::Plugin::MarcFieldValues" ] } );
223
223
224
    $result = 1;
224
    $result = 1;
225
    foreach my $plugin_class ( map{ $_->{class} } @installed_plugins ) {
225
    foreach my $plugin_class ( map { $_->{class} } @installed_plugins ) {
226
        $result = 0 unless("$plugin_class" =~ ":Test\$" || "$plugin_class" =~ ":MarcFieldValues\$");
226
        $result = 0 unless ( "$plugin_class" =~ ":Test\$" || "$plugin_class" =~ ":MarcFieldValues\$" );
227
    }
227
    }
228
    ok($result, "Only included plugins are returned");
228
    ok( $result, "Only included plugins are returned" );
229
229
230
    # Test the plugins in the database
230
    # Test the plugins in the database
231
    @plugins = $plugins->GetPlugins({ all => 1, error => 1});
231
    @plugins = $plugins->GetPlugins( { all => 1, error => 1 } );
232
232
233
    $result = 1;
233
    $result = 1;
234
    foreach my $plugin_class ( map{ $_->{class} } @plugins ) {
234
    foreach my $plugin_class ( map { $_->{class} } @plugins ) {
235
        $result = 0 unless("$plugin_class" =~ ":Test\$" || "$plugin_class" =~ ":MarcFieldValues\$");
235
        $result = 0 unless ( "$plugin_class" =~ ":Test\$" || "$plugin_class" =~ ":MarcFieldValues\$" );
236
    }
236
    }
237
    ok($result, "Only included plugins are installed");
237
    ok( $result, "Only included plugins are installed" );
238
238
239
    $schema->storage->txn_rollback;
239
    $schema->storage->txn_rollback;
240
};
240
};
241
- 

Return to bug 34978