Attachment #164340 for bug #33568

View | Details | Raw Unified | Return to bug 33568
Collapse All | Expand All




    return 0;
}

=head3 strings_map

Returns a map of column name to string representations including the string.

=cut

sub strings_map {
    my ($self) = @_;
    return {
        pickup_library_id => { str => $self->branch->branchname, type => 'library' },
    };
}

=head2 Internal methods

=head3 _type

Lines 428-433 Link Here

(-)a/api/v1/swagger/paths/biblios.yaml (+1 lines)
428	- transfer	428	- transfer
429	- transfer+strings	429	- transfer+strings
430	- first_hold	430	- first_hold
		431	- first_hold+strings
431	- first_hold.patron	432	- first_hold.patron
432	- recall	433	- recall
433	- recall.patron	434	- recall.patron




        [%# In case or SeparateHoldings we may need to display the number of biblios in each tab %]
        [%# Do we need separate/new endpoints or do we hack the somewhere client-side? %]
        let item_table_url = "/api/v1/biblios/[% biblio.biblionumber | uri %]/items?";
        let embed = ["+strings,checkout,checkout.patron,transfer,transfer+strings,first_hold,first_hold+strings,first_hold.patron,item_type"];
        [% IF Koha.Preference('LocalCoverImages') %]
            embed.push('cover_image_ids');
        [% END %]


                        if ( row.first_hold ) {
                            if ( row.first_hold.waiting_date ) {
                                [%# FIXME Display library names instead of codes %]
                                [%# FIXME We lost the desk name, we need an additional embed %]
                                nodes += '<span class="waitingat">%s</span>'.format(_("Waiting at %s since %s.".format(row.first_hold._strings.pickup_library_id.str, $date(row.first_hold.waiting_date))));
                                [% IF Koha.Preference('canreservefromotherbranches') %]
                                    if ( row.first_hold.waiting_date || row.first_hold.priority == 1 ) {
                                        let patron_to_html = $patron_to_html(row.first_hold.patron); [%# FIXME What about hide_patron_infos_if_needed?? %]
- 

Return to bug 33568

Lines 1041-1046 sub can_update_pickup_location_opac { Link Here

(-)a/Koha/Hold.pm (+13 lines)
1041	return 0;	1041	return 0;
1042	}	1042	}
1043		1043
		1044	=head3 strings_map
		1045
		1046	Returns a map of column name to string representations including the string.
		1047
		1048	=cut
		1049
		1050	sub strings_map {
		1051	my ($self) = @_;
		1052	return {
		1053	pickup_library_id => { str => $self->branch->branchname, type => 'library' },
		1054	};
		1055	}
		1056
1044	=head2 Internal methods	1057	=head2 Internal methods
1045		1058
1046	=head3 _type	1059	=head3 _type

Lines 2173-2179 Link Here

(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt (-4 / +2 lines)
2173	[%# In case or SeparateHoldings we may need to display the number of biblios in each tab %]	2173	[%# In case or SeparateHoldings we may need to display the number of biblios in each tab %]
2174	[%# Do we need separate/new endpoints or do we hack the somewhere client-side? %]	2174	[%# Do we need separate/new endpoints or do we hack the somewhere client-side? %]
2175	let item_table_url = "/api/v1/biblios/[% biblio.biblionumber \| uri %]/items?";	2175	let item_table_url = "/api/v1/biblios/[% biblio.biblionumber \| uri %]/items?";
2176	let embed = ["+strings,checkout,checkout.patron,transfer,transfer+strings,first_hold,first_hold.patron,item_type"];	2176	let embed = ["+strings,checkout,checkout.patron,transfer,transfer+strings,first_hold,first_hold+strings,first_hold.patron,item_type"];
2177	[% IF Koha.Preference('LocalCoverImages') %]	2177	[% IF Koha.Preference('LocalCoverImages') %]
2178	embed.push('cover_image_ids');	2178	embed.push('cover_image_ids');
2179	[% END %]	2179	[% END %]
Lines 2425-2433 Link Here
2425		2425
2426	if ( row.first_hold ) {	2426	if ( row.first_hold ) {
2427	if ( row.first_hold.waiting_date ) {	2427	if ( row.first_hold.waiting_date ) {
2428	[%# FIXME Display library names instead of codes %]
2429	[%# FIXME We lost the desk name, we need an additional embed %]	2428	[%# FIXME We lost the desk name, we need an additional embed %]
2430	nodes += '<span class="waitingat">%s</span>'.format(_("Waiting at %s since %s.".format(row.first_hold.pickup_library_id, $date(row.first_hold.waiting_date))));	2429	nodes += '<span class="waitingat">%s</span>'.format(_("Waiting at %s since %s.".format(row.first_hold._strings.pickup_library_id.str, $date(row.first_hold.waiting_date))));
2431	[% IF Koha.Preference('canreservefromotherbranches') %]	2430	[% IF Koha.Preference('canreservefromotherbranches') %]
2432	if ( row.first_hold.waiting_date \|\| row.first_hold.priority == 1 ) {	2431	if ( row.first_hold.waiting_date \|\| row.first_hold.priority == 1 ) {
2433	let patron_to_html = $patron_to_html(row.first_hold.patron); [%# FIXME What about hide_patron_infos_if_needed?? %]	2432	let patron_to_html = $patron_to_html(row.first_hold.patron); [%# FIXME What about hide_patron_infos_if_needed?? %]
2434	-