Attachment #167378 for bug #37023

View | Details | Raw Unified | Return to bug 37023
Collapse All | Expand All

Lines 848-853 sub fill { Link Here

(-)a/Koha/Hold.pm (+1 lines)
848	{	848	{
849	found => 'F',	849	found => 'F',
850	priority => 0,	850	priority => 0,
		851	timestamp => dt_from_string->strftime( '%Y-%m-%d %H:%M:%S' ),
851	$params->{item_id} ? ( itemnumber => $params->{item_id} ) : (),	852	$params->{item_id} ? ( itemnumber => $params->{item_id} ) : (),
852	}	853	}
853	);	854	);





subtest 'fill() tests' => sub {

    plan tests => 15;

    $schema->storage->txn_begin;


                biblionumber   => $biblio->id,
                borrowernumber => $patron->id,
                itemnumber     => $item->id,
                timestamp      => dt_from_string('2021-06-25 14:05:35'),
                priority       => 10,
            }
        }


    my $interface = 'api';
    C4::Context->interface($interface);
    my $hold_timestamp = $hold->timestamp;
    my $ret = $hold->fill;
    
    is( ref($ret), 'Koha::Hold', '->fill returns the object type' );
    is( $ret->id, $hold->id, '->fill returns the object' );



    is( $old_hold->id, $hold->id, 'reserve_id retained' );
    is( $old_hold->priority, 0, 'priority set to 0' );
    isnt( $old_hold->timestamp, $hold_timestamp, 'timestamp updated' );
    is( $old_hold->found, 'F', 'found set to F' );

    subtest 'item_id parameter' => sub {
- 

Return to bug 37023

Lines 106-112 subtest 'pickup_library/branch tests' => sub { Link Here

(-)a/t/db_dependent/Koha/Hold.t (-4 / +5 lines)
106		106
107	subtest 'fill() tests' => sub {	107	subtest 'fill() tests' => sub {
108		108
109	plan tests => 14;	109	plan tests => 15;
110		110
111	$schema->storage->txn_begin;	111	$schema->storage->txn_begin;
112		112
Lines 136-141 subtest 'fill() tests' => sub { Link Here
136	biblionumber => $biblio->id,	136	biblionumber => $biblio->id,
137	borrowernumber => $patron->id,	137	borrowernumber => $patron->id,
138	itemnumber => $item->id,	138	itemnumber => $item->id,
		139	timestamp => dt_from_string('2021-06-25 14:05:35'),
139	priority => 10,	140	priority => 10,
140	}	141	}
141	}	142	}
Lines 148-156 subtest 'fill() tests' => sub { Link Here
148		149
149	my $interface = 'api';	150	my $interface = 'api';
150	C4::Context->interface($interface);	151	C4::Context->interface($interface);
151		152	my $hold_timestamp = $hold->timestamp;
152	my $ret = $hold->fill;	153	my $ret = $hold->fill;
153		154
154	is( ref($ret), 'Koha::Hold', '->fill returns the object type' );	155	is( ref($ret), 'Koha::Hold', '->fill returns the object type' );
155	is( $ret->id, $hold->id, '->fill returns the object' );	156	is( $ret->id, $hold->id, '->fill returns the object' );
156		157
Lines 159-164 subtest 'fill() tests' => sub { Link Here
159		160
160	is( $old_hold->id, $hold->id, 'reserve_id retained' );	161	is( $old_hold->id, $hold->id, 'reserve_id retained' );
161	is( $old_hold->priority, 0, 'priority set to 0' );	162	is( $old_hold->priority, 0, 'priority set to 0' );
		163	isnt( $old_hold->timestamp, $hold_timestamp, 'timestamp updated' );
162	is( $old_hold->found, 'F', 'found set to F' );	164	is( $old_hold->found, 'F', 'found set to F' );
163		165
164	subtest 'item_id parameter' => sub {	166	subtest 'item_id parameter' => sub {
165	-