View | Details | Raw Unified | Return to bug 37508
Collapse All | Expand All

(-)a/C4/Reports/Guided.pm (-9 / +3 lines)
Lines 624-638 sub execute_query { Link Here
624
624
625
    return ( $sth, { queryerr => $sth->errstr } ) if ( $sth->err );
625
    return ( $sth, { queryerr => $sth->errstr } ) if ( $sth->err );
626
626
627
    if ( $sql =~ m/password/ ) {
627
    # Check if table.* contained forbidden column names
628
        return ( $sth, { passworderr => "Illegal column in SQL" } );
628
    return ( $sth, { passworderr => "Illegal column in results" } )
629
    }
629
        if Koha::Report->new->check_columns( undef, $sth->{NAME_lc} );
630
631
    foreach my $column ( @{ $sth->{NAME_lc} } ) {
632
        if ( $column eq 'password' ) {
633
            return ( $sth, { passworderr => "Illegal column in results" } );
634
        }
635
    }
636
630
637
    return ($sth);
631
    return ($sth);
638
}
632
}
(-)a/t/db_dependent/Reports/Guided.t (-1 / +2 lines)
Lines 1-3 Link Here
1
#!/usr/bin/perl
2
1
# Copyright 2012 Catalyst IT Ltd.
3
# Copyright 2012 Catalyst IT Ltd.
2
# Copyright 2015 Koha Development team
4
# Copyright 2015 Koha Development team
3
#
5
#
4
- 

Return to bug 37508