This method adds possibility to edit a booking

This method allows patching a booking

    if ( $params->{status} ) {

    my $new_status = $params->{'status'};

        if ( $params->{status} eq 'cancelled' ) {

    unless ($new_status) {

            $self->cancel( { send_letter => 1 } );

        return $self->store;

        }

        $self->_set_status( $params->{status} );

    return $self;

    $self->_set_status($new_status);

    my $status = $self->status;

    if ( $status eq 'cancelled' ) {

        $self->cancel( { send_letter => 1 } );

    }

    return $self->store;

    if ( $params->{send_letter} ) {

    if ( $params->{'send_letter'} ) {

=head3 set_status

=head2 Internal methods

=head3 _set_status

    my @valid_statuses = qw(pending completed cancelled);

    my @valid_statuses = qw(new completed cancelled);

    unless ( grep { $_ eq $new_status } @valid_statuses ) {

    my $is_valid       = any { $new_status eq $_ } @valid_statuses;

    unless ($is_valid) {

Will return the bookings that have not ended and without "CANCELLED" status.

Will return the bookings that have not ended, were cancelled or are completed.

            end_date => { '>=' => \'NOW()' },

            end_date => { '>='  => \'NOW()' },

            status   => { '!=' => 'cancelled' }

            status   => { q{!=} => [ -and => qw(cancelled completed) ] }

Controller function that editing an existing booking

Controller function that handles editing an existing booking

    my $c    = shift->openapi->valid_input or return;

    my $c = shift->openapi->valid_input or return;

    my $body = $c->req->json;

    my $booking = Koha::Bookings->find( $c->param('booking_id') );

    my $booking = $c->objects->find_rs( Koha::Bookings->new, $c->param('booking_id') );

        $booking->edit($body);

        $booking->edit( $c->req->json );

                        <fieldset class="action filters" style="cursor:pointer; display: flex; flex-direction: column;">

                        <fieldset class="action filters d-flex gap-2" style="cursor: pointer;">

                            <a id="expired_filter" class="filtered"><i class="fa fa-bars"></i> Show expired</a>

                            <a id="expired_filter" data-filter="expired"><i class="fa fa-bars"></i> Show expired</a>

                            <a id="cancelled_filter" class="filtered"><i class="fa fa-bars"></i> Show cancelled</a>

                            <a id="cancelled_filter" data-filter="cancelled"><i class="fa fa-bars"></i> Show cancelled</a>

                        content: $patron_to_html(booking.patron, {

                        content: !isActive ? `<s>${patronContent}</s>` : patronContent,

                            display_cardnumber: true,

                            url: false

                        }),

                        editable: booking.status != 'cancelled' ? { remove: true, updateTime: true } : false,

                        editable: booking.status !== "cancelled" ? { remove: true, updateTime: true } : false,

                        group: booking.item_id ? booking.item_id : 0,

                        group: booking.item_id ?? 0,

                        className: booking.status,

        let filter_expired = true;

        const filterStates = { expired: true, cancelled: false };

        let filter_cancelled = false;

        const additional_filters = {

        let additional_filters = {

            end_date: () => {

            end_date: function(){

                if (filterStates.expired) {

                if ( filter_expired ) {

                    return { ">=": today.toISOString() }

                    return { ">=": today.toISOString() };

                } else {

                    return;

            status: function(){

            status: () => {

                if ( filter_cancelled ) {

                const defaults = ["new", "pending", "active"];

                    return { "=": 'cancelled' }

                if (filterStates.cancelled) {

                } else {

                    const filtered = [...defaults, "cancelled"];

                    return;

                    return { "-in": filtered };

            }

                return { "-in": defaults };

            },

                    let is_expired = dayjs(row.end_date).isBefore(new Date());

                    const is_expired = dayjs(row.end_date).isBefore(new Date());

                    let is_cancelled = row.status == 'cancelled' ? 1 : 0;

                        return '<span class="badge rounded-pill bg-secondary">' + _("Expired") + '</span>';

                        return `<span class="badge rounded-pill bg-secondary">

                            ${_("Expired")}

                        </span>`;

                        return '<span class="badge rounded-pill bg-secondary">' + _("Cancelled") + '</span>';

                        return `<span class="badge rounded-pill bg-secondary">

                            ${_("Cancelled")}

                        </span>`;

                    return '<span class="badge rounded-pill bg-success">' + _("Active") + '</span>';

                    return `<span class="badge rounded-pill bg-success">

                        ${_("New")}

                    </span>`;

                    let is_cancelled = row.status == 'cancelled' ? 1 : 0;

                    let is_cancelled = row.status === "cancelled";

                    if( !is_cancelled ){

                    if (!is_cancelled) {

        function setupFilter(filterId, activeText, inactiveText, filterVariable) {

        document

            $(filterId).on("click", function() {

            .getElementById("expired_filter")

                if ($(this).hasClass('filtered')) {

            .addEventListener("click", (e) =>

                    filterVariable = false;

                handleFilter(

                    $(this).html('<i class="fa fa-filter"></i> ' + inactiveText);

                    e,

                } else {

                    { active: _("Hide expired"), inactive: _("Show expired") },

                    filterVariable = true;

                    filterStates,

                    $(this).html('<i class="fa fa-bars"></i> ' + activeText);

                ),

                }

            );

                bookings_table.DataTable().ajax.reload(() => {

        document

                    bookings_table.DataTable().column("status:name").visible(!filterVariable, false);

            .getElementById("cancelled_filter")

                });

            .addEventListener("click", (e) =>

                $(this).toggleClass('filtered');

                handleFilter(

                    e,

                    { active: _("Hide cancelled"), inactive: _("Show cancelled") },

                    filterStates,

                ),

            );

        function handleFilter(e, text, filterStates) {

            const target = e.target;

            const { filter } = target.dataset;

            if (target.classList.contains("filtered")) {

                filterStates[filter] = false;

                target.innerHTML = `<i class="fa fa-bars"></i> ${text.inactive}`;

            } else {

                filterStates[filter] = true;

                target.innerHTML = `<i class="fa fa-filter"></i> ${text.active}`;

            }

            bookings_table.DataTable().ajax.reload(() => {

                bookings_table

                    .DataTable()

                    .column("status:name")

                    .visible(filterStates[filter], false);

        setupFilter("#expired_filter", _("Show expired"), _("Hide expired"), filter_expired);

            target.classList.toggle("filtered");

        setupFilter("#cancelled_filter", _("Show cancelled"), _("Hide cancelled"), filter_cancelled);

        }

$('#cancelBookingModal').on('show.bs.modal', function(e) {

(() => {

    var button = $(e.relatedTarget);

    document

    var booking = button.data('booking');

        .getElementById("cancelBookingModal")

    $('#cancel_booking_id').val(booking);

        ?.addEventListener("show.bs.modal", handleShowBsModal);

});

    document

        .getElementById("cancelBookingForm")

$("#cancelBookingForm").on('submit', function(e) {

        ?.addEventListener("submit", handleSubmit);

    e.preventDefault();

    async function handleSubmit(e) {

    var booking_id = $('#cancel_booking_id').val();

        e.preventDefault();

    var url = '/api/v1/bookings/'+booking_id;

        const bookingIdInput = document.getElementById("cancel_booking_id");

    var cancelling = $.ajax({

        if (!bookingIdInput) {

        'method': "PATCH",

            return;

        'url': url,

        }

        'data': JSON.stringify({"status": "cancelled"}),

        'contentType': "application/json"

        const bookingId = bookingIdInput.value;

    });

        if (!bookingId) {

            return;

        }

    cancelling.done(function(data) {

        cancel_success = 1;

        let [error, response] = await catchError(

        if (bookings_table) {

            fetch(`/api/v1/bookings/${bookingId}`, {

            bookings_table.api().ajax.reload();

                method: "PATCH",

                body: JSON.stringify({ status: "cancelled" }),

                headers: {

                    "Content-Type": "application/json",

                },

            })

        );

        if (error || !response.ok) {

            const alertContainer = document.getElementById(

                "cancel_booking_result"

            );

            alertContainer.outerHTML = `

                <div id="booking_result" class="alert alert-danger">

                    ${__("Failure")}

                </div>

            `;

            return;

        if (typeof timeline !== 'undefined') {

            timeline.itemsData.remove(Number(booking_id));

        cancel_success = true;

        bookings_table?.api().ajax.reload();

        timeline?.itemsData.remove(Number(booking_id));

        $("#cancelBookingModal").modal("hide");

        const bookingsCount = document.querySelector(".bookings_count");

        if (!bookingsCount) {

            return;

        $('.bookings_count').html(parseInt($('.bookings_count').html(), 10)-1);

        $('#cancelBookingModal').modal('hide');

        bookingsCount.innerHTML = parseInt(bookingsCount.innerHTML, 10) - 1;

    });

    }

    cancelling.fail(function(data) {

    function handleShowBsModal(e) {

        $('#cancel_booking_result').replaceWith('<div id="booking_result" class="alert alert-danger">'+__("Failure")+'</div>');

        const button = e.relatedTarget;

    });

        if (!button) {

});

            return;

        }

        const booking = button.dataset.booking;

        if (!booking) {

            return;

        }

        const bookingIdInput = document.getElementById("cancel_booking_id");

        if (!bookingIdInput) {

            return;

        }

        bookingIdInput.value = booking;

    }

    function catchError(promise) {

        return promise.then(data => [undefined, data]).catch(error => [error]);

    }

})();

            url: "/api/v1/bookings?biblio_id=" + biblionumber + "&_per_page=-1",

            url:

                "/api/v1/bookings?biblio_id=" +

                biblionumber +

                "&_per_page=-1" +

                '&q={"status":{"-in":["new","pending","active"]}}',

    $booking_with_old_status->set_status('completed');

    $booking_with_old_status->_set_status('completed');

    $booking_with_old_status->set_status('cancelled');

    $booking_with_old_status->_set_status('cancelled');

        eval { $booking_with_old_status->set_status('blah'); };

        eval { $booking_with_old_status->_set_status('blah'); };