Attachment #174037 for bug #33766

View | Details | Raw Unified | Return to bug 33766
Collapse All | Expand All




use Modern::Perl;

return {
    bug_number  => "33766",
    description => "Add syspref to determine text content of userid input field's label.",
    up          => sub {
        my ($args) = @_;
        my ( $dbh, $out ) = @$args{qw(dbh out)};

        # Do you stuffs here
        $dbh->do(
            q{INSERT IGNORE INTO systempreferences (variable,value) VALUES ('OPACLoginLabelTextContent','Cardnumber')  }
        );

        # sysprefs
        say $out "Added new system preference 'OPACLoginLabelTextContent'";
    },
};

Lines 513-518 INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` Link Here

(-)a/installer/data/mysql/mandatory/sysprefs.sql (+1 lines)
513	('OPACLocalCoverImages','0','1','Display local cover images on OPAC search and details pages.','YesNo'),	513	('OPACLocalCoverImages','0','1','Display local cover images on OPAC search and details pages.','YesNo'),
514	('OpacLocationBranchToDisplay','holding','holding\|home\|both','In the OPAC, under location show which branch for Location in the record details.','Choice'),	514	('OpacLocationBranchToDisplay','holding','holding\|home\|both','In the OPAC, under location show which branch for Location in the record details.','Choice'),
515	('OpacLocationOnDetail','holding','holding\|home\|both\|column','In the OPAC detail, display the shelving location on its own column or under a library columns.', 'Choice'),	515	('OpacLocationOnDetail','holding','holding\|home\|both\|column','In the OPAC detail, display the shelving location on its own column or under a library columns.', 'Choice'),
		516	('OPACLoginLabelTextContent','Cardnumber',NULL,NULL,NULL),
516	('OpacMaintenance','0','','If ON, enables maintenance warning in OPAC','YesNo'),	517	('OpacMaintenance','0','','If ON, enables maintenance warning in OPAC','YesNo'),
517	('OPACMandatoryHoldDates', '', '\|start\|end\|both', 'Define which hold dates are required on OPAC reserve form', 'Choice'),	518	('OPACMandatoryHoldDates', '', '\|start\|end\|both', 'Define which hold dates are required on OPAC reserve form', 'Choice'),
518	('OpacMaxItemsToDisplay','50','','Max items to display at the OPAC on a biblio detail','Integer'),	519	('OpacMaxItemsToDisplay','50','','Max items to display at the OPAC on a biblio detail','Integer'),




                  column: "on a separate column"
            - "for items on the OPAC record details page."
            - "<br />Note: If 'on a separate column' is selected, you still need to enable the item_shelving_location display on the <a href='/cgi-bin/koha/admin/columns_settings.pl'>configure columns</a> administration page."
        -
            - Use
            - pref: OPACLoginLabelTextContent
              default: Cardnumber
              choices:
                  Cardnumber: Cardnumber
                  Username: Username
                  "Cardnumber or Username": Cardnumber or Username
            - "as the text content of the userid input field's label."
        -
            - pref: OPACShowMusicalInscripts
              default: 0

              type: textarea
              syntax: text/html
              class: code

        -
            - pref: OpacBrowseSearch
              default: 0

Lines 438-444 Link Here

(-)a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc (-1 / +1 lines)
438	<input type="hidden" name="koha_login_context" value="opac" />	438	<input type="hidden" name="koha_login_context" value="opac" />
439	<fieldset class="brief">	439	<fieldset class="brief">
440	<div class="local-login">	440	<div class="local-login">
441	<label for="muserid">Login:</label><input type="text" id="muserid" name="login_userid" autocomplete="off" />	441	<label for="muserid">[% Koha.Preference('OPACLoginLabelTextContent') \| html %]:</label><input type="text" id="muserid" name="login_userid" autocomplete="off" />
442	<label for="mpassword">Password:</label><input type="password" id="mpassword" name="login_password" autocomplete="off" />	442	<label for="mpassword">Password:</label><input type="password" id="mpassword" name="login_password" autocomplete="off" />
443	<fieldset class="action">	443	<fieldset class="action">
444	<input type="hidden" name="op" value="cud-login" />	444	<input type="hidden" name="op" value="cud-login" />

Lines 242-248 Link Here

(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt (-1 / +1 lines)
242	<input type="hidden" name="[% INPUT.name \| html %]" value="[% INPUT.value \| html %]" />	242	<input type="hidden" name="[% INPUT.name \| html %]" value="[% INPUT.value \| html %]" />
243	[% END %]	243	[% END %]
244	<div class="form-group">	244	<div class="form-group">
245	<label for="userid">Login:</label>	245	<label for="userid">[% Koha.Preference('OPACLoginLabelTextContent') \| html %]:</label>
246	<input class="form-control" type="text" size="25" id="userid" name="login_userid" autocomplete="off" />	246	<input class="form-control" type="text" size="25" id="userid" name="login_userid" autocomplete="off" />
247	</div>	247	</div>
248	<div class="form-group">	248	<div class="form-group">

Lines 200-206 Link Here

(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt (-1 / +1 lines)
200	<p>If you do not have an external account, but do have a local account, you can still log in: </p>	200	<p>If you do not have an external account, but do have a local account, you can still log in: </p>
201	[% END # /IF identity_providers.size %]	201	[% END # /IF identity_providers.size %]
202	<div class="local-login">	202	<div class="local-login">
203	<label for="userid">Login:</label>	203	<label for="userid">[% Koha.Preference('OPACLoginLabelTextContent') \| html %]:</label>
204	<input class="form-control" type="text" id="userid" name="login_userid" autocomplete="off" />	204	<input class="form-control" type="text" id="userid" name="login_userid" autocomplete="off" />
205	<label for="password">Password:</label>	205	<label for="password">Password:</label>
206	<input class="form-control" type="password" id="password" name="login_password" autocomplete="off" />	206	<input class="form-control" type="password" id="password" name="login_password" autocomplete="off" />

Lines 132-138 Link Here

(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt (-1 / +1 lines)
132	<p>To reset your password, enter your login or your email address.</p>	132	<p>To reset your password, enter your login or your email address.</p>
133	<fieldset class="brief">	133	<fieldset class="brief">
134	<div class="form-group">	134	<div class="form-group">
135	<label for="username">Login:</label>	135	<label for="username">[% Koha.Preference('OPACLoginLabelTextContent') \| html %]:</label>
136	<input class="form-control" type="text" id="username" size="40" name="username" value="[% username \| html %]" />	136	<input class="form-control" type="text" id="username" size="40" name="username" value="[% username \| html %]" />
137	</div>	137	</div>
138		138

Lines 109-115 Link Here

(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-registration-confirmation.tt (-1 / +1 lines)
109	<input type="hidden" name="op" value="cud-login">	109	<input type="hidden" name="op" value="cud-login">
110	<fieldset class="brief">	110	<fieldset class="brief">
111	<legend>Log in to your account:</legend>	111	<legend>Log in to your account:</legend>
112	<label for="userid">Login:</label>	112	<label for="userid">[% Koha.Preference('OPACLoginLabelTextContent') \| html %]:</label>
113	[% IF Koha.Preference('PatronSelfRegistrationPrefillForm') %]	113	[% IF Koha.Preference('PatronSelfRegistrationPrefillForm') %]
114	<input class="form-control" type="text" id="userid" size="10" name="login_userid" value="[% borrower.userid \| html %]" autocomplete="off" />	114	<input class="form-control" type="text" id="userid" size="10" name="login_userid" value="[% borrower.userid \| html %]" autocomplete="off" />
115	[% ELSE %]	115	[% ELSE %]

Lines 75-81 Link Here

(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reset-password.tt (-1 / +1 lines)
75		75
76	<fieldset class="brief">	76	<fieldset class="brief">
77	<div class="form-group">	77	<div class="form-group">
78	<label for="userid">Login:</label>	78	<label for="userid">[% Koha.Preference('OPACLoginLabelTextContent') \| html %]:</label>
79	<input class="form-control" autocomplete="off" type="text" size="25" id="userid" name="userid" />	79	<input class="form-control" autocomplete="off" type="text" size="25" id="userid" name="userid" />
80	</div>	80	</div>
81	<div class="form-group">	81	<div class="form-group">

Lines 466-472 Link Here

(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt (-2 / +1 lines)
466	<fieldset>	466	<fieldset>
467	[% IF ( Koha.Preference('SelfCheckoutByLogin') ) %]	467	[% IF ( Koha.Preference('SelfCheckoutByLogin') ) %]
468	<legend>Log in to your account</legend>	468	<legend>Log in to your account</legend>
469	<label for="patronlogin">Login:</label>	469	<label for="patronlogin">[% Koha.Preference('OPACLoginLabelTextContent') \| html %]:</label>
470	<input type="text" id="patronlogin" class="focus noEnterSubmit" size="20" name="patronlogin" autocomplete="off"/>	470	<input type="text" id="patronlogin" class="focus noEnterSubmit" size="20" name="patronlogin" autocomplete="off"/>
471	<label for="patronpw">Password:</label>	471	<label for="patronpw">Password:</label>
472	<input type="password" id="patronpw" size="20" name="patronpw" autocomplete="off"/>	472	<input type="password" id="patronpw" size="20" name="patronpw" autocomplete="off"/>
473	-

Return to bug 33766

Lines 181-186 OPAC: Link Here

(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref (+10 lines)
181	column: "on a separate column"	181	column: "on a separate column"
182	- "for items on the OPAC record details page."	182	- "for items on the OPAC record details page."
183	- "<br />Note: If 'on a separate column' is selected, you still need to enable the item_shelving_location display on the <a href='/cgi-bin/koha/admin/columns_settings.pl'>configure columns</a> administration page."	183	- "<br />Note: If 'on a separate column' is selected, you still need to enable the item_shelving_location display on the <a href='/cgi-bin/koha/admin/columns_settings.pl'>configure columns</a> administration page."
		184	-
		185	- Use
		186	- pref: OPACLoginLabelTextContent
		187	default: Cardnumber
		188	choices:
		189	Cardnumber: Cardnumber
		190	Username: Username
		191	"Cardnumber or Username": Cardnumber or Username
		192	- "as the text content of the userid input field's label."
184	-	193	-
185	- pref: OPACShowMusicalInscripts	194	- pref: OPACShowMusicalInscripts
186	default: 0	195	default: 0
Lines 533-538 OPAC: Link Here
533	type: textarea	542	type: textarea
534	syntax: text/html	543	syntax: text/html
535	class: code	544	class: code
		545
536	-	546	-
537	- pref: OpacBrowseSearch	547	- pref: OpacBrowseSearch
538	default: 0	548	default: 0

Line 0 Link Here

(-)a/installer/data/mysql/atomicupdate/bug_33766-a11y_fix_ambiguous_form-field_in_opac-auth.tt (+18 lines)
	1	use Modern::Perl;
	2
	3	return {
	4	bug_number => "33766",
	5	description => "Add syspref to determine text content of userid input field's label.",
	6	up => sub {
	7	my ($args) = @_;
	8	my ( $dbh, $out ) = @$args{qw(dbh out)};
	9
	10	# Do you stuffs here
	11	$dbh->do(
	12	q{INSERT IGNORE INTO systempreferences (variable,value) VALUES ('OPACLoginLabelTextContent','Cardnumber') }
	13	);
	14
	15	# sysprefs
	16	say $out "Added new system preference 'OPACLoginLabelTextContent'";
	17	},
	18	};