View | Details | Raw Unified | Return to bug 38615
Collapse All | Expand All

(-)a/C4/SIP/ILS.pm (-2 / +5 lines)
Lines 432-439 sub cancel_hold { Link Here
432
		    last;		# ?? should we keep going, in case there are multiples
432
		    last;		# ?? should we keep going, in case there are multiples
433
		}
433
		}
434
    }
434
    }
435
435
    if ( C4::Context->preference('HoldCancellationRequestSIP') ) {
436
    $trans->screen_msg("Hold Cancelled.");
436
        $trans->screen_msg("Hold Cancellation Requested.");
437
    } else {
438
        $trans->screen_msg("Hold Cancelled.");
439
    }
437
440
438
    return $trans;
441
    return $trans;
439
}
442
}
(-)a/C4/SIP/ILS/Transaction/Hold.pm (-1 / +6 lines)
Lines 94-101 sub drop_hold { Link Here
94
    my $holds = $item->holds->search({ borrowernumber => $patron->borrowernumber });
94
    my $holds = $item->holds->search({ borrowernumber => $patron->borrowernumber });
95
95
96
    return $self unless $holds->count;
96
    return $self unless $holds->count;
97
    my $hold = $holds->next;
97
98
98
    $holds->next->cancel;
99
    if ( C4::Context->preference('HoldCancellationRequestSIP') ) {
100
        $hold->add_cancellation_request;
101
    } else {
102
        $hold->cancel;
103
    }
99
104
100
	$self->ok(1);
105
	$self->ok(1);
101
	return $self;
106
	return $self;
(-)a/installer/data/mysql/mandatory/sysprefs.sql (+1 lines)
Lines 299-304 INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` Link Here
299
('hidelostitems','0','','If ON, disables display of\"lost\" items in OPAC.','YesNo'),
299
('hidelostitems','0','','If ON, disables display of\"lost\" items in OPAC.','YesNo'),
300
('HidePatronName','0','','If this is switched on, patron\'s cardnumber will be shown instead of their name on the holds and catalog screens','YesNo'),
300
('HidePatronName','0','','If this is switched on, patron\'s cardnumber will be shown instead of their name on the holds and catalog screens','YesNo'),
301
('HidePersonalPatronDetailOnCirculation', 0, '', 'Hide patrons phone number, email address, street address and city in the circulation page','YesNo'),
301
('HidePersonalPatronDetailOnCirculation', 0, '', 'Hide patrons phone number, email address, street address and city in the circulation page','YesNo'),
302
('HoldCancellationRequestSIP','0','','Option to set holds cancelled via SIP as cancelation requests','YesNo'),
302
('HoldFeeMode','not_always','any_time_is_placed|not_always|any_time_is_collected','Set the hold fee mode','Choice'),
303
('HoldFeeMode','not_always','any_time_is_placed|not_always|any_time_is_collected','Set the hold fee mode','Choice'),
303
('HoldRatioDefault','3','','Default value for the hold ratio report','Integer'),
304
('HoldRatioDefault','3','','Default value for the hold ratio report','Integer'),
304
('HoldsAutoFill','0',NULL,'If on, librarian will not be asked if hold should be filled, it will be filled automatically','YesNo'),
305
('HoldsAutoFill','0',NULL,'If on, librarian will not be asked if hold should be filled, it will be filled automatically','YesNo'),
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref (-1 / +6 lines)
Lines 1095-1100 Circulation: Link Here
1095
                  1: "Do"
1095
                  1: "Do"
1096
                  0: "Don't"
1096
                  0: "Don't"
1097
            - place a hold when ordering from a suggestion.
1097
            - place a hold when ordering from a suggestion.
1098
        -
1099
            - pref: HoldCancellationRequestSIP
1100
              choices:
1101
                  1: "Do"
1102
                  0: "Don't"
1103
            - set holds cancelled via SIP as cancellation requests.
1098
    Patron restrictions:
1104
    Patron restrictions:
1099
        -
1105
        -
1100
            - pref: PatronRestrictionTypes
1106
            - pref: PatronRestrictionTypes
1101
- 

Return to bug 38615