View | Details | Raw Unified | Return to bug 38615
Collapse All | Expand All

(-)a/C4/SIP/ILS.pm (-2 / +5 lines)
Lines 471-478 sub cancel_hold { Link Here
471
            last;    # ?? should we keep going, in case there are multiples
471
            last;    # ?? should we keep going, in case there are multiples
472
        }
472
        }
473
    }
473
    }
474
474
    if ( C4::Context->preference('HoldCancellationRequestSIP') ) {
475
    $trans->screen_msg("Hold Cancelled.");
475
        $trans->screen_msg("Hold Cancellation Requested.");
476
    } else {
477
        $trans->screen_msg("Hold Cancelled.");
478
    }
476
479
477
    return $trans;
480
    return $trans;
478
}
481
}
(-)a/C4/SIP/ILS/Transaction/Hold.pm (-1 / +6 lines)
Lines 94-101 sub drop_hold { Link Here
94
    my $holds = $item->holds->search( { borrowernumber => $patron->borrowernumber } );
94
    my $holds = $item->holds->search( { borrowernumber => $patron->borrowernumber } );
95
95
96
    return $self unless $holds->count;
96
    return $self unless $holds->count;
97
    my $hold = $holds->next;
97
98
98
    $holds->next->cancel;
99
    if ( C4::Context->preference('HoldCancellationRequestSIP') ) {
100
        $hold->add_cancellation_request;
101
    } else {
102
        $hold->cancel;
103
    }
99
104
100
    $self->ok(1);
105
    $self->ok(1);
101
    return $self;
106
    return $self;
(-)a/installer/data/mysql/mandatory/sysprefs.sql (+1 lines)
Lines 300-305 INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` Link Here
300
('HidePatronName','0','','If this is switched on, patron\'s cardnumber will be shown instead of their name on the holds and catalog screens','YesNo'),
300
('HidePatronName','0','','If this is switched on, patron\'s cardnumber will be shown instead of their name on the holds and catalog screens','YesNo'),
301
('HidePersonalPatronDetailOnCirculation', 0, '', 'Hide patrons phone number, email address, street address and city in the circulation page','YesNo'),
301
('HidePersonalPatronDetailOnCirculation', 0, '', 'Hide patrons phone number, email address, street address and city in the circulation page','YesNo'),
302
('hide_marc','0',NULL,'If ON, disables display of MARC fields, subfield codes & indicators (still shows data)','YesNo'),
302
('hide_marc','0',NULL,'If ON, disables display of MARC fields, subfield codes & indicators (still shows data)','YesNo'),
303
('HoldCancellationRequestSIP','0','','Option to set holds cancelled via SIP as cancelation requests','YesNo'),
303
('HoldFeeMode','not_always','any_time_is_placed|not_always|any_time_is_collected','Set the hold fee mode','Choice'),
304
('HoldFeeMode','not_always','any_time_is_placed|not_always|any_time_is_collected','Set the hold fee mode','Choice'),
304
('HoldRatioDefault','3','','Default value for the hold ratio report','Integer'),
305
('HoldRatioDefault','3','','Default value for the hold ratio report','Integer'),
305
('HoldsAutoFill','0',NULL,'If on, librarian will not be asked if hold should be filled, it will be filled automatically','YesNo'),
306
('HoldsAutoFill','0',NULL,'If on, librarian will not be asked if hold should be filled, it will be filled automatically','YesNo'),
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref (-1 / +6 lines)
Lines 1100-1105 Circulation: Link Here
1100
                  1: "Do"
1100
                  1: "Do"
1101
                  0: "Don't"
1101
                  0: "Don't"
1102
            - place a hold when ordering from a suggestion.
1102
            - place a hold when ordering from a suggestion.
1103
        -
1104
            - pref: HoldCancellationRequestSIP
1105
              choices:
1106
                  1: "Do"
1107
                  0: "Don't"
1108
            - set holds cancelled via SIP as cancellation requests.
1103
    Patron restrictions:
1109
    Patron restrictions:
1104
        -
1110
        -
1105
            - pref: PatronRestrictionTypes
1111
            - pref: PatronRestrictionTypes
1106
- 

Return to bug 38615