View | Details | Raw Unified | Return to bug 39325
Collapse All | Expand All

(-)a/C4/Accounts.pm (-1 / +1 lines)
Lines 146-152 B<$days> -- Zero balance fees older than B<$days> days old will be deleted. Link Here
146
146
147
B<Warning:> Because fines and payments are not linked in accountlines, it is
147
B<Warning:> Because fines and payments are not linked in accountlines, it is
148
possible for a fine to be deleted without the accompanying payment,
148
possible for a fine to be deleted without the accompanying payment,
149
or vise versa. This won't affect the account balance, but might be
149
or vice versa. This won't affect the account balance, but might be
150
confusing to staff.
150
confusing to staff.
151
151
152
=cut
152
=cut
(-)a/C4/Acquisition.pm (-6 / +6 lines)
Lines 142-150 sub GetOrderFromItemnumber { Link Here
142
142
143
  $aqbasket = &GetBasket($basketnumber);
143
  $aqbasket = &GetBasket($basketnumber);
144
144
145
get all basket informations in aqbasket for a given basket
145
get all basket information in aqbasket for a given basket
146
146
147
B<returns:> informations for a given basket returned as a hashref.
147
B<returns:> information for a given basket returned as a hashref.
148
148
149
=cut
149
=cut
150
150
Lines 2022-2028 sub get_rounded_price { Link Here
2022
2022
2023
  \@order_loop = GetHistory( %params );
2023
  \@order_loop = GetHistory( %params );
2024
2024
2025
Retreives some acquisition history information
2025
Retrieves some acquisition history information
2026
2026
2027
params:
2027
params:
2028
  title
2028
  title
Lines 2547-2553 sub GetInvoices { Link Here
2547
2547
2548
    my $invoice = GetInvoice($invoiceid);
2548
    my $invoice = GetInvoice($invoiceid);
2549
2549
2550
Get informations about invoice with given $invoiceid
2550
Get information about invoice with given $invoiceid
2551
2551
2552
Return a hash filled with aqinvoices.* fields
2552
Return a hash filled with aqinvoices.* fields
2553
2553
Lines 2576-2584 sub GetInvoice { Link Here
2576
2576
2577
    my $invoice = GetInvoiceDetails($invoiceid)
2577
    my $invoice = GetInvoiceDetails($invoiceid)
2578
2578
2579
Return informations about an invoice + the list of related order lines
2579
Return information about an invoice + the list of related order lines
2580
2580
2581
Orders informations are in $invoice->{orders} (array ref)
2581
Orders information are in $invoice->{orders} (array ref)
2582
2582
2583
=cut
2583
=cut
2584
2584
(-)a/C4/Auth.pm (-9 / +9 lines)
Lines 113-119 C4::Auth - Authenticates Koha users Link Here
113
=head1 DESCRIPTION
113
=head1 DESCRIPTION
114
114
115
The main function of this module is to provide
115
The main function of this module is to provide
116
authentification. However the get_template_and_user function has
116
authentication. However the get_template_and_user function has
117
been provided so that a users login information is passed along
117
been provided so that a users login information is passed along
118
automatically. This gets loaded into the template.
118
automatically. This gets loaded into the template.
119
119
Lines 173-179 BEGIN { Link Here
173
     );
173
     );
174
174
175
This call passes the C<query>, C<flagsrequired> and C<authnotrequired>
175
This call passes the C<query>, C<flagsrequired> and C<authnotrequired>
176
to C<&checkauth> (in this module) to perform authentification.
176
to C<&checkauth> (in this module) to perform authentication.
177
See C<&checkauth> for an explanation of these parameters.
177
See C<&checkauth> for an explanation of these parameters.
178
178
179
The C<template_name> is then used to find the correct template for
179
The C<template_name> is then used to find the correct template for
Lines 766-772 user has authenticated, C<&checkauth> restarts the original script Link Here
766
The login page is provided using a HTML::Template, which is set in the
766
The login page is provided using a HTML::Template, which is set in the
767
systempreferences table or at the top of this file. The variable C<$type>
767
systempreferences table or at the top of this file. The variable C<$type>
768
selects which template to use, either the opac or the intranet
768
selects which template to use, either the opac or the intranet
769
authentification template.
769
authentication template.
770
770
771
C<&checkauth> returns a user ID, a cookie, and a session ID. The
771
C<&checkauth> returns a user ID, a cookie, and a session ID. The
772
cookie should be sent back to the browser; it verifies that the user
772
cookie should be sent back to the browser; it verifies that the user
Lines 1032-1038 sub checkauth { Link Here
1032
    if ($logout) {
1032
    if ($logout) {
1033
1033
1034
        # voluntary logout the user
1034
        # voluntary logout the user
1035
        # check wether the user was using their shibboleth session or a local one
1035
        # check FIXME CODESPELL (wether ==> weather, whether) the user was using their shibboleth session or a local one
1036
        my $shibSuccess = C4::Context->userenv ? C4::Context->userenv->{'shibboleth'} : undef;
1036
        my $shibSuccess = C4::Context->userenv ? C4::Context->userenv->{'shibboleth'} : undef;
1037
        if ($session) {
1037
        if ($session) {
1038
            $session->delete();
1038
            $session->delete();
Lines 1413-1419 sub checkauth { Link Here
1413
        }
1413
        }
1414
    }
1414
    }
1415
1415
1416
    # finished authentification, now respond
1416
    # finished authentication, now respond
1417
    if ( $auth_state eq 'completed' || $authnotrequired ) {
1417
    if ( $auth_state eq 'completed' || $authnotrequired ) {
1418
1418
1419
        # successful login
1419
        # successful login
Lines 1691-1697 sub check_api_auth { Link Here
1691
    if ( C4::Context->preference('Version') < $kohaversion ) {
1691
    if ( C4::Context->preference('Version') < $kohaversion ) {
1692
1692
1693
        # database in need of version update; assume that
1693
        # database in need of version update; assume that
1694
        # no API should be called while databsae is in
1694
        # no API should be called while database is in
1695
        # this condition.
1695
        # this condition.
1696
        return ( "maintenance", undef, undef );
1696
        return ( "maintenance", undef, undef );
1697
    }
1697
    }
Lines 1737-1743 sub check_api_auth { Link Here
1737
            # User / password auth
1737
            # User / password auth
1738
            unless ( $userid and $password ) {
1738
            unless ( $userid and $password ) {
1739
1739
1740
                # caller did something wrong, fail the authenticateion
1740
                # caller did something wrong, fail the authentication
1741
                return ( "failed", undef, undef );
1741
                return ( "failed", undef, undef );
1742
            }
1742
            }
1743
            my $newuserid;
1743
            my $newuserid;
Lines 1858-1864 sub check_api_auth { Link Here
1858
Given a CGISESSID cookie set during a previous login to Koha, determine
1858
Given a CGISESSID cookie set during a previous login to Koha, determine
1859
if the user has the privileges specified by C<$userflags>. C<$userflags>
1859
if the user has the privileges specified by C<$userflags>. C<$userflags>
1860
is passed unaltered into C<haspermission> and as such accepts all options
1860
is passed unaltered into C<haspermission> and as such accepts all options
1861
avaiable to that routine with the one caveat that C<check_api_auth> will
1861
available to that routine with the one caveat that C<check_api_auth> will
1862
also allow 'undef' to be passed and in such a case the permissions check
1862
also allow 'undef' to be passed and in such a case the permissions check
1863
will be skipped altogether.
1863
will be skipped altogether.
1864
1864
Lines 1906-1912 sub check_cookie_auth { Link Here
1906
        if ( C4::Context->preference('Version') < $kohaversion ) {
1906
        if ( C4::Context->preference('Version') < $kohaversion ) {
1907
1907
1908
            # database in need of version update; assume that
1908
            # database in need of version update; assume that
1909
            # no API should be called while databsae is in
1909
            # no API should be called while database is in
1910
            # this condition.
1910
            # this condition.
1911
            return ( "maintenance", undef );
1911
            return ( "maintenance", undef );
1912
        }
1912
        }
(-)a/C4/Auth_with_cas.pm (-1 / +1 lines)
Lines 290-296 sub _url_with_get_params { Link Here
290
sub logout_if_required {
290
sub logout_if_required {
291
    my ($query) = @_;
291
    my ($query) = @_;
292
292
293
    # Check we havent been hit by a logout call
293
    # Check we haven't been hit by a logout call
294
    my $xml = $query->param('logoutRequest');
294
    my $xml = $query->param('logoutRequest');
295
    return 0 unless $xml;
295
    return 0 unless $xml;
296
296
(-)a/C4/Auth_with_ldap.pm (-2 / +2 lines)
Lines 123-129 sub checkpw_ldap { Link Here
123
    my @hosts = split( ',', $prefhost );
123
    my @hosts = split( ',', $prefhost );
124
    my $db    = Net::LDAP->new( \@hosts );
124
    my $db    = Net::LDAP->new( \@hosts );
125
    unless ($db) {
125
    unless ($db) {
126
        warn "LDAP connexion failed";
126
        warn "LDAP connection failed";
127
        return 0;
127
        return 0;
128
    }
128
    }
129
129
Lines 456-462 C4::Auth - Authenticates Koha users Link Here
456
456
457
=head1 LDAP Configuration
457
=head1 LDAP Configuration
458
458
459
    This module is specific to LDAP authentification. It requires Net::LDAP package and one or more
459
    This module is specific to LDAP authentication. It requires Net::LDAP package and one or more
460
	working LDAP servers.
460
	working LDAP servers.
461
	To use it :
461
	To use it :
462
	   * Modify ldapserver element in KOHA_CONF
462
	   * Modify ldapserver element in KOHA_CONF
(-)a/C4/Biblio.pm (-8 / +8 lines)
Lines 371-377 task to rebuild the holds queue for the biblio if I<RealTimeHoldsQueue> is enabl Link Here
371
371
372
=item C<skip_record_index>
372
=item C<skip_record_index>
373
373
374
Used when the indexing schedulling will be handled by the caller
374
Used when the indexing scheduling will be handled by the caller
375
375
376
=item C<record_source_id>
376
=item C<record_source_id>
377
377
Lines 528-534 I<$params> is a hashref containing extra parameters. Valid keys are: Link Here
528
528
529
=item B<skip_holds_queue>: used when the holds queue update will be handled by the caller
529
=item B<skip_holds_queue>: used when the holds queue update will be handled by the caller
530
530
531
=item B<skip_record_index>: used when the indexing schedulling will be handled by the caller
531
=item B<skip_record_index>: used when the indexing scheduling will be handled by the caller
532
532
533
=back
533
=back
534
=cut
534
=cut
Lines 939-949 sub GetISBDView { Link Here
939
    my $tagslib = GetMarcStructure( 1, $itemtype, { unsafe => 1 } );
939
    my $tagslib = GetMarcStructure( 1, $itemtype, { unsafe => 1 } );
940
940
941
    my $ISBD = C4::Context->preference($sysprefname);
941
    my $ISBD = C4::Context->preference($sysprefname);
942
    my $bloc = $ISBD;
942
    my $block = $ISBD;
943
    my $res;
943
    my $res;
944
    my $blocres;
944
    my $blocres;
945
945
946
    foreach my $isbdfield ( split( /#/, $bloc ) ) {
946
    foreach my $isbdfield ( split( /#/, $block ) ) {
947
947
948
        #         $isbdfield= /(.?.?.?)/;
948
        #         $isbdfield= /(.?.?.?)/;
949
        $isbdfield =~ /(\d\d\d)([^\|])?\|(.*)\|(.*)\|(.*)/;
949
        $isbdfield =~ /(\d\d\d)([^\|])?\|(.*)\|(.*)\|(.*)/;
Lines 982-988 sub GetISBDView { Link Here
982
                                $calculated =~ s#/cgi-bin/koha/[^/]+/([^.]*.pl\?.*)$#opac-$1#g;
982
                                $calculated =~ s#/cgi-bin/koha/[^/]+/([^.]*.pl\?.*)$#opac-$1#g;
983
                            }
983
                            }
984
984
985
                            # field builded, store the result
985
                            # field built, store the result
986
                            if ( $calculated && !$hasputtextbefore ) {    # put textbefore if not done
986
                            if ( $calculated && !$hasputtextbefore ) {    # put textbefore if not done
987
                                $blocres .= $textbefore;
987
                                $blocres .= $textbefore;
988
                                $hasputtextbefore = 1;
988
                                $hasputtextbefore = 1;
Lines 1027-1033 sub GetISBDView { Link Here
1027
                            }
1027
                            }
1028
                        }
1028
                        }
1029
1029
1030
                        # field builded, store the result
1030
                        # field built, store the result
1031
                        if ( $calculated && !$hasputtextbefore ) {    # put textbefore if not done
1031
                        if ( $calculated && !$hasputtextbefore ) {    # put textbefore if not done
1032
                            $blocres .= $textbefore;
1032
                            $blocres .= $textbefore;
1033
                            $hasputtextbefore = 1;
1033
                            $hasputtextbefore = 1;
Lines 1199-1205 The following options are supported: Link Here
1199
1199
1200
Pass { unsafe => 1 } do disable cached object cloning,
1200
Pass { unsafe => 1 } do disable cached object cloning,
1201
and instead get a shared reference, resulting in better
1201
and instead get a shared reference, resulting in better
1202
performance (but care must be taken so that retured object
1202
performance (but care must be taken so that returned object
1203
is never modified).
1203
is never modified).
1204
1204
1205
Note: If you call GetMarcSubfieldStructure with unsafe => 1, do not modify or
1205
Note: If you call GetMarcSubfieldStructure with unsafe => 1, do not modify or
Lines 2303-2309 sub TransformHtmlToMarc { Link Here
2303
            $newfield = 0;
2303
            $newfield = 0;
2304
            my $j = $i + 2;
2304
            my $j = $i + 2;
2305
2305
2306
            if ( $tag < 10 ) {    # no code for theses fields
2306
            if ( $tag < 10 ) {    # no code for FIXME CODESPELL (theses ==> these, thesis) fields
2307
                                  # in MARC editor, 000 contains the leader.
2307
                                  # in MARC editor, 000 contains the leader.
2308
                next if $tag == $biblionumbertagfield;
2308
                next if $tag == $biblionumbertagfield;
2309
                my $fval = $cgi->param( $params[ $j + 1 ] );
2309
                my $fval = $cgi->param( $params[ $j + 1 ] );
(-)a/C4/Budgets.pm (-2 / +2 lines)
Lines 819-825 sub _recursiveAdd { Link Here
819
    }
819
    }
820
}
820
}
821
821
822
# Recursive method to add a budget and its chidren to an array
822
# Recursive method to add a budget and its children to an array
823
sub _add_budget_children {
823
sub _add_budget_children {
824
    my $res    = shift;
824
    my $res    = shift;
825
    my $budget = shift;
825
    my $budget = shift;
Lines 1054-1060 sub GetBudgetsByActivity { Link Here
1054
1054
1055
Get all but cancelled orders for all funds.
1055
Get all but cancelled orders for all funds.
1056
1056
1057
If the optionnal activity parameter is passed, returns orders for active/inactive budgets only.
1057
If the optional activity parameter is passed, returns orders for active/inactive budgets only.
1058
1058
1059
active = 1
1059
active = 1
1060
inactive = 0
1060
inactive = 0
(-)a/C4/Charset.pm (-3 / +3 lines)
Lines 368-374 removed. Link Here
368
This function exists to work around a problem
368
This function exists to work around a problem
369
that can occur with badly-encoded MARC records.
369
that can occur with badly-encoded MARC records.
370
Specifically, if a UTF-8 MARC record also
370
Specifically, if a UTF-8 MARC record also
371
has excape (\x1b) characters, MARC::File::XML
371
has escape (\x1b) characters, MARC::File::XML
372
will let the escape characters pass through
372
will let the escape characters pass through
373
when as_xml() or as_xml_record() is called.  The
373
when as_xml() or as_xml_record() is called.  The
374
problem is that the escape character is not
374
problem is that the escape character is not
Lines 707-713 sub _marc_to_utf8_via_text_iconv { Link Here
707
    my $decoder;
707
    my $decoder;
708
    eval { $decoder = Text::Iconv->new( $source_encoding, 'utf8' ); };
708
    eval { $decoder = Text::Iconv->new( $source_encoding, 'utf8' ); };
709
    if ($@) {
709
    if ($@) {
710
        push @errors, "Could not initialze $source_encoding => utf8 converter: $@";
710
        push @errors, "Could not initialize $source_encoding => utf8 converter: $@";
711
        return @errors;
711
        return @errors;
712
    }
712
    }
713
713
Lines 1043-1049 $chars{0xc777} = 0x1e87; # small w with dot above Link Here
1043
$chars{0xc778} = 0x1e8b;    # small x with dot above
1043
$chars{0xc778} = 0x1e8b;    # small x with dot above
1044
$chars{0xc779} = 0x1e8f;    # small y with dot above
1044
$chars{0xc779} = 0x1e8f;    # small y with dot above
1045
$chars{0xc77a} = 0x017c;    # small z with dot above
1045
$chars{0xc77a} = 0x017c;    # small z with dot above
1046
                            # 4/8 trema, diaresis
1046
                            # 4/8 trema, diaeresis
1047
$chars{0xc820} = 0x00a8;    # diaeresis
1047
$chars{0xc820} = 0x00a8;    # diaeresis
1048
$chars{0xc841} = 0x00c4;    # capital a with diaeresis
1048
$chars{0xc841} = 0x00c4;    # capital a with diaeresis
1049
$chars{0xc845} = 0x00cb;    # capital e with diaeresis
1049
$chars{0xc845} = 0x00cb;    # capital e with diaeresis
(-)a/C4/Circulation.pm (-7 / +7 lines)
Lines 751-757 item withdrawn. Link Here
751
item is restricted (set by ??)
751
item is restricted (set by ??)
752
752
753
C<$needsconfirmation> a reference to a hash. It contains reasons why the loan 
753
C<$needsconfirmation> a reference to a hash. It contains reasons why the loan 
754
could be prevented, but ones that can be overriden by the operator.
754
could be prevented, but ones that can be overridden by the operator.
755
755
756
Possible values are :
756
Possible values are :
757
757
Lines 1574-1581 AddIssue does the following things : Link Here
1574
              - fill recall if recall to this patron
1574
              - fill recall if recall to this patron
1575
              - cancel recall or not
1575
              - cancel recall or not
1576
              - revert recall's waiting status or not
1576
              - revert recall's waiting status or not
1577
          * TRANSFERT PENDING ?
1577
          * FIXME CODESPELL (TRANSFERT ==> TRANSFER, TRANSFERRED) PENDING ?
1578
              - complete the transfert
1578
              - complete the FIXME CODESPELL (transfert ==> transfer, transferred)
1579
          * ISSUE THE BOOK
1579
          * ISSUE THE BOOK
1580
1580
1581
=back
1581
=back
Lines 1704-1710 sub AddIssue { Link Here
1704
1704
1705
            C4::Reserves::MoveReserve( $item_object->itemnumber, $patron->borrowernumber, $cancelreserve );
1705
            C4::Reserves::MoveReserve( $item_object->itemnumber, $patron->borrowernumber, $cancelreserve );
1706
1706
1707
            # Starting process for transfer job (checking transfert and validate it if we have one)
1707
            # Starting process for transfer job (checking FIXME CODESPELL (transfert ==> transfer, transferred) and validate it if we have one)
1708
            if ( my $transfer = $item_object->get_transfer ) {
1708
            if ( my $transfer = $item_object->get_transfer ) {
1709
1709
1710
                # updating line of branchtranfert to finish it, and changing the to branch value, implement a comment for visibility of this case (maybe for stats ....)
1710
                # updating line of branchtranfert to finish it, and changing the to branch value, implement a comment for visibility of this case (maybe for stats ....)
Lines 2010-2016 category only Link Here
2010
default branch and category
2010
default branch and category
2011
2011
2012
If no rule has been found in the database, it will default to
2012
If no rule has been found in the database, it will default to
2013
the buillt in rule:
2013
the built in rule:
2014
2014
2015
patron_maxissueqty - undef
2015
patron_maxissueqty - undef
2016
patron_maxonsiteissueqty - undef
2016
patron_maxonsiteissueqty - undef
Lines 2699-2705 Ideally, this function would be internal to C<C4::Circulation>, Link Here
2699
not exported, but it is currently used in misc/cronjobs/longoverdue.pl
2699
not exported, but it is currently used in misc/cronjobs/longoverdue.pl
2700
and offline_circ/process_koc.pl.
2700
and offline_circ/process_koc.pl.
2701
2701
2702
The last optional parameter allos passing skip_record_index to the item store call.
2702
The last optional parameter allows passing skip_record_index to the item store call.
2703
2703
2704
=cut
2704
=cut
2705
2705
Lines 4140-4146 sub CalcDateDue { Link Here
4140
4140
4141
        # if the calculated due date is after the 'before' Hard Due Date (ceiling), override
4141
        # if the calculated due date is after the 'before' Hard Due Date (ceiling), override
4142
        # if the calculated date is before the 'after' Hard Due Date (floor), override
4142
        # if the calculated date is before the 'after' Hard Due Date (floor), override
4143
        # if the hard due date is set to 'exactly', overrride
4143
        # if the hard due date is set to 'exactly', override
4144
        if ( $hardduedatecompare == 0 || $hardduedatecompare == $cmp ) {
4144
        if ( $hardduedatecompare == 0 || $hardduedatecompare == $cmp ) {
4145
            $datedue = $hardduedate->clone;
4145
            $datedue = $hardduedate->clone;
4146
        }
4146
        }
(-)a/C4/ClassSplitRoutine/Dewey.pm (-1 / +1 lines)
Lines 56-62 sub split_callnumber { Link Here
56
    }
56
    }
57
57
58
    if ( $lines[0] =~ /^([-a-zA-Z]+)\s?($possible_decimal)$/ ) {
58
    if ( $lines[0] =~ /^([-a-zA-Z]+)\s?($possible_decimal)$/ ) {
59
        shift @lines;              # pull off the mathching first element, like example 1
59
        shift @lines;              # pull off the matching first element, like example 1
60
        unshift @lines, $1, $2;    # replace it with the two pieces
60
        unshift @lines, $1, $2;    # replace it with the two pieces
61
    }
61
    }
62
62
(-)a/C4/Context.pm (-1 / +1 lines)
Lines 107-113 sub import { Link Here
107
107
108
    # Create the default context ($C4::Context::Context)
108
    # Create the default context ($C4::Context::Context)
109
    # the first time the module is called
109
    # the first time the module is called
110
    # (a config file can be optionaly passed)
110
    # (a config file can be optionally passed)
111
111
112
    # default context already exists?
112
    # default context already exists?
113
    return if $context;
113
    return if $context;
(-)a/C4/Contract.pm (-1 / +1 lines)
Lines 46-52 use C4::Contract; Link Here
46
=head1 DESCRIPTION
46
=head1 DESCRIPTION
47
47
48
The functions in this module deal with contracts. They allow to
48
The functions in this module deal with contracts. They allow to
49
add a new contract, to modify it or to get some informations around
49
add a new contract, to modify it or to get some information around
50
a contract.
50
a contract.
51
51
52
=cut
52
=cut
(-)a/C4/Creators/Batch.pm (-1 / +1 lines)
Lines 286-292 This module provides methods for creating, and otherwise manipulating batch obje Link Here
286
=head2 delete()
286
=head2 delete()
287
287
288
    Invoking the delete method attempts to delete the template from the database. The method returns -1 upon failure. Errors are logged to the Apache log.
288
    Invoking the delete method attempts to delete the template from the database. The method returns -1 upon failure. Errors are logged to the Apache log.
289
    NOTE: This method may also be called as a function and passed a key/value pair simply deleteing that batch from the database. See the example below.
289
    NOTE: This method may also be called as a function and passed a key/value pair simply deleting that batch from the database. See the example below.
290
290
291
    examples:
291
    examples:
292
        my $exitstat = $batch->delete(); # to delete the record behind the $batch object
292
        my $exitstat = $batch->delete(); # to delete the record behind the $batch object
(-)a/C4/Creators/Layout.pm (-1 / +1 lines)
Lines 378-384 R = Right Link Here
378
=head2 delete()
378
=head2 delete()
379
379
380
    Invoking the delete method attempts to delete the layout from the database. The method returns 0 upon success and -1 upon failure. Errors are logged to the Apache log.
380
    Invoking the delete method attempts to delete the layout from the database. The method returns 0 upon success and -1 upon failure. Errors are logged to the Apache log.
381
    NOTE: This method may also be called as a function and passed a key/value pair simply deleteing that template from the database. See the example below.
381
    NOTE: This method may also be called as a function and passed a key/value pair simply deleting that template from the database. See the example below.
382
382
383
    examples:
383
    examples:
384
        C<my $exitstat = $layout->delete(); # to delete the record behind the $layout object>
384
        C<my $exitstat = $layout->delete(); # to delete the record behind the $layout object>
(-)a/C4/Creators/Lib.pm (-3 / +3 lines)
Lines 271-277 ADD_LAYOUTS: Link Here
271
  my $profiles = get_all_profiles({ fields => [@fields], filters => { filters => [$value1, $value2] } });
271
  my $profiles = get_all_profiles({ fields => [@fields], filters => { filters => [$value1, $value2] } });
272
272
273
This function returns an arrayref whose elements are hashes containing all profiles upon success and 1 upon failure. Errors are logged
273
This function returns an arrayref whose elements are hashes containing all profiles upon success and 1 upon failure. Errors are logged
274
to the Apache log. Two parameters are accepted. The first limits the field(s) returned. This parameter should be string of comma separted
274
to the Apache log. Two parameters are accepted. The first limits the field(s) returned. This parameter should be string of comma separated
275
fields. ie. "field_1, field_2, ...field_n" The second limits the records returned based on a string containing a valud SQL 'WHERE' filter.
275
fields. ie. "field_1, field_2, ...field_n" The second limits the records returned based on a string containing a valud SQL 'WHERE' filter.
276
276
277
NOTE: Do not pass in the keyword 'WHERE.'
277
NOTE: Do not pass in the keyword 'WHERE.'
Lines 382-388 sub get_label_summary { Link Here
382
        $record->{'author'} =~ s/[^\.|\w]$//
382
        $record->{'author'} =~ s/[^\.|\w]$//
383
            if $record->{'author'};    # strip off ugly trailing chars... but not periods or word chars
383
            if $record->{'author'};    # strip off ugly trailing chars... but not periods or word chars
384
        $record->{'title'} =~ s/\W*$//;    # strip off ugly trailing chars
384
        $record->{'title'} =~ s/\W*$//;    # strip off ugly trailing chars
385
         # FIXME contructing staff interface URLs should be done *much* higher up the stack - for the most part, C4 module code
385
         # FIXME constructing staff interface URLs should be done *much* higher up the stack - for the most part, C4 module code
386
         # should not know that it's part of a web app
386
         # should not know that it's part of a web app
387
        $label_summary->{'_summary'} =
387
        $label_summary->{'_summary'} =
388
            { title => $record->{title}, author => $record->{author}, biblionumber => $record->{biblionumber} };
388
            { title => $record->{title}, author => $record->{author}, biblionumber => $record->{biblionumber} };
Lines 527-533 sub get_table_names { Link Here
527
527
528
=head2 C4::Creators::Lib::html_table()
528
=head2 C4::Creators::Lib::html_table()
529
529
530
This function returns an arrayref of an array of hashes contianing the supplied data formatted suitably to
530
This function returns an arrayref of an array of hashes containing the supplied data formatted suitably to
531
be passed off as a template parameter and used to build an html table.
531
be passed off as a template parameter and used to build an html table.
532
532
533
   my $table = html_table(header_fields, array_of_row_data);
533
   my $table = html_table(header_fields, array_of_row_data);
(-)a/C4/Creators/Profile.pm (-1 / +1 lines)
Lines 265-271 CM = SI Centimeters (28.3464567 points per) Link Here
265
=head2 delete()
265
=head2 delete()
266
266
267
    Invoking the delete method attempts to delete the profile from the database. The method returns -1 upon failure. Errors are logged to the Apache log.
267
    Invoking the delete method attempts to delete the profile from the database. The method returns -1 upon failure. Errors are logged to the Apache log.
268
    NOTE: This method may also be called as a function and passed a key/value pair simply deleteing that profile from the database. See the example below.
268
    NOTE: This method may also be called as a function and passed a key/value pair simply deleting that profile from the database. See the example below.
269
269
270
    examples:
270
    examples:
271
        C<my $exitstat = $profile->delete(); # to delete the record behind the $profile object>
271
        C<my $exitstat = $profile->delete(); # to delete the record behind the $profile object>
(-)a/C4/Creators/Template.pm (-2 / +2 lines)
Lines 309-315 This module provides methods for creating, retrieving, and otherwise manipulatin Link Here
309
    Invoking the I<new> method constructs a new template object containing the default values for a template.
309
    Invoking the I<new> method constructs a new template object containing the default values for a template.
310
    The following parameters are optionally accepted as key => value pairs:
310
    The following parameters are optionally accepted as key => value pairs:
311
311
312
        C<profile_id>           A valid profile id to be assciated with this template. NOTE: The profile must exist in the database and B<not> be assigned to another template.
312
        C<profile_id>           A valid profile id to be associated with this template. NOTE: The profile must exist in the database and B<not> be assigned to another template.
313
        C<template_code>        A template code. ie. 'Avery 5160 | 1 x 2-5/8'
313
        C<template_code>        A template code. ie. 'Avery 5160 | 1 x 2-5/8'
314
        C<template_desc>        A readable description of the template. ie. '3 columns, 10 rows of labels'
314
        C<template_desc>        A readable description of the template. ie. '3 columns, 10 rows of labels'
315
        C<page_width>           The width of the page measured in the units supplied by the units parameter in this template.
315
        C<page_width>           The width of the page measured in the units supplied by the units parameter in this template.
Lines 373-379 CM = SI Centimeters (28.3464567 points per) Link Here
373
=head2 delete()
373
=head2 delete()
374
374
375
    Invoking the delete method attempts to delete the template from the database. The method returns -1 upon failure. Errors are logged to the Apache log.
375
    Invoking the delete method attempts to delete the template from the database. The method returns -1 upon failure. Errors are logged to the Apache log.
376
    NOTE: This method may also be called as a function and passed a key/value pair simply deleteing that template from the database. See the example below.
376
    NOTE: This method may also be called as a function and passed a key/value pair simply deleting that template from the database. See the example below.
377
377
378
    examples:
378
    examples:
379
        C<my $exitstat = $template->delete(); # to delete the record behind the $template object>
379
        C<my $exitstat = $template->delete(); # to delete the record behind the $template object>
(-)a/C4/Form/MessagingPreferences.pm (-1 / +1 lines)
Lines 156-162 PREF: foreach my $option (@$messaging_options) { Link Here
156
156
157
=item Handle when form input is invalid
157
=item Handle when form input is invalid
158
158
159
=item Generalize into a system of form handler clases
159
=item Generalize into a system of form handler FIXME CODESPELL (clases ==> classes, clashes, cases)
160
160
161
=back
161
=back
162
162
(-)a/C4/HoldsQueue.pm (-1 / +1 lines)
Lines 711-717 RETRY: Link Here
711
sub MapItemsToHoldRequests {
711
sub MapItemsToHoldRequests {
712
    my ( $hold_requests, $available_items, $branches_to_use, $transport_cost_matrix ) = @_;
712
    my ( $hold_requests, $available_items, $branches_to_use, $transport_cost_matrix ) = @_;
713
713
714
    # handle trival cases
714
    # handle trivial cases
715
    return unless scalar(@$hold_requests) > 0;
715
    return unless scalar(@$hold_requests) > 0;
716
    return unless scalar(@$available_items) > 0;
716
    return unless scalar(@$available_items) > 0;
717
717
(-)a/C4/ILSDI/Services.pm (-2 / +2 lines)
Lines 253-259 sub GetRecords { Link Here
253
        foreach my $item (@items) {
253
        foreach my $item (@items) {
254
            my %item = %{ $item->unblessed };
254
            my %item = %{ $item->unblessed };
255
255
256
            # This hides additionnal XML subfields, we don't need these info
256
            # This hides additional XML subfields, we don't need these info
257
            delete $item{'more_subfields_xml'};
257
            delete $item{'more_subfields_xml'};
258
258
259
            # Display branch names instead of branch codes
259
            # Display branch names instead of branch codes
Lines 493-499 sub GetPatronInfo { Link Here
493
493
494
            my ( $item, $biblio, $biblioitem ) = ( {}, {}, {} );
494
            my ( $item, $biblio, $biblioitem ) = ( {}, {}, {} );
495
495
496
            # Get additional informations
496
            # Get additional information
497
            if ( $hold->itemnumber ) {    # item level holds
497
            if ( $hold->itemnumber ) {    # item level holds
498
                $item       = Koha::Items->find( $hold->itemnumber );
498
                $item       = Koha::Items->find( $hold->itemnumber );
499
                $biblio     = $item->biblio;
499
                $biblio     = $item->biblio;
(-)a/C4/ImportExportFramework.pm (-4 / +4 lines)
Lines 177-183 C4::ImportExportFramework - Import/Export Framework to Excel-xml/ODS Module Func Link Here
177
Module to Import/Export Framework to Excel-xml/ODS on intranet administration - MARC Frameworks section
177
Module to Import/Export Framework to Excel-xml/ODS on intranet administration - MARC Frameworks section
178
178
179
Module to Import/Export Framework to Excel-xml/ODS on intranet administration - MARC Frameworks section
179
Module to Import/Export Framework to Excel-xml/ODS on intranet administration - MARC Frameworks section
180
exporting the tables marc_tag_structure, marc_subfield_structure to excel-xml/ods or viceversa
180
exporting the tables marc_tag_structure, marc_subfield_structure to excel-xml/ods or vice-versa
181
181
182
Functions for handling import/export.
182
Functions for handling import/export.
183
183
Lines 191-197 Functions for handling import/export. Link Here
191
Export all information of a bibliographic or authority MARC framework to an Excel "xml" file, comma separated values "csv" or OpenDocument SpreadSheet "ods".
191
Export all information of a bibliographic or authority MARC framework to an Excel "xml" file, comma separated values "csv" or OpenDocument SpreadSheet "ods".
192
192
193
return :
193
return :
194
succes
194
success
195
195
196
=cut
196
=cut
197
197
Lines 746-752 sub ImportFramework { Link Here
746
        }
746
        }
747
        unlink($filename) if ($deleteFilename);    # remove temporary file
747
        unlink($filename) if ($deleteFilename);    # remove temporary file
748
    } else {
748
    } else {
749
        Koha::Logger->get->warn("Error ImportFramework no conex to database or not readeable $filename");
749
        Koha::Logger->get->warn("Error ImportFramework no conex to database or not readable $filename");
750
    }
750
    }
751
    if ( $deleteFilename && $tempdir && -d $tempdir && -w $tempdir ) {
751
    if ( $deleteFilename && $tempdir && -d $tempdir && -w $tempdir ) {
752
        eval {
752
        eval {
Lines 1009-1015 sub _import_table_csv { Link Here
1009
    while ( my $row = $csv->getline($dom) ) {
1009
    while ( my $row = $csv->getline($dom) ) {
1010
        my @fields = @$row;
1010
        my @fields = @$row;
1011
        @arrData = @fields;
1011
        @arrData = @fields;
1012
        next if scalar @arrData == grep { $_ eq '' } @arrData;    # Emtpy lines
1012
        next if scalar @arrData == grep { $_ eq '' } @arrData;    # Empty lines
1013
            #$arrData[0] = substr($arrData[0], 1) if ($arrData[0] =~ /^"/);
1013
            #$arrData[0] = substr($arrData[0], 1) if ($arrData[0] =~ /^"/);
1014
            #$arrData[$#arrData] =~ s/[\r\n]+$//;
1014
            #$arrData[$#arrData] =~ s/[\r\n]+$//;
1015
            #chop $arrData[$#arrData] if ($arrData[$#arrData] =~ /"$/);
1015
            #chop $arrData[$#arrData] if ($arrData[$#arrData] =~ /"$/);
(-)a/C4/InstallAuth.pm (-4 / +4 lines)
Lines 65-71 InstallAuth - Authenticates Koha users for Install process Link Here
65
=head1 DESCRIPTION
65
=head1 DESCRIPTION
66
66
67
The main function of this module is to provide
67
The main function of this module is to provide
68
authentification. However the get_template_and_user function has
68
authentication. However the get_template_and_user function has
69
been provided so that a users login information is passed along
69
been provided so that a users login information is passed along
70
automatically. This gets loaded into the template.
70
automatically. This gets loaded into the template.
71
This package is different from C4::Auth in so far as
71
This package is different from C4::Auth in so far as
Lines 87-93 As in C4::Auth, Authentication is based on cookies. Link Here
87
    );
87
    );
88
88
89
This call passes the C<query>, C<flagsrequired> and C<authnotrequired>
89
This call passes the C<query>, C<flagsrequired> and C<authnotrequired>
90
to C<&checkauth> (in this module) to perform authentification.
90
to C<&checkauth> (in this module) to perform authentication.
91
See C<&checkauth> for an explanation of these parameters.
91
See C<&checkauth> for an explanation of these parameters.
92
92
93
The C<template_name> is then used to find the correct template for
93
The C<template_name> is then used to find the correct template for
Lines 222-228 user has authenticated, C<&checkauth> restarts the original script Link Here
222
The login page is provided using a HTML::Template, which is set in the
222
The login page is provided using a HTML::Template, which is set in the
223
systempreferences table or at the top of this file. The variable C<$type>
223
systempreferences table or at the top of this file. The variable C<$type>
224
selects which template to use, either the opac or the intranet 
224
selects which template to use, either the opac or the intranet 
225
authentification template.
225
authentication template.
226
226
227
C<&checkauth> returns a user ID, a cookie, and a session ID. The
227
C<&checkauth> returns a user ID, a cookie, and a session ID. The
228
cookie should be sent back to the browser; it verifies that the user
228
cookie should be sent back to the browser; it verifies that the user
Lines 341-347 sub checkauth { Link Here
341
        }
341
        }
342
    }
342
    }
343
343
344
    # finished authentification, now respond
344
    # finished authentication, now respond
345
    if ($loggedin) {
345
    if ($loggedin) {
346
346
347
        # successful login
347
        # successful login
(-)a/C4/Installer.pm (-2 / +2 lines)
Lines 407-413 sub load_sql_in_order { Link Here
407
                unless ( index( $systempreference, $file[ scalar(@file) - 1 ] ) >= 0 );
407
                unless ( index( $systempreference, $file[ scalar(@file) - 1 ] ) >= 0 );
408
        }
408
        }
409
409
410
        #Bulding here a hierarchy to display files by level.
410
        #Building here a hierarchy to display files by level.
411
        push @{ $hashlevel{$level} },
411
        push @{ $hashlevel{$level} },
412
            { "fwkname" => $file[ scalar(@file) - 1 ], "error" => $error };
412
            { "fwkname" => $file[ scalar(@file) - 1 ], "error" => $error };
413
    }
413
    }
Lines 628-634 sub load_sql { Link Here
628
  my $filename = $installer->get_file_path_from_name('script_name');
628
  my $filename = $installer->get_file_path_from_name('script_name');
629
629
630
searches through the set of known SQL scripts and finds the fully
630
searches through the set of known SQL scripts and finds the fully
631
qualified path name for the script that mathches the input.
631
qualified path name for the script that matches the input.
632
632
633
returns undef if no match was found.
633
returns undef if no match was found.
634
634
(-)a/C4/Items.pm (-1 / +1 lines)
Lines 571-577 seen. It is ordered by callnumber then title. Link Here
571
571
572
The required minlocation & maxlocation parameters are used to specify a range of item callnumbers
572
The required minlocation & maxlocation parameters are used to specify a range of item callnumbers
573
the datelastseen can be used to specify that you want to see items not seen since a past date only.
573
the datelastseen can be used to specify that you want to see items not seen since a past date only.
574
offset & size can be used to retrieve only a part of the whole listing (defaut behaviour)
574
offset & size can be used to retrieve only a part of the whole listing (default behaviour)
575
$statushash requires a hashref that has the authorized values fieldname (intems.notforloan, etc...) as keys, and an arrayref of statuscodes we are searching for as values.
575
$statushash requires a hashref that has the authorized values fieldname (intems.notforloan, etc...) as keys, and an arrayref of statuscodes we are searching for as values.
576
576
577
$iTotalRecords is the number of rows that would have been returned without the $offset, $size limit clause
577
$iTotalRecords is the number of rows that would have been returned without the $offset, $size limit clause
(-)a/C4/Labels/Label.pm (-2 / +2 lines)
Lines 632-638 This module provides methods for creating, and otherwise manipulating single lab Link Here
632
=head2 new()
632
=head2 new()
633
633
634
    Invoking the I<new> method constructs a new label object containing the supplied values. Depending on the final output format of the label data
634
    Invoking the I<new> method constructs a new label object containing the supplied values. Depending on the final output format of the label data
635
    the minimal required parameters change. (See the implimentation of this object type in labels/label-create-pdf.pl and labels/label-create-csv.pl
635
    the minimal required parameters change. (See the implementation of this object type in labels/label-create-pdf.pl and labels/label-create-csv.pl
636
    and labels/label-create-xml.pl for examples.) The following parameters are optionally accepted as key => value pairs:
636
    and labels/label-create-xml.pl for examples.) The following parameters are optionally accepted as key => value pairs:
637
637
638
        C<batch_id>             Batch id with which this label is associated
638
        C<batch_id>             Batch id with which this label is associated
Lines 765-771 R = Right Link Here
765
765
766
=head2 create_label()
766
=head2 create_label()
767
767
768
    Invoking the I<create_label> method generates the text for that label and returns it as an arrayref of an array contianing the formatted text as well as creating the barcode
768
    Invoking the I<create_label> method generates the text for that label and returns it as an arrayref of an array containing the formatted text as well as creating the barcode
769
    and writing it directly to the pdf stream. The handling of the barcode is not quite good OO form due to the linear format of PDF::Reuse::Barcode. Be aware that the instantiating
769
    and writing it directly to the pdf stream. The handling of the barcode is not quite good OO form due to the linear format of PDF::Reuse::Barcode. Be aware that the instantiating
770
    code is responsible to properly format the text for insertion into the pdf stream as well as the actual insertion.
770
    code is responsible to properly format the text for insertion into the pdf stream as well as the actual insertion.
771
771
(-)a/C4/Languages.pm (-4 / +4 lines)
Lines 423-434 sub _build_languages_arrayref { Link Here
423
    my @ordered_keys = sort {
423
    my @ordered_keys = sort {
424
        my $aa     = '';
424
        my $aa     = '';
425
        my $bb     = '';
425
        my $bb     = '';
426
        my $acount = @{ $language_groups->{$a} };
426
        my $account = @{ $language_groups->{$a} };
427
        my $bcount = @{ $language_groups->{$b} };
427
        my $bcount = @{ $language_groups->{$b} };
428
        if ( $language_groups->{$a}->[0]->{enabled} ) {
428
        if ( $language_groups->{$a}->[0]->{enabled} ) {
429
            $aa = $language_groups->{$a}->[0]->{rfc4646_subtag};
429
            $aa = $language_groups->{$a}->[0]->{rfc4646_subtag};
430
        } elsif ( $acount > 1 ) {
430
        } elsif ( $account > 1 ) {
431
            for ( my $i = 1 ; $i < $acount ; $i++ ) {
431
            for ( my $i = 1 ; $i < $account ; $i++ ) {
432
                if ( $language_groups->{$a}->[$i]->{enabled} ) {
432
                if ( $language_groups->{$a}->[$i]->{enabled} ) {
433
                    $aa = $language_groups->{$a}->[$i]->{rfc4646_subtag};
433
                    $aa = $language_groups->{$a}->[$i]->{rfc4646_subtag};
434
                    last;
434
                    last;
Lines 623-629 sub accept_language { Link Here
623
    my @languages = ();
623
    my @languages = ();
624
    if ($clientPreferences) {
624
    if ($clientPreferences) {
625
625
626
        # There should be no whitespace anways, but a cleanliness/sanity check
626
        # There should be no whitespace anyway, but a cleanliness/sanity check
627
        $clientPreferences =~ s/\s//g;
627
        $clientPreferences =~ s/\s//g;
628
628
629
        # Prepare the list of client-acceptable languages
629
        # Prepare the list of client-acceptable languages
(-)a/C4/Letters.pm (-6 / +6 lines)
Lines 80-86 C4::Letters - Give functions for Letters management Link Here
80
80
81
=head1 DESCRIPTION
81
=head1 DESCRIPTION
82
82
83
  "Letters" is the tool used in Koha to manage informations sent to the patrons and/or the library. This include some cron jobs like
83
  "Letters" is the tool used in Koha to manage information sent to the patrons and/or the library. This include some cron jobs like
84
  late issues, as well as other tasks like sending a mail to users that have subscribed to a "serial issue alert" (= being warned every time a new issue has arrived at the library)
84
  late issues, as well as other tasks like sending a mail to users that have subscribed to a "serial issue alert" (= being warned every time a new issue has arrived at the library)
85
85
86
  Letters are managed through "alerts" sent by Koha on some events. All "alert" related functions are in this module too.
86
  Letters are managed through "alerts" sent by Koha on some events. All "alert" related functions are in this module too.
Lines 88-94 C4::Letters - Give functions for Letters management Link Here
88
=head2 GetLetters([$module])
88
=head2 GetLetters([$module])
89
89
90
  $letters = &GetLetters($module);
90
  $letters = &GetLetters($module);
91
  returns informations about letters.
91
  returns information about letters.
92
  if needed, $module filters for letters given module
92
  if needed, $module filters for letters given module
93
93
94
  DEPRECATED - You must use Koha::Notice::Templates instead
94
  DEPRECATED - You must use Koha::Notice::Templates instead
Lines 236-242 sub GetLettersAvailableForALibrary { Link Here
236
    );
236
    );
237
237
238
    Delete the letter. The mtt parameter is facultative.
238
    Delete the letter. The mtt parameter is facultative.
239
    If not given, all templates mathing the other parameters will be removed.
239
    If not given, all templates matching the other parameters will be removed.
240
240
241
=cut
241
=cut
242
242
Lines 1597-1603 sub _send_message_by_email { Link Here
1597
    }
1597
    }
1598
1598
1599
    # if initial message address was empty, coming here means that a to address was found and
1599
    # if initial message address was empty, coming here means that a to address was found and
1600
    # queue should be updated; same if to address was overriden by Koha::Email->create
1600
    # queue should be updated; same if to address was overridden by Koha::Email->create
1601
    _update_message_to_address( $message->{'message_id'}, $email->email->header('To') )
1601
    _update_message_to_address( $message->{'message_id'}, $email->email->header('To') )
1602
        if !$message->{to_address}
1602
        if !$message->{to_address}
1603
        || $message->{to_address} ne $email->email->header('To');
1603
        || $message->{to_address} ne $email->email->header('To');
Lines 1975-1981 sub _get_tt_params { Link Here
1975
        },
1975
        },
1976
        problem_reports => {
1976
        problem_reports => {
1977
            module   => 'Koha::ProblemReports',
1977
            module   => 'Koha::ProblemReports',
1978
            singluar => 'problemreport',
1978
            singular => 'problemreport',
1979
            plural   => 'problemreports',
1979
            plural   => 'problemreports',
1980
            pk       => 'reportid'
1980
            pk       => 'reportid'
1981
        },
1981
        },
Lines 2040-2046 sub _get_tt_params { Link Here
2040
                my $object;
2040
                my $object;
2041
                if ( @{ $tables->{$table} } == 1 ) {    # Param is a single key
2041
                if ( @{ $tables->{$table} } == 1 ) {    # Param is a single key
2042
                    $object = $module->search( { $pk => $tables->{$table} } )->last();
2042
                    $object = $module->search( { $pk => $tables->{$table} } )->last();
2043
                } else {                                # Params are mutliple foreign keys
2043
                } else {                                # Params are multiple foreign keys
2044
                    croak "Multiple foreign keys (table $table) should be passed using an hashref";
2044
                    croak "Multiple foreign keys (table $table) should be passed using an hashref";
2045
                }
2045
                }
2046
                $params->{ $config->{$table}->{singular} } = $object;
2046
                $params->{ $config->{$table}->{singular} } = $object;
(-)a/C4/Log.pm (-1 / +1 lines)
Lines 181-187 sub logaction { Link Here
181
  &cronlogaction($infos);
181
  &cronlogaction($infos);
182
182
183
Convenience routine to add a record into action_logs table from a cron job.
183
Convenience routine to add a record into action_logs table from a cron job.
184
Logs the path and name of the calling script plus the information privided by param $infos.
184
Logs the path and name of the calling script plus the information provided by param $infos.
185
185
186
=cut
186
=cut
187
187
(-)a/C4/Matcher.pm (-3 / +3 lines)
Lines 487-493 parameter identifies the index that will be searched, while $score Link Here
487
is the weight that will be added if a match is found.
487
is the weight that will be added if a match is found.
488
488
489
$matchcomponents should be a reference to an array of matchpoint
489
$matchcomponents should be a reference to an array of matchpoint
490
compoents, each of which should be a hash containing the following 
490
components, each of which should be a hash containing the following
491
keys:
491
keys:
492
    tag
492
    tag
493
    subfields
493
    subfields
Lines 524-530 sub add_matchpoint { Link Here
524
524
525
525
526
Adds a simple matchpoint rule -- after composing a key based on the source tag and subfields,
526
Adds a simple matchpoint rule -- after composing a key based on the source tag and subfields,
527
normalized per the normalization fuction, search the index.  All records retrieved
527
normalized per the normalization function, search the index.  All records retrieved
528
will receive the assigned score.
528
will receive the assigned score.
529
529
530
=cut
530
=cut
Lines 865-871 sub _get_match_keys { Link Here
865
    # matchpoint includes both 003 and 001), any repeats
865
    # matchpoint includes both 003 and 001), any repeats
866
    # of the first component's tag are identified; repeats
866
    # of the first component's tag are identified; repeats
867
    # of the subsequent components' tags are appended to
867
    # of the subsequent components' tags are appended to
868
    # each parallel key dervied from the first component,
868
    # each parallel key derived from the first component,
869
    # up to the number of repeats of the first component's tag.
869
    # up to the number of repeats of the first component's tag.
870
    #
870
    #
871
    # For example, if the record has one 003 and two 001s, only
871
    # For example, if the record has one 003 and two 001s, only
(-)a/C4/Members/Messaging.pm (-1 / +1 lines)
Lines 43-49 This module lets you modify a patron's messaging preferences. Link Here
43
  my $preferences = C4::Members::Messaging::GetMessagingPreferences( { categorycode => 'LIBRARY',
43
  my $preferences = C4::Members::Messaging::GetMessagingPreferences( { categorycode => 'LIBRARY',
44
                                                                       message_name   => 'Item_Due ' } );
44
                                                                       message_name   => 'Item_Due ' } );
45
45
46
returns: a hashref of messaging preferences for a borrower or patron category for a particlar message_name
46
returns: a hashref of messaging preferences for a borrower or patron category for a particular message_name
47
47
48
Requires either a borrowernumber or a categorycode key, but not both.
48
Requires either a borrowernumber or a categorycode key, but not both.
49
49
(-)a/C4/Record.pm (-1 / +1 lines)
Lines 264-270 sub marc2dcxml { Link Here
264
    my ( $marcxml, $record, $output );
264
    my ( $marcxml, $record, $output );
265
265
266
    # set the default path for intranet xslts
266
    # set the default path for intranet xslts
267
    # differents xslts to process (OAIDC, SRWDC and RDFDC)
267
    # FIXME CODESPELL (differents ==> different, difference) xslts to process (OAIDC, SRWDC and RDFDC)
268
    my $xsl =
268
    my $xsl =
269
          C4::Context->config('intrahtdocs')
269
          C4::Context->config('intrahtdocs')
270
        . '/prog/en/xslt/'
270
        . '/prog/en/xslt/'
(-)a/C4/Reports/Guided.pm (-4 / +4 lines)
Lines 305-311 sub _build_query { Link Here
305
        my @definitions = split( ',', $definition );
305
        my @definitions = split( ',', $definition );
306
        my $deftext;
306
        my $deftext;
307
        foreach my $def (@definitions) {
307
        foreach my $def (@definitions) {
308
            my $defin = get_from_dictionary( '', $def );
308
            my $define = get_from_dictionary( '', $def );
309
            $deftext .= " " . $defin->[0]->{'saved_sql'};
309
            $deftext .= " " . $defin->[0]->{'saved_sql'};
310
        }
310
        }
311
        if ( $query =~ /WHERE/i ) {
311
        if ( $query =~ /WHERE/i ) {
Lines 345-351 sub get_criteria { Link Here
345
    my ( $area, $cgi ) = @_;
345
    my ( $area, $cgi ) = @_;
346
    my $dbh = C4::Context->dbh();
346
    my $dbh = C4::Context->dbh();
347
347
348
    # have to do someting here to know if its dropdown, free text, date etc
348
    # have to do something here to know if its dropdown, free text, date etc
349
    my %criteria = (
349
    my %criteria = (
350
        CIRC => [
350
        CIRC => [
351
            'statistics.type', 'borrowers.categorycode', 'statistics.branch',
351
            'statistics.type', 'borrowers.categorycode', 'statistics.branch',
Lines 913-919 sub get_column_type { Link Here
913
913
914
=head2 get_distinct_values($column)
914
=head2 get_distinct_values($column)
915
915
916
Given a column name, return an arrary ref of hashrefs suitable for use as a tmpl_loop 
916
Given a column name, return an array ref of hashrefs suitable for use as a tmpl_loop
917
with the distinct values of the column
917
with the distinct values of the column
918
918
919
=cut
919
=cut
Lines 1032-1038 sub get_results { Link Here
1032
1032
1033
    my %reserved_authorised_values = GetReservedAuthorisedValues();
1033
    my %reserved_authorised_values = GetReservedAuthorisedValues();
1034
1034
1035
Returns a hash containig all reserved words
1035
Returns a hash containing all reserved words
1036
1036
1037
=cut
1037
=cut
1038
1038
(-)a/C4/Reserves.pm (-9 / +9 lines)
Lines 59-70 C4::Reserves - Koha functions for dealing with reservation. Link Here
59
59
60
=head1 DESCRIPTION
60
=head1 DESCRIPTION
61
61
62
This modules provides somes functions to deal with reservations.
62
This modules provides FIXME CODESPELL (somes ==> some, sums) functions to deal with reservations.
63
63
64
  Reserves are stored in reserves table.
64
  Reserves are stored in reserves table.
65
  The following columns contains important values :
65
  The following columns contains important values :
66
  - priority >0      : then the reserve is at 1st stage, and not yet affected to any item.
66
  - priority >0      : then the reserve is at 1st stage, and not yet affected to any item.
67
             =0      : then the reserve is being dealed
67
             =0      : then the reserve is being dealt
68
  - found : NULL         : means the patron requested the 1st available, and we haven't chosen the item
68
  - found : NULL         : means the patron requested the 1st available, and we haven't chosen the item
69
            T(ransit)    : the reserve is linked to an item but is in transit to the pickup branch
69
            T(ransit)    : the reserve is linked to an item but is in transit to the pickup branch
70
            W(aiting)    : the reserve is linked to an item, is at the pickup branch, and is waiting on the hold shelf
70
            W(aiting)    : the reserve is linked to an item, is at the pickup branch, and is waiting on the hold shelf
Lines 162-168 BEGIN { Link Here
162
162
163
Adds reserve and generates HOLDPLACED message and HOLDPLACED_PATRON message.
163
Adds reserve and generates HOLDPLACED message and HOLDPLACED_PATRON message.
164
164
165
The following tables are available witin the HOLDPLACED message:
165
The following tables are available within the HOLDPLACED message:
166
166
167
    branches
167
    branches
168
    borrowers
168
    borrowers
Lines 230-236 sub AddReserve { Link Here
230
230
231
    my $waitingdate;
231
    my $waitingdate;
232
232
233
    # If the reserv had the waiting status, we had the value of the resdate
233
    # If the reserve had the waiting status, we had the value of the resdate
234
    if ( $found && $found eq 'W' ) {
234
    if ( $found && $found eq 'W' ) {
235
        $waitingdate = $resdate;
235
        $waitingdate = $resdate;
236
    }
236
    }
Lines 891-899 sub CheckReserves { Link Here
891
            if ( $res->{'found'} && $res->{'found'} eq 'W' ) {
891
            if ( $res->{'found'} && $res->{'found'} eq 'W' ) {
892
                return ( "Waiting", $res, \@reserves );    # Found it, it is waiting
892
                return ( "Waiting", $res, \@reserves );    # Found it, it is waiting
893
            } elsif ( $res->{'found'} && $res->{'found'} eq 'P' ) {
893
            } elsif ( $res->{'found'} && $res->{'found'} eq 'P' ) {
894
                return ( "Processing", $res, \@reserves );    # Found determinated hold, e. g. the transferred one
894
                return ( "Processing", $res, \@reserves );    # Found determined hold, e. g. the transferred one
895
            } elsif ( $res->{'found'} && $res->{'found'} eq 'T' ) {
895
            } elsif ( $res->{'found'} && $res->{'found'} eq 'T' ) {
896
                return ( "Transferred", $res, \@reserves );    # Found determinated hold, e. g. the transferred one
896
                return ( "Transferred", $res, \@reserves );    # Found determined hold, e. g. the transferred one
897
            } else {
897
            } else {
898
                my $patron;
898
                my $patron;
899
                my $local_hold_match;
899
                my $local_hold_match;
Lines 1308-1314 Reduce the values of queued list Link Here
1308
sub ModReserveMinusPriority {
1308
sub ModReserveMinusPriority {
1309
    my ( $itemnumber, $reserve_id ) = @_;
1309
    my ( $itemnumber, $reserve_id ) = @_;
1310
1310
1311
    #first step update the value of the first person on reserv
1311
    #first step update the value of the first person on reserve
1312
    my $dbh   = C4::Context->dbh;
1312
    my $dbh   = C4::Context->dbh;
1313
    my $query = "
1313
    my $query = "
1314
        UPDATE reserves
1314
        UPDATE reserves
Lines 1627-1633 sub _FixPriority { Link Here
1627
    }
1627
    }
1628
    my @priority;
1628
    my @priority;
1629
1629
1630
    # get whats left
1630
    # get what's left
1631
    my $query = "
1631
    my $query = "
1632
        SELECT reserve_id, borrowernumber, reservedate
1632
        SELECT reserve_id, borrowernumber, reservedate
1633
        FROM   reserves
1633
        FROM   reserves
Lines 1802-1808 The letter code for this notice may be found using the following query: Link Here
1802
This will probably sipmly be 'HOLD', but because it is defined in the database,
1802
This will probably sipmly be 'HOLD', but because it is defined in the database,
1803
it is subject to addition or change.
1803
it is subject to addition or change.
1804
1804
1805
The following tables are availalbe witin the notice:
1805
The following tables are available within the notice:
1806
1806
1807
    branches
1807
    branches
1808
    borrowers
1808
    borrowers
(-)a/C4/RotatingCollections.pm (-1 / +1 lines)
Lines 2-8 package C4::RotatingCollections; Link Here
2
2
3
# $Id: RotatingCollections.pm,v 0.1 2007/04/20 kylemhall
3
# $Id: RotatingCollections.pm,v 0.1 2007/04/20 kylemhall
4
4
5
# This package is inteded to keep track of what library
5
# This package is intended to keep track of what library
6
# Items of a certain collection should be at.
6
# Items of a certain collection should be at.
7
7
8
# Copyright 2007 Kyle Hall
8
# Copyright 2007 Kyle Hall
(-)a/C4/SIP/ILS.pm (-1 / +1 lines)
Lines 131-137 sub offline_ok { Link Here
131
# Checkout(patron_id, item_id, sc_renew):
131
# Checkout(patron_id, item_id, sc_renew):
132
#    patron_id & item_id are the identifiers send by the terminal
132
#    patron_id & item_id are the identifiers send by the terminal
133
#    sc_renew is the renewal policy configured on the terminal
133
#    sc_renew is the renewal policy configured on the terminal
134
# returns a status opject that can be queried for the various bits
134
# returns a status object that can be queried for the various bits
135
# of information that the protocol (SIP or NCIP) needs to generate
135
# of information that the protocol (SIP or NCIP) needs to generate
136
# the response.
136
# the response.
137
137
(-)a/C4/SIP/SIPServer.pm (-6 / +6 lines)
Lines 55-67 my %transports = ( Link Here
55
# Read configuration
55
# Read configuration
56
#
56
#
57
my $config = C4::SIP::Sip::Configuration->new( $ARGV[0] );
57
my $config = C4::SIP::Sip::Configuration->new( $ARGV[0] );
58
my @parms;
58
my @FIXME CODESPELL (parms ==> params, prams);
59
59
60
#
60
#
61
# Ports to bind
61
# Ports to bind
62
#
62
#
63
foreach my $svc ( keys %{ $config->{listeners} } ) {
63
foreach my $svc ( keys %{ $config->{listeners} } ) {
64
    push @parms, "port=" . $svc;
64
    push @FIXME CODESPELL (parms ==> params, prams), "port=" . $svc;
65
}
65
}
66
66
67
#
67
#
Lines 81-97 foreach my $svc ( keys %{ $config->{listeners} } ) { Link Here
81
#
81
#
82
if ( defined( $config->{'server-params'} ) ) {
82
if ( defined( $config->{'server-params'} ) ) {
83
    while ( my ( $key, $val ) = each %{ $config->{'server-params'} } ) {
83
    while ( my ( $key, $val ) = each %{ $config->{'server-params'} } ) {
84
        push @parms, $key . '=' . $val;
84
        push @FIXME CODESPELL (parms ==> params, prams), $key . '=' . $val;
85
    }
85
    }
86
}
86
}
87
87
88
# Add user and group to prevent warn from Net::Server.
88
# Add user and group to prevent warn from Net::Server.
89
push @parms, 'user=' . $>;
89
push @FIXME CODESPELL (parms ==> params, prams), 'user=' . $>;
90
push @parms, 'group=' . $>;
90
push @FIXME CODESPELL (parms ==> params, prams), 'group=' . $>;
91
91
92
#
92
#
93
# This is the main event.
93
# This is the main event.
94
__PACKAGE__->run(@parms);
94
__PACKAGE__->run(@FIXME CODESPELL (parms ==> params, prams));
95
95
96
#
96
#
97
# Server
97
# Server
(-)a/C4/SMS.pm (-1 / +1 lines)
Lines 64-70 use File::Spec; Link Here
64
64
65
=cut
65
=cut
66
66
67
# The previous implmentation used username and password.
67
# The previous implementation used username and password.
68
# our $user = C4::Context->config('smsuser');
68
# our $user = C4::Context->config('smsuser');
69
# our $pwd  = C4::Context->config('smspass');
69
# our $pwd  = C4::Context->config('smspass');
70
70
(-)a/C4/Scheduler.pm (-1 / +1 lines)
Lines 108-114 sub add_at_job { Link Here
108
    #    not check all error conditions - in particular, it does
108
    #    not check all error conditions - in particular, it does
109
    #    not check the return value of the "at" run; it basically
109
    #    not check the return value of the "at" run; it basically
110
    #    complains only if it can't find at.
110
    #    complains only if it can't find at.
111
    # 3. Similary, Schedule::At::add() does not do something more useful,
111
    # 3. Similarly, Schedule::At::add() does not do something more useful,
112
    #    such as returning the job ID.  To be fair, it is possible
112
    #    such as returning the job ID.  To be fair, it is possible
113
    #    that 'at' does not allow this in any portable way.
113
    #    that 'at' does not allow this in any portable way.
114
    # 4. Although unlikely, it is possible that a job could be added
114
    # 4. Although unlikely, it is possible that a job could be added
(-)a/C4/Search.pm (-2 / +2 lines)
Lines 191-197 for my $r ( @{$marcresults} ) { Link Here
191
    my $marcrecord = MARC::File::USMARC::decode($r);
191
    my $marcrecord = MARC::File::USMARC::decode($r);
192
    my $biblio = TransformMarcToKoha({ record => $marcrecord });
192
    my $biblio = TransformMarcToKoha({ record => $marcrecord });
193
193
194
    #build the iarray of hashs for the template.
194
    #build the iarray of hashes for the template.
195
    push @results, {
195
    push @results, {
196
        title           => $biblio->{'title'},
196
        title           => $biblio->{'title'},
197
        subtitle        => $biblio->{'subtitle'},
197
        subtitle        => $biblio->{'subtitle'},
Lines 307-313 sub getRecords { Link Here
307
    my @results;
307
    my @results;
308
    my $results_hashref = ();
308
    my $results_hashref = ();
309
309
310
    # TODO simplify this structure ( { branchcode => $branchname } is enought) and remove this parameter
310
    # TODO simplify this structure ( { branchcode => $branchname } is enough) and remove this parameter
311
    $branches ||= { map { $_->branchcode => { branchname => $_->branchname } } Koha::Libraries->search->as_list };
311
    $branches ||= { map { $_->branchcode => { branchname => $_->branchname } } Koha::Libraries->search->as_list };
312
312
313
    # Initialize variables for the faceted results objects
313
    # Initialize variables for the faceted results objects
(-)a/C4/Serials.pm (-3 / +3 lines)
Lines 1719-1725 sub NewIssue { Link Here
1719
1719
1720
1 or 0 = HasSubscriptionStrictlyExpired($subscriptionid)
1720
1 or 0 = HasSubscriptionStrictlyExpired($subscriptionid)
1721
1721
1722
the subscription has stricly expired when today > the end subscription date 
1722
the subscription has strictly expired when today > the end subscription date
1723
1723
1724
return :
1724
return :
1725
1 if true, 0 if false, -1 if the expiration date is not set.
1725
1 if true, 0 if false, -1 if the expiration date is not set.
Lines 1744-1750 sub HasSubscriptionStrictlyExpired { Link Here
1744
        # Getting today's date
1744
        # Getting today's date
1745
        my ( $nowyear, $nowmonth, $nowday ) = Today();
1745
        my ( $nowyear, $nowmonth, $nowday ) = Today();
1746
1746
1747
        # if today's date > expiration date, then the subscription has stricly expired
1747
        # if today's date > expiration date, then the subscription has strictly expired
1748
        if ( Delta_Days( $nowyear, $nowmonth, $nowday, $endyear, $endmonth, $endday ) < 0 ) {
1748
        if ( Delta_Days( $nowyear, $nowmonth, $nowday, $endyear, $endmonth, $endday ) < 0 ) {
1749
            return 1;
1749
            return 1;
1750
        } else {
1750
        } else {
Lines 2486-2492 this function it takes the publisheddate and will return the next issue's date Link Here
2486
and will skip dates if there exists an irregularity.
2486
and will skip dates if there exists an irregularity.
2487
$publisheddate has to be an ISO date
2487
$publisheddate has to be an ISO date
2488
$subscription is a hashref containing at least 'firstacquidate', 'irregularity', and 'countissuesperunit'
2488
$subscription is a hashref containing at least 'firstacquidate', 'irregularity', and 'countissuesperunit'
2489
$frequency is a hashref containing frequency informations
2489
$frequency is a hashref containing frequency information
2490
$updatecount is a boolean value which, when set to true, update the 'countissuesperunit' in database
2490
$updatecount is a boolean value which, when set to true, update the 'countissuesperunit' in database
2491
- eg if periodicity is monthly and $publisheddate is 2007-02-10 but if March and April is to be
2491
- eg if periodicity is monthly and $publisheddate is 2007-02-10 but if March and April is to be
2492
skipped then the returned date will be 2007-05-10
2492
skipped then the returned date will be 2007-05-10
(-)a/C4/Suggestions.pm (-4 / +4 lines)
Lines 122-131 sub GetSuggestionFromBiblionumber { Link Here
122
122
123
=head2 GetSuggestionInfoFromBiblionumber
123
=head2 GetSuggestionInfoFromBiblionumber
124
124
125
Get a suggestion and borrower's informations from it's biblionumber.
125
Get a suggestion and borrower's information from it's biblionumber.
126
126
127
return :
127
return :
128
all informations (suggestion and borrower) of the suggestion which is related to the biblionumber given.
128
all information (suggestion and borrower) of the suggestion which is related to the biblionumber given.
129
129
130
=cut
130
=cut
131
131
Lines 149-158 sub GetSuggestionInfoFromBiblionumber { Link Here
149
149
150
=head2 GetSuggestionInfo
150
=head2 GetSuggestionInfo
151
151
152
Get a suggestion and borrower's informations from it's suggestionid
152
Get a suggestion and borrower's information from it's suggestionid
153
153
154
return :
154
return :
155
all informations (suggestion and borrower) of the suggestion which is related to the suggestionid given.
155
all information (suggestion and borrower) of the suggestion which is related to the suggestionid given.
156
156
157
=cut
157
=cut
158
158
(-)a/C4/TTParser.pm (-1 / +1 lines)
Lines 15-21 Link Here
15
# You should have received a copy of the GNU General Public License
15
# You should have received a copy of the GNU General Public License
16
# along with Koha; if not, see <http://www.gnu.org/licenses>.
16
# along with Koha; if not, see <http://www.gnu.org/licenses>.
17
17
18
#simple parser for HTML with Template Toolkit directives. Tokens are put into @tokens and are accesible via next_token and peep_token
18
#simple parser for HTML with Template Toolkit directives. Tokens are put into @tokens and are accessible via next_token and peep_token
19
package C4::TTParser;
19
package C4::TTParser;
20
use base qw(HTML::Parser);
20
use base qw(HTML::Parser);
21
use C4::TmplToken;
21
use C4::TmplToken;
(-)a/C4/UsageStats.pm (-3 / +3 lines)
Lines 32-39 C4::UsageStats Link Here
32
=head1 DESCRIPTION
32
=head1 DESCRIPTION
33
33
34
This package contains what is needed to report Koha statistics to hea
34
This package contains what is needed to report Koha statistics to hea
35
hea.koha-community.org is the server that centralize Koha setups informations
35
hea.koha-community.org is the server that centralize Koha setups information
36
Koha libraries are encouraged to provide informations about their collections,
36
Koha libraries are encouraged to provide information about their collections,
37
their structure,...
37
their structure,...
38
38
39
=cut
39
=cut
Lines 85-91 sub BuildReport { Link Here
85
85
86
  ReportToCommunity;
86
  ReportToCommunity;
87
87
88
Send to hea.koha-community.org database informations
88
Send to hea.koha-community.org database information
89
89
90
=cut
90
=cut
91
91
(-)a/Koha/Biblio.pm (-3 / +3 lines)
Lines 520-526 sub pickup_locations { Link Here
520
520
521
    my $bool = $biblio->hidden_in_opac({ [ rules => $rules ] })
521
    my $bool = $biblio->hidden_in_opac({ [ rules => $rules ] })
522
522
523
Returns true if the biblio matches the hidding criteria defined in $rules.
523
Returns true if the biblio matches the FIXME CODESPELL (hidding ==> hiding, hidden) criteria defined in $rules.
524
Returns false otherwise. It involves the I<OpacHiddenItems> and
524
Returns false otherwise. It involves the I<OpacHiddenItems> and
525
I<OpacHiddenItemsHidesRecord> system preferences.
525
I<OpacHiddenItemsHidesRecord> system preferences.
526
526
Lines 1261-1267 sub get_coins { Link Here
1261
        [ 'rft.issn', $issn ],
1261
        [ 'rft.issn', $issn ],
1262
    );
1262
    );
1263
1263
1264
    # If it's a subscription, these informations have no meaning.
1264
    # If it's a subscription, these information have no meaning.
1265
    if ( $genre ne 'journal' ) {
1265
    if ( $genre ne 'journal' ) {
1266
        push @params, (
1266
        push @params, (
1267
            [ 'rft.aulast',  $aulast ],
1267
            [ 'rft.aulast',  $aulast ],
Lines 1332-1338 sub is_serial { Link Here
1332
my $image_url = $biblio->custom_cover_image_url
1332
my $image_url = $biblio->custom_cover_image_url
1333
1333
1334
Return the specific url of the cover image for this bibliographic record.
1334
Return the specific url of the cover image for this bibliographic record.
1335
It is built regaring the value of the system preference CustomCoverImagesURL
1335
It is built regarding the value of the system preference CustomCoverImagesURL
1336
1336
1337
=cut
1337
=cut
1338
1338
(-)a/Koha/Cash/Register/Cashup.pm (-1 / +1 lines)
Lines 189-195 sub summary { Link Here
189
189
190
=head3 to_api_mapping
190
=head3 to_api_mapping
191
191
192
This method returns the mapping for representing a Koha::Cash::Regiser::Cashup object
192
This method returns the mapping for representing a Koha::Cash::Register::Cashup object
193
on the API.
193
on the API.
194
194
195
=cut
195
=cut
(-)a/Koha/ClassSplitRule.pm (-1 / +1 lines)
Lines 25-31 use base qw(Koha::Object); Link Here
25
25
26
=head1 NAME
26
=head1 NAME
27
27
28
Koha::ClassSplitRule Koha Classfication Spliting Rule Object class
28
Koha::ClassSplitRule Koha Classfication Splitting Rule Object class
29
29
30
=head1 API
30
=head1 API
31
31
(-)a/Koha/Club/Template/EnrollmentFields.pm (-1 / +1 lines)
Lines 29-35 use base qw(Koha::Objects); Link Here
29
29
30
Koha::Club::Template::EnrollemntFields
30
Koha::Club::Template::EnrollemntFields
31
31
32
Represents a colleciton of club fields that are only set at the time a patron is enrolled
32
Represents a collection of club fields that are only set at the time a patron is enrolled
33
33
34
=head1 API
34
=head1 API
35
35
(-)a/Koha/EDI.pm (-3 / +3 lines)
Lines 1197-1203 sub _get_budget { Link Here
1197
        }
1197
        }
1198
    );
1198
    );
1199
1199
1200
    # db does not ensure budget code is unque
1200
    # db does not ensure budget code is unique
1201
    return $schema->resultset('Aqbudget')->single(
1201
    return $schema->resultset('Aqbudget')->single(
1202
        {
1202
        {
1203
            budget_code      => $budget_code,
1203
            budget_code      => $budget_code,
Lines 1340-1346 Koha::EDI Link Here
1340
1340
1341
    passed a message object for an invoice, add the contained invoices
1341
    passed a message object for an invoice, add the contained invoices
1342
    and update the orderlines referred to in the invoice
1342
    and update the orderlines referred to in the invoice
1343
    As an Edifact invoice is in effect a despatch note this receipts the
1343
    As an Edifact invoice is in effect a dispatch note this receipts the
1344
    appropriate quantities in the orders
1344
    appropriate quantities in the orders
1345
1345
1346
    no meaningful return value
1346
    no meaningful return value
Lines 1409-1415 Koha::EDI Link Here
1409
1409
1410
      classmark = title_level_class(edi_item)
1410
      classmark = title_level_class(edi_item)
1411
1411
1412
      Trys to return a title level classmark from a quote message line
1412
      Tries to return a title level classmark from a quote message line
1413
      Will return a dewey or lcc classmark if one exists according to the
1413
      Will return a dewey or lcc classmark if one exists according to the
1414
      value in DefaultClassificationSource syspref
1414
      value in DefaultClassificationSource syspref
1415
1415
(-)a/Koha/Edifact.pm (-1 / +1 lines)
Lines 280-286 Edifact - Edifact message handler Link Here
280
280
281
=head2 get_transmission
281
=head2 get_transmission
282
282
283
     This method is useful in debugg:ing. Call on an Edifact object
283
     This method is useful in debug:ing. Call on an Edifact object
284
     it returns the object's transmission member
284
     it returns the object's transmission member
285
285
286
=head2 message_type
286
=head2 message_type
(-)a/Koha/Edifact/Line.pm (-2 / +2 lines)
Lines 438-444 sub coded_substitute_text { Link Here
438
}
438
}
439
439
440
# This will take a standard code as returned
440
# This will take a standard code as returned
441
# by (orderline|substitue)-free_text (FTX seg LIN)
441
# by (orderline|substitute)-free_text (FTX seg LIN)
442
# and expand it using EditEUR code list 8B
442
# and expand it using EditEUR code list 8B
443
443
444
sub translate_8B {
444
sub translate_8B {
Lines 778-784 sub pri_price { Link Here
778
    return;
778
    return;
779
}
779
}
780
780
781
# unit price that will be chaged excl tax
781
# unit price that will be FIXME CODESPELL (chaged ==> changed, charged) excl tax
782
782
783
sub price_net {
783
sub price_net {
784
    my $self = shift;
784
    my $self = shift;
(-)a/Koha/Edifact/Order.pm (-5 / +5 lines)
Lines 226-232 sub message_reference { Link Here
226
    my ( $self, $function ) = @_;
226
    my ( $self, $function ) = @_;
227
    if ( $function eq 'new' || !$self->{message_reference_no} ) {
227
    if ( $function eq 'new' || !$self->{message_reference_no} ) {
228
228
229
        # unique 14 char mesage ref
229
        # unique 14 char message ref
230
        $self->{message_reference_no} = sprintf 'ME%012d', int rand($NINES_12);
230
        $self->{message_reference_no} = sprintf 'ME%012d', int rand($NINES_12);
231
    }
231
    }
232
    return $self->{message_reference_no};
232
    return $self->{message_reference_no};
Lines 776-782 Make handling of GIR segments more customizable Link Here
776
    pass the string 'new'.
776
    pass the string 'new'.
777
    In practice we encode 1 message per transmission so there is only one message
777
    In practice we encode 1 message per transmission so there is only one message
778
    referenced. were we to encode multiple messages a new reference would be
778
    referenced. were we to encode multiple messages a new reference would be
779
    neaded for each
779
    FIXME CODESPELL (neaded ==> needed, kneaded, headed) for each
780
780
781
=head2 message_header
781
=head2 message_header
782
782
Lines 784-790 Make handling of GIR segments more customizable Link Here
784
784
785
=head2 interchange_trailer
785
=head2 interchange_trailer
786
786
787
    returns the UNZ segment which ends the tranmission encoding the
787
    returns the UNZ segment which ends the transmission encoding the
788
    message count and control reference for the interchange
788
    message count and control reference for the interchange
789
789
790
=head2 order_msg_header
790
=head2 order_msg_header
Lines 801-807 Make handling of GIR segments more customizable Link Here
801
                Id
801
                Id
802
                Agency
802
                Agency
803
803
804
    Returns a NAD segment containg the id and agency for for the Function
804
    Returns a NAD segment containing the id and agency for for the Function
805
    value. Handles the fact that NAD segments encode the value for 'EAN' differently
805
    value. Handles the fact that NAD segments encode the value for 'EAN' differently
806
    to elsewhere.
806
    to elsewhere.
807
807
Lines 854-860 Make handling of GIR segments more customizable Link Here
854
854
855
=head2 _interchange_sr_identifier
855
=head2 _interchange_sr_identifier
856
856
857
    Format sender and receipient identifiers for use in the interchange header
857
    Format sender and recipient identifiers for use in the interchange header
858
858
859
=head2 encode_text
859
=head2 encode_text
860
860
(-)a/Koha/Filter/MARC/ViewPolicy.pm (-1 / +1 lines)
Lines 232-238 nothing is passed. Valid values include 'opac' or 'intranet'. Link Here
232
=cut
232
=cut
233
233
234
sub should_hide_marc {
234
sub should_hide_marc {
235
    my ( $self, $parms ) = @_;
235
    my ( $self, $FIXME CODESPELL (parms ==> params, prams) ) = @_;
236
    my $frameworkcode = $parms->{frameworkcode} // q{};
236
    my $frameworkcode = $parms->{frameworkcode} // q{};
237
    my $interface     = $parms->{interface}     // 'opac';
237
    my $interface     = $parms->{interface}     // 'opac';
238
    my $hide          = _should_hide_on_interface();
238
    my $hide          = _should_hide_on_interface();
(-)a/Koha/FrameworkPlugin.pm (-1 / +1 lines)
Lines 182-188 sub build { Link Here
182
=head2 launch
182
=head2 launch
183
183
184
    Launches the popup for this plugin by calling its launcher sub
184
    Launches the popup for this plugin by calling its launcher sub
185
    Old style plugins still expect to receive a CGI oject, new style
185
    Old style plugins still expect to receive a CGI object, new style
186
    plugins expect a params hashref.
186
    plugins expect a params hashref.
187
    Returns undef on failure, otherwise launcher return value (if any).
187
    Returns undef on failure, otherwise launcher return value (if any).
188
188
(-)a/Koha/ILL/Backend.pm (-1 / +1 lines)
Lines 54-60 sub existing_statuses { Link Here
54
    # We need the 'status' field for obvious reasons, the 'backend' field is required to not
54
    # We need the 'status' field for obvious reasons, the 'backend' field is required to not
55
    # throw 'Koha::Exceptions::Ill::InvalidBackendId' when we're converting to a Koha object.
55
    # throw 'Koha::Exceptions::Ill::InvalidBackendId' when we're converting to a Koha object.
56
    # Finally, to get around 'ONLY_FULL_GROUP_BY', we have to be explicit about which
56
    # Finally, to get around 'ONLY_FULL_GROUP_BY', we have to be explicit about which
57
    # 'request_id' we want to return, hense the 'MAX' call.
57
    # 'request_id' we want to return, hence the 'MAX' call.
58
    my $ill_requests = Koha::ILL::Requests->search(
58
    my $ill_requests = Koha::ILL::Requests->search(
59
        { backend => $backend_id },
59
        { backend => $backend_id },
60
        {
60
        {
(-)a/Koha/Item.pm (-1 / +1 lines)
Lines 935-941 sub can_article_request { Link Here
935
935
936
my $bool = $item->hidden_in_opac({ [ rules => $rules ] })
936
my $bool = $item->hidden_in_opac({ [ rules => $rules ] })
937
937
938
Returns true if item fields match the hidding criteria defined in $rules.
938
Returns true if item fields match the FIXME CODESPELL (hidding ==> hiding, hidden) criteria defined in $rules.
939
Returns false otherwise.
939
Returns false otherwise.
940
940
941
Takes HASHref that can have the following parameters:
941
Takes HASHref that can have the following parameters:
(-)a/Koha/Misc/Files.pm (-3 / +3 lines)
Lines 52-58 from this table. However, this method does accept an arbitrary Link Here
52
string as 'tabletag', and an arbitrary integer as 'recordid'.
52
string as 'tabletag', and an arbitrary integer as 'recordid'.
53
53
54
Particular Koha::Misc::Files object can have one or more file records
54
Particular Koha::Misc::Files object can have one or more file records
55
(actuall file contents + various file metadata) associated with it.
55
(FIXME CODESPELL (actuall ==> actually, actual) file contents + various file metadata) associated with it.
56
56
57
In case of an error (wrong parameter format) it returns undef.
57
In case of an error (wrong parameter format) it returns undef.
58
58
Lines 150-156 my $file = $mf->GetFile( id => $file_id ); Link Here
150
For an individual, specific file ID this method returns a hashref
150
For an individual, specific file ID this method returns a hashref
151
containing all metadata (file_id, table_tag, record_id, file_name,
151
containing all metadata (file_id, table_tag, record_id, file_name,
152
file_type, file_description, file_content, date_uploaded), plus
152
file_type, file_description, file_content, date_uploaded), plus
153
an actuall contents of a file (in 'file_content'). In typical usage
153
an FIXME CODESPELL (actuall ==> actually, actual) contents of a file (in 'file_content'). In typical usage
154
scenarios, for a given $mf object, specific file IDs have to be
154
scenarios, for a given $mf object, specific file IDs have to be
155
obtained first by GetFilesInfo() call.
155
obtained first by GetFilesInfo() call.
156
156
Lines 218-224 sub DelAllFiles { Link Here
218
218
219
$mf->MergeFileRecIds(@ids_to_be_merged);
219
$mf->MergeFileRecIds(@ids_to_be_merged);
220
220
221
This method re-associates all individuall file records associated with
221
This method re-associates all FIXME CODESPELL (individuall ==> individually, individual) file records associated with
222
some "parent" records IDs (provided in @ids_to_be_merged) with the given
222
some "parent" records IDs (provided in @ids_to_be_merged) with the given
223
single $mf object (which would be treated as a "parent" destination).
223
single $mf object (which would be treated as a "parent" destination).
224
224
(-)a/Koha/OAI/Server/Repository.pm (-1 / +1 lines)
Lines 65-71 preferences (OAI-PMH:archiveID and OAI-PMH:MaxCount) and the server returns Link Here
65
records in marcxml or dublin core format. Dublin core records are created from
65
records in marcxml or dublin core format. Dublin core records are created from
66
koha marcxml records transformed with XSLT. Used XSL file is located in koha-
66
koha marcxml records transformed with XSLT. Used XSL file is located in koha-
67
tmpl/intranet-tmpl/prog/en/xslt directory and chosen based on marcflavour,
67
tmpl/intranet-tmpl/prog/en/xslt directory and chosen based on marcflavour,
68
respecively MARC21slim2OAIDC.xsl for MARC21 and  MARC21slim2OAIDC.xsl for
68
respectively MARC21slim2OAIDC.xsl for MARC21 and  MARC21slim2OAIDC.xsl for
69
UNIMARC.
69
UNIMARC.
70
70
71
In extended mode, it's possible to parameter other format than marcxml or
71
In extended mode, it's possible to parameter other format than marcxml or
(-)a/Koha/Patron/Password/Recovery.pm (-1 / +1 lines)
Lines 52-58 use Koha::Patron::Password::Recovery; Link Here
52
52
53
=head2 ValidateBorrowernumber
53
=head2 ValidateBorrowernumber
54
54
55
$alread = ValidateBorrowernumber( $borrower_number );
55
$already = ValidateBorrowernumber( $borrower_number );
56
56
57
Check if the system already start recovery
57
Check if the system already start recovery
58
58
(-)a/Koha/Patrons/Import.pm (-2 / +2 lines)
Lines 768-776 sub format_dates { Link Here
768
    my ( $self, $params ) = @_;
768
    my ( $self, $params ) = @_;
769
769
770
    foreach my $date_type (qw(dateofbirth dateenrolled dateexpiry date_renewed)) {
770
    foreach my $date_type (qw(dateofbirth dateenrolled dateexpiry date_renewed)) {
771
        my $tempdate = $params->{borrower}->{$date_type} or next();
771
        my $template = $params->{borrower}->{$date_type} or next();
772
        my $formatted_date =
772
        my $formatted_date =
773
            eval { output_pref( { dt => dt_from_string($tempdate), dateonly => 1, dateformat => 'iso' } ); };
773
            eval { output_pref( { dt => dt_from_string($template), dateonly => 1, dateformat => 'iso' } ); };
774
774
775
        if ($formatted_date) {
775
        if ($formatted_date) {
776
            $params->{borrower}->{$date_type} = $formatted_date;
776
            $params->{borrower}->{$date_type} = $formatted_date;
(-)a/Koha/Plugins/Base.pm (-3 / +3 lines)
Lines 156-162 Then name of the plugin method used. For example 'tool' or 'report'. Link Here
156
=item B<PLUGIN_PATH>
156
=item B<PLUGIN_PATH>
157
157
158
The URL path to the plugin. It can be used in templates in order to localize
158
The URL path to the plugin. It can be used in templates in order to localize
159
ressources like images in html tags, or other templates.
159
resources like images in html tags, or other templates.
160
160
161
=item B<PLUGIN_DIR>
161
=item B<PLUGIN_DIR>
162
162
Lines 344-350 sub _version_compare { Link Here
344
        push( @v1, 0 ) unless defined( $v1[$i] );
344
        push( @v1, 0 ) unless defined( $v1[$i] );
345
        push( @v2, 0 ) unless defined( $v2[$i] );
345
        push( @v2, 0 ) unless defined( $v2[$i] );
346
346
347
        # Strip letters before comparing, supresses 'Argument "v1" isn't numeric in int' warning
347
        # Strip letters before comparing, suppresses 'Argument "v1" isn't numeric in int' warning
348
        $v1[$i] =~ s/^v//g;
348
        $v1[$i] =~ s/^v//g;
349
        $v2[$i] =~ s/^v//g;
349
        $v2[$i] =~ s/^v//g;
350
350
Lines 359-365 sub _version_compare { Link Here
359
359
360
=head2 is_enabled
360
=head2 is_enabled
361
361
362
Method that returns wether the plugin is enabled or not
362
Method that returns FIXME CODESPELL (wether ==> weather, whether) the plugin is enabled or not
363
363
364
$plugin->enable
364
$plugin->enable
365
365
(-)a/Koha/REST/Plugin/Exceptions.pm (-1 / +1 lines)
Lines 43-49 Koha::REST::Plugin::Exceptions Link Here
43
    }
43
    }
44
44
45
Provides a generic and reusable way to throw unhandled exceptions. This way we
45
Provides a generic and reusable way to throw unhandled exceptions. This way we
46
can centralize the behaviour control (e.g. production vs. development environmet)
46
can centralize the behaviour control (e.g. production vs. development environment)
47
47
48
=cut
48
=cut
49
49
(-)a/Koha/REST/V1/Static.pm (-2 / +2 lines)
Lines 38-51 sub get { Link Here
38
    if ( C4::Context->config("enable_plugins") ) {
38
    if ( C4::Context->config("enable_plugins") ) {
39
        my $path = $c->req->url->path->leading_slash(1);
39
        my $path = $c->req->url->path->leading_slash(1);
40
40
41
        return $c->render( status => 400, openapi => { error => 'Endpoint inteded for plugin static files' } )
41
        return $c->render( status => 400, openapi => { error => 'Endpoint intended for plugin static files' } )
42
            unless "$path" =~ /^\/api\/v1\/contrib/;
42
            unless "$path" =~ /^\/api\/v1\/contrib/;
43
43
44
        my $namespace = $path->[3];
44
        my $namespace = $path->[3];
45
45
46
        my $checkpath = '/api/v1/contrib/' . $namespace . '/static';
46
        my $checkpath = '/api/v1/contrib/' . $namespace . '/static';
47
47
48
        return $c->render( status => 400, openapi => { error => 'Endpoint inteded for plugin static files' } )
48
        return $c->render( status => 400, openapi => { error => 'Endpoint intended for plugin static files' } )
49
            unless "$path" =~ /\Q$checkpath/;
49
            unless "$path" =~ /\Q$checkpath/;
50
50
51
        my @plugins = Koha::Plugins->new()->GetPlugins(
51
        my @plugins = Koha::Plugins->new()->GetPlugins(
(-)a/Koha/RecordProcessor.pm (-1 / +1 lines)
Lines 37-43 B<filter ($record)> - apply the filter and return the result. $record Link Here
37
may be either a scalar or an arrayref, and the return result will be
37
may be either a scalar or an arrayref, and the return result will be
38
the same type.
38
the same type.
39
39
40
These methods may be overriden:
40
These methods may be overridden:
41
41
42
B<initialize (%params)> - initialize the filter
42
B<initialize (%params)> - initialize the filter
43
43
(-)a/Koha/RecordProcessor/Base.pm (-2 / +2 lines)
Lines 38-44 The following variables must be defined in each filter: Link Here
38
  our $NAME ='Filter';
38
  our $NAME ='Filter';
39
  our $VERSION = '1.0';
39
  our $VERSION = '1.0';
40
40
41
These methods may be overriden:
41
These methods may be overridden:
42
42
43
B<initialize (%params)> - initialize the filter
43
B<initialize (%params)> - initialize the filter
44
44
Lines 87-93 sub new { Link Here
87
87
88
=head2 initialize
88
=head2 initialize
89
89
90
    $filter->initalize(%params);
90
    $filter->initialize(%params);
91
91
92
Initialize a filter using the specified parameters.
92
Initialize a filter using the specified parameters.
93
93
(-)a/Koha/Schema/Result/Borrower.pm (-3 / +3 lines)
Lines 184-190 the fax number for your patron/borrower's primary address Link Here
184
  data_type: 'mediumtext'
184
  data_type: 'mediumtext'
185
  is_nullable: 1
185
  is_nullable: 1
186
186
187
the secondary email addres for your patron/borrower's primary address
187
the secondary email address for your patron/borrower's primary addresss
188
188
189
=head2 phonepro
189
=head2 phonepro
190
190
Lines 368-374 comment on the stop of the patron Link Here
368
  data_type: 'longtext'
368
  data_type: 'longtext'
369
  is_nullable: 1
369
  is_nullable: 1
370
370
371
used for children and profesionals to include surname or last name of guarantor or organization name
371
used for children and professionals to include surname or last name of guarantor or organization name
372
372
373
=head2 contactfirstname
373
=head2 contactfirstname
374
374
Lines 621-627 lang to use to send notices to this patron Link Here
621
  default_value: 0
621
  default_value: 0
622
  is_nullable: 0
622
  is_nullable: 0
623
623
624
number of failed login attemps
624
number of failed login attempts
625
625
626
=head2 overdrive_auth_token
626
=head2 overdrive_auth_token
627
627
(-)a/Koha/Schema/Result/ClubHold.pm (-1 / +1 lines)
Lines 51-57 id for the bibliographic record the hold has been placed against Link Here
51
  is_foreign_key: 1
51
  is_foreign_key: 1
52
  is_nullable: 1
52
  is_nullable: 1
53
53
54
If item-level, the id for the item the hold has been placed agains
54
If item-level, the id for the item the hold has been placed FIXME CODESPELL (agains ==> against, again)
55
55
56
=head2 date_created
56
=head2 date_created
57
57
(-)a/Koha/Schema/Result/Deletedbiblio.pm (-1 / +1 lines)
Lines 38-44 unique identifier assigned to each bibliographic record Link Here
38
  is_nullable: 0
38
  is_nullable: 0
39
  size: 4
39
  size: 4
40
40
41
foriegn key from the biblio_framework table to identify which framework was used in cataloging this record
41
foreign key from the biblio_framework table to identify which framework was used in cataloging this record
42
42
43
=head2 author
43
=head2 author
44
44
(-)a/Koha/Schema/Result/Deletedborrower.pm (-3 / +3 lines)
Lines 184-190 the fax number for your patron/borrower's primary address Link Here
184
  data_type: 'mediumtext'
184
  data_type: 'mediumtext'
185
  is_nullable: 1
185
  is_nullable: 1
186
186
187
the secondary email addres for your patron/borrower's primary address
187
the secondary email address for your patron/borrower's primary addresss
188
188
189
=head2 phonepro
189
=head2 phonepro
190
190
Lines 366-372 comment on the stop of patron Link Here
366
  data_type: 'longtext'
366
  data_type: 'longtext'
367
  is_nullable: 1
367
  is_nullable: 1
368
368
369
used for children and profesionals to include surname or last name of guarantor or organization name
369
used for children and professionals to include surname or last name of guarantor or organization name
370
370
371
=head2 contactfirstname
371
=head2 contactfirstname
372
372
Lines 618-624 lang to use to send notices to this patron Link Here
618
  default_value: 0
618
  default_value: 0
619
  is_nullable: 0
619
  is_nullable: 0
620
620
621
number of failed login attemps
621
number of failed login attempts
622
622
623
=head2 overdrive_auth_token
623
=head2 overdrive_auth_token
624
624
(-)a/Koha/Schema/Result/Deleteditem.pm (-1 / +1 lines)
Lines 383-389 inventory number (MARC21 952$i) Link Here
383
  is_nullable: 1
383
  is_nullable: 1
384
  size: 32
384
  size: 32
385
385
386
'new' value, you can put whatever free-text information. This field is intented to be managed by the automatic_item_modification_by_age cronjob.
386
'new' value, you can put whatever free-text information. This field is FIXME CODESPELL (intented ==> intended, indented) to be managed by the automatic_item_modification_by_age cronjob.
387
387
388
=head2 exclude_from_local_holds_priority
388
=head2 exclude_from_local_holds_priority
389
389
(-)a/Koha/Schema/Result/HouseboundProfile.pm (-1 / +1 lines)
Lines 43-49 The preferred day of the week for delivery. Link Here
43
  data_type: 'mediumtext'
43
  data_type: 'mediumtext'
44
  is_nullable: 0
44
  is_nullable: 0
45
45
46
The Authorised_Value definining the pattern for delivery.
46
The Authorised_Value defining the pattern for delivery.
47
47
48
=head2 fav_itemtypes
48
=head2 fav_itemtypes
49
49
(-)a/Koha/Schema/Result/Item.pm (-1 / +1 lines)
Lines 387-393 inventory number (MARC21 952$i) Link Here
387
  is_nullable: 1
387
  is_nullable: 1
388
  size: 32
388
  size: 32
389
389
390
'new' value, you can put whatever free-text information. This field is intented to be managed by the automatic_item_modification_by_age cronjob.
390
'new' value, you can put whatever free-text information. This field is FIXME CODESPELL (intented ==> intended, indented) to be managed by the automatic_item_modification_by_age cronjob.
391
391
392
=head2 exclude_from_local_holds_priority
392
=head2 exclude_from_local_holds_priority
393
393
(-)a/Koha/Schema/Result/LibraryGroup.pm (-1 / +1 lines)
Lines 54-60 The branchcode of a branch belonging to the parent group Link Here
54
  is_nullable: 1
54
  is_nullable: 1
55
  size: 100
55
  size: 100
56
56
57
Short description of the goup
57
Short description of the group
58
58
59
=head2 description
59
=head2 description
60
60
(-)a/Koha/Schema/Result/Stockrotationstage.pm (-1 / +1 lines)
Lines 61-67 Branch this stage relates to Link Here
61
  default_value: 4
61
  default_value: 4
62
  is_nullable: 0
62
  is_nullable: 0
63
63
64
The number of days items shoud occupy this stage
64
The number of days items should occupy this stage
65
65
66
=cut
66
=cut
67
67
(-)a/Koha/Schema/Result/Virtualshelfshare.pm (-1 / +1 lines)
Lines 53-59 borrower that accepted access to this list Link Here
53
  is_nullable: 1
53
  is_nullable: 1
54
  size: 10
54
  size: 10
55
55
56
temporary string used in accepting the invitation to access thist list; not-empty means that the invitation has not been accepted yet
56
temporary string used in accepting the invitation to access this list; not-empty means that the invitation has not been accepted yet
57
57
58
=head2 sharedate
58
=head2 sharedate
59
59
(-)a/Koha/SearchEngine/Elasticsearch.pm (-1 / +1 lines)
Lines 1209-1215 each call to C<MARC::Record>->field) we create an optimized structure of mapping Link Here
1209
rules keyed by MARC field tags holding all the mapping rules for that particular tag.
1209
rules keyed by MARC field tags holding all the mapping rules for that particular tag.
1210
1210
1211
We can then iterate through all MARC fields for each record and apply all relevant
1211
We can then iterate through all MARC fields for each record and apply all relevant
1212
rules once per fields instead of retreiving fields multiple times for each mapping rule
1212
rules once per fields instead of retrieving fields multiple times for each mapping rule
1213
which is terribly slow.
1213
which is terribly slow.
1214
1214
1215
=cut
1215
=cut
(-)a/Koha/SearchEngine/Elasticsearch/Indexer.pm (-1 / +1 lines)
Lines 255-261 sub index_status { Link Here
255
Generate Elasticsearch mappings from mappings stored in database and
255
Generate Elasticsearch mappings from mappings stored in database and
256
perform a request to update Elasticsearch index mappings. Will throw an
256
perform a request to update Elasticsearch index mappings. Will throw an
257
error and set index status to C<INDEX_STATUS_RECREATE_REQUIRED> if update
257
error and set index status to C<INDEX_STATUS_RECREATE_REQUIRED> if update
258
failes.
258
fails.
259
259
260
=cut
260
=cut
261
261
(-)a/Koha/SuggestionEngine.pm (-1 / +1 lines)
Lines 36-42 namespace, and provide the following methods: Link Here
36
B<get_suggestions ($search)> - get suggestions from the plugin for the
36
B<get_suggestions ($search)> - get suggestions from the plugin for the
37
specified search.
37
specified search.
38
38
39
These methods may be overriden:
39
These methods may be overridden:
40
40
41
B<initialize (%params)> - initialize the plugin
41
B<initialize (%params)> - initialize the plugin
42
42
(-)a/Koha/SuggestionEngine/Base.pm (-2 / +2 lines)
Lines 38-44 B<NAME> - return a string with the name of the plugin. Link Here
38
38
39
B<VERSION> - return a string with the version of the plugin.
39
B<VERSION> - return a string with the version of the plugin.
40
40
41
These methods may be overriden:
41
These methods may be overridden:
42
42
43
B<initialize (%params)> - initialize the plugin
43
B<initialize (%params)> - initialize the plugin
44
44
Lines 81-87 sub new { Link Here
81
81
82
=head2 initialize
82
=head2 initialize
83
83
84
    $plugin->initalize(%params);
84
    $plugin->initialize(%params);
85
85
86
Initialize a filter using the specified parameters.
86
Initialize a filter using the specified parameters.
87
87
(-)a/Koha/Template/Plugin/Asset.pm (-1 / +1 lines)
Lines 25-31 Koha::Template::Plugin::Asset Link Here
25
25
26
The Asset plugin is a helper that generates HTML tags for JS and CSS files
26
The Asset plugin is a helper that generates HTML tags for JS and CSS files
27
27
28
=head1 SYNOPSYS
28
=head1 SYNOPSIS
29
29
30
    [% USE Asset %]
30
    [% USE Asset %]
31
31
(-)a/Koha/Template/Plugin/TablesSettings.pm (-1 / +1 lines)
Lines 21-27 package Koha::Template::Plugin::TablesSettings; Link Here
21
21
22
Koha::Template::Plugin::TablesSettings
22
Koha::Template::Plugin::TablesSettings
23
23
24
=head2 SYNOPSYS
24
=head2 SYNOPSIS
25
25
26
    [% USE TablesSettings %]
26
    [% USE TablesSettings %]
27
27
(-)a/Koha/pdfformat/layout2pages.pm (-2 / +2 lines)
Lines 36-43 BEGIN { Link Here
36
    @EXPORT = qw(printpdf);
36
    @EXPORT = qw(printpdf);
37
}
37
}
38
38
39
#be careful, all the sizes (height, width, etc...) are in mm, not PostScript points (the default measurment of PDF::API2).
39
#be careful, all the sizes (height, width, etc...) are in mm, not PostScript points (the default measurement of PDF::API2).
40
#The constants exported transform that into PostScript points (/mm for milimeter, /in for inch, pt is postscript point, and as so is there only to show what is happening.
40
#The constants exported transform that into PostScript points (/mm for millimeter, /in for inch, pt is postscript point, and as so is there only to show what is happening.
41
use constant mm => 25.4 / 72;
41
use constant mm => 25.4 / 72;
42
use constant in => 1 / 72;
42
use constant in => 1 / 72;
43
use constant pt => 1;
43
use constant pt => 1;
(-)a/Koha/pdfformat/layout2pagesde.pm (-2 / +2 lines)
Lines 36-43 BEGIN { Link Here
36
    @EXPORT_OK = qw(printpdf);
36
    @EXPORT_OK = qw(printpdf);
37
}
37
}
38
38
39
#be careful, all the sizes (height, width, etc...) are in mm, not PostScript points (the default measurment of PDF::API2).
39
#be careful, all the sizes (height, width, etc...) are in mm, not PostScript points (the default measurement of PDF::API2).
40
#The constants exported transform that into PostScript points (/mm for milimeter, /in for inch, pt is postscript point, and as so is there only to show what is happening.
40
#The constants exported transform that into PostScript points (/mm for millimeter, /in for inch, pt is postscript point, and as so is there only to show what is happening.
41
use constant mm => 25.4 / 72;
41
use constant mm => 25.4 / 72;
42
use constant in => 1 / 72;
42
use constant in => 1 / 72;
43
use constant pt => 1;
43
use constant pt => 1;
(-)a/Koha/pdfformat/layout3pages.pm (-2 / +2 lines)
Lines 38-45 BEGIN { Link Here
38
    @EXPORT = qw(printpdf);
38
    @EXPORT = qw(printpdf);
39
}
39
}
40
40
41
#be careful, all the sizes (height, width, etc...) are in mm, not PostScript points (the default measurment of PDF::API2).
41
#be careful, all the sizes (height, width, etc...) are in mm, not PostScript points (the default measurement of PDF::API2).
42
#The constants exported transform that into PostScript points (/mm for milimeter, /in for inch, pt is postscript point, and as so is there only to show what is happening.
42
#The constants exported transform that into PostScript points (/mm for millimeter, /in for inch, pt is postscript point, and as so is there only to show what is happening.
43
use constant mm => 25.4 / 72;
43
use constant mm => 25.4 / 72;
44
use constant in => 1 / 72;
44
use constant in => 1 / 72;
45
use constant pt => 1;
45
use constant pt => 1;
(-)a/Koha/pdfformat/layout3pagesfr.pm (-2 / +2 lines)
Lines 39-46 BEGIN { Link Here
39
    @EXPORT = qw(printpdf);
39
    @EXPORT = qw(printpdf);
40
}
40
}
41
41
42
#be careful, all the sizes (height, width, etc...) are in mm, not PostScript points (the default measurment of PDF::API2).
42
#be careful, all the sizes (height, width, etc...) are in mm, not PostScript points (the default measurement of PDF::API2).
43
#The constants exported transform that into PostScript points (/mm for milimeter, /in for inch, pt is postscript point, and as so is there only to show what is happening.
43
#The constants exported transform that into PostScript points (/mm for millimeter, /in for inch, pt is postscript point, and as so is there only to show what is happening.
44
use constant mm => 25.4 / 72;
44
use constant mm => 25.4 / 72;
45
use constant in => 1 / 72;
45
use constant in => 1 / 72;
46
use constant pt => 1;
46
use constant pt => 1;
(-)a/Makefile.PL (-1 / +1 lines)
Lines 450-456 Name of DBMS user account for Koha's database. Link Here
450
450
451
=item DB_PASS
451
=item DB_PASS
452
452
453
Pasword of DMBS user account for Koha's database.
453
Password of DMBS user account for Koha's database.
454
454
455
=item ZEBRA_MARC_FORMAT
455
=item ZEBRA_MARC_FORMAT
456
456
(-)a/acqui/basket.pl (-1 / +1 lines)
Lines 50-56 basket.pl Link Here
50
50
51
=head1 DESCRIPTION
51
=head1 DESCRIPTION
52
52
53
 This script display all informations about basket for the supplier given
53
 This script display all information about basket for the supplier given
54
 on input arg.  Moreover, it allows us to add a new order for this supplier from
54
 on input arg.  Moreover, it allows us to add a new order for this supplier from
55
 an existing record, a suggestion or a new record.
55
 an existing record, a suggestion or a new record.
56
56
(-)a/acqui/basketgroup.pl (-1 / +1 lines)
Lines 281-287 if ( $op eq "add_form" ) { Link Here
281
            selectedbaskets => $selecteds
281
            selectedbaskets => $selecteds
282
        );
282
        );
283
283
284
        # Get general informations about the basket group to prefill the form
284
        # Get general information about the basket group to prefill the form
285
        my $basketgroup = GetBasketgroup($basketgroupid);
285
        my $basketgroup = GetBasketgroup($basketgroupid);
286
        $template->param(
286
        $template->param(
287
            name              => $basketgroup->{name},
287
            name              => $basketgroup->{name},
(-)a/acqui/booksellers.pl (-1 / +1 lines)
Lines 28-34 booksellers.pl Link Here
28
=head1 DESCRIPTION
28
=head1 DESCRIPTION
29
29
30
this script displays the list of suppliers & baskets like C<$supplier> given on input arg.
30
this script displays the list of suppliers & baskets like C<$supplier> given on input arg.
31
thus, this page brings differents features like to display supplier's details,
31
thus, this page brings FIXME CODESPELL (differents ==> different, difference) features like to display supplier's details,
32
to add an order for a specific supplier or to just add a new supplier.
32
to add an order for a specific supplier or to just add a new supplier.
33
33
34
=head1 CGI PARAMETERS
34
=head1 CGI PARAMETERS
(-)a/acqui/check_budget_total.pl (-1 / +1 lines)
Lines 26-32 use C4::Budgets qw( GetBudget ); Link Here
26
26
27
=head1 DESCRIPTION
27
=head1 DESCRIPTION
28
28
29
fetches the budget amount fron the DB
29
fetches the budget amount FIXME CODESPELL (fron ==> from, front) the DB
30
30
31
=cut
31
=cut
32
32
(-)a/acqui/invoice.pl (-1 / +1 lines)
Lines 345-351 $template->param( Link Here
345
defined($invoice_files) && $template->param( files => $invoice_files->GetFilesInfo() );
345
defined($invoice_files) && $template->param( files => $invoice_files->GetFilesInfo() );
346
346
347
# FIXME
347
# FIXME
348
# Fonction dupplicated from basket.pl
348
# Function duplicated from basket.pl
349
# Code must to be exported. Where ??
349
# Code must to be exported. Where ??
350
sub get_infos {
350
sub get_infos {
351
    my $order      = shift;
351
    my $order      = shift;
(-)a/acqui/neworderempty.pl (-1 / +1 lines)
Lines 448-454 $template->param( Link Here
448
$template->param(
448
$template->param(
449
    existing => $biblionumber,
449
    existing => $biblionumber,
450
450
451
    # basket informations
451
    # basket information
452
    basketname           => $basket->{'basketname'},
452
    basketname           => $basket->{'basketname'},
453
    basketnote           => $basket->{'note'},
453
    basketnote           => $basket->{'note'},
454
    booksellerid         => $basket->{'booksellerid'},
454
    booksellerid         => $basket->{'booksellerid'},
(-)a/acqui/updatesupplier.pl (-1 / +1 lines)
Lines 32-38 a supplier. This script is called from acqui/supplier.pl. Link Here
32
32
33
=head1 CGI PARAMETERS
33
=head1 CGI PARAMETERS
34
34
35
All informations regarding this supplier are listed on input parameter.
35
All information regarding this supplier are listed on input parameter.
36
Here is the list :
36
Here is the list :
37
37
38
supplier, id, company, company_postal, physical, company_phone,
38
supplier, id, company, company_postal, physical, company_phone,
(-)a/admin/aqbudgets.pl (-1 / +1 lines)
Lines 254-260 if ( $op eq 'list' ) { Link Here
254
    my $period_total = 0;
254
    my $period_total = 0;
255
    my ( $period_alloc_total, $spent_total, $ordered_total, $available_total ) = ( 0, 0, 0, 0 );
255
    my ( $period_alloc_total, $spent_total, $ordered_total, $available_total ) = ( 0, 0, 0, 0 );
256
256
257
    #This Looks WEIRD to me : should budgets be filtered in such a way ppl who donot own it would not see the amount spent on the budget by others ?
257
    #This Looks WEIRD to me : should budgets be filtered in such a way ppl who FIXME CODESPELL (donot ==> do not, donut) own it would not see the amount spent on the budget by others ?
258
258
259
    my @budgets_to_display;
259
    my @budgets_to_display;
260
    foreach my $budget (@budgets) {
260
    foreach my $budget (@budgets) {
(-)a/admin/check_budget_parent.pl (-1 / +1 lines)
Lines 26-32 use C4::Budgets qw( CheckBudgetParent GetBudget ); Link Here
26
26
27
=head1 DESCRIPTION
27
=head1 DESCRIPTION
28
28
29
fetches the budget amount fron the DB,
29
fetches the budget amount FIXME CODESPELL (fron ==> from, front) the DB,
30
called by aqbudgets.pl and neworderempty.pl
30
called by aqbudgets.pl and neworderempty.pl
31
31
32
=cut
32
=cut
(-)a/admin/check_parent_total.pl (-1 / +1 lines)
Lines 54-60 $period = GetBudgetPeriod($period_id) if $period_id; Link Here
54
$parent = GetBudget($parent_id)       if defined $parent_id;
54
$parent = GetBudget($parent_id)       if defined $parent_id;
55
$budget = GetBudget($budget_id)       if defined $budget_id;
55
$budget = GetBudget($budget_id)       if defined $budget_id;
56
56
57
# CHECK THE PARENT BUDGET FOR ENOUGHT AMOUNT UNALLOCATED,  IF NOT THEN RETURN 1
57
# CHECK THE PARENT BUDGET FOR ENOUGH AMOUNT UNALLOCATED,  IF NOT THEN RETURN 1
58
my ( $sub_unalloc, $period_sum, $budget_period_unalloc );
58
my ( $sub_unalloc, $period_sum, $budget_period_unalloc );
59
59
60
if ($parent) {
60
if ($parent) {
(-)a/admin/edi_accounts.pl (-2 / +2 lines)
Lines 110-117 if ( $op eq 'acct_form' ) { Link Here
110
        $schema->resultset('VendorEdiAccount')->search( { id => scalar $input->param('id'), } )->delete_all;
110
        $schema->resultset('VendorEdiAccount')->search( { id => scalar $input->param('id'), } )->delete_all;
111
    }
111
    }
112
112
113
    # we do a default dispaly after deletes and saves
113
    # we do a default display after deletes and saves
114
    # as well as when thats all you want
114
    # as well as when that's all you want
115
    $template->param( display => 1 );
115
    $template->param( display => 1 );
116
    my @ediaccounts = $schema->resultset('VendorEdiAccount')->search(
116
    my @ediaccounts = $schema->resultset('VendorEdiAccount')->search(
117
        {},
117
        {},
(-)a/admin/systempreferences.pl (-1 / +1 lines)
Lines 422-428 sub get_prefs_from_files { Link Here
422
    return @names;
422
    return @names;
423
}
423
}
424
424
425
# Return an array containg all preferences defined in DB
425
# Return an array containing all preferences defined in DB
426
426
427
sub get_prefs_from_db {
427
sub get_prefs_from_db {
428
    my $dbh = C4::Context->dbh;
428
    my $dbh = C4::Context->dbh;
(-)a/authorities/authorities.pl (-1 / +1 lines)
Lines 437-443 sub build_tabs { Link Here
437
                            fixedfield    => ( $tag < 10 ) ? (1) : (0),
437
                            fixedfield    => ( $tag < 10 ) ? (1) : (0),
438
                            random        => CreateKey,
438
                            random        => CreateKey,
439
                        );
439
                        );
440
                        if ( $tag >= 10 ) {    # no indicator for theses tag
440
                        if ( $tag >= 10 ) {    # no indicator for FIXME CODESPELL (theses ==> these, thesis) tag
441
                            $tag_data{indicator1} = format_indicator( $field->indicator(1) ),
441
                            $tag_data{indicator1} = format_indicator( $field->indicator(1) ),
442
                                $tag_data{indicator2} = format_indicator( $field->indicator(2) ),;
442
                                $tag_data{indicator2} = format_indicator( $field->indicator(2) ),;
443
                        }
443
                        }
(-)a/catalogue/MARCdetail.pl (-1 / +1 lines)
Lines 251-257 for ( my $tabloop = 0 ; $tabloop <= 10 ; $tabloop++ ) { Link Here
251
# now, build item tab !
251
# now, build item tab !
252
# the main difference is that datas are in lines and not in columns : thus, we build the <th> first, then the values...
252
# the main difference is that datas are in lines and not in columns : thus, we build the <th> first, then the values...
253
# loop through each tag
253
# loop through each tag
254
# warning : we may have differents number of columns in each row. Thus, we first build a hash, complete it if necessary
254
# warning : we may have FIXME CODESPELL (differents ==> different, difference) number of columns in each row. Thus, we first build a hash, complete it if necessary
255
# then construct template.
255
# then construct template.
256
my @fields = $record->fields();
256
my @fields = $record->fields();
257
my %witness;    #---- stores the list of subfields used at least once, with the "meaning" of the code
257
my %witness;    #---- stores the list of subfields used at least once, with the "meaning" of the code
(-)a/catalogue/search.pl (-1 / +1 lines)
Lines 411-417 if ( $params->{'limit-yr'} ) { Link Here
411
    }
411
    }
412
    push @limits, $limit_yr;
412
    push @limits, $limit_yr;
413
413
414
    #FIXME: Should return a error to the user, incorect date format specified
414
    #FIXME: Should return a error to the user, incorrect date format specified
415
}
415
}
416
416
417
# convert indexes and operands to corresponding parameter names for the z3950 search
417
# convert indexes and operands to corresponding parameter names for the z3950 search
(-)a/catalogue/stockrotation.pl (-1 / +1 lines)
Lines 20-26 Link Here
20
=head1 stockrotation.pl
20
=head1 stockrotation.pl
21
21
22
 Script to manage item assignments to stock rotation rotas. Including their
22
 Script to manage item assignments to stock rotation rotas. Including their
23
 assiciated stages
23
 associated stages
24
24
25
=cut
25
=cut
26
26
(-)a/cataloguing/addbooks.pl (-1 / +1 lines)
Lines 83-89 if ($query) { Link Here
83
    }
83
    }
84
84
85
    # format output
85
    # format output
86
    # SimpleSearch() give the results per page we want, so 0 offet here
86
    # SimpleSearch() give the results per page we want, so 0 FIXME CODESPELL (offet ==> offset, offer) here
87
    my $total = @{$marcresults};
87
    my $total = @{$marcresults};
88
    my @newresults =
88
    my @newresults =
89
        searchResults( { 'interface' => 'intranet' }, $query, $total, $results_per_page, 0, 0, $marcresults );
89
        searchResults( { 'interface' => 'intranet' }, $query, $total, $results_per_page, 0, 0, $marcresults );
(-)a/cataloguing/value_builder/callnumber.pl (-2 / +2 lines)
Lines 31-39 use C4::Output qw( output_html_with_http_headers ); Link Here
31
Is used for callnumber computation.
31
Is used for callnumber computation.
32
32
33
If the user send an empty string, we return a simple incremented callnumber.
33
If the user send an empty string, we return a simple incremented callnumber.
34
If a prefix is submited, we look for the highest callnumber with this prefix, and return it incremented.
34
If a prefix is submitted, we look for the highest callnumber with this prefix, and return it incremented.
35
In this case, a callnumber has this form : "PREFIX 0009678570".
35
In this case, a callnumber has this form : "PREFIX 0009678570".
36
 - PREFIX is an upercase word
36
 - PREFIX is an uppercase word
37
 - a space separator
37
 - a space separator
38
 - 10 digits, with leading 0s if needed
38
 - 10 digits, with leading 0s if needed
39
39
(-)a/cataloguing/value_builder/stocknumberAV.pl (-1 / +1 lines)
Lines 86-92 my $launcher = sub { Link Here
86
        }
86
        }
87
    );
87
    );
88
88
89
    # If a prefix is submited, we look for the highest stocknumber with this prefix, and return it incremented
89
    # If a prefix is submitted, we look for the highest stocknumber with this prefix, and return it incremented
90
    $code =~ s/ *$//g;
90
    $code =~ s/ *$//g;
91
    if ( $code =~ m/^[a-zA-Z]+$/ ) {
91
    if ( $code =~ m/^[a-zA-Z]+$/ ) {
92
        my $av = Koha::AuthorisedValues->find(
92
        my $av = Koha::AuthorisedValues->find(
(-)a/cataloguing/value_builder/stocknumberam123.pl (-3 / +3 lines)
Lines 32-40 This plugin is specific to AM123 but could be used as a base for similar operati Link Here
32
It is used for stocknumber computation.
32
It is used for stocknumber computation.
33
33
34
If the user send an empty string, we return a simple incremented stocknumber.
34
If the user send an empty string, we return a simple incremented stocknumber.
35
If a prefix is submited, we look for the highest stocknumber with this prefix, and return it incremented.
35
If a prefix is submitted, we look for the highest stocknumber with this prefix, and return it incremented.
36
In this case, a stocknumber has this form : "PREFIX 0009678570".
36
In this case, a stocknumber has this form : "PREFIX 0009678570".
37
 - PREFIX is an upercase word
37
 - PREFIX is an uppercase word
38
 - a space separator
38
 - a space separator
39
 - 10 digits, with leading 0s if needed
39
 - 10 digits, with leading 0s if needed
40
40
Lines 87-93 my $launcher = sub { Link Here
87
            );
87
            );
88
        }
88
        }
89
89
90
        # If a prefix is submited, we look for the highest stocknumber with this prefix, and return it incremented
90
        # If a prefix is submitted, we look for the highest stocknumber with this prefix, and return it incremented
91
    } elsif ( $code =~ m/^[a-zA-Z]+$/ ) {
91
    } elsif ( $code =~ m/^[a-zA-Z]+$/ ) {
92
        my $sth = $dbh->prepare(
92
        my $sth = $dbh->prepare(
93
            "SELECT MAX(CAST(SUBSTRING_INDEX(stocknumber,' ',-1) AS SIGNED)) FROM items WHERE stocknumber LIKE ?");
93
            "SELECT MAX(CAST(SUBSTRING_INDEX(stocknumber,' ',-1) AS SIGNED)) FROM items WHERE stocknumber LIKE ?");
(-)a/circ/returns.pl (-2 / +2 lines)
Lines 205-211 my $return_date_override = $query->param('return_date_override') || q{}; Link Here
205
if ($return_date_override) {
205
if ($return_date_override) {
206
    if ( C4::Context->preference('SpecifyReturnDate') ) {
206
    if ( C4::Context->preference('SpecifyReturnDate') ) {
207
207
208
        # note that we've overriden the return date
208
        # note that we've overridden the return date
209
        $template->param( return_date_was_overriden => 1 );
209
        $template->param( return_date_was_overriden => 1 );
210
210
211
        my $return_date_override_remember = $query->param('return_date_override_remember');
211
        my $return_date_override_remember = $query->param('return_date_override_remember');
Lines 534-540 if ( $messages->{'Wrongbranch'} ) { Link Here
534
    );
534
    );
535
}
535
}
536
536
537
# case of wrong transfert, if the document wasn't transferred to the right library (according to branchtransfer (tobranch) BDD)
537
# case of wrong FIXME CODESPELL (transfert ==> transfer, transferred), if the document wasn't transferred to the right library (according to branchtransfer (tobranch) BDD)
538
538
539
if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'} ) {
539
if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'} ) {
540
540
(-)a/circ/set-library.pl (-2 / +2 lines)
Lines 63-70 if ( Link Here
63
{
63
{
64
    if ( !$userenv_branch or $userenv_branch ne $branch ) {
64
    if ( !$userenv_branch or $userenv_branch ne $branch ) {
65
        my $branchname = $library->branchname;
65
        my $branchname = $library->branchname;
66
        $session->param( 'branchname', $branchname );    # update sesssion in DB
66
        $session->param( 'branchname', $branchname );    # update session in DB
67
        $session->param( 'branch',     $branch );        # update sesssion in DB
67
        $session->param( 'branch',     $branch );        # update session in DB
68
        $updated = 1;
68
        $updated = 1;
69
    }
69
    }
70
} else {
70
} else {
(-)a/circ/transferstoreceive.pl (-1 / +1 lines)
Lines 103-109 while ( my $library = $libraries->next ) { Link Here
103
                itemcallnumber => $item->itemcallnumber,
103
                itemcallnumber => $item->itemcallnumber,
104
            );
104
            );
105
105
106
            # we check if we have a reserv for this transfer
106
            # we check if we have a reserve for this transfer
107
            my $holds = $item->current_holds;
107
            my $holds = $item->current_holds;
108
            if ( my $first_hold = $holds->next ) {
108
            if ( my $first_hold = $holds->next ) {
109
                $getransf{patron} = Koha::Patrons->find( $first_hold->borrowernumber );
109
                $getransf{patron} = Koha::Patrons->find( $first_hold->borrowernumber );
(-)a/docs/CAS/CASProxy/examples/proxy_cas_data.pl (-1 / +1 lines)
Lines 26-32 Link Here
26
=head2 PGTIOU
26
=head2 PGTIOU
27
27
28
The Proxy Granting Ticket IOU the CAS Server returned to us when we gave him the Service Ticket
28
The Proxy Granting Ticket IOU the CAS Server returned to us when we gave him the Service Ticket
29
This PGTIOU will allow us to retrive the matching PGTID
29
This PGTIOU will allow us to retrieve the matching PGTID
30
30
31
=cut 
31
=cut 
32
32
(-)a/fix-perl-path.PL (-1 / +1 lines)
Lines 29-35 $bindir =~ s!\\!/!g; # make all directory separators uniform since Win32 does Link Here
29
my $shebang = "#!$bindir\/perl";
29
my $shebang = "#!$bindir\/perl";
30
30
31
warn "Perl binary located in $bindir on this system.\n"        if $DEBUG;
31
warn "Perl binary located in $bindir on this system.\n"        if $DEBUG;
32
warn "The shebang line for this sytems should be $shebang\n\n" if $DEBUG;
32
warn "The shebang line for this systems should be $shebang\n\n" if $DEBUG;
33
33
34
die if $basedir eq 'test';
34
die if $basedir eq 'test';
35
35
(-)a/installer/data/mysql/db_revs/210600018.pl (-1 / +1 lines)
Lines 2-8 use Modern::Perl; Link Here
2
2
3
return {
3
return {
4
    bug_number  => "22690",
4
    bug_number  => "22690",
5
    description => "Add contraints to the linktracker table",
5
    description => "Add constraints to the linktracker table",
6
    up          => sub {
6
    up          => sub {
7
        my ($args) = @_;
7
        my ($args) = @_;
8
        my ( $dbh, $out ) = @$args{qw(dbh out)};
8
        my ( $dbh, $out ) = @$args{qw(dbh out)};
(-)a/installer/data/mysql/db_revs/210600020.pl (-1 / +1 lines)
Lines 9-15 return { Link Here
9
        $dbh->do(
9
        $dbh->do(
10
            q{
10
            q{
11
            INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES
11
            INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES
12
            ('PassItemMarcToXSLT','0',NULL,'If enabled, item fields in the MARC record will be made avaiable to XSLT sheets. Otherwise they will be removed.','YesNo');
12
            ('PassItemMarcToXSLT','0',NULL,'If enabled, item fields in the MARC record will be made available to XSLT sheets. Otherwise they will be removed.','YesNo');
13
        }
13
        }
14
        );
14
        );
15
        foreach my $pref (
15
        foreach my $pref (
(-)a/installer/data/mysql/db_revs/220600059.pl (-1 / +1 lines)
Lines 11-17 return { Link Here
11
        $dbh->do(
11
        $dbh->do(
12
            q{
12
            q{
13
            INSERT IGNORE INTO letter (module, code, name, title, content, message_transport_type) VALUES ('members', 'PASSWORD_CHANGE', 'Notification of password change', 'Library account password change notification',
13
            INSERT IGNORE INTO letter (module, code, name, title, content, message_transport_type) VALUES ('members', 'PASSWORD_CHANGE', 'Notification of password change', 'Library account password change notification',
14
            "Dear [% borrower.firstname %] [% borrower.surname %],\r\n\r\nWe want to notify you that your password has been changed. If you did not change it yourself (or requested that change), please contact library staff.\r\n\r\nYour library.", 'email');
14
            "Dear [% borrower.firstname %] [% borrower.surname %],\r\n\r\new want to notify you that your password has been changed. If you did not change it yourself (or requested that change), please contact library staff.\r\n\r\nYour library.", 'email');
15
        }
15
        }
16
        );
16
        );
17
17
(-)a/installer/data/mysql/db_revs/221200003.pl (-1 / +1 lines)
Lines 9-15 return { Link Here
9
9
10
        my $permission_added = $dbh->do(
10
        my $permission_added = $dbh->do(
11
            q{
11
            q{
12
            INSERT IGNORE INTO permissions (module_bit, code, description) VALUES ( 9, 'edit_any_item', 'Edit any item reguardless of home library');
12
            INSERT IGNORE INTO permissions (module_bit, code, description) VALUES ( 9, 'edit_any_item', 'Edit any item regardless of home library');
13
        }
13
        }
14
        );
14
        );
15
15
(-)a/installer/data/mysql/db_revs/231200023.pl (-1 / +1 lines)
Lines 41-46 return { Link Here
41
        $dbh->do(
41
        $dbh->do(
42
            q{ALTER TABLE aqbudgets ADD CONSTRAINT `aqbudgetperiods_ibfk_1` FOREIGN KEY (`budget_period_id`) REFERENCES aqbudgetperiods(`budget_period_id`) ON DELETE CASCADE ON UPDATE CASCADE}
42
            q{ALTER TABLE aqbudgets ADD CONSTRAINT `aqbudgetperiods_ibfk_1` FOREIGN KEY (`budget_period_id`) REFERENCES aqbudgetperiods(`budget_period_id`) ON DELETE CASCADE ON UPDATE CASCADE}
43
        );
43
        );
44
        say $out "Readded foreign key aqbudgetperiods_ibfk_1";
44
        say $out "Read foreign key aqbudgetperiods_ibfk_1";
45
    },
45
    },
46
};
46
};
(-)a/installer/data/mysql/fix_unclosed_nonaccruing_fines_bug17135.pl (-1 / +1 lines)
Lines 167-173 sub Bug_17135_fix { Link Here
167
167
168
            ## If we are here: item is due again, but fine is not accruing
168
            ## If we are here: item is due again, but fine is not accruing
169
            ## yet (overdue may be in the grace period, 1st charging period
169
            ## yet (overdue may be in the grace period, 1st charging period
170
            ## is not over yet, all days beetwen due date and today are
170
            ## is not over yet, all days between due date and today are
171
            ## holidays etc.). Old fine record needs to be closed
171
            ## holidays etc.). Old fine record needs to be closed
172
            $is_not_accruing = 1;
172
            $is_not_accruing = 1;
173
        }
173
        }
(-)a/installer/data/mysql/labels_upgrade.pl (-1 / +1 lines)
Lines 189-195 $sth->do("DROP TABLE IF EXISTS labels_profile;") or die "DB ERROR: " . $sth->e Link Here
189
$sth->do("DROP TABLE IF EXISTS labels_templates;") or die "DB ERROR: " . $sth->errstr . "\n";
189
$sth->do("DROP TABLE IF EXISTS labels_templates;") or die "DB ERROR: " . $sth->errstr . "\n";
190
$sth->do("DROP TABLE IF EXISTS printers_profile;") or die "DB ERROR: " . $sth->errstr . "\n";
190
$sth->do("DROP TABLE IF EXISTS printers_profile;") or die "DB ERROR: " . $sth->errstr . "\n";
191
191
192
# Rename temporary tables to permenant names...
192
# Rename temporary tables to permanent names...
193
193
194
$sth->do("ALTER TABLE labels_batches_tmp RENAME TO labels_batches;")     or die "DB ERROR: " . $sth->errstr . "\n";
194
$sth->do("ALTER TABLE labels_batches_tmp RENAME TO labels_batches;")     or die "DB ERROR: " . $sth->errstr . "\n";
195
$sth->do("ALTER TABLE labels_layouts_tmp RENAME TO labels_layouts;")     or die "DB ERROR: " . $sth->errstr . "\n";
195
$sth->do("ALTER TABLE labels_layouts_tmp RENAME TO labels_layouts;")     or die "DB ERROR: " . $sth->errstr . "\n";
(-)a/installer/data/mysql/patroncards_upgrade.pl (-1 / +1 lines)
Lines 149-155 $sth->do("DROP TABLE IF EXISTS labels_batches;") or die "DB ERROR: " . $sth->e Link Here
149
$sth->do("DROP TABLE IF EXISTS labels_layouts;")   or die "DB ERROR: " . $sth->errstr . "\n";
149
$sth->do("DROP TABLE IF EXISTS labels_layouts;")   or die "DB ERROR: " . $sth->errstr . "\n";
150
$sth->do("DROP TABLE IF EXISTS labels_templates;") or die "DB ERROR: " . $sth->errstr . "\n";
150
$sth->do("DROP TABLE IF EXISTS labels_templates;") or die "DB ERROR: " . $sth->errstr . "\n";
151
151
152
# Rename temporary tables to permenant names...
152
# Rename temporary tables to permanent names...
153
153
154
$sth->do("ALTER TABLE creator_batches_tmp RENAME TO creator_batches;")     or die "DB ERROR: " . $sth->errstr . "\n";
154
$sth->do("ALTER TABLE creator_batches_tmp RENAME TO creator_batches;")     or die "DB ERROR: " . $sth->errstr . "\n";
155
$sth->do("ALTER TABLE creator_layouts_tmp RENAME TO creator_layouts;")     or die "DB ERROR: " . $sth->errstr . "\n";
155
$sth->do("ALTER TABLE creator_layouts_tmp RENAME TO creator_layouts;")     or die "DB ERROR: " . $sth->errstr . "\n";
(-)a/koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc (-1 / +1 lines)
Lines 62-68 Link Here
62
        <option value="ti,phr">&nbsp;&nbsp;&nbsp;&nbsp; Title as phrase</option>
62
        <option value="ti,phr">&nbsp;&nbsp;&nbsp;&nbsp; Title as phrase</option>
63
    [% END %]
63
    [% END %]
64
    [% IF ms_se %]
64
    [% IF ms_se %]
65
        <option selected="seleced" value="se">&nbsp;&nbsp;&nbsp;&nbsp; Series title</option>
65
        <option selected="selected" value="se">&nbsp;&nbsp;&nbsp;&nbsp; Series title</option>
66
    [% ELSE %]
66
    [% ELSE %]
67
        <option value="se">&nbsp;&nbsp;&nbsp;&nbsp; Series title</option>
67
        <option value="se">&nbsp;&nbsp;&nbsp;&nbsp; Series title</option>
68
    [% END %]
68
    [% END %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/includes/subtype_limits.inc (-2 / +2 lines)
Lines 197-205 Link Here
197
            <option value="ctype:l">Legislation</option>
197
            <option value="ctype:l">Legislation</option>
198
        [% END %]
198
        [% END %]
199
        [% IF (limits.ctype.0 == 'm' ) %]
199
        [% IF (limits.ctype.0 == 'm' ) %]
200
            <option value="ctype:m" selected="selected">Theses</option>
200
            <option value="ctype:m" selected="selected">FIXME CODESPELL (Theses ==> These, Thesis)</option>
201
        [% ELSE %]
201
        [% ELSE %]
202
            <option value="ctype:m">Theses</option>
202
            <option value="ctype:m">FIXME CODESPELL (Theses ==> These, Thesis)</option>
203
        [% END %]
203
        [% END %]
204
        [% IF (limits.ctype.0 == 'n' ) %]
204
        [% IF (limits.ctype.0 == 'n' ) %]
205
            <option value="ctype:n" selected="selected">Surveys</option>
205
            <option value="ctype:n" selected="selected">Surveys</option>
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt (-5 / +5 lines)
Lines 272-280 Link Here
272
    [% WRAPPER tab_panel tabname= "perl" bt_active = 1 %]
272
    [% WRAPPER tab_panel tabname= "perl" bt_active = 1 %]
273
        <table style="cursor:pointer">
273
        <table style="cursor:pointer">
274
            <caption>Perl modules</caption>
274
            <caption>Perl modules</caption>
275
            [% FOREACH tabl IN table %]
275
            [% FOREACH table IN tablee %]
276
                <tr>
276
                <tr>
277
                    [% FOREACH ro IN tabl.row %]
277
                    [% FOREACH ro IN table.row %]
278
                        [% IF ( ro.require ) %]
278
                        [% IF ( ro.require ) %]
279
                            [% SET th_font_weight = "bold" %]
279
                            [% SET th_font_weight = "bold" %]
280
                        [% ELSE %]
280
                        [% ELSE %]
Lines 313-319 Link Here
313
                        [% END %]
313
                        [% END %]
314
                    [% END # /FOREACH ro %]
314
                    [% END # /FOREACH ro %]
315
                </tr>
315
                </tr>
316
            [% END # /FOREACH tabl %]
316
            [% END # /FOREACH table %]
317
        </table>
317
        </table>
318
    [% END # tab=perl %]
318
    [% END # tab=perl %]
319
[% END %]
319
[% END %]
Lines 1246-1254 Link Here
1246
                        <td style="font-weight:bold;">Description</td>
1246
                        <td style="font-weight:bold;">Description</td>
1247
                    </tr>
1247
                    </tr>
1248
                </thead>
1248
                </thead>
1249
                [% FOREACH tabl IN table2 %]
1249
                [% FOREACH table IN tablee2 %]
1250
                    <tr class="[% loop.parity | html %]">
1250
                    <tr class="[% loop.parity | html %]">
1251
                        [% FOREACH ro IN tabl.row2 %]
1251
                        [% FOREACH ro IN table.row2 %]
1252
                            <td>[% ro.date | html %]</td>
1252
                            <td>[% ro.date | html %]</td>
1253
                            <td>[% ro.desc | html %]</td>
1253
                            <td>[% ro.desc | html %]</td>
1254
                        [% END %]
1254
                        [% END %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt (-1 / +1 lines)
Lines 577-583 Link Here
577
                                    <legend>Accounting details</legend>
577
                                    <legend>Accounting details</legend>
578
                                    <ol>
578
                                    <ol>
579
                                        <li>
579
                                        <li>
580
                                            <!-- origquantityrec only here for javascript compatibility (additem.js needs it, useless here, useful when receiveing an order -->
580
                                            <!-- origquantityrec only here for javascript compatibility (additem.js needs it, useless here, useful when receiving an order -->
581
                                            <input id="origquantityrec" readonly="readonly" type="hidden" name="origquantityrec" value="1" />
581
                                            <input id="origquantityrec" readonly="readonly" type="hidden" name="origquantityrec" value="1" />
582
                                        </li>
582
                                        </li>
583
                                        [% IF ( close ) %]
583
                                        [% IF ( close ) %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt (-1 / +1 lines)
Lines 266-272 Link Here
266
                [% END %]
266
                [% END %]
267
                <input type="hidden" name="op" value="cud-do_duplicate" />
267
                <input type="hidden" name="op" value="cud-do_duplicate" />
268
                <input type="hidden" name="basketno" value="[% basket.basketno | html %]" />
268
                <input type="hidden" name="basketno" value="[% basket.basketno | html %]" />
269
                <!-- origquantityrec only here for javascript compatibility (additem.js needs it, useless here, useful when receiveing an order -->
269
                <!-- origquantityrec only here for javascript compatibility (additem.js needs it, useless here, useful when receiving an order -->
270
                <input id="origquantityrec" readonly="readonly" type="hidden" name="origquantityrec" value="1" />
270
                <input id="origquantityrec" readonly="readonly" type="hidden" name="origquantityrec" value="1" />
271
                <button type="submit" class="btn btn-primary">Duplicate orders</button>
271
                <button type="submit" class="btn btn-primary">Duplicate orders</button>
272
                <a class="cancel" href="/cgi-bin/koha/acqui/duplicate_orders.pl?basketno=[% basket.basketno | html %]">Cancel</a>
272
                <a class="cancel" href="/cgi-bin/koha/acqui/duplicate_orders.pl?basketno=[% basket.basketno | html %]">Cancel</a>
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt (-1 / +1 lines)
Lines 570-576 Link Here
570
                        [% END %]
570
                        [% END %]
571
                    [% END %]
571
                    [% END %]
572
                    <span class="required">Required</span>
572
                    <span class="required">Required</span>
573
                    <!-- origquantityrec only here for javascript compatibility (additem.js needs it, useless here, useful when receiveing an order -->
573
                    <!-- origquantityrec only here for javascript compatibility (additem.js needs it, useless here, useful when receiving an order -->
574
                    <input id="origquantityrec" readonly="readonly" type="hidden" name="origquantityrec" value="1" />
574
                    <input id="origquantityrec" readonly="readonly" type="hidden" name="origquantityrec" value="1" />
575
575
576
                    [% IF subscription %]
576
                    [% IF subscription %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt (-2 / +2 lines)
Lines 132-138 Link Here
132
                        [% outputsubfield = PROCESS outputsubfield subfieldanchor = loo.subfieldcode %]
132
                        [% outputsubfield = PROCESS outputsubfield subfieldanchor = loo.subfieldcode %]
133
                        [% WRAPPER tab_panel tabname=outputsubfield %]
133
                        [% WRAPPER tab_panel tabname=outputsubfield %]
134
                            <input type="hidden" name="tab_id" value="[% loo.row | html %]" />
134
                            <input type="hidden" name="tab_id" value="[% loo.row | html %]" />
135
                            <div id="basic[%- outputsubfield | html -%]" class="contraints">
135
                            <div id="basic[%- outputsubfield | html -%]" class="constraints">
136
                                <fieldset class="rows">
136
                                <fieldset class="rows">
137
                                    <legend>Basic constraints</legend>
137
                                    <legend>Basic constraints</legend>
138
                                    <ol>
138
                                    <ol>
Lines 211-217 Link Here
211
                            </div>
211
                            </div>
212
                            <!-- /#basic[%- PROCESS outputsubfield subfieldanchor = subfieldcode -%] -->
212
                            <!-- /#basic[%- PROCESS outputsubfield subfieldanchor = subfieldcode -%] -->
213
213
214
                            <div id="advanced[%- outputsubfield | html -%]" class="contraints">
214
                            <div id="advanced[%- outputsubfield | html -%]" class="constraints">
215
                                <fieldset class="rows">
215
                                <fieldset class="rows">
216
                                    <legend>Advanced constraints</legend>
216
                                    <legend>Advanced constraints</legend>
217
                                    <ol>
217
                                    <ol>
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/usage_statistics.tt (-1 / +1 lines)
Lines 199-205 Link Here
199
                            /></a>
199
                            /></a>
200
                        </li>
200
                        </li>
201
                        <li>
201
                        <li>
202
                            <label for="UsageStatsLibrariesInfo">Libraries informations: </label>
202
                            <label for="UsageStatsLibrariesInfo">Libraries information: </label>
203
                            <select name="UsageStatsLibrariesInfo" id="UsageStatsLibrariesInfo">
203
                            <select name="UsageStatsLibrariesInfo" id="UsageStatsLibrariesInfo">
204
                                [% IF Koha.Preference('UsageStatsLibrariesInfo') %]
204
                                [% IF Koha.Preference('UsageStatsLibrariesInfo') %]
205
                                    <option value="1" selected="selected">Yes</option>
205
                                    <option value="1" selected="selected">Yes</option>
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt (-1 / +1 lines)
Lines 298-304 Link Here
298
                input.val(document.location.hash);
298
                input.val(document.location.hash);
299
                $( '#loginform' ).append( input );
299
                $( '#loginform' ).append( input );
300
            }
300
            }
301
            // Clear last borrowers, rememberd sql reports, carts, etc.
301
            // Clear last borrowers, remembered sql reports, carts, etc.
302
            logOut();
302
            logOut();
303
303
304
            $("#send_otp").on("click", function(e){
304
            $("#send_otp").on("click", function(e){
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt (-15 / +15 lines)
Lines 93-111 Link Here
93
                    <th>Get it!</th>
93
                    <th>Get it!</th>
94
                    <th>Other action</th>
94
                    <th>Other action</th>
95
                </tr>
95
                </tr>
96
                [% FOREACH resul IN result %]
96
                [% FOREACH result IN resultt %]
97
                    <tr>
97
                    <tr>
98
                        <td>
98
                        <td>
99
                            [% IF resul.html %]
99
                            [% IF result.html %]
100
                                [% resul.html | $raw %]
100
                                [% result.html | $raw %]
101
                            [% ELSE %]
101
                            [% ELSE %]
102
                                [% PROCESS authresult summary=resul.summary authid=resul.authid auth_preview=1 %]
102
                                [% PROCESS authresulttt summary=resultt.summary authid=resultt.authid auth_preview=1 %]
103
                            [% END %]
103
                            [% END %]
104
                        </td>
104
                        </td>
105
                        <td>[% resul.summary.label | html %]</td>
105
                        <td>[% result.summary.label | html %]</td>
106
                        <td>
106
                        <td>
107
                            [% IF resul.used > 0 %]
107
                            [% IF result.used > 0 %]
108
                                <a href="/cgi-bin/koha/catalogue/search.pl?type=intranet&amp;op=do_search&amp;idx=an,phr&amp;q=[% resul.authid | uri %]" class="button">[% resul.used | html %] times</a>
108
                                <a href="/cgi-bin/koha/catalogue/search.pl?type=intranet&amp;op=do_search&amp;idx=an,phr&amp;q=[% resultt.authid | uri %]" class="button">[% resultt.used | html %] times</a>
109
                            [% ELSE %]
109
                            [% ELSE %]
110
                                0 times
110
                                0 times
111
                            [% END %]
111
                            [% END %]
Lines 113-135 Link Here
113
                        [% IF Koha.Preference('ShowHeadingUse') %]
113
                        [% IF Koha.Preference('ShowHeadingUse') %]
114
                            <td class="heading_use"
114
                            <td class="heading_use"
115
                                ><ul class="usefor">
115
                                ><ul class="usefor">
116
                                    <li>[% IF resul.main %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Main/Added Entry</li>
116
                                    <li>[% IF result.main %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Main/Added Entry</li>
117
                                    <li>[% IF resul.subject %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Subject</li>
117
                                    <li>[% IF result.subject %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Subject</li>
118
                                    <li>[% IF resul.series %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Series Title</li>
118
                                    <li>[% IF result.series %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Series Title</li>
119
                                </ul></td
119
                                </ul></td
120
                            >
120
                            >
121
                        [% END %]
121
                        [% END %]
122
                        <td>
122
                        <td>
123
                            [% IF resul.summary && resul.summary.authorized && resul.summary.authorized.size > 1 %]
123
                            [% IF resulttt.summary && resulttt.summary.authorized && resulttt.summary.authorized.size > 1 %]
124
                                [% FOREACH authorized IN resul.summary.authorized %]
124
                                [% FOREACH authorized IN result.summary.authorized %]
125
                                    <a href="javascript:doauth('[% resul.authid | uri %]', '[% index | uri %]', '[% loop.count | uri %]')" title="[% authorized.heading | html %]">[% loop.count | html %]</a>
125
                                    <a href="javascript:doauth('[% result.authid | uri %]', '[% index | uri %]', '[% loop.count | uri %]')" title="[% authorized.heading | html %]">[% loop.count | html %]</a>
126
                                [% END %]
126
                                [% END %]
127
                            [% ELSE %]
127
                            [% ELSE %]
128
                                <a class="btn btn-xs btn-default" href="javascript:doauth('[% resul.authid | html %]', '[% index | html %]', '')"><i class="fa fa-plus"></i> Choose</a>
128
                                <a class="btn btn-xs btn-default" href="javascript:doauth('[% result.authid | html %]', '[% index | html %]', '')"><i class="fa fa-plus"></i> Choose</a>
129
                            [% END %]
129
                            [% END %]
130
                        </td>
130
                        </td>
131
                        <td
131
                        <td
132
                            ><a class="btn btn-xs btn-default" href="authorities.pl?authid=[% resul.authid | html %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit authority</a></td
132
                            ><a class="btn btn-xs btn-default" href="authorities.pl?authid=[% result.authid | html %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit authority</a></td
133
                        >
133
                        >
134
                    </tr>
134
                    </tr>
135
                [% END %]
135
                [% END %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt (-18 / +18 lines)
Lines 73-92 Link Here
73
                            <th>&nbsp;</th>
73
                            <th>&nbsp;</th>
74
                        [% END %]
74
                        [% END %]
75
                    </tr>
75
                    </tr>
76
                    [% FOREACH resul IN result %]
76
                    [% FOREACH result IN resultt %]
77
                        <tr data-authid="[% resul.authid | html %]">
77
                        <tr data-authid="[% result.authid | html %]">
78
                            <td>
78
                            <td>
79
                                [% IF resul.html %]
79
                                [% IF result.html %]
80
                                    [% resul.html | $raw %]
80
                                    [% result.html | $raw %]
81
                                [% ELSE %]
81
                                [% ELSE %]
82
                                    [% PROCESS authresult summary=resul.summary authid=resul.authid %]
82
                                    [% PROCESS authresulttt summary=resultt.summary authid=resultt.authid %]
83
                                [% END %]
83
                                [% END %]
84
                            </td>
84
                            </td>
85
                            <td>[% resul.authtype | html %]</td>
85
                            <td>[% result.authtype | html %]</td>
86
                            [% UNLESS ( resul.isEDITORS ) %]
86
                            [% UNLESS ( result.isEDITORS ) %]
87
                                <td>
87
                                <td>
88
                                    [% IF resul.used > 0 %]
88
                                    [% IF result.used > 0 %]
89
                                        <a href="/cgi-bin/koha/catalogue/search.pl?type=intranet&amp;op=do_search&amp;idx=an,phr&amp;q=[% resul.authid | uri %]" class="button">[% resul.used | html %] record(s)</a>
89
                                        <a href="/cgi-bin/koha/catalogue/search.pl?type=intranet&amp;op=do_search&amp;idx=an,phr&amp;q=[% resultt.authid | uri %]" class="button">[% resultt.used | html %] record(s)</a>
90
                                    [% ELSE %]
90
                                    [% ELSE %]
91
                                        0 records
91
                                        0 records
92
                                    [% END %]
92
                                    [% END %]
Lines 95-123 Link Here
95
                            [% IF Koha.Preference('ShowHeadingUse') %]
95
                            [% IF Koha.Preference('ShowHeadingUse') %]
96
                                <td class="heading_use"
96
                                <td class="heading_use"
97
                                    ><ul class="usefor">
97
                                    ><ul class="usefor">
98
                                        <li>[% IF resul.main %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Main/Added Entry</li>
98
                                        <li>[% IF result.main %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Main/Added Entry</li>
99
                                        <li>[% IF resul.subject %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Subject</li>
99
                                        <li>[% IF result.subject %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Subject</li>
100
                                        <li>[% IF resul.series %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Series Title</li>
100
                                        <li>[% IF result.series %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Series Title</li>
101
                                    </ul></td
101
                                    </ul></td
102
                                >
102
                                >
103
                            [% END %]
103
                            [% END %]
104
                            [% IF ( CAN_user_editauthorities ) %]
104
                            [% IF ( CAN_user_editauthorities ) %]
105
                                <td>
105
                                <td>
106
                                    <div class="btn-group dropup">
106
                                    <div class="btn-group dropup">
107
                                        <a class="btn btn-default btn-xs dropdown-toggle" id="authactions[% resul.authid | html %]" role="button" data-bs-toggle="dropdown" href="#"> Actions</a>
107
                                        <a class="btn btn-default btn-xs dropdown-toggle" id="authactions[% result.authid | html %]" role="button" data-bs-toggle="dropdown" href="#"> Actions</a>
108
                                        <ul class="dropdown-menu dropdown-menu-end" role="menu" aria-labelledby="authactions[% resul.authid | html %]">
108
                                        <ul class="dropdown-menu dropdown-menu-end" role="menu" aria-labelledby="authactions[% result.authid | html %]">
109
                                            <li
109
                                            <li
110
                                                ><a class="dropdown-item" href="/cgi-bin/koha/authorities/authorities.pl?authid=[% resul.authid | uri %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a></li
110
                                                ><a class="dropdown-item" href="/cgi-bin/koha/authorities/authorities.pl?authid=[% result.authid | uri %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a></li
111
                                            >
111
                                            >
112
                                            <li
112
                                            <li
113
                                                ><a class="merge_auth dropdown-item" href="#merge"><i class="fa fa-compress"></i> Merge</a></li
113
                                                ><a class="merge_auth dropdown-item" href="#merge"><i class="fa fa-compress"></i> Merge</a></li
114
                                            >
114
                                            >
115
                                            [% UNLESS ( resul.used ) %]
115
                                            [% UNLESS ( result.used ) %]
116
                                                <li
116
                                                <li
117
                                                    ><form class="form_delete" method="post" action="/cgi-bin/koha/authorities/authorities-home.pl">
117
                                                    ><form class="form_delete" method="post" action="/cgi-bin/koha/authorities/authorities-home.pl">
118
                                                        [% INCLUDE 'csrf-token.inc' %]
118
                                                        [% INCLUDE 'csrf-token.inc' %]
119
                                                        <input type="hidden" name="op" value="cud-delete" />
119
                                                        <input type="hidden" name="op" value="cud-delete" />
120
                                                        <input type="hidden" name="authid" value="[% resul.authid | html %]" />
120
                                                        <input type="hidden" name="authid" value="[% result.authid | html %]" />
121
                                                        <input type="hidden" name="type" value="intranet" />
121
                                                        <input type="hidden" name="type" value="intranet" />
122
                                                        <input type="hidden" name="authtypecode" value="[% authtypecode | html %]" />
122
                                                        <input type="hidden" name="authtypecode" value="[% authtypecode | html %]" />
123
                                                        <input type="hidden" name="marclist" value="[% marclist | html %]" />
123
                                                        <input type="hidden" name="marclist" value="[% marclist | html %]" />
Lines 133-139 Link Here
133
                                                >
133
                                                >
134
                                            [% END %]
134
                                            [% END %]
135
                                            <li class="authority_preview">
135
                                            <li class="authority_preview">
136
                                                <a class="dropdown-item" data-authid="[% resul.authid | html %]" href="/cgi-bin/koha/authorities/detail.pl?authid=[% resul.authid | uri %]"><i class="fa-solid fa-eye"></i> MARC preview</a>
136
                                                <a class="dropdown-item" data-authid="[% resultt.authid | html %]" href="/cgi-bin/koha/authorities/detail.pl?authid=[% resultt.authid | uri %]"><i class="fa-solid fa-eye"></i> MARC preview</a>
137
                                            </li>
137
                                            </li>
138
                                        </ul>
138
                                        </ul>
139
                                    </div>
139
                                    </div>
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt (-1 / +1 lines)
Lines 141-147 Link Here
141
                                                        <a
141
                                                        <a
142
                                                            class="delete"
142
                                                            class="delete"
143
                                                            href="/cgi-bin/koha/cataloguing/additem.pl?op=delinkitem&amp;biblionumber=[% biblio.biblionumber | html %]&amp;hostitemnumber=[% item.itemnumber | html %]&amp;searchid=[% searchid | html %]"
143
                                                            href="/cgi-bin/koha/cataloguing/additem.pl?op=delinkitem&amp;biblionumber=[% biblio.biblionumber | html %]&amp;hostitemnumber=[% item.itemnumber | html %]&amp;searchid=[% searchid | html %]"
144
                                                            >Delink</a
144
                                                            >Unlink</a
145
                                                        ></li
145
                                                        ></li
146
                                                    >
146
                                                    >
147
                                                [% ELSE %]
147
                                                [% ELSE %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt (-14 / +14 lines)
Lines 84-116 Link Here
84
                        <th>Concise description</th>
84
                        <th>Concise description</th>
85
                        <th>&nbsp;</th>
85
                        <th>&nbsp;</th>
86
                    </tr>
86
                    </tr>
87
                    [% FOREACH resul IN result %]
87
                    [% FOREACH result IN resultt %]
88
                        [% IF ( resul.title ) %]
88
                        [% IF ( result.title ) %]
89
                            <tr>
89
                            <tr>
90
                                [% SET td_class = '' %]
90
                                [% SET td_class = '' %]
91
                                [% IF ( resul.even ) %]
91
                                [% IF ( result.even ) %]
92
                                    [% td_class = 'hilighted' %]
92
                                    [% td_class = 'hilighted' %]
93
                                [% END %]
93
                                [% END %]
94
                                <td class="[% td_class | html %]">
94
                                <td class="[% td_class | html %]">
95
                                    [% IF ( resul.MARC_ON ) %]
95
                                    [% IF ( result.MARC_ON ) %]
96
                                        <a class="transparent resultlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% resul.biblionumber |url %]">[% resul.title | html %]</a>
96
                                        <a class="transparent resultttlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% resultt.biblionumber |url %]">[% resultt.title | html %]</a>
97
                                    [% ELSE %]
97
                                    [% ELSE %]
98
                                        <a class="transparent resultlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% resul.biblionumber |url %]">[% resul.title | html %]</a>
98
                                        <a class="transparent resultttlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% resultt.biblionumber |url %]">[% resultt.title | html %]</a>
99
                                    [% END %]
99
                                    [% END %]
100
                                    <p
100
                                    <p
101
                                        >[% resul.author | html %]
101
                                        >[% result.author | html %]
102
                                        [% IF ( resul.publishercode ) %]- [% resul.publishercode | html %][% END %]
102
                                        [% IF ( resultt.publishercode ) %]- [% resultt.publishercode | html %][% END %]
103
                                        [% IF ( resul.place ) %]; [% resul.place | html %][% END %]
103
                                        [% IF ( resultt.place ) %]; [% resultt.place | html %][% END %]
104
                                        [% IF ( resul.pages ) %]- [% resul.pages | html %][% END %]
104
                                        [% IF ( resultt.pages ) %]- [% resultt.pages | html %][% END %]
105
                                        [% IF ( resul.notes ) %]: [% resul.notes | html %][% END %]
105
                                        [% IF ( resultt.notes ) %]: [% resultt.notes | html %][% END %]
106
                                        [% IF ( resul.size ) %]; [% resul.size | html %][% END %]
106
                                        [% IF ( resultt.size ) %]; [% resultt.size | html %][% END %]
107
                                    </p>
107
                                    </p>
108
                                </td>
108
                                </td>
109
109
110
                                <td>
110
                                <td>
111
                                    [% IF ( resul.biblionumber ) %]
111
                                    [% IF ( result.biblionumber ) %]
112
                                        <a
112
                                        <a
113
                                            href="javascript:jumpfull('/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_linking_section.pl&amp;index=[% index | uri %]&amp;biblionumber=[% resul.biblionumber | uri %]&amp;type=intranet&amp;op=fillinput')"
113
                                            href="javascript:jumpfull('/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_linking_section.pl&amp;index=[% index | uri %]&amp;biblionumber=[% result.biblionumber | uri %]&amp;type=intranet&amp;op=fillinput')"
114
                                            >Choose</a
114
                                            >Choose</a
115
                                        >
115
                                        >
116
                                    [% ELSE %]
116
                                    [% ELSE %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_120.tt (-4 / +4 lines)
Lines 715-723 Link Here
715
                            <option value="ai">Cadiz, Spain</option>
715
                            <option value="ai">Cadiz, Spain</option>
716
                        [% END %]
716
                        [% END %]
717
                        [% IF ( f9aj ) %]
717
                        [% IF ( f9aj ) %]
718
                            <option value="aj" selected="selected">Capetown, South Africa</option>
718
                            <option value="aj" selected="selected">Cape town, South Africa</option>
719
                        [% ELSE %]
719
                        [% ELSE %]
720
                            <option value="aj">Capetown, South Africa</option>
720
                            <option value="aj">Cape town, South Africa</option>
721
                        [% END %]
721
                        [% END %]
722
                        [% IF ( f9ak ) %]
722
                        [% IF ( f9ak ) %]
723
                            <option value="ak" selected="selected">Caracas, Venezuela</option>
723
                            <option value="ak" selected="selected">Caracas, Venezuela</option>
Lines 950-958 Link Here
950
                            <option value="ai">Cadiz, Spain</option>
950
                            <option value="ai">Cadiz, Spain</option>
951
                        [% END %]
951
                        [% END %]
952
                        [% IF ( f10aj ) %]
952
                        [% IF ( f10aj ) %]
953
                            <option value="aj" selected="selected">Capetown, South Africa</option>
953
                            <option value="aj" selected="selected">Cape town, South Africa</option>
954
                        [% ELSE %]
954
                        [% ELSE %]
955
                            <option value="aj">Capetown, South Africa</option>
955
                            <option value="aj">Cape town, South Africa</option>
956
                        [% END %]
956
                        [% END %]
957
                        [% IF ( f10ak ) %]
957
                        [% IF ( f10ak ) %]
958
                            <option value="ak" selected="selected">Caracas, Venezuela</option>
958
                            <option value="ak" selected="selected">Caracas, Venezuela</option>
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tt (-6 / +6 lines)
Lines 68-82 Link Here
68
                <th>Used</th>
68
                <th>Used</th>
69
                <th>Get it!</th>
69
                <th>Get it!</th>
70
            </tr>
70
            </tr>
71
            [% FOREACH resul IN result %]
71
            [% FOREACH result IN resultt %]
72
                <tr>
72
                <tr>
73
                    <td>[% PROCESS authresult summary=resul.summary authid=resul.authid %]</td>
73
                    <td>[% PROCESS authresulttt summary=resultt.summary authid=resultt.authid %]</td>
74
                    <td>[% resul.summary.label | html %]</td>
74
                    <td>[% result.summary.label | html %]</td>
75
                    <td>[% resul.used | html %] times</td>
75
                    <td>[% result.used | html %] times</td>
76
                    <td>
76
                    <td>
77
                        [% IF ( resul.to_report ) %]
77
                        [% IF ( result.to_report ) %]
78
                            <button class="choosebt">Choose</button>
78
                            <button class="choosebt">Choose</button>
79
                            <p class="toreport" style="display:none">[% resul.to_report |replace('\n', '\\n') |replace('\r', '\\r') |html %]</p>
79
                            <p class="toreport" style="display:none">[% result.to_report |replace('\n', '\\n') |replace('\r', '\\r') |html %]</p>
80
                        [% END %]
80
                        [% END %]
81
                    </td>
81
                    </td>
82
                </tr>
82
                </tr>
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt (-16 / +16 lines)
Lines 89-124 Link Here
89
                    <th>Location</th>
89
                    <th>Location</th>
90
                    <th>&nbsp;</th>
90
                    <th>&nbsp;</th>
91
                </tr>
91
                </tr>
92
                [% FOREACH resul IN result %]
92
                [% FOREACH result IN resultt %]
93
                    [% IF ( resul.title ) %]
93
                    [% IF ( result.title ) %]
94
                        <tr>
94
                        <tr>
95
                            [% SET td_class = '' %]
95
                            [% SET td_class = '' %]
96
                            [% IF ( resul.even ) %]
96
                            [% IF ( result.even ) %]
97
                                [% td_class = 'hilighted' %]
97
                                [% td_class = 'hilighted' %]
98
                            [% END %]
98
                            [% END %]
99
                            <td class="[% td_class | html %]">
99
                            <td class="[% td_class | html %]">
100
                                [% IF ( resul.MARC_ON ) %]
100
                                [% IF ( result.MARC_ON ) %]
101
                                    <a class="transparent resultlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% resul.biblionumber |url %]">[% resul.title | html %]</a>
101
                                    <a class="transparent resultttlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% resultt.biblionumber |url %]">[% resultt.title | html %]</a>
102
                                [% ELSE %]
102
                                [% ELSE %]
103
                                    <a class="transparent resultlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% resul.biblionumber |url %]">[% resul.fulltitle | html %]</a>
103
                                    <a class="transparent resultttlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% resultt.biblionumber |url %]">[% resultt.fulltitle | html %]</a>
104
                                [% END %]
104
                                [% END %]
105
                                <p
105
                                <p
106
                                    >[% resul.author | html %]
106
                                    >[% result.author | html %]
107
                                    [% IF ( resul.publishercode ) %]- [% resul.publishercode | html %][% END %]
107
                                    [% IF ( resultt.publishercode ) %]- [% resultt.publishercode | html %][% END %]
108
                                    [% IF ( resul.place ) %]; [% resul.place | html %][% END %]
108
                                    [% IF ( resultt.place ) %]; [% resultt.place | html %][% END %]
109
                                    [% IF ( resul.pages ) %]- [% resul.pages | html %][% END %]
109
                                    [% IF ( resultt.pages ) %]- [% resultt.pages | html %][% END %]
110
                                    [% IF ( resul.notes ) %]: [% resul.notes | html %][% END %]
110
                                    [% IF ( resultt.notes ) %]: [% resultt.notes | html %][% END %]
111
                                    [% IF ( resul.item('size') ) %]; [% resul.item('size') | html %][% END %]
111
                                    [% IF ( resultt.item('size') ) %]; [% resultt.item('size') | html %][% END %]
112
                                </p>
112
                                </p>
113
                            </td>
113
                            </td>
114
                            <td align="center" class="[% td_class | html %]"> [% resul.totitem | html %] </td>
114
                            <td align="center" class="[% td_class | html %]"> [% result.totitem | html %] </td>
115
                            <td class="[% td_class | html %]"> [% resul.CN | html %] </td>
115
                            <td class="[% td_class | html %]"> [% result.CN | html %] </td>
116
                            <td>
116
                            <td>
117
                                [% IF ( resul.biblionumber ) %]
117
                                [% IF ( result.biblionumber ) %]
118
                                    <a
118
                                    <a
119
                                        href="#"
119
                                        href="#"
120
                                        class="btn btn-default btn-xs redirect_link"
120
                                        class="btn btn-default btn-xs redirect_link"
121
                                        data-url="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&amp;index=[% index | html %]&amp;biblionumber=[% resul.biblionumber | html %]&amp;type=intranet&amp;op=fillinput"
121
                                        data-url="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&amp;index=[% index | html %]&amp;biblionumber=[% result.biblionumber | html %]&amp;type=intranet&amp;op=fillinput"
122
                                        >Choose</a
122
                                        >Choose</a
123
                                    >
123
                                    >
124
                                [% ELSE %]
124
                                [% ELSE %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt (-1 / +1 lines)
Lines 81-87 Link Here
81
81
82
    <h1>Check out</h1>
82
    <h1>Check out</h1>
83
83
84
    <!--  INITIAL BLOC : PARAMETERS & BORROWER INFO -->
84
    <!--  INITIAL BLOCK : PARAMETERS & BORROWER INFO -->
85
    [% IF ( was_renewed ) %]
85
    [% IF ( was_renewed ) %]
86
        <div class="alert alert-info">Patron's account has been renewed until [% expiry | $KohaDates %]</div>
86
        <div class="alert alert-info">Patron's account has been renewed until [% expiry | $KohaDates %]</div>
87
    [% END %]
87
    [% END %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt (-1 / +1 lines)
Lines 54-60 Link Here
54
                                </tr></thead
54
                                </tr></thead
55
                            >
55
                            >
56
                            <tbody
56
                            <tbody
57
                                >[% FOREACH reser IN branchesloo.reserv %]
57
                                >[% FOREACH reser IN branchesloo.reserve %]
58
                                    [% SET tr_class = '' %]
58
                                    [% SET tr_class = '' %]
59
                                    [% IF ( reser.messcompa ) %]
59
                                    [% IF ( reser.messcompa ) %]
60
                                        [% tr_class = 'problem' %]
60
                                        [% tr_class = 'problem' %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt (-1 / +1 lines)
Lines 284-290 Link Here
284
                        [% ELSE %]
284
                        [% ELSE %]
285
                            <input type="hidden" name="op" value="cud-save" />
285
                            <input type="hidden" name="op" value="cud-save" />
286
                            [% IF step == 4 || step == 5 || step == 6 || step == 2 || step == 1 || step == 7 %]
286
                            [% IF step == 4 || step == 5 || step == 6 || step == 2 || step == 1 || step == 7 %]
287
                                [%# Only put the card number if we arent showing it in the form later %]
287
                                [%# Only put the card number if we aren't showing it in the form later %]
288
                                [% IF borrower_data.cardnumber %]
288
                                [% IF borrower_data.cardnumber %]
289
                                    <input type="hidden" name="cardnumber" value="[% borrower_data.cardnumber | html %]" />
289
                                    <input type="hidden" name="cardnumber" value="[% borrower_data.cardnumber | html %]" />
290
                                [% END %]
290
                                [% END %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt (-1 / +1 lines)
Lines 515-521 Link Here
515
                let amount_outstanding = parseFloat( $('#amountoutstanding').attr('value') );
515
                let amount_outstanding = parseFloat( $('#amountoutstanding').attr('value') );
516
                let amount_writeoff = parseFloat( $('#amountwrittenoff').attr('value') );
516
                let amount_writeoff = parseFloat( $('#amountwrittenoff').attr('value') );
517
                if ( amount_writeoff > amount_outstanding ) {
517
                if ( amount_writeoff > amount_outstanding ) {
518
                    alert(_("You are attemping to writeoff more than the value of the fee."));
518
                    alert(_("You are attempting to writeoff more than the value of the fee."));
519
                    $('#woindivfine').beenSubmitted = false;
519
                    $('#woindivfine').beenSubmitted = false;
520
                } else {
520
                } else {
521
                    prevent_default = 0;
521
                    prevent_default = 0;
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt (-4 / +4 lines)
Lines 82-92 Link Here
82
                    <fieldset class="brief">
82
                    <fieldset class="brief">
83
                        <div class="hint"> Select one or more images to delete. </div>
83
                        <div class="hint"> Select one or more images to delete. </div>
84
                        <table>
84
                        <table>
85
                            [% FOREACH TABL IN TABLE %]
85
                            [% FOREACH TABLE IN TABLEE %]
86
86
87
                                [% IF ( TABL.header_fields ) %]
87
                                [% IF ( TABLE.header_fields ) %]
88
                                    <tr>
88
                                    <tr>
89
                                        [% FOREACH header_field IN TABL.header_fields %]
89
                                        [% FOREACH header_field IN TABLE.header_fields %]
90
                                            [% SWITCH header_field.field_label -%]
90
                                            [% SWITCH header_field.field_label -%]
91
                                            [% CASE "ID" %]
91
                                            [% CASE "ID" %]
92
                                                <th>Image ID</th>
92
                                                <th>Image ID</th>
Lines 101-107 Link Here
101
                                    </tr>
101
                                    </tr>
102
                                [% ELSE %]
102
                                [% ELSE %]
103
                                    <tr>
103
                                    <tr>
104
                                        [% FOREACH text_field IN TABL.text_fields %]
104
                                        [% FOREACH text_field IN TABLE.text_fields %]
105
                                            [% IF ( text_field.select_field ) %]
105
                                            [% IF ( text_field.select_field ) %]
106
                                                <td>
106
                                                <td>
107
                                                    <a
107
                                                    <a
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt (-6 / +6 lines)
Lines 90-96 Link Here
90
                    </tr>
90
                    </tr>
91
                    [% FOREACH loopro IN mainloo.looprow %]
91
                    [% FOREACH loopro IN mainloo.looprow %]
92
                        <tr>
92
                        <tr>
93
                            <td [% IF loopro.hilighted %]class="hilighted"[% END %]> [% loopro.rowtitle | html %]</td>
93
                            <td [% IF loopro.highlighted %]class="highlighted"[% END %]> [% loopro.rowtitle | html %]</td>
94
                            [% FOREACH loopcel IN loopro.loopcell %]
94
                            [% FOREACH loopcel IN loopro.loopcell %]
95
                                <td>
95
                                <td>
96
                                    [% IF ( loopcel.value ) %]
96
                                    [% IF ( loopcel.value ) %]
Lines 128-134 Link Here
128
                        </tr>
128
                        </tr>
129
                    </thead>
129
                    </thead>
130
                    <tbody>
130
                    <tbody>
131
                        <tr class="hilighted">
131
                        <tr class="highlighted">
132
                            <td>Placed on</td>
132
                            <td>Placed on</td>
133
                            <td><input type="radio" name="Line" value="aqbasket.closedate" /></td>
133
                            <td><input type="radio" name="Line" value="aqbasket.closedate" /></td>
134
                            <td><input type="radio" checked="checked" name="Column" value="aqbasket.closedate" /> </td>
134
                            <td><input type="radio" checked="checked" name="Column" value="aqbasket.closedate" /> </td>
Lines 139-145 Link Here
139
                                <span class="hint">[% INCLUDE 'date-format.inc' %]</span>
139
                                <span class="hint">[% INCLUDE 'date-format.inc' %]</span>
140
                            </td>
140
                            </td>
141
                        </tr>
141
                        </tr>
142
                        <tr class="hilighted">
142
                        <tr class="highlighted">
143
                            <td>&nbsp;</td>
143
                            <td>&nbsp;</td>
144
                            <td colspan="2"
144
                            <td colspan="2"
145
                                >group by
145
                                >group by
Lines 176-182 Link Here
176
                            </td>
176
                            </td>
177
                            <td>&nbsp;</td>
177
                            <td>&nbsp;</td>
178
                        </tr>
178
                        </tr>
179
                        <tr class="hilighted">
179
                        <tr class="highlighted">
180
                            <td>Vendor</td>
180
                            <td>Vendor</td>
181
                            <td><input type="radio" checked="checked" name="Line" value="aqbooksellers.name" /></td>
181
                            <td><input type="radio" checked="checked" name="Line" value="aqbooksellers.name" /></td>
182
                            <td><input type="radio" name="Column" value="aqbooksellers.name" /></td>
182
                            <td><input type="radio" name="Column" value="aqbooksellers.name" /></td>
Lines 254-260 Link Here
254
                        </tr>
254
                        </tr>
255
255
256
                        [% IF ( hassort1 ) %]
256
                        [% IF ( hassort1 ) %]
257
                            <tr class="hilighted">
257
                            <tr class="highlighted">
258
                                <td>Sort1</td>
258
                                <td>Sort1</td>
259
                                <td><input type="radio" name="Line" value="aqorders.sort1" /></td>
259
                                <td><input type="radio" name="Line" value="aqorders.sort1" /></td>
260
                                <td><input type="radio" name="Column" value="aqorders.sort1" /></td>
260
                                <td><input type="radio" name="Column" value="aqorders.sort1" /></td>
Lines 269-275 Link Here
269
                            </tr>
269
                            </tr>
270
                        [% END %]
270
                        [% END %]
271
                        [% IF ( hassort2 ) %]
271
                        [% IF ( hassort2 ) %]
272
                            <tr [% IF HglghtSort2 %]class="hilighted"[% END %]>
272
                            <tr [% IF HglghtSort2 %]class="highlighted"[% END %]>
273
                                <td>Sort2</td>
273
                                <td>Sort2</td>
274
                                <td><input type="radio" name="Line" value="aqorders.sort2" /></td>
274
                                <td><input type="radio" name="Line" value="aqorders.sort2" /></td>
275
                                <td><input type="radio" name="Column" value="aqorders.sort2" /></td>
275
                                <td><input type="radio" name="Column" value="aqorders.sort2" /></td>
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt (-1 / +1 lines)
Lines 2076-2082 Link Here
2076
                        }
2076
                        }
2077
                    });
2077
                    });
2078
2078
2079
                    // Remove coresponding cells.
2079
                    // Remove corresponding cells.
2080
                    var kept_results = [];
2080
                    var kept_results = [];
2081
                    $.each(results, function(index, value) {
2081
                    $.each(results, function(index, value) {
2082
                        var line = {};
2082
                        var line = {};
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt (-8 / +8 lines)
Lines 60-68 Link Here
60
                    </tr>
60
                    </tr>
61
                    [% FOREACH loopro IN mainloo.looprow %]
61
                    [% FOREACH loopro IN mainloo.looprow %]
62
                        <tr>
62
                        <tr>
63
                            <td [% IF loopro.hilighted %]class="hilighted"[% END %]> [% loopro.rowtitle | html %]</td>
63
                            <td [% IF loopro.highlighted %]class="highlighted"[% END %]> [% loopro.rowtitle | html %]</td>
64
                            [% FOREACH loopcel IN loopro.loopcell %]
64
                            [% FOREACH loopcel IN loopro.loopcell %]
65
                                <td [% IF loopcel.hilighted %]class="hilighted"[% END %]> [% IF ( loopcel.value ) %][% loopcel.value | html %][% END %] </td>
65
                                <td [% IF loopcel.highlighted %]class="highlighted"[% END %]> [% IF ( loopcel.value ) %][% loopcel.value | html %][% END %] </td>
66
                            [% END %]
66
                            [% END %]
67
                            <td> [% loopro.totalrow | html %] </td>
67
                            <td> [% loopro.totalrow | html %] </td>
68
                        </tr>
68
                        </tr>
Lines 92-98 Link Here
92
                        </tr>
92
                        </tr>
93
                    </thead>
93
                    </thead>
94
                    <tbody>
94
                    <tbody>
95
                        <tr class="hilighted">
95
                        <tr class="highlighted">
96
                            <td>Checkout date</td>
96
                            <td>Checkout date</td>
97
                            <td><input type="radio" name="Line" value="timestamp" /></td>
97
                            <td><input type="radio" name="Line" value="timestamp" /></td>
98
                            <td><input type="radio" checked="checked" name="Column" value="timestamp" /></td>
98
                            <td><input type="radio" checked="checked" name="Column" value="timestamp" /></td>
Lines 105-111 Link Here
105
                                <span class="hint">[% INCLUDE 'date-format.inc' %]</span>
105
                                <span class="hint">[% INCLUDE 'date-format.inc' %]</span>
106
                            </td>
106
                            </td>
107
                        </tr>
107
                        </tr>
108
                        <tr class="hilighted">
108
                        <tr class="highlighted">
109
                            <td>&nbsp;</td>
109
                            <td>&nbsp;</td>
110
                            <td colspan="2"
110
                            <td colspan="2"
111
                                >by
111
                                >by
Lines 144-150 Link Here
144
                            </td>
144
                            </td>
145
                            <td><input type="hidden" name="Filter" value="" /><input type="hidden" name="Filter" value="" /></td>
145
                            <td><input type="hidden" name="Filter" value="" /><input type="hidden" name="Filter" value="" /></td>
146
                        </tr>
146
                        </tr>
147
                        <tr class="hilighted">
147
                        <tr class="highlighted">
148
                            <td>Patron category</td>
148
                            <td>Patron category</td>
149
                            <td><input type="radio" checked="checked" name="Line" value="borrowers.categorycode" /></td>
149
                            <td><input type="radio" checked="checked" name="Line" value="borrowers.categorycode" /></td>
150
                            <td><input type="radio" name="Column" value="borrowers.categorycode" /></td>
150
                            <td><input type="radio" name="Column" value="borrowers.categorycode" /></td>
Lines 170-176 Link Here
170
                                </select>
170
                                </select>
171
                            </td>
171
                            </td>
172
                        </tr>
172
                        </tr>
173
                        <tr class="hilighted">
173
                        <tr class="highlighted">
174
                            <td>Library</td>
174
                            <td>Library</td>
175
                            <td><input type="radio" name="Line" value="branchcode" /></td>
175
                            <td><input type="radio" name="Line" value="branchcode" /></td>
176
                            <td><input type="radio" name="Column" value="branchcode" /></td>
176
                            <td><input type="radio" name="Column" value="branchcode" /></td>
Lines 182-188 Link Here
182
                            </td>
182
                            </td>
183
                        </tr>
183
                        </tr>
184
                        [% IF ( hassort1 ) %]
184
                        [% IF ( hassort1 ) %]
185
                            <tr class="hilighted">
185
                            <tr class="highlighted">
186
                                <td>Sort1</td>
186
                                <td>Sort1</td>
187
                                <td><input type="radio" name="Line" value="borrowers.sort1" /></td>
187
                                <td><input type="radio" name="Line" value="borrowers.sort1" /></td>
188
                                <td><input type="radio" name="Column" value="borrowers.sort1" /></td>
188
                                <td><input type="radio" name="Column" value="borrowers.sort1" /></td>
Lines 197-203 Link Here
197
                            </tr>
197
                            </tr>
198
                        [% END %]
198
                        [% END %]
199
                        [% IF ( hassort2 ) %]
199
                        [% IF ( hassort2 ) %]
200
                            <tr [% IF HglghtSort2 %]class="hilighted"[% END %]>
200
                            <tr [% IF HglghtSort2 %]class="highlighted"[% END %]>
201
                                <td>Sort2</td>
201
                                <td>Sort2</td>
202
                                <td><input type="radio" name="Line" value="borrowers.sort2" /></td>
202
                                <td><input type="radio" name="Line" value="borrowers.sort2" /></td>
203
                                <td><input type="radio" name="Column" value="borrowers.sort2" /></td>
203
                                <td><input type="radio" name="Column" value="borrowers.sort2" /></td>
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt (-1 / +1 lines)
Lines 668-674 Link Here
668
                        <!-- /.rows -->
668
                        <!-- /.rows -->
669
669
670
                        <fieldset class="action">
670
                        <fieldset class="action">
671
                            <input type="hidden" id="returnsuggested" name="returnsuggested" value="[% IF ( returnsuggestedby ) %][% returnsuggestedby | html %][% ELSE %]noone[% END %]" />
671
                            <input type="hidden" id="returnsuggested" name="returnsuggested" value="[% IF ( returnsuggestedby ) %][% returnsuggestedby | html %][% ELSE %]no one[% END %]" />
672
                            [% IF ( suggestionid ) %]
672
                            [% IF ( suggestionid ) %]
673
                                <input type="hidden" name="op" value="cud-save" />
673
                                <input type="hidden" name="op" value="cud-save" />
674
                                [% IF ( need_confirm ) %]
674
                                [% IF ( need_confirm ) %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes-upload.tt (-1 / +1 lines)
Lines 151-157 Link Here
151
            function fnCSVToArray(strData, strDelimiter) {
151
            function fnCSVToArray(strData, strDelimiter) {
152
                // This will parse a delimited string into an array of
152
                // This will parse a delimited string into an array of
153
                // arrays. The default delimiter is the comma, but this
153
                // arrays. The default delimiter is the comma, but this
154
                // can be overriden in the second argument.
154
                // can be overridden in the second argument.
155
155
156
                // Check to see if the delimiter is defined. If not,
156
                // Check to see if the delimiter is defined. If not,
157
                // then default to comma.
157
                // then default to comma.
(-)a/koha-tmpl/intranet-tmpl/prog/js/acq.js (-1 / +1 lines)
Lines 366-372 function checkBudgetParent(budgetId, newBudgetParent) { Link Here
366
    if (result == "1") {
366
    if (result == "1") {
367
        return "- " + __("New budget-parent is beneath budget") + "\n";
367
        return "- " + __("New budget-parent is beneath budget") + "\n";
368
        //     } else if (result == '2') {
368
        //     } else if (result == '2') {
369
        //            return "- New budget-parent has insufficent funds\n";
369
        //            return "- New budget-parent has insufficient funds\n";
370
        //     } else  {
370
        //     } else  {
371
        //              return false;
371
        //              return false;
372
    }
372
    }
(-)a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js (-2 / +2 lines)
Lines 579-585 function UnCloneField(index) { Link Here
579
    if ($(original).hasClass("tag")) {
579
    if ($(original).hasClass("tag")) {
580
        // unclone a field, check if there will remain one field
580
        // unclone a field, check if there will remain one field
581
        var fieldCode = getFieldCode(index);
581
        var fieldCode = getFieldCode(index);
582
        // tag divs with id begining with original field code
582
        // tag divs with id beginning with original field code
583
        var cloneFields = $('.tag[id^="tag_' + fieldCode + '"]');
583
        var cloneFields = $('.tag[id^="tag_' + fieldCode + '"]');
584
        if (cloneFields.length > 1) {
584
        if (cloneFields.length > 1) {
585
            canUnclone = true;
585
            canUnclone = true;
Lines 587-593 function UnCloneField(index) { Link Here
587
    } else {
587
    } else {
588
        // unclone a subfield, check if there will remain one subfield
588
        // unclone a subfield, check if there will remain one subfield
589
        var subfieldCode = getFieldAndSubfieldCode(index);
589
        var subfieldCode = getFieldAndSubfieldCode(index);
590
        // subfield divs of same field with id begining with original field and subfield field code
590
        // subfield divs of same field with id beginning with original field and subfield field code
591
        var cloneSubfields = $(original)
591
        var cloneSubfields = $(original)
592
            .parent()
592
            .parent()
593
            .children('.subfield_line[id^="subfield' + subfieldCode + '"]');
593
            .children('.subfield_line[id^="subfield' + subfieldCode + '"]');
(-)a/koha-tmpl/intranet-tmpl/prog/js/datatables.js (-1 / +1 lines)
Lines 1282-1288 function update_search_description( Link Here
1282
     *                                                allows setting the 'comparison operator' used in searches
1282
     *                                                allows setting the 'comparison operator' used in searches
1283
     *                                                Supports `contains`, `starts_with`, `ends_with` and `exact` match
1283
     *                                                Supports `contains`, `starts_with`, `ends_with` and `exact` match
1284
     * @param  {string}  [options.columns.*.type      Data type the field is stored in so we may impose some additional
1284
     * @param  {string}  [options.columns.*.type      Data type the field is stored in so we may impose some additional
1285
     *                                                manipulation to search strings. Supported types are currenlty 'date'
1285
     *                                                manipulation to search strings. Supported types are currently 'date'
1286
     * @param  {Object}  table_settings               The arrayref as returned by TableSettings.GetTableSettings function
1286
     * @param  {Object}  table_settings               The arrayref as returned by TableSettings.GetTableSettings function
1287
     *                                                available from the columns_settings template toolkit include
1287
     *                                                available from the columns_settings template toolkit include
1288
     * @param  {Boolean} add_filters                  Add a filters row as the top row of the table
1288
     * @param  {Boolean} add_filters                  Add a filters row as the top row of the table
(-)a/koha-tmpl/intranet-tmpl/prog/js/ill-batch-modal.js (-8 / +8 lines)
Lines 140-146 Link Here
140
140
141
    // The element that potentially holds the ID of the batch
141
    // The element that potentially holds the ID of the batch
142
    // we're working with
142
    // we're working with
143
    var idEl = document.getElementById("ill-batch-details");
143
    var idle = document.getElementById("ill-batch-details");
144
    var batchId = null;
144
    var batchId = null;
145
    var backend = null;
145
    var backend = null;
146
146
Lines 157-164 Link Here
157
        $("#ill-batch-modal").on("hidden.bs.modal", function () {
157
        $("#ill-batch-modal").on("hidden.bs.modal", function () {
158
            // Reset our state when we close the modal
158
            // Reset our state when we close the modal
159
            // TODO: need to also reset progress bar and already processed identifiers
159
            // TODO: need to also reset progress bar and already processed identifiers
160
            delete idEl.dataset.batchId;
160
            delete idle.dataset.batchId;
161
            delete idEl.dataset.backend;
161
            delete idle.dataset.backend;
162
            batchId = null;
162
            batchId = null;
163
            tableEl.style.display = "none";
163
            tableEl.style.display = "none";
164
            tableContent.data = [];
164
            tableContent.data = [];
Lines 176-183 Link Here
176
    }
176
    }
177
177
178
    function init() {
178
    function init() {
179
        batchId = idEl.dataset.batchId;
179
        batchId = idle.dataset.batchId;
180
        backend = idEl.dataset.backend;
180
        backend = idle.dataset.backend;
181
        emptyBatch.backend = backend;
181
        emptyBatch.backend = backend;
182
        progressTotals.data = {
182
        progressTotals.data = {
183
            total: 0,
183
            total: 0,
Lines 714-722 Link Here
714
        var tabIdentifiers = tableContent.data.map(function (tabId) {
714
        var tabIdentifiers = tableContent.data.map(function (tabId) {
715
            return tabId.value;
715
            return tabId.value;
716
        });
716
        });
717
        var notInTable = deduped.filter(function (ded) {
717
        var notInTable = deaduped.filter(function (dead) {
718
            if (!tabIdentifiers.includes(ded.value)) {
718
            if (!tabIdentifiers.includes(dead.value)) {
719
                return ded;
719
                return dead;
720
            }
720
            }
721
        });
721
        });
722
        if (notInTable.length > 0) {
722
        if (notInTable.length > 0) {
(-)a/koha-tmpl/intranet-tmpl/prog/js/ill-batch.js (-3 / +3 lines)
Lines 3-12 Link Here
3
    // If we're working with an existing batch, set the ID so the
3
    // If we're working with an existing batch, set the ID so the
4
    // modal can access it
4
    // modal can access it
5
    window.openBatchModal = function (id, backend) {
5
    window.openBatchModal = function (id, backend) {
6
        var idEl = document.getElementById("ill-batch-details");
6
        var idle = document.getElementById("ill-batch-details");
7
        idEl.dataset.backend = backend;
7
        idle.dataset.backend = backend;
8
        if (id) {
8
        if (id) {
9
            idEl.dataset.batchId = id;
9
            idle.dataset.batchId = id;
10
        }
10
        }
11
        $("#ill-batch-modal").modal("show");
11
        $("#ill-batch-modal").modal("show");
12
    };
12
    };
(-)a/koha-tmpl/intranet-tmpl/prog/js/localcovers.js (-1 / +1 lines)
Lines 14-20 KOHA.LocalCover = { Link Here
14
     * or
14
     * or
15
     *    <div title="biblionumber" id="isbn" class="openlibrary-thumbnail-preview"></div>
15
     *    <div title="biblionumber" id="isbn" class="openlibrary-thumbnail-preview"></div>
16
     * and run a search with all collected isbns to Open Library Book Search.
16
     * and run a search with all collected isbns to Open Library Book Search.
17
     * The result is asynchronously returned by OpenLibrary and catched by
17
     * The result is asynchronously returned by OpenLibrary and caught by
18
     * olCallBack().
18
     * olCallBack().
19
     */
19
     */
20
    GetCoverFromBibnumber: function (uselink) {
20
    GetCoverFromBibnumber: function (uselink) {
(-)a/koha-tmpl/intranet-tmpl/prog/js/marc_subfields_structure.js (-1 / +1 lines)
Lines 187-193 function populateHiddenCheckboxes(tab) { Link Here
187
    // read the serialized value
187
    // read the serialized value
188
    var hidden_value = $("#hidden-" + tab).val();
188
    var hidden_value = $("#hidden-" + tab).val();
189
    var hidden_protected = $("#hidden-" + tab).attr("data-koha-protected");
189
    var hidden_protected = $("#hidden-" + tab).attr("data-koha-protected");
190
    // deafult to false
190
    // default to false
191
    var opac_checked = false;
191
    var opac_checked = false;
192
    var intranet_checked = false;
192
    var intranet_checked = false;
193
    var editor_checked = false;
193
    var editor_checked = false;
(-)a/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js (-1 / +1 lines)
Lines 139-145 $("#placeBookingModal").on("show.bs.modal", function (e) { Link Here
139
    // Note: For now, we apply the pickup library rules for issuelength, renewalsallowed and renewalperiod.
139
    // Note: For now, we apply the pickup library rules for issuelength, renewalsallowed and renewalperiod.
140
    // This effectively makes these circulation rules hard coded to CircControl: ItemHomeLibrary + HomeOrHolding: holdingbranch
140
    // This effectively makes these circulation rules hard coded to CircControl: ItemHomeLibrary + HomeOrHolding: holdingbranch
141
    // Whilst it would be beneficial to make this follow those rules more closely, this would require some significant thinking
141
    // Whilst it would be beneficial to make this follow those rules more closely, this would require some significant thinking
142
    // around how to best display this in the calender component for the 'Any item' case.
142
    // around how to best display this in the calendar component for the 'Any item' case.
143
    function getCirculationRules() {
143
    function getCirculationRules() {
144
        let rules_url = "/api/v1/circulation_rules";
144
        let rules_url = "/api/v1/circulation_rules";
145
        if (booking_patron && pickup_library_id && booking_itemtype_id) {
145
        if (booking_patron && pickup_library_id && booking_itemtype_id) {
(-)a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesFormAdd.vue (-1 / +1 lines)
Lines 515-521 export default { Link Here
515
            delete title.title_id;
515
            delete title.title_id;
516
            delete title.biblio_id;
516
            delete title.biblio_id;
517
517
518
            // Cannot use the map/keepAttrs because of the reserved keywork 'package'
518
            // Cannot use the map/keepAttrs because of the reserved keyword 'package'
519
            title.resources.forEach(function (e) {
519
            title.resources.forEach(function (e) {
520
                delete e.package;
520
                delete e.package;
521
                delete e.resource_id;
521
                delete e.resource_id;
(-)a/koha-tmpl/opac-tmpl/bootstrap/en/includes/js-date-format.inc (-1 / +1 lines)
Lines 31-37 Link Here
31
        };
31
        };
32
32
33
        /*
33
        /*
34
         * A JS equivilent of the KohaDates TT Plugin. Passed an rfc3339 formatted date string,
34
         * A JS equivalent of the KohaDates TT Plugin. Passed an rfc3339 formatted date string,
35
         * or JS Date, the function will return a date string formatted as per the koha instance config.
35
         * or JS Date, the function will return a date string formatted as per the koha instance config.
36
         * Optionally accepts a dateformat parameter to allow override of the configured output format
36
         * Optionally accepts a dateformat parameter to allow override of the configured output format
37
         * as well as a 'withtime' boolean denoting whether to include time or not in the output string.
37
         * as well as a 'withtime' boolean denoting whether to include time or not in the output string.
(-)a/koha-tmpl/opac-tmpl/bootstrap/en/includes/subtypes_unimarc.inc (-1 / +1 lines)
Lines 26-32 Link Here
26
            <option value="Material-type:h">hand-written</option>
26
            <option value="Material-type:h">hand-written</option>
27
            <option value="Material-type:i">multimedia</option>
27
            <option value="Material-type:i">multimedia</option>
28
            <option value="Material-type:j">mini-print</option>
28
            <option value="Material-type:j">mini-print</option>
29
            <option value="Material-type:s">electronic ressource</option>
29
            <option value="Material-type:s">electronic resource</option>
30
            <option value="Material-type:t">microform</option>
30
            <option value="Material-type:t">microform</option>
31
            <option value="Material-type:z">other form of textual material</option>
31
            <option value="Material-type:z">other form of textual material</option>
32
        </select>
32
        </select>
(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt (-1 / +1 lines)
Lines 454-460 Link Here
454
                                        <option value="ctype:j">Patent document</option>
454
                                        <option value="ctype:j">Patent document</option>
455
                                        <option value="ctype:k">Discographies</option>
455
                                        <option value="ctype:k">Discographies</option>
456
                                        <option value="ctype:l">Legislation</option>
456
                                        <option value="ctype:l">Legislation</option>
457
                                        <option value="ctype:m">Theses</option>
457
                                        <option value="ctype:m">FIXME CODESPELL (Theses ==> These, Thesis)</option>
458
                                        <option value="ctype:n">Surveys</option>
458
                                        <option value="ctype:n">Surveys</option>
459
                                        <option value="ctype:o">Reviews</option>
459
                                        <option value="ctype:o">Reviews</option>
460
                                        <option value="ctype:p">Programmed texts</option>
460
                                        <option value="ctype:p">Programmed texts</option>
(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt (-8 / +8 lines)
Lines 76-95 Link Here
76
                                    </tr>
76
                                    </tr>
77
                                </thead>
77
                                </thead>
78
                                <tbody>
78
                                <tbody>
79
                                    [% FOREACH resul IN result %]
79
                                    [% FOREACH result IN resultt %]
80
                                        <tr>
80
                                        <tr>
81
                                            <td>
81
                                            <td>
82
                                                [% IF resul.html %]
82
                                                [% IF result.html %]
83
                                                    [% resul.html | $raw %]
83
                                                    [% result.html | $raw %]
84
                                                [% ELSE %]
84
                                                [% ELSE %]
85
                                                    [% PROCESS authresult summary=resul.summary authid=resul.authid %]
85
                                                    [% PROCESS authresulttt summary=resultt.summary authid=resultt.authid %]
86
                                                [% END %]
86
                                                [% END %]
87
                                            </td>
87
                                            </td>
88
                                            <td><a href="/cgi-bin/koha/opac-authoritiesdetail.pl?authid=[% resul.authid | uri %]">Details</a> </td><td>[% resul.authtype | html %]</td>
88
                                            <td><a href="/cgi-bin/koha/opac-authoritiesdetail.pl?authid=[% resultt.authid | uri %]">Details</a> </td><td>[% resultt.authtype | html %]</td>
89
                                            [% UNLESS ( resul.isEDITORS ) %]
89
                                            [% UNLESS ( result.isEDITORS ) %]
90
                                                <td>
90
                                                <td>
91
                                                    [% IF resul.used > 0 %]
91
                                                    [% IF result.used > 0 %]
92
                                                        <a href="/cgi-bin/koha/opac-search.pl?type=opac&amp;op=do_search&amp;q=an,phr:[% resul.authid | uri %]">[% resul.used | html %] [% tn('record', 'records', resul.used ) | html %]</a>
92
                                                        <a href="/cgi-bin/koha/opac-search.pl?type=opac&amp;op=do_search&amp;q=an,phr:[% resulttt.authid | uri %]">[% resulttt.used | html %] [% tn('record', 'records', resulttt.used ) | html %]</a>
93
                                                    [% ELSE %]
93
                                                    [% ELSE %]
94
                                                        0 records
94
                                                        0 records
95
                                                    [% END %]
95
                                                    [% END %]
(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt (-1 / +1 lines)
Lines 662-668 Link Here
662
                    $("#reqspecific_" + id).attr("disabled", "disabled");
662
                    $("#reqspecific_" + id).attr("disabled", "disabled");
663
                    $("#reqany_" + id).attr("disabled", "disabled");
663
                    $("#reqany_" + id).attr("disabled", "disabled");
664
                }
664
                }
665
                // expand or collaspe the items block
665
                // expand or collapse the items block
666
                toggle_copiesrow(id);
666
                toggle_copiesrow(id);
667
            });
667
            });
668
668
(-)a/koha-tmpl/opac-tmpl/bootstrap/js/autofill.js (-2 / +2 lines)
Lines 199-205 Link Here
199
    };
199
    };
200
200
201
    /*
201
    /*
202
     * @fields object: Google Books API item propreties map for
202
     * @fields object: Google Books API item properties map for
203
     *                 mapping against a target element. Expected
203
     *                 mapping against a target element. Expected
204
     *                 type:
204
     *                 type:
205
     *                 {
205
     *                 {
Lines 210-216 Link Here
210
     *                 }
210
     *                 }
211
     *
211
     *
212
     *                 "target" is optional and if specified alone (i.e no
212
     *                 "target" is optional and if specified alone (i.e no
213
     *                 handle proprety) autofill will automaticly fill this
213
     *                 handle property) autofill will automatically fill this
214
     *                 target element with returned data.
214
     *                 target element with returned data.
215
     *
215
     *
216
     *                 "handle" is optional and will be called when ajax request
216
     *                 "handle" is optional and will be called when ajax request
(-)a/koha-tmpl/opac-tmpl/bootstrap/js/datatables.js (-1 / +1 lines)
Lines 275-281 function _dt_visibility(table_settings, table_dt) { Link Here
275
     *                                                allows setting the 'comparison operator' used in searches
275
     *                                                allows setting the 'comparison operator' used in searches
276
     *                                                Supports `contains`, `starts_with`, `ends_with` and `exact` match
276
     *                                                Supports `contains`, `starts_with`, `ends_with` and `exact` match
277
     * @param  {string}  [options.columns.*.type      Data type the field is stored in so we may impose some additional
277
     * @param  {string}  [options.columns.*.type      Data type the field is stored in so we may impose some additional
278
     *                                                manipulation to search strings. Supported types are currenlty 'date'
278
     *                                                manipulation to search strings. Supported types are currently 'date'
279
     * @param  {Object}  table_settings               The arrayref as returned by TableSettings.GetTableSettings function
279
     * @param  {Object}  table_settings               The arrayref as returned by TableSettings.GetTableSettings function
280
     *                                                available from the columns_settings template toolkit include
280
     *                                                available from the columns_settings template toolkit include
281
     * @return {Object}                               The dataTables instance
281
     * @return {Object}                               The dataTables instance
(-)a/koha-tmpl/opac-tmpl/bootstrap/js/google-jackets.js (-1 / +1 lines)
Lines 13-19 KOHA.Google = { Link Here
13
     * or
13
     * or
14
     *    <div title="biblionumber" id="isbn" class="gbs-thumbnail-preview"></div>
14
     *    <div title="biblionumber" id="isbn" class="gbs-thumbnail-preview"></div>
15
     * and run a search with all collected isbns to Google Book Search.
15
     * and run a search with all collected isbns to Google Book Search.
16
     * The result is asynchronously returned by Google and catched by
16
     * The result is asynchronously returned by Google and caught by
17
     * gbsCallBack().
17
     * gbsCallBack().
18
     */
18
     */
19
    GetCoverFromIsbn: function (newWindow) {
19
    GetCoverFromIsbn: function (newWindow) {
(-)a/koha-tmpl/opac-tmpl/bootstrap/js/localcovers.js (-1 / +1 lines)
Lines 13-19 KOHA.LocalCover = { Link Here
13
     * or
13
     * or
14
     *    <div title="biblionumber" id="isbn" class="openlibrary-thumbnail-preview"></div>
14
     *    <div title="biblionumber" id="isbn" class="openlibrary-thumbnail-preview"></div>
15
     * and run a search with all collected isbns to Open Library Book Search.
15
     * and run a search with all collected isbns to Open Library Book Search.
16
     * The result is asynchronously returned by OpenLibrary and catched by
16
     * The result is asynchronously returned by OpenLibrary and caught by
17
     * olCallBack().
17
     * olCallBack().
18
     */
18
     */
19
    GetCoverFromBibnumber: function () {
19
    GetCoverFromBibnumber: function () {
(-)a/koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js (-1 / +1 lines)
Lines 13-19 KOHA.OpenLibrary = new (function () { Link Here
13
     * or
13
     * or
14
     *    <div title="biblionumber" id="isbn" class="openlibrary-thumbnail-preview"></div>
14
     *    <div title="biblionumber" id="isbn" class="openlibrary-thumbnail-preview"></div>
15
     * and run a search with all collected isbns to Open Library Book Search.
15
     * and run a search with all collected isbns to Open Library Book Search.
16
     * The result is asynchronously returned by OpenLibrary and catched by
16
     * The result is asynchronously returned by OpenLibrary and caught by
17
     * olCallBack().
17
     * olCallBack().
18
     */
18
     */
19
    this.GetCoverFromIsbn = function () {
19
    this.GetCoverFromIsbn = function () {
(-)a/members/statistics.pl (-1 / +1 lines)
Lines 115-121 sub add_actual_state { Link Here
115
=head2 build_array
115
=head2 build_array
116
116
117
  Build a new array containing values of hashes.
117
  Build a new array containing values of hashes.
118
  It used by template whitch display silly values.
118
  It used by template which display silly values.
119
  ex:
119
  ex:
120
    $array = [
120
    $array = [
121
      {
121
      {
(-)a/misc/batchDeleteUnusedSubfields.pl (-1 / +1 lines)
Lines 50-56 foreach my $tag ( sort keys( %{$tags} ) ) { Link Here
50
        next if $subfield eq "tab";
50
        next if $subfield eq "tab";
51
51
52
        # DO NOT drop biblionumber, biblioitemnumber and itemnumber.
52
        # DO NOT drop biblionumber, biblioitemnumber and itemnumber.
53
        # they are stored internally, and are mapped to tab -1. This script must keep them or it will completly break Koha DB !!!
53
        # they are stored internally, and are mapped to tab -1. This script must keep them or it will completely break Koha DB !!!
54
        next if ( $tags->{$tag}->{$subfield}->{kohafield} eq "biblio.biblionumber" );
54
        next if ( $tags->{$tag}->{$subfield}->{kohafield} eq "biblio.biblionumber" );
55
        next if ( $tags->{$tag}->{$subfield}->{kohafield} eq "biblioitems.biblioitemnumber" );
55
        next if ( $tags->{$tag}->{$subfield}->{kohafield} eq "biblioitems.biblioitemnumber" );
56
        next if ( $tags->{$tag}->{$subfield}->{kohafield} eq "items.itemnumber" );
56
        next if ( $tags->{$tag}->{$subfield}->{kohafield} eq "items.itemnumber" );
(-)a/misc/bin/connexion_import_daemon.pl (-4 / +4 lines)
Lines 62-72 Config file format: Link Here
62
                      add_only_for_matches, add_only_for_new or ignore
62
                      add_only_for_matches, add_only_for_new or ignore
63
  import_mode    - stage or direct
63
  import_mode    - stage or direct
64
  framework      - to be used if import_mode is direct, if blank, will use default
64
  framework      - to be used if import_mode is direct, if blank, will use default
65
  connexion_user      - User sent from connexion client
65
  connection_user      - User sent from connection client
66
  connexion_password  - Password sent from connexion client
66
  connection_password  - Password sent from connection client
67
67
68
  Note: If connexion parameters are not defined request authentication will not be checked
68
  Note: If connection parameters are not defined request authentication will not be checked
69
  You should specify a different user for connexion to protect the Koha credentials
69
  You should specify a different user for connection to protect the Koha credentials
70
70
71
  All process related parameters (all but ip and port) have default values as
71
  All process related parameters (all but ip and port) have default values as
72
  per Koha import process.
72
  per Koha import process.
(-)a/misc/cronjobs/advance_notices.pl (-1 / +1 lines)
Lines 141-147 program. They may be redirected to a file if desired. Link Here
141
=head2 Templates
141
=head2 Templates
142
142
143
Templates can contain variables enclosed in double angle brackets like
143
Templates can contain variables enclosed in double angle brackets like
144
E<lt>E<lt>thisE<gt>E<gt>. Those variables will be replaced with values
144
E<lt>E<lt>FIXME CODESPELL (thisE ==> these, this)<gt>E<gt>. Those variables will be replaced with values
145
specific to the overdue items or relevant patron. Available variables
145
specific to the overdue items or relevant patron. Available variables
146
are:
146
are:
147
147
(-)a/misc/cronjobs/cart_to_shelf.pl (-1 / +1 lines)
Lines 44-50 GetOptions( 'h|hours=s' => \$hours, ); Link Here
44
44
45
my $usage = << 'ENDUSAGE';
45
my $usage = << 'ENDUSAGE';
46
cart_to_shelf.pl: This cron script will set any item of the location CART ( Shelving Cart ) to it's original shelving location
46
cart_to_shelf.pl: This cron script will set any item of the location CART ( Shelving Cart ) to it's original shelving location
47
                 after the given numer of hours has passed.
47
                 after the given number of hours has passed.
48
48
49
This script takes the following parameters :
49
This script takes the following parameters :
50
50
(-)a/misc/cronjobs/cloud-kw.pl (-3 / +3 lines)
Lines 311-317 cloud-kw.pl - Creates HTML keywords clouds from Koha Zebra Indexes Link Here
311
311
312
=item cloud-kw.pl [--verbose|--help] --conf=F<cloud.conf> 
312
=item cloud-kw.pl [--verbose|--help] --conf=F<cloud.conf> 
313
313
314
Creates multiple HTML files containing kewords cloud with top terms sorted
314
Creates multiple HTML files containing keywords cloud with top terms sorted
315
by their logarithmic weight.
315
by their logarithmic weight.
316
F<cloud.conf> is a YAML configuration file driving cloud generation
316
F<cloud.conf> is a YAML configuration file driving cloud generation
317
process.
317
process.
Lines 346-352 Configuration file looks like that: Link Here
346
  KohaConf: /home/koha/mylibray/etc/koha-conf.xml
346
  KohaConf: /home/koha/mylibray/etc/koha-conf.xml
347
  # Zebra index to scan
347
  # Zebra index to scan
348
  ZebraIndex: Author
348
  ZebraIndex: Author
349
  # Koha index used to link found kewords with an opac search URL
349
  # Koha index used to link found keywords with an opac search URL
350
  KohaIndex: au
350
  KohaIndex: au
351
  # Number of top keyword to use for the cloud
351
  # Number of top keyword to use for the cloud
352
  Count: 50
352
  Count: 50
Lines 366-372 Configuration file looks like that: Link Here
366
366
367
=head1 IMPROVEMENTS
367
=head1 IMPROVEMENTS
368
368
369
Generated top terms have more informations than those outputted from
369
Generated top terms have more information than those outputted from
370
the time being. Some parameters could be easily added to improve
370
the time being. Some parameters could be easily added to improve
371
this script:
371
this script:
372
372
(-)a/misc/cronjobs/create_koc_db.pl (-1 / +1 lines)
Lines 188-194 pass in the filename that we're considering using for the SQLite db. Link Here
188
188
189
returns true if we can use it.
189
returns true if we can use it.
190
190
191
returns false if we can't. For example, if it alredy exists and we
191
returns false if we can't. For example, if it already exists and we
192
don't have --force or don't have permissions to unlink it.
192
don't have --force or don't have permissions to unlink it.
193
193
194
=cut
194
=cut
(-)a/misc/cronjobs/fines.pl (-2 / +2 lines)
Lines 3-9 Link Here
3
#  This script loops through each overdue item, determines the fine,
3
#  This script loops through each overdue item, determines the fine,
4
#  and updates the total amount of fines due by each user.  It relies on
4
#  and updates the total amount of fines due by each user.  It relies on
5
#  the existence of /tmp/fines, which is created by ???
5
#  the existence of /tmp/fines, which is created by ???
6
# Doesn't really rely on it, it relys on being able to write to /tmp/
6
# Doesn't really rely on it, it relies on being able to write to /tmp/
7
# It creates the fines file
7
# It creates the fines file
8
#
8
#
9
#  This script is meant to be run nightly out of cron.
9
#  This script is meant to be run nightly out of cron.
Lines 71-77 or not calculated ("Don't calculate"). Link Here
71
This script has the following parameters :
71
This script has the following parameters :
72
    -h --help: this message
72
    -h --help: this message
73
    -l --log: log the output to a file (optional if the -o parameter is given)
73
    -l --log: log the output to a file (optional if the -o parameter is given)
74
    -o --out:  ouput directory for logs (defaults to env or /tmp if !exist)
74
    -o --out:  output directory for logs (defaults to env or /tmp if !exist)
75
    -v --verbose
75
    -v --verbose
76
    -m --maxdays: how many days back of overdues to process
76
    -m --maxdays: how many days back of overdues to process
77
    -i --verifyissue: verify the issue before updating the fine in case the
77
    -i --verifyissue: verify the issue before updating the fine in case the
(-)a/misc/cronjobs/import_webservice_batch.pl (-1 / +1 lines)
Lines 61-67 Specify frameworkcode when overlaying records. Current framework is preserved i Link Here
61
61
62
=head1 DESCRIPTION
62
=head1 DESCRIPTION
63
63
64
This script is designed to import batches staged by webservices (e.g. connexion).
64
This script is designed to import batches staged by webservices (e.g. connection).
65
65
66
=head1 USAGE EXAMPLES
66
=head1 USAGE EXAMPLES
67
67
(-)a/misc/cronjobs/membership_expiry.pl (-1 / +1 lines)
Lines 142-148 not the borrower has an email address. This can be useful for libraries that Link Here
142
prefer to deal with print notices.
142
prefer to deal with print notices.
143
143
144
Notices can contain variables enclosed in double angle brackets like
144
Notices can contain variables enclosed in double angle brackets like
145
E<lt>E<lt>thisE<gt>E<gt>. Those variables will be replaced with values
145
E<lt>E<lt>FIXME CODESPELL (thisE ==> these, this)<gt>E<gt>. Those variables will be replaced with values
146
specific to the soon expiring members.
146
specific to the soon expiring members.
147
Available variables are:
147
Available variables are:
148
148
(-)a/misc/cronjobs/overdue_notices.pl (-1 / +1 lines)
Lines 227-233 program. They may be redirected to a file if desired. Link Here
227
=head2 Templates
227
=head2 Templates
228
228
229
Templates can contain variables enclosed in double angle brackets like
229
Templates can contain variables enclosed in double angle brackets like
230
E<lt>E<lt>thisE<gt>E<gt>. Those variables will be replaced with values
230
E<lt>E<lt>FIXME CODESPELL (thisE ==> these, this)<gt>E<gt>. Those variables will be replaced with values
231
specific to the overdue items or relevant patron. Available variables
231
specific to the overdue items or relevant patron. Available variables
232
are:
232
are:
233
233
(-)a/misc/cronjobs/update_patrons_category.pl (-2 / +2 lines)
Lines 109-119 Supply a number and only account with fines under this number will be updated. Link Here
109
109
110
=item B<--regbefore=date | -rb=date>
110
=item B<--regbefore=date | -rb=date>
111
111
112
Enter a date in ISO format YYYY-MM-DD and only patrons registered before this date wil be updated.
112
Enter a date in ISO format YYYY-MM-DD and only patrons registered before this date FIXME CODESPELL (wil ==> will, well) be updated.
113
113
114
=item B<--regafter=date | -ra=date>
114
=item B<--regafter=date | -ra=date>
115
115
116
Enter a date in ISO format YYYY-MM-DD and only patrons registered after this date wil be updated.
116
Enter a date in ISO format YYYY-MM-DD and only patrons registered after this date FIXME CODESPELL (wil ==> will, well) be updated.
117
117
118
=item B<--field column=value | -d column=value>
118
=item B<--field column=value | -d column=value>
119
119
(-)a/misc/devel/codespell.pl (-1 / +1 lines)
Lines 35-41 while ( my ( $i, $file ) = each @files ) { Link Here
35
        my @lines = split "\n", $output;
35
        my @lines = split "\n", $output;
36
        for my $line (@lines) {
36
        for my $line (@lines) {
37
37
38
            # C4/Auth.pm:144: authentification ==> authentication
38
            # C4/Auth.pm:144: authentication ==> authentication
39
            if ( $line =~ m{(?<file>[^:]*):(?<line>\d+): (?<pattern>\w+) ==> (?<replace>.*)} ) {
39
            if ( $line =~ m{(?<file>[^:]*):(?<line>\d+): (?<pattern>\w+) ==> (?<replace>.*)} ) {
40
                my $line_number = $+{line} - 1;
40
                my $line_number = $+{line} - 1;
41
                my $pattern     = $+{pattern};
41
                my $pattern     = $+{pattern};
(-)a/misc/devel/get_prepared_letter.pl (-3 / +3 lines)
Lines 51-67 The letter language (es-ES, fr-FR, ...) Link Here
51
=item B<--repeat REPEAT>
51
=item B<--repeat REPEAT>
52
52
53
A JSON formatted string that will be used as repeat parameter. See
53
A JSON formatted string that will be used as repeat parameter. See
54
documentation of GetPreparedLetter for more informations.
54
documentation of GetPreparedLetter for more information.
55
55
56
=item B<--tables TABLES>
56
=item B<--tables TABLES>
57
57
58
A JSON formatted string that will be used as tables parameter. See
58
A JSON formatted string that will be used as tables parameter. See
59
documentation of GetPreparedLetter for more informations.
59
documentation of GetPreparedLetter for more information.
60
60
61
=item B<--loops LOOPS>
61
=item B<--loops LOOPS>
62
62
63
A JSON formatted string that will be used as loops parameter. See
63
A JSON formatted string that will be used as loops parameter. See
64
documentation of GetPreparedLetter for more informations.
64
documentation of GetPreparedLetter for more information.
65
65
66
=back
66
=back
67
67
(-)a/misc/export_borrowers.pl (-2 / +2 lines)
Lines 34-40 sub print_usage { Link Here
34
    print <<USAGE;
34
    print <<USAGE;
35
35
36
$basename
36
$basename
37
    Export patron informations in CSV format.
37
    Export patron information in CSV format.
38
    It prints to standard output. Use redirection to save CSV in a file.
38
    It prints to standard output. Use redirection to save CSV in a file.
39
39
40
Usage:
40
Usage:
Lines 97-103 unless ($separator) { Link Here
97
my $csv = Text::CSV->new( { sep_char => $separator, binary => 1, formula => 'empty' } );
97
my $csv = Text::CSV->new( { sep_char => $separator, binary => 1, formula => 'empty' } );
98
98
99
# If the user did not specify any field to export, we assume they want them all
99
# If the user did not specify any field to export, we assume they want them all
100
# We retrieve the first borrower informations to get field names
100
# We retrieve the first borrower information to get field names
101
my ($borrowernumber) = $sth->fetchrow_array or die "No borrower to export";
101
my ($borrowernumber) = $sth->fetchrow_array or die "No borrower to export";
102
my $patron           = Koha::Patrons->find($borrowernumber);               # FIXME Now is_expired is no longer available
102
my $patron           = Koha::Patrons->find($borrowernumber);               # FIXME Now is_expired is no longer available
103
    # We will have to use Koha::Patron and allow method calls
103
    # We will have to use Koha::Patron and allow method calls
(-)a/misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl (-4 / +4 lines)
Lines 48-54 $verbose and print "================================\n"; Link Here
48
$date_created_marc = '099c' unless $date_created_marc;
48
$date_created_marc = '099c' unless $date_created_marc;
49
my ( $c_field, $c_subfield ) = _read_marc_code($date_created_marc);
49
my ( $c_field, $c_subfield ) = _read_marc_code($date_created_marc);
50
die "date-created-marc '$date_created_marc' is not correct." unless $c_field;
50
die "date-created-marc '$date_created_marc' is not correct." unless $c_field;
51
die "date-created-marc field is greated that 009, it should have a subfield."
51
die "date-created-marc field is FIXME CODESPELL (greated ==> greater, grated, graded) that 009, it should have a subfield."
52
    if ( $c_field > 9 && !defined $c_subfield );
52
    if ( $c_field > 9 && !defined $c_subfield );
53
die "date-created-marc field is lower that 010, it should not have a subfield."
53
die "date-created-marc field is lower that 010, it should not have a subfield."
54
    if ( $c_field < 10 && defined $c_subfield );
54
    if ( $c_field < 10 && defined $c_subfield );
Lines 62-68 if ($verbose) { Link Here
62
$date_modified_marc = '099d' unless $date_modified_marc;
62
$date_modified_marc = '099d' unless $date_modified_marc;
63
my ( $m_field, $m_subfield ) = _read_marc_code($date_modified_marc);
63
my ( $m_field, $m_subfield ) = _read_marc_code($date_modified_marc);
64
die "date-modified-marc '$date_modified_marc' is not correct." unless $m_field;
64
die "date-modified-marc '$date_modified_marc' is not correct." unless $m_field;
65
die "date-modified-marc field is greated that 009, it should have a subfield."
65
die "date-modified-marc field is FIXME CODESPELL (greated ==> greater, grated, graded) that 009, it should have a subfield."
66
    if ( $m_field > 9 && !defined $m_subfield );
66
    if ( $m_field > 9 && !defined $m_subfield );
67
die "date-modified-marc field is lower that 010, it should not have a subfield."
67
die "date-modified-marc field is lower that 010, it should not have a subfield."
68
    if ( $m_field < 10 && defined $m_subfield );
68
    if ( $m_field < 10 && defined $m_subfield );
Lines 175-181 sub updateMarc { Link Here
175
        }
175
        }
176
    }
176
    }
177
177
178
    # apply to databse
178
    # apply to database
179
    if ( &ModBiblio( $biblio, $id, $frameworkcode ) ) {
179
    if ( &ModBiblio( $biblio, $id, $frameworkcode ) ) {
180
        return 1;
180
        return 1;
181
    }
181
    }
Lines 216-222 sub process { Link Here
216
if ( lc( C4::Context->preference('marcflavour') ) eq "unimarc" ) {
216
if ( lc( C4::Context->preference('marcflavour') ) eq "unimarc" ) {
217
    $verbose
217
    $verbose
218
        and !$run
218
        and !$run
219
        and print "*** Not in run mode, modifications will not be applyed ***\n";
219
        and print "*** Not in run mode, modifications will not be applied ***\n";
220
220
221
    $verbose and print "================================\n";
221
    $verbose and print "================================\n";
222
    process();
222
    process();
(-)a/misc/migration_tools/22_to_30/move_marc_to_authheader.pl (-1 / +1 lines)
Lines 51-57 while ( my ( $authid, $authtypecode ) = $sth->fetchrow ) { Link Here
51
        $record->insert_fields_ordered( MARC::Field->new( '001', $authid ) );
51
        $record->insert_fields_ordered( MARC::Field->new( '001', $authid ) );
52
    }
52
    }
53
53
54
    #Force UTF-8 in record leaded
54
    #Force UTF-8 in record FIXME CODESPELL (leaded ==> led, lead)
55
    $record->encoding('UTF-8');
55
    $record->encoding('UTF-8');
56
56
57
    #     warn "REC : ".$record->as_formatted;
57
    #     warn "REC : ".$record->as_formatted;
(-)a/misc/migration_tools/build_oai_sets.pl (-5 / +5 lines)
Lines 20-27 Link Here
20
=head1 DESCRIPTION
20
=head1 DESCRIPTION
21
21
22
This script build OAI-PMH sets (to be used by opac/oai.pl) according to sets
22
This script build OAI-PMH sets (to be used by opac/oai.pl) according to sets
23
and mappings defined in Koha. It reads informations from oai_sets and
23
and mappings defined in Koha. It reads information from oai_sets and
24
oai_sets_mappings, and then fill table oai_sets_biblios with builded infos.
24
oai_sets_mappings, and then fill table oai_sets_biblios with built infos.
25
25
26
=head1 USAGE
26
=head1 USAGE
27
27
Lines 29-35 oai_sets_mappings, and then fill table oai_sets_biblios with builded infos. Link Here
29
        -h          Print help message;
29
        -h          Print help message;
30
        -v          Be verbose
30
        -v          Be verbose
31
        -r          Truncate table oai_sets_biblios before inserting new rows
31
        -r          Truncate table oai_sets_biblios before inserting new rows
32
        -i          Embed items informations, mandatory if you defined mappings
32
        -i          Embed items information, mandatory if you defined mappings
33
                    on item fields
33
                    on item fields
34
        -l LENGTH   Process LENGTH biblios
34
        -l LENGTH   Process LENGTH biblios
35
        -o OFFSET   If LENGTH is defined, start processing from OFFSET
35
        -o OFFSET   If LENGTH is defined, start processing from OFFSET
Lines 180-187 sub print_usage { Link Here
180
    print "build_oai_sets.pl: Build OAI-PMH sets, according to mappings defined in Koha\n";
180
    print "build_oai_sets.pl: Build OAI-PMH sets, according to mappings defined in Koha\n";
181
    print "Usage: build_oai_sets.pl [-h] [-v] [-i] [-l LENGTH [-o OFFSET]]\n\n";
181
    print "Usage: build_oai_sets.pl [-h] [-v] [-i] [-l LENGTH [-o OFFSET]]\n\n";
182
    print "\t-h\t\tPrint this help and exit\n";
182
    print "\t-h\t\tPrint this help and exit\n";
183
    print "\t-v\t\tBe verbose\n";
183
    print "\t-v\t\the verbose\n";
184
    print "\t-i\t\tEmbed items informations, mandatory if you defined mappings on item fields\n";
184
    print "\t-i\t\tEmbed items information, mandatory if you defined mappings on item fields\n";
185
    print "\t-l LENGTH\tProcess LENGTH biblios\n";
185
    print "\t-l LENGTH\tProcess LENGTH biblios\n";
186
    print "\t-o OFFSET\tIf LENGTH is defined, start processing from OFFSET\n\n";
186
    print "\t-o OFFSET\tIf LENGTH is defined, start processing from OFFSET\n\n";
187
}
187
}
(-)a/misc/migration_tools/checkNonIndexedBiblios.pl (-1 / +1 lines)
Lines 19-25 Link Here
19
19
20
# Small script that checks if each biblio in the DB is properly indexed
20
# Small script that checks if each biblio in the DB is properly indexed
21
# if it is not and if you use -z the not-indexed biblios are inserted in zebraqueue
21
# if it is not and if you use -z the not-indexed biblios are inserted in zebraqueue
22
# To test just ommit the -z option you will have the biblionumber of non-indexed biblios and the total
22
# To test just omit the -z option you will have the biblionumber of non-indexed biblios and the total
23
23
24
use strict;
24
use strict;
25
25
(-)a/misc/migration_tools/rebuild_zebra.pl (-1 / +1 lines)
Lines 1030-1036 Parameters: Link Here
1030
    --where                 let you specify a WHERE query, like itemtype='BOOK'
1030
    --where                 let you specify a WHERE query, like itemtype='BOOK'
1031
                            or something like that
1031
                            or something like that
1032
1032
1033
    --run-as-root           explicitily allow script to run as 'root' user
1033
    --run-as-root           explicitly allow script to run as 'root' user
1034
1034
1035
    --wait-for-lock         when not running in daemon mode, the default
1035
    --wait-for-lock         when not running in daemon mode, the default
1036
                            behavior is to abort a rebuild if the rebuild
1036
                            behavior is to abort a rebuild if the rebuild
(-)a/misc/sip_cli_emulator.pl (-1 / +1 lines)
Lines 322-328 if ( $data =~ '^941' ) { ## we are logged in Link Here
322
sub build_command_message {
322
sub build_command_message {
323
    my ($message) = @_;
323
    my ($message) = @_;
324
324
325
    ##FIXME It would be much better to use exception handling so we aren't priting from subs
325
    ##FIXME It would be much better to use exception handling so we aren't printing from subs
326
    unless ( $handlers->{$message} ) {
326
    unless ( $handlers->{$message} ) {
327
        say "$message is an unsupported command!";
327
        say "$message is an unsupported command!";
328
        return;
328
        return;
(-)a/misc/stage_file.pl (-1 / +1 lines)
Lines 238-244 Parameters: Link Here
238
    --add-items             use this option to specify that
238
    --add-items             use this option to specify that
239
                            item data is embedded in the MARC
239
                            item data is embedded in the MARC
240
                            bibs and should be parsed.
240
                            bibs and should be parsed.
241
    --item-action           action to take if --add-items is specifed;
241
    --item-action           action to take if --add-items is specified;
242
                            choices are 'always_add',
242
                            choices are 'always_add',
243
                            'add_only_for_matches', 'add_only_for_new',
243
                            'add_only_for_matches', 'add_only_for_new',
244
                            'ignore', or 'replace'
244
                            'ignore', or 'replace'
(-)a/misc/translator/LangInstaller.pm (-2 / +2 lines)
Lines 538-544 sub get_all_langs { Link Here
538
538
539
LangInstaller.pm - Handle templates and preferences translation
539
LangInstaller.pm - Handle templates and preferences translation
540
540
541
=head1 SYNOPSYS
541
=head1 SYNOPSIS
542
542
543
  my $installer = LangInstaller->new( 'fr-FR' );
543
  my $installer = LangInstaller->new( 'fr-FR' );
544
  $installer->create();
544
  $installer->create();
Lines 566-572 For the current language, update .po files. Link Here
566
566
567
=head2 install
567
=head2 install
568
568
569
For the current langage C<$self->{lang}, use .po files to translate the english
569
For the current language C<$self->{lang}, use .po files to translate the english
570
version of templates and preferences files and copy those files in the
570
version of templates and preferences files and copy those files in the
571
appropriate directory.
571
appropriate directory.
572
572
(-)a/misc/translator/TmplTokenizer.pm (-1 / +1 lines)
Lines 311-317 sub _parametrize_internal { Link Here
311
    # }
311
    # }
312
    my $s = join( "", map { _formalize $_ } @parts );
312
    my $s = join( "", map { _formalize $_ } @parts );
313
313
314
    # should both the string and form be $s? maybe only the later? posibly the former....
314
    # should both the string and form be $s? maybe only the later? possibly the former....
315
    # used line number from first token, should suffice
315
    # used line number from first token, should suffice
316
    my $t = C4::TmplToken->new( $s, C4::TmplTokenType::TEXT_PARAMETRIZED, $parts[0]->line_number, $this->filename );
316
    my $t = C4::TmplToken->new( $s, C4::TmplTokenType::TEXT_PARAMETRIZED, $parts[0]->line_number, $this->filename );
317
    $t->set_children(@parts);
317
    $t->set_children(@parts);
(-)a/misc/translator/tmpl_process3.pl (-1 / +1 lines)
Lines 335-341 if ( defined $href ) { Link Here
335
            || $msg->{msgstr} eq '""'
335
            || $msg->{msgstr} eq '""'
336
            || $msg->{obsolete}
336
            || $msg->{obsolete}
337
            || grep { /fuzzy/ } @{ $msg->{_flags} };
337
            || grep { /fuzzy/ } @{ $msg->{_flags} };
338
        warn_normal( "unconsistent %s count: ($id_count/$str_count):\n"
338
        warn_normal( "inconsistent %s count: ($id_count/$str_count):\n"
339
                . "  line:   "
339
                . "  line:   "
340
                . $msg->{loaded_line_number} . "\n"
340
                . $msg->{loaded_line_number} . "\n"
341
                . "  msgid:  "
341
                . "  msgid:  "
(-)a/opac/ilsdi.pl (-1 / +1 lines)
Lines 38-44 outputs the returned hashref as XML. Link Here
38
38
39
=cut
39
=cut
40
40
41
# Instanciate the CGI request
41
# Instantiate the CGI request
42
my $cgi = CGI->new;
42
my $cgi = CGI->new;
43
43
44
# List of available services, sorted by level
44
# List of available services, sorted by level
(-)a/opac/opac-MARCdetail.pl (-1 / +1 lines)
Lines 297-303 for ( my $tabloop = 0 ; $tabloop <= 9 ; $tabloop++ ) { Link Here
297
# now, build item tab !
297
# now, build item tab !
298
# the main difference is that datas are in lines and not in columns : thus, we build the <th> first, then the values...
298
# the main difference is that datas are in lines and not in columns : thus, we build the <th> first, then the values...
299
# loop through each tag
299
# loop through each tag
300
# warning : we may have differents number of columns in each row. Thus, we first build a hash, complete it if necessary
300
# warning : we may have FIXME CODESPELL (differents ==> different, difference) number of columns in each row. Thus, we first build a hash, complete it if necessary
301
# then construct template.
301
# then construct template.
302
# $record has already had all the item fields filtered above.
302
# $record has already had all the item fields filtered above.
303
my @fields = $record->fields();
303
my @fields = $record->fields();
(-)a/opac/opac-password-recovery.pl (-1 / +1 lines)
Lines 79-85 if ( $op eq 'cud-sendEmail' || $op eq 'cud-resendEmail' ) { Link Here
79
    } elsif ( $username && $search_results->count > 1 ) {    # Multiple accounts for username
79
    } elsif ( $username && $search_results->count > 1 ) {    # Multiple accounts for username
80
        $hasError           = 1;
80
        $hasError           = 1;
81
        $errNoBorrowerFound = 1;
81
        $errNoBorrowerFound = 1;
82
    } elsif ( $email && $search_results->count > 1 ) {       # Muliple accounts for E-Mail
82
    } elsif ( $email && $search_results->count > 1 ) {       # Multiple accounts for E-Mail
83
        $hasError                    = 1;
83
        $hasError                    = 1;
84
        $errMultipleAccountsForEmail = 1;
84
        $errMultipleAccountsForEmail = 1;
85
    } elsif ( $borrower = $search_results->next() ) {        # One matching borrower
85
    } elsif ( $borrower = $search_results->next() ) {        # One matching borrower
(-)a/opac/opac-search.pl (-1 / +1 lines)
Lines 480-486 if ( $params->{'limit-yr'} ) { Link Here
480
        push @limits, "yr,st-numeric=$params->{'limit-yr'}";
480
        push @limits, "yr,st-numeric=$params->{'limit-yr'}";
481
    } else {
481
    } else {
482
482
483
        #FIXME: Should return a error to the user, incorect date format specified
483
        #FIXME: Should return a error to the user, incorrect date format specified
484
    }
484
    }
485
}
485
}
486
486
(-)a/opac/opac-suggestions.pl (-1 / +1 lines)
Lines 186-192 if ( $op eq "cud-add_confirm" ) { Link Here
186
        push @messages, { type => 'error', code => 'too_many' };
186
        push @messages, { type => 'error', code => 'too_many' };
187
    } elsif ( $suggestions->count >= 1 ) {
187
    } elsif ( $suggestions->count >= 1 ) {
188
188
189
        #some suggestion are answering the request Donot Add
189
        #some suggestion are answering the request FIXME CODESPELL (Donot ==> Do not, Donut) Add
190
        while ( my $suggestion = $suggestions->next ) {
190
        while ( my $suggestion = $suggestions->next ) {
191
            push @messages,
191
            push @messages,
192
                {
192
                {
(-)a/opac/opac-tags.pl (-1 / +1 lines)
Lines 342-348 if ($add_op) { Link Here
342
342
343
    # Bug 36785: Do not pass biblionumber: get_approval_rows does not 'recognize' biblionumber
343
    # Bug 36785: Do not pass biblionumber: get_approval_rows does not 'recognize' biblionumber
344
    $results = get_approval_rows($arghash);
344
    $results = get_approval_rows($arghash);
345
    stratify_tags( 10, $results );    # work out the differents sizes for things
345
    stratify_tags( 10, $results );    # work out the FIXME CODESPELL (differents ==> different, difference) sizes for things
346
    my $count = scalar @$results;
346
    my $count = scalar @$results;
347
    $template->param( TAGLOOP_COUNT => $count, mine => $mine );
347
    $template->param( TAGLOOP_COUNT => $count, mine => $mine );
348
}
348
}
(-)a/opac/svc/auth/googleopenidconnect (-1 / +1 lines)
Lines 241-247 if ( defined $query->param('error') ) { Link Here
241
        } else {
241
        } else {
242
            loginfailed(
242
            loginfailed(
243
                $query,
243
                $query,
244
                'Unexpectedly, no email seems to be associated with that acccount.'
244
                'Unexpectedly, no email seems to be associated with that account.'
245
            );
245
            );
246
        }
246
        }
247
    } else {
247
    } else {
(-)a/reports/acquisitions_stats.pl (-3 / +3 lines)
Lines 380-386 sub calculate { Link Here
380
    }
380
    }
381
381
382
    my $i         = 0;
382
    my $i         = 0;
383
    my $hilighted = -1;
383
    my $highlighted = -1;
384
384
385
    #Initialization of cell values.....
385
    #Initialization of cell values.....
386
    my %table;
386
    my %table;
Lines 480-491 sub calculate { Link Here
480
        my $r = {
480
        my $r = {
481
            rowtitle  => ( $row eq "zzEMPTY" ) ? "NULL" : $row,
481
            rowtitle  => ( $row eq "zzEMPTY" ) ? "NULL" : $row,
482
            loopcell  => \@loopcell,
482
            loopcell  => \@loopcell,
483
            hilighted => ( $hilighted > 0 ),
483
            highlighted => ( $highlighted > 0 ),
484
            totalrow  => $table{$row}->{totalrow}
484
            totalrow  => $table{$row}->{totalrow}
485
        };
485
        };
486
        $r->{totalrow} = sprintf( "%.2f", $r->{totalrow} ) if ( $r->{totalrow} and grep /$process/, ( 3, 4, 5 ) );
486
        $r->{totalrow} = sprintf( "%.2f", $r->{totalrow} ) if ( $r->{totalrow} and grep /$process/, ( 3, 4, 5 ) );
487
        push @looprow, $r;
487
        push @looprow, $r;
488
        $hilighted = -$hilighted;
488
        $highlighted = -$highlighted;
489
    }
489
    }
490
490
491
    foreach my $col (@loopcol) {
491
    foreach my $col (@loopcol) {
(-)a/reports/cat_issues_top.pl (-3 / +3 lines)
Lines 288-294 sub calculate { Link Here
288
    my $i = 0;
288
    my $i = 0;
289
289
290
    #	my @totalcol;
290
    #	my @totalcol;
291
    my $hilighted = -1;
291
    my $highlighted = -1;
292
292
293
    #Initialization of cell values.....
293
    #Initialization of cell values.....
294
    my @table;
294
    my @table;
Lines 408-416 sub calculate { Link Here
408
        push @looprow, {
408
        push @looprow, {
409
            'rowtitle'  => $i,
409
            'rowtitle'  => $i,
410
            'loopcell'  => \@loopcell,
410
            'loopcell'  => \@loopcell,
411
            'hilighted' => ( $hilighted > 0 ),
411
            'highlighted' => ( $highlighted > 0 ),
412
        };
412
        };
413
        $hilighted = -$hilighted;
413
        $highlighted = -$highlighted;
414
    }
414
    }
415
    #
415
    #
416
416
(-)a/reports/catalogue_stats.pl (-2 / +2 lines)
Lines 402-408 sub calculate { Link Here
402
    }
402
    }
403
403
404
    my $i         = 0;
404
    my $i         = 0;
405
    my $hilighted = -1;
405
    my $highlighted = -1;
406
406
407
    #Initialization of cell values.....
407
    #Initialization of cell values.....
408
    my %table;
408
    my %table;
Lines 543-549 sub calculate { Link Here
543
            'rowtitle'  => $row->{rowtitle},
543
            'rowtitle'  => $row->{rowtitle},
544
            'value'     => $row->{value},
544
            'value'     => $row->{value},
545
            'loopcell'  => \@loopcell,
545
            'loopcell'  => \@loopcell,
546
            'hilighted' => ( $hilighted *= -1 > 0 ),
546
            'highlighted' => ( $highlighted *= -1 > 0 ),
547
            'totalrow'  => $table{ $row->{value} }->{totalrow}
547
            'totalrow'  => $table{ $row->{value} }->{totalrow}
548
            };
548
            };
549
    }
549
    }
(-)a/reports/guided_reports.pl (-2 / +2 lines)
Lines 395-401 if ( !$op ) { Link Here
395
    my @columns = split( ',', $column );
395
    my @columns = split( ',', $column );
396
    my @total_by;
396
    my @total_by;
397
397
398
    # build structue for use by tmpl_loop to choose columns to order by
398
    # build structure for use by tmpl_loop to choose columns to order by
399
    # need to do something about the order of the order :)
399
    # need to do something about the order of the order :)
400
    # we also want to use the %columns hash to get the plain english names
400
    # we also want to use the %columns hash to get the plain english names
401
    foreach my $col (@columns) {
401
    foreach my $col (@columns) {
Lines 436-442 if ( !$op ) { Link Here
436
    my @columns = split( ',', $column );
436
    my @columns = split( ',', $column );
437
    my @order_by;
437
    my @order_by;
438
438
439
    # build structue for use by tmpl_loop to choose columns to order by
439
    # build structure for use by tmpl_loop to choose columns to order by
440
    # need to do something about the order of the order :)
440
    # need to do something about the order of the order :)
441
    foreach my $col (@columns) {
441
    foreach my $col (@columns) {
442
        my %order   = ( name => $col );
442
        my %order   = ( name => $col );
(-)a/reports/issues_avg_stats.pl (-3 / +3 lines)
Lines 387-393 sub calculate { Link Here
387
    #	warn "fin des titres colonnes";
387
    #	warn "fin des titres colonnes";
388
388
389
    my $i         = 0;
389
    my $i         = 0;
390
    my $hilighted = -1;
390
    my $highlighted = -1;
391
391
392
    #Initialization of cell values.....
392
    #Initialization of cell values.....
393
    my %table;
393
    my %table;
Lines 517-526 sub calculate { Link Here
517
            {
517
            {
518
            'rowtitle'  => ( $row eq "zzEMPTY" ) ? "NULL" : $row,
518
            'rowtitle'  => ( $row eq "zzEMPTY" ) ? "NULL" : $row,
519
            'loopcell'  => \@loopcell,
519
            'loopcell'  => \@loopcell,
520
            'hilighted' => ( $hilighted > 0 ),
520
            'highlighted' => ( $highlighted > 0 ),
521
            'totalrow'  => ($total) ? sprintf( "%.2f", $total ) : 0
521
            'totalrow'  => ($total) ? sprintf( "%.2f", $total ) : 0
522
            };
522
            };
523
        $hilighted = -$hilighted;
523
        $highlighted = -$highlighted;
524
    }
524
    }
525
    #
525
    #
526
    # #	warn "footer processing";
526
    # #	warn "footer processing";
(-)a/reports/orders_by_fund.pl (-1 / +1 lines)
Lines 89-95 if ($get_orders) { Link Here
89
        }
89
        }
90
    }
90
    }
91
91
92
    # Format the order's informations
92
    # Format the order's information
93
    foreach my $order (@orders) {
93
    foreach my $order (@orders) {
94
94
95
        # Get the title of the ordered item
95
        # Get the title of the ordered item
(-)a/reserve/request.pl (-3 / +3 lines)
Lines 212-218 if ( $borrowernumber_hold && !$op ) { Link Here
212
        );
212
        );
213
    }
213
    }
214
214
215
    # check if the borrower make the reserv in a different branch
215
    # check if the borrower make the reserve in a different branch
216
    if ( $patron->branchcode ne C4::Context->userenv->{'branch'} ) {
216
    if ( $patron->branchcode ne C4::Context->userenv->{'branch'} ) {
217
        $diffbranch = 1;
217
        $diffbranch = 1;
218
    }
218
    }
Lines 468-474 if ( ( $findborrower && $borrowernumber_hold || $findclub && $club_hold ) Link Here
468
                $item->{notforloan} ||= 0;
468
                $item->{notforloan} ||= 0;
469
469
470
                # if independent branches is on we need to check if the person can reserve
470
                # if independent branches is on we need to check if the person can reserve
471
                # for branches they arent logged in to
471
                # for branches they aren't logged in to
472
                if ( C4::Context->preference("IndependentBranches") ) {
472
                if ( C4::Context->preference("IndependentBranches") ) {
473
                    if ( !C4::Context->preference("canreservefromotherbranches") ) {
473
                    if ( !C4::Context->preference("canreservefromotherbranches") ) {
474
474
Lines 584-590 if ( ( $findborrower && $borrowernumber_hold || $findclub && $club_hold ) Link Here
584
584
585
            $biblioloopiter{biblioitem} = $biblio->biblioitem;
585
            $biblioloopiter{biblioitem} = $biblio->biblioitem;
586
586
587
            # While we can't override an alreay held item, we should be able to override the others
587
            # While we can't override an already held item, we should be able to override the others
588
            # Unless all items are already held
588
            # Unless all items are already held
589
            if ( $num_override > 0 && ( $num_override + $num_alreadyheld ) == scalar( @{ $biblioloopiter{itemloop} } ) )
589
            if ( $num_override > 0 && ( $num_override + $num_alreadyheld ) == scalar( @{ $biblioloopiter{itemloop} } ) )
590
            {
590
            {
(-)a/suggestion/suggestion.pl (-4 / +4 lines)
Lines 257-270 if ( $op =~ /cud-save/ ) { Link Here
257
            my $suggestions = Koha::Suggestions->search_limited($suggestion_only);
257
            my $suggestions = Koha::Suggestions->search_limited($suggestion_only);
258
            if ( $suggestions->count ) {
258
            if ( $suggestions->count ) {
259
259
260
                #some suggestion are answering the request Donot Add
260
                #some suggestion are answering the request FIXME CODESPELL (Donot ==> Do not, Donut) Add
261
                my @messages;
261
                my @messages;
262
                while ( my $suggestion = $suggestions->next ) {
262
                while ( my $suggestion = $suggestions->next ) {
263
                    push @messages, { type => 'error', code => 'already_exists', id => $suggestion->suggestionid };
263
                    push @messages, { type => 'error', code => 'already_exists', id => $suggestion->suggestionid };
264
                }
264
                }
265
                $template->param( messages => \@messages );
265
                $template->param( messages => \@messages );
266
            } else {
266
            } else {
267
                ## Adding some informations related to suggestion
267
                ## Adding some information related to suggestion
268
                if ( $librarian->has_permission( { 'suggestions' => 'suggestions_create' } ) ) {
268
                if ( $librarian->has_permission( { 'suggestions' => 'suggestions_create' } ) ) {
269
                    Koha::Suggestion->new($suggestion_only)->store();
269
                    Koha::Suggestion->new($suggestion_only)->store();
270
                } else {
270
                } else {
Lines 305-311 if ( $op =~ /cud-save/ ) { Link Here
305
} elsif ( $op eq "cud-update_status" ) {
305
} elsif ( $op eq "cud-update_status" ) {
306
    my $suggestion;
306
    my $suggestion;
307
307
308
    # set accepted/rejected/managed informations if applicable
308
    # set accepted/rejected/managed information if applicable
309
    # ie= if the librarian has chosen some action on the suggestions
309
    # ie= if the librarian has chosen some action on the suggestions
310
    my $STATUS      = $input->param('STATUS');
310
    my $STATUS      = $input->param('STATUS');
311
    my $accepted_by = $input->param('acceptedby');
311
    my $accepted_by = $input->param('acceptedby');
Lines 506-512 $template->param( Link Here
506
    "op"            => $op,
506
    "op"            => $op,
507
);
507
);
508
508
509
if ( defined($returnsuggested) and $returnsuggested ne "noone" ) {
509
if ( defined($returnsuggested) and $returnsuggested ne "no one" ) {
510
    print $input->redirect( "/cgi-bin/koha/members/moremember.pl?borrowernumber=" . $returnsuggested . "#suggestions" );
510
    print $input->redirect( "/cgi-bin/koha/members/moremember.pl?borrowernumber=" . $returnsuggested . "#suggestions" );
511
}
511
}
512
512
(-)a/svc/barcode (-1 / +1 lines)
Lines 56-62 EAN8 Link Here
56
EAN13
56
EAN13
57
COOP2of5
57
COOP2of5
58
58
59
If ommited,it defaults to Code39.
59
If omitted,it defaults to Code39.
60
60
61
=item I<notext>
61
=item I<notext>
62
62
(-)a/svc/holds (-1 / +1 lines)
Lines 124-130 while ( my $h = $holds_rs->next() ) { Link Here
124
        : q{},
124
        : q{},
125
    };
125
    };
126
126
127
    $hold->{transfered}     = 0;
127
    $hold->{transferred}     = 0;
128
    $hold->{not_transfered} = 0;
128
    $hold->{not_transfered} = 0;
129
129
130
    if ($item) {
130
    if ($item) {
(-)a/t/ClassSortRoutine_LCC.t (-1 / +1 lines)
Lines 17-23 BEGIN { Link Here
17
is( C4::ClassSortRoutine::LCC::get_class_sort_key(),           "",    "No arguments returns an empty string" );
17
is( C4::ClassSortRoutine::LCC::get_class_sort_key(),           "",    "No arguments returns an empty string" );
18
is( C4::ClassSortRoutine::LCC::get_class_sort_key( 'a', 'b' ), "A B", "Arguments 'a','b' return 'A B'" );
18
is( C4::ClassSortRoutine::LCC::get_class_sort_key( 'a', 'b' ), "A B", "Arguments 'a','b' return 'A B'" );
19
19
20
#spaces in arguements
20
#spaces in arguments
21
is( C4::ClassSortRoutine::LCC::get_class_sort_key( ' ', 'b' ),    "B", "Arguments ' ','b' return 'B'" );
21
is( C4::ClassSortRoutine::LCC::get_class_sort_key( ' ', 'b' ),    "B", "Arguments ' ','b' return 'B'" );
22
is( C4::ClassSortRoutine::LCC::get_class_sort_key( 'a', ' ' ),    "A", "Arguments 'a',' ' return 'A'" );
22
is( C4::ClassSortRoutine::LCC::get_class_sort_key( 'a', ' ' ),    "A", "Arguments 'a',' ' return 'A'" );
23
is( C4::ClassSortRoutine::LCC::get_class_sort_key( ' ', '    ' ), "",  "Arguments ' ','    ' return ''" );
23
is( C4::ClassSortRoutine::LCC::get_class_sort_key( ' ', '    ' ), "",  "Arguments ' ','    ' return ''" );
(-)a/t/Creators.t (-2 / +2 lines)
Lines 1-8 Link Here
1
#!/usr/bin/perl
1
#!/usr/bin/perl
2
#
2
#
3
# This module will excercise pdf creation routines
3
# This module will exercise pdf creation routines
4
#
4
#
5
# When run with KEEP_PDF enviroment variable it will keep
5
# When run with KEEP_PDF environment variable it will keep
6
# test.pdf for manual inspection. This can be used to verify
6
# test.pdf for manual inspection. This can be used to verify
7
# that ttf font configuration is complete like:
7
# that ttf font configuration is complete like:
8
#
8
#
(-)a/t/Number/Price.t (-3 / +3 lines)
Lines 6-12 use Test::More tests => 38; Link Here
6
use Test::MockModule;
6
use Test::MockModule;
7
use t::lib::Mocks;
7
use t::lib::Mocks;
8
8
9
# Number formating depends by default on system environement
9
# Number formatting depends by default on system environment
10
# See http://search.cpan.org/~wrw/Number-Format/Format.pm
10
# See http://search.cpan.org/~wrw/Number-Format/Format.pm
11
use POSIX qw(setlocale LC_NUMERIC);
11
use POSIX qw(setlocale LC_NUMERIC);
12
12
Lines 74-80 is( Link Here
74
);
74
);
75
75
76
SKIP: {
76
SKIP: {
77
    # Bug 18900 - Check params are not from system environement
77
    # Bug 18900 - Check params are not from system environment
78
    setlocale( LC_NUMERIC, "fr_FR.UTF-8" );
78
    setlocale( LC_NUMERIC, "fr_FR.UTF-8" );
79
    my $current_locale = setlocale(LC_NUMERIC);
79
    my $current_locale = setlocale(LC_NUMERIC);
80
80
Lines 102-108 $currency = Koha::Acquisition::Currency->new( Link Here
102
    }
102
    }
103
);
103
);
104
104
105
# Actually,the price formating for France is 3,00€
105
# Actually,the price formatting for France is 3,00€
106
# How put the symbol at the end with Number::Format?
106
# How put the symbol at the end with Number::Format?
107
is( Koha::Number::Price->new->format($format),    '0,00', 'FR: format 0' );
107
is( Koha::Number::Price->new->format($format),    '0,00', 'FR: format 0' );
108
is( Koha::Number::Price->new(3)->format($format), '3,00', 'FR: format 3' );
108
is( Koha::Number::Price->new(3)->format($format), '3,00', 'FR: format 3' );
(-)a/t/Output_JSONStream.t (-1 / +1 lines)
Lines 22-28 like( $json->output, '/"stuff":\["realia"\]/', "Making sure JSON output has adde Link Here
22
like( $json->output, '/"issues":\["yes!","please","no"\]/', "Making sure existing elements remain in JSON output" );
22
like( $json->output, '/"issues":\["yes!","please","no"\]/', "Making sure existing elements remain in JSON output" );
23
$json->param( stuff => [ 'fun', 'love' ] );
23
$json->param( stuff => [ 'fun', 'love' ] );
24
like( $json->output, '/"stuff":\["fun","love"\]/',          "Making sure JSON output can overwrite params." );
24
like( $json->output, '/"stuff":\["fun","love"\]/',          "Making sure JSON output can overwrite params." );
25
like( $json->output, '/"issues":\["yes!","please","no"\]/', "Making non overwitten elements remain in JSON output" );
25
like( $json->output, '/"issues":\["yes!","please","no"\]/', "Making non overwritten elements remain in JSON output" );
26
26
27
eval { $json->param(die) };
27
eval { $json->param(die) };
28
ok( $@, 'Dies' );
28
ok( $@, 'Dies' );
(-)a/t/cypress/support/e2e.js (-2 / +2 lines)
Lines 1298-1304 cy.get_title = () => { Link Here
1298
        num_last_vol_online: "num last vol",
1298
        num_last_vol_online: "num last vol",
1299
        online_identifier: "online identifier",
1299
        online_identifier: "online identifier",
1300
        parent_publication_title_id: "parent id",
1300
        parent_publication_title_id: "parent id",
1301
        preceding_publication_title_id: "preceeding id",
1301
        preceding_publication_title_id: "FIXME CODESPELL (preceeding ==> preceding, proceeding) id",
1302
        print_identifier: "print identifier",
1302
        print_identifier: "print identifier",
1303
        publication_title: "publication title",
1303
        publication_title: "publication title",
1304
        publication_type: "journal",
1304
        publication_type: "journal",
Lines 1364-1370 cy.get_counter_file = () => { Link Here
1364
        date_uploaded: "2023-06-19T09:13:39+00:00",
1364
        date_uploaded: "2023-06-19T09:13:39+00:00",
1365
        erm_counter_files_id: 1,
1365
        erm_counter_files_id: 1,
1366
        file_content:
1366
        file_content:
1367
            'Report_Name,"Journal Requests (Excluding OA_Gold)"\r\nReport_ID,TR_J1\r\nRelease,5\r\nInstitution_Name,"University Of West London"\r\nInstitution_ID,"Proprietary:Wiley:EAL00000122866; ISNI:0000000121857124"\r\nMetric_Types,"Total_Item_Requests; Unique_Item_Requests"\r\nReport_Filters,"Metric_Type:Total_Item_Requests|Unique_Item_Requests; Access_Type:Controlled; End_Date:2023-06-01; Begin_Date:2022-01-01; Data_Type:Journal; Access_Method:Regular"\r\nReport_Attributes,\r\nExceptions,"3031: Usage Not Ready for Requested Dates (Requested data between 2023-06-01 and 2023-06-01. However only data between 2018-11-01 and 2023-05-31 exists.)"\r\nReporting_Period,"Begin_Date=2022-01-01; End_Date=2023-06-01"\r\nCreated,2023-06-19T02:13:31Z\r\nCreated_By,"Atypon Systems LLC."\r\n\r\nTitle,Publisher,Publisher_ID,Platform,DOI,Proprietary_ID,Print_ISSN,Online_ISSN,URI,Metric_Type,Reporting_Period_Total,"Jan 2022","Feb 2022","Mar 2022","Apr 2022","May 2022","Jun 2022","Jul 2022","Aug 2022","Sep 2022","Oct 2022","Nov 2022","Dez 2022","Jan 2023","Feb 2023","Mar 2023","Apr 2023","May 2023","Jun 2023"\r\n"AEM Education and Training",Wiley,0000000403801313,"Wiley Online Library",10.1002/(ISSN)2472-5390,Wiley:AET2,2472-5390,2472-5390,,Total_Item_Requests,16,1,3,0,1,3,1,0,2,1,0,0,1,0,3,0,0,0,0\r\n"AEM Education and Training",Wiley,0000000403801313,"Wiley Online Library",10.1002/(ISSN)2472-5390,Wiley:AET2,2472-5390,2472-5390,,Unique_Item_Requests,10,1,2,0,1,1,1,0,1,1,0,0,1,0,1,0,0,0,0\r\n"AIChE Journal",Wiley,0000000403801313,"Wiley Online Library",10.1002/(ISSN)1547-5905,Wiley:AIC,0001-1541,1547-5905,,Total_Item_Requests,4,1,0,0,0,0,1,0,0,0,0,1,1,0,0,0,0,0,0\r\n"AIChE Journal",Wiley,0000000403801313,"Wiley Online Library",10.1002/(ISSN)1547-5905,Wiley:AIC,0001-1541,1547-5905,,Unique_Item_Requests,4,1,0,0,0,0,1,0,0,0,0,1,1,0,0,0,0,0,0\r\n"ANZ Journal of Surgery",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1445-2197,Wiley:ANS,1445-1433,1445-2197,,Total_Item_Requests,103,11,2,20,14,8,2,9,1,0,5,6,0,2,4,6,5,8,0\r\n"ANZ Journal of Surgery",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1445-2197,Wiley:ANS,1445-1433,1445-2197,,Unique_Item_Requests,77,9,2,16,8,6,1,9,1,0,3,4,0,1,4,4,2,7,0\r\n"AORN Journal",Wiley,0000000403801313,"Wiley Online Library",10.1002/(ISSN)1878-0369,Wiley:AORN,0001-2092,1878-0369,,Total_Item_Requests,634,71,45,59,20,43,47,45,11,14,15,31,22,29,18,28,39,97,0\r\n"AORN Journal",Wiley,0000000403801313,"Wiley Online Library",10.1002/(ISSN)1878-0369,Wiley:AORN,0001-2092,1878-0369,,Unique_Item_Requests,436,53,27,27,15,34,30,30,6,11,13,22,17,23,16,26,26,60,0\r\nAPMIS,Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1600-0463,Wiley:APM,0903-4641,1600-0463,,Total_Item_Requests,6,0,0,0,1,0,0,0,2,0,0,0,2,0,1,0,0,0,0\r\nAPMIS,Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1600-0463,Wiley:APM,0903-4641,1600-0463,,Unique_Item_Requests,4,0,0,0,1,0,0,0,1,0,0,0,1,0,1,0,0,0,0\r\n"AWWA Water Science",Wiley,0000000403801313,"Wiley Online Library",10.1002/(ISSN)2577-8161,Wiley:AWS2,,2577-8161,,Total_Item_Requests,1,0,0,0,0,0,0,0,0,1,0,0,0,0,0,0,0,0,0\r\n"AWWA Water Science",Wiley,0000000403801313,"Wiley Online Library",10.1002/(ISSN)2577-8161,Wiley:AWS2,,2577-8161,,Unique_Item_Requests,1,0,0,0,0,0,0,0,0,1,0,0,0,0,0,0,0,0,0\r\nAbacus,Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1467-6281,Wiley:ABAC,0001-3072,1467-6281,,Total_Item_Requests,51,3,0,7,0,2,0,1,0,0,0,11,6,0,3,17,1,0,0\r\nAbacus,Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1467-6281,Wiley:ABAC,0001-3072,1467-6281,,Unique_Item_Requests,36,2,0,6,0,2,0,1,0,0,0,7,2,0,2,13,1,0,0\r\n"Academic Emergency Medicine",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1553-2712,Wiley:ACEM,1069-6563,1553-2712,,Total_Item_Requests,213,18,16,11,13,21,20,28,16,6,11,2,4,18,17,1,7,4,0\r\n"Academic Emergency Medicine",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1553-2712,Wiley:ACEM,1069-6563,1553-2712,,Unique_Item_Requests,159,15,11,10,10,15,13,23,12,6,7,2,2,10,12,1,7,3,0\r\n"Accounting & Finance",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1467-629X,Wiley:ACFI,0810-5391,1467-629X,,Total_Item_Requests,67,2,4,4,13,8,1,0,2,2,1,9,6,2,0,2,4,7,0\r\n"Accounting & Finance",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1467-629X,Wiley:ACFI,0810-5391,1467-629X,,Unique_Item_Requests,53,1,4,4,11,7,1,0,2,1,1,7,3,1,0,2,4,4,0\r\n"Accounting Perspectives",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1911-3838,Wiley:APR,1911-382X,1911-3838,,Total_Item_Requests,19,0,0,2,1,3,0,1,0,0,0,0,0,3,1,0,4,4,0\r\n"Accounting Perspectives",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1911-3838,Wiley:APR,1911-382X,1911-3838,,Unique_Item_Requests,14,0,0,1,1,1,0,1,0,0,0,0,0,2,1,0,4,3,0\r\n"Acta Anaesthesiologica Scandinavica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1399-6576,Wiley:AAS,0001-5172,1399-6576,,Total_Item_Requests,181,29,20,19,5,15,4,19,6,5,6,4,0,3,29,1,12,4,0\r\n"Acta Anaesthesiologica Scandinavica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1399-6576,Wiley:AAS,0001-5172,1399-6576,,Unique_Item_Requests,117,21,12,11,4,10,4,14,3,5,4,4,0,2,14,1,4,4,0\r\n"Acta Neurologica Scandinavica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1600-0404,Wiley:ANE,0001-6314,1600-0404,,Total_Item_Requests,23,0,0,2,0,5,0,1,1,0,2,2,0,2,1,5,2,0,0\r\n"Acta Neurologica Scandinavica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1600-0404,Wiley:ANE,0001-6314,1600-0404,,Unique_Item_Requests,21,0,0,2,0,4,0,1,1,0,1,2,0,2,1,5,2,0,0\r\n"Acta Obstetricia et Gynecologica Scandinavica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1600-0412,Wiley:AOGS,0001-6349,1600-0412,,Total_Item_Requests,22,1,0,0,0,0,0,0,0,0,0,0,0,0,0,15,4,2,0\r\n"Acta Obstetricia et Gynecologica Scandinavica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1600-0412,Wiley:AOGS,0001-6349,1600-0412,,Unique_Item_Requests,11,1,0,0,0,0,0,0,0,0,0,0,0,0,0,7,2,1,0\r\n"Acta Ophthalmologica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1755-3768,Wiley:AOS,1755-375X,1755-3768,,Total_Item_Requests,2,0,0,0,0,0,1,0,1,0,0,0,0,0,0,0,0,0,0\r\n"Acta Ophthalmologica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1755-3768,Wiley:AOS,1755-375X,1755-3768,,Unique_Item_Requests,2,0,0,0,0,0,1,0,1,0,0,0,0,0,0,0,0,0,0\r\n"Acta Paediatrica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1651-2227,Wiley:APA,0803-5253,1651-2227,,Total_Item_Requests,229,23,26,14,12,8,45,22,6,10,8,3,9,7,8,11,9,8,0\r\n"Acta Paediatrica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1651-2227,Wiley:APA,0803-5253,1651-2227,,Unique_Item_Requests,165,16,19,8,8,8,37,11,6,7,6,3,8,6,7,7,3,5,0\r\n"Acta Physiologica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1748-1716,Wiley:APHA,1748-1708,1748-1716,,Total_Item_Requests,13,2,0,0,1,1,8,0,0,0,0,0,0,0,1,0,0,0,0\r\n"Acta Physiologica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1748-1716,Wiley:APHA,1748-1708,1748-1716,,Unique_Item_Requests,12,2,0,0,1,1,7,0,0,0,0,0,0,0,1,0,0,0,0\r\n"Acta Psychiatrica Scandinavica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1600-0447,Wiley:ACPS,0001-690X,1600-0447,,Total_Item_Requests,226,5,9,28,28,15,18,4,1,2,4,13,14,24,8,20,21,12,0\r\n"Acta Psychiatrica Scandinavica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1600-0447,Wiley:ACPS,0001-690X,1600-0447,,Unique_Item_Requests,178,4,5,19,23,10,17,3,1,1,4,13,10,19,6,18,14,11,0\r\n',
1367
            'Report_Name,"Journal Requests (Excluding OA_Gold)"\r\nReport_ID,TR_J1\r\nRelease,5\r\nInstitution_Name,"University Of West London"\r\nInstitution_ID,"Proprietary:Wiley:EAL00000122866; ISNI:0000000121857124"\r\nMetric_Types,"Total_Item_Requests; Unique_Item_Requests"\r\nReport_Filters,"Metric_Type:Total_Item_Requests|Unique_Item_Requests; Access_Type:Controlled; End_Date:2023-06-01; Begin_Date:2022-01-01; Data_Type:Journal; Access_Method:Regular"\r\nReport_Attributes,\r\nExceptions,"3031: Usage Not Ready for Requested Dates (Requested data between 2023-06-01 and 2023-06-01. However only data between 2018-11-01 and 2023-05-31 exists.)"\r\nReporting_Period,"Begin_Date=2022-01-01; End_Date=2023-06-01"\r\nCreated,2023-06-19T02:13:31Z\r\nCreated_By,"Atypon Systems LLC."\r\n\r\nTitle,Publisher,Publisher_ID,Platform,DOI,Proprietary_ID,Print_ISSN,Online_ISSN,URI,Metric_Type,Reporting_Period_Total,"Jan 2022","Feb 2022","Mar 2022","Apr 2022","May 2022","Jun 2022","Jul 2022","Aug 2022","Sep 2022","Oct 2022","Nov 2022","Dez 2022","Jan 2023","Feb 2023","Mar 2023","Apr 2023","May 2023","Jun 2023"\r\n"AEM Education and Training",Wiley,0000000403801313,"Wiley Online Library",10.1002/(ISSN)2472-5390,Wiley:AET2,2472-5390,2472-5390,,Total_Item_Requests,16,1,3,0,1,3,1,0,2,1,0,0,1,0,3,0,0,0,0\r\n"AEM Education and Training",Wiley,0000000403801313,"Wiley Online Library",10.1002/(ISSN)2472-5390,Wiley:AET2,2472-5390,2472-5390,,Unique_Item_Requests,10,1,2,0,1,1,1,0,1,1,0,0,1,0,1,0,0,0,0\r\n"AIChE Journal",Wiley,0000000403801313,"Wiley Online Library",10.1002/(ISSN)1547-5905,Wiley:AIC,0001-1541,1547-5905,,Total_Item_Requests,4,1,0,0,0,0,1,0,0,0,0,1,1,0,0,0,0,0,0\r\n"AIChE Journal",Wiley,0000000403801313,"Wiley Online Library",10.1002/(ISSN)1547-5905,Wiley:AIC,0001-1541,1547-5905,,Unique_Item_Requests,4,1,0,0,0,0,1,0,0,0,0,1,1,0,0,0,0,0,0\r\n"ANZ Journal of Surgery",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1445-2197,Wiley:AND,1445-1433,1445-2197,,Total_Item_Requests,103,11,2,20,14,8,2,9,1,0,5,6,0,2,4,6,5,8,0\r\n"ANZ Journal of Surgery",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1445-2197,Wiley:AND,1445-1433,1445-2197,,Unique_Item_Requests,77,9,2,16,8,6,1,9,1,0,3,4,0,1,4,4,2,7,0\r\n"AORN Journal",Wiley,0000000403801313,"Wiley Online Library",10.1002/(ISSN)1878-0369,Wiley:AORN,0001-2092,1878-0369,,Total_Item_Requests,634,71,45,59,20,43,47,45,11,14,15,31,22,29,18,28,39,97,0\r\n"AORN Journal",Wiley,0000000403801313,"Wiley Online Library",10.1002/(ISSN)1878-0369,Wiley:AORN,0001-2092,1878-0369,,Unique_Item_Requests,436,53,27,27,15,34,30,30,6,11,13,22,17,23,16,26,26,60,0\r\nAPMIS,Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1600-0463,Wiley:APM,0903-4641,1600-0463,,Total_Item_Requests,6,0,0,0,1,0,0,0,2,0,0,0,2,0,1,0,0,0,0\r\nAPMIS,Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1600-0463,Wiley:APM,0903-4641,1600-0463,,Unique_Item_Requests,4,0,0,0,1,0,0,0,1,0,0,0,1,0,1,0,0,0,0\r\n"AWWA Water Science",Wiley,0000000403801313,"Wiley Online Library",10.1002/(ISSN)2577-8161,Wiley:AWS2,,2577-8161,,Total_Item_Requests,1,0,0,0,0,0,0,0,0,1,0,0,0,0,0,0,0,0,0\r\n"AWWA Water Science",Wiley,0000000403801313,"Wiley Online Library",10.1002/(ISSN)2577-8161,Wiley:AWS2,,2577-8161,,Unique_Item_Requests,1,0,0,0,0,0,0,0,0,1,0,0,0,0,0,0,0,0,0\r\nAbacus,Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1467-6281,Wiley:ABAC,0001-3072,1467-6281,,Total_Item_Requests,51,3,0,7,0,2,0,1,0,0,0,11,6,0,3,17,1,0,0\r\nAbacus,Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1467-6281,Wiley:ABAC,0001-3072,1467-6281,,Unique_Item_Requests,36,2,0,6,0,2,0,1,0,0,0,7,2,0,2,13,1,0,0\r\n"Academic Emergency Medicine",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1553-2712,Wiley:ACEM,1069-6563,1553-2712,,Total_Item_Requests,213,18,16,11,13,21,20,28,16,6,11,2,4,18,17,1,7,4,0\r\n"Academic Emergency Medicine",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1553-2712,Wiley:ACEM,1069-6563,1553-2712,,Unique_Item_Requests,159,15,11,10,10,15,13,23,12,6,7,2,2,10,12,1,7,3,0\r\n"Accounting & Finance",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1467-629X,Wiley:ACFI,0810-5391,1467-629X,,Total_Item_Requests,67,2,4,4,13,8,1,0,2,2,1,9,6,2,0,2,4,7,0\r\n"Accounting & Finance",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1467-629X,Wiley:ACFI,0810-5391,1467-629X,,Unique_Item_Requests,53,1,4,4,11,7,1,0,2,1,1,7,3,1,0,2,4,4,0\r\n"Accounting Perspectives",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1911-3838,Wiley:APR,1911-382X,1911-3838,,Total_Item_Requests,19,0,0,2,1,3,0,1,0,0,0,0,0,3,1,0,4,4,0\r\n"Accounting Perspectives",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1911-3838,Wiley:APR,1911-382X,1911-3838,,Unique_Item_Requests,14,0,0,1,1,1,0,1,0,0,0,0,0,2,1,0,4,3,0\r\n"Acta Anaesthesiologica Scandinavica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1399-6576,Wiley:AAS,0001-5172,1399-6576,,Total_Item_Requests,181,29,20,19,5,15,4,19,6,5,6,4,0,3,29,1,12,4,0\r\n"Acta Anaesthesiologica Scandinavica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1399-6576,Wiley:AAS,0001-5172,1399-6576,,Unique_Item_Requests,117,21,12,11,4,10,4,14,3,5,4,4,0,2,14,1,4,4,0\r\n"Acta Neurologica Scandinavica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1600-0404,Wiley:AND,0001-6314,1600-0404,,Total_Item_Requests,23,0,0,2,0,5,0,1,1,0,2,2,0,2,1,5,2,0,0\r\n"Acta Neurologica Scandinavica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1600-0404,Wiley:AND,0001-6314,1600-0404,,Unique_Item_Requests,21,0,0,2,0,4,0,1,1,0,1,2,0,2,1,5,2,0,0\r\n"Acta Obstetricia et Gynecologica Scandinavica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1600-0412,Wiley:AOGS,0001-6349,1600-0412,,Total_Item_Requests,22,1,0,0,0,0,0,0,0,0,0,0,0,0,0,15,4,2,0\r\n"Acta Obstetricia et Gynecologica Scandinavica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1600-0412,Wiley:AOGS,0001-6349,1600-0412,,Unique_Item_Requests,11,1,0,0,0,0,0,0,0,0,0,0,0,0,0,7,2,1,0\r\n"Acta Ophthalmologica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1755-3768,Wiley:AOS,1755-375X,1755-3768,,Total_Item_Requests,2,0,0,0,0,0,1,0,1,0,0,0,0,0,0,0,0,0,0\r\n"Acta Ophthalmologica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1755-3768,Wiley:AOS,1755-375X,1755-3768,,Unique_Item_Requests,2,0,0,0,0,0,1,0,1,0,0,0,0,0,0,0,0,0,0\r\n"Acta Paediatrica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1651-2227,Wiley:APA,0803-5253,1651-2227,,Total_Item_Requests,229,23,26,14,12,8,45,22,6,10,8,3,9,7,8,11,9,8,0\r\n"Acta Paediatrica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1651-2227,Wiley:APA,0803-5253,1651-2227,,Unique_Item_Requests,165,16,19,8,8,8,37,11,6,7,6,3,8,6,7,7,3,5,0\r\n"Acta Physiologica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1748-1716,Wiley:APHA,1748-1708,1748-1716,,Total_Item_Requests,13,2,0,0,1,1,8,0,0,0,0,0,0,0,1,0,0,0,0\r\n"Acta Physiologica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1748-1716,Wiley:APHA,1748-1708,1748-1716,,Unique_Item_Requests,12,2,0,0,1,1,7,0,0,0,0,0,0,0,1,0,0,0,0\r\n"Acta Psychiatrica Scandinavica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1600-0447,Wiley:ACPS,0001-690X,1600-0447,,Total_Item_Requests,226,5,9,28,28,15,18,4,1,2,4,13,14,24,8,20,21,12,0\r\n"Acta Psychiatrica Scandinavica",Wiley,0000000403801313,"Wiley Online Library",10.1111/(ISSN)1600-0447,Wiley:ACPS,0001-690X,1600-0447,,Unique_Item_Requests,178,4,5,19,23,10,17,3,1,1,4,13,10,19,6,18,14,11,0\r\n',
1368
        filename: "PTFS Journals_TR_J1",
1368
        filename: "PTFS Journals_TR_J1",
1369
        type: "TR_J1",
1369
        type: "TR_J1",
1370
        usage_data_provider_id: 1,
1370
        usage_data_provider_id: 1,
(-)a/t/db_dependent/Accounts.t (-6 / +6 lines)
Lines 124-155 my @test_data = ( Link Here
124
    },
124
    },
125
    {
125
    {
126
        amount      => 5, days_ago => $days - 1,
126
        amount      => 5, days_ago => $days - 1,
127
        description => 'purge_zero_balance_fees should not delete fees with positive amout owed before threshold day',
127
        description => 'purge_zero_balance_fees should not delete fees with positive amount owed before threshold day',
128
        delete      => 0, credit_type => undef, debit_type => 'OVERDUE'
128
        delete      => 0, credit_type => undef, debit_type => 'OVERDUE'
129
    },
129
    },
130
    {
130
    {
131
        amount      => 5, days_ago => $days,
131
        amount      => 5, days_ago => $days,
132
        description => 'purge_zero_balance_fees should not delete fees with positive amout owed on threshold day',
132
        description => 'purge_zero_balance_fees should not delete fees with positive amount owed on threshold day',
133
        delete      => 0, credit_type => undef, debit_type => 'OVERDUE'
133
        delete      => 0, credit_type => undef, debit_type => 'OVERDUE'
134
    },
134
    },
135
    {
135
    {
136
        amount      => 5, days_ago => $days + 1,
136
        amount      => 5, days_ago => $days + 1,
137
        description => 'purge_zero_balance_fees should not delete fees with positive amout owed after threshold day',
137
        description => 'purge_zero_balance_fees should not delete fees with positive amount owed after threshold day',
138
        delete      => 0, credit_type => undef, debit_type => 'OVERDUE'
138
        delete      => 0, credit_type => undef, debit_type => 'OVERDUE'
139
    },
139
    },
140
    {
140
    {
141
        amount      => -5, days_ago => $days - 1,
141
        amount      => -5, days_ago => $days - 1,
142
        description => 'purge_zero_balance_fees should not delete fees with negative amout owed before threshold day',
142
        description => 'purge_zero_balance_fees should not delete fees with negative amount owed before threshold day',
143
        delete      => 0, credit_type => 'PAYMENT', debit_type => undef
143
        delete      => 0, credit_type => 'PAYMENT', debit_type => undef
144
    },
144
    },
145
    {
145
    {
146
        amount      => -5, days_ago => $days,
146
        amount      => -5, days_ago => $days,
147
        description => 'purge_zero_balance_fees should not delete fees with negative amout owed on threshold day',
147
        description => 'purge_zero_balance_fees should not delete fees with negative amount owed on threshold day',
148
        delete      => 0, credit_type => 'PAYMENT', debit_type => undef
148
        delete      => 0, credit_type => 'PAYMENT', debit_type => undef
149
    },
149
    },
150
    {
150
    {
151
        amount      => -5, days_ago => $days + 1,
151
        amount      => -5, days_ago => $days + 1,
152
        description => 'purge_zero_balance_fees should not delete fees with negative amout owed after threshold day',
152
        description => 'purge_zero_balance_fees should not delete fees with negative amount owed after threshold day',
153
        delete      => 0, credit_type => 'PAYMENT', debit_type => undef
153
        delete      => 0, credit_type => 'PAYMENT', debit_type => undef
154
    }
154
    }
155
);
155
);
(-)a/t/db_dependent/Acquisition.t (-1 / +1 lines)
Lines 181-187 my ( $biblionumber3, $biblioitemnumber3 ) = AddBiblio( MARC::Record->new, '' ); Link Here
181
my ( $biblionumber4, $biblioitemnumber4 ) = AddBiblio( MARC::Record->new, '' );
181
my ( $biblionumber4, $biblioitemnumber4 ) = AddBiblio( MARC::Record->new, '' );
182
my ( $biblionumber5, $biblioitemnumber5 ) = AddBiblio( MARC::Record->new, '' );
182
my ( $biblionumber5, $biblioitemnumber5 ) = AddBiblio( MARC::Record->new, '' );
183
183
184
# Prepare 6 orders, and make distinction beween fields to be tested with eq and with ==
184
# Prepare 6 orders, and make distinction between fields to be tested with eq and with ==
185
# Ex : a price of 50.1 will be stored internally as 5.100000
185
# Ex : a price of 50.1 will be stored internally as 5.100000
186
186
187
my @order_content = (
187
my @order_content = (
(-)a/t/db_dependent/Acquisition/TransferOrder.t (-1 / +1 lines)
Lines 85-91 $order = Koha::Acquisition::Orders->find( $order->{ordernumber} ); Link Here
85
is( $order->items->count,         1, "1 item in basket1's order" );
85
is( $order->items->count,         1, "1 item in basket1's order" );
86
is( scalar GetOrders($basketno2), 0, "0 order in basket2" );
86
is( scalar GetOrders($basketno2), 0, "0 order in basket2" );
87
87
88
# Transfering order to basket2
88
# Transferring order to basket2
89
my $newordernumber = TransferOrder( $ordernumber, $basketno2 );
89
my $newordernumber = TransferOrder( $ordernumber, $basketno2 );
90
is( scalar GetOrders($basketno1), 0, "0 order in basket1" );
90
is( scalar GetOrders($basketno1), 0, "0 order in basket1" );
91
is( scalar GetOrders($basketno2), 1, "1 order in basket2" );
91
is( scalar GetOrders($basketno2), 1, "1 order in basket2" );
(-)a/t/db_dependent/Auth.t (-1 / +1 lines)
Lines 82-88 subtest 'checkauth() tests' => sub { Link Here
82
82
83
    my $is_allowed = C4::Auth::haspermission( $db_user_id, { can_do => 'everything' } );
83
    my $is_allowed = C4::Auth::haspermission( $db_user_id, { can_do => 'everything' } );
84
84
85
    # FIXME This belongs to t/db_dependent/Auth/haspermission.t but we do not want to c/p the pervious mock statements
85
    # FIXME This belongs to t/db_dependent/Auth/haspermission.t but we do not want to c/p the previous mock statements
86
    ok( !$is_allowed, 'DB user should not have any permissions' );
86
    ok( !$is_allowed, 'DB user should not have any permissions' );
87
87
88
    subtest 'Prevent authentication when sending credential via GET' => sub {
88
    subtest 'Prevent authentication when sending credential via GET' => sub {
(-)a/t/db_dependent/Auth_with_ldap.t (-1 / +1 lines)
Lines 146-152 subtest 'checkpw_ldap tests' => sub { Link Here
146
    warning_is {
146
    warning_is {
147
        $ret = C4::Auth_with_ldap::checkpw_ldap( 'hola', password => 'hey' );
147
        $ret = C4::Auth_with_ldap::checkpw_ldap( 'hola', password => 'hey' );
148
    }
148
    }
149
    'LDAP connexion failed',
149
    'LDAP connection failed',
150
        'checkpw_ldap prints correct warning if LDAP conexion fails';
150
        'checkpw_ldap prints correct warning if LDAP conexion fails';
151
    is( $ret, 0, 'checkpw_ldap returns 0 if LDAP conexion fails' );
151
    is( $ret, 0, 'checkpw_ldap returns 0 if LDAP conexion fails' );
152
152
(-)a/t/db_dependent/Biblio.t (-1 / +1 lines)
Lines 397-403 sub run_tests { Link Here
397
    my $data = GetBiblioData($biblionumber);
397
    my $data = GetBiblioData($biblionumber);
398
    is(
398
    is(
399
        $data->{isbn}, $isbn,
399
        $data->{isbn}, $isbn,
400
        '(GetBiblioData) ISBN correctly retireved.'
400
        '(GetBiblioData) ISBN correctly retrieved.'
401
    );
401
    );
402
    is(
402
    is(
403
        $data->{title}, undef,
403
        $data->{title}, undef,
(-)a/t/db_dependent/Biblio/MarcOverlayRules.t (-1 / +1 lines)
Lines 1088-1094 subtest 'context option in ModBiblio is handled correctly' => sub { Link Here
1088
    DelBiblio($biblionumber);
1088
    DelBiblio($biblionumber);
1089
};
1089
};
1090
1090
1091
# Explicityly delete rule to trigger clearing of cache
1091
# Explicitly delete rule to trigger clearing of cache
1092
$rule->delete();
1092
$rule->delete();
1093
1093
1094
$schema->storage->txn_rollback;
1094
$schema->storage->txn_rollback;
(-)a/t/db_dependent/Biblio_holdsqueue.t (-1 / +1 lines)
Lines 83-89 subtest 'ModBiblio() + holds_queue update tests' => sub { Link Here
83
        $biblio->frameworkcode, { skip_holds_queue => 0 }
83
        $biblio->frameworkcode, { skip_holds_queue => 0 }
84
    );
84
    );
85
85
86
    # this call shoul not trigger the mocked 'enqueue'
86
    # this call FIXME CODESPELL (shoul ==> should, shoal, shawl) not trigger the mocked 'enqueue'
87
    C4::Biblio::ModBiblio(
87
    C4::Biblio::ModBiblio(
88
        $biblio->metadata->record, $biblio->id,
88
        $biblio->metadata->record, $biblio->id,
89
        $biblio->frameworkcode, { skip_holds_queue => 1 }
89
        $biblio->frameworkcode, { skip_holds_queue => 1 }
(-)a/t/db_dependent/Breeding.t (-1 / +1 lines)
Lines 139-145 sub test_build_translate_query { Link Here
139
    #Another try with fallback to any
139
    #Another try with fallback to any
140
    $server = { sru_fields => 'srchany=overal' };
140
    $server = { sru_fields => 'srchany=overal' };
141
    $squery = C4::Breeding::_translate_query( $server, $queries[1] );
141
    $squery = C4::Breeding::_translate_query( $server, $queries[1] );
142
    is( $squery =~ /overal/, 1, 'SRU query fallback to translated any' );
142
    is( $squery =~ /overall/, 1, 'SRU query fallback to translated any' );
143
143
144
    #Another try even without any
144
    #Another try even without any
145
    $server = { sru_fields => 'this,is,bad,input' };
145
    $server = { sru_fields => 'this,is,bad,input' };
(-)a/t/db_dependent/Budgets.t (-1 / +1 lines)
Lines 130-136 is( Link Here
130
);
130
);
131
is(
131
is(
132
    $budgetperiod->{budget_period_active}, $my_budgetperiod->{budget_period_active},
132
    $budgetperiod->{budget_period_active}, $my_budgetperiod->{budget_period_active},
133
    'ModBudgetPeriod upates active correctly'
133
    'ModBudgetPeriod updates active correctly'
134
);
134
);
135
135
136
$budgetperiods = GetBudgetPeriods();
136
$budgetperiods = GetBudgetPeriods();
(-)a/t/db_dependent/Circulation.t (-7 / +7 lines)
Lines 2007-2016 subtest "GetUpcomingDueIssues" => sub { Link Here
2007
    is( scalar(@$upcoming_dues), 1, "1 item is due today, none tomorrow" );
2007
    is( scalar(@$upcoming_dues), 1, "1 item is due today, none tomorrow" );
2008
2008
2009
    $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
2009
    $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
2010
    is( scalar(@$upcoming_dues), 2, "2 items are due withing 2 days" );
2010
    is( scalar(@$upcoming_dues), 2, "2 items are due within 2 days" );
2011
2011
2012
    $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 3 } );
2012
    $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 3 } );
2013
    is( scalar(@$upcoming_dues), 2, "2 items are due withing 2 days" );
2013
    is( scalar(@$upcoming_dues), 2, "2 items are due within 2 days" );
2014
2014
2015
    $upcoming_dues = C4::Circulation::GetUpcomingDueIssues();
2015
    $upcoming_dues = C4::Circulation::GetUpcomingDueIssues();
2016
    is( scalar(@$upcoming_dues), 2, "days_in_advance is 7 in GetUpcomingDueIssues if not provided" );
2016
    is( scalar(@$upcoming_dues), 2, "days_in_advance is 7 in GetUpcomingDueIssues if not provided" );
Lines 5709-5715 subtest 'Incremented fee tests' => sub { Link Here
5709
        }
5709
        }
5710
    );
5710
    );
5711
5711
5712
    is( $itemtype->rentalcharge_daily + 0, 1,             'Daily rental charge stored and retreived correctly' );
5712
    is( $itemtype->rentalcharge_daily + 0, 1,             'Daily rental charge stored and retrieved correctly' );
5713
    is( $item->effective_itemtype,         $itemtype->id, "Itemtype set correctly for item" );
5713
    is( $item->effective_itemtype,         $itemtype->id, "Itemtype set correctly for item" );
5714
5714
5715
    my $now         = dt_from_string;
5715
    my $now         = dt_from_string;
Lines 5774-5780 subtest 'Incremented fee tests' => sub { Link Here
5774
5774
5775
    my $calendar = C4::Calendar->new( branchcode => $library->id );
5775
    my $calendar = C4::Calendar->new( branchcode => $library->id );
5776
5776
5777
    # DateTime 1..7 (Mon..Sun), C4::Calender 0..6 (Sun..Sat)
5777
    # DateTime 1..7 (Mon..Sun), C4::Calendar 0..6 (Sun..Sat)
5778
    my $closed_day =
5778
    my $closed_day =
5779
          ( $dt_from->day_of_week == 6 ) ? 0
5779
          ( $dt_from->day_of_week == 6 ) ? 0
5780
        : ( $dt_from->day_of_week == 7 ) ? 1
5780
        : ( $dt_from->day_of_week == 7 ) ? 1
Lines 5812-5818 subtest 'Incremented fee tests' => sub { Link Here
5812
    $issue->delete();
5812
    $issue->delete();
5813
5813
5814
    $itemtype->rentalcharge(2)->store;
5814
    $itemtype->rentalcharge(2)->store;
5815
    is( $itemtype->rentalcharge + 0, 2, 'Rental charge updated and retreived correctly' );
5815
    is( $itemtype->rentalcharge + 0, 2, 'Rental charge updated and retrieved correctly' );
5816
    $issue = AddIssue( $patron, $item->barcode, $dt_to, undef, $dt_from );
5816
    $issue = AddIssue( $patron, $item->barcode, $dt_to, undef, $dt_from );
5817
    my $accountlines = Koha::Account::Lines->search( { itemnumber => $item->id } );
5817
    my $accountlines = Koha::Account::Lines->search( { itemnumber => $item->id } );
5818
    is( $accountlines->count, '2', "Fixed charge and accrued charge recorded distinctly" );
5818
    is( $accountlines->count, '2', "Fixed charge and accrued charge recorded distinctly" );
Lines 5831-5837 subtest 'Incremented fee tests' => sub { Link Here
5831
    $accountlines->delete();
5831
    $accountlines->delete();
5832
    $issue->delete();
5832
    $issue->delete();
5833
    $itemtype->rentalcharge(0)->store;
5833
    $itemtype->rentalcharge(0)->store;
5834
    is( $itemtype->rentalcharge + 0, 0, 'Rental charge reset and retreived correctly' );
5834
    is( $itemtype->rentalcharge + 0, 0, 'Rental charge reset and retrieved correctly' );
5835
5835
5836
    # Hourly
5836
    # Hourly
5837
    Koha::CirculationRules->set_rule(
5837
    Koha::CirculationRules->set_rule(
Lines 5845-5851 subtest 'Incremented fee tests' => sub { Link Here
5845
    );
5845
    );
5846
5846
5847
    $itemtype->rentalcharge_hourly('0.25')->store();
5847
    $itemtype->rentalcharge_hourly('0.25')->store();
5848
    is( $itemtype->rentalcharge_hourly, '0.25', 'Hourly rental charge stored and retreived correctly' );
5848
    is( $itemtype->rentalcharge_hourly, '0.25', 'Hourly rental charge stored and retrieved correctly' );
5849
5849
5850
    $dt_to       = $now->clone->add( hours => 168 );
5850
    $dt_to       = $now->clone->add( hours => 168 );
5851
    $dt_to_renew = $now->clone->add( hours => 312 );
5851
    $dt_to_renew = $now->clone->add( hours => 312 );
(-)a/t/db_dependent/Circulation/CalcDateDue.t (-1 / +1 lines)
Lines 113-119 $date = C4::Circulation::CalcDateDue( $start_date, $itemtype, $branchcode, $borr Link Here
113
is( $date, '2013-02-' . ( 9 + $renewalperiod ) . 'T23:59:00', "date expiry ( 9 + $renewalperiod )" );
113
is( $date, '2013-02-' . ( 9 + $renewalperiod ) . 'T23:59:00', "date expiry ( 9 + $renewalperiod )" );
114
114
115
# Now we want to test the Dayweek useDaysMode option
115
# Now we want to test the Dayweek useDaysMode option
116
# For this we need a loan period that is a mutiple of 7 days
116
# For this we need a loan period that is a multiple of 7 days
117
# But, since we currently don't have that, let's test it does the
117
# But, since we currently don't have that, let's test it does the
118
# right thing in that case, it should act as though useDaysMode is set to
118
# right thing in that case, it should act as though useDaysMode is set to
119
# Datedue
119
# Datedue
(-)a/t/db_dependent/Circulation/OfflineOperation.t (-1 / +1 lines)
Lines 84-90 is_deeply( Link Here
84
        cardnumber => 'Cardnumber1',
84
        cardnumber => 'Cardnumber1',
85
        amount     => '10.000000'
85
        amount     => '10.000000'
86
    },
86
    },
87
    "GetOffline returns offlineoperation's informations"
87
    "GetOffline returns offlineoperation's information"
88
);
88
);
89
is(
89
is(
90
    GetOfflineOperation(), undef,
90
    GetOfflineOperation(), undef,
(-)a/t/db_dependent/Circulation/TooMany.t (-3 / +3 lines)
Lines 422-429 subtest '1 Issuingrule exist: 1 CO allowed, 1 OSCO allowed, Do a OSCO' => sub { Link Here
422
422
423
subtest '1 BranchBorrowerCircRule exist: 1 CO allowed, 1 OSCO allowed' => sub {
423
subtest '1 BranchBorrowerCircRule exist: 1 CO allowed, 1 OSCO allowed' => sub {
424
424
425
    # Note: the same test coul be done for
425
    # Note: the same test could be done for
426
    # DefaultBorrowerCircRule, DefaultBranchCircRule, DefaultBranchItemRule ans DefaultCircRule.pm
426
    # DefaultBorrowerCircRule, DefaultBranchCircRule, DefaultBranchItemRule and DefaultCircRule.pm
427
427
428
    plan tests => 18;
428
    plan tests => 18;
429
    Koha::CirculationRules->set_rules(
429
    Koha::CirculationRules->set_rules(
Lines 734-740 subtest 'General vs specific rules limit quantity correctly' => sub { Link Here
734
        'We are only allowed one from that branch, and have one'
734
        'We are only allowed one from that branch, and have one'
735
    );
735
    );
736
736
737
    # Now we make anothe from a different branch
737
    # Now we make another from a different branch
738
    my $item_2 = $builder->build_sample_item(
738
    my $item_2 = $builder->build_sample_item(
739
        {
739
        {
740
            itype => $itemtype->{itemtype},
740
            itype => $itemtype->{itemtype},
(-)a/t/db_dependent/Circulation/transferbook.t (-1 / +1 lines)
Lines 37-43 subtest 'transfer a non-existant item' => sub { Link Here
37
37
38
    my $library = $builder->build( { source => 'Branch' } );
38
    my $library = $builder->build( { source => 'Branch' } );
39
39
40
    #Transfert on unknown barcode
40
    #FIXME CODESPELL (Transfert ==> Transfer, Transferred) on unknown barcode
41
    my $item  = $builder->build_sample_item();
41
    my $item  = $builder->build_sample_item();
42
    my $badbc = $item->barcode;
42
    my $badbc = $item->barcode;
43
    $item->delete;
43
    $item->delete;
(-)a/t/db_dependent/CourseReserves.t (-1 / +1 lines)
Lines 76-82 $course_id = ModCourse( Link Here
76
my $course = GetCourse($course_id);
76
my $course = GetCourse($course_id);
77
77
78
ok( $course->{'course_name'} eq "Test Course",      "GetCourse returned correct course" );
78
ok( $course->{'course_name'} eq "Test Course",      "GetCourse returned correct course" );
79
ok( $course->{'staff_note'} eq "Test staff note 2", "ModCourse updated course succesfully" );
79
ok( $course->{'staff_note'} eq "Test staff note 2", "ModCourse updated course successfully" );
80
is( $course->{'enabled'}, 'no', "Test Course is disabled" );
80
is( $course->{'enabled'}, 'no', "Test Course is disabled" );
81
81
82
my $courses = GetCourses();
82
my $courses = GetCourses();
(-)a/t/db_dependent/FrameworkPlugin.t (-1 / +1 lines)
Lines 187-193 sub test05 { Link Here
187
    foreach my $f (@$plugins) {
187
    foreach my $f (@$plugins) {
188
        $objs->{$f} = Koha::FrameworkPlugin->new($f);
188
        $objs->{$f} = Koha::FrameworkPlugin->new($f);
189
        my $pars = { dbh => $dbh, id => $f };
189
        my $pars = { dbh => $dbh, id => $f };
190
        is( $objs->{$f}->build($pars), 1, "Builded " . $objs->{$f}->name );
190
        is( $objs->{$f}->build($pars), 1, "Built " . $objs->{$f}->name );
191
    }
191
    }
192
192
193
    # test launching them (but we cannot verify returned results here)
193
    # test launching them (but we cannot verify returned results here)
(-)a/t/db_dependent/Holds/HoldFulfillmentPolicy.t (-1 / +1 lines)
Lines 184-190 $reserve_id = AddReserve( Link Here
184
is( $status, q{}, "Hold where pickup ne home, pickup ne holding not targeted" );
184
is( $status, q{}, "Hold where pickup ne home, pickup ne holding not targeted" );
185
Koha::Holds->find($reserve_id)->cancel;
185
Koha::Holds->find($reserve_id)->cancel;
186
186
187
# With hold_fulfillment_policy = any, hold should be pikcup up reguardless of matching home or holding branch
187
# With hold_fulfillment_policy = any, hold should be pikcup up regardless of matching home or holding branch
188
$dbh->do("DELETE FROM circulation_rules");
188
$dbh->do("DELETE FROM circulation_rules");
189
Koha::CirculationRules->set_rules(
189
Koha::CirculationRules->set_rules(
190
    {
190
    {
(-)a/t/db_dependent/Holds/HoldItemtypeLimit.t (-1 / +1 lines)
Lines 112-118 my $reserve_id = AddReserve( Link Here
112
    }
112
    }
113
);
113
);
114
my ($status) = CheckReserves($item);
114
my ($status) = CheckReserves($item);
115
is( $status, 'Reserved', "Hold where itemtype matches item's itemtype targed" );
115
is( $status, 'Reserved', "Hold where itemtype matches item's itemtype target" );
116
Koha::Holds->find($reserve_id)->cancel;
116
Koha::Holds->find($reserve_id)->cancel;
117
117
118
# Itemtypes don't match
118
# Itemtypes don't match
(-)a/t/db_dependent/HoldsQueue.t (-2 / +2 lines)
Lines 400-406 C4::Calendar->new( branchcode => $branchcodes[0] )->insert_single_holiday( Link Here
400
    description => "$today",
400
    description => "$today",
401
);
401
);
402
402
403
# If the test below is removed, aother tests using the holiday will fail. For some reason if we call is_holiday now
403
# If the test below is removed, FIXME CODESPELL (aother ==> another, other, mother) tests using the holiday will fail. For some reason if we call is_holiday now
404
# the holiday will get set in cache correctly, but not if we let C4::HoldsQueue call is_holiday instead.
404
# the holiday will get set in cache correctly, but not if we let C4::HoldsQueue call is_holiday instead.
405
is(
405
is(
406
    Koha::Calendar->new( branchcode => $branchcodes[0] )->is_holiday($today), 1,
406
    Koha::Calendar->new( branchcode => $branchcodes[0] )->is_holiday($today), 1,
Lines 861-867 $holds_queue = $dbh->selectall_arrayref( "SELECT * FROM tmp_holdsqueue", { Slice Link Here
861
is( @$holds_queue, 0, "Hold where pickup ne home, pickup ne holding not targeted" );
861
is( @$holds_queue, 0, "Hold where pickup ne home, pickup ne holding not targeted" );
862
Koha::Holds->find($reserve_id)->cancel;
862
Koha::Holds->find($reserve_id)->cancel;
863
863
864
# With hold_fulfillment_policy = any, hold should be pikcup up reguardless of matching home or holding branch
864
# With hold_fulfillment_policy = any, hold should be pikcup up regardless of matching home or holding branch
865
$dbh->do("DELETE FROM circulation_rules");
865
$dbh->do("DELETE FROM circulation_rules");
866
Koha::CirculationRules->set_rules(
866
Koha::CirculationRules->set_rules(
867
    {
867
    {
(-)a/t/db_dependent/ILSDI_Services.t (-1 / +1 lines)
Lines 866-872 subtest 'GetRecords' => sub { Link Here
866
        'GetRecords returns transfer informations'
866
        'GetRecords returns transfer informations'
867
    );
867
    );
868
868
869
    # Check informations exposed
869
    # Check information exposed
870
    my $reply_issue = $reply->{record}->[0]->{issues}->{issue}->[0];
870
    my $reply_issue = $reply->{record}->[0]->{issues}->{issue}->[0];
871
    is( $reply_issue->{itemnumber},     $item->itemnumber, 'GetRecords has an issue tag' );
871
    is( $reply_issue->{itemnumber},     $item->itemnumber, 'GetRecords has an issue tag' );
872
    is( $reply_issue->{borrowernumber}, undef,             'GetRecords does not expose borrowernumber in issue tag' );
872
    is( $reply_issue->{borrowernumber}, undef,             'GetRecords does not expose borrowernumber in issue tag' );
(-)a/t/db_dependent/ImportBatch.t (-2 / +2 lines)
Lines 79-85 delete $importbatch2->{profile}; Link Here
79
79
80
is_deeply(
80
is_deeply(
81
    $importbatch2, $sample_import_batch2,
81
    $importbatch2, $sample_import_batch2,
82
    "GetImportBatch returns the right informations about $sample_import_batch2"
82
    "GetImportBatch returns the right information about $sample_import_batch2"
83
);
83
);
84
84
85
my $importbatch1 = C4::ImportBatch::GetImportBatch($id_import_batch1);
85
my $importbatch1 = C4::ImportBatch::GetImportBatch($id_import_batch1);
Lines 92-98 delete $importbatch1->{profile}; Link Here
92
92
93
is_deeply(
93
is_deeply(
94
    $importbatch1, $sample_import_batch1,
94
    $importbatch1, $sample_import_batch1,
95
    "GetImportBatch returns the right informations about $sample_import_batch1"
95
    "GetImportBatch returns the right information about $sample_import_batch1"
96
);
96
);
97
97
98
my $record          = MARC::Record->new;
98
my $record          = MARC::Record->new;
(-)a/t/db_dependent/Installer.t (-1 / +1 lines)
Lines 68-74 ok( !column_exists( 'borrowers', 'xxx' ), 'Column xxx does not exist' ); Link Here
68
}
68
}
69
my @constraint_names = $source->unique_constraint_names();
69
my @constraint_names = $source->unique_constraint_names();
70
my $constraint_name  = $constraint_names[0];
70
my $constraint_name  = $constraint_names[0];
71
ok( index_exists( 'borrowers',  $constraint_name ), 'Known contraint does exist' );
71
ok( index_exists( 'borrowers',  $constraint_name ), 'Known constraint does exist' );
72
ok( !index_exists( 'borrowers', 'xxx' ),            'Constraint xxx does not exist' );
72
ok( !index_exists( 'borrowers', 'xxx' ),            'Constraint xxx does not exist' );
73
73
74
ok( foreign_key_exists( 'borrowers',  'borrowers_ibfk_1' ), 'FK borrowers_ibfk_1 exists' );
74
ok( foreign_key_exists( 'borrowers',  'borrowers_ibfk_1' ), 'FK borrowers_ibfk_1 exists' );
(-)a/t/db_dependent/Koha/Account.t (-1 / +1 lines)
Lines 1262-1268 subtest 'Koha::Account::pay() generates credit number (Koha::Account::Line->stor Link Here
1262
    $accountlines_id =
1262
    $accountlines_id =
1263
        $account->pay( { type => 'WRITEOFF', amount => '1.00', library_id => $library->id } )->{payment_id};
1263
        $account->pay( { type => 'WRITEOFF', amount => '1.00', library_id => $library->id } )->{payment_id};
1264
    $accountline = Koha::Account::Lines->find($accountlines_id);
1264
    $accountline = Koha::Account::Lines->find($accountlines_id);
1265
    is( $accountline->credit_number, undef, "Annual format credit number not aded for writeoff" );
1265
    is( $accountline->credit_number, undef, "Annual format credit number not added for writeoff" );
1266
1266
1267
    t::lib::Mocks::mock_preference( 'AutoCreditNumber', 'branchyyyymmincr' );
1267
    t::lib::Mocks::mock_preference( 'AutoCreditNumber', 'branchyyyymmincr' );
1268
    for my $i ( 1 .. 11 ) {
1268
    for my $i ( 1 .. 11 ) {
(-)a/t/db_dependent/Koha/Acquisition/Basket.t (-1 / +1 lines)
Lines 225-231 subtest 'estimated_delivery_date' => sub { Link Here
225
    $bookseller->deliverytime(2)->store;                                # 2 delivery days
225
    $bookseller->deliverytime(2)->store;                                # 2 delivery days
226
    is(
226
    is(
227
        $basket->estimated_delivery_date,
227
        $basket->estimated_delivery_date,
228
        undef, 'return undef if closedate is not defined (basket stil open)'
228
        undef, 'return undef if closedate is not defined (basket still open)'
229
    );
229
    );
230
230
231
    $bookseller->deliverytime(2)->store;                                # 2 delivery days
231
    $bookseller->deliverytime(2)->store;                                # 2 delivery days
(-)a/t/db_dependent/Koha/Charges/Fees.t (-1 / +1 lines)
Lines 365-371 subtest 'accumulate_rentalcharge tests' => sub { Link Here
365
365
366
    my $calendar = C4::Calendar->new( branchcode => $library->id );
366
    my $calendar = C4::Calendar->new( branchcode => $library->id );
367
367
368
    # DateTime 1..7 (Mon..Sun), C4::Calender 0..6 (Sun..Sat)
368
    # DateTime 1..7 (Mon..Sun), C4::Calendar 0..6 (Sun..Sat)
369
    my $closed_day =
369
    my $closed_day =
370
          ( $dt_from->day_of_week == 6 ) ? 0
370
          ( $dt_from->day_of_week == 6 ) ? 0
371
        : ( $dt_from->day_of_week == 7 ) ? 1
371
        : ( $dt_from->day_of_week == 7 ) ? 1
(-)a/t/db_dependent/Koha/Objects.t (-8 / +8 lines)
Lines 193-199 subtest 'search_related' => sub { Link Here
193
        ->search_related('branchcode');
193
        ->search_related('branchcode');
194
    is(
194
    is(
195
        ref($libraries), 'Koha::Libraries',
195
        ref($libraries), 'Koha::Libraries',
196
        'Koha::Objects->search_related should return an instanciated Koha::Objects-based object'
196
        'Koha::Objects->search_related should return an instantiated Koha::Objects-based object'
197
    );
197
    );
198
    is(
198
    is(
199
        $libraries->count, 2,
199
        $libraries->count, 2,
Lines 518-524 subtest 'Return same values as DBIx::Class' => sub { Link Here
518
                    !defined $e_us && !defined $e_them,
518
                    !defined $e_us && !defined $e_them,
519
                    'Successful delete should not raise an exception'
519
                    'Successful delete should not raise an exception'
520
                );
520
                );
521
                is( ref($r_us), 'Koha::City', 'Successful delete should return our Koha::Obect based object' );
521
                is( ref($r_us), 'Koha::City', 'Successful delete should return our Koha::Object based object' );
522
522
523
                # CASE 2 - Delete an object that is not in storage
523
                # CASE 2 - Delete an object that is not in storage
524
                try { $r_us   = $r_us->delete; } catch   { $e_us   = $_ };
524
                try { $r_us   = $r_us->delete; } catch   { $e_us   = $_ };
Lines 528-534 subtest 'Return same values as DBIx::Class' => sub { Link Here
528
                    'Delete an object that is not in storage should raise an exception'
528
                    'Delete an object that is not in storage should raise an exception'
529
                );
529
                );
530
                is( ref($e_us), 'DBIx::Class::Exception' )
530
                is( ref($e_us), 'DBIx::Class::Exception' )
531
                    ;    # FIXME This needs adjustement, we want to throw a Koha::Exception
531
                    ;    # FIXME This needs adjustment, we want to throw a Koha::Exception
532
532
533
            };
533
            };
534
534
Lines 647-653 subtest 'Return same values as DBIx::Class' => sub { Link Here
647
                );
647
                );
648
                is(
648
                is(
649
                    ref($r_us), 'Koha::Patron',
649
                    ref($r_us), 'Koha::Patron',
650
                    'Successful delete should return our Koha::Obect based object'
650
                    'Successful delete should return our Koha::Object based object'
651
                );
651
                );
652
652
653
                # CASE 2 - Delete a patron that is not in storage
653
                # CASE 2 - Delete a patron that is not in storage
Lines 658-664 subtest 'Return same values as DBIx::Class' => sub { Link Here
658
                    'Delete a patron that is not in storage should raise an exception'
658
                    'Delete a patron that is not in storage should raise an exception'
659
                );
659
                );
660
                is( ref($e_us), 'DBIx::Class::Exception' )
660
                is( ref($e_us), 'DBIx::Class::Exception' )
661
                    ;    # FIXME This needs adjustement, we want to throw a Koha::Exception
661
                    ;    # FIXME This needs adjustment, we want to throw a Koha::Exception
662
662
663
                # CASE 3 - Delete a patron that cannot be deleted (as a checkout)
663
                # CASE 3 - Delete a patron that cannot be deleted (as a checkout)
664
                $patron = Koha::Patron->new($patron_data)->store;
664
                $patron = Koha::Patron->new($patron_data)->store;
Lines 676-682 subtest 'Return same values as DBIx::Class' => sub { Link Here
676
                    'Delete a patron that cannot be deleted should raise an exception'
676
                    'Delete a patron that cannot be deleted should raise an exception'
677
                );
677
                );
678
                is( ref($e_us), 'DBIx::Class::Exception' )
678
                is( ref($e_us), 'DBIx::Class::Exception' )
679
                    ;    # FIXME This needs adjustement, we want to throw a Koha::Exception
679
                    ;    # FIXME This needs adjustment, we want to throw a Koha::Exception
680
            };
680
            };
681
681
682
            subtest 'Koha::Objects->delete' => sub {
682
            subtest 'Koha::Objects->delete' => sub {
Lines 871-877 subtest 'Return same values as DBIx::Class' => sub { Link Here
871
                    !defined $e_us && !defined $e_them,
871
                    !defined $e_us && !defined $e_them,
872
                    'Successful update should not raise an exception'
872
                    'Successful update should not raise an exception'
873
                );
873
                );
874
                is( ref($r_us), 'Koha::City', 'Successful update should return our Koha::Obect based object' );
874
                is( ref($r_us), 'Koha::City', 'Successful update should return our Koha::Object based object' );
875
875
876
                # CASE 2 - Update an object that is not in storage
876
                # CASE 2 - Update an object that is not in storage
877
                $c_us->delete;
877
                $c_us->delete;
Lines 1008-1014 subtest 'Return same values as DBIx::Class' => sub { Link Here
1008
                );
1008
                );
1009
                is(
1009
                is(
1010
                    ref($r_us), 'Koha::Patron',
1010
                    ref($r_us), 'Koha::Patron',
1011
                    'Successful update should return our Koha::Obect based object'
1011
                    'Successful update should return our Koha::Object based object'
1012
                );
1012
                );
1013
1013
1014
                # CASE 2 - Update a patron that is not in storage
1014
                # CASE 2 - Update a patron that is not in storage
(-)a/t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t (-1 / +1 lines)
Lines 76-82 is_deeply( Link Here
76
    [
76
    [
77
        map {
77
        map {
78
            {
78
            {
79
                # We are bascially removing the 'id' field here
79
                # We are basically removing the 'id' field here
80
                field_id  => $_->{field_id},
80
                field_id  => $_->{field_id},
81
                record_id => $_->{record_id},
81
                record_id => $_->{record_id},
82
                value     => $_->{value},
82
                value     => $_->{value},
(-)a/t/db_dependent/Koha/Patrons.t (-2 / +2 lines)
Lines 2399-2405 subtest '->set_password' => sub { Link Here
2399
2399
2400
    # Refresh patron from DB, just to make sure
2400
    # Refresh patron from DB, just to make sure
2401
    $patron->discard_changes;
2401
    $patron->discard_changes;
2402
    is( $patron->login_attempts, 3, 'Previous tests kept login attemps count' );
2402
    is( $patron->login_attempts, 3, 'Previous tests kept login attempts count' );
2403
2403
2404
    $patron->set_password( { password => 'abcD12 34' } );
2404
    $patron->set_password( { password => 'abcD12 34' } );
2405
    $patron->discard_changes;
2405
    $patron->discard_changes;
Lines 2418-2424 subtest '->set_password' => sub { Link Here
2418
2418
2419
    isnt( $patron->password, $old_digest, 'Password has been updated' );
2419
    isnt( $patron->password, $old_digest, 'Password has been updated' );
2420
    ok( checkpw_hash( 'abcd   a', $patron->password ), 'Password hash is correct' );
2420
    ok( checkpw_hash( 'abcd   a', $patron->password ), 'Password hash is correct' );
2421
    is( $patron->login_attempts, 0, 'Login attemps have been reset' );
2421
    is( $patron->login_attempts, 0, 'Login attempts have been reset' );
2422
2422
2423
    my $number_of_logs = $schema->resultset('ActionLog')
2423
    my $number_of_logs = $schema->resultset('ActionLog')
2424
        ->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $patron->borrowernumber } )->count;
2424
        ->search( { module => 'MEMBERS', action => 'CHANGE PASS', object => $patron->borrowernumber } )->count;
(-)a/t/db_dependent/Koha/Patrons/Import.t (-1 / +1 lines)
Lines 682-688 is( $result_6->{overwritten}, 0, 'Got the expected 0 overwritten result from imp Link Here
682
682
683
# Given ... 2 new inputs. One without dateofbirth, dateenrolled and dateexpiry values.
683
# Given ... 2 new inputs. One without dateofbirth, dateenrolled and dateexpiry values.
684
my $input_complete =
684
my $input_complete =
685
    '1009,Christina,Harris,Dr,Philip,CH,99,Street,Grayhawk,Baton Rouge,Dallas,Louisiana,70810,United States,pharris9@hp.com,9-(317)603-5513,7-(005)062-7593,8-(349)134-1627,06/19/1969,IPT,PT,04/09/2015,07/01/2015,pharris9,NcAhcvvnB';
685
    '1009,Christina,Harris,Dr,Philip,CH,99,Street,Grayhawk,Baton Rogue,Dallas,Louisiana,70810,United States,pharris9@hp.com,9-(317)603-5513,7-(005)062-7593,8-(349)134-1627,06/19/1969,IPT,PT,04/09/2015,07/01/2015,pharris9,NcAhcvvnB';
686
my $input_no_date =
686
my $input_no_date =
687
    '1010,Ralph,Warren,Ms,Linda,RW,6,Way,Barby,Orlando,Albany,Florida,32803,United States,lwarrena@multiply.com,7-(579)753-7752,6-(847)086-7566,9-(122)729-8226,26/01/2001,LPL,T,25/01/2001,24/01/2001,lwarrena,tJ56RD4uV';
687
    '1010,Ralph,Warren,Ms,Linda,RW,6,Way,Barby,Orlando,Albany,Florida,32803,United States,lwarrena@multiply.com,7-(579)753-7752,6-(847)086-7566,9-(122)729-8226,26/01/2001,LPL,T,25/01/2001,24/01/2001,lwarrena,tJ56RD4uV';
688
688
(-)a/t/db_dependent/Koha/REST/Plugin/Objects.t (-1 / +1 lines)
Lines 263-269 subtest 'objects.search helper, sorting on mapped column' => sub { Link Here
263
        ->json_is( '/2/country' => 'Belarus' )->json_is( '/3/name' => 'C' )->json_is( '/3/country' => 'Argentina' )
263
        ->json_is( '/2/country' => 'Belarus' )->json_is( '/3/name' => 'C' )->json_is( '/3/country' => 'Argentina' )
264
        ->json_hasnt('/4');
264
        ->json_hasnt('/4');
265
265
266
    # Multi-param: PHP Style, Passes validation as above, subsequntly explodes
266
    # Multi-param: PHP Style, Passes validation as above, subsequently explodes
267
    $t->get_ok('/cities?_order_by[]=%2Bname&_order_by[]=-country')->status_is(200)->json_has('/0')->json_has('/1')
267
    $t->get_ok('/cities?_order_by[]=%2Bname&_order_by[]=-country')->status_is(200)->json_has('/0')->json_has('/1')
268
        ->json_is( '/0/name' => 'A' )->json_is( '/1/name' => 'B' )->json_is( '/2/name' => 'C' )
268
        ->json_is( '/0/name' => 'A' )->json_is( '/1/name' => 'B' )->json_is( '/2/name' => 'C' )
269
        ->json_is( '/2/country' => 'Belarus' )->json_is( '/3/name' => 'C' )->json_is( '/3/country' => 'Argentina' )
269
        ->json_is( '/2/country' => 'Belarus' )->json_is( '/3/name' => 'C' )->json_is( '/3/country' => 'Argentina' )
(-)a/t/db_dependent/Koha/Reviews.t (-1 / +1 lines)
Lines 59-65 my $new_review_2_1 = Koha::Review->new( Link Here
59
    {
59
    {
60
        borrowernumber => $patron_2->borrowernumber,
60
        borrowernumber => $patron_2->borrowernumber,
61
        biblionumber   => $biblio_1->biblionumber,
61
        biblionumber   => $biblio_1->biblionumber,
62
        review         => 'just anoter review',
62
        review         => 'just another review',
63
    }
63
    }
64
)->store;
64
)->store;
65
65
(-)a/t/db_dependent/Koha/Subscription/Routinglists.t (-1 / +1 lines)
Lines 8-14 Link Here
8
# (at your option) any later version.
8
# (at your option) any later version.
9
#
9
#
10
# Koha is distributed in the hope that it will be useful, but
10
# Koha is distributed in the hope that it will be useful, but
11
# WIT HOUT ANY WARRANTY; without even the implied warranty of
11
# WITH HOUT ANY WARRANTY; without even the implied warranty of
12
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13
# GNU General Public License for more details.
13
# GNU General Public License for more details.
14
#
14
#
(-)a/t/db_dependent/Koha/Template/Plugin/Koha.t (-1 / +1 lines)
Lines 49-55 subtest 'GenerateCSRF() tests' => sub { Link Here
49
    $schema->storage->txn_rollback;
49
    $schema->storage->txn_rollback;
50
};
50
};
51
51
52
subtest 'GenerateCSRF - New CSRF token generated everytime we need one' => sub {
52
subtest 'GenerateCSRF - New CSRF token generated every time we need one' => sub {
53
    plan tests => 2;
53
    plan tests => 2;
54
54
55
    $schema->storage->txn_begin;
55
    $schema->storage->txn_begin;
(-)a/t/db_dependent/LDAP/test_ldap_add.pl (-1 / +1 lines)
Lines 66-72 sub ldap_search { Link Here
66
    $query->code and die sprintf 'error (code:%s) - %s', $query->code, $query->error;
66
    $query->code and die sprintf 'error (code:%s) - %s', $query->code, $query->error;
67
    my $size = scalar( $query->entries );
67
    my $size = scalar( $query->entries );
68
    my $i    = 5;
68
    my $i    = 5;
69
    print "\nNumber of records returned from search: $size.\n";
69
    print "\number of records returned from search: $size.\n";
70
    ( $size > $i ) and print "Displaying the last $i records.\n\n";
70
    ( $size > $i ) and print "Displaying the last $i records.\n\n";
71
    foreach ( $query->entries ) {
71
    foreach ( $query->entries ) {
72
        ( $size-- > $i ) and next;
72
        ( $size-- > $i ) and next;
(-)a/t/db_dependent/Languages.t (-1 / +1 lines)
Lines 27-33 my $schema = Koha::Database->new->schema; Link Here
27
$schema->storage->txn_begin;
27
$schema->storage->txn_begin;
28
my $dbh = C4::Context->dbh;
28
my $dbh = C4::Context->dbh;
29
29
30
isnt( C4::Languages::_get_themes(), undef, 'testing _get_themes doesnt return undef' );
30
isnt( C4::Languages::_get_themes(), undef, 'testing _get_themes FIXME CODESPELL (doesnt ==> doesn't, does not) return undef' );
31
31
32
ok( C4::Languages::_get_language_dirs(), 'test getting _get_language_dirs' );
32
ok( C4::Languages::_get_language_dirs(), 'test getting _get_language_dirs' );
33
33
(-)a/t/db_dependent/Letters.t (-1 / +1 lines)
Lines 224-230 isnt( Link Here
224
    $messages->[0]->{updated_on}, $messages->[0]->{time_queued},
224
    $messages->[0]->{updated_on}, $messages->[0]->{time_queued},
225
    'Time status changed differs from time queued when status changes'
225
    'Time status changed differs from time queued when status changes'
226
);
226
);
227
is( dt_from_string( $messages->[0]->{time_queued} ), $yesterday, 'Time queued remaines inmutable' );
227
is( dt_from_string( $messages->[0]->{time_queued} ), $yesterday, 'Time queued FIXME CODESPELL (remaines ==> remains, remained) inmutable' );
228
228
229
# ResendMessage
229
# ResendMessage
230
my $resent = C4::Letters::ResendMessage( $messages->[0]->{message_id} );
230
my $resent = C4::Letters::ResendMessage( $messages->[0]->{message_id} );
(-)a/t/db_dependent/MarcModificationTemplates.t (-4 / +4 lines)
Lines 440-449 is( Link Here
440
        '245',        '',             '', '', '',
440
        '245',        '',             '', '', '',
441
        '',           '',             '',
441
        '',           '',             '',
442
        'if',         '245',          'a', 'equals', '^Bad title', '1',
442
        'if',         '245',          'a', 'equals', '^Bad title', '1',
443
        'Delete first 245$a mathing ^Bad title'
443
        'Delete first 245$a matching ^Bad title'
444
    ),
444
    ),
445
    1,
445
    1,
446
    'Delete first 245$a mathing ^Bad title'
446
    'Delete first 245$a matching ^Bad title'
447
);
447
);
448
448
449
$record = new_record();
449
$record = new_record();
Lines 471-480 is( Link Here
471
        '245',        '',             '', '', '',
471
        '245',        '',             '', '', '',
472
        '',           '',             '',
472
        '',           '',             '',
473
        'if',         '245',          'a', 'equals', 'updated$', '1',
473
        'if',         '245',          'a', 'equals', 'updated$', '1',
474
        'Delete first 245$a mathing updated$'
474
        'Delete first 245$a matching updated$'
475
    ),
475
    ),
476
    1,
476
    1,
477
    'Delete first 245$a mathing updated$'
477
    'Delete first 245$a matching updated$'
478
);
478
);
479
479
480
$record = new_record();
480
$record = new_record();
(-)a/t/db_dependent/Matcher.t (-1 / +1 lines)
Lines 60-66 subtest 'GetMatcherList' => sub { Link Here
60
    ok( $testmatcher = C4::Matcher->new( 'blue', 0 ), 'testing matcher new' );
60
    ok( $testmatcher = C4::Matcher->new( 'blue', 0 ), 'testing matcher new' );
61
61
62
    $testmatcher->threshold(1000);
62
    $testmatcher->threshold(1000);
63
    is( $testmatcher->threshold(), 1000, 'testing threshhold accessor method' );
63
    is( $testmatcher->threshold(), 1000, 'testing threshold accessor method' );
64
64
65
    $testmatcher->_id(53);
65
    $testmatcher->_id(53);
66
    is( $testmatcher->_id(), 53, 'testing _id accessor' );
66
    is( $testmatcher->_id(), 53, 'testing _id accessor' );
(-)a/t/db_dependent/Patron/Borrower_PrevCheckout.t (-1 / +1 lines)
Lines 362-368 test_it( $cpvPmappings, "PostReturn" ); Link Here
362
# We have already tested ->wants_check_for_previous_checkout and
362
# We have already tested ->wants_check_for_previous_checkout and
363
# ->do_check_for_previous_checkout, so all that remains to be tested is
363
# ->do_check_for_previous_checkout, so all that remains to be tested is
364
# whetherthe different combinational outcomes of the above return values in
364
# whetherthe different combinational outcomes of the above return values in
365
# CanBookBeIssued result in the approriate $needsconfirmation.
365
# CanBookBeIssued result in the appropriate $needsconfirmation.
366
366
367
# We want to test:
367
# We want to test:
368
# - DESCRIPTION [RETURNVALUE (0/1)]
368
# - DESCRIPTION [RETURNVALUE (0/1)]
(-)a/t/db_dependent/Prices.t (-2 / +2 lines)
Lines 511-521 subtest 'Tests from t' => sub { Link Here
511
        t::lib::Mocks::mock_preference( 'CurrencyFormat', $currency_format );
511
        t::lib::Mocks::mock_preference( 'CurrencyFormat', $currency_format );
512
        is(
512
        is(
513
            Koha::Number::Price->new(1234567)->format_for_editing, '1234567.00',
513
            Koha::Number::Price->new(1234567)->format_for_editing, '1234567.00',
514
            'format_for_editing should return unformated integer part with 2 decimals'
514
            'format_for_editing should return unformatted integer part with 2 decimals'
515
        );
515
        );
516
        is(
516
        is(
517
            Koha::Number::Price->new(1234567.89)->format_for_editing, '1234567.89',
517
            Koha::Number::Price->new(1234567.89)->format_for_editing, '1234567.89',
518
            'format_for_editing should return unformated integer part with 2 decimals'
518
            'format_for_editing should return unformatted integer part with 2 decimals'
519
        );
519
        );
520
    }
520
    }
521
};
521
};
(-)a/t/db_dependent/Reports.t (-1 / +1 lines)
Lines 13-17 BEGIN { Link Here
13
    use_ok( 'C4::Reports', qw( GetDelimiterChoices ) );
13
    use_ok( 'C4::Reports', qw( GetDelimiterChoices ) );
14
}
14
}
15
15
16
ok( GetDelimiterChoices(), "Testing getting delimeter choices" )
16
ok( GetDelimiterChoices(), "Testing getting delimiter choices" )
17
    ;    #Not testing the value of the output just that it returns something.
17
    ;    #Not testing the value of the output just that it returns something.
(-)a/t/db_dependent/Reserves.t (-1 / +1 lines)
Lines 228-234 $itemnum_fpl = $builder->build_sample_item( Link Here
228
    }
228
    }
229
)->itemnumber;
229
)->itemnumber;
230
230
231
# Ensure that priorities are numbered correcly when a hold is moved to waiting
231
# Ensure that priorities are numbered correctly when a hold is moved to waiting
232
# (bug 11947)
232
# (bug 11947)
233
$dbh->do( "DELETE FROM reserves WHERE biblionumber=?", undef, ($bibnum2) );
233
$dbh->do( "DELETE FROM reserves WHERE biblionumber=?", undef, ($bibnum2) );
234
AddReserve(
234
AddReserve(
(-)a/t/db_dependent/RotatingCollections.t (-3 / +3 lines)
Lines 164-176 my @collection1 = GetCollection($collection_id1); Link Here
164
is_deeply(
164
is_deeply(
165
    \@collection1,
165
    \@collection1,
166
    [ $collection_id1, 'Collection1', 'Description1', undef ],
166
    [ $collection_id1, 'Collection1', 'Description1', undef ],
167
    "Collection1's informations"
167
    "Collection1's information"
168
);
168
);
169
my @collection2 = GetCollection($collection_id2);
169
my @collection2 = GetCollection($collection_id2);
170
is_deeply(
170
is_deeply(
171
    \@collection2,
171
    \@collection2,
172
    [ $collection_id2, 'Collection2 modified', 'Description2 modified', undef ],
172
    [ $collection_id2, 'Collection2 modified', 'Description2 modified', undef ],
173
    "Collection2's informations"
173
    "Collection2's information"
174
);
174
);
175
my @undef_collection = GetCollection();
175
my @undef_collection = GetCollection();
176
is_deeply(
176
is_deeply(
Lines 207-213 Koha::Library->new($samplebranch)->store; Link Here
207
my ( $transferred, $messages ) = TransferCollection( $collection_id1, $samplebranch->{branchcode} );
207
my ( $transferred, $messages ) = TransferCollection( $collection_id1, $samplebranch->{branchcode} );
208
is(
208
is(
209
    $transferred,
209
    $transferred,
210
    1, "Collection1 has been transfered in the branch SAB"
210
    1, "Collection1 has been transferred in the branch SAB"
211
);
211
);
212
@collection1 = GetCollection($collection_id1);
212
@collection1 = GetCollection($collection_id1);
213
is_deeply(
213
is_deeply(
(-)a/t/db_dependent/SIP/SIPServer.t (-1 / +1 lines)
Lines 1-7 Link Here
1
#!/usr/bin/perl
1
#!/usr/bin/perl
2
2
3
# This test is db dependent: SIPServer needs MsgType which needs Auth.
3
# This test is db dependent: SIPServer needs MsgType which needs Auth.
4
# And Auth needs config vars and prefences in its BEGIN block.
4
# And Auth needs config vars and preferences in its BEGIN block.
5
5
6
# This file is part of Koha.
6
# This file is part of Koha.
7
#
7
#
(-)a/t/db_dependent/Search.t (-2 / +2 lines)
Lines 1156-1167 sub run_unimarc_search_tests { Link Here
1156
        ['mainentry'], ['and'], [''], ['contains'],
1156
        ['mainentry'], ['and'], [''], ['contains'],
1157
        ['wil'], 0, 10, '', '', 1
1157
        ['wil'], 0, 10, '', '', 1
1158
    );
1158
    );
1159
    is( $count, 11, 'UNIMARC authorities: hits on mainentry contains "wil"' );
1159
    is( $count, 11, 'UNIMARC authorities: hits on mainentry contains "FIXME CODESPELL (wil ==> will, well)"' );
1160
    ( $auths, $count ) = SearchAuthorities(
1160
    ( $auths, $count ) = SearchAuthorities(
1161
        ['match'], ['and'], [''], ['contains'],
1161
        ['match'], ['and'], [''], ['contains'],
1162
        ['wil'],   0, 10, '', '', 1
1162
        ['wil'],   0, 10, '', '', 1
1163
    );
1163
    );
1164
    is( $count, 11, 'UNIMARC authorities: hits on match contains "wil"' );
1164
    is( $count, 11, 'UNIMARC authorities: hits on match contains "FIXME CODESPELL (wil ==> will, well)"' );
1165
    ( $auths, $count ) = SearchAuthorities(
1165
    ( $auths, $count ) = SearchAuthorities(
1166
        ['mainentry'], ['and'], [''], ['contains'],
1166
        ['mainentry'], ['and'], [''], ['contains'],
1167
        ['michel'],    0, 20, '', '', 1
1167
        ['michel'],    0, 20, '', '', 1
(-)a/t/db_dependent/Serials.t (-3 / +3 lines)
Lines 404-410 subtest 'GetSubscriptionsFromBiblionumber' => sub { Link Here
404
is( C4::Serials::GetSerials(),  undef, 'test getting serials when you enter nothing' );
404
is( C4::Serials::GetSerials(),  undef, 'test getting serials when you enter nothing' );
405
is( C4::Serials::GetSerials2(), undef, 'test getting serials when you enter nothing' );
405
is( C4::Serials::GetSerials2(), undef, 'test getting serials when you enter nothing' );
406
406
407
is( C4::Serials::GetLatestSerials(), undef, 'test getting lastest serials' );
407
is( C4::Serials::GetLatestSerials(), undef, 'test getting FIXME CODESPELL (lastest ==> latest, last) serials' );
408
408
409
is( C4::Serials::GetNextSeq(), undef, 'test getting next seq when you enter nothing' );
409
is( C4::Serials::GetNextSeq(), undef, 'test getting next seq when you enter nothing' );
410
410
Lines 618-624 subtest "Do not generate an expected if one already exists" => sub { Link Here
618
        $publisheddate, $publisheddate, '1', 'an useless note'
618
        $publisheddate, $publisheddate, '1', 'an useless note'
619
    );
619
    );
620
    @serialsByStatus = C4::Serials::findSerialsByStatus( 1, $subscriptionid );
620
    @serialsByStatus = C4::Serials::findSerialsByStatus( 1, $subscriptionid );
621
    is( @serialsByStatus, 1, "ModSerialStatus delete corectly serial expected and create another if not exist" );
621
    is( @serialsByStatus, 1, "ModSerialStatus delete correctly serial expected and create another if not exist" );
622
622
623
    # add 1 serial with status=Expected 1
623
    # add 1 serial with status=Expected 1
624
    C4::Serials::ModSerialStatus(
624
    C4::Serials::ModSerialStatus(
Lines 635-641 subtest "Do not generate an expected if one already exists" => sub { Link Here
635
635
636
    #try if create or not another serial with status is expected
636
    #try if create or not another serial with status is expected
637
    @serialsByStatus = C4::Serials::findSerialsByStatus( 1, $subscriptionid );
637
    @serialsByStatus = C4::Serials::findSerialsByStatus( 1, $subscriptionid );
638
    is( @serialsByStatus, 1, "ModSerialStatus delete corectly serial expected and not create another if exists" );
638
    is( @serialsByStatus, 1, "ModSerialStatus delete correctly serial expected and not create another if exists" );
639
};
639
};
640
640
641
subtest "PreserveSerialNotes preference" => sub {
641
subtest "PreserveSerialNotes preference" => sub {
(-)a/t/db_dependent/Serials/ReNewSubscription.t (-1 / +1 lines)
Lines 155-161 is( $monthlength, undef, "Subscription length is undef months, invalid month dat Link Here
155
( $numberlength, $weeklength, $monthlength ) = GetSubscriptionLength( 'issues', 'w' );
155
( $numberlength, $weeklength, $monthlength ) = GetSubscriptionLength( 'issues', 'w' );
156
is( $monthlength, undef, "Subscription length is undef issues, invalid issue data was not stored" );
156
is( $monthlength, undef, "Subscription length is undef issues, invalid issue data was not stored" );
157
157
158
# Check subscription length when a special character is inputted into numberic sublength field
158
# Check subscription length when a special character is inputted into numeric sublength field
159
( $numberlength, $weeklength, $monthlength ) = GetSubscriptionLength( 'weeks', '!' );
159
( $numberlength, $weeklength, $monthlength ) = GetSubscriptionLength( 'weeks', '!' );
160
is( $weeklength, undef, "Subscription length is undef weeks, invalid weeks data was not stored" );
160
is( $weeklength, undef, "Subscription length is undef weeks, invalid weeks data was not stored" );
161
161
(-)a/t/db_dependent/Sitemapper.t (-2 / +2 lines)
Lines 52-58 subtest 'Sitemapper' => sub { Link Here
52
52
53
    my $dir = C4::Context::temporary_directory;
53
    my $dir = C4::Context::temporary_directory;
54
54
55
    # Create a sitemap for a catalog containg 2 biblios, with option 'long url'
55
    # Create a sitemap for a catalog containing 2 biblios, with option 'long url'
56
    my $sitemapper = Koha::Sitemapper->new(
56
    my $sitemapper = Koha::Sitemapper->new(
57
        verbose => 0,
57
        verbose => 0,
58
        url     => 'http://www.mylibrary.org',
58
        url     => 'http://www.mylibrary.org',
Lines 96-102 EOS Link Here
96
EOS
96
EOS
97
    is( $file_content, $expected_content, 'Its content is valid' );
97
    is( $file_content, $expected_content, 'Its content is valid' );
98
98
99
    # Create a sitemap for a catalog containg 2 biblios, with option 'short url'.
99
    # Create a sitemap for a catalog containing 2 biblios, with option 'short url'.
100
    # Test that 2 files are created.
100
    # Test that 2 files are created.
101
    $sitemapper = Koha::Sitemapper->new(
101
    $sitemapper = Koha::Sitemapper->new(
102
        verbose => 0,
102
        verbose => 0,
(-)a/t/db_dependent/TestBuilder.t (-1 / +1 lines)
Lines 569-575 subtest '->build parameter' => sub { Link Here
569
    warnings_like {
569
    warnings_like {
570
        $builder->build( { source => 'Borrower', categorycode => 'foobar' } );
570
        $builder->build( { source => 'Borrower', categorycode => 'foobar' } );
571
    }
571
    }
572
    qr{Unknown parameter\(s\): categorycode}, "Unkown parameter detected";
572
    qr{Unknown parameter\(s\): categorycode}, "Unknown parameter detected";
573
573
574
    $schema->storage->txn_rollback;
574
    $schema->storage->txn_rollback;
575
};
575
};
(-)a/t/db_dependent/Utils/Datatables_Virtualshelves.t (-2 / +2 lines)
Lines 188-194 t::lib::Mocks::mock_userenv( { patron => $john_doe_patron } ); Link Here
188
# Search private lists by title
188
# Search private lists by title
189
$search_results = C4::Utils::DataTables::VirtualShelves::search(
189
$search_results = C4::Utils::DataTables::VirtualShelves::search(
190
    {
190
    {
191
        shelfname => "ist",
191
        shelfname => "FIXME CODESPELL (ist ==> is, it, its, it's, sit, list)",
192
        %dt_params,
192
        %dt_params,
193
        public => 0,
193
        public => 0,
194
    }
194
    }
Lines 201-207 is( Link Here
201
201
202
is(
202
is(
203
    $search_results->{recordsFiltered}, 2,
203
    $search_results->{recordsFiltered}, 2,
204
    "There should be 2 private shelves with title like '%ist%"
204
    "There should be 2 private shelves with title like '%FIXME CODESPELL (ist ==> is, it, its, it's, sit, list)%"
205
);
205
);
206
206
207
is(
207
is(
(-)a/t/db_dependent/selenium/basic_workflow.t (-1 / +1 lines)
Lines 280-286 SKIP: { Link Here
280
    $driver->get( $base_url . "/reserve/request.pl?borrowernumber=$borrowernumber&biblionumber=" . $biblionumbers[0] );
280
    $driver->get( $base_url . "/reserve/request.pl?borrowernumber=$borrowernumber&biblionumber=" . $biblionumbers[0] );
281
    $driver->find_element('//form[@id="hold-request-form"]//button[@type="submit"]')->click;    # Biblio level
281
    $driver->find_element('//form[@id="hold-request-form"]//button[@type="submit"]')->click;    # Biblio level
282
    $driver->pause(1000)
282
    $driver->pause(1000)
283
        ; # This seems wrong, since bug 19618 the hold is created async with an AJAX call. Not sure what is happening here but the next statements are exectuted before the hold is created and the count is wrong (still 0)
283
        ; # This seems wrong, since bug 19618 the hold is created async with an AJAX call. Not sure what is happening here but the next statements are executed before the hold is created and the count is wrong (still 0)
284
    my $patron = Koha::Patrons->find($borrowernumber);
284
    my $patron = Koha::Patrons->find($borrowernumber);
285
    is( $patron->holds->count, 1, );
285
    is( $patron->holds->count, 1, );
286
286
(-)a/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt (-5 / +5 lines)
Lines 252-260 Link Here
252
        [% WRAPPER tab_panel tabname= "perl" bt_active = 1 %]
252
        [% WRAPPER tab_panel tabname= "perl" bt_active = 1 %]
253
            <table style="cursor:pointer">
253
            <table style="cursor:pointer">
254
                <caption>Perl modules</caption>
254
                <caption>Perl modules</caption>
255
                [% FOREACH tabl IN table %]
255
                [% FOREACH table IN tablee %]
256
                    <tr>
256
                    <tr>
257
                        [% FOREACH ro IN tabl.row %]
257
                        [% FOREACH ro IN table.row %]
258
                            [% IF ( ro.require ) %]
258
                            [% IF ( ro.require ) %]
259
                                [% SET th_font_weight = "bold" %]
259
                                [% SET th_font_weight = "bold" %]
260
                            [% ELSE %]
260
                            [% ELSE %]
Lines 293-299 Link Here
293
                            [% END %]
293
                            [% END %]
294
                        [% END # /FOREACH ro %]
294
                        [% END # /FOREACH ro %]
295
                    </tr>
295
                    </tr>
296
                [% END # /FOREACH tabl %]
296
                [% END # /FOREACH table %]
297
            </table>
297
            </table>
298
        [% END # tab=perl %]
298
        [% END # tab=perl %]
299
    [% END %]
299
    [% END %]
Lines 1186-1194 Link Here
1186
                            <td style="font-weight:bold;">Description</td>
1186
                            <td style="font-weight:bold;">Description</td>
1187
                        </tr>
1187
                        </tr>
1188
                    </thead>
1188
                    </thead>
1189
                    [% FOREACH tabl IN table2 %]
1189
                    [% FOREACH table IN tablee2 %]
1190
                        <tr class="[% loop.parity | html %]">
1190
                        <tr class="[% loop.parity | html %]">
1191
                            [% FOREACH ro IN tabl.row2 %]
1191
                            [% FOREACH ro IN table.row2 %]
1192
                                <td>[% ro.date | html %]</td>
1192
                                <td>[% ro.date | html %]</td>
1193
                                <td>[% ro.desc | html %]</td>
1193
                                <td>[% ro.desc | html %]</td>
1194
                            [% END %]
1194
                            [% END %]
(-)a/t/mock_templates/intranet-tmpl/prog/fr-CA/modules/about.tt (-5 / +5 lines)
Lines 252-260 Link Here
252
        [% WRAPPER tab_panel tabname= "perl" bt_active = 1 %]
252
        [% WRAPPER tab_panel tabname= "perl" bt_active = 1 %]
253
            <table style="cursor:pointer">
253
            <table style="cursor:pointer">
254
                <caption>Perl modules</caption>
254
                <caption>Perl modules</caption>
255
                [% FOREACH tabl IN table %]
255
                [% FOREACH table IN tablee %]
256
                    <tr>
256
                    <tr>
257
                        [% FOREACH ro IN tabl.row %]
257
                        [% FOREACH ro IN table.row %]
258
                            [% IF ( ro.require ) %]
258
                            [% IF ( ro.require ) %]
259
                                [% SET th_font_weight = "bold" %]
259
                                [% SET th_font_weight = "bold" %]
260
                            [% ELSE %]
260
                            [% ELSE %]
Lines 293-299 Link Here
293
                            [% END %]
293
                            [% END %]
294
                        [% END # /FOREACH ro %]
294
                        [% END # /FOREACH ro %]
295
                    </tr>
295
                    </tr>
296
                [% END # /FOREACH tabl %]
296
                [% END # /FOREACH table %]
297
            </table>
297
            </table>
298
        [% END # tab=perl %]
298
        [% END # tab=perl %]
299
    [% END %]
299
    [% END %]
Lines 1192-1200 Link Here
1192
                            <td style="font-weight:bold;">Description</td>
1192
                            <td style="font-weight:bold;">Description</td>
1193
                        </tr>
1193
                        </tr>
1194
                    </thead>
1194
                    </thead>
1195
                    [% FOREACH tabl IN table2 %]
1195
                    [% FOREACH table IN tablee2 %]
1196
                        <tr class="[% loop.parity | html %]">
1196
                        <tr class="[% loop.parity | html %]">
1197
                            [% FOREACH ro IN tabl.row2 %]
1197
                            [% FOREACH ro IN table.row2 %]
1198
                                <td>[% ro.date | html %]</td>
1198
                                <td>[% ro.date | html %]</td>
1199
                                <td>[% ro.desc | html %]</td>
1199
                                <td>[% ro.desc | html %]</td>
1200
                            [% END %]
1200
                            [% END %]
(-)a/tools/import_borrowers.pl (-1 / +1 lines)
Lines 23-29 Link Here
23
# File format
23
# File format
24
#
24
#
25
# cardnumber,surname,firstname,title,othernames,initials,streetnumber,streettype,
25
# cardnumber,surname,firstname,title,othernames,initials,streetnumber,streettype,
26
# address line , address line 2, city, zipcode, contry, email, phone, mobile, fax, work email, work phone,
26
# address line , address line 2, city, zipcode, country, email, phone, mobile, fax, work email, work phone,
27
# alternate streetnumber, alternate streettype, alternate address line 1, alternate city,
27
# alternate streetnumber, alternate streettype, alternate address line 1, alternate city,
28
# alternate zipcode, alternate country, alternate email, alternate phone, date of birth, branchcode,
28
# alternate zipcode, alternate country, alternate email, alternate phone, date of birth, branchcode,
29
# categorycode, enrollment date, expiry date, noaddress, lost, debarred, contact surname,
29
# categorycode, enrollment date, expiry date, noaddress, lost, debarred, contact surname,
(-)a/tools/modborrowers.pl (-2 / +2 lines)
Lines 61-67 if ( $logged_in_user->is_superlibrarian ) { Link Here
61
}
61
}
62
my $dbh = C4::Context->dbh;
62
my $dbh = C4::Context->dbh;
63
63
64
# Show borrower informations
64
# Show borrower information
65
if ( $op eq 'cud-show' || $op eq 'show' ) {
65
if ( $op eq 'cud-show' || $op eq 'show' ) {
66
    my @borrowers;
66
    my @borrowers;
67
    my @patronidnumbers;
67
    my @patronidnumbers;
Lines 154-160 if ( $op eq 'cud-show' || $op eq 'show' ) { Link Here
154
    my @patron_categories =
154
    my @patron_categories =
155
        Koha::Patron::Categories->search_with_library_limits( {}, { order_by => ['description'] } )->as_list;
155
        Koha::Patron::Categories->search_with_library_limits( {}, { order_by => ['description'] } )->as_list;
156
    while ( my $attr_type = $patron_attribute_types->next ) {
156
    while ( my $attr_type = $patron_attribute_types->next ) {
157
        next if $attr_type->unique_id;    # Don't display patron attributes that must be unqiue
157
        next if $attr_type->unique_id;    # Don't display patron attributes that must be unique
158
        my $options =
158
        my $options =
159
            $attr_type->authorised_value_category
159
            $attr_type->authorised_value_category
160
            ? GetAuthorisedValues( $attr_type->authorised_value_category )
160
            ? GetAuthorisedValues( $attr_type->authorised_value_category )
(-)a/tools/picture-upload.pl (-2 / +2 lines)
Lines 240-249 sub handle_dir { Link Here
240
            chomp $line;
240
            chomp $line;
241
            $logger->debug("Examining line: $line");
241
            $logger->debug("Examining line: $line");
242
            my $delim = ( $line =~ /\t/ ) ? "\t" : ( $line =~ /,/ ) ? "," : "";
242
            my $delim = ( $line =~ /\t/ ) ? "\t" : ( $line =~ /,/ ) ? "," : "";
243
            $logger->debug("Delimeter is \'$delim\'");
243
            $logger->debug("Delimiter is \'$delim\'");
244
            unless ( $delim eq "," || $delim eq "\t" ) {
244
            unless ( $delim eq "," || $delim eq "\t" ) {
245
                warn
245
                warn
246
                    "Unrecognized or missing field delimeter. Please verify that you are using either a ',' or a 'tab'";
246
                    "Unrecognized or missing field delimiter. Please verify that you are using either a ',' or a 'tab'";
247
                $direrrors{'DELERR'} = 1;
247
                $direrrors{'DELERR'} = 1;
248
248
249
                # This error is fatal to the import of this directory contents
249
                # This error is fatal to the import of this directory contents
(-)a/tools/upload-cover-image.pl (-1 / +1 lines)
Lines 172-178 if ( $op eq 'cud-process' && $fileID ) { Link Here
172
172
173
                        unless ( $delim eq "," || $delim eq "\t" ) {
173
                        unless ( $delim eq "," || $delim eq "\t" ) {
174
                            warn
174
                            warn
175
                                "Unrecognized or missing field delimeter. Please verify that you are using either a ',' or a 'tab'";
175
                                "Unrecognized or missing field delimiter. Please verify that you are using either a ',' or a 'tab'";
176
                            $error = 'DELERR';
176
                            $error = 'DELERR';
177
                            next;
177
                            next;
178
                        } else {
178
                        } else {
(-)a/xt/author/Text_CSV_Various.t (-1 / +1 lines)
Lines 14-20 Link Here
14
# You should have received a copy of the GNU General Public License along
14
# You should have received a copy of the GNU General Public License along
15
# with Koha; if not, see <http://www.gnu.org/licenses>.
15
# with Koha; if not, see <http://www.gnu.org/licenses>.
16
16
17
#This test demonstrates why Koha uses the CSV parser and configration
17
#This test demonstrates why Koha uses the CSV parser and configuration
18
#it does.  Specifically, the test is for Unicode compliance in text
18
#it does.  Specifically, the test is for Unicode compliance in text
19
#parsing and data.  This test requires other modules that Koha doesn't
19
#parsing and data.  This test requires other modules that Koha doesn't
20
#actually use, in order to compare.  Therefore, running this test is not
20
#actually use, in order to compare.  Therefore, running this test is not
(-)a/xt/author/podcorrectness.t (-2 / +1 lines)
Lines 3-9 Link Here
3
=head1 podcorrectness.t
3
=head1 podcorrectness.t
4
4
5
This test file checks all perl modules in the C4 directory for POD
5
This test file checks all perl modules in the C4 directory for POD
6
correctness. It typically finds things like pod tags withouth blank
6
correctness. It typically finds things like pod tags without blank
7
lines immediately before or after them, unknown directives, or =over,
7
lines immediately before or after them, unknown directives, or =over,
8
=item, and =back in the wrong order.
8
=item, and =back in the wrong order.
9
9
10
- 

Return to bug 39325