View | Details | Raw Unified | Return to bug 39325
Collapse All | Expand All

(-)a/C4/Auth.pm (-1 / +1 lines)
Lines 1032-1038 sub checkauth { Link Here
1032
    if ($logout) {
1032
    if ($logout) {
1033
1033
1034
        # voluntary logout the user
1034
        # voluntary logout the user
1035
        # check FIXME CODESPELL (wether ==> weather, whether) the user was using their shibboleth session or a local one
1035
        # check whether the user was using their shibboleth session or a local one
1036
        my $shibSuccess = C4::Context->userenv ? C4::Context->userenv->{'shibboleth'} : undef;
1036
        my $shibSuccess = C4::Context->userenv ? C4::Context->userenv->{'shibboleth'} : undef;
1037
        if ($session) {
1037
        if ($session) {
1038
            $session->delete();
1038
            $session->delete();
(-)a/C4/Biblio.pm (-1 / +1 lines)
Lines 2303-2309 sub TransformHtmlToMarc { Link Here
2303
            $newfield = 0;
2303
            $newfield = 0;
2304
            my $j = $i + 2;
2304
            my $j = $i + 2;
2305
2305
2306
            if ( $tag < 10 ) {    # no code for FIXME CODESPELL (theses ==> these, thesis) fields
2306
            if ( $tag < 10 ) {    # no code for this field
2307
                                  # in MARC editor, 000 contains the leader.
2307
                                  # in MARC editor, 000 contains the leader.
2308
                next if $tag == $biblionumbertagfield;
2308
                next if $tag == $biblionumbertagfield;
2309
                my $fval = $cgi->param( $params[ $j + 1 ] );
2309
                my $fval = $cgi->param( $params[ $j + 1 ] );
(-)a/C4/Circulation.pm (-3 / +3 lines)
Lines 1574-1581 AddIssue does the following things : Link Here
1574
              - fill recall if recall to this patron
1574
              - fill recall if recall to this patron
1575
              - cancel recall or not
1575
              - cancel recall or not
1576
              - revert recall's waiting status or not
1576
              - revert recall's waiting status or not
1577
          * FIXME CODESPELL (TRANSFERT ==> TRANSFER, TRANSFERRED) PENDING ?
1577
          * TRANSFER PENDING ?
1578
              - complete the FIXME CODESPELL (transfert ==> transfer, transferred)
1578
              - complete the transfer
1579
          * ISSUE THE BOOK
1579
          * ISSUE THE BOOK
1580
1580
1581
=back
1581
=back
Lines 1704-1710 sub AddIssue { Link Here
1704
1704
1705
            C4::Reserves::MoveReserve( $item_object->itemnumber, $patron->borrowernumber, $cancelreserve );
1705
            C4::Reserves::MoveReserve( $item_object->itemnumber, $patron->borrowernumber, $cancelreserve );
1706
1706
1707
            # Starting process for transfer job (checking FIXME CODESPELL (transfert ==> transfer, transferred) and validate it if we have one)
1707
            # Starting process for transfer job (checking transfer and validate it if we have one)
1708
            if ( my $transfer = $item_object->get_transfer ) {
1708
            if ( my $transfer = $item_object->get_transfer ) {
1709
1709
1710
                # updating line of branchtranfert to finish it, and changing the to branch value, implement a comment for visibility of this case (maybe for stats ....)
1710
                # updating line of branchtranfert to finish it, and changing the to branch value, implement a comment for visibility of this case (maybe for stats ....)
(-)a/C4/Form/MessagingPreferences.pm (-1 / +1 lines)
Lines 156-162 PREF: foreach my $option (@$messaging_options) { Link Here
156
156
157
=item Handle when form input is invalid
157
=item Handle when form input is invalid
158
158
159
=item Generalize into a system of form handler FIXME CODESPELL (clases ==> classes, clashes, cases)
159
=item Generalize into a system of form handler classes
160
160
161
=back
161
=back
162
162
(-)a/C4/Record.pm (-1 / +1 lines)
Lines 264-270 sub marc2dcxml { Link Here
264
    my ( $marcxml, $record, $output );
264
    my ( $marcxml, $record, $output );
265
265
266
    # set the default path for intranet xslts
266
    # set the default path for intranet xslts
267
    # FIXME CODESPELL (differents ==> different, difference) xslts to process (OAIDC, SRWDC and RDFDC)
267
    # different xslts to process (OAIDC, SRWDC and RDFDC)
268
    my $xsl =
268
    my $xsl =
269
          C4::Context->config('intrahtdocs')
269
          C4::Context->config('intrahtdocs')
270
        . '/prog/en/xslt/'
270
        . '/prog/en/xslt/'
(-)a/C4/Reports/Guided.pm (-2 / +2 lines)
Lines 305-312 sub _build_query { Link Here
305
        my @definitions = split( ',', $definition );
305
        my @definitions = split( ',', $definition );
306
        my $deftext;
306
        my $deftext;
307
        foreach my $def (@definitions) {
307
        foreach my $def (@definitions) {
308
            my $define = get_from_dictionary( '', $def );
308
            my $report = get_from_dictionary( '', $def );
309
            $deftext .= " " . $defin->[0]->{'saved_sql'};
309
            $deftext .= " " . $report->[0]->{'saved_sql'};
310
        }
310
        }
311
        if ( $query =~ /WHERE/i ) {
311
        if ( $query =~ /WHERE/i ) {
312
            $query .= $deftext;
312
            $query .= $deftext;
(-)a/C4/Reserves.pm (-1 / +1 lines)
Lines 59-65 C4::Reserves - Koha functions for dealing with reservation. Link Here
59
59
60
=head1 DESCRIPTION
60
=head1 DESCRIPTION
61
61
62
This modules provides FIXME CODESPELL (somes ==> some, sums) functions to deal with reservations.
62
This modules provides some functions to deal with reservations.
63
63
64
  Reserves are stored in reserves table.
64
  Reserves are stored in reserves table.
65
  The following columns contains important values :
65
  The following columns contains important values :
(-)a/C4/SIP/ILS/Patron.pm (-1 / +1 lines)
Lines 1132-1137 blocked, or C<undef> if the patron ID is not valid. Link Here
1132
1132
1133
=head2 C<$patron-E<gt>enable;>
1133
=head2 C<$patron-E<gt>enable;>
1134
1134
1135
Reenable the patron after she's been blocked.  This is a test
1135
Re-enable the patron after she's been blocked.  This is a test
1136
function and will not normally be called by self-service
1136
function and will not normally be called by self-service
1137
terminals in production.
1137
terminals in production.
(-)a/C4/SIP/SIPServer.pm (-6 / +6 lines)
Lines 55-67 my %transports = ( Link Here
55
# Read configuration
55
# Read configuration
56
#
56
#
57
my $config = C4::SIP::Sip::Configuration->new( $ARGV[0] );
57
my $config = C4::SIP::Sip::Configuration->new( $ARGV[0] );
58
my @FIXME CODESPELL (parms ==> params, prams);
58
my @params;
59
59
60
#
60
#
61
# Ports to bind
61
# Ports to bind
62
#
62
#
63
foreach my $svc ( keys %{ $config->{listeners} } ) {
63
foreach my $svc ( keys %{ $config->{listeners} } ) {
64
    push @FIXME CODESPELL (parms ==> params, prams), "port=" . $svc;
64
    push @params, "port=" . $svc;
65
}
65
}
66
66
67
#
67
#
Lines 81-97 foreach my $svc ( keys %{ $config->{listeners} } ) { Link Here
81
#
81
#
82
if ( defined( $config->{'server-params'} ) ) {
82
if ( defined( $config->{'server-params'} ) ) {
83
    while ( my ( $key, $val ) = each %{ $config->{'server-params'} } ) {
83
    while ( my ( $key, $val ) = each %{ $config->{'server-params'} } ) {
84
        push @FIXME CODESPELL (parms ==> params, prams), $key . '=' . $val;
84
        push @params, $key . '=' . $val;
85
    }
85
    }
86
}
86
}
87
87
88
# Add user and group to prevent warn from Net::Server.
88
# Add user and group to prevent warn from Net::Server.
89
push @FIXME CODESPELL (parms ==> params, prams), 'user=' . $>;
89
push @params, 'user=' . $>;
90
push @FIXME CODESPELL (parms ==> params, prams), 'group=' . $>;
90
push @params, 'group=' . $>;
91
91
92
#
92
#
93
# This is the main event.
93
# This is the main event.
94
__PACKAGE__->run(@FIXME CODESPELL (parms ==> params, prams));
94
__PACKAGE__->run(@params);
95
95
96
#
96
#
97
# Server
97
# Server
(-)a/Koha/Biblio.pm (-1 / +1 lines)
Lines 520-526 sub pickup_locations { Link Here
520
520
521
    my $bool = $biblio->hidden_in_opac({ [ rules => $rules ] })
521
    my $bool = $biblio->hidden_in_opac({ [ rules => $rules ] })
522
522
523
Returns true if the biblio matches the FIXME CODESPELL (hidding ==> hiding, hidden) criteria defined in $rules.
523
Returns true if the biblio matches the hiding criteria defined in $rules.
524
Returns false otherwise. It involves the I<OpacHiddenItems> and
524
Returns false otherwise. It involves the I<OpacHiddenItems> and
525
I<OpacHiddenItemsHidesRecord> system preferences.
525
I<OpacHiddenItemsHidesRecord> system preferences.
526
526
(-)a/Koha/Edifact/Line.pm (-1 / +1 lines)
Lines 778-784 sub pri_price { Link Here
778
    return;
778
    return;
779
}
779
}
780
780
781
# unit price that will be FIXME CODESPELL (chaged ==> changed, charged) excl tax
781
# unit price that will be charged excl tax
782
782
783
sub price_net {
783
sub price_net {
784
    my $self = shift;
784
    my $self = shift;
(-)a/Koha/Edifact/Order.pm (-1 / +1 lines)
Lines 776-782 Make handling of GIR segments more customizable Link Here
776
    pass the string 'new'.
776
    pass the string 'new'.
777
    In practice we encode 1 message per transmission so there is only one message
777
    In practice we encode 1 message per transmission so there is only one message
778
    referenced. were we to encode multiple messages a new reference would be
778
    referenced. were we to encode multiple messages a new reference would be
779
    FIXME CODESPELL (neaded ==> needed, kneaded, headed) for each
779
    needed for each
780
780
781
=head2 message_header
781
=head2 message_header
782
782
(-)a/Koha/Filter/MARC/ViewPolicy.pm (-3 / +3 lines)
Lines 232-240 nothing is passed. Valid values include 'opac' or 'intranet'. Link Here
232
=cut
232
=cut
233
233
234
sub should_hide_marc {
234
sub should_hide_marc {
235
    my ( $self, $FIXME CODESPELL (parms ==> params, prams) ) = @_;
235
    my ( $self, $params ) = @_;
236
    my $frameworkcode = $parms->{frameworkcode} // q{};
236
    my $frameworkcode = $params->{frameworkcode} // q{};
237
    my $interface     = $parms->{interface}     // 'opac';
237
    my $interface     = $params->{interface}     // 'opac';
238
    my $hide          = _should_hide_on_interface();
238
    my $hide          = _should_hide_on_interface();
239
239
240
    my %shouldhidemarc;
240
    my %shouldhidemarc;
(-)a/Koha/Item.pm (-1 / +1 lines)
Lines 935-941 sub can_article_request { Link Here
935
935
936
my $bool = $item->hidden_in_opac({ [ rules => $rules ] })
936
my $bool = $item->hidden_in_opac({ [ rules => $rules ] })
937
937
938
Returns true if item fields match the FIXME CODESPELL (hidding ==> hiding, hidden) criteria defined in $rules.
938
Returns true if item fields match the hiding criteria defined in $rules.
939
Returns false otherwise.
939
Returns false otherwise.
940
940
941
Takes HASHref that can have the following parameters:
941
Takes HASHref that can have the following parameters:
(-)a/Koha/Misc/Files.pm (-3 / +3 lines)
Lines 52-58 from this table. However, this method does accept an arbitrary Link Here
52
string as 'tabletag', and an arbitrary integer as 'recordid'.
52
string as 'tabletag', and an arbitrary integer as 'recordid'.
53
53
54
Particular Koha::Misc::Files object can have one or more file records
54
Particular Koha::Misc::Files object can have one or more file records
55
(FIXME CODESPELL (actuall ==> actually, actual) file contents + various file metadata) associated with it.
55
(actual file contents + various file metadata) associated with it.
56
56
57
In case of an error (wrong parameter format) it returns undef.
57
In case of an error (wrong parameter format) it returns undef.
58
58
Lines 150-156 my $file = $mf->GetFile( id => $file_id ); Link Here
150
For an individual, specific file ID this method returns a hashref
150
For an individual, specific file ID this method returns a hashref
151
containing all metadata (file_id, table_tag, record_id, file_name,
151
containing all metadata (file_id, table_tag, record_id, file_name,
152
file_type, file_description, file_content, date_uploaded), plus
152
file_type, file_description, file_content, date_uploaded), plus
153
an FIXME CODESPELL (actuall ==> actually, actual) contents of a file (in 'file_content'). In typical usage
153
an actually contents of a file (in 'file_content'). In typical usage
154
scenarios, for a given $mf object, specific file IDs have to be
154
scenarios, for a given $mf object, specific file IDs have to be
155
obtained first by GetFilesInfo() call.
155
obtained first by GetFilesInfo() call.
156
156
Lines 218-224 sub DelAllFiles { Link Here
218
218
219
$mf->MergeFileRecIds(@ids_to_be_merged);
219
$mf->MergeFileRecIds(@ids_to_be_merged);
220
220
221
This method re-associates all FIXME CODESPELL (individuall ==> individually, individual) file records associated with
221
This method re-associates all individual file records associated with
222
some "parent" records IDs (provided in @ids_to_be_merged) with the given
222
some "parent" records IDs (provided in @ids_to_be_merged) with the given
223
single $mf object (which would be treated as a "parent" destination).
223
single $mf object (which would be treated as a "parent" destination).
224
224
(-)a/Koha/Patrons/Import.pm (-2 / +2 lines)
Lines 768-776 sub format_dates { Link Here
768
    my ( $self, $params ) = @_;
768
    my ( $self, $params ) = @_;
769
769
770
    foreach my $date_type (qw(dateofbirth dateenrolled dateexpiry date_renewed)) {
770
    foreach my $date_type (qw(dateofbirth dateenrolled dateexpiry date_renewed)) {
771
        my $template = $params->{borrower}->{$date_type} or next();
771
        my $tmp_date = $params->{borrower}->{$date_type} or next();
772
        my $formatted_date =
772
        my $formatted_date =
773
            eval { output_pref( { dt => dt_from_string($template), dateonly => 1, dateformat => 'iso' } ); };
773
            eval { output_pref( { dt => dt_from_string($tmp_date), dateonly => 1, dateformat => 'iso' } ); };
774
774
775
        if ($formatted_date) {
775
        if ($formatted_date) {
776
            $params->{borrower}->{$date_type} = $formatted_date;
776
            $params->{borrower}->{$date_type} = $formatted_date;
(-)a/Koha/Plugins/Base.pm (-1 / +1 lines)
Lines 359-365 sub _version_compare { Link Here
359
359
360
=head2 is_enabled
360
=head2 is_enabled
361
361
362
Method that returns FIXME CODESPELL (wether ==> weather, whether) the plugin is enabled or not
362
Method that returns whether the plugin is enabled or not
363
363
364
$plugin->enable
364
$plugin->enable
365
365
(-)a/Koha/Schema/Result/ClubHold.pm (-1 / +1 lines)
Lines 51-57 id for the bibliographic record the hold has been placed against Link Here
51
  is_foreign_key: 1
51
  is_foreign_key: 1
52
  is_nullable: 1
52
  is_nullable: 1
53
53
54
If item-level, the id for the item the hold has been placed FIXME CODESPELL (agains ==> against, again)
54
If item-level, the id for the item the hold has been placed against
55
55
56
=head2 date_created
56
=head2 date_created
57
57
(-)a/Koha/Schema/Result/Deleteditem.pm (-1 / +1 lines)
Lines 383-389 inventory number (MARC21 952$i) Link Here
383
  is_nullable: 1
383
  is_nullable: 1
384
  size: 32
384
  size: 32
385
385
386
'new' value, you can put whatever free-text information. This field is FIXME CODESPELL (intented ==> intended, indented) to be managed by the automatic_item_modification_by_age cronjob.
386
'new' value, you can put whatever free-text information. This field is intended to be managed by the automatic_item_modification_by_age cronjob.
387
387
388
=head2 exclude_from_local_holds_priority
388
=head2 exclude_from_local_holds_priority
389
389
(-)a/Koha/Schema/Result/Item.pm (-1 / +1 lines)
Lines 387-393 inventory number (MARC21 952$i) Link Here
387
  is_nullable: 1
387
  is_nullable: 1
388
  size: 32
388
  size: 32
389
389
390
'new' value, you can put whatever free-text information. This field is FIXME CODESPELL (intented ==> intended, indented) to be managed by the automatic_item_modification_by_age cronjob.
390
'new' value, you can put whatever free-text information. This field is intended to be managed by the automatic_item_modification_by_age cronjob.
391
391
392
=head2 exclude_from_local_holds_priority
392
=head2 exclude_from_local_holds_priority
393
393
(-)a/Koha/SearchEngine/Elasticsearch/Indexer.pm (-1 / +1 lines)
Lines 255-261 sub index_status { Link Here
255
Generate Elasticsearch mappings from mappings stored in database and
255
Generate Elasticsearch mappings from mappings stored in database and
256
perform a request to update Elasticsearch index mappings. Will throw an
256
perform a request to update Elasticsearch index mappings. Will throw an
257
error and set index status to C<INDEX_STATUS_RECREATE_REQUIRED> if update
257
error and set index status to C<INDEX_STATUS_RECREATE_REQUIRED> if update
258
fails.
258
failed.
259
259
260
=cut
260
=cut
261
261
(-)a/acqui/booksellers.pl (-1 / +1 lines)
Lines 28-34 booksellers.pl Link Here
28
=head1 DESCRIPTION
28
=head1 DESCRIPTION
29
29
30
this script displays the list of suppliers & baskets like C<$supplier> given on input arg.
30
this script displays the list of suppliers & baskets like C<$supplier> given on input arg.
31
thus, this page brings FIXME CODESPELL (differents ==> different, difference) features like to display supplier's details,
31
thus, this page brings different features like to display supplier's details,
32
to add an order for a specific supplier or to just add a new supplier.
32
to add an order for a specific supplier or to just add a new supplier.
33
33
34
=head1 CGI PARAMETERS
34
=head1 CGI PARAMETERS
(-)a/acqui/check_budget_total.pl (-1 / +1 lines)
Lines 26-32 use C4::Budgets qw( GetBudget ); Link Here
26
26
27
=head1 DESCRIPTION
27
=head1 DESCRIPTION
28
28
29
fetches the budget amount FIXME CODESPELL (fron ==> from, front) the DB
29
fetches the budget amount from the DB
30
30
31
=cut
31
=cut
32
32
(-)a/admin/aqbudgets.pl (-1 / +1 lines)
Lines 254-260 if ( $op eq 'list' ) { Link Here
254
    my $period_total = 0;
254
    my $period_total = 0;
255
    my ( $period_alloc_total, $spent_total, $ordered_total, $available_total ) = ( 0, 0, 0, 0 );
255
    my ( $period_alloc_total, $spent_total, $ordered_total, $available_total ) = ( 0, 0, 0, 0 );
256
256
257
    #This Looks WEIRD to me : should budgets be filtered in such a way ppl who FIXME CODESPELL (donot ==> do not, donut) own it would not see the amount spent on the budget by others ?
257
    #This Looks WEIRD to me : should budgets be filtered in such a way ppl who do not own it would not see the amount spent on the budget by others ?
258
258
259
    my @budgets_to_display;
259
    my @budgets_to_display;
260
    foreach my $budget (@budgets) {
260
    foreach my $budget (@budgets) {
(-)a/admin/check_budget_parent.pl (-1 / +1 lines)
Lines 26-32 use C4::Budgets qw( CheckBudgetParent GetBudget ); Link Here
26
26
27
=head1 DESCRIPTION
27
=head1 DESCRIPTION
28
28
29
fetches the budget amount FIXME CODESPELL (fron ==> from, front) the DB,
29
fetches the budget amount from the DB,
30
called by aqbudgets.pl and neworderempty.pl
30
called by aqbudgets.pl and neworderempty.pl
31
31
32
=cut
32
=cut
(-)a/authorities/authorities.pl (-1 / +1 lines)
Lines 437-443 sub build_tabs { Link Here
437
                            fixedfield    => ( $tag < 10 ) ? (1) : (0),
437
                            fixedfield    => ( $tag < 10 ) ? (1) : (0),
438
                            random        => CreateKey,
438
                            random        => CreateKey,
439
                        );
439
                        );
440
                        if ( $tag >= 10 ) {    # no indicator for FIXME CODESPELL (theses ==> these, thesis) tag
440
                        if ( $tag >= 10 ) {    # no indicator for this tag
441
                            $tag_data{indicator1} = format_indicator( $field->indicator(1) ),
441
                            $tag_data{indicator1} = format_indicator( $field->indicator(1) ),
442
                                $tag_data{indicator2} = format_indicator( $field->indicator(2) ),;
442
                                $tag_data{indicator2} = format_indicator( $field->indicator(2) ),;
443
                        }
443
                        }
(-)a/catalogue/MARCdetail.pl (-1 / +1 lines)
Lines 251-257 for ( my $tabloop = 0 ; $tabloop <= 10 ; $tabloop++ ) { Link Here
251
# now, build item tab !
251
# now, build item tab !
252
# the main difference is that datas are in lines and not in columns : thus, we build the <th> first, then the values...
252
# the main difference is that datas are in lines and not in columns : thus, we build the <th> first, then the values...
253
# loop through each tag
253
# loop through each tag
254
# warning : we may have FIXME CODESPELL (differents ==> different, difference) number of columns in each row. Thus, we first build a hash, complete it if necessary
254
# warning : we may have different number of columns in each row. Thus, we first build a hash, complete it if necessary
255
# then construct template.
255
# then construct template.
256
my @fields = $record->fields();
256
my @fields = $record->fields();
257
my %witness;    #---- stores the list of subfields used at least once, with the "meaning" of the code
257
my %witness;    #---- stores the list of subfields used at least once, with the "meaning" of the code
(-)a/cataloguing/addbooks.pl (-1 / +1 lines)
Lines 83-89 if ($query) { Link Here
83
    }
83
    }
84
84
85
    # format output
85
    # format output
86
    # SimpleSearch() give the results per page we want, so 0 FIXME CODESPELL (offet ==> offset, offer) here
86
    # SimpleSearch() give the results per page we want, so 0 offset here
87
    my $total = @{$marcresults};
87
    my $total = @{$marcresults};
88
    my @newresults =
88
    my @newresults =
89
        searchResults( { 'interface' => 'intranet' }, $query, $total, $results_per_page, 0, 0, $marcresults );
89
        searchResults( { 'interface' => 'intranet' }, $query, $total, $results_per_page, 0, 0, $marcresults );
(-)a/circ/returns.pl (-1 / +1 lines)
Lines 534-540 if ( $messages->{'Wrongbranch'} ) { Link Here
534
    );
534
    );
535
}
535
}
536
536
537
# case of wrong FIXME CODESPELL (transfert ==> transfer, transferred), if the document wasn't transferred to the right library (according to branchtransfer (tobranch) BDD)
537
# case of wrong transfer, if the document wasn't transferred to the right library (according to branchtransfer (tobranch) BDD)
538
538
539
if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'} ) {
539
if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'} ) {
540
540
(-)a/koha-tmpl/intranet-tmpl/prog/en/includes/subtype_limits.inc (-2 / +2 lines)
Lines 197-205 Link Here
197
            <option value="ctype:l">Legislation</option>
197
            <option value="ctype:l">Legislation</option>
198
        [% END %]
198
        [% END %]
199
        [% IF (limits.ctype.0 == 'm' ) %]
199
        [% IF (limits.ctype.0 == 'm' ) %]
200
            <option value="ctype:m" selected="selected">FIXME CODESPELL (Theses ==> These, Thesis)</option>
200
            <option value="ctype:m" selected="selected">Thesis</option>
201
        [% ELSE %]
201
        [% ELSE %]
202
            <option value="ctype:m">FIXME CODESPELL (Theses ==> These, Thesis)</option>
202
            <option value="ctype:m">Thesis</option>
203
        [% END %]
203
        [% END %]
204
        [% IF (limits.ctype.0 == 'n' ) %]
204
        [% IF (limits.ctype.0 == 'n' ) %]
205
            <option value="ctype:n" selected="selected">Surveys</option>
205
            <option value="ctype:n" selected="selected">Surveys</option>
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt (-5 / +5 lines)
Lines 272-280 Link Here
272
    [% WRAPPER tab_panel tabname= "perl" bt_active = 1 %]
272
    [% WRAPPER tab_panel tabname= "perl" bt_active = 1 %]
273
        <table style="cursor:pointer">
273
        <table style="cursor:pointer">
274
            <caption>Perl modules</caption>
274
            <caption>Perl modules</caption>
275
            [% FOREACH table IN tablee %]
275
            [% FOREACH line IN table %]
276
                <tr>
276
                <tr>
277
                    [% FOREACH ro IN table.row %]
277
                    [% FOREACH ro IN line.row %]
278
                        [% IF ( ro.require ) %]
278
                        [% IF ( ro.require ) %]
279
                            [% SET th_font_weight = "bold" %]
279
                            [% SET th_font_weight = "bold" %]
280
                        [% ELSE %]
280
                        [% ELSE %]
Lines 313-319 Link Here
313
                        [% END %]
313
                        [% END %]
314
                    [% END # /FOREACH ro %]
314
                    [% END # /FOREACH ro %]
315
                </tr>
315
                </tr>
316
            [% END # /FOREACH table %]
316
            [% END # /FOREACH line %]
317
        </table>
317
        </table>
318
    [% END # tab=perl %]
318
    [% END # tab=perl %]
319
[% END %]
319
[% END %]
Lines 1246-1254 Link Here
1246
                        <td style="font-weight:bold;">Description</td>
1246
                        <td style="font-weight:bold;">Description</td>
1247
                    </tr>
1247
                    </tr>
1248
                </thead>
1248
                </thead>
1249
                [% FOREACH table IN tablee2 %]
1249
                [% FOREACH line IN table2 %]
1250
                    <tr class="[% loop.parity | html %]">
1250
                    <tr class="[% loop.parity | html %]">
1251
                        [% FOREACH ro IN table.row2 %]
1251
                        [% FOREACH ro IN line.row2 %]
1252
                            <td>[% ro.date | html %]</td>
1252
                            <td>[% ro.date | html %]</td>
1253
                            <td>[% ro.desc | html %]</td>
1253
                            <td>[% ro.desc | html %]</td>
1254
                        [% END %]
1254
                        [% END %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt (-15 / +15 lines)
Lines 93-111 Link Here
93
                    <th>Get it!</th>
93
                    <th>Get it!</th>
94
                    <th>Other action</th>
94
                    <th>Other action</th>
95
                </tr>
95
                </tr>
96
                [% FOREACH result IN resultt %]
96
                [% FOREACH line IN result %]
97
                    <tr>
97
                    <tr>
98
                        <td>
98
                        <td>
99
                            [% IF result.html %]
99
                            [% IF line.html %]
100
                                [% result.html | $raw %]
100
                                [% line.html | $raw %]
101
                            [% ELSE %]
101
                            [% ELSE %]
102
                                [% PROCESS authresulttt summary=resultt.summary authid=resultt.authid auth_preview=1 %]
102
                                [% PROCESS authresult summary=line.summary authid=line.authid auth_preview=1 %]
103
                            [% END %]
103
                            [% END %]
104
                        </td>
104
                        </td>
105
                        <td>[% result.summary.label | html %]</td>
105
                        <td>[% line.summary.label | html %]</td>
106
                        <td>
106
                        <td>
107
                            [% IF result.used > 0 %]
107
                            [% IF line.used > 0 %]
108
                                <a href="/cgi-bin/koha/catalogue/search.pl?type=intranet&amp;op=do_search&amp;idx=an,phr&amp;q=[% resultt.authid | uri %]" class="button">[% resultt.used | html %] times</a>
108
                                <a href="/cgi-bin/koha/catalogue/search.pl?type=intranet&amp;op=do_search&amp;idx=an,phr&amp;q=[% line.authid | uri %]" class="button">[% line.used | html %] times</a>
109
                            [% ELSE %]
109
                            [% ELSE %]
110
                                0 times
110
                                0 times
111
                            [% END %]
111
                            [% END %]
Lines 113-135 Link Here
113
                        [% IF Koha.Preference('ShowHeadingUse') %]
113
                        [% IF Koha.Preference('ShowHeadingUse') %]
114
                            <td class="heading_use"
114
                            <td class="heading_use"
115
                                ><ul class="usefor">
115
                                ><ul class="usefor">
116
                                    <li>[% IF result.main %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Main/Added Entry</li>
116
                                    <li>[% IF line.main %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Main/Added Entry</li>
117
                                    <li>[% IF result.subject %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Subject</li>
117
                                    <li>[% IF line.subject %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Subject</li>
118
                                    <li>[% IF result.series %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Series Title</li>
118
                                    <li>[% IF line.series %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Series Title</li>
119
                                </ul></td
119
                                </ul></td
120
                            >
120
                            >
121
                        [% END %]
121
                        [% END %]
122
                        <td>
122
                        <td>
123
                            [% IF resulttt.summary && resulttt.summary.authorized && resulttt.summary.authorized.size > 1 %]
123
                            [% IF line.summary && line.summary.authorized && line.summary.authorized.size > 1 %]
124
                                [% FOREACH authorized IN result.summary.authorized %]
124
                                [% FOREACH authorized IN line.summary.authorized %]
125
                                    <a href="javascript:doauth('[% result.authid | uri %]', '[% index | uri %]', '[% loop.count | uri %]')" title="[% authorized.heading | html %]">[% loop.count | html %]</a>
125
                                    <a href="javascript:doauth('[% line.authid | uri %]', '[% index | uri %]', '[% loop.count | uri %]')" title="[% authorized.heading | html %]">[% loop.count | html %]</a>
126
                                [% END %]
126
                                [% END %]
127
                            [% ELSE %]
127
                            [% ELSE %]
128
                                <a class="btn btn-xs btn-default" href="javascript:doauth('[% result.authid | html %]', '[% index | html %]', '')"><i class="fa fa-plus"></i> Choose</a>
128
                                <a class="btn btn-xs btn-default" href="javascript:doauth('[% line.authid | html %]', '[% index | html %]', '')"><i class="fa fa-plus"></i> Choose</a>
129
                            [% END %]
129
                            [% END %]
130
                        </td>
130
                        </td>
131
                        <td
131
                        <td
132
                            ><a class="btn btn-xs btn-default" href="authorities.pl?authid=[% result.authid | html %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit authority</a></td
132
                            ><a class="btn btn-xs btn-default" href="authorities.pl?authid=[% line.authid | html %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit authority</a></td
133
                        >
133
                        >
134
                    </tr>
134
                    </tr>
135
                [% END %]
135
                [% END %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt (-15 / +15 lines)
Lines 73-92 Link Here
73
                            <th>&nbsp;</th>
73
                            <th>&nbsp;</th>
74
                        [% END %]
74
                        [% END %]
75
                    </tr>
75
                    </tr>
76
                    [% FOREACH result IN resultt %]
76
                    [% FOREACH line IN result %]
77
                        <tr data-authid="[% result.authid | html %]">
77
                        <tr data-authid="[% result.authid | html %]">
78
                            <td>
78
                            <td>
79
                                [% IF result.html %]
79
                                [% IF result.html %]
80
                                    [% result.html | $raw %]
80
                                    [% result.html | $raw %]
81
                                [% ELSE %]
81
                                [% ELSE %]
82
                                    [% PROCESS authresulttt summary=resultt.summary authid=resultt.authid %]
82
                                    [% PROCESS authresult summary=line.summary authid=line.authid %]
83
                                [% END %]
83
                                [% END %]
84
                            </td>
84
                            </td>
85
                            <td>[% result.authtype | html %]</td>
85
                            <td>[% line.authtype | html %]</td>
86
                            [% UNLESS ( result.isEDITORS ) %]
86
                            [% UNLESS ( line.isEDITORS ) %]
87
                                <td>
87
                                <td>
88
                                    [% IF result.used > 0 %]
88
                                    [% IF line.used > 0 %]
89
                                        <a href="/cgi-bin/koha/catalogue/search.pl?type=intranet&amp;op=do_search&amp;idx=an,phr&amp;q=[% resultt.authid | uri %]" class="button">[% resultt.used | html %] record(s)</a>
89
                                        <a href="/cgi-bin/koha/catalogue/search.pl?type=intranet&amp;op=do_search&amp;idx=an,phr&amp;q=[% line.authid | uri %]" class="button">[% line.used | html %] record(s)</a>
90
                                    [% ELSE %]
90
                                    [% ELSE %]
91
                                        0 records
91
                                        0 records
92
                                    [% END %]
92
                                    [% END %]
Lines 95-123 Link Here
95
                            [% IF Koha.Preference('ShowHeadingUse') %]
95
                            [% IF Koha.Preference('ShowHeadingUse') %]
96
                                <td class="heading_use"
96
                                <td class="heading_use"
97
                                    ><ul class="usefor">
97
                                    ><ul class="usefor">
98
                                        <li>[% IF result.main %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Main/Added Entry</li>
98
                                        <li>[% IF line.main %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Main/Added Entry</li>
99
                                        <li>[% IF result.subject %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Subject</li>
99
                                        <li>[% IF line.subject %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Subject</li>
100
                                        <li>[% IF result.series %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Series Title</li>
100
                                        <li>[% IF line.series %]<i class="fa fa-check"></i>[% ELSE %]<i class="fa fa-times"></i>[% END %] Series Title</li>
101
                                    </ul></td
101
                                    </ul></td
102
                                >
102
                                >
103
                            [% END %]
103
                            [% END %]
104
                            [% IF ( CAN_user_editauthorities ) %]
104
                            [% IF ( CAN_user_editauthorities ) %]
105
                                <td>
105
                                <td>
106
                                    <div class="btn-group dropup">
106
                                    <div class="btn-group dropup">
107
                                        <a class="btn btn-default btn-xs dropdown-toggle" id="authactions[% result.authid | html %]" role="button" data-bs-toggle="dropdown" href="#"> Actions</a>
107
                                        <a class="btn btn-default btn-xs dropdown-toggle" id="authactions[% line.authid | html %]" role="button" data-bs-toggle="dropdown" href="#"> Actions</a>
108
                                        <ul class="dropdown-menu dropdown-menu-end" role="menu" aria-labelledby="authactions[% result.authid | html %]">
108
                                        <ul class="dropdown-menu dropdown-menu-end" role="menu" aria-labelledby="authactions[% line.authid | html %]">
109
                                            <li
109
                                            <li
110
                                                ><a class="dropdown-item" href="/cgi-bin/koha/authorities/authorities.pl?authid=[% result.authid | uri %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a></li
110
                                                ><a class="dropdown-item" href="/cgi-bin/koha/authorities/authorities.pl?authid=[% line.authid | uri %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a></li
111
                                            >
111
                                            >
112
                                            <li
112
                                            <li
113
                                                ><a class="merge_auth dropdown-item" href="#merge"><i class="fa fa-compress"></i> Merge</a></li
113
                                                ><a class="merge_auth dropdown-item" href="#merge"><i class="fa fa-compress"></i> Merge</a></li
114
                                            >
114
                                            >
115
                                            [% UNLESS ( result.used ) %]
115
                                            [% UNLESS ( line.used ) %]
116
                                                <li
116
                                                <li
117
                                                    ><form class="form_delete" method="post" action="/cgi-bin/koha/authorities/authorities-home.pl">
117
                                                    ><form class="form_delete" method="post" action="/cgi-bin/koha/authorities/authorities-home.pl">
118
                                                        [% INCLUDE 'csrf-token.inc' %]
118
                                                        [% INCLUDE 'csrf-token.inc' %]
119
                                                        <input type="hidden" name="op" value="cud-delete" />
119
                                                        <input type="hidden" name="op" value="cud-delete" />
120
                                                        <input type="hidden" name="authid" value="[% result.authid | html %]" />
120
                                                        <input type="hidden" name="authid" value="[% line.authid | html %]" />
121
                                                        <input type="hidden" name="type" value="intranet" />
121
                                                        <input type="hidden" name="type" value="intranet" />
122
                                                        <input type="hidden" name="authtypecode" value="[% authtypecode | html %]" />
122
                                                        <input type="hidden" name="authtypecode" value="[% authtypecode | html %]" />
123
                                                        <input type="hidden" name="marclist" value="[% marclist | html %]" />
123
                                                        <input type="hidden" name="marclist" value="[% marclist | html %]" />
Lines 133-139 Link Here
133
                                                >
133
                                                >
134
                                            [% END %]
134
                                            [% END %]
135
                                            <li class="authority_preview">
135
                                            <li class="authority_preview">
136
                                                <a class="dropdown-item" data-authid="[% resultt.authid | html %]" href="/cgi-bin/koha/authorities/detail.pl?authid=[% resultt.authid | uri %]"><i class="fa-solid fa-eye"></i> MARC preview</a>
136
                                                <a class="dropdown-item" data-authid="[% line.authid | html %]" href="/cgi-bin/koha/authorities/detail.pl?authid=[% line.authid | uri %]"><i class="fa-solid fa-eye"></i> MARC preview</a>
137
                                            </li>
137
                                            </li>
138
                                        </ul>
138
                                        </ul>
139
                                    </div>
139
                                    </div>
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt (-14 / +14 lines)
Lines 84-116 Link Here
84
                        <th>Concise description</th>
84
                        <th>Concise description</th>
85
                        <th>&nbsp;</th>
85
                        <th>&nbsp;</th>
86
                    </tr>
86
                    </tr>
87
                    [% FOREACH result IN resultt %]
87
                    [% FOREACH line IN result %]
88
                        [% IF ( result.title ) %]
88
                        [% IF ( line.title ) %]
89
                            <tr>
89
                            <tr>
90
                                [% SET td_class = '' %]
90
                                [% SET td_class = '' %]
91
                                [% IF ( result.even ) %]
91
                                [% IF ( line.even ) %]
92
                                    [% td_class = 'hilighted' %]
92
                                    [% td_class = 'hilighted' %]
93
                                [% END %]
93
                                [% END %]
94
                                <td class="[% td_class | html %]">
94
                                <td class="[% td_class | html %]">
95
                                    [% IF ( result.MARC_ON ) %]
95
                                    [% IF ( line.MARC_ON ) %]
96
                                        <a class="transparent resultttlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% resultt.biblionumber |url %]">[% resultt.title | html %]</a>
96
                                        <a class="transparent resultlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% line.biblionumber |url %]">[% line.title | html %]</a>
97
                                    [% ELSE %]
97
                                    [% ELSE %]
98
                                        <a class="transparent resultttlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% resultt.biblionumber |url %]">[% resultt.title | html %]</a>
98
                                        <a class="transparent resultlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% line.biblionumber |url %]">[% line.title | html %]</a>
99
                                    [% END %]
99
                                    [% END %]
100
                                    <p
100
                                    <p
101
                                        >[% result.author | html %]
101
                                        >[% line.author | html %]
102
                                        [% IF ( resultt.publishercode ) %]- [% resultt.publishercode | html %][% END %]
102
                                        [% IF ( line.publishercode ) %]- [% line.publishercode | html %][% END %]
103
                                        [% IF ( resultt.place ) %]; [% resultt.place | html %][% END %]
103
                                        [% IF ( line.place ) %]; [% line.place | html %][% END %]
104
                                        [% IF ( resultt.pages ) %]- [% resultt.pages | html %][% END %]
104
                                        [% IF ( line.pages ) %]- [% line.pages | html %][% END %]
105
                                        [% IF ( resultt.notes ) %]: [% resultt.notes | html %][% END %]
105
                                        [% IF ( line.notes ) %]: [% line.notes | html %][% END %]
106
                                        [% IF ( resultt.size ) %]; [% resultt.size | html %][% END %]
106
                                        [% IF ( line.size ) %]; [% line.size | html %][% END %]
107
                                    </p>
107
                                    </p>
108
                                </td>
108
                                </td>
109
109
110
                                <td>
110
                                <td>
111
                                    [% IF ( result.biblionumber ) %]
111
                                    [% IF ( line.biblionumber ) %]
112
                                        <a
112
                                        <a
113
                                            href="javascript:jumpfull('/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_linking_section.pl&amp;index=[% index | uri %]&amp;biblionumber=[% result.biblionumber | uri %]&amp;type=intranet&amp;op=fillinput')"
113
                                            href="javascript:jumpfull('/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=marc21_linking_section.pl&amp;index=[% index | uri %]&amp;biblionumber=[% line.biblionumber | uri %]&amp;type=intranet&amp;op=fillinput')"
114
                                            >Choose</a
114
                                            >Choose</a
115
                                        >
115
                                        >
116
                                    [% ELSE %]
116
                                    [% ELSE %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tt (-6 / +6 lines)
Lines 68-82 Link Here
68
                <th>Used</th>
68
                <th>Used</th>
69
                <th>Get it!</th>
69
                <th>Get it!</th>
70
            </tr>
70
            </tr>
71
            [% FOREACH result IN resultt %]
71
            [% FOREACH line IN result %]
72
                <tr>
72
                <tr>
73
                    <td>[% PROCESS authresulttt summary=resultt.summary authid=resultt.authid %]</td>
73
                    <td>[% PROCESS authresult summary=line.summary authid=line.authid %]</td>
74
                    <td>[% result.summary.label | html %]</td>
74
                    <td>[% line.summary.label | html %]</td>
75
                    <td>[% result.used | html %] times</td>
75
                    <td>[% line.used | html %] times</td>
76
                    <td>
76
                    <td>
77
                        [% IF ( result.to_report ) %]
77
                        [% IF ( line.to_report ) %]
78
                            <button class="choosebt">Choose</button>
78
                            <button class="choosebt">Choose</button>
79
                            <p class="toreport" style="display:none">[% result.to_report |replace('\n', '\\n') |replace('\r', '\\r') |html %]</p>
79
                            <p class="toreport" style="display:none">[% line.to_report |replace('\n', '\\n') |replace('\r', '\\r') |html %]</p>
80
                        [% END %]
80
                        [% END %]
81
                    </td>
81
                    </td>
82
                </tr>
82
                </tr>
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt (-16 / +16 lines)
Lines 89-124 Link Here
89
                    <th>Location</th>
89
                    <th>Location</th>
90
                    <th>&nbsp;</th>
90
                    <th>&nbsp;</th>
91
                </tr>
91
                </tr>
92
                [% FOREACH result IN resultt %]
92
                [% FOREACH line IN result %]
93
                    [% IF ( result.title ) %]
93
                    [% IF ( line.title ) %]
94
                        <tr>
94
                        <tr>
95
                            [% SET td_class = '' %]
95
                            [% SET td_class = '' %]
96
                            [% IF ( result.even ) %]
96
                            [% IF ( line.even ) %]
97
                                [% td_class = 'hilighted' %]
97
                                [% td_class = 'hilighted' %]
98
                            [% END %]
98
                            [% END %]
99
                            <td class="[% td_class | html %]">
99
                            <td class="[% td_class | html %]">
100
                                [% IF ( result.MARC_ON ) %]
100
                                [% IF ( line.MARC_ON ) %]
101
                                    <a class="transparent resultttlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% resultt.biblionumber |url %]">[% resultt.title | html %]</a>
101
                                    <a class="transparent resultlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% line.biblionumber |url %]">[% line.title | html %]</a>
102
                                [% ELSE %]
102
                                [% ELSE %]
103
                                    <a class="transparent resultttlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% resultt.biblionumber |url %]">[% resultt.fulltitle | html %]</a>
103
                                    <a class="transparent resultlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% line.biblionumber |url %]">[% line.fulltitle | html %]</a>
104
                                [% END %]
104
                                [% END %]
105
                                <p
105
                                <p
106
                                    >[% result.author | html %]
106
                                    >[% line.author | html %]
107
                                    [% IF ( resultt.publishercode ) %]- [% resultt.publishercode | html %][% END %]
107
                                    [% IF ( line.publishercode ) %]- [% line.publishercode | html %][% END %]
108
                                    [% IF ( resultt.place ) %]; [% resultt.place | html %][% END %]
108
                                    [% IF ( line.place ) %]; [% line.place | html %][% END %]
109
                                    [% IF ( resultt.pages ) %]- [% resultt.pages | html %][% END %]
109
                                    [% IF ( line.pages ) %]- [% line.pages | html %][% END %]
110
                                    [% IF ( resultt.notes ) %]: [% resultt.notes | html %][% END %]
110
                                    [% IF ( line.notes ) %]: [% line.notes | html %][% END %]
111
                                    [% IF ( resultt.item('size') ) %]; [% resultt.item('size') | html %][% END %]
111
                                    [% IF ( line.item('size') ) %]; [% line.item('size') | html %][% END %]
112
                                </p>
112
                                </p>
113
                            </td>
113
                            </td>
114
                            <td align="center" class="[% td_class | html %]"> [% result.totitem | html %] </td>
114
                            <td align="center" class="[% td_class | html %]"> [% line.totitem | html %] </td>
115
                            <td class="[% td_class | html %]"> [% result.CN | html %] </td>
115
                            <td class="[% td_class | html %]"> [% line.CN | html %] </td>
116
                            <td>
116
                            <td>
117
                                [% IF ( result.biblionumber ) %]
117
                                [% IF ( line.biblionumber ) %]
118
                                    <a
118
                                    <a
119
                                        href="#"
119
                                        href="#"
120
                                        class="btn btn-default btn-xs redirect_link"
120
                                        class="btn btn-default btn-xs redirect_link"
121
                                        data-url="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&amp;index=[% index | html %]&amp;biblionumber=[% result.biblionumber | html %]&amp;type=intranet&amp;op=fillinput"
121
                                        data-url="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&amp;index=[% index | html %]&amp;biblionumber=[% line.biblionumber | html %]&amp;type=intranet&amp;op=fillinput"
122
                                        >Choose</a
122
                                        >Choose</a
123
                                    >
123
                                    >
124
                                [% ELSE %]
124
                                [% ELSE %]
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt (-1 / +1 lines)
Lines 319-325 Link Here
319
            } else if (mode == 'batch') {
319
            } else if (mode == 'batch') {
320
                return GB_showCenter(_("Export labels"), "/cgi-bin/koha/labels/label-print.pl?batch_id=[% batch_id | html %]", 400, 800);
320
                return GB_showCenter(_("Export labels"), "/cgi-bin/koha/labels/label-print.pl?batch_id=[% batch_id | html %]", 400, 800);
321
            } else {
321
            } else {
322
                // some pass-thru error trapping just in case...
322
                // some pass-through error trapping just in case...
323
            }
323
            }
324
        }
324
        }
325
325
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt (-1 / +1 lines)
Lines 269-275 Link Here
269
            } else if (mode == 'batch') {
269
            } else if (mode == 'batch') {
270
                return GB_showCenter(_("Export patron cards"), "/cgi-bin/koha/patroncards/print.pl?batch_id=[% batch_id | html %]", 400, 800);
270
                return GB_showCenter(_("Export patron cards"), "/cgi-bin/koha/patroncards/print.pl?batch_id=[% batch_id | html %]", 400, 800);
271
            } else {
271
            } else {
272
                // some pass-thru error trapping just in case...
272
                // some pass-through error trapping just in case...
273
            }
273
            }
274
        };
274
        };
275
        function selected_layout() {
275
        function selected_layout() {
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt (-4 / +4 lines)
Lines 82-92 Link Here
82
                    <fieldset class="brief">
82
                    <fieldset class="brief">
83
                        <div class="hint"> Select one or more images to delete. </div>
83
                        <div class="hint"> Select one or more images to delete. </div>
84
                        <table>
84
                        <table>
85
                            [% FOREACH TABLE IN TABLEE %]
85
                            [% FOREACH line IN TABLE %]
86
86
87
                                [% IF ( TABLE.header_fields ) %]
87
                                [% IF ( line.header_fields ) %]
88
                                    <tr>
88
                                    <tr>
89
                                        [% FOREACH header_field IN TABLE.header_fields %]
89
                                        [% FOREACH header_field IN line.header_fields %]
90
                                            [% SWITCH header_field.field_label -%]
90
                                            [% SWITCH header_field.field_label -%]
91
                                            [% CASE "ID" %]
91
                                            [% CASE "ID" %]
92
                                                <th>Image ID</th>
92
                                                <th>Image ID</th>
Lines 101-107 Link Here
101
                                    </tr>
101
                                    </tr>
102
                                [% ELSE %]
102
                                [% ELSE %]
103
                                    <tr>
103
                                    <tr>
104
                                        [% FOREACH text_field IN TABLE.text_fields %]
104
                                        [% FOREACH text_field IN line.text_fields %]
105
                                            [% IF ( text_field.select_field ) %]
105
                                            [% IF ( text_field.select_field ) %]
106
                                                <td>
106
                                                <td>
107
                                                    <a
107
                                                    <a
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt (-2 / +2 lines)
Lines 1734-1742 Link Here
1734
1734
1735
            $("#always_show_holds").change(function(){
1735
            $("#always_show_holds").change(function(){
1736
                if( $(this).prop('checked') ){
1736
                if( $(this).prop('checked') ){
1737
                    document.cookie = 'always_show_holds=DO';
1737
                    document.cookie = "always_show_holds=DO";
1738
                } else {
1738
                } else {
1739
                    document.cookie = 'always_show_holds=DONT';
1739
                    document.cookie = "always_show_holds=DONT";
1740
                }
1740
                }
1741
            });
1741
            });
1742
            $("input.needsoverride").click(function() { // This must be before the radio button/checkbox switch logic
1742
            $("input.needsoverride").click(function() { // This must be before the radio button/checkbox switch logic
(-)a/koha-tmpl/intranet-tmpl/prog/js/ill-batch-modal.js (-8 / +8 lines)
Lines 140-146 Link Here
140
140
141
    // The element that potentially holds the ID of the batch
141
    // The element that potentially holds the ID of the batch
142
    // we're working with
142
    // we're working with
143
    var idle = document.getElementById("ill-batch-details");
143
    var elId = document.getElementById("ill-batch-details");
144
    var batchId = null;
144
    var batchId = null;
145
    var backend = null;
145
    var backend = null;
146
146
Lines 157-164 Link Here
157
        $("#ill-batch-modal").on("hidden.bs.modal", function () {
157
        $("#ill-batch-modal").on("hidden.bs.modal", function () {
158
            // Reset our state when we close the modal
158
            // Reset our state when we close the modal
159
            // TODO: need to also reset progress bar and already processed identifiers
159
            // TODO: need to also reset progress bar and already processed identifiers
160
            delete idle.dataset.batchId;
160
            delete elId.dataset.batchId;
161
            delete idle.dataset.backend;
161
            delete elId.dataset.backend;
162
            batchId = null;
162
            batchId = null;
163
            tableEl.style.display = "none";
163
            tableEl.style.display = "none";
164
            tableContent.data = [];
164
            tableContent.data = [];
Lines 176-183 Link Here
176
    }
176
    }
177
177
178
    function init() {
178
    function init() {
179
        batchId = idle.dataset.batchId;
179
        batchId = elId.dataset.batchId;
180
        backend = idle.dataset.backend;
180
        backend = elId.dataset.backend;
181
        emptyBatch.backend = backend;
181
        emptyBatch.backend = backend;
182
        progressTotals.data = {
182
        progressTotals.data = {
183
            total: 0,
183
            total: 0,
Lines 714-722 Link Here
714
        var tabIdentifiers = tableContent.data.map(function (tabId) {
714
        var tabIdentifiers = tableContent.data.map(function (tabId) {
715
            return tabId.value;
715
            return tabId.value;
716
        });
716
        });
717
        var notInTable = deaduped.filter(function (dead) {
717
        var notInTable = deduped.filter(function (d) {
718
            if (!tabIdentifiers.includes(dead.value)) {
718
            if (!tabIdentifiers.includes(d.value)) {
719
                return dead;
719
                return d;
720
            }
720
            }
721
        });
721
        });
722
        if (notInTable.length > 0) {
722
        if (notInTable.length > 0) {
(-)a/koha-tmpl/intranet-tmpl/prog/js/ill-batch.js (-3 / +3 lines)
Lines 3-12 Link Here
3
    // If we're working with an existing batch, set the ID so the
3
    // If we're working with an existing batch, set the ID so the
4
    // modal can access it
4
    // modal can access it
5
    window.openBatchModal = function (id, backend) {
5
    window.openBatchModal = function (id, backend) {
6
        var idle = document.getElementById("ill-batch-details");
6
        var elId = document.getElementById("ill-batch-details");
7
        idle.dataset.backend = backend;
7
        elId.dataset.backend = backend;
8
        if (id) {
8
        if (id) {
9
            idle.dataset.batchId = id;
9
            elId.dataset.batchId = id;
10
        }
10
        }
11
        $("#ill-batch-modal").modal("show");
11
        $("#ill-batch-modal").modal("show");
12
    };
12
    };
(-)a/koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc (-1 / +1 lines)
Lines 44-50 Link Here
44
            [% IF ( HOLD.is_at_destination ) %]
44
            [% IF ( HOLD.is_at_destination ) %]
45
                [% tr_class = 'reserved' %]
45
                [% tr_class = 'reserved' %]
46
            [% ELSIF HOLD.is_in_transit %]
46
            [% ELSIF HOLD.is_in_transit %]
47
                [% tr_class = 'transfered' %]
47
                [% tr_class = 'transferred' %]
48
            [% END %]
48
            [% END %]
49
            <tr class="[% tr_class | html %]">
49
            <tr class="[% tr_class | html %]">
50
                <td class="title">
50
                <td class="title">
(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt (-1 / +1 lines)
Lines 454-460 Link Here
454
                                        <option value="ctype:j">Patent document</option>
454
                                        <option value="ctype:j">Patent document</option>
455
                                        <option value="ctype:k">Discographies</option>
455
                                        <option value="ctype:k">Discographies</option>
456
                                        <option value="ctype:l">Legislation</option>
456
                                        <option value="ctype:l">Legislation</option>
457
                                        <option value="ctype:m">FIXME CODESPELL (Theses ==> These, Thesis)</option>
457
                                        <option value="ctype:m">Thesis</option>
458
                                        <option value="ctype:n">Surveys</option>
458
                                        <option value="ctype:n">Surveys</option>
459
                                        <option value="ctype:o">Reviews</option>
459
                                        <option value="ctype:o">Reviews</option>
460
                                        <option value="ctype:p">Programmed texts</option>
460
                                        <option value="ctype:p">Programmed texts</option>
(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt (-8 / +8 lines)
Lines 76-95 Link Here
76
                                    </tr>
76
                                    </tr>
77
                                </thead>
77
                                </thead>
78
                                <tbody>
78
                                <tbody>
79
                                    [% FOREACH result IN resultt %]
79
                                    [% FOREACH line IN result %]
80
                                        <tr>
80
                                        <tr>
81
                                            <td>
81
                                            <td>
82
                                                [% IF result.html %]
82
                                                [% IF line.html %]
83
                                                    [% result.html | $raw %]
83
                                                    [% line.html | $raw %]
84
                                                [% ELSE %]
84
                                                [% ELSE %]
85
                                                    [% PROCESS authresulttt summary=resultt.summary authid=resultt.authid %]
85
                                                    [% PROCESS authresult summary=line.summary authid=line.authid %]
86
                                                [% END %]
86
                                                [% END %]
87
                                            </td>
87
                                            </td>
88
                                            <td><a href="/cgi-bin/koha/opac-authoritiesdetail.pl?authid=[% resultt.authid | uri %]">Details</a> </td><td>[% resultt.authtype | html %]</td>
88
                                            <td><a href="/cgi-bin/koha/opac-authoritiesdetail.pl?authid=[% line.authid | uri %]">Details</a> </td><td>[% line.authtype | html %]</td>
89
                                            [% UNLESS ( result.isEDITORS ) %]
89
                                            [% UNLESS ( line.isEDITORS ) %]
90
                                                <td>
90
                                                <td>
91
                                                    [% IF result.used > 0 %]
91
                                                    [% IF line.used > 0 %]
92
                                                        <a href="/cgi-bin/koha/opac-search.pl?type=opac&amp;op=do_search&amp;q=an,phr:[% resulttt.authid | uri %]">[% resulttt.used | html %] [% tn('record', 'records', resulttt.used ) | html %]</a>
92
                                                        <a href="/cgi-bin/koha/opac-search.pl?type=opac&amp;op=do_search&amp;q=an,phr:[% line.authid | uri %]">[% line.used | html %] [% tn('record', 'records', line.used ) | html %]</a>
93
                                                    [% ELSE %]
93
                                                    [% ELSE %]
94
                                                        0 records
94
                                                        0 records
95
                                                    [% END %]
95
                                                    [% END %]
(-)a/members/housebound.pl (-1 / +1 lines)
Lines 122-128 if ( $op eq 'cud-updateconfirm' and $houseboundprofile ) { Link Here
122
    $houseboundvisit = $visit;
122
    $houseboundvisit = $visit;
123
} elsif ( $op eq 'cud-visit_delete' and $visit ) {
123
} elsif ( $op eq 'cud-visit_delete' and $visit ) {
124
124
125
    # We want ot delete a specific visit.
125
    # We want to delete a specific visit.
126
    my $success = eval { return $visit->delete };
126
    my $success = eval { return $visit->delete };
127
    push @messages, { type => 'error', code => 'error_on_visit_delete' }
127
    push @messages, { type => 'error', code => 'error_on_visit_delete' }
128
        if ( $@ or !$success );
128
        if ( $@ or !$success );
(-)a/misc/cronjobs/advance_notices.pl (-1 / +1 lines)
Lines 141-147 program. They may be redirected to a file if desired. Link Here
141
=head2 Templates
141
=head2 Templates
142
142
143
Templates can contain variables enclosed in double angle brackets like
143
Templates can contain variables enclosed in double angle brackets like
144
E<lt>E<lt>FIXME CODESPELL (thisE ==> these, this)<gt>E<gt>. Those variables will be replaced with values
144
<<this>>. Those variables will be replaced with values
145
specific to the overdue items or relevant patron. Available variables
145
specific to the overdue items or relevant patron. Available variables
146
are:
146
are:
147
147
(-)a/misc/cronjobs/holds/holds_reminder.pl (-1 / +1 lines)
Lines 202-208 unless ( defined $days ) { Link Here
202
    $days = 0;
202
    $days = 0;
203
}
203
}
204
204
205
# Unless one ore more branchcodes are passed we use all the branches
205
# Unless one or more branchcodes are passed we use all the branches
206
if ( scalar @branchcodes > 0 ) {
206
if ( scalar @branchcodes > 0 ) {
207
    my $branchcodes_word = scalar @branchcodes > 1 ? 'branches' : 'branch';
207
    my $branchcodes_word = scalar @branchcodes > 1 ? 'branches' : 'branch';
208
    $verbose and warn "$branchcodes_word @branchcodes passed on parameter\n";
208
    $verbose and warn "$branchcodes_word @branchcodes passed on parameter\n";
(-)a/misc/cronjobs/membership_expiry.pl (-1 / +1 lines)
Lines 142-148 not the borrower has an email address. This can be useful for libraries that Link Here
142
prefer to deal with print notices.
142
prefer to deal with print notices.
143
143
144
Notices can contain variables enclosed in double angle brackets like
144
Notices can contain variables enclosed in double angle brackets like
145
E<lt>E<lt>FIXME CODESPELL (thisE ==> these, this)<gt>E<gt>. Those variables will be replaced with values
145
<<this>>. Those variables will be replaced with values
146
specific to the soon expiring members.
146
specific to the soon expiring members.
147
Available variables are:
147
Available variables are:
148
148
(-)a/misc/cronjobs/overdue_notices.pl (-1 / +1 lines)
Lines 227-233 program. They may be redirected to a file if desired. Link Here
227
=head2 Templates
227
=head2 Templates
228
228
229
Templates can contain variables enclosed in double angle brackets like
229
Templates can contain variables enclosed in double angle brackets like
230
E<lt>E<lt>FIXME CODESPELL (thisE ==> these, this)<gt>E<gt>. Those variables will be replaced with values
230
<<this>>. Those variables will be replaced with values
231
specific to the overdue items or relevant patron. Available variables
231
specific to the overdue items or relevant patron. Available variables
232
are:
232
are:
233
233
(-)a/misc/cronjobs/update_patrons_category.pl (-2 / +2 lines)
Lines 109-119 Supply a number and only account with fines under this number will be updated. Link Here
109
109
110
=item B<--regbefore=date | -rb=date>
110
=item B<--regbefore=date | -rb=date>
111
111
112
Enter a date in ISO format YYYY-MM-DD and only patrons registered before this date FIXME CODESPELL (wil ==> will, well) be updated.
112
Enter a date in ISO format YYYY-MM-DD and only patrons registered before this date will be updated.
113
113
114
=item B<--regafter=date | -ra=date>
114
=item B<--regafter=date | -ra=date>
115
115
116
Enter a date in ISO format YYYY-MM-DD and only patrons registered after this date FIXME CODESPELL (wil ==> will, well) be updated.
116
Enter a date in ISO format YYYY-MM-DD and only patrons registered after this date will be updated.
117
117
118
=item B<--field column=value | -d column=value>
118
=item B<--field column=value | -d column=value>
119
119
(-)a/misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl (-4 / +4 lines)
Lines 48-56 $verbose and print "================================\n"; Link Here
48
$date_created_marc = '099c' unless $date_created_marc;
48
$date_created_marc = '099c' unless $date_created_marc;
49
my ( $c_field, $c_subfield ) = _read_marc_code($date_created_marc);
49
my ( $c_field, $c_subfield ) = _read_marc_code($date_created_marc);
50
die "date-created-marc '$date_created_marc' is not correct." unless $c_field;
50
die "date-created-marc '$date_created_marc' is not correct." unless $c_field;
51
die "date-created-marc field is FIXME CODESPELL (greated ==> greater, grated, graded) that 009, it should have a subfield."
51
die "date-created-marc field is greater than 009, it should have a subfield."
52
    if ( $c_field > 9 && !defined $c_subfield );
52
    if ( $c_field > 9 && !defined $c_subfield );
53
die "date-created-marc field is lower that 010, it should not have a subfield."
53
die "date-created-marc field is lower than 010, it should not have a subfield."
54
    if ( $c_field < 10 && defined $c_subfield );
54
    if ( $c_field < 10 && defined $c_subfield );
55
if ($verbose) {
55
if ($verbose) {
56
    print "Date created on $c_field";
56
    print "Date created on $c_field";
Lines 62-70 if ($verbose) { Link Here
62
$date_modified_marc = '099d' unless $date_modified_marc;
62
$date_modified_marc = '099d' unless $date_modified_marc;
63
my ( $m_field, $m_subfield ) = _read_marc_code($date_modified_marc);
63
my ( $m_field, $m_subfield ) = _read_marc_code($date_modified_marc);
64
die "date-modified-marc '$date_modified_marc' is not correct." unless $m_field;
64
die "date-modified-marc '$date_modified_marc' is not correct." unless $m_field;
65
die "date-modified-marc field is FIXME CODESPELL (greated ==> greater, grated, graded) that 009, it should have a subfield."
65
die "date-modified-marc field is greater than 009, it should have a subfield."
66
    if ( $m_field > 9 && !defined $m_subfield );
66
    if ( $m_field > 9 && !defined $m_subfield );
67
die "date-modified-marc field is lower that 010, it should not have a subfield."
67
die "date-modified-marc field is lower than 010, it should not have a subfield."
68
    if ( $m_field < 10 && defined $m_subfield );
68
    if ( $m_field < 10 && defined $m_subfield );
69
die "When date-created-marc and date-modified-marc are on same field, they should have distinct subfields"
69
die "When date-created-marc and date-modified-marc are on same field, they should have distinct subfields"
70
    if ( $c_field eq $m_field )
70
    if ( $c_field eq $m_field )
(-)a/misc/migration_tools/22_to_30/move_marc_to_authheader.pl (-1 / +1 lines)
Lines 51-57 while ( my ( $authid, $authtypecode ) = $sth->fetchrow ) { Link Here
51
        $record->insert_fields_ordered( MARC::Field->new( '001', $authid ) );
51
        $record->insert_fields_ordered( MARC::Field->new( '001', $authid ) );
52
    }
52
    }
53
53
54
    #Force UTF-8 in record FIXME CODESPELL (leaded ==> led, lead)
54
    #Force UTF-8 in record
55
    $record->encoding('UTF-8');
55
    $record->encoding('UTF-8');
56
56
57
    #     warn "REC : ".$record->as_formatted;
57
    #     warn "REC : ".$record->as_formatted;
(-)a/misc/migration_tools/build_oai_sets.pl (-1 / +1 lines)
Lines 180-186 sub print_usage { Link Here
180
    print "build_oai_sets.pl: Build OAI-PMH sets, according to mappings defined in Koha\n";
180
    print "build_oai_sets.pl: Build OAI-PMH sets, according to mappings defined in Koha\n";
181
    print "Usage: build_oai_sets.pl [-h] [-v] [-i] [-l LENGTH [-o OFFSET]]\n\n";
181
    print "Usage: build_oai_sets.pl [-h] [-v] [-i] [-l LENGTH [-o OFFSET]]\n\n";
182
    print "\t-h\t\tPrint this help and exit\n";
182
    print "\t-h\t\tPrint this help and exit\n";
183
    print "\t-v\t\the verbose\n";
183
    print "\t-v\t\t" . " Be verbose\n";
184
    print "\t-i\t\tEmbed items information, mandatory if you defined mappings on item fields\n";
184
    print "\t-i\t\tEmbed items information, mandatory if you defined mappings on item fields\n";
185
    print "\t-l LENGTH\tProcess LENGTH biblios\n";
185
    print "\t-l LENGTH\tProcess LENGTH biblios\n";
186
    print "\t-o OFFSET\tIf LENGTH is defined, start processing from OFFSET\n\n";
186
    print "\t-o OFFSET\tIf LENGTH is defined, start processing from OFFSET\n\n";
(-)a/opac/opac-MARCdetail.pl (-1 / +1 lines)
Lines 297-303 for ( my $tabloop = 0 ; $tabloop <= 9 ; $tabloop++ ) { Link Here
297
# now, build item tab !
297
# now, build item tab !
298
# the main difference is that datas are in lines and not in columns : thus, we build the <th> first, then the values...
298
# the main difference is that datas are in lines and not in columns : thus, we build the <th> first, then the values...
299
# loop through each tag
299
# loop through each tag
300
# warning : we may have FIXME CODESPELL (differents ==> different, difference) number of columns in each row. Thus, we first build a hash, complete it if necessary
300
# warning : we may have different number of columns in each row. Thus, we first build a hash, complete it if necessary
301
# then construct template.
301
# then construct template.
302
# $record has already had all the item fields filtered above.
302
# $record has already had all the item fields filtered above.
303
my @fields = $record->fields();
303
my @fields = $record->fields();
(-)a/opac/opac-suggestions.pl (-1 / +1 lines)
Lines 186-192 if ( $op eq "cud-add_confirm" ) { Link Here
186
        push @messages, { type => 'error', code => 'too_many' };
186
        push @messages, { type => 'error', code => 'too_many' };
187
    } elsif ( $suggestions->count >= 1 ) {
187
    } elsif ( $suggestions->count >= 1 ) {
188
188
189
        #some suggestion are answering the request FIXME CODESPELL (Donot ==> Do not, Donut) Add
189
        #some suggestion are answering the request, do not add
190
        while ( my $suggestion = $suggestions->next ) {
190
        while ( my $suggestion = $suggestions->next ) {
191
            push @messages,
191
            push @messages,
192
                {
192
                {
(-)a/opac/opac-tags.pl (-1 / +1 lines)
Lines 342-348 if ($add_op) { Link Here
342
342
343
    # Bug 36785: Do not pass biblionumber: get_approval_rows does not 'recognize' biblionumber
343
    # Bug 36785: Do not pass biblionumber: get_approval_rows does not 'recognize' biblionumber
344
    $results = get_approval_rows($arghash);
344
    $results = get_approval_rows($arghash);
345
    stratify_tags( 10, $results );    # work out the FIXME CODESPELL (differents ==> different, difference) sizes for things
345
    stratify_tags( 10, $results );    # work out the different sizes for things
346
    my $count = scalar @$results;
346
    my $count = scalar @$results;
347
    $template->param( TAGLOOP_COUNT => $count, mine => $mine );
347
    $template->param( TAGLOOP_COUNT => $count, mine => $mine );
348
}
348
}
(-)a/suggestion/suggestion.pl (-1 / +1 lines)
Lines 257-263 if ( $op =~ /cud-save/ ) { Link Here
257
            my $suggestions = Koha::Suggestions->search_limited($suggestion_only);
257
            my $suggestions = Koha::Suggestions->search_limited($suggestion_only);
258
            if ( $suggestions->count ) {
258
            if ( $suggestions->count ) {
259
259
260
                #some suggestion are answering the request FIXME CODESPELL (Donot ==> Do not, Donut) Add
260
                #some suggestion are answering the request, do not add
261
                my @messages;
261
                my @messages;
262
                while ( my $suggestion = $suggestions->next ) {
262
                while ( my $suggestion = $suggestions->next ) {
263
                    push @messages, { type => 'error', code => 'already_exists', id => $suggestion->suggestionid };
263
                    push @messages, { type => 'error', code => 'already_exists', id => $suggestion->suggestionid };
(-)a/svc/holds (-1 / +1 lines)
Lines 125-131 while ( my $h = $holds_rs->next() ) { Link Here
125
    };
125
    };
126
126
127
    $hold->{transferred}     = 0;
127
    $hold->{transferred}     = 0;
128
    $hold->{not_transfered} = 0;
128
    $hold->{not_transferred} = 0;
129
129
130
    if ($item) {
130
    if ($item) {
131
        $hold->{itemnumber}           = $item->itemnumber();
131
        $hold->{itemnumber}           = $item->itemnumber();
(-)a/t/cypress/support/e2e.js (-1 / +1 lines)
Lines 1298-1304 cy.get_title = () => { Link Here
1298
        num_last_vol_online: "num last vol",
1298
        num_last_vol_online: "num last vol",
1299
        online_identifier: "online identifier",
1299
        online_identifier: "online identifier",
1300
        parent_publication_title_id: "parent id",
1300
        parent_publication_title_id: "parent id",
1301
        preceding_publication_title_id: "FIXME CODESPELL (preceeding ==> preceding, proceeding) id",
1301
        preceding_publication_title_id: "preceding id",
1302
        print_identifier: "print identifier",
1302
        print_identifier: "print identifier",
1303
        publication_title: "publication title",
1303
        publication_title: "publication title",
1304
        publication_type: "journal",
1304
        publication_type: "journal",
(-)a/t/db_dependent/Acquisition/GetBasketAsCSV.t (-2 / +2 lines)
Lines 116-126 is( Link Here
116
116
117
try {
117
try {
118
    my $basket_csv4 = C4::Acquisition::GetBasketAsCSV( $basketno, $query, 'non_existant_profile_id' );
118
    my $basket_csv4 = C4::Acquisition::GetBasketAsCSV( $basketno, $query, 'non_existant_profile_id' );
119
    fail("It is not possible to export basket using non-existant profile");
119
    fail("It is not possible to export basket using non-existent profile");
120
} catch {
120
} catch {
121
    ok(
121
    ok(
122
        $_->isa("Koha::Exceptions::ObjectNotFound"),
122
        $_->isa("Koha::Exceptions::ObjectNotFound"),
123
        "Using non-existant profile should throw ObjectNotFound exception"
123
        "Using non-existent profile should throw ObjectNotFound exception"
124
    );
124
    );
125
};
125
};
126
126
(-)a/t/db_dependent/Biblio_holdsqueue.t (-1 / +1 lines)
Lines 83-89 subtest 'ModBiblio() + holds_queue update tests' => sub { Link Here
83
        $biblio->frameworkcode, { skip_holds_queue => 0 }
83
        $biblio->frameworkcode, { skip_holds_queue => 0 }
84
    );
84
    );
85
85
86
    # this call FIXME CODESPELL (shoul ==> should, shoal, shawl) not trigger the mocked 'enqueue'
86
    # this call should not trigger the mocked 'enqueue'
87
    C4::Biblio::ModBiblio(
87
    C4::Biblio::ModBiblio(
88
        $biblio->metadata->record, $biblio->id,
88
        $biblio->metadata->record, $biblio->id,
89
        $biblio->frameworkcode, { skip_holds_queue => 1 }
89
        $biblio->frameworkcode, { skip_holds_queue => 1 }
(-)a/t/db_dependent/Breeding.t (-3 / +3 lines)
Lines 132-143 sub test_build_translate_query { Link Here
132
    is( $queries[0] =~ /$str/, 1, 'First Z39.50 query contains ISBN' );
132
    is( $queries[0] =~ /$str/, 1, 'First Z39.50 query contains ISBN' );
133
133
134
    #SRU query should contain translation for ISBN
134
    #SRU query should contain translation for ISBN
135
    my $server = { sru_fields => 'isbn=ie-es-bee-en,srchany=overal' };
135
    my $server = { sru_fields => 'isbn=ie-es-bee-en,srchany=overall' };
136
    my $squery = C4::Breeding::_translate_query( $server, $queries[1] );
136
    my $squery = C4::Breeding::_translate_query( $server, $queries[1] );
137
    is( $squery =~ /ie-es-bee-en/, 1, 'SRU query has translated ISBN index' );
137
    is( $squery =~ /ie-es-bee-en/, 1, 'SRU query has translated ISBN index' );
138
138
139
    #Another try with fallback to any
139
    #Another try with fallback to any
140
    $server = { sru_fields => 'srchany=overal' };
140
    $server = { sru_fields => 'srchany=overall' };
141
    $squery = C4::Breeding::_translate_query( $server, $queries[1] );
141
    $squery = C4::Breeding::_translate_query( $server, $queries[1] );
142
    is( $squery =~ /overall/, 1, 'SRU query fallback to translated any' );
142
    is( $squery =~ /overall/, 1, 'SRU query fallback to translated any' );
143
143
Lines 170-176 sub test_build_translate_query { Link Here
170
    );
170
    );
171
171
172
    #SRU revisited
172
    #SRU revisited
173
    $server = { sru_fields => 'isbn=nb,title=dc.title,srchany=overal' };
173
    $server = { sru_fields => 'isbn=nb,title=dc.title,srchany=overall' };
174
    $squery = C4::Breeding::_translate_query( $server, $queries[1] );
174
    $squery = C4::Breeding::_translate_query( $server, $queries[1] );
175
    is( $squery =~ /dc.title/ && $squery =~ / and / && $squery =~ /nb=/, 1, 'SRU query with two parameters' );
175
    is( $squery =~ /dc.title/ && $squery =~ / and / && $squery =~ /nb=/, 1, 'SRU query with two parameters' );
176
176
(-)a/t/db_dependent/Circulation.t (-1 / +1 lines)
Lines 2059-2065 subtest "Bug 13841 - Do not create new 0 amount fines" => sub { Link Here
2059
    );
2059
    );
2060
    my $count = $hr->{count};
2060
    my $count = $hr->{count};
2061
2061
2062
    is( $count, 0, "Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine" );
2062
    is( $count, 0, "Calling UpdateFine on non-existent fine with an amount of 0 does not result in an empty fine" );
2063
};
2063
};
2064
2064
2065
subtest "AllowRenewalIfOtherItemsAvailable tests" => sub {
2065
subtest "AllowRenewalIfOtherItemsAvailable tests" => sub {
(-)a/t/db_dependent/Circulation/transferbook.t (-2 / +2 lines)
Lines 32-43 my $schema = Koha::Database->new->schema; Link Here
32
32
33
$schema->storage->txn_begin;
33
$schema->storage->txn_begin;
34
34
35
subtest 'transfer a non-existant item' => sub {
35
subtest 'transfer a non-existent item' => sub {
36
    plan tests => 2;
36
    plan tests => 2;
37
37
38
    my $library = $builder->build( { source => 'Branch' } );
38
    my $library = $builder->build( { source => 'Branch' } );
39
39
40
    #FIXME CODESPELL (Transfert ==> Transfer, Transferred) on unknown barcode
40
    #Transfer on unknown barcode
41
    my $item  = $builder->build_sample_item();
41
    my $item  = $builder->build_sample_item();
42
    my $badbc = $item->barcode;
42
    my $badbc = $item->barcode;
43
    $item->delete;
43
    $item->delete;
(-)a/t/db_dependent/HoldsQueue.t (-1 / +1 lines)
Lines 400-406 C4::Calendar->new( branchcode => $branchcodes[0] )->insert_single_holiday( Link Here
400
    description => "$today",
400
    description => "$today",
401
);
401
);
402
402
403
# If the test below is removed, FIXME CODESPELL (aother ==> another, other, mother) tests using the holiday will fail. For some reason if we call is_holiday now
403
# If the test below is removed, another tests using the holiday will fail. For some reason if we call is_holiday now
404
# the holiday will get set in cache correctly, but not if we let C4::HoldsQueue call is_holiday instead.
404
# the holiday will get set in cache correctly, but not if we let C4::HoldsQueue call is_holiday instead.
405
is(
405
is(
406
    Koha::Calendar->new( branchcode => $branchcodes[0] )->is_holiday($today), 1,
406
    Koha::Calendar->new( branchcode => $branchcodes[0] )->is_holiday($today), 1,
(-)a/t/db_dependent/LDAP/test_ldap_add.pl (-1 / +1 lines)
Lines 66-72 sub ldap_search { Link Here
66
    $query->code and die sprintf 'error (code:%s) - %s', $query->code, $query->error;
66
    $query->code and die sprintf 'error (code:%s) - %s', $query->code, $query->error;
67
    my $size = scalar( $query->entries );
67
    my $size = scalar( $query->entries );
68
    my $i    = 5;
68
    my $i    = 5;
69
    print "\number of records returned from search: $size.\n";
69
    print "\n" . "Number of records returned from search: $size." . "\n";
70
    ( $size > $i ) and print "Displaying the last $i records.\n\n";
70
    ( $size > $i ) and print "Displaying the last $i records.\n\n";
71
    foreach ( $query->entries ) {
71
    foreach ( $query->entries ) {
72
        ( $size-- > $i ) and next;
72
        ( $size-- > $i ) and next;
(-)a/t/db_dependent/Languages.t (-1 / +1 lines)
Lines 27-33 my $schema = Koha::Database->new->schema; Link Here
27
$schema->storage->txn_begin;
27
$schema->storage->txn_begin;
28
my $dbh = C4::Context->dbh;
28
my $dbh = C4::Context->dbh;
29
29
30
isnt( C4::Languages::_get_themes(), undef, 'testing _get_themes FIXME CODESPELL (doesnt ==> doesn't, does not) return undef' );
30
isnt( C4::Languages::_get_themes(), undef, 'testing _get_themes does not return undef' );
31
31
32
ok( C4::Languages::_get_language_dirs(), 'test getting _get_language_dirs' );
32
ok( C4::Languages::_get_language_dirs(), 'test getting _get_language_dirs' );
33
33
(-)a/t/db_dependent/Letters.t (-1 / +1 lines)
Lines 224-230 isnt( Link Here
224
    $messages->[0]->{updated_on}, $messages->[0]->{time_queued},
224
    $messages->[0]->{updated_on}, $messages->[0]->{time_queued},
225
    'Time status changed differs from time queued when status changes'
225
    'Time status changed differs from time queued when status changes'
226
);
226
);
227
is( dt_from_string( $messages->[0]->{time_queued} ), $yesterday, 'Time queued FIXME CODESPELL (remaines ==> remains, remained) inmutable' );
227
is( dt_from_string( $messages->[0]->{time_queued} ), $yesterday, 'Time queued remains inmutable' );
228
228
229
# ResendMessage
229
# ResendMessage
230
my $resent = C4::Letters::ResendMessage( $messages->[0]->{message_id} );
230
my $resent = C4::Letters::ResendMessage( $messages->[0]->{message_id} );
(-)a/t/db_dependent/OAI/Sets.t (-1 / +1 lines)
Lines 176-182 isa_ok( $set, 'HASH', '$set is a hash describing the set whose spec is $oai_sets Link Here
176
is( $set->{spec}, 'specSet2', 'spec field is "specSet2"' );
176
is( $set->{spec}, 'specSet2', 'spec field is "specSet2"' );
177
is( $set->{name}, 'nameSet2', 'name field is "nameSet2"' );
177
is( $set->{name}, 'nameSet2', 'name field is "nameSet2"' );
178
178
179
#GetOAISetBySpec does't return the description field.
179
#GetOAISetBySpec does not return the description field.
180
180
181
# ---------- Testing ModOAISet ------------------
181
# ---------- Testing ModOAISet ------------------
182
ok( !defined(ModOAISet), 'ModOAISet without argument is undef' );
182
ok( !defined(ModOAISet), 'ModOAISet without argument is undef' );
(-)a/t/db_dependent/Search.t (-2 / +2 lines)
Lines 1156-1167 sub run_unimarc_search_tests { Link Here
1156
        ['mainentry'], ['and'], [''], ['contains'],
1156
        ['mainentry'], ['and'], [''], ['contains'],
1157
        ['wil'], 0, 10, '', '', 1
1157
        ['wil'], 0, 10, '', '', 1
1158
    );
1158
    );
1159
    is( $count, 11, 'UNIMARC authorities: hits on mainentry contains "FIXME CODESPELL (wil ==> will, well)"' );
1159
    is( $count, 11, 'UNIMARC authorities: hits on mainentry contains the search term' );
1160
    ( $auths, $count ) = SearchAuthorities(
1160
    ( $auths, $count ) = SearchAuthorities(
1161
        ['match'], ['and'], [''], ['contains'],
1161
        ['match'], ['and'], [''], ['contains'],
1162
        ['wil'],   0, 10, '', '', 1
1162
        ['wil'],   0, 10, '', '', 1
1163
    );
1163
    );
1164
    is( $count, 11, 'UNIMARC authorities: hits on match contains "FIXME CODESPELL (wil ==> will, well)"' );
1164
    is( $count, 11, 'UNIMARC authorities: hits on match contains the search term' );
1165
    ( $auths, $count ) = SearchAuthorities(
1165
    ( $auths, $count ) = SearchAuthorities(
1166
        ['mainentry'], ['and'], [''], ['contains'],
1166
        ['mainentry'], ['and'], [''], ['contains'],
1167
        ['michel'],    0, 20, '', '', 1
1167
        ['michel'],    0, 20, '', '', 1
(-)a/t/db_dependent/Serials.t (-1 / +1 lines)
Lines 404-410 subtest 'GetSubscriptionsFromBiblionumber' => sub { Link Here
404
is( C4::Serials::GetSerials(),  undef, 'test getting serials when you enter nothing' );
404
is( C4::Serials::GetSerials(),  undef, 'test getting serials when you enter nothing' );
405
is( C4::Serials::GetSerials2(), undef, 'test getting serials when you enter nothing' );
405
is( C4::Serials::GetSerials2(), undef, 'test getting serials when you enter nothing' );
406
406
407
is( C4::Serials::GetLatestSerials(), undef, 'test getting FIXME CODESPELL (lastest ==> latest, last) serials' );
407
is( C4::Serials::GetLatestSerials(), undef, 'test getting latest serials' );
408
408
409
is( C4::Serials::GetNextSeq(), undef, 'test getting next seq when you enter nothing' );
409
is( C4::Serials::GetNextSeq(), undef, 'test getting next seq when you enter nothing' );
410
410
(-)a/t/db_dependent/Utils/Datatables_Virtualshelves.t (-2 / +2 lines)
Lines 188-194 t::lib::Mocks::mock_userenv( { patron => $john_doe_patron } ); Link Here
188
# Search private lists by title
188
# Search private lists by title
189
$search_results = C4::Utils::DataTables::VirtualShelves::search(
189
$search_results = C4::Utils::DataTables::VirtualShelves::search(
190
    {
190
    {
191
        shelfname => "FIXME CODESPELL (ist ==> is, it, its, it's, sit, list)",
191
        shelfname => "list",
192
        %dt_params,
192
        %dt_params,
193
        public => 0,
193
        public => 0,
194
    }
194
    }
Lines 201-207 is( Link Here
201
201
202
is(
202
is(
203
    $search_results->{recordsFiltered}, 2,
203
    $search_results->{recordsFiltered}, 2,
204
    "There should be 2 private shelves with title like '%FIXME CODESPELL (ist ==> is, it, its, it's, sit, list)%"
204
    "There should be 2 private shelves with title like '%list%"
205
);
205
);
206
206
207
is(
207
is(
(-)a/t/db_dependent/api/v1/stockrotationstage.t (-3 / +2 lines)
Lines 86-96 subtest 'move() tests' => sub { Link Here
86
    $t->put_ok( "//$unauth_userid:$password@/api/v1/rotas/$rota_id/stages/$stage1_id/position" => json => 2 )
86
    $t->put_ok( "//$unauth_userid:$password@/api/v1/rotas/$rota_id/stages/$stage1_id/position" => json => 2 )
87
        ->status_is(403);
87
        ->status_is(403);
88
88
89
    # Invalid attempt to move a stage on a non-existant rota
89
    # Invalid attempt to move a stage on a non-existent rota
90
    $t->put_ok( "//$auth_userid:$password@/api/v1/rotas/99999999/stages/$stage1_id/position" => json => 2 )
90
    $t->put_ok( "//$auth_userid:$password@/api/v1/rotas/99999999/stages/$stage1_id/position" => json => 2 )
91
        ->status_is(404)->json_is( '/error' => "Rota not found" );
91
        ->status_is(404)->json_is( '/error' => "Rota not found" );
92
92
93
    # Invalid attempt to move an non-existant stage
93
    # Invalid attempt to move an non-existent stage
94
    $t->put_ok( "//$auth_userid:$password@/api/v1/rotas/$rota_id/stages/999999999/position" => json => 2 )
94
    $t->put_ok( "//$auth_userid:$password@/api/v1/rotas/$rota_id/stages/999999999/position" => json => 2 )
95
        ->status_is(404)->json_is( '/error' => "Stage not found" );
95
        ->status_is(404)->json_is( '/error' => "Stage not found" );
96
96
97
- 

Return to bug 39325