View | Details | Raw Unified | Return to bug 39632
Collapse All | Expand All

(-)a/Koha/Plugins/Base.pm (-2 / +2 lines)
Lines 62-68 sub new { Link Here
62
                warn "Plugin $class failed during installation!";
62
                warn "Plugin $class failed during installation!";
63
            }
63
            }
64
        } catch {
64
        } catch {
65
            Koha::Exceptions::Plugin::InstallDied->throw( plugin_class => $class );
65
            Koha::Exceptions::Plugin::InstallDied->throw( plugin_class => $class, install_error => "$_" );
66
        };
66
        };
67
    } elsif ( $self->can('upgrade') ) {
67
    } elsif ( $self->can('upgrade') ) {
68
        if ( _version_compare( $plugin_version, $database_version ) == 1 ) {
68
        if ( _version_compare( $plugin_version, $database_version ) == 1 ) {
Lines 73-79 sub new { Link Here
73
                    warn "Plugin $class failed during upgrade!";
73
                    warn "Plugin $class failed during upgrade!";
74
                }
74
                }
75
            } catch {
75
            } catch {
76
                Koha::Exceptions::Plugin::UpgradeDied->throw( plugin_class => $class );
76
                Koha::Exceptions::Plugin::UpgradeDied->throw( plugin_class => $class, upgrade_error => "$_" );
77
            };
77
            };
78
        }
78
        }
79
    } elsif ( $plugin_version ne $database_version ) {
79
    } elsif ( $plugin_version ne $database_version ) {
(-)a/t/db_dependent/Koha/Plugins/Broken.t (-4 / +4 lines)
Lines 37-48 $schema->storage->txn_begin; Link Here
37
37
38
t::lib::Mocks::mock_config( 'enable_plugins', 1 );
38
t::lib::Mocks::mock_config( 'enable_plugins', 1 );
39
39
40
my $plugins = Koha::Plugins->new;
40
my $plugins      = Koha::Plugins->new;
41
my $error_string = 'Why Liz? WHY?';
41
42
42
warnings_are { $plugins->InstallPlugins; }
43
warnings_are { $plugins->InstallPlugins; }
43
[
44
[
44
    "Calling 'install' died for plugin Koha::Plugin::BrokenInstall",
45
    "Calling 'install' died for plugin Koha::Plugin::BrokenInstall: $error_string",
45
    "Calling 'upgrade' died for plugin Koha::Plugin::BrokenUpgrade"
46
    "Calling 'upgrade' died for plugin Koha::Plugin::BrokenUpgrade: $error_string"
46
];
47
];
47
48
48
$schema->storage->txn_begin;
49
$schema->storage->txn_begin;
49
- 

Return to bug 39632