View | Details | Raw Unified | Return to bug 39180
Collapse All | Expand All

(-)a/C4/Circulation.pm (-3 / +24 lines)
Lines 22-27 use Modern::Perl; Link Here
22
use DateTime;
22
use DateTime;
23
use POSIX qw( floor );
23
use POSIX qw( floor );
24
use Encode;
24
use Encode;
25
use Try::Tiny;
25
26
26
use C4::Context;
27
use C4::Context;
27
use C4::Stats qw( UpdateStats );
28
use C4::Stats qw( UpdateStats );
Lines 1783-1789 sub AddIssue { Link Here
1783
                );
1784
                );
1784
            }
1785
            }
1785
            $issue->discard_changes;
1786
            $issue->discard_changes;
1786
            $patron->update_lastseen('check_out');
1787
            #Update borrowers.lastseen
1788
            try{
1789
                $patron->update_lastseen('check_out');
1790
            }
1791
            catch {
1792
                my $exception = $_;
1793
                warn "Problem updating lastseen date for borrowernumber " . $patron->borrowernumber . ": $exception";
1794
            };
1787
            if (   $item_object->location
1795
            if (   $item_object->location
1788
                && $item_object->location eq 'CART'
1796
                && $item_object->location eq 'CART'
1789
                && ( !$item_object->permanent_location || $item_object->permanent_location ne 'CART' ) )
1797
                && ( !$item_object->permanent_location || $item_object->permanent_location ne 'CART' ) )
Lines 2576-2582 sub AddReturn { Link Here
2576
            if C4::Context->preference("ReturnLog");
2584
            if C4::Context->preference("ReturnLog");
2577
2585
2578
        #Update borrowers.lastseen
2586
        #Update borrowers.lastseen
2579
        $patron->update_lastseen('check_in');
2587
        try{
2588
            $patron->update_lastseen('check_in');
2589
        }
2590
        catch {
2591
            my $exception = $_;
2592
            warn "Problem updating lastseen date for borrowernumber " . $patron->borrowernumber . ": $exception";
2593
            $messages->{UpdateLastSeenError} = "$exception";
2594
        };
2580
    }
2595
    }
2581
2596
2582
    # Check if this item belongs to a biblio record that is attached to an
2597
    # Check if this item belongs to a biblio record that is attached to an
Lines 3524-3530 sub AddRenewal { Link Here
3524
            );
3539
            );
3525
3540
3526
            #Update borrowers.lastseen
3541
            #Update borrowers.lastseen
3527
            $patron->update_lastseen('renewal');
3542
            try{
3543
                $patron->update_lastseen('renewal');
3544
            }
3545
            catch {
3546
                my $exception = $_;
3547
                warn "Problem updating lastseen date for borrowernumber " . $patron->borrowernumber . ": $exception";
3548
            };
3528
3549
3529
            #Log the renewal
3550
            #Log the renewal
3530
            logaction( "CIRCULATION", "RENEWAL", $borrowernumber, $itemnumber )
3551
            logaction( "CIRCULATION", "RENEWAL", $borrowernumber, $itemnumber )
(-)a/circ/returns.pl (+2 lines)
Lines 743-748 foreach my $code ( keys %$messages ) { Link Here
743
        ;
743
        ;
744
    } elsif ( $code eq 'InBundle' ) {
744
    } elsif ( $code eq 'InBundle' ) {
745
        $template->param( InBundle => $messages->{InBundle} );
745
        $template->param( InBundle => $messages->{InBundle} );
746
    } elsif ( $code eq 'UpdateLastSeenError' ) {
747
        $err{UpdateLastSeenError}           = $messages->{UpdateLastSeenError};
746
    } else {
748
    } else {
747
        die "Unknown error code $code";    # note we need all the (empty) elsif's above, or we die.
749
        die "Unknown error code $code";    # note we need all the (empty) elsif's above, or we die.
748
                                           # This forces the issue of staying in sync w/ Circulation.pm
750
                                           # This forces the issue of staying in sync w/ Circulation.pm
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt (-1 / +8 lines)
Lines 294-299 Link Here
294
                            [% END %]
294
                            [% END %]
295
                        </p>
295
                        </p>
296
                    [% END %]
296
                    [% END %]
297
                    [% IF ( errmsgloo.UpdateLastSeenError ) %]
298
                        <div id="update_last_seen_error" class="alert alert-warning audio-alert-warning">
299
                            <h3>Error updating patron's last seen date</h3>
300
                            <p>The item has been checked in, but the issue below must be corrected:</p>
301
                            <p>The system encountered an error when updating the patron's last seen date:</p>
302
                            <p>[% errmsgloo.UpdateLastSeenError | html %]</p>
303
                        </div>
304
                    [% END %]
297
                    [% IF ( errmsgloo.ItemLocationUpdated ) %]
305
                    [% IF ( errmsgloo.ItemLocationUpdated ) %]
298
                        <p class="problem ret_location_update">
306
                        <p class="problem ret_location_update">
299
                            Item shelving location updated.
307
                            Item shelving location updated.
300
- 

Return to bug 39180