Attachment #18338 for bug #7295

View | Details | Raw Unified | Return to bug 7295
Collapse All | Expand All

Lines 48-53 BEGIN { Link Here

(-)a/C4/Acquisition.pm (-2 / +147 lines)
48	&GetBasketsByBookseller &GetBasketsByBasketgroup	48	&GetBasketsByBookseller &GetBasketsByBasketgroup
49	&GetBasketsInfosByBookseller	49	&GetBasketsInfosByBookseller
50		50
		51	&GetBasketUsers &ModBasketUsers
		52	&CanUserManageBasket
		53
51	&ModBasketHeader	54	&ModBasketHeader
52		55
53	&ModBasketgroup &NewBasketgroup &DelBasketgroup &GetBasketgroup &CloseBasketgroup	56	&ModBasketgroup &NewBasketgroup &DelBasketgroup &GetBasketgroup &CloseBasketgroup
Lines 156-163 sub GetBasket { Link Here
156	my $dbh = C4::Context->dbh;	159	my $dbh = C4::Context->dbh;
157	my $query = "	160	my $query = "
158	SELECT aqbasket.*,	161	SELECT aqbasket.*,
159	concat( b.firstname,' ',b.surname) AS authorisedbyname,	162	concat( b.firstname,' ',b.surname) AS authorisedbyname
160	b.branchcode AS branch
161	FROM aqbasket	163	FROM aqbasket
162	LEFT JOIN borrowers b ON aqbasket.authorisedby=b.borrowernumber	164	LEFT JOIN borrowers b ON aqbasket.authorisedby=b.borrowernumber
163	WHERE basketno=?	165	WHERE basketno=?
Lines 606-611 sub GetBasketsInfosByBookseller { Link Here
606	return $sth->fetchall_arrayref({});	608	return $sth->fetchall_arrayref({});
607	}	609	}
608		610
		611	=head3 GetBasketUsers
		612
		613	$basketusers_ids = &GetBasketUsers($basketno);
		614
		615	Returns a list of all borrowernumbers that are in basket users list
		616
		617	=cut
		618
		619	sub GetBasketUsers {
		620	my $basketno = shift;
		621
		622	return unless $basketno;
		623
		624	my $query = qq{
		625	SELECT borrowernumber
		626	FROM aqbasketusers
		627	WHERE basketno = ?
		628	};
		629	my $dbh = C4::Context->dbh;
		630	my $sth = $dbh->prepare($query);
		631	$sth->execute($basketno);
		632	my $results = $sth->fetchall_arrayref( {} );
		633	$sth->finish();
		634
		635	my @borrowernumbers;
		636	foreach (@$results) {
		637	push @borrowernumbers, $_->{'borrowernumber'};
		638	}
		639
		640	return @borrowernumbers;
		641	}
		642
		643	=head3 ModBasketUsers
		644
		645	my @basketusers_ids = (1, 2, 3);
		646	&ModBasketUsers($basketno, @basketusers_ids);
		647
		648	Delete all users from basket users list, and add users in C<@basketusers_ids>
		649	to this users list.
		650
		651	=cut
		652
		653	sub ModBasketUsers {
		654	my ($basketno, @basketusers_ids) = @_;
		655
		656	return unless $basketno;
		657
		658	my $dbh = C4::Context->dbh;
		659	my $query = qq{
		660	DELETE FROM aqbasketusers
		661	WHERE basketno = ?
		662	};
		663	my $sth = $dbh->prepare($query);
		664	$sth->execute($basketno);
		665	$sth->finish();
		666
		667	$query = qq{
		668	INSERT INTO aqbasketusers (basketno, borrowernumber)
		669	VALUES (?, ?)
		670	};
		671	$sth = $dbh->prepare($query);
		672	foreach my $basketuser_id (@basketusers_ids) {
		673	$sth->execute($basketno, $basketuser_id);
		674	}
675	}
676
677	=head3 CanUserManageBasket
678
679	my $bool = CanUserManageBasket($borrower, $basket[, $userflags]);
680	my $bool = CanUserManageBasket($borrowernumber, $basketno[, $userflags]);
681
682	Check if a borrower can manage a basket, according to system preference
683	AcqViewBaskets, user permissions and basket properties (creator, users list,
684	branch).
685
686	First parameter can be either a borrowernumber or a hashref as returned by
687	C4::Members::GetMember.
688
689	Second parameter can be either a basketno or a hashref as returned by
690	C4::Acquisition::GetBasket.
691
692	The third parameter is optional. If given, it should be a hashref as returned
693	by C4::Auth::getuserflags. If not, getuserflags is called.
694
695	If user is authorised to manage basket, returns 1.
696	Otherwise returns 0.
697
698	=cut
699
700	sub CanUserManageBasket {
701	my ($borrower, $basket, $userflags) = @_;
702
703	if (!ref $borrower) {
704	$borrower = C4::Members::GetMember(borrowernumber => $borrower);
705	}
706	if (!ref $basket) {
707	$basket = GetBasket($basket);
708	}
709
710	return 0 unless ($basket and $borrower);
711
712	my $borrowernumber = $borrower->{borrowernumber};
713	my $basketno = $basket->{basketno};
714
715	my $AcqViewBaskets = C4::Context->preference('AcqViewBaskets');
716
717	if (!defined $userflags) {
718	my $dbh = C4::Context->dbh;
719	my $sth = $dbh->prepare("SELECT flags FROM borrowers WHERE borrowernumber = ?");
720	$sth->execute($borrowernumber);
721	my ($flags) = $sth->fetchrow_array;
722	$sth->finish;
723
724	$userflags = C4::Auth::getuserflags($flags, $borrower->{userid}, $dbh);
725	}
726
727	unless ($userflags->{superlibrarian}
728	\|\| (ref $userflags->{acquisition} && $userflags->{acquisition}->{order_manage_all})
729	\|\| (!ref $userflags->{acquisition} && $userflags->{acquisition}))
730	{
731	if (not exists $userflags->{acquisition}) {
732	return 0;
733	}
734
735	if ( (ref $userflags->{acquisition} && !$userflags->{acquisition}->{order_manage})
736	\|\| (!ref $userflags->{acquisition} && !$userflags->{acquisition}) ) {
737	return 0;
738	}
739
740	if ($AcqViewBaskets eq 'user'
741	&& $basket->{authorisedby} != $borrowernumber
742	&& grep($borrowernumber, GetBasketUsers($basketno)) == 0) {
743	return 0;
744	}
745
746	if ($AcqViewBaskets eq 'branch' && defined $basket->{branch}
747	&& $basket->{branch} ne $borrower->{branchcode}) {
748	return 0;
749	}
750	}
751
752	return 1;
753	}
609		754
610	#------------------------------------------------------------#	755	#------------------------------------------------------------#
611		756




#!/usr/bin/perl

# script to find a basket user

# Copyright 2012 BibLibre SARL
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it under the
# terms of the GNU General Public License as published by the Free Software
# Foundation; either version 2 of the License, or (at your option) any later
# version.
#
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along
# with Koha; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

use Modern::Perl;

use CGI;
use C4::Auth;
use C4::Output;
use C4::Members;

my $input = new CGI;

my $dbh = C4::Context->dbh;

my ( $template, $loggedinuser, $cookie, $staff_flags ) = get_template_and_user(
    {   template_name   => "acqui/aqbasketuser_search.tmpl",
        query           => $input,
        type            => "intranet",
        authnotrequired => 0,
        flagsrequired   => { acquisition => 'order_manage' },
    }
);

my $q = $input->param('q') || '';
my $op = $input->param('op') || '';

if( $op eq "do_search" ) {
    my $results = C4::Members::Search( $q, "surname");

    my @users_loop;
    my $nresults = 0;
    foreach my $res (@$results) {
        my $perms = haspermission( $res->{userid} );
        my $subperms = get_user_subpermissions( $res->{userid} );

        if( $perms->{superlibrarian} == 1
         || $perms->{acquisition} == 1
         || $subperms->{acquisition}->{'order_manage'} ) {
            my %row = (
                borrowernumber  => $res->{borrowernumber},
                cardnumber      => $res->{cardnumber},
                surname         => $res->{surname},
                firstname       => $res->{firstname},
                categorycode    => $res->{categorycode},
                branchcode      => $res->{branchcode},
            );
            push( @users_loop, \%row );
            $nresults ++;
        }
    }

    $template->param(
        q           => $q,
        nresults    => $nresults,
        users_loop  => \@users_loop,
    );
}

output_html_with_http_headers( $input, $cookie, $template->output );




use CGI;
use C4::Acquisition;
use C4::Budgets;
use C4::Branch;
use C4::Bookseller qw( GetBookSellerFromId);
use C4::Debug;
use C4::Biblio;

);

my $basket = GetBasket($basketno);
$booksellerid = $basket->{booksellerid} unless $booksellerid;
my ($bookseller) = GetBookSellerFromId($booksellerid);

unless (CanUserManageBasket($loggedinuser, $basket, $userflags)) {
    $template->param(
        cannot_manage_basket => 1,
        basketno => $basketno,
        basketname => $basket->{basketname},
        booksellerid => $booksellerid,
        name => $bookseller->{name}
    );
    output_html_with_http_headers $query, $cookie, $template->output;
    exit;
}

# FIXME : what about the "discount" percentage?
# FIXME : the query->param('booksellerid') below is probably useless. The bookseller is always known from the basket
# if no booksellerid in parameter, get it from basket
# warn "=>".$basket->{booksellerid};
$booksellerid = $basket->{booksellerid} unless $booksellerid;
my ($bookseller) = GetBookSellerFromId($booksellerid);
my $op = $query->param('op');
if (!defined $op) {
    $op = q{};

    $basket->{closedate} = undef;
    ModBasket($basket);
    print $query->redirect('/cgi-bin/koha/acqui/basket.pl?basketno='.$basket->{'basketno'})
} elsif ( $op eq 'mod_users' ) {
    my $basketusers_ids = $query->param('basketusers_ids');
    my @basketusers = split( /:/, $basketusers_ids );
    ModBasketUsers($basketno, @basketusers);
    print $query->redirect("/cgi-bin/koha/acqui/basket.pl?basketno=$basketno");
    exit;
} elsif ( $op eq 'mod_branch' ) {
    my $branch = $query->param('branch');
    $branch = undef if(defined $branch and $branch eq '');
    ModBasket({
        basketno => $basket->{basketno},
        branch   => $branch
    });
    print $query->redirect("/cgi-bin/koha/acqui/basket.pl?basketno=$basketno");
    exit;
} else {
    # get librarian branch...
    if ( C4::Context->preference("IndependentBranches") ) {

            }
        }
    }
    # get branches
    my $branches = C4::Branch::GetBranches;
    my @branches_loop;
    foreach my $branch (sort keys %$branches) {
        push @branches_loop, {
            branchcode => $branch,
            branchname => $branches->{$branch}->{branchname},
            selected => (defined $basket->{branch} and $branch eq $basket->{branch}) ? 1 : 0
        };
    }

#if the basket is closed,and the user has the permission to edit basketgroups, display a list of basketgroups
    my ($basketgroup, $basketgroups);
    my $member = GetMember(borrowernumber => $loggedinuser);

      "loggedinuser: $loggedinuser; creationdate: %s; authorisedby: %s",
      $basket->{creationdate}, $basket->{authorisedby};

    my @basketusers_ids = GetBasketUsers($basketno);
    my @basketusers;
    foreach my $basketuser_id (@basketusers_ids) {
        my $basketuser = GetMember(borrowernumber => $basketuser_id);
        push @basketusers, $basketuser if $basketuser;
    }

    #to get active currency
    my $cur = GetCurrency();


        basketbooksellernote => $basket->{booksellernote},
        basketcontractno     => $basket->{contractnumber},
        basketcontractname   => $contract->{contractname},
        branches_loop        => \@branches_loop,
        creationdate         => $basket->{creationdate},
        authorisedby         => $basket->{authorisedby},
        authorisedbyname     => $basket->{authorisedbyname},
        basketusers_ids      => join(':', @basketusers_ids),
        basketusers          => \@basketusers,
        closedate            => $basket->{closedate},
        estimateddeliverydate=> $estimateddeliverydate,
        deliveryplace        => C4::Branch::GetBranchName( $basket->{deliveryplace} ),




use C4::Output;
use CGI;

use C4::Acquisition qw/ GetBasketsInfosByBookseller CanUserManageBasket /;
use C4::Bookseller qw/ GetBookSellerFromId GetBookSeller /;
use C4::Members qw/GetMember/;
use C4::Context;

my $query = CGI->new;
my ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user(
    {   template_name   => 'acqui/booksellers.tmpl',
        query           => $query,
        type            => 'intranet',

    $uid = GetMember( borrowernumber => $loggedinuser )->{userid};
}

my $userenv = C4::Context::userenv;
my $viewbaskets = C4::Context->preference('AcqViewBaskets');

my $userbranch = $userenv->{branch};

#build result page
my $loop_suppliers = [];


    my $loop_basket = [];

    for my $basket ( @{$baskets} ) {
        if (CanUserManageBasket($loggedinuser, $basket, $userflags)) {
            my $member = GetMember( borrowernumber => $basket->{authorisedby} );
        my $member = GetMember( borrowernumber => $authorisedby );
        if ( $member ) {
           $basketbranch = $member->{branchcode};
        }

        if ($userenv->{'flags'} & 1 || #user is superlibrarian
               (haspermission( $uid, { acquisition => q{*} } ) && #user has acq permissions and
                   ($viewbaskets eq 'all' || #user is allowed to see all baskets
                   ($viewbaskets eq 'branch' && $authorisedby && $userbranch eq $basketbranch) || #basket belongs to user's branch
                   ($basket->{authorisedby} &&  $viewbaskets eq 'user' && $authorisedby == $loggedinuser) #user created this basket
                   ) 
                ) 
           ) { 
            foreach (qw(total_items total_biblios expected_items)) {
                $basket->{$_} ||= 0;
            }

Lines 16-21 INSERT INTO permissions (module_bit, code, description) VALUES Link Here

(-)a/installer/data/mysql/de-DE/mandatory/userpermissions.sql (+1 lines)
16	(11, 'budget_modify', 'Konten verändern (keine Neuen anlegen, aber Bestehende ändern)'),	16	(11, 'budget_modify', 'Konten verändern (keine Neuen anlegen, aber Bestehende ändern)'),
17	(11, 'planning_manage', 'Etatplanung verwalten'),	17	(11, 'planning_manage', 'Etatplanung verwalten'),
18	(11, 'order_manage', 'Bestellungen verwalten'),	18	(11, 'order_manage', 'Bestellungen verwalten'),
		19	(11, 'order_manage_all', 'Manage all orders & baskets'),
19	(11, 'group_manage', 'Bestellgruppen vewalten'),	20	(11, 'group_manage', 'Bestellgruppen vewalten'),
20	(11, 'order_receive', 'Lieferungen verwalten'),	21	(11, 'order_receive', 'Lieferungen verwalten'),
21	(11, 'budget_add_del', 'Konten hinzufügen/ändern, aber bestehende nicht ändern'),	22	(11, 'budget_add_del', 'Konten hinzufügen/ändern, aber bestehende nicht ändern'),

Lines 16-21 INSERT INTO permissions (module_bit, code, description) VALUES Link Here

(-)a/installer/data/mysql/en/mandatory/userpermissions.sql (+1 lines)
16	(11, 'budget_modify', 'Modify budget (can''t create lines, but can modify existing ones)'),	16	(11, 'budget_modify', 'Modify budget (can''t create lines, but can modify existing ones)'),
17	(11, 'planning_manage', 'Manage budget plannings'),	17	(11, 'planning_manage', 'Manage budget plannings'),
18	(11, 'order_manage', 'Manage orders & basket'),	18	(11, 'order_manage', 'Manage orders & basket'),
		19	(11, 'order_manage_all', 'Manage all orders & baskets'),
19	(11, 'group_manage', 'Manage orders & basketgroups'),	20	(11, 'group_manage', 'Manage orders & basketgroups'),
20	(11, 'order_receive', 'Manage orders & basket'),	21	(11, 'order_receive', 'Manage orders & basket'),
21	(11, 'budget_add_del', 'Add and delete budgets (but cant modify budgets)'),	22	(11, 'budget_add_del', 'Add and delete budgets (but cant modify budgets)'),

Lines 16-21 INSERT INTO permissions (module_bit, code, description) VALUES Link Here

(-)a/installer/data/mysql/es-ES/mandatory/userpermissions.sql (+1 lines)
16	(11, 'budget_modify', 'Modify budget (can''t create lines, but can modify existing ones)'),	16	(11, 'budget_modify', 'Modify budget (can''t create lines, but can modify existing ones)'),
17	(11, 'planning_manage', 'Manage budget plannings'),	17	(11, 'planning_manage', 'Manage budget plannings'),
18	(11, 'order_manage', 'Manage orders & basket'),	18	(11, 'order_manage', 'Manage orders & basket'),
		19	(11, 'order_manage_all', 'Manage all orders & baskets'),
19	(11, 'group_manage', 'Manage orders & basketgroups'),	20	(11, 'group_manage', 'Manage orders & basketgroups'),
20	(11, 'order_receive', 'Manage orders & basket'),	21	(11, 'order_receive', 'Manage orders & basket'),
21	(11, 'budget_add_del', 'Add and delete budgets (but cant modify budgets)'),	22	(11, 'budget_add_del', 'Add and delete budgets (but cant modify budgets)'),

Lines 33-38 INSERT INTO permissions (module_bit, code, description) VALUES Link Here

(-)a/installer/data/mysql/fr-FR/1-Obligatoire/userpermissions.sql (+1 lines)
33	(11, 'budget_modify', 'Modifier les budgets (impossible de créer les lignes, mais possible de modifier celles qui existent'),	33	(11, 'budget_modify', 'Modifier les budgets (impossible de créer les lignes, mais possible de modifier celles qui existent'),
34	(11, 'planning_manage', 'Gérer de la planification des budgets'),	34	(11, 'planning_manage', 'Gérer de la planification des budgets'),
35	(11, 'order_manage', 'Gérer les commandes et les paniers'),	35	(11, 'order_manage', 'Gérer les commandes et les paniers'),
		36	(11, 'order_manage_all', 'Gérer toutes les commandes et panier'),
36	(11, 'group_manage', 'Gérer les commandes et les bons de commande'),	37	(11, 'group_manage', 'Gérer les commandes et les bons de commande'),
37	(11, 'order_receive', 'Gérer les réceptions'),	38	(11, 'order_receive', 'Gérer les réceptions'),
38	(11, 'budget_add_del', 'Ajouter et supprimer les budgets (mais pas modifier)'),	39	(11, 'budget_add_del', 'Ajouter et supprimer les budgets (mais pas modifier)'),

Lines 18-23 INSERT INTO permissions (module_bit, code, description) VALUES Link Here

(-)a/installer/data/mysql/it-IT/necessari/userpermissions.sql (+1 lines)
18	(11, 'budget_modify', 'Modifica budget (non li crea ma modifica gli esistenti)'),	18	(11, 'budget_modify', 'Modifica budget (non li crea ma modifica gli esistenti)'),
19	(11, 'planning_manage', 'Intervieni sulla pianificazione dei budgets'),	19	(11, 'planning_manage', 'Intervieni sulla pianificazione dei budgets'),
20	(11, 'order_manage', 'Gestisci ordini e raccoglitori'),	20	(11, 'order_manage', 'Gestisci ordini e raccoglitori'),
		21	(11, 'order_manage_all', 'Manage all orders & baskets'),
21	(11, 'group_manage', 'Gestisci ordini e raccoglitori raggruppati'),	22	(11, 'group_manage', 'Gestisci ordini e raccoglitori raggruppati'),
22	(11, 'order_receive', 'Gestisci arrivi'),	23	(11, 'order_receive', 'Gestisci arrivi'),
23	(11, 'budget_add_del', 'Aggiungi e cancella budgets (senza modificarli)'),	24	(11, 'budget_add_del', 'Aggiungi e cancella budgets (senza modificarli)'),




  `basketgroupid` int(11), -- links this basket to its group (aqbasketgroups.id)
  `deliveryplace` varchar(10) default NULL, -- basket delivery place
  `billingplace` varchar(10) default NULL, -- basket billing place
  branch varchar(10) default NULL, -- basket branch
  PRIMARY KEY  (`basketno`),
  KEY `booksellerid` (`booksellerid`),
  KEY `basketgroupid` (`basketgroupid`),

  CONSTRAINT `aqbasket_ibfk_1` FOREIGN KEY (`booksellerid`) REFERENCES `aqbooksellers` (`id`) ON UPDATE CASCADE,
  CONSTRAINT `aqbasket_ibfk_2` FOREIGN KEY (`contractnumber`) REFERENCES `aqcontract` (`contractnumber`),
  CONSTRAINT `aqbasket_ibfk_3` FOREIGN KEY (`basketgroupid`) REFERENCES `aqbasketgroups` (`id`) ON UPDATE CASCADE
  CONSTRAINT aqbasket_ibfk_4 FOREIGN KEY (branch) REFERENCES branches (branchcode) ON UPDATE CASCADE ON DELETE SET NULL,
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

--
-- Table structure for table aqbasketusers
--

DROP TABLE IF EXISTS aqbasketusers;
CREATE TABLE aqbasketusers (
  basketno int(11) NOT NULL,
  borrowernumber int(11) NOT NULL,
  PRIMARY KEY (basketno,borrowernumber),
  CONSTRAINT aqbasketusers_ibfk_1 FOREIGN KEY (basketno) REFERENCES aqbasket (basketno) ON UPDATE CASCADE ON DELETE CASCADE,
  CONSTRAINT aqbasketusers_ibfk_2 FOREIGN KEY (borrowernumber) REFERENCES borrowers (borrowernumber) ON UPDATE CASCADE ON DELETE CASCADE
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

--

Lines 36-41 INSERT INTO permissions (module_bit, code, description) VALUES Link Here

(-)a/installer/data/mysql/nb-NO/1-Obligatorisk/userpermissions.sql (+1 lines)
36	(11, 'budget_modify', 'Endre budsjetter (kan ikke legge til kontolinjer, men endre eksisterende)'),	36	(11, 'budget_modify', 'Endre budsjetter (kan ikke legge til kontolinjer, men endre eksisterende)'),
37	(11, 'planning_manage', 'Administrere budsjettplaner'),	37	(11, 'planning_manage', 'Administrere budsjettplaner'),
38	(11, 'order_manage', 'Administrere bestillinger og kurver'),	38	(11, 'order_manage', 'Administrere bestillinger og kurver'),
		39	(11, 'order_manage_all', 'Manage all orders & baskets'),
39	(11, 'group_manage', 'Administrere bestillinger og kurv-grupper'),	40	(11, 'group_manage', 'Administrere bestillinger og kurv-grupper'),
40	(11, 'order_receive', 'Administrere bestillinger og kurver'),	41	(11, 'order_receive', 'Administrere bestillinger og kurver'),
41	(11, 'budget_add_del', 'Legge til og slette budsjetter (men ikke endre budsjetter)'),	42	(11, 'budget_add_del', 'Legge til og slette budsjetter (men ikke endre budsjetter)'),

Lines 16-21 INSERT INTO permissions (module_bit, code, description) VALUES Link Here

(-)a/installer/data/mysql/pl-PL/mandatory/userpermissions.sql (+1 lines)
16	(11, 'budget_modify', 'Modify budget (can''t create lines, but can modify existing ones)'),	16	(11, 'budget_modify', 'Modify budget (can''t create lines, but can modify existing ones)'),
17	(11, 'planning_manage', 'Manage budget plannings'),	17	(11, 'planning_manage', 'Manage budget plannings'),
18	(11, 'order_manage', 'Manage orders & basket'),	18	(11, 'order_manage', 'Manage orders & basket'),
		19	(11, 'order_manage_all', 'Manage all orders & baskets'),
19	(11, 'group_manage', 'Manage orders & basketgroups'),	20	(11, 'group_manage', 'Manage orders & basketgroups'),
20	(11, 'order_receive', 'Manage orders & basket'),	21	(11, 'order_receive', 'Manage orders & basket'),
21	(11, 'budget_add_del', 'Add and delete budgets (but cant modify budgets)'),	22	(11, 'budget_add_del', 'Add and delete budgets (but cant modify budgets)'),

Lines 42-47 INSERT INTO permissions (module_bit, code, description) VALUES Link Here

(-)a/installer/data/mysql/ru-RU/mandatory/permissions_and_user_flags.sql (+1 lines)
42	(11, 'budget_modify', 'Modify budget (can''t create lines, but can modify existing ones)'),	42	(11, 'budget_modify', 'Modify budget (can''t create lines, but can modify existing ones)'),
43	(11, 'planning_manage', 'Manage budget plannings'),	43	(11, 'planning_manage', 'Manage budget plannings'),
44	(11, 'order_manage', 'Manage orders & basket'),	44	(11, 'order_manage', 'Manage orders & basket'),
		45	(11, 'order_manage_all', 'Manage all orders & baskets'),
45	(11, 'group_manage', 'Manage orders & basketgroups'),	46	(11, 'group_manage', 'Manage orders & basketgroups'),
46	(11, 'order_receive', 'Manage orders & basket'),	47	(11, 'order_receive', 'Manage orders & basket'),
47	(11, 'budget_add_del', 'Add and delete budgets (but cant modify budgets)'),	48	(11, 'budget_add_del', 'Add and delete budgets (but cant modify budgets)'),

Lines 42-47 INSERT INTO permissions (module_bit, code, description) VALUES Link Here

(-)a/installer/data/mysql/uk-UA/mandatory/permissions_and_user_flags.sql (+1 lines)
42	(11, 'budget_modify', 'Modify budget (can''t create lines, but can modify existing ones)'),	42	(11, 'budget_modify', 'Modify budget (can''t create lines, but can modify existing ones)'),
43	(11, 'planning_manage', 'Manage budget plannings'),	43	(11, 'planning_manage', 'Manage budget plannings'),
44	(11, 'order_manage', 'Manage orders & basket'),	44	(11, 'order_manage', 'Manage orders & basket'),
		45	(11, 'order_manage_all', 'Manage all orders & baskets'),
45	(11, 'group_manage', 'Manage orders & basketgroups'),	46	(11, 'group_manage', 'Manage orders & basketgroups'),
46	(11, 'order_receive', 'Manage orders & basket'),	47	(11, 'order_receive', 'Manage orders & basket'),
47	(11, 'budget_add_del', 'Add and delete budgets (but cant modify budgets)'),	48	(11, 'budget_add_del', 'Add and delete budgets (but cant modify budgets)'),




    SetVersion($DBversion);
}

$DBversion = "XXX";
if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) {
    $dbh->do("
        ALTER TABLE aqbasket ADD branch varchar(10) default NULL
    ");
    $dbh->do("
        ALTER TABLE aqbasket
        ADD CONSTRAINT aqbasket_ibfk_4 FOREIGN KEY (branch)
            REFERENCES branches (branchcode)
            ON UPDATE CASCADE ON DELETE SET NULL
    ");
    $dbh->do("
        DROP TABLE IF EXISTS aqbasketusers
    ");
    $dbh->do("
        CREATE TABLE aqbasketusers (
            basketno int(11) NOT NULL,
            borrowernumber int(11) NOT NULL,
            PRIMARY KEY (basketno,borrowernumber),
            CONSTRAINT aqbasketusers_ibfk_1 FOREIGN KEY (basketno) REFERENCES aqbasket (basketno) ON DELETE CASCADE ON UPDATE CASCADE,
            CONSTRAINT aqbasketusers_ibfk_2 FOREIGN KEY (borrowernumber) REFERENCES borrowers (borrowernumber) ON DELETE CASCADE ON UPDATE CASCADE
        ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
    ");
    $dbh->do("
        INSERT INTO permissions (module_bit, code, description)
        VALUES (11, 'order_manage_all', 'Manage all orders & baskets')
    ");

    print "Upgrade to $DBversion done (Add branch and users list to baskets. "
        . "New permission order_manage_all)\n";
    SetVersion($DBversion);
}


=head1 FUNCTIONS

=head2 TableExists($table)




[% INCLUDE 'doc-head-open.inc' %]
<title>Koha &rsaquo; Basket User Search</title>
[% INCLUDE 'doc-head-close.inc' %]

<style type="text/css">
    #custom-doc {
        width:44.46em;
        *width:43.39em;
        min-width:578px;
        margin:auto;
        text-align:left;
    }
</style>

<script type="text/javascript">
//<![CDATA[
    // modify parent window owner element
    function add_user(borrowernumber, borrowername) {
        var p = window.opener;
        if(p.add_basket_user(borrowernumber, borrowername) < 0) {
            alert(_("Borrower '" + borrowername + "' is already in the list."));
        }
    }
//]]>
</script>

</head>
<body>
<div id="custom-doc" class="yui-t7">
  <div id="bd">
    <div class="yui-g">

      <h3>Search for Basket User</h3>
      <form action="/cgi-bin/koha/acqui/aqbasketuser_search.pl" method="post">
        <fieldset>
          <input type="hidden" name="op" id="op" value="do_search" />
          <input type="text" name="q" id="q" value="[% q %]" class="focus" />
          <input type="submit" class="button" value="Search" />
        </fieldset>
        <div class="hint">Only staff with superlibrarian or acquisitions permissions (or order_manage permission if granular permissions are enabled) are returned in the search results</div>
      </form>

[% IF (q) %]
    <p>Searched for <span class="ex">[% q %]</span>, [% nresults %] patron(s) found.</p>
[% END %]
[% IF ( users_loop ) %]
    <table>
      <thead>
        <tr>
            <th>Cardnumber</th>
            <th>Name</th>
            <th>Branch</th>
            <th>Categorycode</th>
            <th>Select?</th>
        </tr>
      </thead>
      <tbody>
        [% FOREACH user IN users_loop %]
          [% IF ( user.toggle ) %]
            <tr>
          [% ELSE %]
            <tr class="highlight">
          [% END %]
                <td>[% user.cardnumber %]</td>
                <td>[% user.surname %], [% user.firstname %]</td>
                <td>[% user.branchcode %]</td>
                <td>[% user.categorycode %]</td>
                <td>
                    <a style="cursor:pointer" onclick="add_user('[% user.borrowernumber %]', '[% user.firstname %] [% user.surname %]');">Add</a>
                </td>
            </tr>
        [% END %]
    </table>
[% END %]

<div id="closewindow"><a href="#" class="close">Close</a></div>
</div>
</div>
[% INCLUDE 'intranet-bottom.inc' %]




            confirm_reopen();
        });
    });

    function basketUserSearchPopup(f) {
        window.open(
            "/cgi-bin/koha/acqui/aqbasketuser_search.pl",
            'BasketUserSearchPopup',
            'width=740,height=450,toolbar=no,'
         );
    }

    function add_basket_user(borrowernumber, borrowername) {
        var ids = $("#basketusers_ids").val();
        if(ids.length > 0) {
            ids = ids.split(':');
        } else {
            ids = new Array;
        }
        if (ids.indexOf(borrowernumber) < 0) {
            ids.push(borrowernumber);
            $("#basketusers_ids").val(ids.join(':'));
            var li = '<li id="user_'+borrowernumber+'">'+borrowername
                + ' [<a style="cursor:pointer" onclick="del_basket_user('+borrowernumber+');">'
                + _('Delete user') + '</a>]</li>';
            $("#basketusers_names").append(li);
            return 0;
        }
        return -1;
    }

    function del_basket_user(borrowernumber) {
      $("#user_"+borrowernumber).remove();
      var ids = $("#basketusers_ids").val().split(':');
      ids.splice(ids.indexOf(borrowernumber.toString()), 1);
      $("#basketusers_ids").val(ids.join(':'));
    }
//]]>
</script>

<style type="text/css">
.sortmsg {font-size: 80%;}
</style>


<div id="bd">
    <div id="yui-main">
    [% IF (cannot_manage_basket) %]
        <div class="yui-b">
            <p class="error">You are not authorised to manage this basket.</p>
        </div>
    [% ELSE %]
    <div class="yui-b">
        [% UNLESS ( confirm_close ) %]
        [% UNLESS ( selectbasketg ) %]

                [% END %]
                [% IF ( deliveryplace ) %]<li><span class="label">Delivery place:</span> [% deliveryplace %]</li>[% END %]
                [% IF ( billingplace ) %]<li><span class="label">Billing place:</span> [% billingplace %]</li>[% END %]
                [% IF ( authorisedbyname ) %]<li><span class="label">Created by:</span>  [% authorisedbyname %]</li>[% END %]
                <li>
                    <form action="" method="post">
                        <span class="label">Managed by:</span>
                        <div style="float:left">
                            <ul id="basketusers_names" style="padding-left:0">
                              [% FOREACH user IN basketusers %]
                                <li id="user_[% user.borrowernumber %]">
                                    [% user.firstname %] [% user.surname %]
                                    [<a onclick="del_basket_user([% user.borrowernumber %]);" style="cursor:pointer">Delete user</a>]
                                </li>
                              [% END %]
                            </ul>
                            <input type="hidden" id="basketno" name="basketno" value="[% basketno %]" />
                            <input type="hidden" id="basketusers_ids" name="basketusers_ids" value="[% basketusers_ids %]" />
                            <input type="hidden" id="op" name="op" value="mod_users" />
                            <input type="button" id="add_user" onclick="basketUserSearchPopup();" value="Add user" />
                            <input type="submit" value="Save changes" />
                        </div>
                    </form>
                </li>
                <li>
                    <form action="" method="post">
                        <span class="label">Branch:</span>
                        <select id="branch" name="branch">
                            <option value="">No branch</option>
                            [% FOREACH branch IN branches_loop %]
                                [% IF (branch.selected) %]
                                    <option selected="selected" value="[% branch.branchcode %]"> [% branch.branchname %]</option>
                                [% ELSE %]
                                    <option value="[% branch.branchcode %]"> [% branch.branchname %]</option>
                                [% END %]
                            [% END %]
                        </select>
                        <input type="hidden" id="basketno" name="basketno" value="[% basketno %]" />
                        <input type="hidden" id="op" name="op" value="mod_branch" />
                        <input type="submit" value="Save" />
                    </form>
                </li>
                [% IF ( creationdate ) %]<li><span class="label">Opened on:</span>  [% creationdate | $KohaDates %]</li>[% END %]
                [% IF ( closedate ) %]<li><span class="label">Closed on:</span> [% closedate | $KohaDates %]</li>[% END %]
                [% IF ( estimateddeliverydate ) %]<li><span class="label">Estimated delivery date:</span> [% estimateddeliverydate | $KohaDates  %]</li>[% END %]

        </div>
    [% END %]
</div>
[% END %][%# IF (cannot_manage_basket) %]
</div>
<div class="yui-b">
[% INCLUDE 'acquisitions-menu.inc' %]

Lines 22-28 Acquisitions: Link Here

(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref (-1 / +1 lines)
22	- Show baskets	22	- Show baskets
23	- pref: AcqViewBaskets	23	- pref: AcqViewBaskets
24	choices:	24	choices:
25	user: created by staff member.	25	user: created or managed by staff member.
26	branch: from staff member's library.	26	branch: from staff member's library.
27	all: in system, regardless of owner.	27	all: in system, regardless of owner.
28	-	28	-




#!/usr/bin/perl

use Modern::Perl;
use Test::MockModule;
use Test::More tests => 42;

use C4::Acquisition;

my $C4_Acquisition_module = new Test::MockModule('C4::Acquisition');
$C4_Acquisition_module->mock('GetBasketUsers', \&Mock_GetBasketUsers);
my $C4_Context_module = new Test::MockModule('C4::Context');
$C4_Context_module->mock('preference', \&Mock_preference);

my $AcqViewBaskets;
my %basketusers = (
    1 => [],
    2 => [1, 2],
    3 => [],
    4 => [1, 2],
);

# Borrowers
my $borrower1 = {
    borrowernumber => 1,
    branchcode => 'B1',
};

my $borrower2 = {
    borrowernumber => 2,
    branchcode => 'B2',
};

# Baskets
my $basket1 = {
    basketno => 1,
    authorisedby => 1
};

my $basket2 = {
    basketno => 2,
    authorisedby => 2,
};

my $basket3 = {
    basketno => 3,
    authorisedby => 3,
    branch => 'B1'
};

my $basket4 = {
    basketno => 4,
    authorisedby => 4,
    branch => 'B1'
};


my $flags = {
    acquisition => {
        order_manage => 1
    }
};

#################
# Start testing #
#################

# ----------------------
# AcqViewBaskets = 'all'
# ----------------------

$AcqViewBaskets = 'all';

# Simple cases where user can't manage basket
ok( not CanUserManageBasket($borrower1, $basket1, {}) );
ok( not CanUserManageBasket($borrower1, $basket1, {
    acquisition => 0
}) );
ok( not CanUserManageBasket($borrower1, $basket1, {
    acquisition => {
        order_manage => 0
    }
}) );

# Simple cases where user can manage basket
ok( CanUserManageBasket($borrower1, $basket1, {
    superlibrarian => 1
}) );
ok( CanUserManageBasket($borrower1, $basket1, {
    acquisition => 1
}) );
ok( CanUserManageBasket($borrower1, $basket1, {
    acquisition => {
        order_manage_all => 1
    }
}) );

ok( CanUserManageBasket($borrower1, $basket1, $flags) );
ok( CanUserManageBasket($borrower1, $basket2, $flags) );
ok( CanUserManageBasket($borrower1, $basket3, $flags) );
ok( CanUserManageBasket($borrower1, $basket4, $flags) );
ok( CanUserManageBasket($borrower2, $basket1, $flags) );
ok( CanUserManageBasket($borrower2, $basket2, $flags) );
ok( CanUserManageBasket($borrower2, $basket3, $flags) );
ok( CanUserManageBasket($borrower2, $basket4, $flags) );

# -------------------------
# AcqViewBaskets = 'branch'
# -------------------------

$AcqViewBaskets = 'branch';

# Simple cases where user can't manage basket
ok( not CanUserManageBasket($borrower1, $basket1, {}) );
ok( not CanUserManageBasket($borrower1, $basket1, {
    acquisition => 0
}) );
ok( not CanUserManageBasket($borrower1, $basket1, {
    acquisition => {
        order_manage => 0
    }
}) );

# Simple cases where user can manage basket
ok( CanUserManageBasket($borrower1, $basket1, {
    superlibrarian => 1
}) );
ok( CanUserManageBasket($borrower1, $basket1, {
    acquisition => 1
}) );
ok( CanUserManageBasket($borrower1, $basket1, {
    acquisition => {
        order_manage_all => 1
    }
}) );

ok( CanUserManageBasket($borrower1, $basket1, $flags) );
ok( CanUserManageBasket($borrower1, $basket2, $flags) );
ok( CanUserManageBasket($borrower1, $basket3, $flags) );
ok( CanUserManageBasket($borrower1, $basket4, $flags) );
ok( CanUserManageBasket($borrower2, $basket1, $flags) );
ok( CanUserManageBasket($borrower2, $basket2, $flags) );
# borrower2 is not on the same branch as basket3 and basket4
ok( not CanUserManageBasket($borrower2, $basket3, $flags) );
ok( not CanUserManageBasket($borrower2, $basket4, $flags) );

# -----------------------
# AcqViewBaskets = 'user'
# -----------------------

$AcqViewBaskets = 'user';

# Simple cases where user can't manage basket
ok( not CanUserManageBasket($borrower1, $basket1, {}) );
ok( not CanUserManageBasket($borrower1, $basket1, {
    acquisition => 0
}) );
ok( not CanUserManageBasket($borrower1, $basket1, {
    acquisition => {
        order_manage => 0
    }
}) );

# Simple cases where user can manage basket
ok( CanUserManageBasket($borrower1, $basket1, {
    superlibrarian => 1
}) );
ok( CanUserManageBasket($borrower1, $basket1, {
    acquisition => 1
}) );
ok( CanUserManageBasket($borrower1, $basket1, {
    acquisition => {
        order_manage_all => 1
    }
}) );

ok( CanUserManageBasket($borrower1, $basket1, $flags) );
ok( CanUserManageBasket($borrower1, $basket2, $flags) );
# basket3 is not managed or created by borrower1
ok( not CanUserManageBasket($borrower1, $basket3, $flags) );
ok( CanUserManageBasket($borrower1, $basket4, $flags) );
# basket 1 is not managed or created by borrower2
ok( not CanUserManageBasket($borrower2, $basket1, $flags) );
ok( CanUserManageBasket($borrower2, $basket2, $flags) );
# basket 3 is not managed or created by borrower2
ok( not CanUserManageBasket($borrower2, $basket3, $flags) );
ok( CanUserManageBasket($borrower2, $basket4, $flags) );


# Mocked subs

# C4::Acquisition::GetBasketUsers
sub Mock_GetBasketUsers {
    my ($basketno) = @_;

    return @{ $basketusers{$basketno} };
}

# C4::Context->preference
sub Mock_preference {
    my ($self, $variable) = @_;
    if (lc($variable) eq 'acqviewbaskets') {
        return $AcqViewBaskets;
    }
}

Return to bug 7295

Lines 2710-2715 CREATE TABLE `aqbasket` ( -- stores data about baskets in acquisitions Link Here

(-)a/installer/data/mysql/kohastructure.sql (+15 lines)
2710	`basketgroupid` int(11), -- links this basket to its group (aqbasketgroups.id)	2710	`basketgroupid` int(11), -- links this basket to its group (aqbasketgroups.id)
2711	`deliveryplace` varchar(10) default NULL, -- basket delivery place	2711	`deliveryplace` varchar(10) default NULL, -- basket delivery place
2712	`billingplace` varchar(10) default NULL, -- basket billing place	2712	`billingplace` varchar(10) default NULL, -- basket billing place
		2713	branch varchar(10) default NULL, -- basket branch
2713	PRIMARY KEY (`basketno`),	2714	PRIMARY KEY (`basketno`),
2714	KEY `booksellerid` (`booksellerid`),	2715	KEY `booksellerid` (`booksellerid`),
2715	KEY `basketgroupid` (`basketgroupid`),	2716	KEY `basketgroupid` (`basketgroupid`),
Lines 2717-2722 CREATE TABLE `aqbasket` ( -- stores data about baskets in acquisitions Link Here
2717	CONSTRAINT `aqbasket_ibfk_1` FOREIGN KEY (`booksellerid`) REFERENCES `aqbooksellers` (`id`) ON UPDATE CASCADE,	2718	CONSTRAINT `aqbasket_ibfk_1` FOREIGN KEY (`booksellerid`) REFERENCES `aqbooksellers` (`id`) ON UPDATE CASCADE,
2718	CONSTRAINT `aqbasket_ibfk_2` FOREIGN KEY (`contractnumber`) REFERENCES `aqcontract` (`contractnumber`),	2719	CONSTRAINT `aqbasket_ibfk_2` FOREIGN KEY (`contractnumber`) REFERENCES `aqcontract` (`contractnumber`),
2719	CONSTRAINT `aqbasket_ibfk_3` FOREIGN KEY (`basketgroupid`) REFERENCES `aqbasketgroups` (`id`) ON UPDATE CASCADE	2720	CONSTRAINT `aqbasket_ibfk_3` FOREIGN KEY (`basketgroupid`) REFERENCES `aqbasketgroups` (`id`) ON UPDATE CASCADE
		2721	CONSTRAINT aqbasket_ibfk_4 FOREIGN KEY (branch) REFERENCES branches (branchcode) ON UPDATE CASCADE ON DELETE SET NULL,
		2722	) ENGINE=InnoDB DEFAULT CHARSET=utf8;
		2723
		2724	--
		2725	-- Table structure for table aqbasketusers
		2726	--
		2727
		2728	DROP TABLE IF EXISTS aqbasketusers;
		2729	CREATE TABLE aqbasketusers (
		2730	basketno int(11) NOT NULL,
		2731	borrowernumber int(11) NOT NULL,
		2732	PRIMARY KEY (basketno,borrowernumber),
		2733	CONSTRAINT aqbasketusers_ibfk_1 FOREIGN KEY (basketno) REFERENCES aqbasket (basketno) ON UPDATE CASCADE ON DELETE CASCADE,
		2734	CONSTRAINT aqbasketusers_ibfk_2 FOREIGN KEY (borrowernumber) REFERENCES borrowers (borrowernumber) ON UPDATE CASCADE ON DELETE CASCADE
2720	) ENGINE=InnoDB DEFAULT CHARSET=utf8;	2735	) ENGINE=InnoDB DEFAULT CHARSET=utf8;
2721		2736
2722	--	2737	--

Lines 6949-6954 if ( CheckVersion($DBversion) ) { Link Here

(-)a/installer/data/mysql/updatedatabase.pl (+34 lines)
6949	SetVersion($DBversion);	6949	SetVersion($DBversion);
6950	}	6950	}
6951		6951
		6952	$DBversion = "XXX";
		6953	if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) {
		6954	$dbh->do("
		6955	ALTER TABLE aqbasket ADD branch varchar(10) default NULL
		6956	");
		6957	$dbh->do("
		6958	ALTER TABLE aqbasket
		6959	ADD CONSTRAINT aqbasket_ibfk_4 FOREIGN KEY (branch)
		6960	REFERENCES branches (branchcode)
		6961	ON UPDATE CASCADE ON DELETE SET NULL
		6962	");
		6963	$dbh->do("
		6964	DROP TABLE IF EXISTS aqbasketusers
		6965	");
		6966	$dbh->do("
		6967	CREATE TABLE aqbasketusers (
		6968	basketno int(11) NOT NULL,
		6969	borrowernumber int(11) NOT NULL,
		6970	PRIMARY KEY (basketno,borrowernumber),
		6971	CONSTRAINT aqbasketusers_ibfk_1 FOREIGN KEY (basketno) REFERENCES aqbasket (basketno) ON DELETE CASCADE ON UPDATE CASCADE,
		6972	CONSTRAINT aqbasketusers_ibfk_2 FOREIGN KEY (borrowernumber) REFERENCES borrowers (borrowernumber) ON DELETE CASCADE ON UPDATE CASCADE
		6973	) ENGINE=InnoDB DEFAULT CHARSET=utf8;
		6974	");
		6975	$dbh->do("
		6976	INSERT INTO permissions (module_bit, code, description)
		6977	VALUES (11, 'order_manage_all', 'Manage all orders & baskets')
		6978	");
		6979
		6980	print "Upgrade to $DBversion done (Add branch and users list to baskets. "
		6981	. "New permission order_manage_all)\n";
		6982	SetVersion($DBversion);
		6983	}
		6984
		6985
6952	=head1 FUNCTIONS	6986	=head1 FUNCTIONS
6953		6987
6954	=head2 TableExists($table)	6988	=head2 TableExists($table)

Lines 114-122 Link Here

(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt (-2 / +79 lines)
114	confirm_reopen();	114	confirm_reopen();
115	});	115	});
116	});	116	});
		117
		118	function basketUserSearchPopup(f) {
		119	window.open(
		120	"/cgi-bin/koha/acqui/aqbasketuser_search.pl",
		121	'BasketUserSearchPopup',
		122	'width=740,height=450,toolbar=no,'
		123	);
		124	}
		125
		126	function add_basket_user(borrowernumber, borrowername) {
		127	var ids = $("#basketusers_ids").val();
		128	if(ids.length > 0) {
		129	ids = ids.split(':');
		130	} else {
		131	ids = new Array;
		132	}
		133	if (ids.indexOf(borrowernumber) < 0) {
		134	ids.push(borrowernumber);
		135	$("#basketusers_ids").val(ids.join(':'));
		136	var li = '<li id="user_'+borrowernumber+'">'+borrowername
		137	+ ' [<a style="cursor:pointer" onclick="del_basket_user('+borrowernumber+');">'
		138	+ _('Delete user') + '</a>]</li>';
		139	$("#basketusers_names").append(li);
		140	return 0;
		141	}
		142	return -1;
		143	}
		144
		145	function del_basket_user(borrowernumber) {
		146	$("#user_"+borrowernumber).remove();
		147	var ids = $("#basketusers_ids").val().split(':');
		148	ids.splice(ids.indexOf(borrowernumber.toString()), 1);
		149	$("#basketusers_ids").val(ids.join(':'));
		150	}
117	//]]>	151	//]]>
118	</script>	152	</script>
119
120	<style type="text/css">	153	<style type="text/css">
121	.sortmsg {font-size: 80%;}	154	.sortmsg {font-size: 80%;}
122	</style>	155	</style>
Lines 132-137 Link Here
132		165
133	<div id="bd">	166	<div id="bd">
134	<div id="yui-main">	167	<div id="yui-main">
		168	[% IF (cannot_manage_basket) %]
		169	<div class="yui-b">
		170	<p class="error">You are not authorised to manage this basket.</p>
		171	</div>
		172	[% ELSE %]
135	<div class="yui-b">	173	<div class="yui-b">
136	[% UNLESS ( confirm_close ) %]	174	[% UNLESS ( confirm_close ) %]
137	[% UNLESS ( selectbasketg ) %]	175	[% UNLESS ( selectbasketg ) %]
Lines 194-200 Link Here
194	[% END %]	232	[% END %]
195	[% IF ( deliveryplace ) %]<li><span class="label">Delivery place:</span> [% deliveryplace %]</li>[% END %]	233	[% IF ( deliveryplace ) %]<li><span class="label">Delivery place:</span> [% deliveryplace %]</li>[% END %]
196	[% IF ( billingplace ) %]<li><span class="label">Billing place:</span> [% billingplace %]</li>[% END %]	234	[% IF ( billingplace ) %]<li><span class="label">Billing place:</span> [% billingplace %]</li>[% END %]
197	[% IF ( authorisedbyname ) %]<li><span class="label">Managed by:</span> [% authorisedbyname %]</li>[% END %]	235	[% IF ( authorisedbyname ) %]<li><span class="label">Created by:</span> [% authorisedbyname %]</li>[% END %]
		236	<li>
		237	<form action="" method="post">
		238	<span class="label">Managed by:</span>
		239	<div style="float:left">
		240	<ul id="basketusers_names" style="padding-left:0">
		241	[% FOREACH user IN basketusers %]
		242	<li id="user_[% user.borrowernumber %]">
		243	[% user.firstname %] [% user.surname %]
		244	[<a onclick="del_basket_user([% user.borrowernumber %]);" style="cursor:pointer">Delete user</a>]
		245	</li>
		246	[% END %]
		247	</ul>
		248	<input type="hidden" id="basketno" name="basketno" value="[% basketno %]" />
		249	<input type="hidden" id="basketusers_ids" name="basketusers_ids" value="[% basketusers_ids %]" />
		250	<input type="hidden" id="op" name="op" value="mod_users" />
		251	<input type="button" id="add_user" onclick="basketUserSearchPopup();" value="Add user" />
		252	<input type="submit" value="Save changes" />
		253	</div>
		254	</form>
		255	</li>
		256	<li>
		257	<form action="" method="post">
		258	<span class="label">Branch:</span>
		259	<select id="branch" name="branch">
		260	<option value="">No branch</option>
		261	[% FOREACH branch IN branches_loop %]
		262	[% IF (branch.selected) %]
		263	<option selected="selected" value="[% branch.branchcode %]"> [% branch.branchname %]</option>
		264	[% ELSE %]
		265	<option value="[% branch.branchcode %]"> [% branch.branchname %]</option>
		266	[% END %]
		267	[% END %]
		268	</select>
		269	<input type="hidden" id="basketno" name="basketno" value="[% basketno %]" />
		270	<input type="hidden" id="op" name="op" value="mod_branch" />
		271	<input type="submit" value="Save" />
		272	</form>
		273	</li>
198	[% IF ( creationdate ) %]<li><span class="label">Opened on:</span> [% creationdate \| $KohaDates %]</li>[% END %]	274	[% IF ( creationdate ) %]<li><span class="label">Opened on:</span> [% creationdate \| $KohaDates %]</li>[% END %]
199	[% IF ( closedate ) %]<li><span class="label">Closed on:</span> [% closedate \| $KohaDates %]</li>[% END %]	275	[% IF ( closedate ) %]<li><span class="label">Closed on:</span> [% closedate \| $KohaDates %]</li>[% END %]
200	[% IF ( estimateddeliverydate ) %]<li><span class="label">Estimated delivery date:</span> [% estimateddeliverydate \| $KohaDates %]</li>[% END %]	276	[% IF ( estimateddeliverydate ) %]<li><span class="label">Estimated delivery date:</span> [% estimateddeliverydate \| $KohaDates %]</li>[% END %]
Lines 469-474 Link Here
469	</div>	545	</div>
470	[% END %]	546	[% END %]
471	</div>	547	</div>
		548	[% END %][%# IF (cannot_manage_basket) %]
472	</div>	549	</div>
473	<div class="yui-b">	550	<div class="yui-b">
474	[% INCLUDE 'acquisitions-menu.inc' %]	551	[% INCLUDE 'acquisitions-menu.inc' %]

Line 0 Link Here

(-)a/acqui/aqbasketuser_search.pl (+77 lines)
		1	#!/usr/bin/perl
		2
		3	# script to find a basket user
		4
		5	# Copyright 2012 BibLibre SARL
		6	#
		7	# This file is part of Koha.
		8	#
		9	# Koha is free software; you can redistribute it and/or modify it under the
		10	# terms of the GNU General Public License as published by the Free Software
		11	# Foundation; either version 2 of the License, or (at your option) any later
		12	# version.
		13	#
		14	# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
		15	# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
		16	# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
		17	#
		18	# You should have received a copy of the GNU General Public License along
		19	# with Koha; if not, write to the Free Software Foundation, Inc.,
		20	# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
		21
		22	use Modern::Perl;
		23
		24	use CGI;
		25	use C4::Auth;
		26	use C4::Output;
		27	use C4::Members;
		28
		29	my $input = new CGI;
		30
		31	my $dbh = C4::Context->dbh;
		32
		33	my ( $template, $loggedinuser, $cookie, $staff_flags ) = get_template_and_user(
		34	{ template_name => "acqui/aqbasketuser_search.tmpl",
		35	query => $input,
		36	type => "intranet",
		37	authnotrequired => 0,
		38	flagsrequired => { acquisition => 'order_manage' },
		39	}
		40	);
		41
		42	my $q = $input->param('q') \|\| '';
		43	my $op = $input->param('op') \|\| '';
		44
		45	if( $op eq "do_search" ) {
		46	my $results = C4::Members::Search( $q, "surname");
		47
		48	my @users_loop;
		49	my $nresults = 0;
		50	foreach my $res (@$results) {
		51	my $perms = haspermission( $res->{userid} );
		52	my $subperms = get_user_subpermissions( $res->{userid} );
		53
		54	if( $perms->{superlibrarian} == 1
		55	\|\| $perms->{acquisition} == 1
		56	\|\| $subperms->{acquisition}->{'order_manage'} ) {
		57	my %row = (
		58	borrowernumber => $res->{borrowernumber},
		59	cardnumber => $res->{cardnumber},
		60	surname => $res->{surname},
		61	firstname => $res->{firstname},
		62	categorycode => $res->{categorycode},
		63	branchcode => $res->{branchcode},
		64	);
65	push( @users_loop, \%row );
66	$nresults ++;
67	}
68	}
69
70	$template->param(
71	q => $q,
72	nresults => $nresults,
73	users_loop => \@users_loop,
74	);
75	}
76
77	output_html_with_http_headers( $input, $cookie, $template->output );

Lines 28-33 use C4::Output; Link Here

(-)a/acqui/basket.pl (-2 / +51 lines)
28	use CGI;	28	use CGI;
29	use C4::Acquisition;	29	use C4::Acquisition;
30	use C4::Budgets;	30	use C4::Budgets;
		31	use C4::Branch;
31	use C4::Bookseller qw( GetBookSellerFromId);	32	use C4::Bookseller qw( GetBookSellerFromId);
32	use C4::Debug;	33	use C4::Debug;
33	use C4::Biblio;	34	use C4::Biblio;
Lines 80-92 my ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user( Link Here
80	);	81	);
81		82
82	my $basket = GetBasket($basketno);	83	my $basket = GetBasket($basketno);
		84	$booksellerid = $basket->{booksellerid} unless $booksellerid;
		85	my ($bookseller) = GetBookSellerFromId($booksellerid);
		86
		87	unless (CanUserManageBasket($loggedinuser, $basket, $userflags)) {
		88	$template->param(
		89	cannot_manage_basket => 1,
		90	basketno => $basketno,
		91	basketname => $basket->{basketname},
		92	booksellerid => $booksellerid,
		93	name => $bookseller->{name}
		94	);
		95	output_html_with_http_headers $query, $cookie, $template->output;
		96	exit;
		97	}
83		98
84	# FIXME : what about the "discount" percentage?	99	# FIXME : what about the "discount" percentage?
85	# FIXME : the query->param('booksellerid') below is probably useless. The bookseller is always known from the basket	100	# FIXME : the query->param('booksellerid') below is probably useless. The bookseller is always known from the basket
86	# if no booksellerid in parameter, get it from basket	101	# if no booksellerid in parameter, get it from basket
87	# warn "=>".$basket->{booksellerid};	102	# warn "=>".$basket->{booksellerid};
88	$booksellerid = $basket->{booksellerid} unless $booksellerid;
89	my ($bookseller) = GetBookSellerFromId($booksellerid);
90	my $op = $query->param('op');	103	my $op = $query->param('op');
91	if (!defined $op) {	104	if (!defined $op) {
92	$op = q{};	105	$op = q{};
Lines 190-195 if ( $op eq 'delete_confirm' ) { Link Here
190	$basket->{closedate} = undef;	203	$basket->{closedate} = undef;
191	ModBasket($basket);	204	ModBasket($basket);
192	print $query->redirect('/cgi-bin/koha/acqui/basket.pl?basketno='.$basket->{'basketno'})	205	print $query->redirect('/cgi-bin/koha/acqui/basket.pl?basketno='.$basket->{'basketno'})
		206	} elsif ( $op eq 'mod_users' ) {
		207	my $basketusers_ids = $query->param('basketusers_ids');
		208	my @basketusers = split( /:/, $basketusers_ids );
		209	ModBasketUsers($basketno, @basketusers);
		210	print $query->redirect("/cgi-bin/koha/acqui/basket.pl?basketno=$basketno");
		211	exit;
		212	} elsif ( $op eq 'mod_branch' ) {
		213	my $branch = $query->param('branch');
		214	$branch = undef if(defined $branch and $branch eq '');
		215	ModBasket({
		216	basketno => $basket->{basketno},
		217	branch => $branch
		218	});
		219	print $query->redirect("/cgi-bin/koha/acqui/basket.pl?basketno=$basketno");
		220	exit;
193	} else {	221	} else {
194	# get librarian branch...	222	# get librarian branch...
195	if ( C4::Context->preference("IndependentBranches") ) {	223	if ( C4::Context->preference("IndependentBranches") ) {
Lines 205-210 if ( $op eq 'delete_confirm' ) { Link Here
205	}	233	}
206	}	234	}
207	}	235	}
		236	# get branches
		237	my $branches = C4::Branch::GetBranches;
		238	my @branches_loop;
		239	foreach my $branch (sort keys %$branches) {
		240	push @branches_loop, {
		241	branchcode => $branch,
		242	branchname => $branches->{$branch}->{branchname},
		243	selected => (defined $basket->{branch} and $branch eq $basket->{branch}) ? 1 : 0
		244	};
		245	}
		246
208	#if the basket is closed,and the user has the permission to edit basketgroups, display a list of basketgroups	247	#if the basket is closed,and the user has the permission to edit basketgroups, display a list of basketgroups
209	my ($basketgroup, $basketgroups);	248	my ($basketgroup, $basketgroups);
210	my $member = GetMember(borrowernumber => $loggedinuser);	249	my $member = GetMember(borrowernumber => $loggedinuser);
Lines 241-246 if ( $op eq 'delete_confirm' ) { Link Here
241	"loggedinuser: $loggedinuser; creationdate: %s; authorisedby: %s",	280	"loggedinuser: $loggedinuser; creationdate: %s; authorisedby: %s",
242	$basket->{creationdate}, $basket->{authorisedby};	281	$basket->{creationdate}, $basket->{authorisedby};
243		282
		283	my @basketusers_ids = GetBasketUsers($basketno);
		284	my @basketusers;
		285	foreach my $basketuser_id (@basketusers_ids) {
		286	my $basketuser = GetMember(borrowernumber => $basketuser_id);
		287	push @basketusers, $basketuser if $basketuser;
		288	}
		289
244	#to get active currency	290	#to get active currency
245	my $cur = GetCurrency();	291	my $cur = GetCurrency();
246		292
Lines 320-328 if ( $op eq 'delete_confirm' ) { Link Here
320	basketbooksellernote => $basket->{booksellernote},	366	basketbooksellernote => $basket->{booksellernote},
321	basketcontractno => $basket->{contractnumber},	367	basketcontractno => $basket->{contractnumber},
322	basketcontractname => $contract->{contractname},	368	basketcontractname => $contract->{contractname},
		369	branches_loop => \@branches_loop,
323	creationdate => $basket->{creationdate},	370	creationdate => $basket->{creationdate},
324	authorisedby => $basket->{authorisedby},	371	authorisedby => $basket->{authorisedby},
325	authorisedbyname => $basket->{authorisedbyname},	372	authorisedbyname => $basket->{authorisedbyname},
		373	basketusers_ids => join(':', @basketusers_ids),
		374	basketusers => \@basketusers,
326	closedate => $basket->{closedate},	375	closedate => $basket->{closedate},
327	estimateddeliverydate=> $estimateddeliverydate,	376	estimateddeliverydate=> $estimateddeliverydate,
328	deliveryplace => C4::Branch::GetBranchName( $basket->{deliveryplace} ),	377	deliveryplace => C4::Branch::GetBranchName( $basket->{deliveryplace} ),

Lines 56-68 use C4::Biblio; Link Here

(-)a/acqui/booksellers.pl (-22 / +4 lines)
56	use C4::Output;	56	use C4::Output;
57	use CGI;	57	use CGI;
58		58
59	use C4::Acquisition qw/ GetBasketsInfosByBookseller /;	59	use C4::Acquisition qw/ GetBasketsInfosByBookseller CanUserManageBasket /;
60	use C4::Bookseller qw/ GetBookSellerFromId GetBookSeller /;	60	use C4::Bookseller qw/ GetBookSellerFromId GetBookSeller /;
61	use C4::Members qw/GetMember/;	61	use C4::Members qw/GetMember/;
62	use C4::Context;	62	use C4::Context;
63		63
64	my $query = CGI->new;	64	my $query = CGI->new;
65	my ( $template, $loggedinuser, $cookie ) = get_template_and_user(	65	my ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user(
66	{ template_name => 'acqui/booksellers.tmpl',	66	{ template_name => 'acqui/booksellers.tmpl',
67	query => $query,	67	query => $query,
68	type => 'intranet',	68	type => 'intranet',
Lines 98-108 if ($loggedinuser) { Link Here
98	$uid = GetMember( borrowernumber => $loggedinuser )->{userid};	98	$uid = GetMember( borrowernumber => $loggedinuser )->{userid};
99	}	99	}
100		100
101	my $userenv = C4::Context::userenv;
102	my $viewbaskets = C4::Context->preference('AcqViewBaskets');
103
104	my $userbranch = $userenv->{branch};
105
106	#build result page	101	#build result page
107	my $loop_suppliers = [];	102	my $loop_suppliers = [];
108		103
Lines 112-132 for my $vendor (@suppliers) { Link Here
112	my $loop_basket = [];	107	my $loop_basket = [];
113		108
114	for my $basket ( @{$baskets} ) {	109	for my $basket ( @{$baskets} ) {
115	my $authorisedby = $basket->{authorisedby};	110	if (CanUserManageBasket($loggedinuser, $basket, $userflags)) {
116	my $basketbranch = ''; # set a blank branch to start with	111	my $member = GetMember( borrowernumber => $basket->{authorisedby} );
117	my $member = GetMember( borrowernumber => $authorisedby );
118	if ( $member ) {
119	$basketbranch = $member->{branchcode};
120	}
121
122	if ($userenv->{'flags'} & 1 \|\| #user is superlibrarian
123	(haspermission( $uid, { acquisition => q{*} } ) && #user has acq permissions and
124	($viewbaskets eq 'all' \|\| #user is allowed to see all baskets
125	($viewbaskets eq 'branch' && $authorisedby && $userbranch eq $basketbranch) \|\| #basket belongs to user's branch
126	($basket->{authorisedby} && $viewbaskets eq 'user' && $authorisedby == $loggedinuser) #user created this basket
127	)
128	)
129	) {
130	foreach (qw(total_items total_biblios expected_items)) {	112	foreach (qw(total_items total_biblios expected_items)) {
131	$basket->{$_} \|\|= 0;	113	$basket->{$_} \|\|= 0;
132	}	114	}

Line 0 Link Here

(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/aqbasketuser_search.tt (+79 lines)
		1	[% INCLUDE 'doc-head-open.inc' %]
		2	<title>Koha &rsaquo; Basket User Search</title>
		3	[% INCLUDE 'doc-head-close.inc' %]
		4
		5	<style type="text/css">
		6	#custom-doc {
		7	width:44.46em;
		8	*width:43.39em;
		9	min-width:578px;
		10	margin:auto;
		11	text-align:left;
		12	}
		13	</style>
		14
		15	<script type="text/javascript">
		16	//<![CDATA[
		17	// modify parent window owner element
		18	function add_user(borrowernumber, borrowername) {
		19	var p = window.opener;
		20	if(p.add_basket_user(borrowernumber, borrowername) < 0) {
		21	alert(_("Borrower '" + borrowername + "' is already in the list."));
		22	}
		23	}
		24	//]]>
		25	</script>
		26
		27	</head>
		28	<body>
		29	<div id="custom-doc" class="yui-t7">
		30	<div id="bd">
		31	<div class="yui-g">
		32
		33	<h3>Search for Basket User</h3>
		34	<form action="/cgi-bin/koha/acqui/aqbasketuser_search.pl" method="post">
		35	<fieldset>
		36	<input type="hidden" name="op" id="op" value="do_search" />
		37	<input type="text" name="q" id="q" value="[% q %]" class="focus" />
		38	<input type="submit" class="button" value="Search" />
		39	</fieldset>
		40	<div class="hint">Only staff with superlibrarian or acquisitions permissions (or order_manage permission if granular permissions are enabled) are returned in the search results</div>
		41	</form>
		42
		43	[% IF (q) %]
		44	<p>Searched for <span class="ex">[% q %]</span>, [% nresults %] patron(s) found.</p>
		45	[% END %]
		46	[% IF ( users_loop ) %]
		47	<table>
		48	<thead>
		49	<tr>
		50	<th>Cardnumber</th>
		51	<th>Name</th>
		52	<th>Branch</th>
		53	<th>Categorycode</th>
		54	<th>Select?</th>
		55	</tr>
		56	</thead>
		57	<tbody>
		58	[% FOREACH user IN users_loop %]
		59	[% IF ( user.toggle ) %]
		60	<tr>
		61	[% ELSE %]
		62	<tr class="highlight">
		63	[% END %]
		64	<td>[% user.cardnumber %]</td>
65	<td>[% user.surname %], [% user.firstname %]</td>
66	<td>[% user.branchcode %]</td>
67	<td>[% user.categorycode %]</td>
68	<td>
69	<a style="cursor:pointer" onclick="add_user('[% user.borrowernumber %]', '[% user.firstname %] [% user.surname %]');">Add</a>
70	</td>
71	</tr>
72	[% END %]
73	</table>
74	[% END %]
75
76	<div id="closewindow"><a href="#" class="close">Close</a></div>
77	</div>
78	</div>
79	[% INCLUDE 'intranet-bottom.inc' %]

Line 0 Link Here

(-)a/t/Acquisition/CanUserManageBasket.t (-1 / +204 lines)
0	-	1	#!/usr/bin/perl
		2
		3	use Modern::Perl;
		4	use Test::MockModule;
		5	use Test::More tests => 42;
		6
		7	use C4::Acquisition;
		8
		9	my $C4_Acquisition_module = new Test::MockModule('C4::Acquisition');
		10	$C4_Acquisition_module->mock('GetBasketUsers', \&Mock_GetBasketUsers);
		11	my $C4_Context_module = new Test::MockModule('C4::Context');
		12	$C4_Context_module->mock('preference', \&Mock_preference);
		13
		14	my $AcqViewBaskets;
		15	my %basketusers = (
		16	1 => [],
		17	2 => [1, 2],
		18	3 => [],
		19	4 => [1, 2],
		20	);
		21
		22	# Borrowers
		23	my $borrower1 = {
		24	borrowernumber => 1,
		25	branchcode => 'B1',
		26	};
		27
		28	my $borrower2 = {
		29	borrowernumber => 2,
		30	branchcode => 'B2',
		31	};
		32
		33	# Baskets
		34	my $basket1 = {
		35	basketno => 1,
		36	authorisedby => 1
		37	};
		38
		39	my $basket2 = {
		40	basketno => 2,
		41	authorisedby => 2,
		42	};
		43
		44	my $basket3 = {
		45	basketno => 3,
		46	authorisedby => 3,
		47	branch => 'B1'
		48	};
		49
		50	my $basket4 = {
		51	basketno => 4,
		52	authorisedby => 4,
		53	branch => 'B1'
		54	};
		55
		56
		57	my $flags = {
		58	acquisition => {
		59	order_manage => 1
		60	}
		61	};
		62
		63	#################
		64	# Start testing #
		65	#################
66
67	# ----------------------
68	# AcqViewBaskets = 'all'
69	# ----------------------
70
71	$AcqViewBaskets = 'all';
72
73	# Simple cases where user can't manage basket
74	ok( not CanUserManageBasket($borrower1, $basket1, {}) );
75	ok( not CanUserManageBasket($borrower1, $basket1, {
76	acquisition => 0
77	}) );
78	ok( not CanUserManageBasket($borrower1, $basket1, {
79	acquisition => {
80	order_manage => 0
81	}
82	}) );
83
84	# Simple cases where user can manage basket
85	ok( CanUserManageBasket($borrower1, $basket1, {
86	superlibrarian => 1
87	}) );
88	ok( CanUserManageBasket($borrower1, $basket1, {
89	acquisition => 1
90	}) );
91	ok( CanUserManageBasket($borrower1, $basket1, {
92	acquisition => {
93	order_manage_all => 1
94	}
95	}) );
96
97	ok( CanUserManageBasket($borrower1, $basket1, $flags) );
98	ok( CanUserManageBasket($borrower1, $basket2, $flags) );
99	ok( CanUserManageBasket($borrower1, $basket3, $flags) );
100	ok( CanUserManageBasket($borrower1, $basket4, $flags) );
101	ok( CanUserManageBasket($borrower2, $basket1, $flags) );
102	ok( CanUserManageBasket($borrower2, $basket2, $flags) );
103	ok( CanUserManageBasket($borrower2, $basket3, $flags) );
104	ok( CanUserManageBasket($borrower2, $basket4, $flags) );
105
106	# -------------------------
107	# AcqViewBaskets = 'branch'
108	# -------------------------
109
110	$AcqViewBaskets = 'branch';
111
112	# Simple cases where user can't manage basket
113	ok( not CanUserManageBasket($borrower1, $basket1, {}) );
114	ok( not CanUserManageBasket($borrower1, $basket1, {
115	acquisition => 0
116	}) );
117	ok( not CanUserManageBasket($borrower1, $basket1, {
118	acquisition => {
119	order_manage => 0
120	}
121	}) );
122
123	# Simple cases where user can manage basket
124	ok( CanUserManageBasket($borrower1, $basket1, {
125	superlibrarian => 1
126	}) );
127	ok( CanUserManageBasket($borrower1, $basket1, {
128	acquisition => 1
129	}) );
130	ok( CanUserManageBasket($borrower1, $basket1, {
131	acquisition => {
132	order_manage_all => 1
133	}
134	}) );
135
136	ok( CanUserManageBasket($borrower1, $basket1, $flags) );
137	ok( CanUserManageBasket($borrower1, $basket2, $flags) );
138	ok( CanUserManageBasket($borrower1, $basket3, $flags) );
139	ok( CanUserManageBasket($borrower1, $basket4, $flags) );
140	ok( CanUserManageBasket($borrower2, $basket1, $flags) );
141	ok( CanUserManageBasket($borrower2, $basket2, $flags) );
142	# borrower2 is not on the same branch as basket3 and basket4
143	ok( not CanUserManageBasket($borrower2, $basket3, $flags) );
144	ok( not CanUserManageBasket($borrower2, $basket4, $flags) );
145
146	# -----------------------
147	# AcqViewBaskets = 'user'
148	# -----------------------
149
150	$AcqViewBaskets = 'user';
151
152	# Simple cases where user can't manage basket
153	ok( not CanUserManageBasket($borrower1, $basket1, {}) );
154	ok( not CanUserManageBasket($borrower1, $basket1, {
155	acquisition => 0
156	}) );
157	ok( not CanUserManageBasket($borrower1, $basket1, {
158	acquisition => {
159	order_manage => 0
160	}
161	}) );
162
163	# Simple cases where user can manage basket
164	ok( CanUserManageBasket($borrower1, $basket1, {
165	superlibrarian => 1
166	}) );
167	ok( CanUserManageBasket($borrower1, $basket1, {
168	acquisition => 1
169	}) );
170	ok( CanUserManageBasket($borrower1, $basket1, {
171	acquisition => {
172	order_manage_all => 1
173	}
174	}) );
175
176	ok( CanUserManageBasket($borrower1, $basket1, $flags) );
177	ok( CanUserManageBasket($borrower1, $basket2, $flags) );
178	# basket3 is not managed or created by borrower1
179	ok( not CanUserManageBasket($borrower1, $basket3, $flags) );
180	ok( CanUserManageBasket($borrower1, $basket4, $flags) );
181	# basket 1 is not managed or created by borrower2
182	ok( not CanUserManageBasket($borrower2, $basket1, $flags) );
183	ok( CanUserManageBasket($borrower2, $basket2, $flags) );
184	# basket 3 is not managed or created by borrower2
185	ok( not CanUserManageBasket($borrower2, $basket3, $flags) );
186	ok( CanUserManageBasket($borrower2, $basket4, $flags) );
187
188
189	# Mocked subs
190
191	# C4::Acquisition::GetBasketUsers
192	sub Mock_GetBasketUsers {
193	my ($basketno) = @_;
194
195	return @{ $basketusers{$basketno} };
196	}
197
198	# C4::Context->preference
199	sub Mock_preference {
200	my ($self, $variable) = @_;
201	if (lc($variable) eq 'acqviewbaskets') {
202	return $AcqViewBaskets;
203	}
204	}