View | Details | Raw Unified | Return to bug 39632
Collapse All | Expand All

(-)a/Koha/Plugins/Base.pm (-2 / +2 lines)
Lines 68-74 sub new { Link Here
68
                warn "Plugin $class failed during installation!";
68
                warn "Plugin $class failed during installation!";
69
            }
69
            }
70
        } catch {
70
        } catch {
71
            Koha::Exceptions::Plugin::InstallDied->throw( plugin_class => $class );
71
            Koha::Exceptions::Plugin::InstallDied->throw( plugin_class => $class, install_error => "$_" );
72
        };
72
        };
73
    } elsif ( $self->can('upgrade') ) {
73
    } elsif ( $self->can('upgrade') ) {
74
        if ( _version_compare( $plugin_version, $database_version ) == 1 ) {
74
        if ( _version_compare( $plugin_version, $database_version ) == 1 ) {
Lines 79-85 sub new { Link Here
79
                    warn "Plugin $class failed during upgrade!";
79
                    warn "Plugin $class failed during upgrade!";
80
                }
80
                }
81
            } catch {
81
            } catch {
82
                Koha::Exceptions::Plugin::UpgradeDied->throw( plugin_class => $class );
82
                Koha::Exceptions::Plugin::UpgradeDied->throw( plugin_class => $class, upgrade_error => "$_" );
83
            };
83
            };
84
        }
84
        }
85
    } elsif ( $plugin_version ne $database_version ) {
85
    } elsif ( $plugin_version ne $database_version ) {
(-)a/t/db_dependent/Koha/Plugins/Broken.t (-4 / +4 lines)
Lines 37-48 $schema->storage->txn_begin; Link Here
37
37
38
t::lib::Mocks::mock_config( 'enable_plugins', 1 );
38
t::lib::Mocks::mock_config( 'enable_plugins', 1 );
39
39
40
my $plugins = Koha::Plugins->new;
40
my $plugins      = Koha::Plugins->new;
41
my $error_string = 'Why Liz? WHY?';
41
42
42
warnings_are { $plugins->InstallPlugins; }
43
warnings_are { $plugins->InstallPlugins; }
43
[
44
[
44
    "Calling 'install' died for plugin Koha::Plugin::BrokenInstall",
45
    "Calling 'install' died for plugin Koha::Plugin::BrokenInstall: $error_string",
45
    "Calling 'upgrade' died for plugin Koha::Plugin::BrokenUpgrade"
46
    "Calling 'upgrade' died for plugin Koha::Plugin::BrokenUpgrade: $error_string"
46
];
47
];
47
48
48
$schema->storage->txn_begin;
49
$schema->storage->txn_begin;
49
- 

Return to bug 39632