View | Details | Raw Unified | Return to bug 21572
Collapse All | Expand All

(-)a/installer/data/mysql/atomicupdate/bug_21572.pl (+41 lines)
Line 0 Link Here
1
use Modern::Perl;
2
use Koha::Installer::Output qw(say_warning say_success say_info);
3
4
return {
5
    bug_number  => "21572",
6
    description => "Update AllowItemsOnHoldCheckoutSIP and AllowItemsOnHoldCheckoutSCO to allow multiple selections",
7
    up          => sub {
8
        my ($args) = @_;
9
        my ( $dbh, $out ) = @$args{qw(dbh out)};
10
11
        # Current behavior for AllowItemsOnHoldCheckoutSIP, if set to Allow, is to allow checkout of items with pending holds only
12
        # Set the new value accordingly to preserve existing behavior on upgrade
13
        $dbh->do(
14
            q{
15
        UPDATE systempreferences
16
        SET options='pending|processing|transferred|waiting',
17
            value=CASE value WHEN '1' THEN 'pending' WHEN '0' THEN '' ELSE value END,
18
            type='multiple',
19
            explanation='When checking out an item via SIP, if a hold for another patron is found, allow the checkout for the following hold statuses'
20
        WHERE variable='AllowItemsOnHoldCheckoutSIP'
21
            }
22
        );
23
        say_success( $out, "Updated system preference AllowItemsOnHoldCheckoutSIP" );
24
25
        # Current behavior for AllowItemsOnHoldCheckoutSCO, if set to Allow, is to allow checkout of items with both pending and waiting holds
26
        # Otherwise don't allow checkout of either
27
        # Set the new value accordingly to preserve existing behavior on upgrade
28
        $dbh->do(
29
            q{
30
        UPDATE systempreferences
31
        SET options='pending|processing|transferred|waiting',
32
            value=CASE value WHEN '1' THEN 'pending,processing,transferred,waiting' WHEN '0' THEN '' ELSE value END,
33
            type='multiple',
34
            explanation='When checking out an item in SCO module, if a hold for another patron is found, allow the checkout for the following hold statuses'
35
        WHERE variable='AllowItemsOnHoldCheckoutSCO'
36
            }
37
        );
38
        say_success( $out, "Updated system preference AllowItemsOnHoldCheckoutSCO" );
39
40
    },
41
};
(-)a/installer/data/mysql/mandatory/sysprefs.sql (-3 / +3 lines)
Lines 34-41 INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` Link Here
34
('AllowHoldPolicyOverride','0',NULL,'Allow staff to override hold policies when placing holds','YesNo'),
34
('AllowHoldPolicyOverride','0',NULL,'Allow staff to override hold policies when placing holds','YesNo'),
35
('AllowHoldsOnDamagedItems','1','','Allow hold requests to be placed on damaged items','YesNo'),
35
('AllowHoldsOnDamagedItems','1','','Allow hold requests to be placed on damaged items','YesNo'),
36
('AllowHoldsOnPatronsPossessions','1',NULL,'Allow holds on records that patron have items of it','YesNo'),
36
('AllowHoldsOnPatronsPossessions','1',NULL,'Allow holds on records that patron have items of it','YesNo'),
37
('AllowItemsOnHoldCheckoutSCO','0','','Do not generate RESERVE_WAITING and RESERVED warning in the SCO module when checking out items reserved to someone else. This allows self checkouts for those items.','YesNo'),
37
('AllowItemsOnHoldCheckoutSCO','','pending|processing|transferred|waiting','When checking out an item in SCO module, if a hold for another patron is found, allow the checkout for the following hold statuses','multiple'),
38
('AllowItemsOnHoldCheckoutSIP','0','','Do not generate RESERVED warning when checking out items reserved to someone else via SIP. This allows self checkouts for those items.','YesNo'),
38
('AllowItemsOnHoldCheckoutSIP','','pending|processing|transferred|waiting','When checking out an item via SIP, if a hold for another patron is found, allow the checkout for the following hold statuses','multiple'),
39
('AllowItemsOnLoanCheckoutSIP','0','','Do not generate ISSUED_TO_ANOTHER warning when checking out items already checked out to someone else via SIP. This allows self checkouts for those items.','YesNo'),
39
('AllowItemsOnLoanCheckoutSIP','0','','Do not generate ISSUED_TO_ANOTHER warning when checking out items already checked out to someone else via SIP. This allows self checkouts for those items.','YesNo'),
40
('AllowMultipleCovers','0','1','Allow multiple cover images to be attached to each bibliographic record.','YesNo'),
40
('AllowMultipleCovers','0','1','Allow multiple cover images to be attached to each bibliographic record.','YesNo'),
41
('AllowMultipleIssuesOnABiblio',1,'Allow/Don\'t allow patrons to check out multiple items from one biblio','','YesNo'),
41
('AllowMultipleIssuesOnABiblio',1,'Allow/Don\'t allow patrons to check out multiple items from one biblio','','YesNo'),
Lines 889-892 INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` Link Here
889
('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'),
889
('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'),
890
('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'),
890
('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'),
891
('z3950Status','','','This syspref allows to define custom YAML based rules for marking items unavailable in z3950 results.','Textarea')
891
('z3950Status','','','This syspref allows to define custom YAML based rules for marking items unavailable in z3950 results.','Textarea')
892
;
892
;
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref (-12 / +15 lines)
Lines 230-242 Circulation: Link Here
230
                  0: "Don't allow"
230
                  0: "Don't allow"
231
            - staff to renew items that are on hold by manually specifying a due date.
231
            - staff to renew items that are on hold by manually specifying a due date.
232
        -
232
        -
233
            - "When checking out an item via SIP, if a hold for another patron is found, allow the checkout for the following hold statuses:"
233
            - pref: AllowItemsOnHoldCheckoutSIP
234
            - pref: AllowItemsOnHoldCheckoutSIP
234
              choices:
235
              multiple:
235
                  1: Allow
236
                  pending: "Pending"
236
                  0: "Don't allow"
237
                  processing: "Processing"
237
            - checkouts of items reserved to someone else via SIP checkout messages.
238
                  transferred: "In transit"
238
            - If allowed do not generate RESERVED warning.
239
                  waiting: "Waiting"
239
            - This allows self-checkouts for those items. If using the holds queue items with pending holds will be marked as "unavailable" if this set to "Don't allow".
240
            - .
240
        -
241
        -
241
            - pref: AllowItemsOnLoanCheckoutSIP
242
            - pref: AllowItemsOnLoanCheckoutSIP
242
              choices:
243
              choices:
Lines 246-256 Circulation: Link Here
246
            - If allowed do not generate ISSUED_TO_ANOTHER warning.
247
            - If allowed do not generate ISSUED_TO_ANOTHER warning.
247
            - This allows self-checkouts for those items.
248
            - This allows self-checkouts for those items.
248
        -
249
        -
250
            - "When checking out an item in the SCO module, if a hold for another patron is found, allow the checkout for the following hold statuses:"
249
            - pref: AllowItemsOnHoldCheckoutSCO
251
            - pref: AllowItemsOnHoldCheckoutSCO
250
              choices:
252
              multiple:
251
                  1: Allow
253
                  pending: "Pending"
252
                  0: "Don't allow"
254
                  processing: "Processing"
253
            - checkouts of items reserved to someone else in the SCO module. If allowed do not generate RESERVE_WAITING and RESERVED warning. This allows self-checkouts for those items.
255
                  transferred: "In transit"
256
                  waiting: "Waiting"
257
            - .
254
        -
258
        -
255
            - pref: AllFinesNeedOverride
259
            - pref: AllFinesNeedOverride
256
              choices:
260
              choices:
Lines 1534-1537 Circulation: Link Here
1534
              choices:
1538
              choices:
1535
                  1: Enable
1539
                  1: Enable
1536
                  0: Disable
1540
                  0: Disable
1537
            - "the curbside pickup module."
1541
            - "the curbside pickup module."
1538
- 

Return to bug 21572