|
Lines 19-29
Link Here
|
| 19 |
|
19 |
|
| 20 |
use Modern::Perl; |
20 |
use Modern::Perl; |
| 21 |
use Test::NoWarnings; |
21 |
use Test::NoWarnings; |
| 22 |
use Test::More tests => 4; |
22 |
use Test::More tests => 5; |
|
|
23 |
use Test::MockModule; |
| 24 |
use MARC::Record; |
| 25 |
use MARC::Field; |
| 26 |
|
| 23 |
use Koha::BiblioFramework; |
27 |
use Koha::BiblioFramework; |
| 24 |
use Koha::BiblioFrameworks; |
28 |
use Koha::BiblioFrameworks; |
|
|
29 |
use Koha::Database; |
| 30 |
use t::lib::TestBuilder; |
| 31 |
|
| 32 |
my $schema = Koha::Database->new->schema; |
| 33 |
my $builder = t::lib::TestBuilder->new; |
| 25 |
|
34 |
|
| 26 |
my $schema = Koha::Database->new->schema; |
|
|
| 27 |
$schema->storage->txn_begin; |
35 |
$schema->storage->txn_begin; |
| 28 |
|
36 |
|
| 29 |
my $nb_of_frameworks = Koha::BiblioFrameworks->search->count; |
37 |
my $nb_of_frameworks = Koha::BiblioFrameworks->search->count; |
|
Lines 50-53
is(
Link Here
|
| 50 |
|
58 |
|
| 51 |
$retrieved_framework_1->delete; |
59 |
$retrieved_framework_1->delete; |
| 52 |
is( Koha::BiblioFrameworks->search->count, $nb_of_frameworks + 1, 'Delete should have deleted the biblio framework' ); |
60 |
is( Koha::BiblioFrameworks->search->count, $nb_of_frameworks + 1, 'Delete should have deleted the biblio framework' ); |
|
|
61 |
|
| 62 |
subtest 'fill_with_default_values' => sub { |
| 63 |
plan tests => 14; |
| 64 |
|
| 65 |
# Create a test framework |
| 66 |
my $framework = $builder->build_object( { class => 'Koha::BiblioFrameworks' } ); |
| 67 |
my $frameworkcode = $framework->frameworkcode; |
| 68 |
|
| 69 |
my $default_008 = '######s################'; |
| 70 |
my $default_author = 'Default Author'; |
| 71 |
|
| 72 |
my $biblio_module = Test::MockModule->new('C4::Biblio'); |
| 73 |
$biblio_module->mock( |
| 74 |
'GetMarcStructure', |
| 75 |
sub { |
| 76 |
return { |
| 77 |
# default for a control field |
| 78 |
'008' => { |
| 79 |
x => { defaultvalue => $default_008 }, |
| 80 |
}, |
| 81 |
|
| 82 |
# default value for an existing field |
| 83 |
'245' => { |
| 84 |
c => { defaultvalue => $default_author, mandatory => 1 }, |
| 85 |
mandatory => 0, |
| 86 |
repeatable => 0, |
| 87 |
tab => 0, |
| 88 |
lib => 'a lib', |
| 89 |
}, |
| 90 |
|
| 91 |
# default for a nonexisting field |
| 92 |
'099' => { |
| 93 |
x => { defaultvalue => 'default_099' }, |
| 94 |
}, |
| 95 |
'942' => { |
| 96 |
c => { defaultvalue => 'BK', mandatory => 1 }, |
| 97 |
d => { defaultvalue => '942d_val' }, |
| 98 |
f => { defaultvalue => '942f_val' }, |
| 99 |
}, |
| 100 |
}; |
| 101 |
} |
| 102 |
); |
| 103 |
|
| 104 |
# Mock GetMarcFromKohaField to return item field |
| 105 |
$biblio_module->mock( 'GetMarcFromKohaField', sub { return ( '952', 'i' ); } ); |
| 106 |
|
| 107 |
# Mock IsMarcStructureInternal - return true for non-hashref (tag properties), false for subfields |
| 108 |
$biblio_module->mock( |
| 109 |
'IsMarcStructureInternal', |
| 110 |
sub { |
| 111 |
my ($subfieldstruct) = @_; |
| 112 |
return 1 unless ref($subfieldstruct) eq 'HASH'; |
| 113 |
return 0; |
| 114 |
} |
| 115 |
); |
| 116 |
|
| 117 |
# Test 1: Fill defaults for existing record |
| 118 |
my $record = MARC::Record->new(); |
| 119 |
$record->leader('03174nam a2200445 a 4500'); |
| 120 |
my @fields = ( |
| 121 |
MARC::Field->new( |
| 122 |
'008', '120829t20132012nyu bk 001 0ceng', |
| 123 |
), |
| 124 |
MARC::Field->new( |
| 125 |
100, '1', ' ', |
| 126 |
a => 'Knuth, Donald Ervin', |
| 127 |
d => '1938', |
| 128 |
), |
| 129 |
MARC::Field->new( |
| 130 |
245, '1', '4', |
| 131 |
a => 'The art of computer programming', |
| 132 |
c => 'Donald E. Knuth.', |
| 133 |
), |
| 134 |
MARC::Field->new( |
| 135 |
245, '1', '4', a => 'my second title', |
| 136 |
), |
| 137 |
); |
| 138 |
|
| 139 |
$record->append_fields(@fields); |
| 140 |
$framework->fill_with_default_values($record); |
| 141 |
|
| 142 |
my @fields_245 = $record->field(245); |
| 143 |
is( scalar(@fields_245), 2, 'No new 245 field has been created' ); |
| 144 |
my @subfields_245_0 = $fields_245[0]->subfields; |
| 145 |
my @subfields_245_1 = $fields_245[1]->subfields; |
| 146 |
is_deeply( |
| 147 |
\@subfields_245_0, |
| 148 |
[ [ 'a', 'The art of computer programming' ], [ 'c', 'Donald E. Knuth.' ] ], |
| 149 |
'first 245 field has not been updated' |
| 150 |
); |
| 151 |
is_deeply( |
| 152 |
\@subfields_245_1, |
| 153 |
[ [ 'a', 'my second title' ], [ 'c', $default_author ] ], |
| 154 |
'second 245 field has a new subfield c with a default value' |
| 155 |
); |
| 156 |
|
| 157 |
# Test 2: New field with default is created |
| 158 |
my @fields_099 = $record->field('099'); |
| 159 |
is( scalar(@fields_099), 1, '1 new 099 field has been created' ); |
| 160 |
my @subfields_099 = $fields_099[0]->subfields; |
| 161 |
is_deeply( |
| 162 |
\@subfields_099, |
| 163 |
[ [ 'x', 'default_099' ] ], |
| 164 |
'099$x contains the default value' |
| 165 |
); |
| 166 |
|
| 167 |
# Test 3: Control field default is applied when undefined |
| 168 |
$record->field('008')->update(undef); |
| 169 |
$framework->fill_with_default_values($record); |
| 170 |
is( $record->field('008')->data, $default_008, 'Controlfield got default' ); |
| 171 |
|
| 172 |
# Test 4: Check 942 fields |
| 173 |
is( $record->subfield( '942', 'd' ), '942d_val', 'Check 942d' ); |
| 174 |
|
| 175 |
# Test 5: Only mandatory parameter |
| 176 |
$record->delete_fields( $record->field('245') ); |
| 177 |
$record->delete_fields( $record->field('942') ); |
| 178 |
$record->append_fields( MARC::Field->new( '942', '', '', 'f' => 'f val' ) ); |
| 179 |
|
| 180 |
# We deleted 245 and replaced 942. If we only apply mandatories, we should get |
| 181 |
# back 245c again and 942c but not 942d. 942f should be left alone. |
| 182 |
$framework->fill_with_default_values( $record, { only_mandatory => 1 } ); |
| 183 |
@fields_245 = $record->field(245); |
| 184 |
is( scalar @fields_245, 1, 'Only one 245 expected' ); |
| 185 |
is( $record->subfield( '245', 'c' ), $default_author, '245c restored' ); |
| 186 |
is( $record->subfield( '942', 'c' ), 'BK', '942c also restored' ); |
| 187 |
is( $record->subfield( '942', 'd' ), undef, '942d should not be there' ); |
| 188 |
is( $record->subfield( '942', 'f' ), 'f val', '942f untouched' ); |
| 189 |
|
| 190 |
# Test 6: Handle undefined record gracefully |
| 191 |
my $record_undef; |
| 192 |
$framework->fill_with_default_values($record_undef); |
| 193 |
ok( !defined $record_undef, 'Undefined record handled without error' ); |
| 194 |
|
| 195 |
# Test 7: Empty record should get defaults |
| 196 |
my $empty_record = MARC::Record->new(); |
| 197 |
$framework->fill_with_default_values($empty_record); |
| 198 |
is( $empty_record->subfield( '942', 'c' ), 'BK', 'Empty record gets default 942c' ); |
| 199 |
}; |
| 200 |
|
| 53 |
$schema->storage->txn_rollback; |
201 |
$schema->storage->txn_rollback; |
| 54 |
- |
|
|