View | Details | Raw Unified | Return to bug 16329
Collapse All | Expand All

(-)a/Koha/Logger.pm (+17 lines)
Lines 91-96 sub get { Link Here
91
    return $self;
91
    return $self;
92
}
92
}
93
93
94
=head2 sql
95
96
    $logger->sql('debug', $sql, $params) if $logger->is_debug();
97
98
Log SQL-statements using a unified interface.
99
@param {String} Log level
100
@param {String} SQL-command
101
@param {ArrayRef} SQL prepared statement parameters
102
@returns whatever Log::Log4perl returns
103
104
=cut
105
106
sub sql {
107
    my ($self, $level, $sql, $params) = @_;
108
    return $self->$level("$sql -- @$params");
109
}
110
94
=head1 INTERNALS
111
=head1 INTERNALS
95
112
96
=head2 AUTOLOAD
113
=head2 AUTOLOAD
(-)a/t/Koha/Logger.t (-1 / +13 lines)
Lines 180-185 sub returnValuePassthrough { Link Here
180
}
180
}
181
t::Koha::Logger::clearLog();
181
t::Koha::Logger::clearLog();
182
182
183
184
subtest "Koha::Logger->sql()", \&sqlsql;
185
sub sqlsql {
186
    my $logger = Koha::Logger->get({category => "sqlsql-1"});
187
    my $retval = $logger->sql('fatal', 'SELECT * FROM a WHERE b=? AND c=? OR d=?', [1,2,3]) if $logger->is_fatal();
188
    my $log = t::Koha::Logger::slurpLog('wantArray');
189
    is(scalar(@$log), 1, "One entry written");
190
    is($retval, 1, "Koha::Logger->sql() returns 'true' per Log4perl best practices");
191
    ok($log->[0] =~ /SELECT \* FROM a WHERE b=\? AND c=\? OR d=\? -- 1 2 3/);
192
    t::Koha::Logger::clearLog();
193
}
194
195
183
sub _loggerBlarbAllLevels {
196
sub _loggerBlarbAllLevels {
184
    my ($logger) = @_;
197
    my ($logger) = @_;
185
    $logger->trace('trace');
198
    $logger->trace('trace');
186
- 

Return to bug 16329