Attachment #61997 for bug #17600

View | Details | Raw Unified | Return to bug 17600
Collapse All | Expand All

Lines 21-30 package C4::Accounts; Link Here

(-)a/C4/Accounts.pm (-3 / +3 lines)
21	use strict;	21	use strict;
22	#use warnings; FIXME - Bug 2505	22	#use warnings; FIXME - Bug 2505
23	use C4::Context;	23	use C4::Context;
24	use C4::Stats;	24	use C4::Stats qw( UpdateStats );
25	use C4::Members;	25	use C4::Members;
26	use C4::Circulation qw(ReturnLostItem);	26	use C4::Circulation qw( ReturnLostItem LostItem );
27	use C4::Log qw(logaction);	27	use C4::Log qw( logaction );
28	use Koha::Account;	28	use Koha::Account;
29	use Koha::Account::Lines;	29	use Koha::Account::Lines;
30		30

Lines 23-30 use Carp; Link Here

(-)a/C4/Acquisition.pm (-2 / +2 lines)
23	use C4::Context;	23	use C4::Context;
24	use C4::Debug;	24	use C4::Debug;
25	use C4::Suggestions;	25	use C4::Suggestions;
26	use C4::Biblio;	26	use C4::Biblio qw( GetBiblio GetBiblioData GetBiblionumberFromItemnumber GetFrameworkCode GetMarcFromKohaField DelBiblio GetMarcStructure IsMarcStructureInternal );
27	use C4::Contract;	27	use C4::Contract qw( GetContract );
28	use C4::Debug;	28	use C4::Debug;
29	use C4::Templates qw(gettemplate);	29	use C4::Templates qw(gettemplate);
30	use Koha::DateUtils qw( dt_from_string output_pref );	30	use Koha::DateUtils qw( dt_from_string output_pref );

Lines 27-37 use CGI::Session; Link Here

(-)a/C4/Auth.pm (-2 / +2 lines)
27		27
28	use C4::Context;	28	use C4::Context;
29	use C4::Templates; # to get the template	29	use C4::Templates; # to get the template
30	use C4::Languages;	30	use C4::Languages qw( getlanguage );
31	use C4::Search::History;	31	use C4::Search::History;
32	use Koha;	32	use Koha;
33	use Koha::Caches;	33	use Koha::Caches;
34	use Koha::AuthUtils qw(get_script_name hash_password);	34	use Koha::AuthUtils qw( get_script_name hash_password );
35	use Koha::Libraries;	35	use Koha::Libraries;
36	use Koha::LibraryCategories;	36	use Koha::LibraryCategories;
37	use Koha::Patrons;	37	use Koha::Patrons;

Lines 22-28 use warnings; Link Here

(-)a/C4/Auth_with_cas.pm (-1 / +1 lines)
22		22
23	use C4::Debug;	23	use C4::Debug;
24	use C4::Context;	24	use C4::Context;
25	use Koha::AuthUtils qw(get_script_name);	25	use Koha::AuthUtils qw( get_script_name );
26	use Authen::CAS::Client;	26	use Authen::CAS::Client;
27	use CGI qw ( -utf8 );	27	use CGI qw ( -utf8 );
28	use FindBin;	28	use FindBin;





use C4::Debug;
use C4::Context;
use C4::Members qw( AddMember );
use C4::Members qw( AddMember );
use C4::Members qw( AddMember );
use C4::Members qw( AddMember );
use C4::Auth qw( checkpw checkpw_internal );
use Koha::Patrons;
use Koha::AuthUtils qw( hash_password );
use List::MoreUtils qw( any );
use Net::LDAP;
use Net::LDAP::Filter;

Lines 21-27 use Modern::Perl; Link Here

(-)a/C4/Auth_with_shibboleth.pm (-1 / +1 lines)
21		21
22	use C4::Debug;	22	use C4::Debug;
23	use C4::Context;	23	use C4::Context;
24	use Koha::AuthUtils qw(get_script_name);	24	use Koha::AuthUtils qw( get_script_name );
25	use Koha::Database;	25	use Koha::Database;
26	use C4::Members qw( AddMember_Auto );	26	use C4::Members qw( AddMember_Auto );
27	use C4::Members::Messaging;	27	use C4::Members::Messaging;




use warnings;
use C4::Context;
use MARC::Record;
use C4::Biblio qw( ModZebra GetMarcFromKohaField GetMarcBiblio ModBiblio GetFrameworkCode );
use C4::Search qw( FindDuplicate new_record_from_zebra );
use C4::AuthoritiesMarc::MARC21;
use C4::AuthoritiesMarc::UNIMARC;
use C4::Charset qw( SetUTF8Flag );
use C4::Log qw( logaction );
use Koha::MetadataRecord::Authority;
use Koha::Authorities;
use Koha::Authority::Types;

Lines 21-27 package C4::BackgroundJob; Link Here

(-)a/C4/BackgroundJob.pm (-1 / +1 lines)
21	use strict;	21	use strict;
22	#use warnings; FIXME - Bug 2505	22	#use warnings; FIXME - Bug 2505
23	use C4::Context;	23	use C4::Context;
24	use C4::Auth qw/get_session/;	24	use C4::Auth qw( get_session );
25	use Digest::MD5;	25	use Digest::MD5;
26		26
27		27

Lines 25-31 use Carp; Link Here

(-)a/C4/Barcodes/annual.pm (-1 / +1 lines)
25	use C4::Context;	25	use C4::Context;
26	use C4::Debug;	26	use C4::Debug;
27		27
28	use Koha::DateUtils qw( output_pref dt_from_string );	28	use Koha::DateUtils qw( dt_from_string output_pref );
29		29
30	use vars qw(@ISA);	30	use vars qw(@ISA);
31	use vars qw($debug $cgi_debug); # from C4::Debug, of course	31	use vars qw($debug $cgi_debug); # from C4::Debug, of course




use POSIX qw(strftime);
use Module::Load::Conditional qw(can_load);

use C4::Koha qw( get_infos_of getitemtypeinfo );
use C4::Log qw( logaction );
use C4::Budgets;
use C4::ClassSource qw( GetClassSort );
use C4::Charset qw( SetUTF8Flag SetMarcUnicodeFlag StripNonXmlChars nsb_clean );
use C4::Linker;
use C4::OAI::Sets qw( UpdateOAISetsBiblio );
use C4::Debug;
use C4::Items qw( AddItem ModItem GetItem GetHiddenItemnumbers GetMarcItem );

use Koha::Caches;
use Koha::Authority::Types;




use strict;
use warnings;

use C4::Biblio qw( AddBiblio TransformMarcToKoha TransformMarcToKohaOneField );
use C4::Koha qw( GetNormalizedISBN );
use C4::Charset qw( MarcToUTF8Record SetUTF8Flag );
use MARC::File::USMARC;
use C4::ImportBatch qw( GetZ3950BatchId AddBiblioToBatch AddAuthToBatch );
use C4::AuthoritiesMarc qw( GetAuthorizedHeading GuessAuthTypeCode FindDuplicateAuthority ModAuthority );
use C4::Languages qw( getlanguage );
use Koha::Database;
use Koha::XSLT_Handler;





use strict;
#use warnings; FIXME - Bug 2505
use DateTime;
use Koha::DateUtils qw( dt_from_string output_pref );
use C4::Context;
use C4::Stats qw( UpdateStats );
use C4::Reserves qw( CheckReserves CanItemBeReserved MoveReserve ModReserve ModReserveStatus IsItemOnHoldAndFound IsAvailableForItemLevelRequest );
use C4::Biblio qw( GetBiblio GetBiblioFromItemNumber GetBiblioItemData UpdateTotalIssues GetBiblioData );
use C4::Items qw( GetItem GetItemnumberFromBarcode ModItem ModItemTransfer ModDateLastSeen CartToShelf ShelfToCart );
use C4::Members qw( GetMemberDetails GetMember GetMemberAccountBalance GetAge );
use C4::Accounts qw( getnextacctno chargelostitem );
use C4::ItemCirculationAlertPreference;
use C4::Message;
use C4::Debug;
use C4::Log qw( logaction );
use C4::Overdues qw( UpdateFine get_chargeable_units CalcFine );
use C4::RotatingCollections qw( isItemInAnyCollection );
use Algorithm::CheckDigits;

use Data::Dumper;
use Koha::Account;
use Koha::AuthorisedValues;
use Koha::DateUtils qw( dt_from_string output_pref );
use Koha::Calendar;
use Koha::Checkouts;
use Koha::IssuingRules;
use Koha::Items;
use Koha::Patrons;
use Koha::Patron::Debarments qw( GetDebarments DelUniqueDebarment AddUniqueDebarment );
use Koha::Database;
use Koha::Libraries;
use Koha::Holds;

Lines 28-34 C4::ClassSortRoutine::Dewey - generic call number sorting key routine Link Here

(-)a/C4/ClassSortRoutine/Dewey.pm (-1 / +1 lines)
28		28
29	=head1 SYNOPSIS	29	=head1 SYNOPSIS
30		30
31	use C4::ClassSortRoutine;	31	use C4::ClassSortRoutine qw( GetClassSortKey );
32		32
33	my $cn_sort = GetClassSortKey('Dewey', $cn_class, $cn_item);	33	my $cn_sort = GetClassSortKey('Dewey', $cn_class, $cn_item);
34		34

Lines 28-34 C4::ClassSortRoutine::Generic - generic call number sorting key routine Link Here

(-)a/C4/ClassSortRoutine/Generic.pm (-1 / +1 lines)
28		28
29	=head1 SYNOPSIS	29	=head1 SYNOPSIS
30		30
31	use C4::ClassSortRoutine;	31	use C4::ClassSortRoutine qw( GetClassSortKey );
32		32
33	my $cn_sort = GetClassSortKey('Generic', $cn_class, $cn_item);	33	my $cn_sort = GetClassSortKey('Generic', $cn_class, $cn_item);
34		34

Lines 30-36 C4::ClassSortRoutine::LCC - generic call number sorting key routine Link Here

(-)a/C4/ClassSortRoutine/LCC.pm (-1 / +1 lines)
30		30
31	=head1 SYNOPSIS	31	=head1 SYNOPSIS
32		32
33	use C4::ClassSortRoutine;	33	use C4::ClassSortRoutine qw( GetClassSortKey );
34		34
35	my $cn_sort = GetClassSortKey('LCC', $cn_class, $cn_item);	35	my $cn_sort = GetClassSortKey('LCC', $cn_class, $cn_item);
36		36

Lines 97-103 use DateTime::TimeZone; Link Here

(-)a/C4/Context.pm (-1 / +1 lines)
97	use Module::Load::Conditional qw(can_load);	97	use Module::Load::Conditional qw(can_load);
98	use Carp;	98	use Carp;
99		99
100	use C4::Boolean;	100	use C4::Boolean qw( true_p );
101	use C4::Debug;	101	use C4::Debug;
102	use Koha;	102	use Koha;
103	use Koha::Config;	103	use Koha::Config;

Lines 20-28 use Modern::Perl; Link Here

(-)a/C4/CourseReserves.pm (-3 / +3 lines)
20	use List::MoreUtils qw(any);	20	use List::MoreUtils qw(any);
21		21
22	use C4::Context;	22	use C4::Context;
23	use C4::Items qw(GetItem ModItem);	23	use C4::Items qw( GetItem ModItem );
24	use C4::Biblio qw(GetBiblioFromItemNumber);	24	use C4::Biblio qw( GetBiblioFromItemNumber GetBiblio );
25	use C4::Circulation qw(GetOpenIssue);	25	use C4::Circulation qw( GetOpenIssue );
26		26
27	use vars qw($DEBUG @FIELDS);	27	use vars qw($DEBUG @FIELDS);
28	our (@ISA, @EXPORT_OK);	28	our (@ISA, @EXPORT_OK);

Lines 7-13 use autouse 'Data::Dumper' => qw(Dumper); Link Here

(-)a/C4/Creators/Profile.pm (-1 / +1 lines)
7		7
8	use C4::Context;	8	use C4::Context;
9	use C4::Debug;	9	use C4::Debug;
10	use C4::Creators::Lib qw(get_unit_values);	10	use C4::Creators::Lib qw( get_unit_values );
11		11
12		12
13	sub _check_params {	13	sub _check_params {

Lines 8-14 use autouse 'Data::Dumper' => qw(Dumper); Link Here

(-)a/C4/Creators/Template.pm (-1 / +1 lines)
8	use C4::Context;	8	use C4::Context;
9	use C4::Debug;	9	use C4::Debug;
10	use C4::Creators::Profile;	10	use C4::Creators::Profile;
11	use C4::Creators::Lib qw(get_unit_values);	11	use C4::Creators::Lib qw( get_unit_values );
12		12
13		13
14	sub _check_params {	14	sub _check_params {

Lines 24-34 use warnings; Link Here

(-)a/C4/HoldsQueue.pm (-5 / +5 lines)
24		24
25	use C4::Context;	25	use C4::Context;
26	use C4::Search;	26	use C4::Search;
27	use C4::Items;	27	use C4::Items qw( GetItem );
28	use C4::Circulation;	28	use C4::Circulation qw( GetTransfers GetBranchItemRule );
29	use C4::Members;	29	use C4::Members qw( GetMember );
30	use C4::Biblio;	30	use C4::Biblio qw( GetHolds GetMarcBiblio GetRecordValue GetBiblioData GetBiblio );
31	use Koha::DateUtils;	31	use Koha::DateUtils qw( dt_from_string );
32		32
33	use List::Util qw(shuffle);	33	use List::Util qw(shuffle);
34	use List::MoreUtils qw(any);	34	use List::MoreUtils qw(any);




use strict;
use warnings;

use C4::Members qw( GetMember GetPendingIssues );
use C4::Items qw( GetItem GetItemsByBiblioitemnumber );
use C4::Circulation qw( GetBiblioIssues CanBookBeRenewed barcodedecode decode CanBookBeIssued AddRenewal GetItemIssue );
use C4::Accounts qw( getcharges );
use C4::Biblio qw( GetBiblioItemByBiblioNumber GetBiblio GetMarcBiblio GetBiblioFromItemNumber );
use C4::Reserves qw( GetReserve GetReservesFromBorrowernumber CanBookBeReserved IsAvailableForItemLevelRequest CalculatePriority AddReserve CanItemBeReserved CancelReserve );
use C4::Context;
use C4::Auth qw( checkpw );
use XML::Simple;
use HTML::Entities;
use CGI qw ( -utf8 );
use DateTime;
use C4::Auth qw( checkpw );
use C4::Members qw( GetMember GetMemberDetails GetPendingIssues );

use Koha::Biblios;
use Koha::Libraries;




use warnings;

use C4::Context;
use C4::Koha qw( GetNormalizedISBN );
use C4::Biblio qw( AddBiblio ModBiblio GetMarcFromKohaField GetBiblio GetXmlBiblio GetFrameworkCode TransformMarcToKoha DelBiblio );
use C4::Items qw( AddItem GetItem GetItemnumberFromBarcode ModItemFromMarc ModItem AddItemFromMarc DelItem DelItemCheck );
use C4::Charset qw( SetUTF8Flag StripNonXmlChars MarcToUTF8Record );
use C4::AuthoritiesMarc qw( ModAuthority GuessAuthTypeCode AddAuthority GetAuthorityXML GetAuthority DelAuthority GetAuthorizedHeading );
use C4::MarcModificationTemplates qw( ModifyRecordWithTemplate );
use Koha::Plugins::Handler;
use Koha::Logger;


Lines 22-28 use strict; Link Here

(-)a/C4/InstallAuth.pm (-1 / +1 lines)
22	use Digest::MD5 qw(md5_base64);	22	use Digest::MD5 qw(md5_base64);
23		23
24	use C4::Context;	24	use C4::Context;
25	use C4::Output;	25	use C4::Output qw( output_html_with_http_headers );
26	use C4::Templates;	26	use C4::Templates;
27	use C4::Koha;	27	use C4::Koha;
28	use CGI::Session;	28	use CGI::Session;





use Carp;
use C4::Context;
use C4::Koha qw( IsKohaFieldLinked get_infos_of GetItemTypes );
use C4::Biblio qw( GetFrameworkCode GetMarcFromKohaField TransformMarcToKoha ModZebra AddBiblio GetBiblionumberFromItemnumber GetBiblio GetMarcBiblio TransformKohaToMarc GetMarcStructure IsMarcStructureInternal );
use Koha::DateUtils qw( dt_from_string output_pref );
use MARC::Record;
use C4::ClassSource qw( GetClassSort GetClassSources GetClassSource );
use C4::Log qw( logaction );
use List::MoreUtils qw/any/;
use YAML qw/Load/;
use DateTime::Format::MySQL;

                  # debugging; so please don't remove this

use Koha::AuthorisedValues;
use Koha::DateUtils qw( dt_from_string output_pref );
use Koha::Database;

use Koha::Biblioitems;

Lines 25-31 use strict; Link Here

(-)a/C4/Koha.pm (-1 / +1 lines)
25		25
26	use C4::Context;	26	use C4::Context;
27	use Koha::Caches;	27	use Koha::Caches;
28	use Koha::DateUtils qw(dt_from_string);	28	use Koha::DateUtils qw( dt_from_string );
29	use Koha::AuthorisedValues;	29	use Koha::AuthorisedValues;
30	use Koha::Libraries;	30	use Koha::Libraries;
31	use Koha::MarcSubfieldStructures;	31	use Koha::MarcSubfieldStructures;

Lines 12-18 use Text::Bidi qw( log2vis ); Link Here

(-)a/C4/Labels/Label.pm (-1 / +1 lines)
12		12
13	use C4::Context;	13	use C4::Context;
14	use C4::Debug;	14	use C4::Debug;
15	use C4::Biblio;	15	use C4::Biblio qw( GetAuthorisedValueDesc GetMarcFromKohaField GetMarcBiblio );
16		16
17		17
18	my $possible_decimal = qr/\d{3,}(?:\.\d+)?/; # at least three digits for a DDCN	18	my $possible_decimal = qr/\d{3,}(?:\.\d+)?/; # at least three digits for a DDCN




use Template;
use Module::Load::Conditional qw(can_load);

use C4::Members qw( GetMember GetNoticeEmailAddress );
use C4::Members qw( GetMember GetNoticeEmailAddress );
use C4::Log qw( logaction );
use C4::SMS;
use C4::Debug;
use Koha::DateUtils qw( format_sqldatetime dt_from_string output_pref );
use Koha::SMS::Providers;

use Koha::Email;
use Koha::DateUtils qw( format_sqldatetime dt_from_string output_pref );

our (@ISA, @EXPORT_OK);
BEGIN {

Lines 27-33 use warnings; Link Here

(-)a/C4/Log.pm (-1 / +1 lines)
27	use JSON qw( to_json );	27	use JSON qw( to_json );
28		28
29	use C4::Context;	29	use C4::Context;
30	use Koha::DateUtils;	30	use Koha::DateUtils qw( output_pref dt_from_string );
31	use Koha::Logger;	31	use Koha::Logger;
32		32
33		33

Lines 22-28 use Modern::Perl; Link Here

(-)a/C4/MarcModificationTemplates.pm (-1 / +1 lines)
22	use DateTime;	22	use DateTime;
23		23
24	use C4::Context;	24	use C4::Context;
25	use Koha::SimpleMARC;	25	use Koha::SimpleMARC qw( field_exists field_equals copy_field copy_and_replace_field update_field move_field delete_field );
26		26
27	use constant DEBUG => 0;	27	use constant DEBUG => 0;
28	our ( @ISA, @EXPORT_OK );	28	our ( @ISA, @EXPORT_OK );

Lines 23-29 use MARC::Record; Link Here

(-)a/C4/Matcher.pm (-1 / +1 lines)
23		23
24	use Koha::SearchEngine;	24	use Koha::SearchEngine;
25	use Koha::SearchEngine::Search;	25	use Koha::SearchEngine::Search;
26	use Koha::Util::Normalize qw/legacy_default remove_spaces upper_case lower_case/;	26	use Koha::Util::Normalize qw( remove_spaces upper_case lower_case legacy_default );
27		27
28	=head1 NAME	28	=head1 NAME
29		29




use String::Random qw( random_string );
use Scalar::Util qw( looks_like_number );
use Date::Calc qw/Today check_date Date_to_Days/;
use C4::Log qw( logaction );
use C4::Overdues qw( checkoverdues );
use C4::Reserves qw( GetReserve GetReservesFromBorrowernumber );
use C4::Accounts;
use C4::Biblio qw( GetBiblioFromItemNumber GetBiblio );
use C4::Letters qw( GetPreparedLetter );
use C4::Members::Attributes qw(SearchIdMatchingAttribute UpdateBorrowerAttribute);
use C4::NewsChannels qw( GetNewsToDisplay );
use DateTime;
use Koha::Database;
use Koha::DateUtils qw( dt_from_string output_pref );
use Text::Unaccent qw( unac_string );
use Koha::AuthUtils qw( hash_password );
use Koha::Database;
use Koha::Holds;
use Koha::List::Patron;

Lines 22-28 package C4::Message; Link Here

(-)a/C4/Message.pm (-1 / +1 lines)
22	use strict;	22	use strict;
23	use warnings;	23	use warnings;
24	use C4::Context;	24	use C4::Context;
25	use C4::Letters;	25	use C4::Letters qw( GetPreparedLetter EnqueueLetter getletter );
26	use YAML::Syck;	26	use YAML::Syck;
27	use Carp;	27	use Carp;
28		28

Lines 20-26 package C4::NewsChannels; Link Here

(-)a/C4/NewsChannels.pm (-1 / +1 lines)
20		20
21	use Modern::Perl;	21	use Modern::Perl;
22	use C4::Context;	22	use C4::Context;
23	use Koha::DateUtils;	23	use Koha::DateUtils qw( dt_from_string output_pref );
24		24
25	our ( @ISA, @EXPORT_OK );	25	our ( @ISA, @EXPORT_OK );
26		26




use Locale::Currency::Format 1.28;
use Carp;

use C4::Circulation qw( GetIssues );
use C4::Context;
use C4::Accounts qw( getnextacctno );
use C4::Log qw( logaction );
use C4::Debug;
use Koha::DateUtils qw( dt_from_string output_pref );
use Koha::Account::Line;
use Koha::Account::Lines;
use Koha::IssuingRules;

Lines 26-32 use Text::Wrap qw(wrap); Link Here

(-)a/C4/Patroncards/Patroncard.pm (-1 / +1 lines)
26		26
27	use C4::Creators::Lib qw(get_font_types);	27	use C4::Creators::Lib qw(get_font_types);
28	use C4::Creators::PDF qw(StrWidth);	28	use C4::Creators::PDF qw(StrWidth);
29	use C4::Patroncards::Lib qw(unpack_UTF8 text_alignment leading box get_borrower_attributes);	29	use C4::Patroncards::Lib qw( box get_borrower_attributes text_alignment leading );
30		30
31		31
32	sub new {	32	sub new {




use MARC::File::XML; # marc2marcxml, marcxml2marc, changeEncoding
use Biblio::EndnoteStyle;
use Unicode::Normalize; # _entity_encode
use C4::Biblio qw( GetXmlBiblio GetBiblionumberFromItemnumber GetBiblio GetMarcBiblio EmbedItemsInMarcBiblio GetFrameworkCode );
use C4::Koha; #marc2csv
use C4::XSLT qw( engine );
use YAML; #marcrecords2csv
use Template;
use Text::CSV::Encoded; #marc2csv
use Koha::SimpleMARC qw( delete_field read_field );
use Koha::XSLT_Handler;
use Koha::CsvProfiles;
use Koha::AuthorisedValues;

Lines 24-34 use JSON qw( from_json ); Link Here

(-)a/C4/Reports/Guided.pm (-3 / +3 lines)
24		24
25	use C4::Context;	25	use C4::Context;
26	use C4::Templates qw/themelanguage/;	26	use C4::Templates qw/themelanguage/;
27	use C4::Koha;	27	use C4::Koha qw( GetAuthorisedValues );
28	use Koha::DateUtils;	28	use Koha::DateUtils qw( dt_from_string output_pref );
29	use C4::Output;	29	use C4::Output;
30	use C4::Debug;	30	use C4::Debug;
31	use C4::Log;	31	use C4::Log qw( logaction );
32		32
33	use Koha::AuthorisedValues;	33	use Koha::AuthorisedValues;
34	use Koha::Patron::Categories;	34	use Koha::Patron::Categories;




use strict;
#use warnings; FIXME - Bug 2505
use C4::Context;
use C4::Biblio qw( GetBiblioData GetBiblio );
use C4::Members qw( GetMember GetAge GetNoticeEmailAddress );
use C4::Items qw( GetItem GetItemnumbersForBiblio get_hostitemnumbers_of ModItem ModItemTransfer CartToShelf );
use C4::Circulation qw( GetAgeRestriction _GetCircControlBranch GetBranchItemRule );
use C4::Accounts qw( getnextacctno manualinvoice );

# for _koha_notify_reserve
use C4::Members qw( GetMember GetAge GetNoticeEmailAddress );
use C4::Members qw( GetMember GetAge GetNoticeEmailAddress );
use C4::Letters qw( GetPreparedLetter EnqueueLetter );
use C4::Log qw( logaction );

use Koha::DateUtils qw( dt_from_string output_pref );
use Koha::Calendar;
use Koha::Database;
use Koha::Hold;

Lines 65-71 use Modern::Perl; Link Here

(-)a/C4/Ris.pm (-1 / +1 lines)
65	use List::MoreUtils qw/uniq/;	65	use List::MoreUtils qw/uniq/;
66		66
67	use C4::Biblio qw(GetMarcSubfieldStructureFromKohaField);	67	use C4::Biblio qw(GetMarcSubfieldStructureFromKohaField);
68	use Koha::SimpleMARC qw(read_field);	68	use Koha::SimpleMARC qw( read_field );
69		69
70	our ( @ISA, @EXPORT_OK );	70	our ( @ISA, @EXPORT_OK );
71		71

Lines 25-32 package C4::RotatingCollections; Link Here

(-)a/C4/RotatingCollections.pm (-2 / +2 lines)
25	use Modern::Perl;	25	use Modern::Perl;
26		26
27	use C4::Context;	27	use C4::Context;
28	use C4::Circulation;	28	use C4::Circulation qw( GetTransfers transferbook );
29	use C4::Reserves qw(CheckReserves);	29	use C4::Reserves qw( CheckReserves );
30	use Koha::Database;	30	use Koha::Database;
31		31
32	use DBI;	32	use DBI;




#use warnings; FIXME - Bug 2505

use C4::Context;
use C4::Biblio qw( TransformMarcToKoha GetMarcFromKohaField GetFrameworkCode GetRecordValue GetMarcBiblio GetAuthorisedValueDesc GetBiblioData GetBiblio );
use C4::Koha qw( getFacets GetVariationsOfISBN GetItemTypes getitemtypeimagelocation GetNormalizedUPC GetNormalizedEAN GetNormalizedOCLCNumber GetNormalizedISBN );
use Koha::DateUtils qw( dt_from_string output_pref );
use Koha::Libraries;
use Lingua::Stem;
use C4::Search::PazPar2;
use XML::Simple;
use C4::XSLT qw( get_xslt_sysprefs XSLTParse4Display engine );
use C4::Reserves qw( GetReserve GetReserveStatus );
use C4::Debug;
use C4::Charset qw( SetUTF8Flag );
use Koha::AuthorisedValues;
use Koha::Libraries;
use Koha::Patrons;

Lines 4-10 use Modern::Perl; Link Here

(-)a/C4/Search/History.pm (-1 / +1 lines)
4		4
5	use C4::Auth qw( get_session );	5	use C4::Auth qw( get_session );
6	use C4::Context;	6	use C4::Context;
7	use Koha::DateUtils;	7	use Koha::DateUtils qw( dt_from_string output_pref );
8		8
9	use JSON qw( encode_json decode_json );	9	use JSON qw( encode_json decode_json );
10	use URI::Escape;	10	use URI::Escape;





use Modern::Perl;

use C4::Auth qw( haspermission );
use C4::Context;
use DateTime;
use Date::Calc qw(:all);
use POSIX qw(strftime);
use C4::Biblio qw( GetBiblio GetMarcBiblio GetMarcFromKohaField ModBiblio );
use C4::Log qw( logaction );
use C4::Debug;
use C4::Serials::Frequency qw( GetSubscriptionFrequency );
use C4::Serials::Numberpattern qw( GetSubscriptionNumberpattern );
use Koha::AdditionalField;
use Koha::DateUtils qw( dt_from_string output_pref );
use Koha::Serial;
use Koha::Subscriptions;
use Koha::Subscription::Histories;

Lines 43-50 use warnings; Link Here

(-)a/C4/Service.pm (-2 / +2 lines)
43		43
44	use CGI qw ( -utf8 );	44	use CGI qw ( -utf8 );
45	use C4::Auth qw( check_api_auth );	45	use C4::Auth qw( check_api_auth );
46	use C4::Output qw( :ajax );	46	use C4::Output qw( output_with_http_headers );
47	use C4::Output::JSONStream;	47	use C4::Output qw( output_with_http_headers );
48	use JSON;	48	use JSON;
49		49
50	our $debug;	50	our $debug;

Lines 22-30 package C4::ShelfBrowser; Link Here

(-)a/C4/ShelfBrowser.pm (-2 / +2 lines)
22	use strict;	22	use strict;
23	use warnings;	23	use warnings;
24		24
25	use C4::Biblio;	25	use C4::Biblio qw( GetAuthorisedValueDesc GetMarcBiblio GetRecordValue GetFrameworkCode );
26	use C4::Context;	26	use C4::Context;
27	use C4::Koha;	27	use C4::Koha qw( GetNormalizedUPC GetNormalizedOCLCNumber GetNormalizedISBN GetNormalizedEAN );
28	use Koha::Libraries;	28	use Koha::Libraries;
29		29
30	our (@ISA, @EXPORT_OK);	30	our (@ISA, @EXPORT_OK);

Lines 19-25 use Modern::Perl; Link Here

(-)a/C4/SocialData.pm (-1 / +1 lines)
19		19
20	use C4::Context;	20	use C4::Context;
21	use Business::ISBN;	21	use Business::ISBN;
22	use C4::Koha;	22	use C4::Koha qw( GetNormalizedISBN );
23		23
24	=head1 NAME	24	=head1 NAME
25		25

Lines 26-33 use CGI qw ( -utf8 ); Link Here

(-)a/C4/Suggestions.pm (-2 / +2 lines)
26	use C4::Context;	26	use C4::Context;
27	use C4::Output;	27	use C4::Output;
28	use C4::Debug;	28	use C4::Debug;
29	use C4::Letters;	29	use C4::Letters qw( GetPreparedLetter EnqueueLetter );
30	use Koha::DateUtils;	30	use Koha::DateUtils qw( dt_from_string output_pref );
31		31
32	use List::MoreUtils qw(any);	32	use List::MoreUtils qw(any);
33	use base qw(Exporter);	33	use base qw(Exporter);

Lines 32-38 use List::MoreUtils qw/ any uniq /; Link Here

(-)a/C4/Templates.pm (-1 / +1 lines)
32	use base qw(Class::Accessor);	32	use base qw(Class::Accessor);
33	use Template;	33	use Template;
34	use Template::Constants qw( :debug );	34	use Template::Constants qw( :debug );
35	use C4::Languages qw(getTranslatedLanguages get_bidi regex_lang_subtags language_get_description accept_language );	35	use C4::Languages qw( regex_lang_subtags get_bidi getTranslatedLanguages getlanguage );
36		36
37	use C4::Context;	37	use C4::Context;
38		38

Lines 20-26 package C4::TmplToken; Link Here

(-)a/C4/TmplToken.pm (-1 / +1 lines)
20		20
21	use strict;	21	use strict;
22	use warnings;	22	use warnings;
23	use C4::TmplTokenType;	23	use C4::TmplTokenType qw( DIRECTIVE TAG CDATA TEXT TEXT_PARAMETRIZED );
24		24
25	=head1 NAME	25	=head1 NAME
26		26

Lines 19-28 package C4::XISBN; Link Here

(-)a/C4/XISBN.pm (-4 / +4 lines)
19		19
20	use XML::Simple;	20	use XML::Simple;
21	#use LWP::Simple;	21	#use LWP::Simple;
22	use C4::Biblio;	22	use C4::Biblio qw( get_koha_field_from_marc GetBiblioData GetBiblio );
23	use C4::Koha;	23	use C4::Koha qw( GetNormalizedISBN );
24	use C4::Search;	24	use C4::Search qw( new_record_from_zebra );
25	use C4::External::Syndetics qw(get_syndetics_editions);	25	use C4::External::Syndetics qw( get_syndetics_editions );
26	use LWP::UserAgent;	26	use LWP::UserAgent;
27	use HTTP::Request::Common;	27	use HTTP::Request::Common;
28		28

Lines 24-34 package C4::XSLT; Link Here

(-)a/C4/XSLT.pm (-5 / +5 lines)
24	use Modern::Perl;	24	use Modern::Perl;
25		25
26	use C4::Context;	26	use C4::Context;
27	use C4::Items;	27	use C4::Items qw( GetItem GetItemsInfo );
28	use C4::Koha;	28	use C4::Koha qw( GetItemTypes xml_escape );
29	use C4::Biblio;	29	use C4::Biblio qw( GetFrameworkCode GetMarcStructure GetAuthorisedValueDesc );
30	use C4::Circulation;	30	use C4::Circulation qw( GetTransfers );
31	use C4::Reserves;	31	use C4::Reserves qw( GetReserve GetReserveStatus );
32	use Koha::AuthorisedValues;	32	use Koha::AuthorisedValues;
33	use Koha::XSLT_Handler;	33	use Koha::XSLT_Handler;
34	use Koha::Libraries;	34	use Koha::Libraries;

Lines 27-33 use Koha::Biblios; Link Here

(-)a/Koha/ArticleRequest.pm (-1 / +1 lines)
27	use Koha::Items;	27	use Koha::Items;
28	use Koha::Libraries;	28	use Koha::Libraries;
29	use Koha::ArticleRequest::Status;	29	use Koha::ArticleRequest::Status;
30	use Koha::DateUtils qw(dt_from_string);	30	use Koha::DateUtils qw( dt_from_string );
31		31
32	use base qw(Koha::Object);	32	use base qw(Koha::Object);
33		33

Lines 21-27 use Modern::Perl; Link Here

(-)a/Koha/Biblio.pm (-1 / +1 lines)
21		21
22	use Carp;	22	use Carp;
23		23
24	use C4::Biblio qw();	24	use C4::Biblio qw( GetRecordValue GetMarcBiblio );
25		25
26	use Koha::Database;	26	use Koha::Database;
27	use Koha::DateUtils qw( dt_from_string );	27	use Koha::DateUtils qw( dt_from_string );

Lines 32-38 the new thing that should be used. Link Here

(-)a/Koha/BiblioUtils.pm (-1 / +1 lines)
32		32
33	=cut	33	=cut
34		34
35	use C4::Biblio; # EmbedItemsInMarcBiblio	35	use C4::Biblio qw( GetMarcBiblio );
36	use Koha::MetadataIterator;	36	use Koha::MetadataIterator;
37	use Koha::Database;	37	use Koha::Database;
38	use Modern::Perl;	38	use Modern::Perl;

Lines 43-49 Returns biblionumber and marc in list context. Link Here

(-)a/Koha/BiblioUtils/Iterator.pm (-1 / +1 lines)
43		43
44	=cut	44	=cut
45		45
46	use C4::Biblio; # :( - for EmbedItemsInMarcBiblio	46	use C4::Biblio qw( EmbedItemsInMarcBiblio );
47		47
48	use Carp;	48	use Carp;
49	use MARC::Record;	49	use MARC::Record;

Lines 23-29 use Carp; Link Here

(-)a/Koha/Config/SysPref.pm (-1 / +1 lines)
23		23
24	use Koha::Database;	24	use Koha::Database;
25		25
26	use C4::Log;	26	use C4::Log qw( logaction );
27		27
28	use base qw(Koha::Object);	28	use base qw(Koha::Object);
29		29

Lines 27-36 use Business::ISBN; Link Here

(-)a/Koha/EDI.pm (-3 / +3 lines)
27	use DateTime;	27	use DateTime;
28	use C4::Context;	28	use C4::Context;
29	use Koha::Database;	29	use Koha::Database;
30	use C4::Acquisition qw( NewBasket CloseBasket ModOrder);	30	use C4::Acquisition qw( ModOrder NewBasket CloseBasket );
31	use C4::Suggestions qw( ModSuggestion );	31	use C4::Suggestions qw( ModSuggestion );
32	use C4::Items qw(AddItem);	32	use C4::Items qw( AddItem );
33	use C4::Biblio qw( AddBiblio TransformKohaToMarc GetMarcBiblio );	33	use C4::Biblio qw( AddBiblio TransformKohaToMarc );
34	use Koha::Edifact::Order;	34	use Koha::Edifact::Order;
35	use Koha::Edifact;	35	use Koha::Edifact;
36	use Log::Log4perl;	36	use Log::Log4perl;

Lines 5-12 use MARC::File::XML; Link Here

(-)a/Koha/Exporter/Record.pm (-2 / +2 lines)
5	use MARC::File::USMARC;	5	use MARC::File::USMARC;
6		6
7	use C4::AuthoritiesMarc;	7	use C4::AuthoritiesMarc;
8	use C4::Biblio;	8	use C4::Biblio qw( RemoveAllNsb GetMarcBiblio EmbedItemsInMarcBiblio GetMarcFromKohaField GetFrameworkCode );
9	use C4::Record;	9	use C4::Record qw( marc2csv );
10	use Koha::CsvProfiles;	10	use Koha::CsvProfiles;
11	use Koha::Logger;	11	use Koha::Logger;
12		12

Lines 23-31 use Carp; Link Here

(-)a/Koha/Hold.pm (-2 / +2 lines)
23	use Data::Dumper qw(Dumper);	23	use Data::Dumper qw(Dumper);
24		24
25	use C4::Context qw(preference);	25	use C4::Context qw(preference);
26	use C4::Log;	26	use C4::Log qw( logaction );
27		27
28	use Koha::DateUtils qw(dt_from_string);	28	use Koha::DateUtils qw( dt_from_string );
29	use Koha::Patrons;	29	use Koha::Patrons;
30	use Koha::Biblios;	30	use Koha::Biblios;
31	use Koha::Items;	31	use Koha::Items;

Lines 21-27 use Modern::Perl; Link Here

(-)a/Koha/I18N.pm (-1 / +1 lines)
21	use base qw(Locale::Maketext Exporter);	21	use base qw(Locale::Maketext Exporter);
22		22
23	use CGI;	23	use CGI;
24	use C4::Languages;	24	use C4::Languages qw( getlanguage );
25		25
26	use Locale::Maketext::Lexicon {	26	use Locale::Maketext::Lexicon {
27	'en' => ['Auto'],	27	'en' => ['Auto'],

Lines 19-26 use Modern::Perl; Link Here

(-)a/Koha/ItemType.pm (-2 / +2 lines)
19		19
20	use Carp;	20	use Carp;
21		21
22	use C4::Koha;	22	use C4::Koha qw( getitemtypeimagelocation );
23	use C4::Languages;	23	use C4::Languages qw( getlanguage );
24	use Koha::Database;	24	use Koha::Database;
25	use Koha::Localizations;	25	use Koha::Localizations;
26		26

Lines 22-28 use Modern::Perl; Link Here

(-)a/Koha/MetaSearcher.pm (-1 / +1 lines)
22	use base 'Class::Accessor';	22	use base 'Class::Accessor';
23		23
24	use C4::Charset qw( MarcToUTF8Record );	24	use C4::Charset qw( MarcToUTF8Record );
25	use C4::Search qw(); # Purely for new_record_from_zebra	25	use C4::Search qw( new_record_from_zebra );
26	use DBIx::Class::ResultClass::HashRefInflator;	26	use DBIx::Class::ResultClass::HashRefInflator;
27	use IO::Select;	27	use IO::Select;
28	use Koha::Caches;	28	use Koha::Caches;

Lines 35-41 and authority) records in Koha. Link Here

(-)a/Koha/MetadataRecord.pm (-1 / +1 lines)
35	use Modern::Perl;	35	use Modern::Perl;
36		36
37	use Carp;	37	use Carp;
38	use C4::Biblio;	38	use C4::Biblio qw( GetMarcSubfieldStructure );
39	use Koha::Util::MARC;	39	use Koha::Util::MARC;
40		40
41	use base qw(Class::Accessor);	41	use base qw(Class::Accessor);

Lines 36-42 use warnings; Link Here

(-)a/Koha/MetadataRecord/Authority.pm (-1 / +1 lines)
36	use C4::Context;	36	use C4::Context;
37	use MARC::Record;	37	use MARC::Record;
38	use MARC::File::XML;	38	use MARC::File::XML;
39	use C4::Charset;	39	use C4::Charset qw( StripNonXmlChars );
40	use Koha::Util::MARC;	40	use Koha::Util::MARC;
41		41
42	use base qw(Koha::MetadataRecord);	42	use base qw(Koha::MetadataRecord);

Lines 23-32 use Modern::Perl; Link Here

(-)a/Koha/Patron.pm (-2 / +2 lines)
23	use Carp;	23	use Carp;
24		24
25	use C4::Context;	25	use C4::Context;
26	use C4::Log;	26	use C4::Log qw( logaction );
27	use Koha::Checkouts;	27	use Koha::Checkouts;
28	use Koha::Database;	28	use Koha::Database;
29	use Koha::DateUtils;	29	use Koha::DateUtils qw( dt_from_string );
30	use Koha::Holds;	30	use Koha::Holds;
31	use Koha::Old::Checkouts;	31	use Koha::Old::Checkouts;
32	use Koha::Patron::Categories;	32	use Koha::Patron::Categories;

Lines 22-28 use Carp; Link Here

(-)a/Koha/Patron/Category.pm (-1 / +1 lines)
22	use C4::Members::Messaging;	22	use C4::Members::Messaging;
23		23
24	use Koha::Database;	24	use Koha::Database;
25	use Koha::DateUtils;	25	use Koha::DateUtils qw( dt_from_string );
26		26
27	use base qw(Koha::Object);	27	use base qw(Koha::Object);
28		28

Lines 7-13 use Carp; Link Here

(-)a/Koha/Patron/Discharge.pm (-1 / +1 lines)
7		7
8	use C4::Templates qw ( gettemplate );	8	use C4::Templates qw ( gettemplate );
9	use C4::Members qw( GetPendingIssues );	9	use C4::Members qw( GetPendingIssues );
10	use C4::Reserves qw( GetReservesFromBorrowernumber CancelReserve );	10	use C4::Reserves qw( GetReserve GetReservesFromBorrowernumber CancelReserve );
11		11
12	use Koha::Database;	12	use Koha::Database;
13	use Koha::DateUtils qw( dt_from_string output_pref );	13	use Koha::DateUtils qw( dt_from_string output_pref );

Lines 72-78 use Time::HiRes; Link Here

(-)a/Koha/Uploader.pm (-1 lines)
72	use base qw(Class::Accessor);	72	use base qw(Class::Accessor);
73		73
74	use C4::Context;	74	use C4::Context;
75	use C4::Koha;
76	use Koha::UploadedFile;	75	use Koha::UploadedFile;
77	use Koha::UploadedFiles;	76	use Koha::UploadedFiles;
78		77

Lines 19-25 use Modern::Perl; Link Here

(-)a/Koha/Virtualshelf.pm (-1 / +1 lines)
19		19
20	use Carp;	20	use Carp;
21		21
22	use C4::Auth;	22	use C4::Auth qw( haspermission );
23		23
24	use Koha::Patrons;	24	use Koha::Patrons;
25	use Koha::Database;	25	use Koha::Database;

Lines 22-28 use DateTime; Link Here

(-)a/Koha/Virtualshelfshare.pm (-1 / +1 lines)
22	use DateTime::Duration;	22	use DateTime::Duration;
23		23
24	use Koha::Database;	24	use Koha::Database;
25	use Koha::DateUtils;	25	use Koha::DateUtils qw( dt_from_string );
26	use Koha::Exceptions;	26	use Koha::Exceptions;
27		27
28	use base qw(Koha::Object);	28	use base qw(Koha::Object);

Lines 29-35 use warnings; Link Here

(-)a/acqui/pdfformat/layout2pages.pm (-1 / +1 lines)
29	use utf8;	29	use utf8;
30		30
31	use Koha::Number::Price;	31	use Koha::Number::Price;
32	use Koha::DateUtils;	32	use Koha::DateUtils qw( dt_from_string output_pref );
33	use Koha::Libraries;	33	use Koha::Libraries;
34		34
35	our (@ISA, @EXPORT_OK);	35	our (@ISA, @EXPORT_OK);

Lines 28-34 use warnings; Link Here

(-)a/acqui/pdfformat/layout2pagesde.pm (-1 / +1 lines)
28	use utf8;	28	use utf8;
29		29
30	use Koha::Number::Price;	30	use Koha::Number::Price;
31	use Koha::DateUtils;	31	use Koha::DateUtils qw( dt_from_string output_pref );
32	use Koha::Libraries;	32	use Koha::Libraries;
33		33
34	our(@ISA, @EXPORT_OK);	34	our(@ISA, @EXPORT_OK);

Lines 30-36 use warnings; Link Here

(-)a/acqui/pdfformat/layout3pages.pm (-1 / +1 lines)
30	use utf8;	30	use utf8;
31		31
32	use Koha::Number::Price;	32	use Koha::Number::Price;
33	use Koha::DateUtils;	33	use Koha::DateUtils qw( dt_from_string output_pref );
34	use Koha::Libraries;	34	use Koha::Libraries;
35		35
36	our (@ISA, @EXPORT_OK);	36	our (@ISA, @EXPORT_OK);

Lines 29-35 use warnings; Link Here

(-)a/acqui/pdfformat/layout3pagesfr.pm (-1 / +1 lines)
29	use utf8;	29	use utf8;
30		30
31	use Koha::Number::Price;	31	use Koha::Number::Price;
32	use Koha::DateUtils;	32	use Koha::DateUtils qw( dt_from_string output_pref );
33	use Koha::Libraries;	33	use Koha::Libraries;
34		34
35	our (@ISA, @EXPORT_OK);	35	our (@ISA, @EXPORT_OK);

Lines 2-8 package TmplTokenizer; Link Here

(-)a/misc/translator/TmplTokenizer.pm (-2 / +1 lines)
2		2
3	use strict;	3	use strict;
4	#use warnings; FIXME - Bug 2505	4	#use warnings; FIXME - Bug 2505
5	use C4::TmplTokenType;	5	use C4::TmplTokenType qw( CDATA UNKNOWN DIRECTIVE TEXT TAG TEXT_PARAMETRIZED to_string );
6	use C4::TmplToken;	6	use C4::TmplToken;
7	use C4::TTParser;	7	use C4::TTParser;
8	use VerboseWarnings qw( pedantic_p error_normal warn_normal warn_pedantic );	8	use VerboseWarnings qw( pedantic_p error_normal warn_normal warn_pedantic );
9	-

Return to bug 17600

Lines 23-35 use Carp; Link Here

(-)a/C4/Auth_with_ldap.pm (-6 / +6 lines)
23		23
24	use C4::Debug;	24	use C4::Debug;
25	use C4::Context;	25	use C4::Context;
26	use C4::Members qw(AddMember);	26	use C4::Members qw( AddMember );
27	use C4::Members::Attributes;	27	use C4::Members qw( AddMember );
28	use C4::Members::AttributeTypes;	28	use C4::Members qw( AddMember );
29	use C4::Members::Messaging;	29	use C4::Members qw( AddMember );
30	use C4::Auth qw(checkpw_internal);	30	use C4::Auth qw( checkpw checkpw_internal );
31	use Koha::Patrons;	31	use Koha::Patrons;
32	use Koha::AuthUtils qw(hash_password);	32	use Koha::AuthUtils qw( hash_password );
33	use List::MoreUtils qw( any );	33	use List::MoreUtils qw( any );
34	use Net::LDAP;	34	use Net::LDAP;
35	use Net::LDAP::Filter;	35	use Net::LDAP::Filter;

Lines 20-31 use strict; Link Here

(-)a/C4/AuthoritiesMarc.pm (-4 / +4 lines)
20	use warnings;	20	use warnings;
21	use C4::Context;	21	use C4::Context;
22	use MARC::Record;	22	use MARC::Record;
23	use C4::Biblio;	23	use C4::Biblio qw( ModZebra GetMarcFromKohaField GetMarcBiblio ModBiblio GetFrameworkCode );
24	use C4::Search;	24	use C4::Search qw( FindDuplicate new_record_from_zebra );
25	use C4::AuthoritiesMarc::MARC21;	25	use C4::AuthoritiesMarc::MARC21;
26	use C4::AuthoritiesMarc::UNIMARC;	26	use C4::AuthoritiesMarc::UNIMARC;
27	use C4::Charset;	27	use C4::Charset qw( SetUTF8Flag );
28	use C4::Log;	28	use C4::Log qw( logaction );
29	use Koha::MetadataRecord::Authority;	29	use Koha::MetadataRecord::Authority;
30	use Koha::Authorities;	30	use Koha::Authorities;
31	use Koha::Authority::Types;	31	use Koha::Authority::Types;

Lines 29-43 use MARC::File::XML; Link Here

(-)a/C4/Biblio.pm (-5 / +5 lines)
29	use POSIX qw(strftime);	29	use POSIX qw(strftime);
30	use Module::Load::Conditional qw(can_load);	30	use Module::Load::Conditional qw(can_load);
31		31
32	use C4::Koha;	32	use C4::Koha qw( get_infos_of getitemtypeinfo );
33	use C4::Log; # logaction	33	use C4::Log qw( logaction );
34	use C4::Budgets;	34	use C4::Budgets;
35	use C4::ClassSource qw( GetClassSort );	35	use C4::ClassSource qw( GetClassSort );
36	use C4::Charset qw( SetUTF8Flag );	36	use C4::Charset qw( SetUTF8Flag SetMarcUnicodeFlag StripNonXmlChars nsb_clean );
37	use C4::Linker;	37	use C4::Linker;
38	use C4::OAI::Sets;	38	use C4::OAI::Sets qw( UpdateOAISetsBiblio );
39	use C4::Debug;	39	use C4::Debug;
40	use C4::Items;	40	use C4::Items qw( AddItem ModItem GetItem GetHiddenItemnumbers GetMarcItem );
41		41
42	use Koha::Caches;	42	use Koha::Caches;
43	use Koha::Authority::Types;	43	use Koha::Authority::Types;

Lines 21-33 package C4::Breeding; Link Here

(-)a/C4/Breeding.pm (-6 / +6 lines)
21	use strict;	21	use strict;
22	use warnings;	22	use warnings;
23		23
24	use C4::Biblio;	24	use C4::Biblio qw( AddBiblio TransformMarcToKoha TransformMarcToKohaOneField );
25	use C4::Koha;	25	use C4::Koha qw( GetNormalizedISBN );
26	use C4::Charset;	26	use C4::Charset qw( MarcToUTF8Record SetUTF8Flag );
27	use MARC::File::USMARC;	27	use MARC::File::USMARC;
28	use C4::ImportBatch;	28	use C4::ImportBatch qw( GetZ3950BatchId AddBiblioToBatch AddAuthToBatch );
29	use C4::AuthoritiesMarc; #GuessAuthTypeCode, FindDuplicateAuthority	29	use C4::AuthoritiesMarc qw( GetAuthorizedHeading GuessAuthTypeCode FindDuplicateAuthority ModAuthority );
30	use C4::Languages;	30	use C4::Languages qw( getlanguage );
31	use Koha::Database;	31	use Koha::Database;
32	use Koha::XSLT_Handler;	32	use Koha::XSLT_Handler;
33		33

Lines 22-53 package C4::Circulation; Link Here

(-)a/C4/Circulation.pm (-12 / +12 lines)
22	use strict;	22	use strict;
23	#use warnings; FIXME - Bug 2505	23	#use warnings; FIXME - Bug 2505
24	use DateTime;	24	use DateTime;
25	use Koha::DateUtils;	25	use Koha::DateUtils qw( dt_from_string output_pref );
26	use C4::Context;	26	use C4::Context;
27	use C4::Stats;	27	use C4::Stats qw( UpdateStats );
28	use C4::Reserves;	28	use C4::Reserves qw( CheckReserves CanItemBeReserved MoveReserve ModReserve ModReserveStatus IsItemOnHoldAndFound IsAvailableForItemLevelRequest );
29	use C4::Biblio;	29	use C4::Biblio qw( GetBiblio GetBiblioFromItemNumber GetBiblioItemData UpdateTotalIssues GetBiblioData );
30	use C4::Items;	30	use C4::Items qw( GetItem GetItemnumberFromBarcode ModItem ModItemTransfer ModDateLastSeen CartToShelf ShelfToCart );
31	use C4::Members;	31	use C4::Members qw( GetMemberDetails GetMember GetMemberAccountBalance GetAge );
32	use C4::Accounts;	32	use C4::Accounts qw( getnextacctno chargelostitem );
33	use C4::ItemCirculationAlertPreference;	33	use C4::ItemCirculationAlertPreference;
34	use C4::Message;	34	use C4::Message;
35	use C4::Debug;	35	use C4::Debug;
36	use C4::Log; # logaction	36	use C4::Log qw( logaction );
37	use C4::Overdues qw(CalcFine UpdateFine get_chargeable_units);	37	use C4::Overdues qw( UpdateFine get_chargeable_units CalcFine );
38	use C4::RotatingCollections qw(GetCollectionItemBranches);	38	use C4::RotatingCollections qw( isItemInAnyCollection );
39	use Algorithm::CheckDigits;	39	use Algorithm::CheckDigits;
40		40
41	use Data::Dumper;	41	use Data::Dumper;
42	use Koha::Account;	42	use Koha::Account;
43	use Koha::AuthorisedValues;	43	use Koha::AuthorisedValues;
44	use Koha::DateUtils;	44	use Koha::DateUtils qw( dt_from_string output_pref );
45	use Koha::Calendar;	45	use Koha::Calendar;
46	use Koha::Checkouts;	46	use Koha::Checkouts;
47	use Koha::IssuingRules;	47	use Koha::IssuingRules;
48	use Koha::Items;	48	use Koha::Items;
49	use Koha::Patrons;	49	use Koha::Patrons;
50	use Koha::Patron::Debarments;	50	use Koha::Patron::Debarments qw( GetDebarments DelUniqueDebarment AddUniqueDebarment );
51	use Koha::Database;	51	use Koha::Database;
52	use Koha::Libraries;	52	use Koha::Libraries;
53	use Koha::Holds;	53	use Koha::Holds;

Lines 20-39 package C4::ILSDI::Services; Link Here

(-)a/C4/ILSDI/Services.pm (-9 / +9 lines)
20	use strict;	20	use strict;
21	use warnings;	21	use warnings;
22		22
23	use C4::Members;	23	use C4::Members qw( GetMember GetPendingIssues );
24	use C4::Items;	24	use C4::Items qw( GetItem GetItemsByBiblioitemnumber );
25	use C4::Circulation;	25	use C4::Circulation qw( GetBiblioIssues CanBookBeRenewed barcodedecode decode CanBookBeIssued AddRenewal GetItemIssue );
26	use C4::Accounts;	26	use C4::Accounts qw( getcharges );
27	use C4::Biblio;	27	use C4::Biblio qw( GetBiblioItemByBiblioNumber GetBiblio GetMarcBiblio GetBiblioFromItemNumber );
28	use C4::Reserves qw(AddReserve GetReservesFromBorrowernumber CanBookBeReserved CanItemBeReserved IsAvailableForItemLevelRequest);	28	use C4::Reserves qw( GetReserve GetReservesFromBorrowernumber CanBookBeReserved IsAvailableForItemLevelRequest CalculatePriority AddReserve CanItemBeReserved CancelReserve );
29	use C4::Context;	29	use C4::Context;
30	use C4::AuthoritiesMarc;	30	use C4::Auth qw( checkpw );
31	use XML::Simple;	31	use XML::Simple;
32	use HTML::Entities;	32	use HTML::Entities;
33	use CGI qw ( -utf8 );	33	use CGI qw ( -utf8 );
34	use DateTime;	34	use DateTime;
35	use C4::Auth;	35	use C4::Auth qw( checkpw );
36	use C4::Members::Attributes qw(GetBorrowerAttributes);	36	use C4::Members qw( GetMember GetMemberDetails GetPendingIssues );
37		37
38	use Koha::Biblios;	38	use Koha::Biblios;
39	use Koha::Libraries;	39	use Koha::Libraries;

Lines 21-32 use strict; Link Here

(-)a/C4/ImportBatch.pm (-6 / +6 lines)
21	use warnings;	21	use warnings;
22		22
23	use C4::Context;	23	use C4::Context;
24	use C4::Koha;	24	use C4::Koha qw( GetNormalizedISBN );
25	use C4::Biblio;	25	use C4::Biblio qw( AddBiblio ModBiblio GetMarcFromKohaField GetBiblio GetXmlBiblio GetFrameworkCode TransformMarcToKoha DelBiblio );
26	use C4::Items;	26	use C4::Items qw( AddItem GetItem GetItemnumberFromBarcode ModItemFromMarc ModItem AddItemFromMarc DelItem DelItemCheck );
27	use C4::Charset;	27	use C4::Charset qw( SetUTF8Flag StripNonXmlChars MarcToUTF8Record );
28	use C4::AuthoritiesMarc;	28	use C4::AuthoritiesMarc qw( ModAuthority GuessAuthTypeCode AddAuthority GetAuthorityXML GetAuthority DelAuthority GetAuthorizedHeading );
29	use C4::MarcModificationTemplates;	29	use C4::MarcModificationTemplates qw( ModifyRecordWithTemplate );
30	use Koha::Plugins::Handler;	30	use Koha::Plugins::Handler;
31	use Koha::Logger;	31	use Koha::Logger;
32		32

Lines 23-34 use strict; Link Here

(-)a/C4/Items.pm (-6 / +6 lines)
23		23
24	use Carp;	24	use Carp;
25	use C4::Context;	25	use C4::Context;
26	use C4::Koha;	26	use C4::Koha qw( IsKohaFieldLinked get_infos_of GetItemTypes );
27	use C4::Biblio qw( GetFrameworkCode );	27	use C4::Biblio qw( GetFrameworkCode GetMarcFromKohaField TransformMarcToKoha ModZebra AddBiblio GetBiblionumberFromItemnumber GetBiblio GetMarcBiblio TransformKohaToMarc GetMarcStructure IsMarcStructureInternal );
28	use Koha::DateUtils;	28	use Koha::DateUtils qw( dt_from_string output_pref );
29	use MARC::Record;	29	use MARC::Record;
30	use C4::ClassSource;	30	use C4::ClassSource qw( GetClassSort GetClassSources GetClassSource );
31	use C4::Log;	31	use C4::Log qw( logaction );
32	use List::MoreUtils qw/any/;	32	use List::MoreUtils qw/any/;
33	use YAML qw/Load/;	33	use YAML qw/Load/;
34	use DateTime::Format::MySQL;	34	use DateTime::Format::MySQL;
Lines 36-42 use Data::Dumper; # used as part of logging item record changes, not just for Link Here
36	# debugging; so please don't remove this	36	# debugging; so please don't remove this
37		37
38	use Koha::AuthorisedValues;	38	use Koha::AuthorisedValues;
39	use Koha::DateUtils qw/dt_from_string/;	39	use Koha::DateUtils qw( dt_from_string output_pref );
40	use Koha::Database;	40	use Koha::Database;
41		41
42	use Koha::Biblioitems;	42	use Koha::Biblioitems;

Lines 27-42 use Carp; Link Here

(-)a/C4/Letters.pm (-5 / +5 lines)
27	use Template;	27	use Template;
28	use Module::Load::Conditional qw(can_load);	28	use Module::Load::Conditional qw(can_load);
29		29
30	use C4::Members;	30	use C4::Members qw( GetMember GetNoticeEmailAddress );
31	use C4::Members::Attributes qw(GetBorrowerAttributes);	31	use C4::Members qw( GetMember GetNoticeEmailAddress );
32	use C4::Log;	32	use C4::Log qw( logaction );
33	use C4::SMS;	33	use C4::SMS;
34	use C4::Debug;	34	use C4::Debug;
35	use Koha::DateUtils;	35	use Koha::DateUtils qw( format_sqldatetime dt_from_string output_pref );
36	use Koha::SMS::Providers;	36	use Koha::SMS::Providers;
37		37
38	use Koha::Email;	38	use Koha::Email;
39	use Koha::DateUtils qw( format_sqldatetime dt_from_string );	39	use Koha::DateUtils qw( format_sqldatetime dt_from_string output_pref );
40		40
41	our (@ISA, @EXPORT_OK);	41	our (@ISA, @EXPORT_OK);
42	BEGIN {	42	BEGIN {

Lines 26-44 use C4::Context; Link Here

(-)a/C4/Members.pm (-8 / +8 lines)
26	use String::Random qw( random_string );	26	use String::Random qw( random_string );
27	use Scalar::Util qw( looks_like_number );	27	use Scalar::Util qw( looks_like_number );
28	use Date::Calc qw/Today check_date Date_to_Days/;	28	use Date::Calc qw/Today check_date Date_to_Days/;
29	use C4::Log; # logaction	29	use C4::Log qw( logaction );
30	use C4::Overdues;	30	use C4::Overdues qw( checkoverdues );
31	use C4::Reserves;	31	use C4::Reserves qw( GetReserve GetReservesFromBorrowernumber );
32	use C4::Accounts;	32	use C4::Accounts;
33	use C4::Biblio;	33	use C4::Biblio qw( GetBiblioFromItemNumber GetBiblio );
34	use C4::Letters;	34	use C4::Letters qw( GetPreparedLetter );
35	use C4::Members::Attributes qw(SearchIdMatchingAttribute UpdateBorrowerAttribute);	35	use C4::Members::Attributes qw(SearchIdMatchingAttribute UpdateBorrowerAttribute);
36	use C4::NewsChannels; #get slip news	36	use C4::NewsChannels qw( GetNewsToDisplay );
37	use DateTime;	37	use DateTime;
38	use Koha::Database;	38	use Koha::Database;
39	use Koha::DateUtils;	39	use Koha::DateUtils qw( dt_from_string output_pref );
40	use Text::Unaccent qw( unac_string );	40	use Text::Unaccent qw( unac_string );
41	use Koha::AuthUtils qw(hash_password);	41	use Koha::AuthUtils qw( hash_password );
42	use Koha::Database;	42	use Koha::Database;
43	use Koha::Holds;	43	use Koha::Holds;
44	use Koha::List::Patron;	44	use Koha::List::Patron;

Lines 28-39 use POSIX qw( floor ceil ); Link Here

(-)a/C4/Overdues.pm (-4 / +4 lines)
28	use Locale::Currency::Format 1.28;	28	use Locale::Currency::Format 1.28;
29	use Carp;	29	use Carp;
30		30
31	use C4::Circulation;	31	use C4::Circulation qw( GetIssues );
32	use C4::Context;	32	use C4::Context;
33	use C4::Accounts;	33	use C4::Accounts qw( getnextacctno );
34	use C4::Log; # logaction	34	use C4::Log qw( logaction );
35	use C4::Debug;	35	use C4::Debug;
36	use Koha::DateUtils;	36	use Koha::DateUtils qw( dt_from_string output_pref );
37	use Koha::Account::Line;	37	use Koha::Account::Line;
38	use Koha::Account::Lines;	38	use Koha::Account::Lines;
39	use Koha::IssuingRules;	39	use Koha::IssuingRules;

Lines 28-40 use MARC::Record; # marc2marcxml, marcxml2marc, changeEncoding Link Here

(-)a/C4/Record.pm (-3 / +3 lines)
28	use MARC::File::XML; # marc2marcxml, marcxml2marc, changeEncoding	28	use MARC::File::XML; # marc2marcxml, marcxml2marc, changeEncoding
29	use Biblio::EndnoteStyle;	29	use Biblio::EndnoteStyle;
30	use Unicode::Normalize; # _entity_encode	30	use Unicode::Normalize; # _entity_encode
31	use C4::Biblio; #marc2bibtex	31	use C4::Biblio qw( GetXmlBiblio GetBiblionumberFromItemnumber GetBiblio GetMarcBiblio EmbedItemsInMarcBiblio GetFrameworkCode );
32	use C4::Koha; #marc2csv	32	use C4::Koha; #marc2csv
33	use C4::XSLT ();	33	use C4::XSLT qw( engine );
34	use YAML; #marcrecords2csv	34	use YAML; #marcrecords2csv
35	use Template;	35	use Template;
36	use Text::CSV::Encoded; #marc2csv	36	use Text::CSV::Encoded; #marc2csv
37	use Koha::SimpleMARC qw(read_field);	37	use Koha::SimpleMARC qw( delete_field read_field );
38	use Koha::XSLT_Handler;	38	use Koha::XSLT_Handler;
39	use Koha::CsvProfiles;	39	use Koha::CsvProfiles;
40	use Koha::AuthorisedValues;	40	use Koha::AuthorisedValues;

Lines 24-42 package C4::Reserves; Link Here

(-)a/C4/Reserves.pm (-10 / +10 lines)
24	use strict;	24	use strict;
25	#use warnings; FIXME - Bug 2505	25	#use warnings; FIXME - Bug 2505
26	use C4::Context;	26	use C4::Context;
27	use C4::Biblio;	27	use C4::Biblio qw( GetBiblioData GetBiblio );
28	use C4::Members;	28	use C4::Members qw( GetMember GetAge GetNoticeEmailAddress );
29	use C4::Items;	29	use C4::Items qw( GetItem GetItemnumbersForBiblio get_hostitemnumbers_of ModItem ModItemTransfer CartToShelf );
30	use C4::Circulation;	30	use C4::Circulation qw( GetAgeRestriction _GetCircControlBranch GetBranchItemRule );
31	use C4::Accounts;	31	use C4::Accounts qw( getnextacctno manualinvoice );
32		32
33	# for _koha_notify_reserve	33	# for _koha_notify_reserve
34	use C4::Members::Messaging;	34	use C4::Members qw( GetMember GetAge GetNoticeEmailAddress );
35	use C4::Members qw();	35	use C4::Members qw( GetMember GetAge GetNoticeEmailAddress );
36	use C4::Letters;	36	use C4::Letters qw( GetPreparedLetter EnqueueLetter );
37	use C4::Log;	37	use C4::Log qw( logaction );
38		38
39	use Koha::DateUtils;	39	use Koha::DateUtils qw( dt_from_string output_pref );
40	use Koha::Calendar;	40	use Koha::Calendar;
41	use Koha::Database;	41	use Koha::Database;
42	use Koha::Hold;	42	use Koha::Hold;

Lines 19-35 use strict; Link Here

(-)a/C4/Search.pm (-6 / +6 lines)
19	#use warnings; FIXME - Bug 2505	19	#use warnings; FIXME - Bug 2505
20		20
21	use C4::Context;	21	use C4::Context;
22	use C4::Biblio; # GetMarcFromKohaField, GetBiblioData	22	use C4::Biblio qw( TransformMarcToKoha GetMarcFromKohaField GetFrameworkCode GetRecordValue GetMarcBiblio GetAuthorisedValueDesc GetBiblioData GetBiblio );
23	use C4::Koha; # getFacets	23	use C4::Koha qw( getFacets GetVariationsOfISBN GetItemTypes getitemtypeimagelocation GetNormalizedUPC GetNormalizedEAN GetNormalizedOCLCNumber GetNormalizedISBN );
24	use Koha::DateUtils;	24	use Koha::DateUtils qw( dt_from_string output_pref );
25	use Koha::Libraries;	25	use Koha::Libraries;
26	use Lingua::Stem;	26	use Lingua::Stem;
27	use C4::Search::PazPar2;	27	use C4::Search::PazPar2;
28	use XML::Simple;	28	use XML::Simple;
29	use C4::XSLT;	29	use C4::XSLT qw( get_xslt_sysprefs XSLTParse4Display engine );
30	use C4::Reserves; # GetReserveStatus	30	use C4::Reserves qw( GetReserve GetReserveStatus );
31	use C4::Debug;	31	use C4::Debug;
32	use C4::Charset;	32	use C4::Charset qw( SetUTF8Flag );
33	use Koha::AuthorisedValues;	33	use Koha::AuthorisedValues;
34	use Koha::Libraries;	34	use Koha::Libraries;
35	use Koha::Patrons;	35	use Koha::Patrons;

Lines 20-37 package C4::Serials; Link Here

(-)a/C4/Serials.pm (-6 / +6 lines)
20		20
21	use Modern::Perl;	21	use Modern::Perl;
22		22
23	use C4::Auth qw(haspermission);	23	use C4::Auth qw( haspermission );
24	use C4::Context;	24	use C4::Context;
25	use DateTime;	25	use DateTime;
26	use Date::Calc qw(:all);	26	use Date::Calc qw(:all);
27	use POSIX qw(strftime);	27	use POSIX qw(strftime);
28	use C4::Biblio;	28	use C4::Biblio qw( GetBiblio GetMarcBiblio GetMarcFromKohaField ModBiblio );
29	use C4::Log; # logaction	29	use C4::Log qw( logaction );
30	use C4::Debug;	30	use C4::Debug;
31	use C4::Serials::Frequency;	31	use C4::Serials::Frequency qw( GetSubscriptionFrequency );
32	use C4::Serials::Numberpattern;	32	use C4::Serials::Numberpattern qw( GetSubscriptionNumberpattern );
33	use Koha::AdditionalField;	33	use Koha::AdditionalField;
34	use Koha::DateUtils;	34	use Koha::DateUtils qw( dt_from_string output_pref );
35	use Koha::Serial;	35	use Koha::Serial;
36	use Koha::Subscriptions;	36	use Koha::Subscriptions;
37	use Koha::Subscription::Histories;	37	use Koha::Subscription::Histories;