Attachment #64786 for bug #18434

View | Details | Raw Unified | Return to bug 18434
Collapse All | Expand All




# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>

use Modern::Perl;
use warnings;

use Test::More tests => 2;
use Test::MockModule;

use t::lib::Mocks;
use MARC::Record;
use Koha::SearchEngine::Elasticsearch::Indexer;
use JSON::XS;

my $schema = Koha::Database->schema;

use_ok('Koha::SearchEngine::Elasticsearch');

subtest 'get_fixer_rules() tests' => sub {

    plan tests => 47;

    $schema->storage->txn_begin;

    t::lib::Mocks::mock_preference( 'marcflavour', 'MARC21' );

    my @mappings;

    my $se = Test::MockModule->new( 'Koha::SearchEngine::Elasticsearch' );
    $se->mock( '_foreach_mapping', sub {
        my ($self, $sub ) = @_;

        foreach my $map ( @mappings ) {
            $sub->(
                $map->{name},
                $map->{type},
                $map->{facet},
                $map->{suggestible},
                $map->{sort},
                $map->{marc_type},
                $map->{marc_field}
            );
        }
    });

    my $see = Koha::SearchEngine::Elasticsearch->new({ index => 'biblios' });

    @mappings = (
        {
            name => 'author',
            type => 'string',
            facet => 1,
            suggestible => 1,
            sort => '~',
            marc_type => 'marc21',
            marc_field => '100a',
        },
        {
            name => 'author',
            type => 'string',
            facet => 1,
            suggestible => 1,
            sort => '~',
            marc_type => 'marc21',
            marc_field => '110a',
        },
    );

    my $marc_record = MARC::Record->new();
    $marc_record->append_fields(
        MARC::Field->new( '001', '1234567' ),
        MARC::Field->new( '020', '', '', 'a' => '1234567890123' ),
        MARC::Field->new( '100', '', '', 'a' => 'Author' ),
        MARC::Field->new( '110', '', '', 'a' => 'Corp Author' ),
        MARC::Field->new( '245', '', '', 'a' => 'Title' ),
    );
    my @records = ( $marc_record );

    my $importer = Koha::SearchEngine::Elasticsearch::Indexer->new({ index => 'biblios' });
    my $conv = $importer->_convert_marc_to_json( \@records )->next();
    is( $conv->{author}[0][0], "Author", "First mapped author should be 100a");
    is( $conv->{author}[1][0], "Corp Author", "Second mapped author should be 110a");

    my $result = $see->get_fixer_rules();
    is( $result->[0], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{.$append', -split => 1)});
    is( $result->[1], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__facet', -split => 1)});
    is( $result->[2], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__suggestion.input.$append')});
    is( $result->[3], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__sort', -split => 1)});
    is( $result->[4], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{.$append', -split => 1)});
    is( $result->[5], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__facet', -split => 1)});
    is( $result->[6], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__suggestion.input.$append')});
    is( $result->[7], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__sort', -split => 1)});
    is( $result->[8], q{move_field(_id,es_id)});

    $mappings[0]->{type}  = 'boolean';
    $mappings[1]->{type}  = 'boolean';
    $result = $see->get_fixer_rules();
    is( $result->[0], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{.$append', -split => 1)});
    is( $result->[1], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__facet', -split => 1)});
    is( $result->[2], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__suggestion.input.$append')});
    is( $result->[3], q{unless exists('} . $mappings[0]->{name} . q{') add_field('} . $mappings[0]->{name} . q{', 0) end});
    is( $result->[4], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__sort', -split => 1)});
    is( $result->[5], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{.$append', -split => 1)});
    is( $result->[6], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__facet', -split => 1)});
    is( $result->[7], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__suggestion.input.$append')});
    is( $result->[8], q{unless exists('} . $mappings[1]->{name} . q{') add_field('} . $mappings[1]->{name} . q{', 0) end});
    is( $result->[9], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__sort', -split => 1)});
    is( $result->[10], q{move_field(_id,es_id)});

    $mappings[0]->{type}  = 'sum';
    $mappings[1]->{type}  = 'sum';
    $result = $see->get_fixer_rules();
    is( $result->[0], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{.$append', )});
    is( $result->[1], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__facet', )});
    is( $result->[2], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__suggestion.input.$append')});
    is( $result->[3], q{sum('} . $mappings[0]->{name} . q{')});
    is( $result->[4], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__sort', )});
    is( $result->[5], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{.$append', )});
    is( $result->[6], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__facet', )});
    is( $result->[7], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__suggestion.input.$append')});
    is( $result->[8], q{sum('} . $mappings[1]->{name} . q{')});
    is( $result->[9], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__sort', )});
    is( $result->[10], q{move_field(_id,es_id)});

    $mappings[0]->{type}  = 'string';
    $mappings[0]->{facet} = 0;
    $mappings[1]->{type}  = 'string';
    $mappings[1]->{facet} = 0;

    $result = $see->get_fixer_rules();
    is( $result->[0], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{.$append', -split => 1)});
    is( $result->[1], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__suggestion.input.$append')});
    is( $result->[2], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__sort', -split => 1)});
    is( $result->[3], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{.$append', -split => 1)});
    is( $result->[4], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__suggestion.input.$append')});
    is( $result->[5], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__sort', -split => 1)});
    is( $result->[6], q{move_field(_id,es_id)});

    $mappings[0]->{suggestible}  = 0;
    $mappings[1]->{suggestible}  = 0;

    $result = $see->get_fixer_rules();
    is( $result->[0], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{.$append', -split => 1)});
    is( $result->[1], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__sort', -split => 1)});
    is( $result->[2], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{.$append', -split => 1)});
    is( $result->[3], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__sort', -split => 1)});
    is( $result->[4], q{move_field(_id,es_id)});

    t::lib::Mocks::mock_preference( 'marcflavour', 'UNIMARC' );

    $result = $see->get_fixer_rules();
    is( $result->[0], q{move_field(_id,es_id)});
    is( $result->[1], undef, q{No mapping when marc_type doesn't match marchflavour} );

    $schema->storage->txn_rollback;

};

1;

Return to bug 18434

Lines 15-23 Link Here

(-)a/t/db_dependent/Koha_Elasticsearch.t (-4 / +152 lines)
15	# You should have received a copy of the GNU General Public License	15	# You should have received a copy of the GNU General Public License
16	# along with Koha; if not, see <http://www.gnu.org/licenses>	16	# along with Koha; if not, see <http://www.gnu.org/licenses>
17		17
18	use strict;	18	use Modern::Perl;
19	use warnings;
20		19
21	use Test::More tests => 1; # last test to print	20	use Test::More tests => 2;
		21	use Test::MockModule;
		22
		23	use t::lib::Mocks;
		24	use MARC::Record;
		25	use Koha::SearchEngine::Elasticsearch::Indexer;
		26	use JSON::XS;
		27
		28	my $schema = Koha::Database->schema;
22		29
23	use_ok('Koha::SearchEngine::Elasticsearch');	30	use_ok('Koha::SearchEngine::Elasticsearch');
24	-	31
		32	subtest 'get_fixer_rules() tests' => sub {
		33
		34	plan tests => 47;
		35
		36	$schema->storage->txn_begin;
		37
		38	t::lib::Mocks::mock_preference( 'marcflavour', 'MARC21' );
		39
		40	my @mappings;
		41
		42	my $se = Test::MockModule->new( 'Koha::SearchEngine::Elasticsearch' );
		43	$se->mock( '_foreach_mapping', sub {
		44	my ($self, $sub ) = @_;
		45
		46	foreach my $map ( @mappings ) {
		47	$sub->(
		48	$map->{name},
		49	$map->{type},
		50	$map->{facet},
		51	$map->{suggestible},
		52	$map->{sort},
		53	$map->{marc_type},
		54	$map->{marc_field}
		55	);
		56	}
		57	});
		58
		59	my $see = Koha::SearchEngine::Elasticsearch->new({ index => 'biblios' });
		60
		61	@mappings = (
		62	{
		63	name => 'author',
		64	type => 'string',
		65	facet => 1,
		66	suggestible => 1,
		67	sort => '~',
		68	marc_type => 'marc21',
		69	marc_field => '100a',
		70	},
		71	{
		72	name => 'author',
		73	type => 'string',
		74	facet => 1,
		75	suggestible => 1,
		76	sort => '~',
		77	marc_type => 'marc21',
		78	marc_field => '110a',
		79	},
		80	);
		81
		82	my $marc_record = MARC::Record->new();
		83	$marc_record->append_fields(
		84	MARC::Field->new( '001', '1234567' ),
		85	MARC::Field->new( '020', '', '', 'a' => '1234567890123' ),
		86	MARC::Field->new( '100', '', '', 'a' => 'Author' ),
		87	MARC::Field->new( '110', '', '', 'a' => 'Corp Author' ),
		88	MARC::Field->new( '245', '', '', 'a' => 'Title' ),
		89	);
		90	my @records = ( $marc_record );
		91
		92	my $importer = Koha::SearchEngine::Elasticsearch::Indexer->new({ index => 'biblios' });
		93	my $conv = $importer->_convert_marc_to_json( \@records )->next();
		94	is( $conv->{author}[0][0], "Author", "First mapped author should be 100a");
		95	is( $conv->{author}[1][0], "Corp Author", "Second mapped author should be 110a");
96
97	my $result = $see->get_fixer_rules();
98	is( $result->[0], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{.$append', -split => 1)});
99	is( $result->[1], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__facet', -split => 1)});
100	is( $result->[2], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__suggestion.input.$append')});
101	is( $result->[3], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__sort', -split => 1)});
102	is( $result->[4], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{.$append', -split => 1)});
103	is( $result->[5], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__facet', -split => 1)});
104	is( $result->[6], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__suggestion.input.$append')});
105	is( $result->[7], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__sort', -split => 1)});
106	is( $result->[8], q{move_field(_id,es_id)});
107
108	$mappings[0]->{type} = 'boolean';
109	$mappings[1]->{type} = 'boolean';
110	$result = $see->get_fixer_rules();
111	is( $result->[0], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{.$append', -split => 1)});
112	is( $result->[1], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__facet', -split => 1)});
113	is( $result->[2], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__suggestion.input.$append')});
114	is( $result->[3], q{unless exists('} . $mappings[0]->{name} . q{') add_field('} . $mappings[0]->{name} . q{', 0) end});
115	is( $result->[4], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__sort', -split => 1)});
116	is( $result->[5], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{.$append', -split => 1)});
117	is( $result->[6], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__facet', -split => 1)});
118	is( $result->[7], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__suggestion.input.$append')});
119	is( $result->[8], q{unless exists('} . $mappings[1]->{name} . q{') add_field('} . $mappings[1]->{name} . q{', 0) end});
120	is( $result->[9], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__sort', -split => 1)});
121	is( $result->[10], q{move_field(_id,es_id)});
122
123	$mappings[0]->{type} = 'sum';
124	$mappings[1]->{type} = 'sum';
125	$result = $see->get_fixer_rules();
126	is( $result->[0], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{.$append', )});
127	is( $result->[1], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__facet', )});
128	is( $result->[2], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__suggestion.input.$append')});
129	is( $result->[3], q{sum('} . $mappings[0]->{name} . q{')});
130	is( $result->[4], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__sort', )});
131	is( $result->[5], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{.$append', )});
132	is( $result->[6], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__facet', )});
133	is( $result->[7], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__suggestion.input.$append')});
134	is( $result->[8], q{sum('} . $mappings[1]->{name} . q{')});
135	is( $result->[9], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__sort', )});
136	is( $result->[10], q{move_field(_id,es_id)});
137
138	$mappings[0]->{type} = 'string';
139	$mappings[0]->{facet} = 0;
140	$mappings[1]->{type} = 'string';
141	$mappings[1]->{facet} = 0;
142
143	$result = $see->get_fixer_rules();
144	is( $result->[0], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{.$append', -split => 1)});
145	is( $result->[1], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__suggestion.input.$append')});
146	is( $result->[2], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__sort', -split => 1)});
147	is( $result->[3], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{.$append', -split => 1)});
148	is( $result->[4], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__suggestion.input.$append')});
149	is( $result->[5], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__sort', -split => 1)});
150	is( $result->[6], q{move_field(_id,es_id)});
151
152	$mappings[0]->{suggestible} = 0;
153	$mappings[1]->{suggestible} = 0;
154
155	$result = $see->get_fixer_rules();
156	is( $result->[0], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{.$append', -split => 1)});
157	is( $result->[1], q{marc_map('} . $mappings[0]->{marc_field} . q{','} . $mappings[0]->{name} . q{__sort', -split => 1)});
158	is( $result->[2], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{.$append', -split => 1)});
159	is( $result->[3], q{marc_map('} . $mappings[1]->{marc_field} . q{','} . $mappings[1]->{name} . q{__sort', -split => 1)});
160	is( $result->[4], q{move_field(_id,es_id)});
161
162	t::lib::Mocks::mock_preference( 'marcflavour', 'UNIMARC' );
163
164	$result = $see->get_fixer_rules();
165	is( $result->[0], q{move_field(_id,es_id)});
166	is( $result->[1], undef, q{No mapping when marc_type doesn't match marchflavour} );
167
168	$schema->storage->txn_rollback;
169
170	};
171
172	1;