|
Lines 17-23
Link Here
|
| 17 |
|
17 |
|
| 18 |
use Modern::Perl; |
18 |
use Modern::Perl; |
| 19 |
|
19 |
|
| 20 |
use Test::More tests => 21; |
20 |
use Test::More tests => 39; |
| 21 |
use Test::Mojo; |
21 |
use Test::Mojo; |
| 22 |
use t::lib::TestBuilder; |
22 |
use t::lib::TestBuilder; |
| 23 |
use t::lib::Mocks; |
23 |
use t::lib::Mocks; |
|
Lines 25-30
use t::lib::Mocks;
Link Here
|
| 25 |
use C4::Auth; |
25 |
use C4::Auth; |
| 26 |
use C4::Context; |
26 |
use C4::Context; |
| 27 |
|
27 |
|
|
|
28 |
use Koha::AuthUtils; |
| 28 |
use Koha::Database; |
29 |
use Koha::Database; |
| 29 |
use Koha::Patron; |
30 |
use Koha::Patron; |
| 30 |
|
31 |
|
|
Lines 42-47
my $t = Test::Mojo->new('Koha::REST::V1');
Link Here
|
| 42 |
|
43 |
|
| 43 |
my $categorycode = $builder->build({ source => 'Category' })->{ categorycode }; |
44 |
my $categorycode = $builder->build({ source => 'Category' })->{ categorycode }; |
| 44 |
my $branchcode = $builder->build({ source => 'Branch' })->{ branchcode }; |
45 |
my $branchcode = $builder->build({ source => 'Branch' })->{ branchcode }; |
|
|
46 |
|
| 45 |
my $guarantor = $builder->build({ |
47 |
my $guarantor = $builder->build({ |
| 46 |
source => 'Borrower', |
48 |
source => 'Borrower', |
| 47 |
value => { |
49 |
value => { |
|
Lines 50-55
my $guarantor = $builder->build({
Link Here
|
| 50 |
flags => 0, |
52 |
flags => 0, |
| 51 |
} |
53 |
} |
| 52 |
}); |
54 |
}); |
|
|
55 |
|
| 56 |
my $password = "secret"; |
| 53 |
my $borrower = $builder->build({ |
57 |
my $borrower = $builder->build({ |
| 54 |
source => 'Borrower', |
58 |
source => 'Borrower', |
| 55 |
value => { |
59 |
value => { |
|
Lines 86-91
$tx->req->cookies({name => 'CGISESSID', value => $session->id});
Link Here
|
| 86 |
$t->request_ok($tx) |
90 |
$t->request_ok($tx) |
| 87 |
->status_is(403); |
91 |
->status_is(403); |
| 88 |
|
92 |
|
|
|
93 |
|
| 89 |
$tx = $t->ua->build_tx(GET => "/api/v1/patrons/" . ($borrower->{ borrowernumber }-1)); |
94 |
$tx = $t->ua->build_tx(GET => "/api/v1/patrons/" . ($borrower->{ borrowernumber }-1)); |
| 90 |
$tx->req->cookies({name => 'CGISESSID', value => $session->id}); |
95 |
$tx->req->cookies({name => 'CGISESSID', value => $session->id}); |
| 91 |
$t->request_ok($tx) |
96 |
$t->request_ok($tx) |
|
Lines 105-116
$t->request_ok($tx)
Link Here
|
| 105 |
->status_is(200) |
110 |
->status_is(200) |
| 106 |
->json_is('/guarantorid', $guarantor->{borrowernumber}); |
111 |
->json_is('/guarantorid', $guarantor->{borrowernumber}); |
| 107 |
|
112 |
|
|
|
113 |
my $password_obj = { |
| 114 |
current_password => $password, |
| 115 |
new_password => "new password", |
| 116 |
}; |
| 117 |
|
| 118 |
$tx = $t->ua->build_tx(PATCH => '/api/v1/patrons/-100/password' => json => $password_obj); |
| 119 |
$t->request_ok($tx) |
| 120 |
->status_is(401); |
| 121 |
|
| 122 |
$tx = $t->ua->build_tx(PATCH => '/api/v1/patrons/'.$borrower->{borrowernumber}.'/password'); |
| 123 |
$tx->req->cookies({name => 'CGISESSID', value => $session->id}); |
| 124 |
$t->request_ok($tx) |
| 125 |
->status_is(400); |
| 126 |
|
| 127 |
$tx = $t->ua->build_tx(PATCH => '/api/v1/patrons/'.$guarantor->{borrowernumber}.'/password' => json => $password_obj); |
| 128 |
$tx->req->cookies({name => 'CGISESSID', value => $session->id}); |
| 129 |
$t->request_ok($tx) |
| 130 |
->status_is(403); |
| 131 |
|
| 108 |
my $loggedinuser = $builder->build({ |
132 |
my $loggedinuser = $builder->build({ |
| 109 |
source => 'Borrower', |
133 |
source => 'Borrower', |
| 110 |
value => { |
134 |
value => { |
| 111 |
branchcode => $branchcode, |
135 |
branchcode => $branchcode, |
| 112 |
categorycode => $categorycode, |
136 |
categorycode => $categorycode, |
| 113 |
flags => 16 # borrowers flag |
137 |
flags => 16, # borrowers flag |
|
|
138 |
password => Koha::AuthUtils::hash_password($password), |
| 114 |
} |
139 |
} |
| 115 |
}); |
140 |
}); |
| 116 |
|
141 |
|
|
Lines 135-138
$t->request_ok($tx)
Link Here
|
| 135 |
->json_is('/surname' => $borrower->{ surname }) |
160 |
->json_is('/surname' => $borrower->{ surname }) |
| 136 |
->json_is('/lost' => Mojo::JSON->true ); |
161 |
->json_is('/lost' => Mojo::JSON->true ); |
| 137 |
|
162 |
|
|
|
163 |
$tx = $t->ua->build_tx(PATCH => '/api/v1/patrons/-100/password' => json => $password_obj); |
| 164 |
$tx->req->cookies({name => 'CGISESSID', value => $session->id}); |
| 165 |
$t->request_ok($tx) |
| 166 |
->status_is(404); |
| 167 |
|
| 168 |
$tx = $t->ua->build_tx(PATCH => '/api/v1/patrons/'.$loggedinuser->{borrowernumber}.'/password' => json => $password_obj); |
| 169 |
$tx->req->cookies({name => 'CGISESSID', value => $session->id}); |
| 170 |
$t->request_ok($tx) |
| 171 |
->status_is(200); |
| 172 |
|
| 173 |
ok(C4::Auth::checkpw_hash($password_obj->{'new_password'}, Koha::Patrons->find($loggedinuser->{borrowernumber})->password), "New password in database."); |
| 174 |
is(C4::Auth::checkpw_hash($password_obj->{'current_password'}, Koha::Patrons->find($loggedinuser->{borrowernumber})->password), "", "Old password is gone."); |
| 175 |
|
| 176 |
$password_obj->{'current_password'} = $password_obj->{'new_password'}; |
| 177 |
$password_obj->{'new_password'} = "a"; |
| 178 |
t::lib::Mocks::mock_preference("minPasswordLength", 5); |
| 179 |
$tx = $t->ua->build_tx(PATCH => '/api/v1/patrons/'.$loggedinuser->{borrowernumber}.'/password' => json => $password_obj); |
| 180 |
$tx->req->cookies({name => 'CGISESSID', value => $session->id}); |
| 181 |
$t->request_ok($tx) |
| 182 |
->status_is(400) |
| 183 |
->json_like('/error', qr/Password is too short/, "Password too short"); |
| 184 |
|
| 185 |
$password_obj->{'new_password'} = " abcdef "; |
| 186 |
$tx = $t->ua->build_tx(PATCH => '/api/v1/patrons/'.$loggedinuser->{borrowernumber}.'/password' => json => $password_obj); |
| 187 |
$tx->req->cookies({name => 'CGISESSID', value => $session->id}); |
| 188 |
$t->request_ok($tx) |
| 189 |
->status_is(400) |
| 190 |
->json_is('/error', "Password cannot contain trailing whitespaces."); |
| 191 |
|
| 138 |
$schema->storage->txn_rollback; |
192 |
$schema->storage->txn_rollback; |
| 139 |
- |
|
|