|
Lines 17-23
Link Here
|
| 17 |
|
17 |
|
| 18 |
use Modern::Perl; |
18 |
use Modern::Perl; |
| 19 |
|
19 |
|
| 20 |
use Test::More tests => 118; |
20 |
use Test::More tests => 120; |
| 21 |
|
21 |
|
| 22 |
use DateTime; |
22 |
use DateTime; |
| 23 |
use POSIX qw( floor ); |
23 |
use POSIX qw( floor ); |
|
Lines 231-236
C4::Context->dbh->do("DELETE FROM accountlines");
Link Here
|
| 231 |
my $title = 'Silence in the library'; |
231 |
my $title = 'Silence in the library'; |
| 232 |
my ($biblionumber, $biblioitemnumber) = add_biblio($title, 'Moffat, Steven'); |
232 |
my ($biblionumber, $biblioitemnumber) = add_biblio($title, 'Moffat, Steven'); |
| 233 |
|
233 |
|
|
|
234 |
|
| 234 |
my $barcode = 'R00000342'; |
235 |
my $barcode = 'R00000342'; |
| 235 |
my $branch = $library2->{branchcode}; |
236 |
my $branch = $library2->{branchcode}; |
| 236 |
|
237 |
|
|
Lines 337-342
C4::Context->dbh->do("DELETE FROM accountlines");
Link Here
|
| 337 |
my $borrowing_borrowernumber = Koha::Checkouts->find( { itemnumber => $itemnumber } )->borrowernumber; |
338 |
my $borrowing_borrowernumber = Koha::Checkouts->find( { itemnumber => $itemnumber } )->borrowernumber; |
| 338 |
is ($borrowing_borrowernumber, $renewing_borrowernumber, "Item checked out to $renewing_borrower->{firstname} $renewing_borrower->{surname}"); |
339 |
is ($borrowing_borrowernumber, $renewing_borrowernumber, "Item checked out to $renewing_borrower->{firstname} $renewing_borrower->{surname}"); |
| 339 |
|
340 |
|
|
|
341 |
t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary'); |
| 340 |
my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1); |
342 |
my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1); |
| 341 |
is( $renewokay, 1, 'Can renew, no holds for this title or item'); |
343 |
is( $renewokay, 1, 'Can renew, no holds for this title or item'); |
| 342 |
|
344 |
|
|
Lines 1162-1167
C4::Context->dbh->do("DELETE FROM accountlines");
Link Here
|
| 1162 |
} |
1164 |
} |
| 1163 |
|
1165 |
|
| 1164 |
{ |
1166 |
{ |
|
|
1167 |
# Don't allow renewing on reserve period with PreventCheckoutOnSameReservePeriod enabled |
| 1168 |
t::lib::Mocks::mock_preference( 'PreventCheckoutOnSameReservePeriod', 1 ); |
| 1169 |
|
| 1170 |
my $start_issue_dt = DateTime->now(); |
| 1171 |
$start_issue_dt->subtract( days => 15); |
| 1172 |
my $due_date = $start_issue_dt->clone; |
| 1173 |
$due_date->add( days => 17 ); |
| 1174 |
|
| 1175 |
my $biblio = $builder->build({ |
| 1176 |
source => 'Biblio', |
| 1177 |
}); |
| 1178 |
my $biblionumber = $biblio->{biblionumber}; |
| 1179 |
|
| 1180 |
my $item = $builder->build({ |
| 1181 |
source => 'Item', |
| 1182 |
value => { |
| 1183 |
biblionumber => $biblionumber |
| 1184 |
} |
| 1185 |
}); |
| 1186 |
my $itemnumber = $item->{itemnumber}; |
| 1187 |
|
| 1188 |
my $issue = $builder->build({ |
| 1189 |
source => 'Issue', |
| 1190 |
value => { |
| 1191 |
itemnumber => $itemnumber, |
| 1192 |
biblionumber => $biblionumber, |
| 1193 |
issuedate => $start_issue_dt->ymd, |
| 1194 |
date_due => $due_date->ymd, |
| 1195 |
onsite_checkout => 0 |
| 1196 |
} |
| 1197 |
}); |
| 1198 |
|
| 1199 |
my $reservedate = $due_date->clone; |
| 1200 |
$reservedate->add( days => 5 ); |
| 1201 |
my $expirationdate = $reservedate->clone; |
| 1202 |
$expirationdate->add( days => 15 ); |
| 1203 |
$builder->build({ |
| 1204 |
source => 'Reserve', |
| 1205 |
value => { |
| 1206 |
biblionumber => $biblionumber, |
| 1207 |
itemnumber => $itemnumber, |
| 1208 |
reservedate => $reservedate->ymd, |
| 1209 |
expirationdate => $expirationdate->ymd |
| 1210 |
} |
| 1211 |
}); |
| 1212 |
|
| 1213 |
my $requested_date_due = $due_date->clone; |
| 1214 |
$requested_date_due->add( days => 4 ); |
| 1215 |
my ( $renewed, $error ) = CanBookBeRenewed( $issue->{borrowernumber}, $itemnumber, 1, $requested_date_due ); |
| 1216 |
is( $renewed, 1, 'CanBookBeRenewed should allow to renew if no reserve date overlap' ); |
| 1217 |
|
| 1218 |
$requested_date_due->add( days => 2 ); |
| 1219 |
( $renewed, $error ) = CanBookBeRenewed( $issue->{borrowernumber}, $itemnumber, 1, $requested_date_due ); |
| 1220 |
is( $renewed, 0, 'CanBookBeRenewed should not allow to renew if reserve date overlap' ); |
| 1221 |
|
| 1222 |
t::lib::Mocks::mock_preference( 'PreventCheckoutOnSameReservePeriod', 0 ); |
| 1223 |
} |
| 1224 |
|
| 1225 |
{ |
| 1165 |
my $library = $builder->build({ source => 'Branch' }); |
1226 |
my $library = $builder->build({ source => 'Branch' }); |
| 1166 |
|
1227 |
|
| 1167 |
my ($biblionumber, $biblioitemnumber) = add_biblio(); |
1228 |
my ($biblionumber, $biblioitemnumber) = add_biblio(); |
| 1168 |
- |
|
|