Attachment #84731 for bug #21756

View | Details | Raw Unified | Return to bug 21756
Collapse All | Expand All




        C4::Context->set_preference('OPACFineNoRenewalsBlockAutoRenew','1');
        C4::Context->set_preference('OPACFineNoRenewals','10');
        my $fines_amount = 5;
        my $account = Koha::Account->new({patron_id => $renewing_borrowernumber});
        $account->add_debit(
            {
                amount      => $fines_amount,
                type        => 'fine',
                item_id     => $item_to_auto_renew->{itemnumber},
                description => "Some fines"
            }
        )->accounttype->('F')->store;
        ( $renewokay, $error ) =
          CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );
        is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 5' );

        $account->add_debit(
            {
                amount      => $fines_amount,
                type        => 'fine',
                item_id     => $item_to_auto_renew->{itemnumber},
                description => "Some fines"
            }
        )->accounttype->('F')->store;
        ( $renewokay, $error ) =
          CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );
        is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 10' );

        $account->add_debit(
            {
                amount      => $fines_amount,
                type        => 'fine',
                item_id     => $item_to_auto_renew->{itemnumber},
                description => "Some fines"
            }
        )->accounttype->('F')->store;
        ( $renewokay, $error ) =
          CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );




use t::lib::TestBuilder;
use t::lib::Mocks;

use C4::Accounts qw( manualinvoice );
use C4::Circulation qw( CanBookBeIssued );
use Koha::Account;
use Koha::Account::Lines;
use Koha::Account::Offsets;


my ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->{barcode} );
is( $issuingimpossible->{DEBT_GUARANTEES}, undef, "Patron can check out item" );

my $account = Koha::Account->new( { patron_id => $guarantee->{borrowernumber} } );
$account->add_debit({ amount => 10.00, type => 'lost_item' });
( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->{barcode} );
is( $issuingimpossible->{DEBT_GUARANTEES} + 0, '10.00' + 0, "Patron cannot check out item due to debt for guarantee" );


Lines 25-31 use Test::Warn; Link Here

(-)a/t/db_dependent/api/v1/patrons_accounts.t (-2 lines)
25	use t::lib::TestBuilder;	25	use t::lib::TestBuilder;
26	use t::lib::Mocks;	26	use t::lib::Mocks;
27		27
28	use C4::Accounts qw(manualinvoice);
29	use C4::Auth;	28	use C4::Auth;
30	use Koha::Account::Line;	29	use Koha::Account::Line;
31		30
32	-

Return to bug 21756

Lines 659-677 my ( $reused_itemnumber_1, $reused_itemnumber_2 ); Link Here

(-)a/t/db_dependent/Circulation.t (-3 / +25 lines)
659	C4::Context->set_preference('OPACFineNoRenewalsBlockAutoRenew','1');	659	C4::Context->set_preference('OPACFineNoRenewalsBlockAutoRenew','1');
660	C4::Context->set_preference('OPACFineNoRenewals','10');	660	C4::Context->set_preference('OPACFineNoRenewals','10');
661	my $fines_amount = 5;	661	my $fines_amount = 5;
662	C4::Accounts::manualinvoice( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber}, "Some fines", 'F', $fines_amount );	662	my $account = Koha::Account->new({patron_id => $renewing_borrowernumber});
		663	$account->add_debit(
		664	{
		665	amount => $fines_amount,
		666	type => 'fine',
		667	item_id => $item_to_auto_renew->{itemnumber},
		668	description => "Some fines"
		669	}
		670	)->accounttype->('F')->store;
663	( $renewokay, $error ) =	671	( $renewokay, $error ) =
664	CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );	672	CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
665	is( $renewokay, 0, 'Do not renew, renewal is automatic' );	673	is( $renewokay, 0, 'Do not renew, renewal is automatic' );
666	is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 5' );	674	is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 5' );
667		675
668	C4::Accounts::manualinvoice( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber}, "Some fines", 'F', $fines_amount );	676	$account->add_debit(
		677	{
		678	amount => $fines_amount,
		679	type => 'fine',
		680	item_id => $item_to_auto_renew->{itemnumber},
		681	description => "Some fines"
		682	}
		683	)->accounttype->('F')->store;
669	( $renewokay, $error ) =	684	( $renewokay, $error ) =
670	CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );	685	CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
671	is( $renewokay, 0, 'Do not renew, renewal is automatic' );	686	is( $renewokay, 0, 'Do not renew, renewal is automatic' );
672	is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 10' );	687	is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 10' );
673		688
674	C4::Accounts::manualinvoice( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber}, "Some fines", 'F', $fines_amount );	689	$account->add_debit(
		690	{
		691	amount => $fines_amount,
		692	type => 'fine',
		693	item_id => $item_to_auto_renew->{itemnumber},
		694	description => "Some fines"
		695	}
		696	)->accounttype->('F')->store;
675	( $renewokay, $error ) =	697	( $renewokay, $error ) =
676	CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );	698	CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
677	is( $renewokay, 0, 'Do not renew, renewal is automatic' );	699	is( $renewokay, 0, 'Do not renew, renewal is automatic' );

Lines 22-29 use Test::More tests => 6; Link Here

(-)a/t/db_dependent/Circulation/NoIssuesChargeGuarantees.t (-2 / +3 lines)
22	use t::lib::TestBuilder;	22	use t::lib::TestBuilder;
23	use t::lib::Mocks;	23	use t::lib::Mocks;
24		24
25	use C4::Accounts qw( manualinvoice );
26	use C4::Circulation qw( CanBookBeIssued );	25	use C4::Circulation qw( CanBookBeIssued );
		26	use Koha::Account;
27	use Koha::Account::Lines;	27	use Koha::Account::Lines;
28	use Koha::Account::Offsets;	28	use Koha::Account::Offsets;
29		29
Lines 68-74 t::lib::Mocks::mock_preference( 'AllowFineOverride', '' ); Link Here
68	my ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->{barcode} );	68	my ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->{barcode} );
69	is( $issuingimpossible->{DEBT_GUARANTEES}, undef, "Patron can check out item" );	69	is( $issuingimpossible->{DEBT_GUARANTEES}, undef, "Patron can check out item" );
70		70
71	manualinvoice( $guarantee->{borrowernumber}, undef, undef, 'L', 10.00 );	71	my $account = Koha::Account->new( { patron_id => $guarantee->{borrowernumber} } );
		72	$account->add_debit({ amount => 10.00, type => 'lost_item' });
72	( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->{barcode} );	73	( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->{barcode} );
73	is( $issuingimpossible->{DEBT_GUARANTEES} + 0, '10.00' + 0, "Patron cannot check out item due to debt for guarantee" );	74	is( $issuingimpossible->{DEBT_GUARANTEES} + 0, '10.00' + 0, "Patron cannot check out item due to debt for guarantee" );
74		75