Attachment #86472 for bug #21683

View | Details | Raw Unified | Return to bug 21683
Collapse All | Expand All

Lines 2429-2435 sub _FixAccountForLostAndReturned { Link Here

(-)a/C4/Circulation.pm (-1 / +1 lines)
2429	accounttype => { -in => [ 'L', 'Rep', 'W' ] },	2429	accounttype => { -in => [ 'L', 'Rep', 'W' ] },
2430	},	2430	},
2431	{	2431	{
2432	order_by => { -desc => [ 'date' ] }	2432	order_by => { -desc => [ 'date', 'accountlines_id' ] }
2433	}	2433	}
2434	);	2434	);
2435		2435




        }

        my $sql =
            "DELETE FROM accountlines WHERE accountlines_id = ?";
        $dbh->do( $sql, undef, $f->{'accountlines_id'} );
    }

    if ($has_changed) {
        my $sql =
            "UPDATE accountlines SET amountoutstanding = ? WHERE accountlines_id = ?";
        $dbh->do(
            $sql,                           undef,
            $keeper->{'amountoutstanding'}, $keeper->{'accountlines_id'}

Lines 4-10 use Modern::Perl; Link Here

(-)a/t/db_dependent/Stats.t (-2 / +2 lines)
4	use C4::Stats;	4	use C4::Stats;
5	use Koha::Database;	5	use Koha::Database;
6		6
7	use Test::More tests => 18;	7	use Test::More tests => 19;
8		8
9	BEGIN {	9	BEGIN {
10	use_ok('C4::Stats');	10	use_ok('C4::Stats');
Lines 119-124 is ($params->{other}, $line->{other}, "UpdateStats save other Link Here
119	is ($params->{itemtype}, $line->{itemtype}, "UpdateStats save itemtype param in itemtype field of statistics table");	119	is ($params->{itemtype}, $line->{itemtype}, "UpdateStats save itemtype param in itemtype field of statistics table");
120	is ($params->{location}, $line->{location}, "UpdateStats save location param in location field of statistics table");	120	is ($params->{location}, $line->{location}, "UpdateStats save location param in location field of statistics table");
121	is ($params->{ccode}, $line->{ccode}, "UpdateStats save ccode param in ccode field of statistics table");	121	is ($params->{ccode}, $line->{ccode}, "UpdateStats save ccode param in ccode field of statistics table");
		122	is (undef, $line->{proccode}, "UpdateStats save no proccode param in proccode field of statistics table");
122		123
123	$dbh->do(q\|DELETE FROM statistics\|);	124	$dbh->do(q\|DELETE FROM statistics\|);
124	$params = {	125	$params = {
125	-

Return to bug 21683

Lines 98-110 foreach my $keeper (@$results) { Link Here

(-)a/misc/maintenance/fix_accountlines_rmdupfines_bug8253.pl (-2 / +2 lines)
98	}	98	}
99		99
100	my $sql =	100	my $sql =
101	"DELETE FROM accountlines WHERE accountlines_id = ? LIMIT 1";	101	"DELETE FROM accountlines WHERE accountlines_id = ?";
102	$dbh->do( $sql, undef, $f->{'accountlines_id'} );	102	$dbh->do( $sql, undef, $f->{'accountlines_id'} );
103	}	103	}
104		104
105	if ($has_changed) {	105	if ($has_changed) {
106	my $sql =	106	my $sql =
107	"UPDATE accountlines SET amountoutstanding = ? WHERE accountlines_id = ? LIMIT 1";	107	"UPDATE accountlines SET amountoutstanding = ? WHERE accountlines_id = ?";
108	$dbh->do(	108	$dbh->do(
109	$sql, undef,	109	$sql, undef,
110	$keeper->{'amountoutstanding'}, $keeper->{'accountlines_id'}	110	$keeper->{'amountoutstanding'}, $keeper->{'accountlines_id'}