|
Lines 35-50
t::lib::Mocks::mock_userenv({ branchcode => $library1->{branchcode} });
Link Here
|
| 35 |
|
35 |
|
| 36 |
my $bib_title = "Test Title"; |
36 |
my $bib_title = "Test Title"; |
| 37 |
|
37 |
|
| 38 |
my $borrower1 = $builder->build({ |
38 |
my $patron1 = $builder->build_object({ |
| 39 |
source => 'Borrower', |
39 |
class => 'Koha::Patrons', |
| 40 |
value => { |
40 |
value => { |
| 41 |
branchcode => $library1->{branchcode}, |
41 |
branchcode => $library1->{branchcode}, |
| 42 |
dateexpiry => '3000-01-01', |
42 |
dateexpiry => '3000-01-01', |
| 43 |
} |
43 |
} |
| 44 |
}); |
44 |
}); |
|
|
45 |
my $borrower1 = $patron1->unblessed; |
| 45 |
|
46 |
|
| 46 |
my $borrower2 = $builder->build({ |
47 |
my $patron2 = $builder->build_object({ |
| 47 |
source => 'Borrower', |
48 |
class => 'Koha::Patrons', |
| 48 |
value => { |
49 |
value => { |
| 49 |
branchcode => $library1->{branchcode}, |
50 |
branchcode => $library1->{branchcode}, |
| 50 |
dateexpiry => '3000-01-01', |
51 |
dateexpiry => '3000-01-01', |
|
Lines 53-60
my $borrower2 = $builder->build({
Link Here
|
| 53 |
|
54 |
|
| 54 |
# Test hold_fulfillment_policy |
55 |
# Test hold_fulfillment_policy |
| 55 |
my ( $itemtype ) = @{ $dbh->selectrow_arrayref("SELECT itemtype FROM itemtypes LIMIT 1") }; |
56 |
my ( $itemtype ) = @{ $dbh->selectrow_arrayref("SELECT itemtype FROM itemtypes LIMIT 1") }; |
| 56 |
my $borrowernumber1 = $borrower1->{borrowernumber}; |
|
|
| 57 |
my $borrowernumber2 = $borrower2->{borrowernumber}; |
| 58 |
my $library_A = $library1->{branchcode}; |
57 |
my $library_A = $library1->{branchcode}; |
| 59 |
my $library_B = $library2->{branchcode}; |
58 |
my $library_B = $library2->{branchcode}; |
| 60 |
|
59 |
|
|
Lines 69-95
my $biblioitemnumber =
Link Here
|
| 69 |
$dbh->selectrow_array("SELECT biblioitemnumber FROM biblioitems WHERE biblionumber = $biblionumber") |
68 |
$dbh->selectrow_array("SELECT biblioitemnumber FROM biblioitems WHERE biblionumber = $biblionumber") |
| 70 |
or BAIL_OUT("Cannot find newly created biblioitems record"); |
69 |
or BAIL_OUT("Cannot find newly created biblioitems record"); |
| 71 |
|
70 |
|
| 72 |
$dbh->do(" |
71 |
my $item1 = $builder->build_object({ class => 'Koha::Items', value => { barcode => 'AllowHoldIf1', biblionumber => $biblionumber, biblioitemnumber => $biblioitemnumber, homebranch => $library_A, holdingbranch => $library_A, notforloan => 0, damaged => 0, itemlost => 0, withdrawn => 0, onloan => undef, itype => $itemtype } }); |
| 73 |
INSERT INTO items (barcode, biblionumber, biblioitemnumber, homebranch, holdingbranch, notforloan, damaged, itemlost, withdrawn, onloan, itype) |
|
|
| 74 |
VALUES ('AllowHoldIf1', $biblionumber, $biblioitemnumber, '$library_A', '$library_A', 0, 0, 0, 0, NULL, '$itemtype') |
| 75 |
"); |
| 76 |
|
72 |
|
| 77 |
my $itemnumber1 = |
73 |
my $item2 = $builder->build_object({ class => 'Koha::Items', value => { barcode => 'AllowHoldIf2', biblionumber => $biblionumber, biblioitemnumber => $biblioitemnumber, homebranch => $library_A, holdingbranch => $library_A, notforloan => 0, damaged => 0, itemlost => 0, withdrawn => 0, onloan => undef, itype => $itemtype } }); |
| 78 |
$dbh->selectrow_array("SELECT itemnumber FROM items WHERE biblionumber = $biblionumber") |
|
|
| 79 |
or BAIL_OUT("Cannot find newly created item"); |
| 80 |
|
| 81 |
my $item1 = Koha::Items->find( $itemnumber1 )->unblessed; |
| 82 |
|
| 83 |
$dbh->do(" |
| 84 |
INSERT INTO items (barcode, biblionumber, biblioitemnumber, homebranch, holdingbranch, notforloan, damaged, itemlost, withdrawn, onloan, itype) |
| 85 |
VALUES ('AllowHoldIf2', $biblionumber, $biblioitemnumber, '$library_A', '$library_A', 0, 0, 0, 0, NULL, '$itemtype') |
| 86 |
"); |
| 87 |
|
| 88 |
my $itemnumber2 = |
| 89 |
$dbh->selectrow_array("SELECT itemnumber FROM items WHERE biblionumber = $biblionumber ORDER BY itemnumber DESC") |
| 90 |
or BAIL_OUT("Cannot find newly created item"); |
| 91 |
|
| 92 |
my $item2 = Koha::Items->find( $itemnumber2 )->unblessed; |
| 93 |
|
74 |
|
| 94 |
$dbh->do("DELETE FROM issuingrules"); |
75 |
$dbh->do("DELETE FROM issuingrules"); |
| 95 |
my $rule = Koha::IssuingRule->new( |
76 |
my $rule = Koha::IssuingRule->new( |
|
Lines 105-124
my $rule = Koha::IssuingRule->new(
Link Here
|
| 105 |
); |
86 |
); |
| 106 |
$rule->store(); |
87 |
$rule->store(); |
| 107 |
|
88 |
|
| 108 |
my $is = IsAvailableForItemLevelRequest( $item1, $borrower1); |
89 |
my $is = IsAvailableForItemLevelRequest( $item1, $patron1); |
| 109 |
is( $is, 0, "Item cannot be held, 2 items available" ); |
90 |
is( $is, 0, "Item cannot be held, 2 items available" ); |
| 110 |
|
91 |
|
| 111 |
my $issue1 = AddIssue( $borrower2, $item1->{barcode} ); |
92 |
my $issue1 = AddIssue( $patron2->unblessed, $item1->barcode ); |
| 112 |
|
93 |
|
| 113 |
$is = IsAvailableForItemLevelRequest( $item1, $borrower1); |
94 |
$is = IsAvailableForItemLevelRequest( $item1, $patron1); |
| 114 |
is( $is, 0, "Item cannot be held, 1 item available" ); |
95 |
is( $is, 0, "Item cannot be held, 1 item available" ); |
| 115 |
|
96 |
|
| 116 |
AddIssue( $borrower2, $item2->{barcode} ); |
97 |
AddIssue( $patron2->unblessed, $item2->barcode ); |
| 117 |
|
98 |
|
| 118 |
$is = IsAvailableForItemLevelRequest( $item1, $borrower1); |
99 |
$is = IsAvailableForItemLevelRequest( $item1, $patron1); |
| 119 |
is( $is, 1, "Item can be held, no items available" ); |
100 |
is( $is, 1, "Item can be held, no items available" ); |
| 120 |
|
101 |
|
| 121 |
AddReturn( $item1->{barcode} ); |
102 |
AddReturn( $item1->barcode ); |
| 122 |
|
103 |
|
| 123 |
{ # Remove the issue for the first patron, and modify the branch for item1 |
104 |
{ # Remove the issue for the first patron, and modify the branch for item1 |
| 124 |
subtest 'IsAvailableForItemLevelRequest behaviours depending on ReservesControlBranch + holdallowed' => sub { |
105 |
subtest 'IsAvailableForItemLevelRequest behaviours depending on ReservesControlBranch + holdallowed' => sub { |
|
Lines 132-140
AddReturn( $item1->{barcode} );
Link Here
|
| 132 |
subtest 'Item is available at a different library' => sub { |
113 |
subtest 'Item is available at a different library' => sub { |
| 133 |
plan tests => 4; |
114 |
plan tests => 4; |
| 134 |
|
115 |
|
| 135 |
$item1 = Koha::Items->find( $item1->{itemnumber} ); |
|
|
| 136 |
$item1->set({homebranch => $library_B, holdingbranch => $library_B })->store; |
116 |
$item1->set({homebranch => $library_B, holdingbranch => $library_B })->store; |
| 137 |
$item1 = $item1->unblessed; |
|
|
| 138 |
#Scenario is: |
117 |
#Scenario is: |
| 139 |
#One shelf holds is 'If all unavailable'/2 |
118 |
#One shelf holds is 'If all unavailable'/2 |
| 140 |
#Item 1 homebranch library B is available |
119 |
#Item 1 homebranch library B is available |
|
Lines 148-158
AddReturn( $item1->{barcode} );
Link Here
|
| 148 |
$sth_insert_rule->execute( $hold_allowed_from_home_library ); |
127 |
$sth_insert_rule->execute( $hold_allowed_from_home_library ); |
| 149 |
|
128 |
|
| 150 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary'); |
129 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary'); |
| 151 |
$is = IsAvailableForItemLevelRequest( $item1, $borrower1); |
130 |
$is = IsAvailableForItemLevelRequest( $item1, $patron1); |
| 152 |
is( $is, 1, "Hold allowed from home library + ReservesControlBranch=ItemHomeLibrary, One item is available at different library, not holdable = none available => the hold is allowed at item level" ); |
131 |
is( $is, 1, "Hold allowed from home library + ReservesControlBranch=ItemHomeLibrary, One item is available at different library, not holdable = none available => the hold is allowed at item level" ); |
| 153 |
|
132 |
|
| 154 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary'); |
133 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary'); |
| 155 |
$is = IsAvailableForItemLevelRequest( $item1, $borrower1); |
134 |
$is = IsAvailableForItemLevelRequest( $item1, $patron1); |
| 156 |
is( $is, 1, "Hold allowed from home library + ReservesControlBranch=PatronLibrary, One item is available at different library, not holdable = none available => the hold is allowed at item level" ); |
135 |
is( $is, 1, "Hold allowed from home library + ReservesControlBranch=PatronLibrary, One item is available at different library, not holdable = none available => the hold is allowed at item level" ); |
| 157 |
} |
136 |
} |
| 158 |
|
137 |
|
|
Lines 161-171
AddReturn( $item1->{barcode} );
Link Here
|
| 161 |
$sth_insert_rule->execute( $hold_allowed_from_any_libraries ); |
140 |
$sth_insert_rule->execute( $hold_allowed_from_any_libraries ); |
| 162 |
|
141 |
|
| 163 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary'); |
142 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary'); |
| 164 |
$is = IsAvailableForItemLevelRequest( $item1, $borrower1); |
143 |
$is = IsAvailableForItemLevelRequest( $item1, $patron1); |
| 165 |
is( $is, 0, "Hold allowed from any library + ReservesControlBranch=ItemHomeLibrary, One item is available at the diff library, holdable = 1 available => the hold is not allowed at item level" ); |
144 |
is( $is, 0, "Hold allowed from any library + ReservesControlBranch=ItemHomeLibrary, One item is available at the diff library, holdable = 1 available => the hold is not allowed at item level" ); |
| 166 |
|
145 |
|
| 167 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary'); |
146 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary'); |
| 168 |
$is = IsAvailableForItemLevelRequest( $item1, $borrower1); |
147 |
$is = IsAvailableForItemLevelRequest( $item1, $patron1); |
| 169 |
is( $is, 0, "Hold allowed from any library + ReservesControlBranch=PatronLibrary, One item is available at the diff library, holdable = 1 available => the hold is not allowed at item level" ); |
148 |
is( $is, 0, "Hold allowed from any library + ReservesControlBranch=PatronLibrary, One item is available at the diff library, holdable = 1 available => the hold is not allowed at item level" ); |
| 170 |
} |
149 |
} |
| 171 |
}; |
150 |
}; |
|
Lines 173-181
AddReturn( $item1->{barcode} );
Link Here
|
| 173 |
subtest 'Item is available at the same library' => sub { |
152 |
subtest 'Item is available at the same library' => sub { |
| 174 |
plan tests => 4; |
153 |
plan tests => 4; |
| 175 |
|
154 |
|
| 176 |
$item1 = Koha::Items->find( $item1->{itemnumber} ); |
|
|
| 177 |
$item1->set({homebranch => $library_A, holdingbranch => $library_A })->store; |
155 |
$item1->set({homebranch => $library_A, holdingbranch => $library_A })->store; |
| 178 |
$item1 = $item1->unblessed; |
|
|
| 179 |
#Scenario is: |
156 |
#Scenario is: |
| 180 |
#One shelf holds is 'If all unavailable'/2 |
157 |
#One shelf holds is 'If all unavailable'/2 |
| 181 |
#Item 1 homebranch library A is available |
158 |
#Item 1 homebranch library A is available |
|
Lines 189-199
AddReturn( $item1->{barcode} );
Link Here
|
| 189 |
$sth_insert_rule->execute( $hold_allowed_from_home_library ); |
166 |
$sth_insert_rule->execute( $hold_allowed_from_home_library ); |
| 190 |
|
167 |
|
| 191 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary'); |
168 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary'); |
| 192 |
$is = IsAvailableForItemLevelRequest( $item1, $borrower1); |
169 |
$is = IsAvailableForItemLevelRequest( $item1, $patron1); |
| 193 |
is( $is, 0, "Hold allowed from home library + ReservesControlBranch=ItemHomeLibrary, One item is available at the same library, holdable = 1 available => the hold is not allowed at item level" ); |
170 |
is( $is, 0, "Hold allowed from home library + ReservesControlBranch=ItemHomeLibrary, One item is available at the same library, holdable = 1 available => the hold is not allowed at item level" ); |
| 194 |
|
171 |
|
| 195 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary'); |
172 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary'); |
| 196 |
$is = IsAvailableForItemLevelRequest( $item1, $borrower1); |
173 |
$is = IsAvailableForItemLevelRequest( $item1, $patron1); |
| 197 |
is( $is, 0, "Hold allowed from home library + ReservesControlBranch=PatronLibrary, One item is available at the same library, holdable = 1 available => the hold is not allowed at item level" ); |
174 |
is( $is, 0, "Hold allowed from home library + ReservesControlBranch=PatronLibrary, One item is available at the same library, holdable = 1 available => the hold is not allowed at item level" ); |
| 198 |
} |
175 |
} |
| 199 |
|
176 |
|
|
Lines 202-212
AddReturn( $item1->{barcode} );
Link Here
|
| 202 |
$sth_insert_rule->execute( $hold_allowed_from_any_libraries ); |
179 |
$sth_insert_rule->execute( $hold_allowed_from_any_libraries ); |
| 203 |
|
180 |
|
| 204 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary'); |
181 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary'); |
| 205 |
$is = IsAvailableForItemLevelRequest( $item1, $borrower1); |
182 |
$is = IsAvailableForItemLevelRequest( $item1, $patron1); |
| 206 |
is( $is, 0, "Hold allowed from any library + ReservesControlBranch=ItemHomeLibrary, One item is available at the same library, holdable = 1 available => the hold is not allowed at item level" ); |
183 |
is( $is, 0, "Hold allowed from any library + ReservesControlBranch=ItemHomeLibrary, One item is available at the same library, holdable = 1 available => the hold is not allowed at item level" ); |
| 207 |
|
184 |
|
| 208 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary'); |
185 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'PatronLibrary'); |
| 209 |
$is = IsAvailableForItemLevelRequest( $item1, $borrower1); |
186 |
$is = IsAvailableForItemLevelRequest( $item1, $patron1); |
| 210 |
is( $is, 0, "Hold allowed from any library + ReservesControlBranch=PatronLibrary, One item is available at the same library, holdable = 1 available => the hold is not allowed at item level" ); |
187 |
is( $is, 0, "Hold allowed from any library + ReservesControlBranch=PatronLibrary, One item is available at the same library, holdable = 1 available => the hold is not allowed at item level" ); |
| 211 |
} |
188 |
} |
| 212 |
}; |
189 |
}; |
|
Lines 217-224
my $biblio = $builder->build({
Link Here
|
| 217 |
source => 'Biblio', |
194 |
source => 'Biblio', |
| 218 |
}); |
195 |
}); |
| 219 |
|
196 |
|
| 220 |
my $item3 = $builder->build({ |
197 |
my $item3 = $builder->build_object({ |
| 221 |
source => 'Item', |
198 |
class => 'Koha::Items', |
| 222 |
value => { |
199 |
value => { |
| 223 |
biblionumber => $biblio->{biblionumber}, |
200 |
biblionumber => $biblio->{biblionumber}, |
| 224 |
itemlost => 0, |
201 |
itemlost => 0, |
|
Lines 232-238
my $item3 = $builder->build({
Link Here
|
| 232 |
my $hold = $builder->build({ |
209 |
my $hold = $builder->build({ |
| 233 |
source => 'Reserve', |
210 |
source => 'Reserve', |
| 234 |
value =>{ |
211 |
value =>{ |
| 235 |
itemnumber => $item3->{itemnumber}, |
212 |
itemnumber => $item3->itemnumber, |
| 236 |
found => 'T' |
213 |
found => 'T' |
| 237 |
} |
214 |
} |
| 238 |
}); |
215 |
}); |
|
Lines 251-257
$rule = Koha::IssuingRule->new(
Link Here
|
| 251 |
); |
228 |
); |
| 252 |
$rule->store(); |
229 |
$rule->store(); |
| 253 |
|
230 |
|
| 254 |
$is = IsAvailableForItemLevelRequest( $item3, $borrower1); |
231 |
$is = IsAvailableForItemLevelRequest( $item3, $patron1); |
| 255 |
is( $is, 1, "Item can be held, items in transit are not available" ); |
232 |
is( $is, 1, "Item can be held, items in transit are not available" ); |
| 256 |
|
233 |
|
| 257 |
# Cleanup |
234 |
# Cleanup |