$branchcode  = $patron->{branchcode};

         $branchcode  = $patron->branchcode;

    #Check if the patron catgeory/item type combination is valid

    #Check if the patron category/item type combination is valid

    if ( ($issuingrule->reservesallowed || $issuingrule->holds_per_record) == 0 ) {

    if ( ($issuingrule->reservesallowed == 0 || $issuingrule->holds_per_record == 0 || $issuingrule->holds_per_day == 0 )) {

use Test::More tests => 29;

use Test::More tests => 30;

- 

subtest "check_if_existing_hold_matches_issuingrules tests" => sub {

    plan tests => 9;

    $schema->storage->txn_begin();

    #Create test data

    my $branchcode = $builder->build( { source => 'Branch' } )->{ branchcode };

    my $categorycode1 = $builder->build({ source => 'Category' })->{categorycode};

    my $categorycode2 = $builder->build({ source => 'Category' })->{categorycode};

    my $patron1 = $builder->build({source => 'Borrower', value => { branchcode => $branchcode }});

    my $item1 = $builder->build({ source => 'Item', value => { homebranch => $branchcode }});

    my $item2 = $builder->build({ source => 'Item', value => { homebranch => $branchcode }});

    my $itemtype1 = $item1->{'itype'};

    my $itemtype2 = $item2->{'itype'};

    Koha::IssuingRules->delete;

    #Get branchcode

    my $controlbranch = C4::Context->preference('ReservesControlBranch');

    if ( $controlbranch eq "ItemHomeLibrary" ) {

       $branchcode  = $item->{homebranch};

    }

    elsif ( $controlbranch eq "PatronLibrary" ) {

       $branchcode  = $patron1->{branchcode};

    }

    #Test all cases when the check_return

    #check_if_existing_hold_matches_issuingrules() returns 'InvalidHold' when reservesallowed, holds_per_record and holds_per_day are all 0

    my $rule1 = Koha::IssuingRule->new({

        branchcode =>  $branchcode,

        categorycode => $patron1->{'categorycode'},

        itemtype => $item1->{'itype'},

        reservesallowed => 0,

        holds_per_record => 0,

        holds_per_day => 0,

    })->store;

    my $checkreserve1 = Koha::Hold->check_if_existing_hold_matches_issuingrules($patron1->{'borrowernumber'}, $item1->{'itemnumber'} );

    is( $checkreserve1, 'InvalidHold', 'Allocating item1 to a bib-reserve is not allowed as the issuingrules reservesallowed, holds_per_record and holds_per_day is 0 for this patron category/itemtype combination' );

    #Confirm that when any of the 4 reserves related issuingrules fields (reservesallowed, holds_per_record, holds_per_day) are set to 0 then check_if_existing_hold_matches_issuingrules() returns 'InvalidHold' and so a newly returned item is not allocated to a specific bib-level reserve

    #check_if_existing_hold_matches_issuingrules() returns 'InvalidHold' when reservesallowed is 0 for the patron category/itemtype combination

    $rule1->set({ reservesallowed => 0, holds_per_record => 1, holds_per_day => 1 })->store;

    my $checkreserve2 = Koha::Hold->check_if_existing_hold_matches_issuingrules($patron1->{'borrowernumber'}, $item1->{'itemnumber'} );

    is( $checkreserve2, 'InvalidHold', 'Allocating item1 to a bib-reserve is not allowed as the issuingrules reservesallowed is 0 for this patron category/itemtype combination' );

    #Now change to reservesallowed = 1, holds_per_record = 0, holds_per_day = 1

    $rule1->set({ reservesallowed => 1, holds_per_record => 0, holds_per_day => 1 })->store;

    my $checkreserve3 = Koha::Hold->check_if_existing_hold_matches_issuingrules($patron1->{'borrowernumber'}, $item1->{'itemnumber'} );

    is( $checkreserve3, 'InvalidHold', 'Allocating item1 to a bib-reserve is not allowed as the issuingrules holds_per_record is set to 0 for this patron category/itemtype combination' );

   #Now change to reservesallowed = 1, holds_per_record = 1, holds_per_day = 0

   $rule1->set({ reservesallowed => 1, holds_per_record => 1, holds_per_day => 0 })->store;

   my $checkreserve4 = Koha::Hold->check_if_existing_hold_matches_issuingrules($patron1->{'borrowernumber'}, $item1->{'itemnumber'} );

   is( $checkreserve4, 'InvalidHold', 'Allocating item1 to a bib-reserve is not allowed as the issuingrules holds_per_record is set to0 for this patron category/itemtype combination' );

   #Now change to reservesallowed = 1, holds_per_record = 1, holds_per_day = 1 and confirm 'OK' is returned

   $rule1->set({ reservesallowed => 1, holds_per_record => 1, holds_per_day => 1 })->store;

   my $checkreserve5 = Koha::Hold->check_if_existing_hold_matches_issuingrules($patron1->{'borrowernumber'}, $item1->{'itemnumber'} );

   is( $checkreserve5, 'OK', 'Allocating item2 to a bib-reserve is allowed as there is no specific issuingrule for this patron category/itemtype combination and so we default to the all patron category/all item type rule which allows reserves' );

   #Create a default rule (patron categories: ALL, itemtypes: ALL)

   my $rule3 = Koha::IssuingRule->new({

       branchcode => $branchcode,

       categorycode => '*',

       itemtype => '*',

       reservesallowed => 1,

       holds_per_record => 1,

       holds_per_day => 1,

    })->store;

    #Check that when no specific patron category/item type issuingrule combo exists we revert to using the default ALL categories/ALL

    #itemtypes issuingrule. When generic rule is reservesallowed, holds_per_record and holds_per_day = 1 then 'OK' is returned

    my $checkreserve6 = Koha::Hold->check_if_existing_hold_matches_issuingrules($patron1->{'borrowernumber'}, $item2->{'itemnumber'} );

    is( $checkreserve6, 'OK', 'Allocating item2 to a bib-reserve is allowed as there is no specific issuingrule for this patron category/itemtype combination and so we default to the all patron category/all item type rule which allows reserves' );

    #When default rule is reservesallowed = 0, holds_per_record = 1, holds_per_day = 1 then 'InvalidHold is returned

    $rule3->set({ reservesallowed => 0, holds_per_record => 1, holds_per_day => 1 })->store;

    my $checkreserve7 = Koha::Hold->check_if_existing_hold_matches_issuingrules($patron1->{'borrowernumber'}, $item2->{'itemnumber'} );

    is( $checkreserve7, 'InvalidHold', 'Allocating item2 to a bib-reserve is not allowed as there is no specific issuingrule for this patron category/itemtype combination and so we default to the all patron category/all item type rule which doesnt allows reserves as reservesallowed is 0' );

    #When default rule is reservesallowed = 1, holds_per_record = 0, holds_per_day = 1 then 'InvalidHold' is returned

    $rule3->set({ reservesallowed => 1, holds_per_record => 0, holds_per_day => 1 })->store;

    my $checkreserve8 = Koha::Hold->check_if_existing_hold_matches_issuingrules($patron1->{'borrowernumber'}, $item2->{'itemnumber'} );

    is( $checkreserve8, 'InvalidHold', 'Allocating item2 to a bib-reserve is not allowed as there is no specific issuingrule for this patron category/itemtype combination and so we default to the all patron category/all item type rule which doesnt allows reserves as holds_per_record is 0' );

    #When default rule is reservesallowed = 1, holds_per_record = 1, holds_per_day = 0 then 'InvalidHold' is returned

    $rule3->set({ reservesallowed => 1, holds_per_record => 1, holds_per_day => 0 })->store;

    my $checkreserve9 = Koha::Hold->check_if_existing_hold_matches_issuingrules($patron1->{'borrowernumber'}, $item2->{'itemnumber'} );

    is( $checkreserve9, 'InvalidHold', 'Allocating item2 to a bib-reserve is not allowed as there is no specific issuingrule for this patron category/itemtype combination and so we default to the all patron category/all item type rule which doesnt allows reserves as holds_per_day is 0' );

    $schema->storage->txn_rollback;

};