$needsconfirmation{resreserveid} = $res->{reserve_id};

                    $needsconfirmation{resreserveid} = $res->{reserve_id};

        my $now = dt_from_string();

        my $preventCheckoutOnSameReservePeriod =

            C4::Context->preference("PreventCheckoutOnSameReservePeriod");

        my $reserves_on_same_period =

            ReservesOnSamePeriod($item_object->biblionumber, $item_object->itemnumber, $now->ymd, $duedate->ymd);

        if ($preventCheckoutOnSameReservePeriod && $reserves_on_same_period) {

            my $reserve = $reserves_on_same_period->[0];

            my $patron = Koha::Patrons->find( $reserve->{borrowernumber} );

            my $branchname = Koha::Libraries->find($reserve->{branchcode})->branchname;

            $needsconfirmation{RESERVED} = 1;

            $needsconfirmation{resfirstname} = $patron->firstname;

            $needsconfirmation{ressurname} = $patron->surname;

            $needsconfirmation{rescardnumber} = $patron->cardnumber;

            $needsconfirmation{resborrowernumber} = $patron->borrowernumber;

            $needsconfirmation{resbranchname} = $branchname;

            $needsconfirmation{resreservedate} = $reserve->{reservedate};

            $needsconfirmation{resreserveid} = $reserve->{reserve_id};

        }

    unless ($date_due) {

        my $itemtype = $item->effective_itemtype;

        my $patron_unblessed = $patron->unblessed;

        $date_due = (C4::Context->preference('RenewalPeriodBase') eq 'date_due') ?

                                        dt_from_string( $issue->date_due, 'sql' ) :

                                        DateTime->now( time_zone => C4::Context->tz());

        $date_due =  CalcDateDue($date_due, $itemtype, _GetCircControlBranch($item->unblessed(), $patron_unblessed), $patron_unblessed, 'is a renewal');

    }

    my $now = dt_from_string();

    my $biblionumber = $item->biblionumber;

    my $preventCheckoutOnSameReservePeriod =

        C4::Context->preference("PreventCheckoutOnSameReservePeriod");

    my $reserves_on_same_period =

        ReservesOnSamePeriod($biblionumber, $itemnumber, $now->ymd, $date_due->ymd);

    if ($preventCheckoutOnSameReservePeriod && $reserves_on_same_period) {

        $resfound = 1;

    }

        &ReservesOnSamePeriod

=head2 ReservesOnSamePeriod

    my $reserve = ReservesOnSamePeriod( $biblionumber, $itemnumber, $resdate, $expdate);

    Return the reserve that match the period ($resdate => $expdate),

    undef if no reserve match.

=cut

sub ReservesOnSamePeriod {

    my ($biblionumber, $itemnumber, $resdate, $expdate) = @_;

    unless ($resdate && $expdate) {

        return;

    }

    my @reserves = Koha::Holds->search({ biblionumber => $biblionumber });

    $resdate = output_pref({ str => $resdate, dateonly => 1, dateformat => 'iso' });

    $expdate = output_pref({ str => $expdate, dateonly => 1, dateformat => 'iso' });

    my @reserves_overlaps;

    foreach my $reserve ( @reserves ) {

        unless ($reserve->reservedate && $reserve->expirationdate) {

            next;

        }

        if (date_ranges_overlap($resdate, $expdate,

                                $reserve->reservedate,

                                $reserve->expirationdate)) {

            # If reserve is item level and the requested periods overlap.

            if ($itemnumber && $reserve->itemnumber == $itemnumber ) {

                return [$reserve->unblessed];

            }

            push @reserves_overlaps, $reserve->unblessed;

        }

    }

    if ( @reserves_overlaps >= Koha::Items->search({ biblionumber => $biblionumber })->count() ) {

        return \@reserves_overlaps;

    }

    return;

}

=head2 date_ranges_overlap

    $bool = date_ranges_overlap($start1, $end1, $start2, $end2);

    Tells if first range ($start1 => $end1) overlaps

    the second one ($start2 => $end2)

=cut

sub date_ranges_overlap {

    my ($start1, $end1, $start2, $end2) = @_;

    $start1 = dt_from_string( $start1, 'iso' );

    $end1 = dt_from_string( $end1, 'iso' );

    $start2 = dt_from_string( $start2, 'iso' );

    $end2 = dt_from_string( $end2, 'iso' );

    if (

        # Start of range 2 is in the range 1.

        (

            DateTime->compare($start2, $start1) >= 0

            && DateTime->compare($start2, $end1) <= 0

        )

        ||

        # End of range 2 is in the range 1.

        (

            DateTime->compare($end2, $start1) >= 0

            && DateTime->compare($end2, $end1) <= 0

        )

        ||

        # Range 2 start before and end after range 1.

        (

            DateTime->compare($start2, $start1) < 0

            && DateTime->compare($end2, $end1) > 0

        )

    ) {

        return 1;

    }

    return;

}

            if ( $cancelreserve eq 'cancel' ) {

                CancelReserve({ reserve_id => $query->param('reserveid') });

            }

            $cancelreserve = $cancelreserve eq 'revert' ? 'revert' : undef;

INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) VALUES ('PreventCheckoutOnSameReservePeriod', '0', 'Prevent to checkout a document if a reserve on same period exists', NULL, 'YesNo');

INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) VALUES ('PreventReservesOnSamePeriod', '0', 'Prevent to hold a document if a reserve on same period exists', NULL, 'YesNo');

('PreventCheckoutOnSameReservePeriod','0','','Prevent to checkout a document if a reserve on same period exists','YesNo'),

('PreventReservesOnSamePeriod','0','','Prevent to hold a document if a reserve on same period exists','YesNo'),

        -

            - pref: PreventCheckoutOnSameReservePeriod

              choices:

                  yes: Do

                  no: "Don't"

            - If yes, checkouts periods can't overlap with a reserve period.

        -

            - pref: PreventReservesOnSamePeriod

              choices:

                  yes: Do

                  no: "Don't"

            - If yes, Reserves periods for the same document can't overlap.

                                            <input type="hidden" name="reserveid" value="[% resreserveid | html %]" />

                                            <input type="hidden" name="reserveid" value="[% resreserveid | html %]" />

[% USE JSON.Escape %]

[% USE raw %]

[% INCLUDE 'doc-head-open.inc' %]

    <title>Koha &rsaquo; Circulation &rsaquo; Holds &rsaquo; Confirm holds</title>

[% INCLUDE 'doc-head-close.inc' %]

</head>

<body id="circ_placerequest" class="catalog">

[% INCLUDE 'header.inc' %]

[% INCLUDE 'circ-search.inc' %]

<div id="breadcrumbs">

  <a href="/cgi-bin/koha/mainpage.pl">Home</a>

  ›

  <a href="/cgi-bin/koha/catalogue/search.pl">Catalog</a>

  ›

  Confirm holds

</div>

<div id="doc3" class="yui-t2">

  <div id="bd">

    <div id="yui-main">

      <div class="yui-b">

        <div class="modal fade" tabindex="-1" role="dialog">

          <div class="modal-dialog" role="document">

            <div class="modal-content">

              <div class="modal-header">

                <h4 class="modal-title">Confirm holds</h4>

              </div>

              <div class="modal-body">

                <p>

                  Some of the reserves you are trying to do overlaps with existing reserves.

                  Please tick the box confirming the reservation then click on Confirm if you want to proceed.

                </p>

                <form method="post" id="confirm-holds">

                  <input type="hidden" name="borrowernumber" value="[% borrowernumber | html %]">

                  [% IF multi_hold %]

                    <input type="hidden" name="biblionumbers" value="[% biblionumbers | html %]">

                    <input type="hidden" name="multi_hold" value="1">

                  [% ELSE %]

                    <input type="hidden" name="biblionumber" value="[% biblionumber | html %]">

                  [% END %]

                  <input type="hidden" name="reserve_date" value="[% reserve_date | html %]">

                  <input type="hidden" name="expiration_date" value="[% expiration_date | html %]">

                  <input type="hidden" name="pickup" value="[% pickup | html %]">

                  <input type="hidden" name="notes" value="[% notes | html %]">

                  <input type="hidden" name="confirm" value="1">

                  <input type="hidden" name="type" value="str8">

                  [% FOREACH biblionumber IN overlap_reserves.keys %]

                    [% input_id = "confirm_$biblionumber" %]

                    <div>

                      <input type="hidden" name="rank_[% biblionumber | html %]" value="[% overlap_reserves.$biblionumber.rank | html %]">

                      [% IF (overlap_reserves.$biblionumber.checkitem) %]

                        <input type="hidden" name="checkitem" value="[% overlap_reserves.$biblionumber.checkitem | html %]">

                      [% END %]

                      <input type="checkbox" name="confirm_biblionumbers" id="[% input_id | html %]"

                             value="[% biblionumber | html %]">

                      <label for="[% input_id | html %]">Confirm hold for [% overlap_reserves.$biblionumber.title | html %]</label>

                    </div>

                  [% END %]

                </form>

              </div>

              <div class="modal-footer">

                <button type="button" class="btn btn-default deny" data-dismiss="modal"><i class="fa fa-times"></i> Cancel</button>

                <button type="submit" class="btn btn-default approve" form="confirm-holds"><i class="fa fa-check"></i> Confirm</button>

              </div>

            </div><!-- /.modal-content -->

          </div><!-- /.modal-dialog -->

        </div><!-- /.modal -->

      </div>

    </div>

  </div>

  <script>

    $(document).ready(function () {

      var modal = $('.modal').modal();

      modal.on('hide.bs.modal', function (e) {

        [% IF multi_hold %]

          window.location = '/cgi-bin/koha/reserve/request.pl?biblionumbers=' + [% biblionumbers.json | $raw %] + '&multi_hold=1' + '&borrowernumber=' + [% borrowernumber.json | $raw %];

        [% ELSE %]

          window.location = '/cgi-bin/koha/reserve/request.pl?biblionumber=' + [% biblionumber.json | $raw %] + '&borrowernumber=' + [% borrowernumber.json | $raw %]

        [% END %]

      })

    });

  </script>

[% INCLUDE 'intranet-bottom.inc' %]

        if ($canreserve) {

            if (C4::Context->preference("PreventReservesOnSamePeriod") &&

                ReservesOnSamePeriod($biblioNum, $itemNum, $startdate, $expiration_date)) {

                $canreserve = 0;

                $failed_holds++;

            }

        }

use List::MoreUtils qw( none );

my $confirm        = $input->param('confirm');

my @confirm_biblionumbers = $input->multi_param('confirm_biblionumbers');

    if (C4::Context->preference('PreventReservesOnSamePeriod') && !$confirm) {

        my %overlap_reserves;

        foreach my $biblionumber ( keys %bibinfos ) {

            my $overlapping_reserves = ReservesOnSamePeriod($biblionumber, $checkitem, $startdate, $expirationdate);

            if ($overlapping_reserves && 0 < scalar @$overlapping_reserves) {

                $overlap_reserves{$biblionumber} = {

                    title => $multi_hold ? $bibinfos{$biblionumber}->{title} : $title,

                    checkitem => $checkitem,

                    rank => $multi_hold ? $bibinfos{$biblionumber}->{rank} : $rank[0],

                };

            }

        }

        if (scalar keys %overlap_reserves) {

            $template->param(

                borrowernumber => $borrowernumber,

                biblionumbers => $biblionumbers,

                biblionumber => $biblionumber,

                overlap_reserves => \%overlap_reserves,

                reserve_date => $startdate,

                expiration_date => $expirationdate,

                notes => $notes,

                rank_request => \@rank,

                pickup => $branch,

                multi_hold => $multi_hold,

            );

            output_html_with_http_headers $input, $cookie, $template->output;

            exit;

        }

    }

        next if ($confirm && none { $_ eq $biblionumber } @confirm_biblionumbers);

    t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');

{

    # Don't allow renewing on reserve period with PreventCheckoutOnSameReservePeriod enabled

    t::lib::Mocks::mock_preference( 'PreventCheckoutOnSameReservePeriod', 1 );

    my $start_issue_dt = DateTime->now();

    $start_issue_dt->subtract( days => 15);

    my $due_date = $start_issue_dt->clone;

    $due_date->add( days => 17 );

    my $biblio = $builder->build({

        source => 'Biblio',

    });

    my $biblionumber = $biblio->{biblionumber};

    my $item = $builder->build({

        source => 'Item',

        value => {

            biblionumber => $biblionumber

        }

    });

    my $itemnumber = $item->{itemnumber};

    my $issue = $builder->build({

        source => 'Issue',

        value => {

            itemnumber => $itemnumber,

            biblionumber => $biblionumber,

            issuedate => $start_issue_dt->ymd,

            date_due => $due_date->ymd,

            onsite_checkout => 0

        }

    });

    my $reservedate = $due_date->clone;

    $reservedate->add( days => 5 );

    my $expirationdate = $reservedate->clone;

    $expirationdate->add( days => 15 );

    $builder->build({

        source => 'Reserve',

        value => {

            biblionumber => $biblionumber,

            itemnumber => $itemnumber,

            reservedate => $reservedate->ymd,

            expirationdate => $expirationdate->ymd

        }

    });

    my $requested_date_due = $due_date->clone;

    $requested_date_due->add( days => 4 );

    my ( $renewed, $error ) = CanBookBeRenewed( $issue->{borrowernumber}, $itemnumber, 1, $requested_date_due );

    is( $renewed, 1, 'CanBookBeRenewed should allow to renew if no reserve date overlap' );

    $requested_date_due->add( days => 2 );

    ( $renewed, $error ) = CanBookBeRenewed( $issue->{borrowernumber}, $itemnumber, 1, $requested_date_due );

    is( $renewed, 0, 'CanBookBeRenewed should not allow to renew if reserve date overlap' );

    t::lib::Mocks::mock_preference( 'PreventCheckoutOnSameReservePeriod', 0 );

}

#!/usr/bin/env perl

# This file is part of Koha.

#

# Koha is free software; you can redistribute it and/or modify it

# under the terms of the GNU General Public License as published by

# the Free Software Foundation; either version 3 of the License, or

# (at your option) any later version.

#

# Koha is distributed in the hope that it will be useful, but

# WITHOUT ANY WARRANTY; without even the implied warranty of

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

# GNU General Public License for more details.

#

# You should have received a copy of the GNU General Public License

# along with Koha; if not, see <http://www.gnu.org/licenses>.

use Modern::Perl;

use Test::More tests => 1;

use C4::Members;

use C4::Reserves;

use C4::Circulation;

use Koha::DateUtils;

use t::lib::TestBuilder;

my $schema  = Koha::Database->new->schema;

$schema->storage->txn_begin;

my $builder = t::lib::TestBuilder->new();

subtest 'Tests for CanBookBeIssued with overlap reserves' => sub {

    plan tests => 6;

    my $categorycode = $builder->build({ source => 'Category' })->{ categorycode };

    my $branch = $builder->build({ source => 'Branch' });

    my $branchcode = $branch->{branchcode};

    my $borrower = $builder->build_object({

        class => 'Koha::Patrons',

        value => {

            branchcode   => $branchcode,

            categorycode => $categorycode,

        }

    });

    my $borrowernumber = $borrower->borrowernumber;

    my $biblio = $builder->build({source => 'Biblio'});

    my $biblioitem = $builder->build({

        source => 'Biblioitem',

        value => {

            biblionumber => $biblio->{biblionumber},

        },

    });

    my $item = $builder->build({

        source => 'Item',

        value => {

            biblionumber => $biblio->{biblionumber},

            biblioitemnumber => $biblioitem->{biblioitemnumber},

            withdrawn => 0,

            itemlost => 0,

            notforloan => 0,

        },

    });

    my $startdate = dt_from_string();

    $startdate->add_duration(DateTime::Duration->new(days => 4));

    my $expdate = $startdate->clone();

    $expdate->add_duration(DateTime::Duration->new(days => 10));

    my $reserveid = AddReserve($branchcode, $borrowernumber,

        $item->{biblionumber}, undef,  1, $startdate->ymd(), $expdate->ymd,

        undef, undef, undef, undef);

    my $non_overlap_duedate = dt_from_string();

    $non_overlap_duedate->add_duration(DateTime::Duration->new(days => 2));

    my ($error, $question, $alerts ) =

        CanBookBeIssued($borrower, $item->{barcode}, $non_overlap_duedate, 1, 0);

    is_deeply($error, {}, "");

    is_deeply($question, {}, "");

    is_deeply($alerts, {}, "");

    my $overlap_duedate = dt_from_string();

    $overlap_duedate->add_duration(DateTime::Duration->new(days => 5));

    ($error, $question, $alerts ) =

        CanBookBeIssued($borrower, $item->{barcode}, $overlap_duedate, 1, 0);

    is_deeply($error, {}, "");

    my $expected = {

        RESERVED => 1,

        resfirstname => $borrower->firstname,

        ressurname => $borrower->surname,

        rescardnumber => $borrower->cardnumber,

        resborrowernumber => $borrower->borrowernumber,

        resbranchname => $branch->{branchname},

        resreservedate => $startdate->ymd,

        resreserveid => $reserveid,

    };

    is_deeply($question, $expected, "");

    is_deeply($alerts, {}, "");

};

$schema->storage->txn_rollback;