Attachment #98883 for bug #24657

View | Details | Raw Unified | Return to bug 24657
Collapse All | Expand All

Lines 1055-1063 subtest 'CanItemBeReserved / pickup_not_in_hold_group' => sub { Link Here

(-)a/t/db_dependent/Holds.t (-3 / +3 lines)
1055	my $itemtype2 = $builder->build_object( { class => 'Koha::ItemTypes' } );	1055	my $itemtype2 = $builder->build_object( { class => 'Koha::ItemTypes' } );
1056		1056
1057	# Create libraries	1057	# Create libraries
1058	my $library1 = $builder->build_object( { class => 'Koha::Libraries' } );	1058	my $library1 = $builder->build_object( { class => 'Koha::Libraries' }, value => {pickup_location => 1} );
1059	my $library2 = $builder->build_object( { class => 'Koha::Libraries' } );	1059	my $library2 = $builder->build_object( { class => 'Koha::Libraries' }, value => {pickup_location => 1} );
1060	my $library3 = $builder->build_object( { class => 'Koha::Libraries' } );	1060	my $library3 = $builder->build_object( { class => 'Koha::Libraries' }, value => {pickup_location => 1} );
1061		1061
1062	# Create library groups hierarchy	1062	# Create library groups hierarchy
1063	my $rootgroup = $builder->build_object( { class => 'Koha::Library::Groups', value => {ft_local_hold_group => 1} } );	1063	my $rootgroup = $builder->build_object( { class => 'Koha::Library::Groups', value => {ft_local_hold_group => 1} } );




        }
    );

    my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } );
    my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } );
    my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST1' } } );
    my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST2' } } );
    my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 0, branchcode => 'TEST3' } } );
    my $library4 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST4' } } );
    my $library4 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1 } } );

    my $group1_1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library1->branchcode } } );
    my $group1_2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library2->branchcode } } );


        foreach my $pickup_location (@pl) {
            is( ref($pickup_location), 'Koha::Library', 'Object type is correct' );
        }

        ok(
            scalar(@pl) == $results->{
                    $item->barcode . '-'
- 

Return to bug 24657

Lines 169-182 subtest 'pickup_locations' => sub { Link Here

(-)a/t/db_dependent/Koha/Item.t (-10 / +6 lines)
169	}	169	}
170	);	170	);
171		171
172	my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } );	172	my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } );
173	my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } );	173	my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1, branchcode => undef } } );
174		174	my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST1' } } );
175	my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1 } } );	175	my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST2' } } );
176	my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1 } } );	176	my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 0, branchcode => 'TEST3' } } );
177	my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 0 } } );	177	my $library4 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, branchcode => 'TEST4' } } );
178	my $library4 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1 } } );
179
180	my $group1_1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library1->branchcode } } );	178	my $group1_1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library1->branchcode } } );
181	my $group1_2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library2->branchcode } } );	179	my $group1_2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library2->branchcode } } );
182		180
Lines 289-295 subtest 'pickup_locations' => sub { Link Here
289	foreach my $pickup_location (@pl) {	287	foreach my $pickup_location (@pl) {
290	is( ref($pickup_location), 'Koha::Library', 'Object type is correct' );	288	is( ref($pickup_location), 'Koha::Library', 'Object type is correct' );
291	}	289	}
292
293	ok(	290	ok(
294	scalar(@pl) == $results->{	291	scalar(@pl) == $results->{
295	$item->barcode . '-'	292	$item->barcode . '-'
296	-