Bugzilla – Attachment 10003 Details for
Bug 8176
$sqlwhere is undefined in C4::Serials in GetSubscriptions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8176 [SIGNED-OFF] Assign an intial value to $sqlwhere
Bug-8176-SIGNED-OFF-Assign-an-intial-value-to-sqlw.patch (text/plain), 5.33 KB, created by
Kyle M Hall
on 2012-06-09 10:28:20 UTC
(
hide
)
Description:
Bug 8176 [SIGNED-OFF] Assign an intial value to $sqlwhere
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2012-06-09 10:28:20 UTC
Size:
5.33 KB
patch
obsolete
>From 0db9056904e1bfcb158a323c22f4eb8a2aed7f28 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Fri, 1 Jun 2012 08:10:21 +0100 >Subject: [PATCH] Bug 8176 [SIGNED-OFF] Assign an intial value to $sqlwhere > >warnings in log because of undefined value in >string concatenation >variable should be initialized to empty string rather >than left undefined > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >Removes a warning in logs > >Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> >--- > C4/Serials.pm | 2 +- > .../intranet-tmpl/prog/en/css/staff-global.css | 12 +++++++ > koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 34 ++++++++++++++++--- > 3 files changed, 41 insertions(+), 7 deletions(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index 20ad706..af5c833 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -566,7 +566,7 @@ sub GetSubscriptions { > LEFT JOIN biblioitems ON biblio.biblionumber = biblioitems.biblionumber > ); > my @bind_params; >- my $sqlwhere; >+ my $sqlwhere = q{}; > if ($biblionumber) { > $sqlwhere = " WHERE biblio.biblionumber=?"; > push @bind_params, $biblionumber; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >index e591a73..d2c4884 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >@@ -2210,20 +2210,24 @@ div.pager img {+/* jQuery UI Autocomplete */ > > vertical-align : middle; > } >+ > div.pager img.last { > padding-right: 5px; > } >+ > div.pager input.pagedisplay { > border : 0; > background-color : transparent; > font-weight: bold; > text-align : center; > } >+ > a.localimage img { > border : 1px solid #0000CC; > margin : 0 .5em; > padding : .3em; > } >+ > div.pager p { > margin: 0; > } >@@ -2274,3 +2278,11 @@ ul.ui-autocomplete { > .ui-autocomplete-loading { > background: #FFF url("../../img/loading-small.gif") right center no-repeat; > } >+ >+div.ohloh-table table, td, tr { >+ margin: 100 left; >+ text-align: left; >+ border: 0px solid white; >+ border-left: 30px solid white; >+ border-collapse:collapse; >+} >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >index f4f0def..8a5fa25 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >@@ -30,6 +30,7 @@ > <li><a href="about.pl#licenses">Licenses</a></li> > <li><a href="about.pl#translations">Translations</a></li> > <li><a href="about.pl#history">Koha Timeline</a></li> >+ <li><a href="about.pl#stats">Koha Statistics</a></li> > </ul> > > <div id="about"> >@@ -124,14 +125,14 @@ > <li>Richard Anderson</li> > <li><a href="https://www.ohloh.net/p/koha/contributors/6620692181851">Nahuel Angelinetti</a></li> > <li>Nuño López Ansótegui</li> >- <li>Tomás Cohen Arazi</li> >+ <li>Tomás Cohen Arazi</li> > <li><a href="https://www.ohloh.net/p/koha/contributors/6620692124662">Andrew Arensburger (the small and great C4::Context module)</a></li> > <li>Alex Arnaud</li> > <li><a href="https://www.ohloh.net/p/koha/contributors/6618544614259">Joe Atzberger</a></li> > <li>Larry Baerveldt</li> > <li>Al Banks</li> > <li>Daniel Banzli</li> >- <li>Greg Barniskis</li> >+ <li>Greg Barniskis</li> > <li>Benedykt P. Barszcz (Polish for 2.0)</li> > <li>D Ruth Bavousett</li> > <li>John Beppu</li> >@@ -232,8 +233,8 @@ > <li><a href="https://www.ohloh.net/p/koha/contributors/6618544607803">Andrew Moore</a></li> > <li>Sharon Moreland</li> > <li>Nicolas Morin</li> >- <li>Mike Mylonas</li> >- <li>Joy Nelson</li> >+ <li>Mike Mylonas</li> >+ <li>Joy Nelson</li> > <li><a href="https://www.ohloh.net/accounts/cnighswonger">Chris Nighswonger</a></li> > <li>Albert Oller</li> > <li>Eric Olsen</li> >@@ -292,6 +293,7 @@ > </ul> > <h3>Contributing companies and institutions</h3> > <ul> >+<<<<<<< HEAD > <li>BibLibre, France</li> > <li>Bibliotheksservice-Zentrum Baden-Württemberg (BSZ), Germany</li> > <li>ByWater Solutions, USA</li> >@@ -442,6 +444,26 @@ > </table> > </div> > >- </div> >-</div></div></div> >+ <div id="stats"> >+ <h2><a target="_top" href="http://www.ohloh.net/p/koha">Koha Ohloh Stats</a></h2> >+ >+ <div class="ohloh-table"> >+ <table> >+ <tr> >+ <td> >+ <script type="text/javascript" src="http://www.ohloh.net/p/1541/widgets/project_basic_stats.js"></script> >+ </td> >+ </tr> >+ >+ <tr> >+ <td> >+ <script type="text/javascript" src= >+ "http://www.ohloh.net/p/1541/widgets/project_languages.js"></script> >+ </td> >+ </tr> >+ </table> >+ </div> >+ >+ <p><a href="http://www.ohloh.net"><img src="http://www.ohloh.net/images/badges/mini.gif" width="80" height="15"></a></p> >+</div></div></div></div></div> > [% INCLUDE 'intranet-bottom.inc' %] >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8176
:
9867
|
9872
|
10003