Bugzilla – Attachment 100096 Details for
Bug 22529
/svc/members/search relies on quirks of haspermission
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22529: Use new C4::Auth::haspermission from svc/members/search
Bug-22529-Use-new-C4Authhaspermission-from-svcmemb.patch (text/plain), 1.99 KB, created by
Martin Renvoize (ashimema)
on 2020-03-04 11:18:33 UTC
(
hide
)
Description:
Bug 22529: Use new C4::Auth::haspermission from svc/members/search
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-03-04 11:18:33 UTC
Size:
1.99 KB
patch
obsolete
>From 5dede7d7baf0cf258a1c8668be75234ebff22c9d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 6 May 2019 11:02:03 -0500 >Subject: [PATCH] Bug 22529: Use new C4::Auth::haspermission from > svc/members/search > >The svc/members/search script can be used to retrieve patrons with a >specific permission. This feature is only used once, to link patrons to >funds. >The code in the script is duplicated from what we have in >C4::Auth::haspermission, and it makes sense to clean it. > >Test plan: >Create a fund and add users to this fund. >When you search for users you must only have a list of patrons with the >acquisition.order_manage permission. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Works as described. No errors >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > svc/members/search | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) > >diff --git a/svc/members/search b/svc/members/search >index ae46d334aa..2d739869ee 100755 >--- a/svc/members/search >+++ b/svc/members/search >@@ -91,19 +91,8 @@ if ($has_permission) { > my ( $permission, $subpermission ) = split /\./, $has_permission; > my @patrons_with_permission; > for my $patron ( @{ $results->{patrons} } ) { >- my $perms = haspermission( $patron->{userid}, undef ); >- if ( $perms->{superlibrarian} == 1 >- or $perms->{$permission} == 1 ) >- { >- push @patrons_with_permission, $patron; >- next; >- } >- >- if ($subpermission) { >- my $subperms = get_user_subpermissions( $patron->{userid} ); >- push @patrons_with_permission, $patron >- if $subperms->{$permission}->{$subpermission}; >- } >+ push @patrons_with_permission, $patron >+ if haspermission( $patron->{userid}, { $permission => $subpermission } ); > } > $results->{patrons} = \@patrons_with_permission; > $results->{iTotalDisplayRecords} = scalar( @patrons_with_permission ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22529
:
89372
|
100042
| 100096