Attachment 100097 Details for Bug 24540 – Bug 24540: Prevent add button being triggered on enter

[patch] Bug 24540: Prevent add button being triggered on enter

Bug-24540-Prevent-add-button-being-triggered-on-en.patch (text/plain), 2.56 KB, created by Tomás Cohen Arazi (tcohen) on 2020-03-04 11:57:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-03-04 11:57:52 UTC

Size: 2.56 KB

patch

obsolete

>From f3355f0bede87a90a772f44d31bfe2e4c6671379 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 2 Mar 2020 16:50:17 +0000
>Subject: [PATCH] Bug 24540: Prevent add button being triggered on enter
>
>This patch prevents the add button being triggered by hitting return
>from inside the collected from patron form input.
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>index cb55711d91..6e8bb564f8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
>@@ -55,7 +55,7 @@
>                                     <td>[% invoice.description | html %]</td>
>                                     <td>[% invoice.default_amount | $Price %]</td>
>                                     <td>
>-                                        <button class="add_button" data-invoice-code="[% invoice.code | html %]" data-invoice-title="[% invoice.description | html %]" data-invoice-price="[% invoice.default_amount | html %]"><i class="fa fa-plus"></i> Add</button>
>+                                        <button type="button" class="add_button" data-invoice-code="[% invoice.code | html %]" data-invoice-title="[% invoice.description | html %]" data-invoice-price="[% invoice.default_amount | html %]"><i class="fa fa-plus"></i> Add</button>
>                                     </td>
>                                 </tr>
>                             [% END %]
>@@ -161,7 +161,7 @@
>             </div>
>             <div class="modal-footer">
>                 <button class="btn btn-default approve" id="modal_submit" type="button"><i class="fa fa-check"></i> Yes</button>
>-                <button class="btn btn-default deny cancel" href="#" data-dismiss="modal" aria-hidden="true"><i class="fa fa-times"></i> No</button>
>+                <button class="btn btn-default deny cancel" href="#" data-dismiss="modal" aria-hidden="true" type="button"><i class="fa fa-times"></i> No</button>
>             </div>
>         </div>
>     </div>
>@@ -234,7 +234,7 @@
>         defaultPrice.value,
>         1,
>         null,
>-        '<button class="drop"><i class="fa fa-trash"></i> Remove</button>',
>+        '<button class="drop" type="button"><i class="fa fa-trash"></i> Remove</button>',
>         invoiceCode
>         ]
>       );
>-- 
>2.25.0

Actions: View | Diff | Splinter Review

Attachments on bug 24540: 99951 | 99952 | 100004 | 100097