Bugzilla – Attachment 100160 Details for
Bug 24803
Clicking "Log in to your account" throws fatal Javascript error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24803: [Alternate patch] bypass Bootstrap click handler by using "#"
Bug-24803-Alternate-patch-bypass-Bootstrap-click-h.patch (text/plain), 2.08 KB, created by
Bernardo Gonzalez Kriegel
on 2020-03-05 00:58:09 UTC
(
hide
)
Description:
Bug 24803: [Alternate patch] bypass Bootstrap click handler by using "#"
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2020-03-05 00:58:09 UTC
Size:
2.08 KB
patch
obsolete
>From 781be42fa2a36978ee38afd98670013f464779af Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Wed, 4 Mar 2020 23:56:45 +0000 >Subject: [PATCH] Bug 24803: [Alternate patch] bypass Bootstrap click handler > by using "#" > >This patch bypasses Bootstrap's click.modal.data-api event handler >for the '[data-toggle="modal"] selector by using a "#" as the "href" > >Test plan: >1. Apply patch >2. Open F12 dev tools >3. Click "Log in to your account" on OPAC >4. Observe no Javascript errors in console > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >JS error verified, and corrected. No qa errors. >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >index a27be4d487..79f6c440a5 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >@@ -102,7 +102,7 @@ > [% ELSIF ( Koha.Preference('GoogleOpenIDConnect') == 1 ) %] > <a class="login-link" href="/cgi-bin/koha/svc/auth/googleopenidconnect" role="button" data-toggle="modal"><i class="fa fa-user fa-icon-white fa-fw"></i> <span class="userlabel">Log in to your account</span></a> > [% ELSE %] >- <a href="/cgi-bin/koha/opac-user.pl" class="login-link loginModal-trigger" role="button" data-toggle="modal"><i class="fa fa-user fa-icon-white fa-fw"></i> <span class="userlabel">Log in to your account</span></a> >+ <a href="#" class="login-link loginModal-trigger" role="button" data-toggle="modal"><i class="fa fa-user fa-icon-white fa-fw"></i> <span class="userlabel">Log in to your account</span></a> > [% END %] > [% END %] > [% END %] >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24803
:
100156
|
100157
|
100159
|
100160
|
100191
|
100208
|
100209
|
100217