Attachment 100166 Details for Bug 23531 – Bug 23531: Add some tests for HoldItem and HoldTitle with date params provided

[patch] Bug 23531: Add some tests for HoldItem and HoldTitle with date params provided

Bug-23531-Add-some-tests-for-HoldItem-and-HoldTitl.patch (text/plain), 3.64 KB, created by Arthur Suzuki on 2020-03-05 08:20:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Arthur Suzuki

Created: 2020-03-05 08:20:36 UTC

Size: 3.64 KB

patch

obsolete

>From 165783ec3a0ae037769d3be9b11324543bb7e134 Mon Sep 17 00:00:00 2001
>From: Arthur Suzuki <arthur.suzuki@biblibre.com>
>Date: Sun, 22 Dec 2019 08:07:51 +0100
>Subject: [PATCH] Bug 23531: Add some tests for HoldItem and HoldTitle with
> date params provided
>
>Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
>---
> t/db_dependent/ILSDI_Services.t | 82 ++++++++++++++++++++++++++++++++-
> 1 file changed, 81 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/ILSDI_Services.t b/t/db_dependent/ILSDI_Services.t
>index d102836386..02fe927e71 100644
>--- a/t/db_dependent/ILSDI_Services.t
>+++ b/t/db_dependent/ILSDI_Services.t
>@@ -19,7 +19,7 @@ use Modern::Perl;
> 
> use CGI qw ( -utf8 );
> 
>-use Test::More tests => 7;
>+use Test::More tests => 8;
> use Test::MockModule;
> use t::lib::Mocks;
> use t::lib::TestBuilder;
>@@ -543,6 +543,86 @@ subtest 'Holds test for branch transfer limits' => sub {
>     $schema->storage->txn_rollback;
> };
> 
>+subtest 'Holds test with start_date and end_date' => sub {
>+
>+    plan tests => 8;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $pickup_branch = $builder->build(
>+        {
>+            source => 'Branch',
>+            value  => {
>+                pickup_location => 1,
>+            }
>+        }
>+    );
>+
>+    my $patron = $builder->build({
>+        source => 'Borrower',
>+    });
>+
>+    my $biblio = $builder->build({
>+        source => 'Biblio',
>+    });
>+
>+    my $biblioitems = $builder->build({
>+        source => 'Biblioitem',
>+        value => {
>+            biblionumber => $biblio->{biblionumber},
>+        }
>+    });
>+
>+    my $item = $builder->build({
>+        source => 'Item',
>+        value => {
>+            homebranch => $pickup_branch->{branchcode},
>+            holdingbranch => $pickup_branch->{branchcode},
>+            biblionumber => $biblio->{biblionumber},
>+            damaged => 0,
>+        }
>+    });
>+
>+    Koha::IssuingRules->search()->delete();
>+    my $issuingrule = $builder->build({
>+        source => 'Issuingrule',
>+        value => {
>+            categorycode => '*',
>+            itemtype => '*',
>+            branchcode => '*',
>+            reservesallowed => 99,
>+        }
>+    });
>+
>+    my $query = new CGI;
>+    $query->param( 'pickup_location', $pickup_branch->{branchcode} );
>+    $query->param( 'patron_id', $patron->{borrowernumber});
>+    $query->param( 'bib_id', $biblio->{biblionumber});
>+    $query->param( 'item_id', $item->{itemnumber});
>+    $query->param( 'start_date', '2020-03-20');
>+    $query->param( 'expiry_date', '2020-04-22');
>+
>+    my $reply = C4::ILSDI::Services::HoldItem( $query );
>+    is ($reply->{pickup_location}, $pickup_branch->{branchname}, "Item hold with date parameters was placed");
>+    my $hold = Koha::Holds->search({ biblionumber => $biblio->{biblionumber}})->next();
>+    use Data::Dumper;
>+    print Dumper($hold);
>+    is( $hold->biblionumber, $biblio->{biblionumber}, "correct biblionumber");
>+    is( $hold->reservedate, '2020-03-20', "Item hold has correct start date" );
>+    is( $hold->expirationdate, '2020-04-22', "Item hold has correct end date" );
>+
>+    $hold->delete();
>+
>+    $reply = C4::ILSDI::Services::HoldTitle( $query );
>+    is ($reply->{pickup_location}, $pickup_branch->{branchname}, "Record hold with date parameters was placed");
>+    $hold = Koha::Holds->search({ biblionumber => $biblio->{biblionumber}})->next();
>+    is( $hold->biblionumber, $biblio->{biblionumber}, "correct biblionumber");
>+    is( $hold->reservedate, '2020-03-20', "Record hold has correct start date" );
>+    is( $hold->expirationdate, '2020-04-22', "Record hold has correct end date" );
>+
>+    $schema->storage->txn_rollback;
>+};
>+
> subtest 'GetRecords' => sub {
> 
>     plan tests => 1;
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23531: 92538 | 93475 | 96563 | 96564 | 100165 | 100166 | 100221 | 100222 | 100294 | 100295 | 100895 | 100896 | 100897 | 100898