Attachment 100182 Details for Bug 23051 – Bug 23051: Add RenewAccruingItemWhenPaid syspref

[patch] Bug 23051: Add RenewAccruingItemWhenPaid syspref

Bug-23051-Add-RenewAccruingItemWhenPaid-syspref.patch (text/plain), 3.69 KB, created by Nick Clemens (kidclamp) on 2020-03-05 12:47:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-03-05 12:47:16 UTC

Size: 3.69 KB

patch

obsolete

>From 923f69cddba0ece1d4d09cf3ba4ad2e67c5946bb Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Wed, 5 Jun 2019 14:38:07 +0100
>Subject: [PATCH] Bug 23051: Add RenewAccruingItemWhenPaid syspref
>
>This patch adds the new syspref "RenewAccruingItemWhenPaid"
>
>Signed-off-by: Lucy Harrison <L.M.Harrison@lboro.ac.uk>
>Sponsored-by: Loughborough University
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> .../bug_23051_add_RenewAccruingItemWhenPaid_syspref.perl          | 8 ++++++++
> installer/data/mysql/sysprefs.sql                                 | 1 +
> .../prog/en/modules/admin/preferences/circulation.pref            | 7 +++++++
> 3 files changed, 16 insertions(+)
> create mode 100644 installer/data/mysql/atomicupdate/bug_23051_add_RenewAccruingItemWhenPaid_syspref.perl
>
>diff --git a/installer/data/mysql/atomicupdate/bug_23051_add_RenewAccruingItemWhenPaid_syspref.perl b/installer/data/mysql/atomicupdate/bug_23051_add_RenewAccruingItemWhenPaid_syspref.perl
>new file mode 100644
>index 0000000000..223e244a7b
>--- /dev/null
>+++ b/installer/data/mysql/atomicupdate/bug_23051_add_RenewAccruingItemWhenPaid_syspref.perl
>@@ -0,0 +1,8 @@
>+$DBversion = 'XXX'; # will be replaced by the RM
>+if( CheckVersion( $DBversion ) ) {
>+
>+    $dbh->do( q| INSERT IGNORE INTO systempreferences (variable, value, explanation, options, type) VALUES ('RenewAccruingItemWhenPaid', '0', 'If enabled, when the fines on an item accruing is paid off, attempt to renew that item', '', 'YesNo'); | );
>+
>+    SetVersion( $DBversion );
>+    print "Upgrade to $DBversion done (Bug 23051 - Add RenewAccruingItemWhenPaid syspref)\n";
>+}
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index 40f7a4740f..1946f09108 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -515,6 +515,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('RandomizeHoldsQueueWeight','0',NULL,'if ON, the holds queue in circulation will be randomized, either based on all location codes, or by the location codes specified in StaticHoldsQueueWeight','YesNo'),
> ('RecordLocalUseOnReturn','0',NULL,'If ON, statistically record returns of unissued items as local use, instead of return','YesNo'),
> ('RefundLostOnReturnControl','CheckinLibrary','CheckinLibrary|ItemHomeBranch|ItemHoldingBranch','If a lost item is returned, choose which branch to pick rules for refunding.','Choice'),
>+('RenewAccruingItemWhenPaid','0','','If enabled, when the fines on an item accruing is paid off, attempt to renew that item','YesNo'),
> ('RenewalLog','0','','If ON, log information about renewals','YesNo'),
> ('RenewalPeriodBase','date_due','date_due|now','Set whether the renewal date should be counted from the date_due or from the moment the Patron asks for renewal ','Choice'),
> ('RenewalSendNotice','0','',NULL,'YesNo'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index 1683d9f034..5563af6667 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -488,6 +488,13 @@ Circulation:
>                   no: Allow
>             - their auto renewals.
>         -
>+            - If a patron pays off all fines on an overdue item that is accruing fines
>+            - pref: RenewAccruingItemWhenPaid
>+              choices:
>+                  yes: Renew
>+                  no: "Don't renew"
>+            - the item automatically.
>+        -
>             - pref: ItemsDeniedRenewal
>               type: textarea
>               syntax: text/x-yaml
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23051: 90559 | 90560 | 90561 | 91058 | 91059 | 91060 | 91792 | 91793 | 91794 | 91795 | 92684 | 92685 | 92686 | 92687 | 92688 | 92689 | 93922 | 93923 | 93924 | 93925 | 94020 | 94021 | 94022 | 94023 | 94024 | 94402 | 94434 | 94453 | 94525 | 94604 | 94605 | 94606 | 94607 | 94608 | 94609 | 94610 | 94611 | 94629 | 94649 | 95557 | 95558 | 95559 | 95560 | 100127 | 100128 | 100129 | 100130 | 100131 | 100132 | 100133 | 100134 | 100135 | 100138 | 100172 | 100182 | 100183 | 100184 | 100185 | 100186 | 100187 | 100188 | 100271