Attachment 100188 Details for Bug 23051 – Bug 23051: (follow-up) Remove call to GetFines

[patch] Bug 23051: (follow-up) Remove call to GetFines

Bug-23051-follow-up-Remove-call-to-GetFines.patch (text/plain), 1.21 KB, created by Nick Clemens (kidclamp) on 2020-03-05 12:47:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-03-05 12:47:37 UTC

Size: 1.21 KB

patch

obsolete

>From 8d14965eae738fbbefea51a26e3cfcbe70621600 Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Thu, 5 Mar 2020 10:26:38 +0000
>Subject: [PATCH] Bug 23051: (follow-up) Remove call to GetFines
>
>As mentioned by Nick in comment #69 and subsequently discussed on Slack,
>the call to GetFines in renew_item was unnececcesary. It has now been
>removed.
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> Koha/Account/Line.pm | 9 ---------
> 1 file changed, 9 deletions(-)
>
>diff --git a/Koha/Account/Line.pm b/Koha/Account/Line.pm
>index 8a6f03091a..8f10ac3ace 100644
>--- a/Koha/Account/Line.pm
>+++ b/Koha/Account/Line.pm
>@@ -827,15 +827,6 @@ sub renew_item {
> 
>     my $itemnumber = $self->item->itemnumber;
>     my $borrowernumber = $self->patron->borrowernumber;
>-    # Only do something if this item has no fines left on it
>-    my $fine = C4::Overdues::GetFine($itemnumber, $borrowernumber);
>-    if ($fine && $fine > 0) {
>-        return {
>-            itemnumber => $itemnumber,
>-            error      => 'has_fine',
>-            success    => 0
>-        };
>-    }
>     my ( $can_renew, $error ) = C4::Circulation::CanBookBeRenewed(
>         $borrowernumber,
>         $itemnumber
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 23051: 90559 | 90560 | 90561 | 91058 | 91059 | 91060 | 91792 | 91793 | 91794 | 91795 | 92684 | 92685 | 92686 | 92687 | 92688 | 92689 | 93922 | 93923 | 93924 | 93925 | 94020 | 94021 | 94022 | 94023 | 94024 | 94402 | 94434 | 94453 | 94525 | 94604 | 94605 | 94606 | 94607 | 94608 | 94609 | 94610 | 94611 | 94629 | 94649 | 95557 | 95558 | 95559 | 95560 | 100127 | 100128 | 100129 | 100130 | 100131 | 100132 | 100133 | 100134 | 100135 | 100138 | 100172 | 100182 | 100183 | 100184 | 100185 | 100186 | 100187 | 100188 | 100271