Bugzilla – Attachment 100265 Details for
Bug 24820
The cashup workflow should use the static 'date' field rather than the transient 'timestamp' field in accountlines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24820: Use 'date' instead of 'timestamp' for cashup
Bug-24820-Use-date-instead-of-timestamp-for-cashup.patch (text/plain), 1.09 KB, created by
Martin Renvoize (ashimema)
on 2020-03-06 11:39:59 UTC
(
hide
)
Description:
Bug 24820: Use 'date' instead of 'timestamp' for cashup
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-03-06 11:39:59 UTC
Size:
1.09 KB
patch
obsolete
>From 723dd34c543a53a633063de653c1e81540f4e469 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 6 Mar 2020 11:38:03 +0000 >Subject: [PATCH] Bug 24820: Use 'date' instead of 'timestamp' for cashup > >Prior to this patch we were comparing cash register action timestamp to >accountlines date fields to fetch the list of outstanding accountlines. > >accountlines.date is a transient field used as 'updated_on' and so this >was a logical mistake. We should be using the 'date' field which is >fixed 'created_on' time. >--- > Koha/Cash/Register.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Cash/Register.pm b/Koha/Cash/Register.pm >index ac14db6d6c..1a907063b6 100644 >--- a/Koha/Cash/Register.pm >+++ b/Koha/Cash/Register.pm >@@ -126,7 +126,7 @@ sub outstanding_accountlines { > > my $local_conditions = > $since->count >- ? { 'timestamp' => { '>=' => $since->get_column('timestamp')->as_query } } >+ ? { 'date' => { '>=' => $since->get_column('timestamp')->as_query } } > : {}; > my $merged_conditions = > $conditions >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24820
:
100265
|
102080
|
102465
|
102950
|
102986