Bugzilla – Attachment 100271 Details for
Bug 23051
Add ability to optionally renew fine accruing items when all fines on item are paid off
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23051: (RM follow-up) Fix rebase error
Bug-23051-RM-follow-up-Fix-rebase-error.patch (text/plain), 1.23 KB, created by
Martin Renvoize (ashimema)
on 2020-03-06 13:15:12 UTC
(
hide
)
Description:
Bug 23051: (RM follow-up) Fix rebase error
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-03-06 13:15:12 UTC
Size:
1.23 KB
patch
obsolete
>From 348a04e00f57e15dc3f1ef320c673961b47ca936 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 6 Mar 2020 13:13:37 +0000 >Subject: [PATCH] Bug 23051: (RM follow-up) Fix rebase error > >Looks like at some point during reworking/rebasing the signature for >Koha::Account::Line->apply changed and was then reverted but one case of >the reversion got lost. > >The error was highlighted in the patrons_accounts credit api tests. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/REST/V1/Patrons/Account.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/REST/V1/Patrons/Account.pm b/Koha/REST/V1/Patrons/Account.pm >index aca65dd17e..4dd9ee2bc4 100644 >--- a/Koha/REST/V1/Patrons/Account.pm >+++ b/Koha/REST/V1/Patrons/Account.pm >@@ -130,7 +130,7 @@ sub add_credit { > my $outstanding_credit = $credit->amountoutstanding; > if ($debits) { > # pay them! >- $outstanding_credit = $credit->apply({ debits => [ $debits->as_list ], offset_type => 'payment' })->{outstanding_amount}; >+ $outstanding_credit = $credit->apply({ debits => [ $debits->as_list ], offset_type => 'payment' }); > } > > if ($outstanding_credit) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23051
:
90559
|
90560
|
90561
|
91058
|
91059
|
91060
|
91792
|
91793
|
91794
|
91795
|
92684
|
92685
|
92686
|
92687
|
92688
|
92689
|
93922
|
93923
|
93924
|
93925
|
94020
|
94021
|
94022
|
94023
|
94024
|
94402
|
94434
|
94453
|
94525
|
94604
|
94605
|
94606
|
94607
|
94608
|
94609
|
94610
|
94611
|
94629
|
94649
|
95557
|
95558
|
95559
|
95560
|
100127
|
100128
|
100129
|
100130
|
100131
|
100132
|
100133
|
100134
|
100135
|
100138
|
100172
|
100182
|
100183
|
100184
|
100185
|
100186
|
100187
|
100188
| 100271