Bugzilla – Attachment 100324 Details for
Bug 22943
The in_ipset C4::Auth function name can be confusing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22943: (QA follow-up) Add new cases
Bug-22943-QA-follow-up-Add-new-cases.patch (text/plain), 1.53 KB, created by
Martin Renvoize (ashimema)
on 2020-03-09 09:20:11 UTC
(
hide
)
Description:
Bug 22943: (QA follow-up) Add new cases
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-03-09 09:20:11 UTC
Size:
1.53 KB
patch
obsolete
>From 079074a53feffe660894fbc78360ee4340372a1b Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 9 Mar 2020 09:17:50 +0000 >Subject: [PATCH] Bug 22943: (QA follow-up) Add new cases > >A few additional cases were introduced since the original bug was >authored. This patch simply catches those cases and makes the same >change. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > opac/sco/help.pl | 4 ++-- > opac/sco/printslip.pl | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/opac/sco/help.pl b/opac/sco/help.pl >index 33ff6e7a35..845144558c 100755 >--- a/opac/sco/help.pl >+++ b/opac/sco/help.pl >@@ -24,11 +24,11 @@ > use Modern::Perl; > use CGI qw ( -utf8 ); > >-use C4::Auth qw(get_template_and_user in_ipset); >+use C4::Auth qw(get_template_and_user in_iprange); > use C4::Output qw(output_html_with_http_headers); > > my $query = new CGI; >-unless ( in_ipset(C4::Context->preference('SelfCheckAllowByIPRanges')) ) { >+unless ( in_iprange(C4::Context->preference('SelfCheckAllowByIPRanges')) ) { > print $query->redirect("/cgi-bin/koha/opac-main.pl"); > exit; > } >diff --git a/opac/sco/printslip.pl b/opac/sco/printslip.pl >index d914c288cc..98ded2a5c6 100755 >--- a/opac/sco/printslip.pl >+++ b/opac/sco/printslip.pl >@@ -29,7 +29,7 @@ It is called from sco-main.pl > use Modern::Perl; > use CGI qw ( -utf8 ); > use C4::Context; >-use C4::Auth qw/:DEFAULT get_session in_ipset/; >+use C4::Auth qw/:DEFAULT get_session in_iprange/; > use C4::Output; > use C4::Members; > use C4::Koha; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22943
:
90100
|
100323
|
100324
|
100702
|
100703
|
100704