Bugzilla – Attachment 100328 Details for
Bug 19288
Holds placed on a specific item after a next available hold will show varied results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19288: Don't show patron info for item level holds on details.pl unless hold is waiting
Bug-19288-Dont-show-patron-info-for-item-level-hol.patch (text/plain), 3.15 KB, created by
Martin Renvoize (ashimema)
on 2020-03-09 09:43:47 UTC
(
hide
)
Description:
Bug 19288: Don't show patron info for item level holds on details.pl unless hold is waiting
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-03-09 09:43:47 UTC
Size:
3.15 KB
patch
obsolete
>From 56e0e1b65674020b9c50facaacb7d16f4970162d Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 9 Mar 2020 09:41:26 +0000 >Subject: [PATCH] Bug 19288: Don't show patron info for item level holds on > details.pl unless hold is waiting > >This persists after bug 20948 - we can still display patron information even if this patron is not the one >who will receive the item upon checkin. The holds tab can give an overview of holds and information - I think >on the details page the only info we need is whether there might be a item level hold, not who it is for > >To test: >1 - Place an item level hold for delivery at a branch not matching home branch of item >2 - Place a record level hold for delivery at homebranch of item placed on hold above >3 - Enable LocalHoldsPriority with 'pickup library' matches the item's 'home library' >4 - View the details for the page, it says the item has a hold for the patron with an item level hold >5 - Check in the item, the hold triggered is for the next available patron, ignore the hold >6 - Apply patch >7 - Check details page, 'There is an item-level hold (priority=1)' with no patron info >8 - Check in, next available hold is still the one triggered > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../intranet-tmpl/prog/en/modules/catalogue/detail.tt | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 3fb4b8263d..4ec7d06bb5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -381,15 +381,13 @@ Note that permanent location is a code, and location may be an authval. > [% IF hold %] > [% IF hold.waitingdate %] > Waiting at [% Branches.GetName( hold.branchcode ) | html %] since [% hold.waitingdate | $KohaDates %]. >- [% ELSIF hold.priority == 1 %] >- Item-level hold (placed [% hold.reservedate | $KohaDates %]) for delivery at [% Branches.GetName( hold.branchcode ) | html %]. >- [% ELSE %] >- There is an item level hold on this item (priority = [% hold.priority | html %]). >- [% END %] > [% IF canreservefromotherbranches AND ( hold.waitingdate OR hold.priority == 1 ) %] > Hold for: > [% INCLUDE 'patron-title.inc' patron=hold.borrower hide_patron_infos_if_needed=1 %] > [% END %] >+ [% ELSE %] >+ There is an item level hold on this item (priority = [% hold.priority | html %]). >+ [% END %] > [% END %] > [% UNLESS ( item.itemnotforloan || item.notforloan_per_itemtype || item.onloan || item.itemlost || item.withdrawn || item.damaged || item.transfertwhen || hold ) %] > Available >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19288
:
76099
|
76100
|
89059
|
95898
|
100328
|
100632
|
100633