Bugzilla – Attachment 10038 Details for
Bug 8178
circ/circulation.pl under plack duplicates checkout rows
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-off] Bug 8178 - circ/circulation.pl under plack duplicates checkout rows
Signed-off-Bug-8178---circcirculationpl-under-plac.patch (text/plain), 1.68 KB, created by
Alex Arnaud
on 2012-06-09 15:04:18 UTC
(
hide
)
Description:
[Signed-off] Bug 8178 - circ/circulation.pl under plack duplicates checkout rows
Filename:
MIME Type:
Creator:
Alex Arnaud
Created:
2012-06-09 15:04:18 UTC
Size:
1.68 KB
patch
obsolete
>From 6febde5a81613b6a5f83bacb2ae9f368f230c401 Mon Sep 17 00:00:00 2001 >From: Dobrica Pavlinusic <dpavlin@rot13.org> >Date: Fri, 1 Jun 2012 15:22:30 +0200 >Subject: [PATCH] [Signed-off] Bug 8178 - circ/circulation.pl under plack duplicates checkout rows > >Bug 7851 introduced our scoping for vairables, unfortunatly it has >side-effect that checkout rows accumulate on page reloads instead >of being initialized to empty array (which this patch fixes) > >This also fixes %renew_failed initialization on each request. > >Test scenario: >1. start intranet under plack >2. open /cgi-bin/koha/circ/circulation.pl and reload page few time > confirming that rows gets duplicated >3. apply patch and reload page to verify that it works > >Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> >--- > circ/circulation.pl | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/circ/circulation.pl b/circ/circulation.pl >index c89abff..858bfe5 100755 >--- a/circ/circulation.pl >+++ b/circ/circulation.pl >@@ -94,7 +94,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user ( > my $branches = GetBranches(); > > my @failedrenews = $query->param('failedrenew'); # expected to be itemnumbers >-our %renew_failed; >+our %renew_failed = {}; > for (@failedrenews) { $renew_failed{$_} = 1; } > > my $findborrower = $query->param('findborrower'); >@@ -417,10 +417,10 @@ if ($borrowernumber) { > # make the issued books table. > my $todaysissues = ''; > my $previssues = ''; >-our @todaysissues; >-our @previousissues; >-our @relissues; >-our @relprevissues; >+our @todaysissues = (); >+our @previousissues = (); >+our @relissues = (); >+our @relprevissues = (); > my $displayrelissues; > > our $totalprice = 0; >-- >1.7.4.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8178
:
9877
|
9885
| 10038