Bugzilla – Attachment 100408 Details for
Bug 24052
Koha::XSLT housekeeping for bug 23290 (follow-up)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24052: Catch warning between test 5 and 6
Bug-24052-Catch-warning-between-test-5-and-6.patch (text/plain), 1.49 KB, created by
Owen Leonard
on 2020-03-09 17:40:16 UTC
(
hide
)
Description:
Bug 24052: Catch warning between test 5 and 6
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2020-03-09 17:40:16 UTC
Size:
1.49 KB
patch
obsolete
>From 60c1d44b57257dc8c62b048f6b56e34a94e4b8aa Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 25 Feb 2020 15:09:53 +0000 >Subject: [PATCH] Bug 24052: Catch warning between test 5 and 6 > >Resolve: >ok 5 - Engine returns error on undefined text >XSLT::Base: Empty String at /usr/share/koha/Koha/XSLT/Base.pm line 214. >ok 6 - Engine returns error on empty string > >Test plan: >Run perl Base.t and verify that this warning is no longer printed. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Koha/XSLT/Base.t | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/XSLT/Base.t b/t/db_dependent/Koha/XSLT/Base.t >index cf4bf2ff14b..55f490c6e8a 100644 >--- a/t/db_dependent/Koha/XSLT/Base.t >+++ b/t/db_dependent/Koha/XSLT/Base.t >@@ -20,7 +20,7 @@ > use Modern::Perl; > > use File::Temp qw/tempfile/; >-use Test::More tests => 32; >+use Test::More tests => 33; > use Test::Warn; > > use Koha::XSLT::Base; >@@ -70,7 +70,9 @@ $output = $engine->transform({ xml => undef, code => $xsl_1 }); > is( $engine->err, Koha::XSLT::Base::XSLTH_ERR_7, 'Engine returns error on undefined text' ); > > # Empty string tests >-$output = $engine->transform({ xml => '', code => $xsl_1 }); >+warning_like {$output = $engine->transform({ xml => '', code => $xsl_1 }) } >+ qr/XSLT::Base: Empty String/, >+ 'Empty string warning detected'; > is( $engine->err, Koha::XSLT::Base::XSLTH_ERR_5, 'Engine returns error on empty string' ); > > # Non-XML tests >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24052
:
99686
|
99687
|
99688
|
99689
|
100371
|
100372
|
100373
|
100374
|
100406
|
100407
|
100408
|
100409
|
100453
|
100454
|
100455
|
100456
|
101118
|
101119
|
101120
|
101121