Attachment 100419 Details for Bug 24825 – Bug 24825: Add [% SET footerjs = 1 %] to on pages that lack it

[patch] Bug 24825: Add [% SET footerjs = 1 %] to on pages that lack it

Bug-24825-Add--SET-footerjs--1--to-on-pages-that-l.patch (text/plain), 5.23 KB, created by David Nind on 2020-03-10 04:56:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-03-10 04:56:20 UTC

Size: 5.23 KB

patch

obsolete

>From 21532955a0786ee246c838df5992347bbb8b29d7 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Fri, 6 Mar 2020 23:38:52 +0000
>Subject: [PATCH] Bug 24825: Add [% SET footerjs = 1 %] to on pages that lack
> it
>
>This patch adds the adds the JS Footer to all the pages which lack it:
>TEST PLAN:
>-add this jQuery to IntranetUserJS: $('#logo').hide();
>-load the circulation page, it does not hide the logo.
>-go to any other page on the staff client, the logo is hidden.
>-apply patch
>-load the circulation page, the logo is hidden. Check these other pages to make sure the logo is hidden here to:
>- Tools
>- Tools > Patron card creator
>- Reports
>- Reports > Items with no checkouts
>- Circulation > Set library
>- Circulation > Transfer
>- Circulation > Overdues with fines
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt      | 1 +
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt     | 1 +
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt    | 1 +
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/selectbranchprinter.tt | 1 +
> koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/home.tt         | 3 ++-
> koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt    | 1 +
> koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt     | 1 +
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt         | 1 +
> 8 files changed, 9 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt
>index 37744f6aa4..a299cb4486 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt
>@@ -1,5 +1,6 @@
> [% USE Branches %]
> [% USE Koha %]
>+[% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Circulation &rsaquo; Overdues at [% LoginBranchname | html %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
>index 4859333a3b..aeed4c18e0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
>@@ -1,4 +1,5 @@
> [% USE Koha %]
>+[% SET footerjs = 1 %]
> [% USE Branches %]
> [% USE ItemTypes %]
> [% USE AuthorisedValues %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt
>index b1bac4ae2b..ff96900380 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt
>@@ -1,5 +1,6 @@
> [% USE raw %]
> [% USE Koha %]
>+[% SET footerjs = 1 %]
> [% USE Branches %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Circulation</title>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/selectbranchprinter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/selectbranchprinter.tt
>index f2a65c92ab..60cb692eeb 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/selectbranchprinter.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/selectbranchprinter.tt
>@@ -1,3 +1,4 @@
>+[% SET footerjs = 1 %]
> [% USE Branches %]
> [% USE Koha %]
> [% INCLUDE 'doc-head-open.inc' %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/home.tt
>index a87f5978d0..dca434c375 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/home.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/home.tt
>@@ -1,4 +1,5 @@
>-    [% INCLUDE 'doc-head-open.inc' %]
>+[% SET footerjs = 1 %]
>+[% INCLUDE 'doc-head-open.inc' %]
>     <title>Koha &rsaquo; Tools &rsaquo; Patron card creator</title>
>     [% INCLUDE 'doc-head-close.inc' %]
> </head>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt
>index 92c5ce19ca..ff9eb3bdd0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt
>@@ -1,3 +1,4 @@
>+[% SET footerjs = 1 %]
> [% USE Branches %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Reports &rsaquo; Items with no checkouts</title>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
>index e4901bbd62..dbda86506d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
>@@ -1,4 +1,5 @@
> [% USE Koha %]
>+[% SET footerjs = 1 %]
> [% USE raw %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Reports</title>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
>index 9b2e257326..45267fe8be 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
>@@ -1,4 +1,5 @@
> [% USE Koha %]
>+[% SET footerjs = 1 %]
> 
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Tools</title>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24825: 100302 | 100307 | 100387 | 100419