Attachment 100458 Details for Bug 24812 – Bug 24812: (bug 24081 follow-up) Add permission description

[patch] Bug 24812: (bug 24081 follow-up) Add permission description

Bug-24812-bug-24081-follow-up-Add-permission-descr.patch (text/plain), 1.82 KB, created by Jonathan Druart on 2020-03-10 13:02:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-03-10 13:02:34 UTC

Size: 1.82 KB

patch

obsolete

>From 09dae3f9dd32ec8b34c6964ba4cfec14b40a729c Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 5 Mar 2020 14:32:23 +0000
>Subject: [PATCH] Bug 24812: (bug 24081 follow-up) Add permission description
>
>Bug 24081 added a discount permission to the accounts system but during
>subsequent rebases, the description of that new permission got lot.
>
>This patch restores the description.
>
>Test plan
>0/ Check that a checkbox without a description appears in the 'Manage
>patrons patrons fines and fees' section of the 'Set permissions' page.
>1/ Apply the patch
>2/ Reload the page and note that the checkbox now preceeds a suitable
>description.
>3/ Signoff.
>
>Bonus points: Check the permission works as described and hides the
>'Discount' action button for staff who do not have the permission
>enabled.
>
>Signed-off-by: Michal Denar <black23@gmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
>index affbf0f6f1..d431acdc3c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
>@@ -307,6 +307,11 @@
> Remaining permissions for managing fines and fees
> 
> ([% name | html %])
>+ [%- CASE 'discount' -%]
>+ 
>+ Discount debits for patrons
>+ 
>+ ([% name | html %])
> [%- CASE 'payout' -%]
> 
> Payout credits to patrons
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24812: 100197 | 100198 | 100458